From patchwork Fri Apr 25 19:47:59 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Justin Tee X-Patchwork-Id: 885266 Received: from mail-pf1-f179.google.com (mail-pf1-f179.google.com [209.85.210.179]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1261521660D for ; Fri, 25 Apr 2025 19:24:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.179 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745609079; cv=none; b=Na6FlPneQeQdWSEjqguhPHT4XEThhYyWr2C3g4aVKoWOL3H1IAe7madoOJ+sC8BClukvIsNfohOeTxyfM1Imf58KlHwFPdMfMCE/pNZl+Pi+iuhHerzPvWn63yE1Z/p7TB60FynuyeEFOg5YXkeGCPNw1jW0TmC7M3v+QtmSSJ8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745609079; c=relaxed/simple; bh=VSjs+NIQXig3rOX9vBtYQIOcUazgEsK0FkB8ZZrTFQU=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=tPm4zoNmMxlJ/VqvxY6/IeALel128yRQDr+1rgDGZtYTZEmGb1jMYEnHvDvlgxt9v1z8qlhqNCxhKWedokyzwrCcNZ4zK6fDjbR0CilN9Cc22qzlaWYdgT6a+5hxHId0aqh4w2NVUb7c4+c2NbuFwYp/ZWt9bKlRG/3wZ3tRyik= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=e6eVKQ1V; arc=none smtp.client-ip=209.85.210.179 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="e6eVKQ1V" Received: by mail-pf1-f179.google.com with SMTP id d2e1a72fcca58-73bb647eb23so2349261b3a.0 for ; Fri, 25 Apr 2025 12:24:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1745609077; x=1746213877; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=RYhOYgXaqhkkQemc9451PzSaJeWBkAGYuytmJ0DMpc0=; b=e6eVKQ1VaG72dNAHtMAJJ2uWK9wzzXbTsB1slI/NlgWmw8sI1f1YH8JSS3SgDrhwi7 XRJQT3y4dAHcWherqdgyjty2C8lr0mxBTM5cXRFcb68ARtzH9dV+yan6DYOM6RbjTg+E WBkYojdFprLLtiyLj0Oo0zZHCv99PUOAHYJg41I6LMJC7ADnhXmx509EvaiMyhXMfhuP 3zQOHNsqsw5BkXzTeNwesIbkWF6h7+lK2Cn/6qbP++YzwBwIgpThc6nycH714VLTLgZs +KUbgCvZh2HV6L9oPf2RJtCcy6TfEFu6XjGvLds+pLefNFBE3YGXxPzcHtqzT2044yX+ M2LQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1745609077; x=1746213877; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=RYhOYgXaqhkkQemc9451PzSaJeWBkAGYuytmJ0DMpc0=; b=hg6o2YYmFofLvZvRRKbFF0uaLqaKHYGJT6Y8g/rx+a6/xPJBEUpn8z7wj72dyCVhgX ngxSPYgybjBmbzja2Qe7Mlok0DpmpF0ATJw6fHi19uA6dm5TESXqYF+ysxMiXgapXR5F zDYAnpVHb3uykZKwDCoyV9lJ8gobcAbRrizuphwp7Mgd7QdUOaT58aNXWn8CDxH2jTE7 TDGgkLdQGUQ/8b/+sKHEQnycwL21QKapCYddNbz4OExsdeap3SZNAB3dXqBTYBO+NIjd 26vxx23mNFw7TiDMiD0sPtOsMtWCLCX3137ZoLe7LY2s8XcDbJgBdbHp7qnmRk9r3meL Z8jA== X-Gm-Message-State: AOJu0Yx02oSZ2HdIEg7LYhDW4JHf+2hdDoWeJQ4LTIiQrBVI5pN0/uB3 f6oiy5jRaOelOlI9/B8p2YSev/HuEmYn2EXcBHkRa7BmKTC9f+78xra2aQ== X-Gm-Gg: ASbGncvKjMrXxwPN4kjf2/YLjMmu+TI0tJb/ZZljhELhXLMaL1WeaxXkSEVSq7etJM9 VLZEt0x1QnohhFCBaMu7IxmXZKpXVx5X4LvJ7XByQmtyZJw/sND5ZJsQvqEkZeQErO5IMaVcO41 nTmJjBz23y5tdMjX1Mday/WrhTPMwIzd4dwPIbD6vXtwDhg6VAdLfazxYZZcpw6dV4LdYQVM0jE nBignO85fo/PhOmFiIZPpn0kJJrqG4Ath9iKnoOlIsDIxKim9+fvBeTNyyvWduNUAVm+/BQKB/I hFLzefTj6EPZMqTcq/FmXC3nJ0z0Tm7zMuxay9tTXB9dQKDL6acWBsF9zY4OVeun6mo5t1+KbaW rfsPlC4r3jtQs2G0BM7ej4n0w9g== X-Google-Smtp-Source: AGHT+IEq0EPfO2Dl736f1EqlJGW0i0KBhkUDkxthi1gx5LTcWJlUo3Qo5Ybxv8SP9mIFpGmnxfXiIA== X-Received: by 2002:a05:6a00:2286:b0:739:4a93:a5db with SMTP id d2e1a72fcca58-73ff7396ad8mr752644b3a.22.1745609077231; Fri, 25 Apr 2025 12:24:37 -0700 (PDT) Received: from dhcp-10-231-55-133.dhcp.broadcom.net ([192.19.223.252]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-73e25a6a649sm3667513b3a.109.2025.04.25.12.24.36 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Fri, 25 Apr 2025 12:24:36 -0700 (PDT) From: Justin Tee To: linux-scsi@vger.kernel.org Cc: jsmart2021@gmail.com, justin.tee@broadcom.com, Justin Tee Subject: [PATCH 1/8] lpfc: Fix lpfc_check_sli_ndlp handling for GEN_REQUEST64 commands Date: Fri, 25 Apr 2025 12:47:59 -0700 Message-Id: <20250425194806.3585-2-justintee8345@gmail.com> X-Mailer: git-send-email 2.38.0 In-Reply-To: <20250425194806.3585-1-justintee8345@gmail.com> References: <20250425194806.3585-1-justintee8345@gmail.com> Precedence: bulk X-Mailing-List: linux-scsi@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 In lpfc_check_sli_ndlp, the get_job_els_rsp64_did remote_id assignment does not apply for GEN_REQUEST64 commands as it only has meaning for a ELS_REQUEST64 command. So, if (iocb->ndlp == ndlp) is false, we could erroneously return the wrong value. Fix by replacing the fallthrough statement with a break statement before the remote_id check. Signed-off-by: Justin Tee --- drivers/scsi/lpfc/lpfc_hbadisc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/scsi/lpfc/lpfc_hbadisc.c b/drivers/scsi/lpfc/lpfc_hbadisc.c index 179be6c5a43e..b5273cb1adbd 100644 --- a/drivers/scsi/lpfc/lpfc_hbadisc.c +++ b/drivers/scsi/lpfc/lpfc_hbadisc.c @@ -5053,7 +5053,7 @@ lpfc_check_sli_ndlp(struct lpfc_hba *phba, case CMD_GEN_REQUEST64_CR: if (iocb->ndlp == ndlp) return 1; - fallthrough; + break; case CMD_ELS_REQUEST64_CR: if (remote_id == ndlp->nlp_DID) return 1; From patchwork Fri Apr 25 19:48:00 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Justin Tee X-Patchwork-Id: 884725 Received: from mail-pg1-f179.google.com (mail-pg1-f179.google.com [209.85.215.179]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CA7F521ADA6 for ; Fri, 25 Apr 2025 19:24:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.179 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745609081; cv=none; b=TYisb8qTrQ5ImJ0hB70aQl4AtzK+VdmkVPIV50wcEjPNmsCsZsuYf+IwiG4QHX9le+ewZN7XPtABYc3OzQpA2roTBcmz1IGui8yWopDtLtXD8djMw+mO4YXy2v5Q2nh2rS+s4SMs+UmWJjcz15h+tvKlmpVZvOdHfBOutMvzsuo= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745609081; c=relaxed/simple; bh=cq3Xhf/r6ZPfvd4t32Y/fkPGn2McQMtUSOmw83M0JZ0=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=ngGIIluRlxpaWEpSp24Uv07St2YHBdfJi5FPBiZ+nadNZ6UItwgAM68O5IGU1j4jSqDtXuWpBdsZr4dhJbsvUL66B3cAOa1NmtvFxGvRzuHTXOZVJ9FD3Gk3vehRvRvqozUsXJAvwRJv1wY4azbQXnOQ2Sdokiday1TmcRTtW5c= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=IHlWY+al; arc=none smtp.client-ip=209.85.215.179 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="IHlWY+al" Received: by mail-pg1-f179.google.com with SMTP id 41be03b00d2f7-7fd35b301bdso3329803a12.2 for ; Fri, 25 Apr 2025 12:24:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1745609079; x=1746213879; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=/Xi0k/1jo5Gcy77coU4aLkwrQsZAmNIeCBCbjkf1s24=; b=IHlWY+alVjVlGQxvSQEi3deJ3eLu9LxTLZP0B2jJTbuvZ+z5fpydfra4W6i2Ejf+Yb IuX94LH4kmlV81g/Y1NG3nskl2o/RIuNjmpyXzn7nnFjpKaEGVBcSEnyO8pyYWZD3UJE 349JrYmW1HNbiD2a+aDYN2X/HE2jtOmnmrL/rCHwMgV7hCMIgSTt8Zqg48p7inwCiJjV bGXN1EHPSEWzlFpN4ZSZ0QzwYypAtIr6zJspIodRN5B7z7tp4f4F+QfGkCpt/eUnYJVu Bnb8mB40ncP2VK73morwBxgJEtyWWwz0UAlT0oW1MrRjSzQcF5ZpsuVpvWwTRmDXCwss WBBg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1745609079; x=1746213879; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=/Xi0k/1jo5Gcy77coU4aLkwrQsZAmNIeCBCbjkf1s24=; b=mthHO26XgL3x2mXGfeyw0zxNylo8se7y0E+vBBCWh068v+ho8iC6CvgueowcbDw/3c LK1/L3zUiMaaiD+LiwFPiCqfOtB/LbzBIDDEmftm0ySobemD58SLx/li3bBpzSSxjSNm n2sXSMwDsYNBwTM/i/LHaLR80neGWczH2HxlDK2/ouPGG8+xz9FG+3nCMqjiGTyvi2qL vKfI6C9tyQwr8PisQIZpwfWX+kzwz4TW+nBkkZEo0SknR4dDX4aTzBcnQKLKtj09XN+a DxOc7d9FjuP9/bdIj4gWrHfuNI9ws2Fd3r3SyMH4rPBFJMZyEi8Ph2z7+MmkIPq5+KjP T1Qg== X-Gm-Message-State: AOJu0YxrpIBRcGU/t1KeYqsN5IwdgrP+Lg7zC+ek1q3XyExC2FiDNYZc MxWWqBPsH/IaKdfBs38HGRZk6bnTo5zQg1NxHhjWLtFQOqJAg/s02HD5DQ== X-Gm-Gg: ASbGncuxvthMY+fjlfz0e8kG+ua47SQ14SdpeOz36UkLDkVBbnd7SKjOrIcwc+7uJkB IC1Ium/kG/cjJSCSanAIxCeGPVBFmlctOcy0GKzHsXPQ51T0LcznFIdBR7F1LKeIekb+/sEOT15 1GwO+iyegWdrHEP7pSrwb62Bf6uVNggMQMYfirD0cNzlI9Tjxj6O/D8iBbHMfu+99SICdbnNXHt Qie7P0Px426sfI2qdCjh7h/ESN3MdbtaP+3PDiJUcxQojooz7Vs+tuN7nssp7WXFIsKYBvryG/S Y1UTcI8EnyofSfDcFsPpSTT/Gm+KGb9zVR47Z7ADzEoOoMdFOMgMb1lFwkOspGOCgRtCynO93yO h+KDD5VYAJMeFPLbMGRTUPnfgaA== X-Google-Smtp-Source: AGHT+IHQFbu7Yhra7AOLprOhnDldJoTK7sMcIN0kXlwRNGu9p1HI8Q3QMSkK9iMToperTyFBRoLBKg== X-Received: by 2002:a05:6a21:1515:b0:203:ad33:1ae3 with SMTP id adf61e73a8af0-2046a465ec0mr663041637.10.1745609078784; Fri, 25 Apr 2025 12:24:38 -0700 (PDT) Received: from dhcp-10-231-55-133.dhcp.broadcom.net ([192.19.223.252]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-73e25a6a649sm3667513b3a.109.2025.04.25.12.24.38 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Fri, 25 Apr 2025 12:24:38 -0700 (PDT) From: Justin Tee To: linux-scsi@vger.kernel.org Cc: jsmart2021@gmail.com, justin.tee@broadcom.com, Justin Tee Subject: [PATCH 2/8] lpfc: Notify fc transport of rport disappearance during PCI fcn reset Date: Fri, 25 Apr 2025 12:48:00 -0700 Message-Id: <20250425194806.3585-3-justintee8345@gmail.com> X-Mailer: git-send-email 2.38.0 In-Reply-To: <20250425194806.3585-1-justintee8345@gmail.com> References: <20250425194806.3585-1-justintee8345@gmail.com> Precedence: bulk X-Mailing-List: linux-scsi@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 A PCI function reset implies a temporary disappearance of a fc_rport. So, call lpfc_scsi_dev_block, which sets all mapped fc_rports into the temporary FC_PORTSTATE_BLOCKED state. Once PCI function reset completes and link reinitialized, the fc_rport is rediscovered and FC_PORTSTATE_BLOCKED state is removed. Signed-off-by: Justin Tee --- drivers/scsi/lpfc/lpfc_init.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/scsi/lpfc/lpfc_init.c b/drivers/scsi/lpfc/lpfc_init.c index 90021653e59e..2400602a8561 100644 --- a/drivers/scsi/lpfc/lpfc_init.c +++ b/drivers/scsi/lpfc/lpfc_init.c @@ -1907,6 +1907,9 @@ lpfc_sli4_port_sta_fn_reset(struct lpfc_hba *phba, int mbx_action, uint32_t intr_mode; LPFC_MBOXQ_t *mboxq; + /* Notifying the transport that the targets are going offline. */ + lpfc_scsi_dev_block(phba); + if (bf_get(lpfc_sli_intf_if_type, &phba->sli4_hba.sli_intf) >= LPFC_SLI_INTF_IF_TYPE_2) { /* From patchwork Fri Apr 25 19:48:01 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Justin Tee X-Patchwork-Id: 885265 Received: from mail-pf1-f174.google.com (mail-pf1-f174.google.com [209.85.210.174]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1870B2D78A for ; Fri, 25 Apr 2025 19:24:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.174 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745609082; cv=none; b=ET0MJMDJppoNt1aqkZhMop6oeEDAcpPY9KEnrOw8oHFtF7mL5oSinPDcTSMuQgcxMxedBpLjGuGZivPpJC7rCqut5Ca40j3VN3DchaBbvhup3Mg3jmPSWKoOh96KEcFFFru30tpATY0g2pp6kF/mjyGMS4vt6HAnBTMgSfy3GZo= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745609082; c=relaxed/simple; bh=1vvf2itwTJXKaPDj70/eseYsNtW02QwEwRvoVRybkv4=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version:Content-Type; b=tXJAKszYzjWuB3afl9hsOqT+Q7YyPFK4QHUr1zgG7OMQyxNAa9ECUT8bUxqwZCqeM7wkyNTWDaGq4q8ACyXv/MB3XcPEUHaiZkI+A5YcPc0sHcJNIqljp0ENPOoOUvzh8fZPPMGQA1Domy1PSthAoohy0olqmaEB+uvPDRrt6NA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Di8P4aPS; arc=none smtp.client-ip=209.85.210.174 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Di8P4aPS" Received: by mail-pf1-f174.google.com with SMTP id d2e1a72fcca58-736ab1c43c4so2632152b3a.1 for ; Fri, 25 Apr 2025 12:24:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1745609080; x=1746213880; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=2zdwHaMdXdc0coCr5oJlzKBFV+fIyFUUnEZCNnt/3dQ=; b=Di8P4aPSAlkJcCI8yGii2zqV6yy+MFF1qSOma56f/0E9dXg1puMGMJ0X8E4YEETVOZ /r1YGQDlyDiNj3vJ9WMW95p3VrYxw1l1X103Isp6EieQfXUDlAPRYQK8TkPOLy3XCOTa dOQWbjSrrZoIs7Bhd8PlxOq8r6D46Uuth+rNl5J4f4KEZ8CX5KP2XdEi20OLccC70SKE vYGIJdaQYxnaLdOH3r5luaIyNOG0NzZyIm5WfUeZeJaVCCo1zUOlyIKy/3AFKfdLblzX UyfsI15+4iOG52B3w+GcfDsv5MedQRjXGVUyPDgyf0UMilN6RkR15qUNwPgcX5avMn7T 8ADg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1745609080; x=1746213880; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=2zdwHaMdXdc0coCr5oJlzKBFV+fIyFUUnEZCNnt/3dQ=; b=a9KoZ17sNmR7cR2M90xbB8fHO04dmbPjmV/8dc/th+k6Bv+0726x1bSq1C3cbh1Ozm 16cjEBhvJJC/q1RcEsTB/FQJDRW5Z1ns++HEVkFIUCXvxdF1kuZt/1kzuxWwul/5nb47 B6AZd4tzC1PnKIDlcGuCFKk7/R7FSrXP3Bh1Oou/PhDCUrUBbmBBTgks1wGZlQMEtYxZ CXVT9fpycLhExte6HbCldyLT3kdrt7QOdGfNg2alZmI2TUo+NKge4my91nA07WpD7qje FGvj6Zo5OVG+0hAyxxuErNtUC4OZ0ceO2+YfpPWhOzuysPHlCg2tZTSKyY9uskBAxB/4 3vxQ== X-Gm-Message-State: AOJu0Yx1tlPPsLi2lPhfT7UPhpqpJq8FoT4nlZLn8EihnxnhHJzKa22Y pDec3XtR7TxypiCQCWKNP61wBAE98QvoZZEAUU9L0Obl/k7n0RPVT9e5/w== X-Gm-Gg: ASbGncs/v/PwLoaqb4+HDW/pKoFy+QHKIT92+uN5zisZfQQLe9qEdQT/O+NdOrsHUpe fA+qADTHyJwYG5M01f6cTdHBQih7X9rVgn9ArMA8F+i3TMAdeVEk/c/pecLPPtbVe5CW9XU0+su xir1yQPOS7VnfKc0GJQIhavcXTqvIwVOQbsIEhlBB0AKmleo4Q62OEABKJl59OedznQ8RK/fM7U /qbFnuUUun/t8t51P6TrdDdipkuRrtCIkVlF77RBbtm5hmIIry6w3GneuDNJDqoxzWvUZF2K8DZ cL7OqHERjYbwG0jm2Y3eEV0OPIa1cXSeKlCdf+xwZDYzzdElPFs0x7affM2IZ9vSWhxSlg271Ip yAtyGlh/zvN0fiXm4iFq78dpVhg== X-Google-Smtp-Source: AGHT+IHO9bVmoIiuuHpGwkzXw2KQf41cMoti7Va/NWvMAJsyYPhmlzu88WkTsjswHCnmkFW49KIqBQ== X-Received: by 2002:a05:6a00:b8a:b0:730:9752:d02a with SMTP id d2e1a72fcca58-73ff7255affmr867828b3a.4.1745609080166; Fri, 25 Apr 2025 12:24:40 -0700 (PDT) Received: from dhcp-10-231-55-133.dhcp.broadcom.net ([192.19.223.252]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-73e25a6a649sm3667513b3a.109.2025.04.25.12.24.39 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Fri, 25 Apr 2025 12:24:39 -0700 (PDT) From: Justin Tee To: linux-scsi@vger.kernel.org Cc: jsmart2021@gmail.com, justin.tee@broadcom.com, Justin Tee Subject: [PATCH 3/8] lpfc: Restart eratt_poll timer if HBA_SETUP flag still unset Date: Fri, 25 Apr 2025 12:48:01 -0700 Message-Id: <20250425194806.3585-4-justintee8345@gmail.com> X-Mailer: git-send-email 2.38.0 In-Reply-To: <20250425194806.3585-1-justintee8345@gmail.com> References: <20250425194806.3585-1-justintee8345@gmail.com> Precedence: bulk X-Mailing-List: linux-scsi@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Reschedule the eratt_poll timer if the HBA_SETUP flag isn’t set yet. The eratt_poll timer should only be cancelled if FC_UNLOADING flag is set or if lpfc_stop_hba_timers is called as part of error, reset, or offline handling. Signed-off-by: Justin Tee --- drivers/scsi/lpfc/lpfc_sli.c | 24 +++++++++++++++++------- 1 file changed, 17 insertions(+), 7 deletions(-) diff --git a/drivers/scsi/lpfc/lpfc_sli.c b/drivers/scsi/lpfc/lpfc_sli.c index a335d34070d3..b582728d9e48 100644 --- a/drivers/scsi/lpfc/lpfc_sli.c +++ b/drivers/scsi/lpfc/lpfc_sli.c @@ -3926,12 +3926,19 @@ void lpfc_poll_eratt(struct timer_list *t) uint64_t sli_intr, cnt; phba = from_timer(phba, t, eratt_poll); - if (!test_bit(HBA_SETUP, &phba->hba_flag)) - return; if (test_bit(FC_UNLOADING, &phba->pport->load_flag)) return; + if (phba->sli_rev == LPFC_SLI_REV4 && + !test_bit(HBA_SETUP, &phba->hba_flag)) { + lpfc_printf_log(phba, KERN_INFO, LOG_SLI, + "0663 HBA still initializing 0x%lx, restart " + "timer\n", + phba->hba_flag); + goto restart_timer; + } + /* Here we will also keep track of interrupts per sec of the hba */ sli_intr = phba->sli.slistat.sli_intr; @@ -3950,13 +3957,16 @@ void lpfc_poll_eratt(struct timer_list *t) /* Check chip HA register for error event */ eratt = lpfc_sli_check_eratt(phba); - if (eratt) + if (eratt) { /* Tell the worker thread there is work to do */ lpfc_worker_wake_up(phba); - else - /* Restart the timer for next eratt poll */ - mod_timer(&phba->eratt_poll, - jiffies + secs_to_jiffies(phba->eratt_poll_interval)); + return; + } + +restart_timer: + /* Restart the timer for next eratt poll */ + mod_timer(&phba->eratt_poll, + jiffies + secs_to_jiffies(phba->eratt_poll_interval)); return; } From patchwork Fri Apr 25 19:48:02 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Justin Tee X-Patchwork-Id: 884724 Received: from mail-pg1-f174.google.com (mail-pg1-f174.google.com [209.85.215.174]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6842321ABA3 for ; Fri, 25 Apr 2025 19:24:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.174 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745609083; cv=none; b=GQtcj/oYKUTfjhbWSF47i3QHSTzk0WMuuE7sYbySOH0taTRMSQCxmWVXeBko6esmfLJbSBLeb1Nwxe7M5uMh+NOcCeJMj912th8aM1eaq//VA7vZbCi6i9jjWAw0t3AMmnDPu0t0oD8VId89SsvzWRDjA5xvrxo1JUbCrZc/H1w= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745609083; c=relaxed/simple; bh=qvhsYakX6JgB2wOaL3mli39KS2gONNnAWfe0LGCNydM=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=QZ71sDQmxGXKzSa402MwbIKm1vt5IArE5OR/qvaBAMYuvFDCBCd07ztUUBsYqk92ttjL+RLjL46/sAnE1KZZTkKBneVXXKeOgH4zBKGM7sLcRjLvcRDdUiQG/o7nUCdp7eyfIHvSVoGm2kDaPCtMArHfWA9dinCCYLxODvkRzOw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=KMb6C3Ym; arc=none smtp.client-ip=209.85.215.174 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="KMb6C3Ym" Received: by mail-pg1-f174.google.com with SMTP id 41be03b00d2f7-af28bc68846so2711699a12.1 for ; Fri, 25 Apr 2025 12:24:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1745609081; x=1746213881; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=lwLKbuH1u4DOJ4WgIiHlObhAF3vMim37u5MBOFqmh9E=; b=KMb6C3Ymk+HUdz/02uDMj0DWiwcLBjn/If4wr2Unb7E/uFA5bM+hBGqrtSkwMPt2og mwEHP3W4n6fLT4y8JAsn7A5jB6/fjfWkCCKDkH/YVtKb2GGxXF1hn+cTJzcJ1XmdlDpG pNE8Tn06/61jKaJGqvfQzKSpcfkgZ6ztCP1RNBXzsD7xSKerp8y/qfFb/2vBragCvURt ol4Z7s4seHaEeo9hMh8Uq9pHb46m+Y9v0pcy4m+lN1EbBOme7A4mjKKTtPzuP2/0Huv2 +buPiHJJ60TsBaapGCUOkGTiADkB2jhOsmt0oDZMzmmE4XEgwl8sWo8z/69pgBvMfl0S grlA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1745609081; x=1746213881; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=lwLKbuH1u4DOJ4WgIiHlObhAF3vMim37u5MBOFqmh9E=; b=GkO0+cP0aH2KND5ZWuFadOUvnxwNb9eixyp50Q1OXzQdwiR2Mod4SXM9WmywpKX3N9 AZ9mZZS8gRQV+XrykqVFd/2GRZhkg8MkfK2dv1aaDy12djMmnAkXtpnZBJZFgAEaN1HF FmW8YtsYu4LkaedXhEFaIRNrlTvGdiFpif8Jz65iIdVOwn+OmpvT2c9i8BA3VfduZeG+ 4Kk9ZPDGl4aYmQRg8tr0DLLyraqQlt8CEWRntSJCN8QthDzGM7L60FRUypLfE9n8lv9D Tkdt4qioI9Wj8KmtMyXFvg+lz99+z4J7G0UhzugTePKUlTwb2jfueF61/wP6hUrkIU8E ztAw== X-Gm-Message-State: AOJu0YwriRl27fkXioZO4JZMmCKcpkOL5kPilTJ5VgNdc4w5bfatE98e urWfevyVyaFgdyaq21Lue4LNc9aGYXNkYnROimx3oMGIZ7VpcIWIkt8JOA== X-Gm-Gg: ASbGncsOV0p1/IdXx7YxVz5oGd+LOjNejISwZ9oGI7JvWiJ1zq13Sk165Z0rywG9bmP F+Wh16O3MIst8+fCr43X3NV1oJFLP5zNPrivbNsdF20kCKBxBhs1ogrVPZLwLfGNE9Wrk99ysdm Mxv6Jp97nz37jtPeqLQXA+b7xddzvlGUB/xcgYjbhiRCjNvl56AOpfjKF8g2DgH87xhxjzFuZUH 0hvz/W6cyollkwn1UWERNVFDydULixCrgnvwK94Rv11E0n5VFmzm0a8FsEW+8VYUKemCvtLl8dv XXLkZvGJJb+SG+40DUcH/zgMn9u114ALCqa0WSMTSh7QmS7x62TLh/1Uas8APUVf+BHqG1t26kI /9Eoxm+8Nj2GTAMfOvmzc/C3VUw== X-Google-Smtp-Source: AGHT+IFD/JTewTY6S2RStQw3A/FsuJI9bqCf0p0S9M2cW4MMZtV2k3DG6EgAYKIQhaesYqriuF6hmQ== X-Received: by 2002:a05:6a21:62c2:b0:1f5:8de8:3b27 with SMTP id adf61e73a8af0-2045b6f203amr5696040637.14.1745609081523; Fri, 25 Apr 2025 12:24:41 -0700 (PDT) Received: from dhcp-10-231-55-133.dhcp.broadcom.net ([192.19.223.252]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-73e25a6a649sm3667513b3a.109.2025.04.25.12.24.40 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Fri, 25 Apr 2025 12:24:41 -0700 (PDT) From: Justin Tee To: linux-scsi@vger.kernel.org Cc: jsmart2021@gmail.com, justin.tee@broadcom.com, Justin Tee Subject: [PATCH 4/8] lpfc: Prevent failure to reregister with NVME transport after PRLI retry Date: Fri, 25 Apr 2025 12:48:02 -0700 Message-Id: <20250425194806.3585-5-justintee8345@gmail.com> X-Mailer: git-send-email 2.38.0 In-Reply-To: <20250425194806.3585-1-justintee8345@gmail.com> References: <20250425194806.3585-1-justintee8345@gmail.com> Precedence: bulk X-Mailing-List: linux-scsi@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 A failure to unregister with the NVMe transport may occur when a PRLI is retried. Remove duplicate testing of NLP_NVME_TARGET flag. Add a secondary check of the registered state based on the nrport information. Further qualify the ndlp reference count modification when nvme_fc_register_remoteport returns an error. Signed-off-by: Justin Tee --- drivers/scsi/lpfc/lpfc_hbadisc.c | 4 +--- drivers/scsi/lpfc/lpfc_nvme.c | 8 ++++++-- 2 files changed, 7 insertions(+), 5 deletions(-) diff --git a/drivers/scsi/lpfc/lpfc_hbadisc.c b/drivers/scsi/lpfc/lpfc_hbadisc.c index b5273cb1adbd..9e585af05bec 100644 --- a/drivers/scsi/lpfc/lpfc_hbadisc.c +++ b/drivers/scsi/lpfc/lpfc_hbadisc.c @@ -4695,9 +4695,7 @@ lpfc_nlp_unreg_node(struct lpfc_vport *vport, struct lpfc_nodelist *ndlp) if (ndlp->fc4_xpt_flags & NVME_XPT_REGD) { vport->phba->nport_event_cnt++; if (vport->phba->nvmet_support == 0) { - /* Start devloss if target. */ - if (ndlp->nlp_type & NLP_NVME_TARGET) - lpfc_nvme_unregister_port(vport, ndlp); + lpfc_nvme_unregister_port(vport, ndlp); } else { /* NVMET has no upcall. */ lpfc_nlp_put(ndlp); diff --git a/drivers/scsi/lpfc/lpfc_nvme.c b/drivers/scsi/lpfc/lpfc_nvme.c index b1adb9f59097..9d61e1251a2f 100644 --- a/drivers/scsi/lpfc/lpfc_nvme.c +++ b/drivers/scsi/lpfc/lpfc_nvme.c @@ -2508,7 +2508,10 @@ lpfc_nvme_register_port(struct lpfc_vport *vport, struct lpfc_nodelist *ndlp) "6031 RemotePort Registration failed " "err: %d, DID x%06x ref %u\n", ret, ndlp->nlp_DID, kref_read(&ndlp->kref)); - lpfc_nlp_put(ndlp); + + /* Only release reference if one was taken for this request */ + if (!oldrport) + lpfc_nlp_put(ndlp); } return ret; @@ -2614,7 +2617,8 @@ lpfc_nvme_unregister_port(struct lpfc_vport *vport, struct lpfc_nodelist *ndlp) * clear any rport state until the transport calls back. */ - if (ndlp->nlp_type & NLP_NVME_TARGET) { + if ((ndlp->nlp_type & NLP_NVME_TARGET) || + (remoteport->port_role & FC_PORT_ROLE_NVME_TARGET)) { /* No concern about the role change on the nvme remoteport. * The transport will update it. */ From patchwork Fri Apr 25 19:48:03 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Justin Tee X-Patchwork-Id: 885264 Received: from mail-pg1-f180.google.com (mail-pg1-f180.google.com [209.85.215.180]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A704721ADC5 for ; Fri, 25 Apr 2025 19:24:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.180 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745609085; cv=none; b=RkKCPEnAWhOTxciRuttVe6HV8TTNJ+WKpLJQiFjDVXKadICMUwQeBGuZKbRBK0Xesp+e4QBj83VaCCZBDJicsfd2DVU39rENEWkdH1zyHXMA5/v9z86TRTQhqrcyknkjRTKrF/uKsztvOibr7sGtTL8BDkRI7+0i8PeIkX7bWNE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745609085; c=relaxed/simple; bh=SKcQXw3TEpKg9fS4Jd5h/Yk5CCj25c6HT0/68V7s9mg=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=rgjkSRcRwoUFjEh2BDTctKO0p1jyFTLfa2MqWTvCWq0baNuXw4aM0Qwobf145mjyxc5qwAS7Sst+w2ZBMiDaCf0D6FCVScyvi3nruj0jUrLSyooV9+6T76/F55dBJiJ+wXnbCeoZFjFqQoliIODvDM3bSFthEXMliEyNfbA1Row= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Tyf8RU+S; arc=none smtp.client-ip=209.85.215.180 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Tyf8RU+S" Received: by mail-pg1-f180.google.com with SMTP id 41be03b00d2f7-7fd581c2bf4so2264522a12.3 for ; Fri, 25 Apr 2025 12:24:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1745609083; x=1746213883; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=djBgvnc3DnRXFBZxSetoKim+sDd+gwp3LdwHt7uNBS8=; b=Tyf8RU+SzckETwb/dAsQ5Q1ydub8j/cNCPFW+MgmxkvyDVT354rpenAML08Jf39rzs sWqUiTiGlTuSddBnby/KA99WBcCfnkkrikKtcMI2dRnn+Gu7T0sbERgYbRoRzuEEl8Y9 UnE5aOfPQJWfUr93HHi6aqehWoUwm9NDAXTEpKN5kjxEDGHSxxe75p0g3U/d7ZpdelE9 gXZgOik91b5quXdvH2Htp2AygldNwiEMRacqb0pE3bd32Zr62YR0B2U/iIGtmalp0yTp S0zk2vsH3kLV1rElHH6cfzVSFk65WsATy6dGWt5si+HPpuxJfdZD4KyCZD5ZyqPx2eBQ sAOg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1745609083; x=1746213883; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=djBgvnc3DnRXFBZxSetoKim+sDd+gwp3LdwHt7uNBS8=; b=D8CDGI5xdrGPW6Q1Ju9PAhn27T3W2yI0GrkL+poihj970uE+FNS6DcoybjZvntp4xI aL8LIk+nt+Vqqr2+o2z+33h0N3lfNYwWOey6p7bT7DCjhbbx2XNGE+JUYPFV9UJa4KH0 uNSDOW4ytYxAPmBIDo5DMw8ht8oV41dtS8pE0e1/N5qZgyDXywPh5rmPzyDZKdBXzKen V73Mc3MfRXCVnip2Sh4d3SPCHxSUONDD6wECvN/wrybaeLK3CEPBTqSQjaeY8dM5zcWG l8J9dY03J6L6AoenMIGcRAaD+vv9BcogFv09juLkEPVV47xoAhgmiqeVYa9sOjWTSjKM Bupw== X-Gm-Message-State: AOJu0YyDfF65UPpZC58oQI9SFcPHcFxS5749wZzT0UrmBhNxRK4dISNM B6NFlxwmHthMlRvbfGwyIPl5YEbFahto31GOOJz2rybx3sXlumDPCXeDxA== X-Gm-Gg: ASbGncsXj9gbil76Gwzu2hXrJFBIvA5Gyqn2YvVyh0WXYEKUKN7z9SPNnZQm/UTaHXZ M4Eyc17Ql3kqzZGiDPweUcaRaDv7O10+UD7/1ADzcLJX4XbX5wWHqvuMJ3nAUTE1llDY8rDMdT2 DUIASsqd66tMBYzRhQQgUljVoz/jwAE5uVh7IBwWnZ2YNUpIU2nzSvewio3RCrxMZOJfs3/liDx KdOFEbaoUYPds0d0VE3BIbQ67NEjNoZ4eNAYDNIppyBQ3q0kzBZX0VEdERMIE1rMenthGCiFPod pwed/1jWa8IPzHKgcWNo2sbVHWFyE/XU0NMRJUNa8MP+G4UudUPwW5e2SEN0CcMJWL+BmZJoKPr QC2ajr4eks1AhorccvZvkO2aHsA== X-Google-Smtp-Source: AGHT+IE6ggYd0BY/hFHuOTGSfX0+RkFBzmMB3cLih/6bSlmTvvuJHCw/7zD7IAA2VT1uBT2cnvWimQ== X-Received: by 2002:a05:6a20:d490:b0:1f5:7ba7:69d7 with SMTP id adf61e73a8af0-2045b69735fmr4733394637.3.1745609082870; Fri, 25 Apr 2025 12:24:42 -0700 (PDT) Received: from dhcp-10-231-55-133.dhcp.broadcom.net ([192.19.223.252]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-73e25a6a649sm3667513b3a.109.2025.04.25.12.24.42 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Fri, 25 Apr 2025 12:24:42 -0700 (PDT) From: Justin Tee To: linux-scsi@vger.kernel.org Cc: jsmart2021@gmail.com, justin.tee@broadcom.com, Justin Tee , Dan Carpenter Subject: [PATCH 5/8] lpfc: Avoid potential ndlp use-after-free in dev_loss_tmo_callbk Date: Fri, 25 Apr 2025 12:48:03 -0700 Message-Id: <20250425194806.3585-6-justintee8345@gmail.com> X-Mailer: git-send-email 2.38.0 In-Reply-To: <20250425194806.3585-1-justintee8345@gmail.com> References: <20250425194806.3585-1-justintee8345@gmail.com> Precedence: bulk X-Mailing-List: linux-scsi@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Smatch detected a potential use-after-free of an ndlp oject in dev_loss_tmo_callbk during driver unload or fatal error handling. Fix by reordering code to avoid potential use-after-free if initial nodelist reference has been previously removed. Fixes: 4281f44ea8bf ("scsi: lpfc: Prevent NDLP reference count underflow in dev_loss_tmo callback") Reported-by: Dan Carpenter Closes: https://lore.kernel.org/linux-scsi/41c1d855-9eb5-416f-ac12-8b61929201a3@stanley.mountain/ Signed-off-by: Justin Tee --- drivers/scsi/lpfc/lpfc_hbadisc.c | 32 +++++++++++++++++--------------- 1 file changed, 17 insertions(+), 15 deletions(-) diff --git a/drivers/scsi/lpfc/lpfc_hbadisc.c b/drivers/scsi/lpfc/lpfc_hbadisc.c index 9e585af05bec..3d15a964f5c9 100644 --- a/drivers/scsi/lpfc/lpfc_hbadisc.c +++ b/drivers/scsi/lpfc/lpfc_hbadisc.c @@ -161,7 +161,7 @@ lpfc_dev_loss_tmo_callbk(struct fc_rport *rport) struct lpfc_hba *phba; struct lpfc_work_evt *evtp; unsigned long iflags; - bool nvme_reg = false; + bool drop_initial_node_ref = false; ndlp = ((struct lpfc_rport_data *)rport->dd_data)->pnode; if (!ndlp) @@ -188,8 +188,13 @@ lpfc_dev_loss_tmo_callbk(struct fc_rport *rport) spin_lock_irqsave(&ndlp->lock, iflags); ndlp->rport = NULL; - if (ndlp->fc4_xpt_flags & NVME_XPT_REGD) - nvme_reg = true; + /* Only 1 thread can drop the initial node reference. + * If not registered for NVME and NLP_DROPPED flag is + * clear, remove the initial reference. + */ + if (!(ndlp->fc4_xpt_flags & NVME_XPT_REGD)) + if (!test_and_set_bit(NLP_DROPPED, &ndlp->nlp_flag)) + drop_initial_node_ref = true; /* The scsi_transport is done with the rport so lpfc cannot * call to unregister. @@ -200,13 +205,16 @@ lpfc_dev_loss_tmo_callbk(struct fc_rport *rport) /* If NLP_XPT_REGD was cleared in lpfc_nlp_unreg_node, * unregister calls were made to the scsi and nvme * transports and refcnt was already decremented. Clear - * the NLP_XPT_REGD flag only if the NVME Rport is + * the NLP_XPT_REGD flag only if the NVME nrport is * confirmed unregistered. */ - if (!nvme_reg && ndlp->fc4_xpt_flags & NLP_XPT_REGD) { - ndlp->fc4_xpt_flags &= ~NLP_XPT_REGD; + if (ndlp->fc4_xpt_flags & NLP_XPT_REGD) { + if (!(ndlp->fc4_xpt_flags & NVME_XPT_REGD)) + ndlp->fc4_xpt_flags &= ~NLP_XPT_REGD; spin_unlock_irqrestore(&ndlp->lock, iflags); - lpfc_nlp_put(ndlp); /* may free ndlp */ + + /* Release scsi transport reference */ + lpfc_nlp_put(ndlp); } else { spin_unlock_irqrestore(&ndlp->lock, iflags); } @@ -214,14 +222,8 @@ lpfc_dev_loss_tmo_callbk(struct fc_rport *rport) spin_unlock_irqrestore(&ndlp->lock, iflags); } - /* Only 1 thread can drop the initial node reference. If - * another thread has set NLP_DROPPED, this thread is done. - */ - if (nvme_reg || test_bit(NLP_DROPPED, &ndlp->nlp_flag)) - return; - - set_bit(NLP_DROPPED, &ndlp->nlp_flag); - lpfc_nlp_put(ndlp); + if (drop_initial_node_ref) + lpfc_nlp_put(ndlp); return; } From patchwork Fri Apr 25 19:48:04 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Justin Tee X-Patchwork-Id: 884723 Received: from mail-pf1-f169.google.com (mail-pf1-f169.google.com [209.85.210.169]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 101612192E4 for ; Fri, 25 Apr 2025 19:24:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.169 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745609086; cv=none; b=WurPyreOF8aotiwGGRiPKN7kttfSFV82Dr2cE2ojl47dKPLu/bgK81J4thANMUxLCGLPxIgkvbetAcDun5nxFxusmTafK786DiMZ+75rmALkjK9kwNShpt8sIG/vEEQu/9+8IZqjRXSJpyXApuRvRxa4i2JreGCczNclB42Cyfs= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745609086; c=relaxed/simple; bh=CRm4p7LF+pCg6J2N9r6mrSVhXUNB0AGvOgRTApIlemA=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=WzaMsDOYDXqAoEF28UBDWoUBBoewFK1CyT9XksTOKZGBmxjOhSxhKI0W23Dd7Cisw5ZY4zAJa0LWroGCWV90UUEm6kuK4JKLt10wJVjXafAZgfF3SM7WbptgYZCpUZuvfPVMNnBiqH2R3S6WQmFdKIc7S09ry3c1TWnyxeCiNX8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=f75tO6U+; arc=none smtp.client-ip=209.85.210.169 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="f75tO6U+" Received: by mail-pf1-f169.google.com with SMTP id d2e1a72fcca58-7394945d37eso2375379b3a.3 for ; Fri, 25 Apr 2025 12:24:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1745609084; x=1746213884; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=KTKGkVCgnaqhLDMH0uVOvq4krRkqQK8k2phVHceZtBU=; b=f75tO6U+UjxXFsef+BjTXEIp5Cg6eg0UKYggPkSIam2RL5kC0ZJCjvZGQrpoip5BYa nMyj+1eYL/mo9g1TxfEmObPgL8K+ewp4+7zDrXuTDyxlw8+5Cy7z17a1YvjKwGhu4AiX 9eD+1/TSDkORrX+uAfXhOjeHObFU0zY/Gbwhqp9Jt7O6xBA6ud98dWdrX97Uu/CbasWc eW8SKn5hq+W+SkekEv+yukLOvH7Ck6yBIAlTwyztpMMGQZNeJ9z7bE8zis2y0oW5WA9l AZpqy0rgb3rZZXv8RucxfNXF3xkClfU2TP3r3EQBTaEvvwLM+ssJjAs1ua4ZMF/dfGsX 51dA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1745609084; x=1746213884; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=KTKGkVCgnaqhLDMH0uVOvq4krRkqQK8k2phVHceZtBU=; b=d/L6RgY7Ck0nSTJ99hKCBbp2m1tMaqyx3qLZH581D6Vp348JCTpnEG2lvSDA4hiLLG tBpQo5UgWk9xhmSeLk/55U4tnVWUTar2dvasthl255hM/K+UoyKUWmVuBSJ3OzpVEI/5 bytbowC7AVitOv5AmoVmVVQGNoBTPI+WRG4g2o3y9CQh6zF0Fcg/O7RhvBnWtUm/cITy PiWO1xFsrkWhiYO3a9jINeBRUZdOo8Tpevmbs40M29XDOnrIRW84fim7+2SrtbEcrd0Z AITPmVuDa0CpKbsK2QgA9byOJbNSwnHUHv5vV0c/aKGXgvRD0H9ZzXdXfZc9bRpv3plP ANOw== X-Gm-Message-State: AOJu0Yzv+3zEG5fbGqzsuX70kwl6rR5KqbXVghk0ptkK1VEIuDOU0xTR VkjjDcwJmXLFiWtNCE8r4yMn6qnn2uO1OPmjQdMMHrjMg+UHRNUhHXQSUQ== X-Gm-Gg: ASbGnctVD6et/dhFm/TqBSbacGyoELqg+QnkMoWRaEoRRmTtt3ZWIFrZ/ILHePbS1yZ JA9MU9rDDx2wpSZ08+xGf0l/91z21X39/JXCbAPZWI+IC3q1d71h0ooEamrHgx4+VTlLztro4N5 w1CPODuDFbtGrC1V0aVSdjkG/FMgiwQiWeIvTHCUwghdkcrsvvsSkOK82ryHGQRJWt69M8rBLyh ZsxbpjwfJZywG5LjMC92Ee3dFkS6BM1+FljU/9HWx9Upnjsf0kpONv4m+ReMKTIWJHiwbUH1GSt VxL9mb3a9quABfjqzQiqaUy8/U6qfxbKz1IODBItKyF4X+SE8aUcmCxY+U6b6ipl30TO91Hd5cz kvMAkk6YFMubOU0r7QnNSJqNe8B6MdhM6bzmF X-Google-Smtp-Source: AGHT+IEUoDmzA3+rKhXHNBt+nPcTZUu4DNc0yc6D5lApgpy/r1HNezPv6b+ld1CSQzp8ewVVlTMY4Q== X-Received: by 2002:a05:6a00:3d4c:b0:73e:96f:d4c1 with SMTP id d2e1a72fcca58-73ff72e40a1mr889411b3a.13.1745609084186; Fri, 25 Apr 2025 12:24:44 -0700 (PDT) Received: from dhcp-10-231-55-133.dhcp.broadcom.net ([192.19.223.252]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-73e25a6a649sm3667513b3a.109.2025.04.25.12.24.43 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Fri, 25 Apr 2025 12:24:43 -0700 (PDT) From: Justin Tee To: linux-scsi@vger.kernel.org Cc: jsmart2021@gmail.com, justin.tee@broadcom.com, Justin Tee Subject: [PATCH 6/8] lpfc: Create lpfc_vmid_info sysfs entry Date: Fri, 25 Apr 2025 12:48:04 -0700 Message-Id: <20250425194806.3585-7-justintee8345@gmail.com> X-Mailer: git-send-email 2.38.0 In-Reply-To: <20250425194806.3585-1-justintee8345@gmail.com> References: <20250425194806.3585-1-justintee8345@gmail.com> Precedence: bulk X-Mailing-List: linux-scsi@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 A vmid_info sysfs entry is created as a convenience designed for users to obtain VMID information without having to log into fabrics for similar info. Signed-off-by: Justin Tee --- drivers/scsi/lpfc/lpfc_attr.c | 134 ++++++++++++++++++++++++++++++++++ 1 file changed, 134 insertions(+) diff --git a/drivers/scsi/lpfc/lpfc_attr.c b/drivers/scsi/lpfc/lpfc_attr.c index 397216ff2c7e..efd02c464549 100644 --- a/drivers/scsi/lpfc/lpfc_attr.c +++ b/drivers/scsi/lpfc/lpfc_attr.c @@ -291,6 +291,138 @@ lpfc_cmf_info_show(struct device *dev, struct device_attribute *attr, return len; } +static ssize_t +lpfc_vmid_info_show(struct device *dev, struct device_attribute *attr, + char *buf) +{ + struct Scsi_Host *shost = class_to_shost(dev); + struct lpfc_vport *vport = (struct lpfc_vport *)shost->hostdata; + struct lpfc_hba *phba = vport->phba; + struct lpfc_vmid *vmp; + int len = 0, i, j, k, cpu; + char hxstr[LPFC_MAX_VMID_SIZE * 3] = {0}; + struct timespec64 curr_tm; + struct lpfc_vmid_priority_range *vr; + u64 *lta, rct_acc = 0, max_lta = 0; + struct tm tm_val; + + ktime_get_ts64(&curr_tm); + + len += scnprintf(buf + len, PAGE_SIZE - len, "Key 'vmid':\n"); + + /* if enabled continue, else return */ + if (lpfc_is_vmid_enabled(phba)) { + len += scnprintf(buf + len, PAGE_SIZE - len, + "lpfc VMID Page: ON\n\n"); + } else { + len += scnprintf(buf + len, PAGE_SIZE - len, + "lpfc VMID Page: OFF\n\n"); + return len; + } + + /* if using priority tagging */ + if (vport->phba->pport->vmid_flag & LPFC_VMID_TYPE_PRIO) { + len += scnprintf(buf + len, PAGE_SIZE - len, + "VMID priority ranges:\n"); + vr = vport->vmid_priority.vmid_range; + for (i = 0; i < vport->vmid_priority.num_descriptors; ++i) { + len += scnprintf(buf + len, PAGE_SIZE - len, + "\t[x%x - x%x], qos: x%x\n", + vr->low, vr->high, vr->qos); + vr++; + } + } + + for (i = 0; i < phba->cfg_max_vmid; i++) { + vmp = &vport->vmid[i]; + max_lta = 0; + + /* only if the slot is used */ + if (!(vmp->flag & LPFC_VMID_SLOT_USED) || + !(vmp->flag & LPFC_VMID_REGISTERED)) + continue; + + /* if using priority tagging */ + if (vport->phba->pport->vmid_flag & LPFC_VMID_TYPE_PRIO) { + len += scnprintf(buf + len, PAGE_SIZE - len, + "VEM ID: %02x:%02x:%02x:%02x:" + "%02x:%02x:%02x:%02x:%02x:%02x:" + "%02x:%02x:%02x:%02x:%02x:%02x\n", + vport->lpfc_vmid_host_uuid[0], + vport->lpfc_vmid_host_uuid[1], + vport->lpfc_vmid_host_uuid[2], + vport->lpfc_vmid_host_uuid[3], + vport->lpfc_vmid_host_uuid[4], + vport->lpfc_vmid_host_uuid[5], + vport->lpfc_vmid_host_uuid[6], + vport->lpfc_vmid_host_uuid[7], + vport->lpfc_vmid_host_uuid[8], + vport->lpfc_vmid_host_uuid[9], + vport->lpfc_vmid_host_uuid[10], + vport->lpfc_vmid_host_uuid[11], + vport->lpfc_vmid_host_uuid[12], + vport->lpfc_vmid_host_uuid[13], + vport->lpfc_vmid_host_uuid[14], + vport->lpfc_vmid_host_uuid[15]); + } + + /* IO stats */ + len += scnprintf(buf + len, PAGE_SIZE - len, + "ID00 READs:%llx WRITEs:%llx\n", + vmp->io_rd_cnt, + vmp->io_wr_cnt); + for (j = 0, k = 0; j < strlen(vmp->host_vmid); j++, k += 3) + sprintf((char *)(hxstr + k), "%2x ", vmp->host_vmid[j]); + /* UUIDs */ + len += scnprintf(buf + len, PAGE_SIZE - len, "UUID:\n"); + len += scnprintf(buf + len, PAGE_SIZE - len, "%s\n", hxstr); + + len += scnprintf(buf + len, PAGE_SIZE - len, "String (%s)\n", + vmp->host_vmid); + + if (vport->phba->pport->vmid_flag & LPFC_VMID_TYPE_PRIO) + len += scnprintf(buf + len, PAGE_SIZE - len, + "CS_CTL VMID: 0x%x\n", + vmp->un.cs_ctl_vmid); + else + len += scnprintf(buf + len, PAGE_SIZE - len, + "Application id: 0x%x\n", + vmp->un.app_id); + + /* calculate the last access time */ + for_each_possible_cpu(cpu) { + lta = per_cpu_ptr(vmp->last_io_time, cpu); + if (!lta) + continue; + + /* if last access time is less than timeout */ + if (time_after((unsigned long)*lta, jiffies)) + continue; + + if (*lta > max_lta) + max_lta = *lta; + } + + rct_acc = jiffies_to_msecs(jiffies - max_lta) / 1000; + /* current time */ + time64_to_tm(ktime_get_real_seconds(), + -(sys_tz.tz_minuteswest * 60) - rct_acc, &tm_val); + + len += scnprintf(buf + len, PAGE_SIZE - len, + "Last Access Time :" + "%ld-%d-%dT%02d:%02d:%02d\n\n", + 1900 + tm_val.tm_year, tm_val.tm_mon + 1, + tm_val.tm_mday, tm_val.tm_hour, + tm_val.tm_min, tm_val.tm_sec); + + if (len >= PAGE_SIZE) + return len; + + memset(hxstr, 0, LPFC_MAX_VMID_SIZE * 3); + } + return len; +} + /** * lpfc_drvr_version_show - Return the Emulex driver string with version number * @dev: class unused variable. @@ -3011,6 +3143,7 @@ static DEVICE_ATTR(protocol, S_IRUGO, lpfc_sli4_protocol_show, NULL); static DEVICE_ATTR(lpfc_xlane_supported, S_IRUGO, lpfc_oas_supported_show, NULL); static DEVICE_ATTR(cmf_info, 0444, lpfc_cmf_info_show, NULL); +static DEVICE_ATTR_RO(lpfc_vmid_info); #define WWN_SZ 8 /** @@ -6117,6 +6250,7 @@ static struct attribute *lpfc_hba_attrs[] = { &dev_attr_lpfc_vmid_inactivity_timeout.attr, &dev_attr_lpfc_vmid_app_header.attr, &dev_attr_lpfc_vmid_priority_tagging.attr, + &dev_attr_lpfc_vmid_info.attr, NULL, }; From patchwork Fri Apr 25 19:48:05 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Justin Tee X-Patchwork-Id: 885263 Received: from mail-pf1-f182.google.com (mail-pf1-f182.google.com [209.85.210.182]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 419C121ABB0 for ; Fri, 25 Apr 2025 19:24:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.182 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745609087; cv=none; b=VFcgw3gDIGfxX0sjWLZr3yyf5xp7y2JMzEio5krWytRLE8PpLbN+Nt3pTeE7z0LT47r2RNeGKpCevv5kDwpo8liRdfkZZzjFwE8EV1zDZLRfaozxBZwmQyeVTcV4pTRjLUJTtZKqh9LdsaqzgHvfu0Zs8F7afQI/R9WxPTZSg0Q= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745609087; c=relaxed/simple; bh=Nz6BpKArnNch1V00UN8vL63qyI4nfXZTb5vr+jniu24=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=vFtzFqgS/d7+V79j5aLFgImHna74j4foc01GK6box5y5+RtOp794HftfmFomP6CR7D0NX5ZF63pw433K/x/UyvqpslvUZT0EctwyBeO/4BKuAw9Eky2QsIVaQnv4DIkRxWX4BlX+zk+DyFGW5mjogogiyZJnfQUzU9WZT+qwGyI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=STLhkbF7; arc=none smtp.client-ip=209.85.210.182 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="STLhkbF7" Received: by mail-pf1-f182.google.com with SMTP id d2e1a72fcca58-7370a2d1981so2274112b3a.2 for ; Fri, 25 Apr 2025 12:24:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1745609085; x=1746213885; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=62zm1W8IoG0ZaLP3Q9zqWa2/RhtclO82F/GKf2CvRGk=; b=STLhkbF7s/F/Ns1zDaUrUIweNkvhcyZ74eVXqg+1ElglGaG5fKjec4yVEoci8FI3RO 0mHkfL8jKfV3RwY+l47w2tovrQhggbntTXNcGOvEA14pCqn7ShFSJZ8nf0pamC2wVqcJ UCNthoQeXVIj9S7VHu4tqd3ZzroH8A1wErqI/SV1RsLMva4zWcZTN4JOYmDki+UeXj5H z+XJf72G4HoE9hTt5qrkyqqFUGKHmRxtYZ3jH1DjzDR8WT4s3MtwS3bQEJB7SngOxqZ1 cjKRPC/AaY7/yBgW8K6ybELi8MMNWZqsqlQgQEsrGGCkNOOmx1xNPinxzTQQJ+LTqOp0 IxlA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1745609085; x=1746213885; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=62zm1W8IoG0ZaLP3Q9zqWa2/RhtclO82F/GKf2CvRGk=; b=X5uYTn7J3mQcbC0EkgnVIxiiKViI+A4+6XJnPdP4w3iydr8M8wasNQiHU0/WAFDFm3 Hr1LVbJktCGPkE+3awFTo8afnsXFd3AMu9imqrOHlpIFI9kbO58Rh8FkGy2g1AdNR5CN K8qVyEvtt25l+aTWmHw3Er1DWBws70or8waQUn3USzfEVXCvPukBJlDC1Yt6OETw1sgA KQVsq79gy/8/r+cuJb8Z8HhDNzD17+wDk+/hV1w6qJAo3/aXRNAPyVTivmRw/SvH4zsC HB8/wWaX3kc2vO+qjLJDAHgS1Vr+/9C1mbhnY2xmPtt1NgRtPQGZw2rQ8OHW/XK8KfPZ +MEQ== X-Gm-Message-State: AOJu0Yym+OKrSBDfZJf+zwFQs7Dw2B6aiVS5QkGqHvlu/53BfFFXTwIt iL2/C5GdMt6XiRfi68652go3Hm9zi4SiHhkVVC+OBtGnPP74NO+kyPeWvA== X-Gm-Gg: ASbGncsW/Qth6dOnqwVNxSMaHKg252pzjP2Ajf3rY1vhJdx2vmsJcJ/zH7WQnLhcT7f p2GnkmIGtV9weNuGUvOdSNTdyoulfLR01LVpjt3/NZIvY3iahnS9lp7ZGqYoKMu/SrbFazaAkLw f0jtKjvIwTcIYgQSAtf4WZofkMxGBZO6D+5FR86uTD5YhzTiSbGdKJPD1G6kiFOVLPGxEAqcMbc x05bAJqT9ai0hqHGLAPQ11ktqbu1582d/z4QyzewmdbqO6k1GmTqrvXxb4SO22kQ5szrkWPo7Wl t63A6xh4saI8QldpQD/BU3A20c7cMP7VoW84+QMtz7kmB0LbzdKN9cnbZ/laoi/tSsmivLnP7wQ inx91cRXh3ThNuC9LsufL9M5f1RPtj0b0lX8V X-Google-Smtp-Source: AGHT+IGkrKcChxGjdgDkygeMDql0BOqHuhIhJPtRsVYDlgUf4zPMOlErgopvMjyPRem0dltjTL8nFQ== X-Received: by 2002:a05:6a21:9004:b0:1f5:535c:82dc with SMTP id adf61e73a8af0-2046a74a4d9mr505395637.42.1745609085462; Fri, 25 Apr 2025 12:24:45 -0700 (PDT) Received: from dhcp-10-231-55-133.dhcp.broadcom.net ([192.19.223.252]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-73e25a6a649sm3667513b3a.109.2025.04.25.12.24.44 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Fri, 25 Apr 2025 12:24:45 -0700 (PDT) From: Justin Tee To: linux-scsi@vger.kernel.org Cc: jsmart2021@gmail.com, justin.tee@broadcom.com, Justin Tee Subject: [PATCH 7/8] lpfc: Update lpfc version to 14.4.0.9 Date: Fri, 25 Apr 2025 12:48:05 -0700 Message-Id: <20250425194806.3585-8-justintee8345@gmail.com> X-Mailer: git-send-email 2.38.0 In-Reply-To: <20250425194806.3585-1-justintee8345@gmail.com> References: <20250425194806.3585-1-justintee8345@gmail.com> Precedence: bulk X-Mailing-List: linux-scsi@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Update lpfc version to 14.4.0.9 Signed-off-by: Justin Tee --- drivers/scsi/lpfc/lpfc_version.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/scsi/lpfc/lpfc_version.h b/drivers/scsi/lpfc/lpfc_version.h index 638b50f35287..749688aa8a82 100644 --- a/drivers/scsi/lpfc/lpfc_version.h +++ b/drivers/scsi/lpfc/lpfc_version.h @@ -20,7 +20,7 @@ * included with this package. * *******************************************************************/ -#define LPFC_DRIVER_VERSION "14.4.0.8" +#define LPFC_DRIVER_VERSION "14.4.0.9" #define LPFC_DRIVER_NAME "lpfc" /* Used for SLI 2/3 */ From patchwork Fri Apr 25 19:48:06 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Justin Tee X-Patchwork-Id: 884722 Received: from mail-pf1-f178.google.com (mail-pf1-f178.google.com [209.85.210.178]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CCC4F21ADC7 for ; Fri, 25 Apr 2025 19:24:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.178 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745609089; cv=none; b=fqgVMK5GxM0+DmYJomB7/T3Q5C5Au3u75nNVVDwIT4i/FvVEyDBzVoAQdwNDCF0lScwNXoHVYxmQhlD88BWn1fm3vDUSc0LVlGJK9hksutsAPeGKObPs3+WldkHi4s2vbuyKSQgmqyUbZh+WVKTf1VTEnwDyArN0diS3caIeMm4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745609089; c=relaxed/simple; bh=PhYPUrUG+PXiqwskbYWP7FYFddh1QI1H+qfQm6csVDc=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version:Content-Type; b=eWi4ek/aZunE8BA8s00K6J8lo+sdXNzhHCWBbq5ucohxrud4ZNDYFl5jhqIdtCXc18y83p01Y63UdH6UOmSOIyMmhB+AFa3XuqQO1M68qBFhrVmCzwJ3gsvZ1u0gUyuEKLI/1bcrlK0r3Sg9Mv4aD14XjodjpKZSWIcZqIJ8WMg= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=MAn01Klo; arc=none smtp.client-ip=209.85.210.178 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="MAn01Klo" Received: by mail-pf1-f178.google.com with SMTP id d2e1a72fcca58-736b98acaadso2699321b3a.1 for ; Fri, 25 Apr 2025 12:24:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1745609087; x=1746213887; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=so/wiwgjHW7oHEn1jinyOqqjwD66ZNbOq7w2WCg5xHQ=; b=MAn01KlolrHSQSO3cYehH4o1c2Hxe2olAxxpKUbdOvmrUWZWrFjnLKa4+nCllBA8xL H8bJ58/pZAZJA2OPmyysktMi+HCg+tS3WMR981nqyOETxl5T+aD+i+Z4yinYyqeLv4gv UeairE9ojBsXI9FPIehxAMji4UA+G+3VVOFM3apWC84rBBd9PFP20KFyyomtC++E+DGe Mrt06ocbFXQnTZ4744CENjQby8ix0q0Lg9aUreeUdcQQoBV9sqKwPtYdj2BWkwL3xpon gSH3KtClMDf/mzYt+2lBVDMRnnYz7+JplH9vsHWAUssK04ZEtg+K/VxK2kdHJYIvA7rS ROGw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1745609087; x=1746213887; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=so/wiwgjHW7oHEn1jinyOqqjwD66ZNbOq7w2WCg5xHQ=; b=ZLscVpBUj749oUNI+HLJtPqU0AAbeni2L5T8xcUrDMflgFXjT3QoZCbA7Ywc12oKw2 unTIkqy2Y+vUVdMJb2WbIGD55EWwFkHXGteljP0eqFos09fsVOWnTIAD1BxWeexn6wjj BjJwKEJTaVjfZLlzbva0iEavt3fi9cjygj34wJVj5bZeIl2EdAno7aqU5cWUfcPe0CGK MkHGO/W2ojznKLTayEgF26m1CE+XPiEUVhWc5NUMivrJqjldfCbNRGqtqBaQ4IzABwAs a1b2dJZxBFFNfVSSpEaPzdXuSTN7LsV8a9CMQgBWzH+EFjrA4zf88CZ4LjCg4vSYTlmM M+Zw== X-Gm-Message-State: AOJu0Yw2agrId6tcnKCeXIIVoY5yuvf8wAWf2snHgUegLQ/Fg1joB7dG K+78YtaAoxWGyP2/0wRWU22qJVWvIYmpAQyIQz99EFu286+lFLJxzAk0uw== X-Gm-Gg: ASbGncvtLBqYYIxU/EuJo715b31GCDDn4WLOniPOJZRsAxFuIzdB0RpqmlISxytn8Tw ALT/ID/vmo46cMOpcck/YQbzxlCRShb7dDjgj5fLb3PlAjaLCISqIfKKzqtFaIvdd6t3k+RYDLN QVHbBXI0Tspb5vWSjpyM4Xf+PDdOmEvV3/AZbr6bS9uIQ+Ju/qVhdwaaX0+hIAxQiCBIcK8igiI l44GOZHNPptMSHyeI9yOY7KuUT6qNywL3T9SxWvvdxeLBv7GjMd0ttlTGKdOz7NGQPM1Yd2qQZJ koUtvqrxJBkn7uUjfcUKyiyY5A3Lc51hZp0jLatrgz68iP8FL5Vag+s0FMtTiA1dPgXbllpXn2E 6XkyQ6hsj70YVngI0DPCETCgabA== X-Google-Smtp-Source: AGHT+IHgTo2XwRo+e/d4FkjfZAt20UksnEmiWgQx4Q0Iqd1yCH6l2R3LOl2xZuzhkeFXQjXpJJl0Bw== X-Received: by 2002:a05:6a00:b4c:b0:736:34ff:be7 with SMTP id d2e1a72fcca58-73fd8b6bd7dmr4190716b3a.15.1745609086862; Fri, 25 Apr 2025 12:24:46 -0700 (PDT) Received: from dhcp-10-231-55-133.dhcp.broadcom.net ([192.19.223.252]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-73e25a6a649sm3667513b3a.109.2025.04.25.12.24.46 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Fri, 25 Apr 2025 12:24:46 -0700 (PDT) From: Justin Tee To: linux-scsi@vger.kernel.org Cc: jsmart2021@gmail.com, justin.tee@broadcom.com, Justin Tee Subject: [PATCH 8/8] lpfc: Copyright updates for 14.4.0.9 patches Date: Fri, 25 Apr 2025 12:48:06 -0700 Message-Id: <20250425194806.3585-9-justintee8345@gmail.com> X-Mailer: git-send-email 2.38.0 In-Reply-To: <20250425194806.3585-1-justintee8345@gmail.com> References: <20250425194806.3585-1-justintee8345@gmail.com> Precedence: bulk X-Mailing-List: linux-scsi@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Update copyrights to 2025 for files modified in the 14.4.0.9 patch set. Signed-off-by: Justin Tee --- drivers/scsi/lpfc/lpfc_attr.c | 2 +- drivers/scsi/lpfc/lpfc_nvme.c | 2 +- drivers/scsi/lpfc/lpfc_sli.c | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/scsi/lpfc/lpfc_attr.c b/drivers/scsi/lpfc/lpfc_attr.c index efd02c464549..54ee8ecec3b3 100644 --- a/drivers/scsi/lpfc/lpfc_attr.c +++ b/drivers/scsi/lpfc/lpfc_attr.c @@ -1,7 +1,7 @@ /******************************************************************* * This file is part of the Emulex Linux Device Driver for * * Fibre Channel Host Bus Adapters. * - * Copyright (C) 2017-2024 Broadcom. All Rights Reserved. The term * + * Copyright (C) 2017-2025 Broadcom. All Rights Reserved. The term * * “Broadcom” refers to Broadcom Inc. and/or its subsidiaries. * * Copyright (C) 2004-2016 Emulex. All rights reserved. * * EMULEX and SLI are trademarks of Emulex. * diff --git a/drivers/scsi/lpfc/lpfc_nvme.c b/drivers/scsi/lpfc/lpfc_nvme.c index 9d61e1251a2f..a6647dd360d1 100644 --- a/drivers/scsi/lpfc/lpfc_nvme.c +++ b/drivers/scsi/lpfc/lpfc_nvme.c @@ -1,7 +1,7 @@ /******************************************************************* * This file is part of the Emulex Linux Device Driver for * * Fibre Channel Host Bus Adapters. * - * Copyright (C) 2017-2024 Broadcom. All Rights Reserved. The term * + * Copyright (C) 2017-2025 Broadcom. All Rights Reserved. The term * * “Broadcom” refers to Broadcom Inc. and/or its subsidiaries. * * Copyright (C) 2004-2016 Emulex. All rights reserved. * * EMULEX and SLI are trademarks of Emulex. * diff --git a/drivers/scsi/lpfc/lpfc_sli.c b/drivers/scsi/lpfc/lpfc_sli.c index b582728d9e48..2ebb073e4ef3 100644 --- a/drivers/scsi/lpfc/lpfc_sli.c +++ b/drivers/scsi/lpfc/lpfc_sli.c @@ -1,7 +1,7 @@ /******************************************************************* * This file is part of the Emulex Linux Device Driver for * * Fibre Channel Host Bus Adapters. * - * Copyright (C) 2017-2024 Broadcom. All Rights Reserved. The term * + * Copyright (C) 2017-2025 Broadcom. All Rights Reserved. The term * * “Broadcom” refers to Broadcom Inc. and/or its subsidiaries. * * Copyright (C) 2004-2016 Emulex. All rights reserved. * * EMULEX and SLI are trademarks of Emulex. *