From patchwork Fri Apr 25 09:00:57 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bartosz Golaszewski X-Patchwork-Id: 885109 Received: from mail-wr1-f49.google.com (mail-wr1-f49.google.com [209.85.221.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AF70F23AE66 for ; Fri, 25 Apr 2025 09:01:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.49 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745571670; cv=none; b=kBDcPYpAvy6cJQoJKBkH2j1q8n9Cy8YBJ6j30jahxXGuPCUE6XqqimIeFHQy/YaGnRdCuk+v+E5+P8hueCzNH7cD7jc7dIn0MNGkYn/uXWxxyg8FQVfOCJnS92FBMQ0IqsEkj7ckmlZJqZQpfNxR080u/Riw5jhnzWEf/lAk9i8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745571670; c=relaxed/simple; bh=Lg7SIXa0ie0LybxnwabcVg+h7GXu/NKorvK1sVySxcg=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=cnfqamFcdjSDSLyhV/ZMd73S0uz6YOhgWczgjNkLrFiBEQ7hwrPPXhGG8FIVmkM0BPPZtpzm27XidcD2NepmBvwGyDwmID0SZ8kIGtY8JrYCIFK8We8E9UzzsLOJW0rYoabk64X87PVIm9dvvRPgexF1bWElzcux0sM1+OAvdvk= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl; spf=none smtp.mailfrom=bgdev.pl; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b=ZZK9c1k2; arc=none smtp.client-ip=209.85.221.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b="ZZK9c1k2" Received: by mail-wr1-f49.google.com with SMTP id ffacd0b85a97d-39ee682e0ddso1257993f8f.1 for ; Fri, 25 Apr 2025 02:01:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bgdev-pl.20230601.gappssmtp.com; s=20230601; t=1745571667; x=1746176467; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=ZB90erWf+Gm+Y0GtLErqGxR/pE5/v4Z/PlOKc5IF8Kc=; b=ZZK9c1k2GpIRHpaiYjHGfTkfd1bluAxmhM0YKsfWg6lFA7aG1w2lznLj5CSIpLodCY A0K0dvRJ8L4X70n0V/+YrMw3nN4Af9OZnvVRECkuQLEX5KSjtfl+Omu9pcxM2OPZ039S /upDGy8jEQeuMqXT4WSxeH+ofguqk8T8/Tf0wIfUda3Lh+6+xJoEnoCP6Ksta6gP47We JjtAQBwY6ByTyxtVAguQ6Tz349UAT3QwpsyQEyZKk1nkbgtDmMOk0HxkUS7KLE9NCyGK u72uJb4cmvWeaTWI3qUzlDG1uIFPGF+BnICzPykMQL+VhmruGFXyEfKBOfo/BXDeIIbL SrUg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1745571667; x=1746176467; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ZB90erWf+Gm+Y0GtLErqGxR/pE5/v4Z/PlOKc5IF8Kc=; b=V3U10bcdxAHkS1czxiEY9Zu5FwIgUJKAg4v5P+5bOs3BthXGOQwoRhWBQmicbFatAf EEycjLQwf49XtFiUbv8aVEspj7kej947pM9I8bD2nCoPThoVkEtB15FPE1VuJaZb1xQr GnMGe3t3KXMVXQFSoLj/V9D0DR+5y1Pcew8jCoOyJS8sXnC2f4frJ4Tj/AYXFzKRCbgH H70JJOhVj8Rg7+UCWDvyJKP7Gk+RDuQAgGJfOceZpO4hFMv76mxCr9M2tXB3GnHfwphs vk7IH0YiOBjJt5wBDKY3gi9pJmg4Q+TuLXsslU1YRQ84ctorVn3viz3bNajVfWCj8eRx Lidg== X-Forwarded-Encrypted: i=1; AJvYcCVu7O251JEQyCFs3ABBOw2CLHpnImabog8yJeB2Bi9X5e3NLHob4WzU3LjUsuGGQieb2i+R1pcHBKFH@vger.kernel.org X-Gm-Message-State: AOJu0YzHM3N2qQ7TUNjKpIg0vsEWmkZgI6SedjWBoW7q2N4KwPmR0/gi u5thlZ9bjbLy2NAkHjx80RqNlIIF6zfOLxjuapBR31DMmizu3wti//ic+myK0Sk= X-Gm-Gg: ASbGncupYnpyojLjWlhT7C5VcjuHrD25wCc21xZ8dBHeZLxFQNafbQ/oVHUYxN5GbBR HSX5M26dZusTBPPPHAP52+7afE8ikHvU0f/DEn9w6BLFX4gB0ihzA+rOk6PNZDin+NPEhOH6LJO 8u/uCkrTAEGW509r1krbCgWWJx5KIQ78V2WNGLjY36pdzky2aYebeysLHdGJ5DH4jOpmtQGUen1 fR6tRKb2vrghxMMHZ7dK2Ac7I/ocfDVWQ0UfM47rYtai3rMO71XzUTgoQs12yfQZTRw6YpNHcNX NKMVs6H+0a10NWlbsjQhrcP4/UUnRBzn1Q== X-Google-Smtp-Source: AGHT+IF0m8rX5UMES4nVD0erCZ4KstVSP6VZhmeff7Jfr6OuosoVYyYD4igGlIuV4D5i2BVa1x4EkQ== X-Received: by 2002:a05:6000:1a88:b0:39c:1257:c96c with SMTP id ffacd0b85a97d-3a074faf4b3mr1205781f8f.56.1745571666825; Fri, 25 Apr 2025 02:01:06 -0700 (PDT) Received: from [127.0.1.1] ([2a01:cb1d:dc:7e00:3f35:2b31:c543:726d]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3a073c8c95dsm1696571f8f.3.2025.04.25.02.01.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 25 Apr 2025 02:01:06 -0700 (PDT) From: Bartosz Golaszewski Date: Fri, 25 Apr 2025 11:00:57 +0200 Subject: [PATCH 1/5] pinctrl: mediatek: airoha: use new GPIO line value setter callbacks Precedence: bulk X-Mailing-List: linux-gpio@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20250425-gpiochip-set-rv-pinctrl-mediatek-v1-1-93e6a01855e7@linaro.org> References: <20250425-gpiochip-set-rv-pinctrl-mediatek-v1-0-93e6a01855e7@linaro.org> In-Reply-To: <20250425-gpiochip-set-rv-pinctrl-mediatek-v1-0-93e6a01855e7@linaro.org> To: Lorenzo Bianconi , Sean Wang , Linus Walleij , Matthias Brugger , AngeloGioacchino Del Regno , Bartosz Golaszewski Cc: linux-mediatek@lists.infradead.org, linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Bartosz Golaszewski X-Mailer: b4 0.14.1 X-Developer-Signature: v=1; a=openpgp-sha256; l=2370; i=bartosz.golaszewski@linaro.org; h=from:subject:message-id; bh=uaHOfJ94TFx8k9XlThx6lSkpYsN9+1e6SW0WrRZmuoc=; b=owEBbQKS/ZANAwAKARGnLqAUcddyAcsmYgBoC09Pjw/np8UeS1ttDZIlSftl0HIaXAVQAcTl+ qHDg6ttNnqJAjMEAAEKAB0WIQQWnetsC8PEYBPSx58Rpy6gFHHXcgUCaAtPTwAKCRARpy6gFHHX chLhD/429DgRXwmTcgjG7Djz7jHNaXG0YDQCs3in+FxM1KrmgZ7nENGsnYdogEPNSvdYBfsUhwf JSQNi2Z47oZ0and5Yvmmv3FnmvnBUpbtPa4O++YpL8TVUq7teVZIBYCPkxG6uWpbX339RqRVb4Z Eu9FEoXAE5JRDGSRUmJDfaRHGeGq4apiYTNBsQpo9cnQN5L4m9pDIlRoM7+e2tYyrEzG6/v8egd OSP1y6+t9WuoDPeH25a1e9Ta1ehj2ViYsD9E4pQE7gM7EPm0OsJqxT007wmerUBuqvCq4rTncQ2 0EQP7ORGcUfUsLT5R/cBcIYlUFbhziuNBpeBaKginbJoYLu8wfb+ospruKX203GPKzCFPtSSRQj 9TyWwf1wV+kQYa/OkcDoCC9ScRxvDE6V7FTE4KzW54hNfzl46gZK8JoJKj1+7yQQgjVnY4AqENs Pt5WUaDQWxdfQotValBICHCN1jMnaWl4dDMso+xs72ErbEvVrbB5xIWWPoFuBGdazfWDfMDjyaI teZVW4YCDH9O2N30eJRp9/ON2MYaliiSvfVZDr6YcXTCzcmsLIIgKqrvexUxntmwoYebcguTINs SGM+230tfxLUtpfvpwqrxYPrpsv28wSCb1BlDuLaLdh+bHvGajSdqgZlxAAN8qwALpRkoR4o/K8 rSv4Yz4yX+so0eQ== X-Developer-Key: i=bartosz.golaszewski@linaro.org; a=openpgp; fpr=169DEB6C0BC3C46013D2C79F11A72EA01471D772 From: Bartosz Golaszewski struct gpio_chip now has callbacks for setting line values that return an integer, allowing to indicate failures. Convert the driver to using them. Signed-off-by: Bartosz Golaszewski --- drivers/pinctrl/mediatek/pinctrl-airoha.c | 19 ++++++++----------- 1 file changed, 8 insertions(+), 11 deletions(-) diff --git a/drivers/pinctrl/mediatek/pinctrl-airoha.c b/drivers/pinctrl/mediatek/pinctrl-airoha.c index 5d84a778683d..b97b28ebb37a 100644 --- a/drivers/pinctrl/mediatek/pinctrl-airoha.c +++ b/drivers/pinctrl/mediatek/pinctrl-airoha.c @@ -2247,15 +2247,16 @@ static int airoha_convert_pin_to_reg_offset(struct pinctrl_dev *pctrl_dev, } /* gpio callbacks */ -static void airoha_gpio_set(struct gpio_chip *chip, unsigned int gpio, - int value) +static int airoha_gpio_set(struct gpio_chip *chip, unsigned int gpio, + int value) { struct airoha_pinctrl *pinctrl = gpiochip_get_data(chip); u32 offset = gpio % AIROHA_PIN_BANK_SIZE; u8 index = gpio / AIROHA_PIN_BANK_SIZE; - regmap_update_bits(pinctrl->regmap, pinctrl->gpiochip.data[index], - BIT(offset), value ? BIT(offset) : 0); + return regmap_update_bits(pinctrl->regmap, + pinctrl->gpiochip.data[index], + BIT(offset), value ? BIT(offset) : 0); } static int airoha_gpio_get(struct gpio_chip *chip, unsigned int gpio) @@ -2280,9 +2281,7 @@ static int airoha_gpio_direction_output(struct gpio_chip *chip, if (err) return err; - airoha_gpio_set(chip, gpio, value); - - return 0; + return airoha_gpio_set(chip, gpio, value); } /* irq callbacks */ @@ -2419,7 +2418,7 @@ static int airoha_pinctrl_add_gpiochip(struct airoha_pinctrl *pinctrl, gc->free = gpiochip_generic_free; gc->direction_input = pinctrl_gpio_direction_input; gc->direction_output = airoha_gpio_direction_output; - gc->set = airoha_gpio_set; + gc->set_rv = airoha_gpio_set; gc->get = airoha_gpio_get; gc->base = -1; gc->ngpio = AIROHA_NUM_PINS; @@ -2715,9 +2714,7 @@ static int airoha_pinconf_set_pin_value(struct pinctrl_dev *pctrl_dev, if (pin < 0) return pin; - airoha_gpio_set(&pinctrl->gpiochip.chip, pin, value); - - return 0; + return airoha_gpio_set(&pinctrl->gpiochip.chip, pin, value); } static int airoha_pinconf_set(struct pinctrl_dev *pctrl_dev, From patchwork Fri Apr 25 09:00:58 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bartosz Golaszewski X-Patchwork-Id: 884625 Received: from mail-wr1-f51.google.com (mail-wr1-f51.google.com [209.85.221.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A4F0D238C19 for ; Fri, 25 Apr 2025 09:01:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.51 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745571672; cv=none; b=aH8//VyCMdxIjHvXFwYBnZfSTWzthvA390RmCQ47ZVkhs9jH34kk4kjibEWj3S32DXU2GdUo8kwApy1G3x6MAIjWCw0oTUeMe5UMDrBAkXHvUHffw9JLDpdPG8W+HbS5CQKsW7tTK9yQz+b6JJZdtZ1THfXv4Tf8UlQ6RJHfRz0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745571672; c=relaxed/simple; bh=phhWviKKhhzzjzPDil2DbjlngOzuC2xCXBD1aK0WBVg=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=N3O44sqWKC1AfT53mDhOUoDOsBPoVvwQ9AeGRJpZ4AG3LeFfi0NZzW4Ckh1ECzTuQQT9Den2V3QYndvGGZ+nd5nq7KcsoS8jsbkvpfhCyZxzaYdORc3ErfHOkF25aIMZ48uFjh036EdgETK5wGlEJ+2tlButmaH3nBQeE8GOgTM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl; spf=none smtp.mailfrom=bgdev.pl; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b=EYnj0Hxi; arc=none smtp.client-ip=209.85.221.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b="EYnj0Hxi" Received: by mail-wr1-f51.google.com with SMTP id ffacd0b85a97d-3914bc3e01aso1163896f8f.2 for ; Fri, 25 Apr 2025 02:01:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bgdev-pl.20230601.gappssmtp.com; s=20230601; t=1745571668; x=1746176468; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=aG92M+ThGG8rcCnZb6WUafkA585r/LuxT+alwijT/5c=; b=EYnj0Hxi6pW4zADwpWaOo3NtQwbi0vT+6Hk+dxRI21HdXhQrg+F2r/uAcsJWHRbrYK pW2OOIgmEZs0gktiK94MCgPEOLud5BwOTeoBdCLQqlekerFZCzSI+9A9JG96uqtQoaiS e4SYx9dg25qQjdKXQhqLtRlWA5iQxdRqLe0uBU0l9JNU2GU04elS0OCVSEFD4JPFJRuO brTs5DQzxozWyP5xoPAK2y8uaIDXXM/hlvIAR9OPPc0QkTOxlmwp03bWeP8FSq3hzS+K ATYpHlNyt7wNzUiYibGon8VZ00bEM7cswU1WbqD1QtIq9bDWgNcgeYcZX5/KO03IE1Hy DmAw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1745571668; x=1746176468; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=aG92M+ThGG8rcCnZb6WUafkA585r/LuxT+alwijT/5c=; b=snndeIvm3R9iJ1W908OQ6oLlp5yVhqqrhyLA2+Wx0VLigcCkAJqhSx781YCZQKII0n 5QLSvtmB9IzMYNAz5bKJWhg3aU2iq83vrnpM2jy7WwU0e8WC7H/d077AmzOJTnaKkNV7 TWnNaQTEfRMvFVcL+oATQra6YlCyORZMNU6RnbcmqVDXDXYh48EQcN6ME6ig62ZdI+LO k2gwI3RNsZVCMzhxJt8RZPYyg4TU5laEGaOWtizDt9dnaJYCdt4ZwKBJzM+GIifCzemp ZLTkeoZQPZ+7etnCSePiVhIl+9WZ6tQKVO3czFw3LeCRqXwv8OHmu7vk6oRbIwXAGvav 9IQw== X-Forwarded-Encrypted: i=1; AJvYcCXEFeVDHm+pRK9HTensQMrAHu0X/8kcK/3rSCOuAlQ63xI7kT/qhfoYBS1DvNqn0J4pOQVtAngXwR8K@vger.kernel.org X-Gm-Message-State: AOJu0Yz7EwNBQMJ2orW1UY1muZkfd+6ei2VTzCVDrz3mxoe1aVeixz3n oLbZ0BRJYNHjOd1i6upbWWoPVGg9FoaMu48VPh7iWmd/ypZRuPI+aQCZjDZnptQ= X-Gm-Gg: ASbGncu2N88NVzmcq0AWtcdCTTSI2cAiQwDf72UTbIn1MFC9JAQahppnXSHDP/LmIZy q5MUR13LaejhvxQPT0cbtxyHpuQTFuiTwFPPN+c3t8n8F+S0ljLIvL6S1Cj4PnR9yQzjUMQRqH3 t38c1p4Qf0TMEvxBwPqNN/TLsZ5grWngr/eaeDxeAraa/dES1gshAjC7YUix0CfWEhgPV/zkRNC 3rHQvvhPap6hmq09V6axZd9EVtKCvj2AfaQ3/lPFRzl2expz4QCedhGcU4y0d0ElEsnoJ+SJiHF quvsyTXtssIokQ89tbObaoFg46jPaWclWg== X-Google-Smtp-Source: AGHT+IFW7oHQT2iQkXG5/oplsgKCVuoYvLPqlkf0fWIPHa0BO2c6LkQgBuCA2L7Ixcx9kcJza03b8Q== X-Received: by 2002:a05:6000:1ac6:b0:38f:483f:8319 with SMTP id ffacd0b85a97d-3a074f4853cmr1080551f8f.51.1745571667902; Fri, 25 Apr 2025 02:01:07 -0700 (PDT) Received: from [127.0.1.1] ([2a01:cb1d:dc:7e00:3f35:2b31:c543:726d]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3a073c8c95dsm1696571f8f.3.2025.04.25.02.01.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 25 Apr 2025 02:01:07 -0700 (PDT) From: Bartosz Golaszewski Date: Fri, 25 Apr 2025 11:00:58 +0200 Subject: [PATCH 2/5] pinctrl: mediatek: paris: don't double-check the GPIO number Precedence: bulk X-Mailing-List: linux-gpio@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20250425-gpiochip-set-rv-pinctrl-mediatek-v1-2-93e6a01855e7@linaro.org> References: <20250425-gpiochip-set-rv-pinctrl-mediatek-v1-0-93e6a01855e7@linaro.org> In-Reply-To: <20250425-gpiochip-set-rv-pinctrl-mediatek-v1-0-93e6a01855e7@linaro.org> To: Lorenzo Bianconi , Sean Wang , Linus Walleij , Matthias Brugger , AngeloGioacchino Del Regno , Bartosz Golaszewski Cc: linux-mediatek@lists.infradead.org, linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Bartosz Golaszewski X-Mailer: b4 0.14.1 X-Developer-Signature: v=1; a=openpgp-sha256; l=2274; i=bartosz.golaszewski@linaro.org; h=from:subject:message-id; bh=nUKaoN4taOpveP3nc3OVuJSxVohaZIGpFohuQJLAScE=; b=owEBbQKS/ZANAwAKARGnLqAUcddyAcsmYgBoC09P1im4kKMb6U7RG39p9G/VrnbdkYWFGjboY 3bmo1dLQC6JAjMEAAEKAB0WIQQWnetsC8PEYBPSx58Rpy6gFHHXcgUCaAtPTwAKCRARpy6gFHHX crgtD/9is3Kf21qiXzq1VSscbgtqKAJ8hb/XCsd0cS2PtTKxYDWP1SnTIL4KX7ofzZY6+UNXOZp dy+D4aO7WNZsFR0/IHIeqWBWEk3rmMlSGkbfrIVDhpWvtIo6opyCQxql8Q5LViq0LRe6JEPRdoC Lor1QT7DRjA92oRtQppJ2/eJZFWLujiVsYYPLfXICUinmpUOHk2wHZ7Juzozwht7N/RM8hDQi5w Tq5I9jApIX7HuFwuRuILD7KrOPs3yAIkxg5EIl9t/8uEheTZAUl8gjFrt2oXh1d8QjiG6UIsnQ0 FCxUF6W7Qt3yoXvJB7BVE+lfhs5yJuhuQiBz7jSQOmUCnEpPC+rnlE6PEgqlrlB4S3UfQMyfxXu TkZGAWz6/V/ricSCTfoPbWxtHT/fmyIr/PoIil6NMgsEtw2lsTQZclPoBCEjv8FSHBZaLlZp21M QjWftw1cUSxo+sR0S6FDFFCo3EdAN3zIgltKS6I3KlaRXzygoM+OsakxjcXFba51INkzT5w7nD9 EsU0E0Z17ILt6kloAzswTHoIJKQM1NeKw/qUNa1zMq4sLMkRIadcAf8J8lFYGsqLQt+KrRyjmQN 85NWWLYzuxDF0gYe0/Ci8Zos6oglGyM6ff6HvFfXZwh0zf1/igURjsYJ8qyXym9CZlTm2F6YJGx sWnd0wD08yn563g== X-Developer-Key: i=bartosz.golaszewski@linaro.org; a=openpgp; fpr=169DEB6C0BC3C46013D2C79F11A72EA01471D772 From: Bartosz Golaszewski GPIO core already makes sure we don't pass invalid GPIO numbers down to the driver callbacks. Remove needless checks from the driver. Signed-off-by: Bartosz Golaszewski --- drivers/pinctrl/mediatek/pinctrl-paris.c | 19 ------------------- 1 file changed, 19 deletions(-) diff --git a/drivers/pinctrl/mediatek/pinctrl-paris.c b/drivers/pinctrl/mediatek/pinctrl-paris.c index 87e958d827bf..852ce0ac7ff9 100644 --- a/drivers/pinctrl/mediatek/pinctrl-paris.c +++ b/drivers/pinctrl/mediatek/pinctrl-paris.c @@ -840,9 +840,6 @@ static int mtk_gpio_get_direction(struct gpio_chip *chip, unsigned int gpio) const struct mtk_pin_desc *desc; int value, err; - if (gpio >= hw->soc->npins) - return -EINVAL; - /* * "Virtual" GPIOs are always and only used for interrupts * Since they are only used for interrupts, they are always inputs @@ -868,9 +865,6 @@ static int mtk_gpio_get(struct gpio_chip *chip, unsigned int gpio) const struct mtk_pin_desc *desc; int value, err; - if (gpio >= hw->soc->npins) - return -EINVAL; - desc = (const struct mtk_pin_desc *)&hw->soc->pins[gpio]; err = mtk_hw_get_value(hw, desc, PINCTRL_PIN_REG_DI, &value); @@ -885,9 +879,6 @@ static void mtk_gpio_set(struct gpio_chip *chip, unsigned int gpio, int value) struct mtk_pinctrl *hw = gpiochip_get_data(chip); const struct mtk_pin_desc *desc; - if (gpio >= hw->soc->npins) - return; - desc = (const struct mtk_pin_desc *)&hw->soc->pins[gpio]; mtk_hw_set_value(hw, desc, PINCTRL_PIN_REG_DO, !!value); @@ -895,22 +886,12 @@ static void mtk_gpio_set(struct gpio_chip *chip, unsigned int gpio, int value) static int mtk_gpio_direction_input(struct gpio_chip *chip, unsigned int gpio) { - struct mtk_pinctrl *hw = gpiochip_get_data(chip); - - if (gpio >= hw->soc->npins) - return -EINVAL; - return pinctrl_gpio_direction_input(chip, gpio); } static int mtk_gpio_direction_output(struct gpio_chip *chip, unsigned int gpio, int value) { - struct mtk_pinctrl *hw = gpiochip_get_data(chip); - - if (gpio >= hw->soc->npins) - return -EINVAL; - mtk_gpio_set(chip, gpio, value); return pinctrl_gpio_direction_output(chip, gpio); From patchwork Fri Apr 25 09:00:59 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bartosz Golaszewski X-Patchwork-Id: 885108 Received: from mail-wr1-f41.google.com (mail-wr1-f41.google.com [209.85.221.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 50810238C10 for ; Fri, 25 Apr 2025 09:01:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.41 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745571673; cv=none; b=KopOJAUg6/q2FMSfanAuUXEzw9cC99f0WNH3Kyvoa7H28MUlpHuDOKHEmF8FfXAcJ0xEYvh11jxzPZW+7BCIxXK3tBj3/bsxzqgY85Cg+df8uwiHVS4NY38bXOqhEGHEhija3M4k5g2j5b9LfXaRPeMCuHiNJMXV0MZvMwwAXfw= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745571673; c=relaxed/simple; bh=hZpJKZ+GQSZQ/UbnOT9RImA04jIADFnimUHfJV9B/o8=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=e9eZSi3OLmfyFXhR2oT1JEbOHTIty6aF9QaEgPuMsGd7r76R6f+0edNaG0x/tN/WAQdT2s5JuL+jr1+c//44CdqAbAc0K1WCxcVlIYyTZSCUxAK9f6W3NHCz2lFIwjogFmrSWHtUJNaBNl4eN+A6MR8M1105SoVe5aXH7qC16KE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl; spf=none smtp.mailfrom=bgdev.pl; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b=l26cjLMP; arc=none smtp.client-ip=209.85.221.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b="l26cjLMP" Received: by mail-wr1-f41.google.com with SMTP id ffacd0b85a97d-39c0dfad22aso1457998f8f.2 for ; Fri, 25 Apr 2025 02:01:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bgdev-pl.20230601.gappssmtp.com; s=20230601; t=1745571669; x=1746176469; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=r8UXZTozvJzjGLspnxEWNqMkDpoXY67SelwpGY/ZF58=; b=l26cjLMP21yfZ46wDo+Cd5wXTo1lG1MZFKrrpmISrY2fTnxNYM+R1g4f9/H7WqQyn2 dyMHcdpik4qP456sNC2EX+/vMSQ9TRNOTEPZiGkasa+L/l6wuWeyCS4Sep/M8OZH8vEK wDXleA8VmxgR3s9j+6LUTpbMifmZJJpjNJGyYOev+NeC7sWbTuCGLiGQZKqwwJXJWKkE kZ7B7eN39o1cZAoqH/W3edoyr/j6fB6scfZFME+Mlv/tktA+pVduU/yEMVYZ5PV5cGi0 VdYYMZ+0pqUHx52IMcpmg8kRtN4WkRUn1QXQfnLxectJqJpz8A1D93h4fCwwEbJ0w6/a zbbA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1745571669; x=1746176469; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=r8UXZTozvJzjGLspnxEWNqMkDpoXY67SelwpGY/ZF58=; b=iWNQAPZI5enxKaz8z3hx8Odgt7t4AeNYLEuwnyprthDnPSIi8d239ugG0jjIl7BB1v KSJsz3WUBN9K42v/Q8J99tWb3PV5anFIShJjCgII3P1OzqmLTvE2qIVJKUVvlCMXGrT+ LmoKFnErR6YV71Nc6Rs24zQ2kdNV09uq6efRWF+GiJ5PAmCsjy74qELabCmvNSo9YRlV johpxYn6Lg/BZdLuLfOVO5LQ/PRgs4CJ8+vvo00qfTRt7TV5W2sFIFklSL4O2ilGGbMv EYvHk2U1kCIXyvTVNynTWVkhscrvmrRU1biNvKO94jHYdYf72RP8EDdopvfZWjyPmF62 Z9DA== X-Forwarded-Encrypted: i=1; AJvYcCVb3tSi1zcCaW0qZeWEAimsWxhsSJrWykyi0Vymp/Ax3D43UXMAmbjMcxmGwIAwKuXmrhxN0hcu5QBD@vger.kernel.org X-Gm-Message-State: AOJu0YxczvhIw/hOavEqyTc7AZauNkSQKwRT/I83r+w9ktUNq/orI+gw JvORTeAhyzLeetgtjq3QNflDmoupLzNV4VcJhZlwb8WBrKxAXbv4zxhyXronfh4= X-Gm-Gg: ASbGncuDpvfAXuoyiySzBCyNezKz+3Jf3lp29kkbSm2GzC5jLb2zW5l8PRRPfm8YtSl PVJZuKEyCIYHnKgQVocz431+tIbL/cdgMxgvZMZXVoyFTYV75rEntbiLQlJj5VBJsmnLQB6DyUU u45Rni8FXQWFMPeV8FGUgMZhXfSRahaOZj7fDjHw7yeHCjxU5EhVsiokqo7xOG35rsCytnRMJat +JB/zLBSvQF1iNq/XTFaoWpAibCebXNcgZm/mpsVrV/ADCq+TCGOHePo5rm8eADZU3KD57tSgUd 4v2vbbAFmUaMbfpLXlPruQ3BwSB+sFbMeQ== X-Google-Smtp-Source: AGHT+IFckeNXXJag89Vd0W7MAUKrj0/boKLVXA4/ZToJROXBMZJpIxWvphXkHztSufJCbS1p52tVAQ== X-Received: by 2002:a5d:5985:0:b0:39f:ed8:d6c2 with SMTP id ffacd0b85a97d-3a074e102fdmr1039852f8f.4.1745571669412; Fri, 25 Apr 2025 02:01:09 -0700 (PDT) Received: from [127.0.1.1] ([2a01:cb1d:dc:7e00:3f35:2b31:c543:726d]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3a073c8c95dsm1696571f8f.3.2025.04.25.02.01.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 25 Apr 2025 02:01:08 -0700 (PDT) From: Bartosz Golaszewski Date: Fri, 25 Apr 2025 11:00:59 +0200 Subject: [PATCH 3/5] pinctrl: mediatek: paris: use new GPIO line value setter callbacks Precedence: bulk X-Mailing-List: linux-gpio@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20250425-gpiochip-set-rv-pinctrl-mediatek-v1-3-93e6a01855e7@linaro.org> References: <20250425-gpiochip-set-rv-pinctrl-mediatek-v1-0-93e6a01855e7@linaro.org> In-Reply-To: <20250425-gpiochip-set-rv-pinctrl-mediatek-v1-0-93e6a01855e7@linaro.org> To: Lorenzo Bianconi , Sean Wang , Linus Walleij , Matthias Brugger , AngeloGioacchino Del Regno , Bartosz Golaszewski Cc: linux-mediatek@lists.infradead.org, linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Bartosz Golaszewski X-Mailer: b4 0.14.1 X-Developer-Signature: v=1; a=openpgp-sha256; l=2008; i=bartosz.golaszewski@linaro.org; h=from:subject:message-id; bh=+GvjQy682fLtJAVRTMRFy+x8ClXiXcJ5yyuJiL29z1g=; b=owEBbQKS/ZANAwAKARGnLqAUcddyAcsmYgBoC09QDlA6V2iktjKbxY3hklKfAJlA4oT2QZrGX wXC06aDqWGJAjMEAAEKAB0WIQQWnetsC8PEYBPSx58Rpy6gFHHXcgUCaAtPUAAKCRARpy6gFHHX crgBEACWxWgAT8cG/mDkoN2QVfPEWbfVWtvWFRQXv54q2Iw67Mow6zOgHOghjKXpL3F5MmAovsN Emfn+onAMvQI68zegwOSkt/BV8B29JP7kvYn09WEGSYg54V3sn6V+gzho2WzN8WwpHFitzxdeL6 Qx75OBSlRSQvM+Rg1YOIAUNDCafWhbA7KAotx2YJeIM4T5h62okSwaTplWDAP41WFDFywwRjVl9 JWhc1fGWSZTNrBtbeVHe6xKZSSt2qBQhoVl2Uz8o9q73DJ9+O3SyHomy3YVbvwRKj8aUWohlijR gTwN+ZQx3IFj6xoEwrdToBSusDzy5MU8LcOU0qoT8Q1BpWnmY9hHxECr/NFdbSrgKZRQhVqR6Py 4vImpttpgKXrFDj0vYJdQ49exEqOj16V32VGbfcZOHEzXrfDn3kMlVS0NPDYG2pTmPYuCFjQ84E 9PrGPAeGq3KesqBih6WbmwMKCV99lt2ob3xvDv2odYaXvG5O6t0SXtxGr1JAdpZg+X+d/SAZuLm pQnTg6IlkT0SZDoyNLTglOknViI/mBGdUzsBxWXmEHR5Agu+A49WHMihKIIWUrHlTjO6biMlilg kRA4CWZLI4Sl9xJA7CRIYu8fuqexaPEA6/o4taqQurhZlhFor6vIh5fXZePJsdudZx5Xj4k5wHF pyKFfkhYSs1PzCw== X-Developer-Key: i=bartosz.golaszewski@linaro.org; a=openpgp; fpr=169DEB6C0BC3C46013D2C79F11A72EA01471D772 From: Bartosz Golaszewski struct gpio_chip now has callbacks for setting line values that return an integer, allowing to indicate failures. Convert the driver to using them. Signed-off-by: Bartosz Golaszewski --- drivers/pinctrl/mediatek/pinctrl-paris.c | 12 ++++++++---- 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/drivers/pinctrl/mediatek/pinctrl-paris.c b/drivers/pinctrl/mediatek/pinctrl-paris.c index 852ce0ac7ff9..89ef4e530fcc 100644 --- a/drivers/pinctrl/mediatek/pinctrl-paris.c +++ b/drivers/pinctrl/mediatek/pinctrl-paris.c @@ -874,14 +874,14 @@ static int mtk_gpio_get(struct gpio_chip *chip, unsigned int gpio) return !!value; } -static void mtk_gpio_set(struct gpio_chip *chip, unsigned int gpio, int value) +static int mtk_gpio_set(struct gpio_chip *chip, unsigned int gpio, int value) { struct mtk_pinctrl *hw = gpiochip_get_data(chip); const struct mtk_pin_desc *desc; desc = (const struct mtk_pin_desc *)&hw->soc->pins[gpio]; - mtk_hw_set_value(hw, desc, PINCTRL_PIN_REG_DO, !!value); + return mtk_hw_set_value(hw, desc, PINCTRL_PIN_REG_DO, !!value); } static int mtk_gpio_direction_input(struct gpio_chip *chip, unsigned int gpio) @@ -892,7 +892,11 @@ static int mtk_gpio_direction_input(struct gpio_chip *chip, unsigned int gpio) static int mtk_gpio_direction_output(struct gpio_chip *chip, unsigned int gpio, int value) { - mtk_gpio_set(chip, gpio, value); + int ret; + + ret = mtk_gpio_set(chip, gpio, value); + if (ret) + return ret; return pinctrl_gpio_direction_output(chip, gpio); } @@ -945,7 +949,7 @@ static int mtk_build_gpiochip(struct mtk_pinctrl *hw) chip->direction_input = mtk_gpio_direction_input; chip->direction_output = mtk_gpio_direction_output; chip->get = mtk_gpio_get; - chip->set = mtk_gpio_set; + chip->set_rv = mtk_gpio_set; chip->to_irq = mtk_gpio_to_irq; chip->set_config = mtk_gpio_set_config; chip->base = -1; From patchwork Fri Apr 25 09:01:00 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bartosz Golaszewski X-Patchwork-Id: 884624 Received: from mail-wr1-f53.google.com (mail-wr1-f53.google.com [209.85.221.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7042A24A063 for ; Fri, 25 Apr 2025 09:01:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.53 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745571674; cv=none; b=Ja7LSHICsuPraujqjNIFu3w43izYTuJfUsIxhDVxU3tsPc0a/qoaX66Y/pOz0Tu301UFPRM+hzJmpgnYYMZA08yrUhtLhNnPvA+Dedl963dSZbA25wX1aPEFZk+qPfEvYn3+baujlVQO1cV5dQgsdG+d9KvUBot25G0GBcaN5+c= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745571674; c=relaxed/simple; bh=uN2bLV37uQ7yhWkU01vCeS3PVLdk4JLJCesbUjcmI9E=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=F6hxvW0SvnXokCNDTgEOMVTcnzSEdMXFrVz6WXPYHDpqAbQyjIyGp7C0gH7LaOi+zE0i5VDmqUBmd4dve+B1FLEmWjydQNnHkoeTfucX/SXi7A9tMbb6PdobMXe/DzGAKPX+AJ1ZGR2hwlCnMDZOALhEE1jJGx52Wi3O/okuvDM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl; spf=none smtp.mailfrom=bgdev.pl; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b=u09wwlHn; arc=none smtp.client-ip=209.85.221.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b="u09wwlHn" Received: by mail-wr1-f53.google.com with SMTP id ffacd0b85a97d-3914aba1ce4so1485893f8f.2 for ; Fri, 25 Apr 2025 02:01:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bgdev-pl.20230601.gappssmtp.com; s=20230601; t=1745571671; x=1746176471; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=vZCsMbe0k2wJLLxto/ZgvqQ6R0v/kHbZTO0AQGYG2lM=; b=u09wwlHnfHMNDB14IRJ3ySkdwNEEpoDiW6DiNs/OFKl1XTlirIgsEA4C5n6UA4BmNH L90RVQd0ut6IwEE5RZPcuoKThp+L3z+lNpO2hHnWlkX9a3ysGwRnr2AK88VbRQmLdZIv 3ED26TSwXN573dFOS9+k+OMnBsskkMO0qahAUdVYyQ/dAEHqm81ft7mjEp8Qdmro0Ogm umSRSffROk3OBzhpyeS5mnZW127/awecrIxgujmsk4gM6a4r8F3RxA4dYrT6X7Ba8ScO FSNHZgq7t2Rt8mD8yTkp0DSvKpEbF+W81EjnRoQDAHw9Yv/9UKMJwLf4OQmRfN1y7tSl +b2g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1745571671; x=1746176471; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=vZCsMbe0k2wJLLxto/ZgvqQ6R0v/kHbZTO0AQGYG2lM=; b=E92nZ9JFJbkwVn1zghxyBkoX6aXow7EuPU9PPSnAQ4PnjVoAr0wHW75h6r/5eQyAGJ Kb8KS/zlmQpb7PdceY6WACgQTeTi4i2WckvQ/NBYtNbXrmEQDmiHnWhcdy7B57K38zYL s8NCHfssl81+fKaqVUlpjflVBC1HJ/EH2PXWyMLkgG1FQ20BOpiOkntsLuxEc7KMkObN iepbfWg7G9AX8/+fxeRv7zGxDT108+io57JdtPv22IVF2+6M2niMCxi8KVnHgVrsw9OV 2dvz2fV33TBKS6bgYBSpzv5u6DhRO4O+19P8zeHART8XhxoNmeg2LyxM5HuU49gJsauX cX4w== X-Forwarded-Encrypted: i=1; AJvYcCVS7vrNIEg9JoJLaP0F/Ky4YrU0Cy2VXBr0ZkRouvurAuFyEEp7HOVH/OPUeeBlV/h/LNYiOWIx7tWe@vger.kernel.org X-Gm-Message-State: AOJu0YzjArYhScffwV8skA2ZJUj1Ax/zahYb5SMirmigCoX8kELmAoY3 xSpD9slP3oRYCxHcLkH/i+hRvxIauWepl29skq/YObhmCk8CosZKT0Q60muvVhw= X-Gm-Gg: ASbGncsxsmOczJXjDklHzjh4J057kaeCkgN8exCbaWYMJvS4myz2yPAgxejH54x/9FW xpX/gWOEgVRBTH5PAoL0qVgcXhXmqR/0rpJfBsBCdcDedFRswqrC9wYjUpnjxlpt0yIFKGBC/B/ kU/P4IR5/PGOvzIy0MK6lC61L+zxkkTPc2LuFwrc2Zoz4oF8p2BRwxiHNErTPntLwNMt359sZq8 cWDr3BY709kyW+DAIGgVfmisLy0fHm6gDmW2ou3mxsNGPg3ssc32DSxk94VqUQcwQRbEMHcnsRf S41+kXZq4ngMhIxTh8D7FCtMcIPlbeaSpQ== X-Google-Smtp-Source: AGHT+IGjMuaC5BmBdOAnNw7BlPBWn5JH7qcxJo02GNuwlEcPgWwbqMJDn55V+Su/wdq4y957SwZGFg== X-Received: by 2002:a05:6000:4282:b0:39c:1efb:ee8a with SMTP id ffacd0b85a97d-3a074f39870mr1172764f8f.38.1745571670663; Fri, 25 Apr 2025 02:01:10 -0700 (PDT) Received: from [127.0.1.1] ([2a01:cb1d:dc:7e00:3f35:2b31:c543:726d]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3a073c8c95dsm1696571f8f.3.2025.04.25.02.01.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 25 Apr 2025 02:01:09 -0700 (PDT) From: Bartosz Golaszewski Date: Fri, 25 Apr 2025 11:01:00 +0200 Subject: [PATCH 4/5] pinctrl: mediatek: moore: use new GPIO line value setter callbacks Precedence: bulk X-Mailing-List: linux-gpio@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20250425-gpiochip-set-rv-pinctrl-mediatek-v1-4-93e6a01855e7@linaro.org> References: <20250425-gpiochip-set-rv-pinctrl-mediatek-v1-0-93e6a01855e7@linaro.org> In-Reply-To: <20250425-gpiochip-set-rv-pinctrl-mediatek-v1-0-93e6a01855e7@linaro.org> To: Lorenzo Bianconi , Sean Wang , Linus Walleij , Matthias Brugger , AngeloGioacchino Del Regno , Bartosz Golaszewski Cc: linux-mediatek@lists.infradead.org, linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Bartosz Golaszewski X-Mailer: b4 0.14.1 X-Developer-Signature: v=1; a=openpgp-sha256; l=1973; i=bartosz.golaszewski@linaro.org; h=from:subject:message-id; bh=K7gLMO3ecqvlBUfWOX7ZuqqYALbBQMdAQOJ0o+WSEZA=; b=owEBbQKS/ZANAwAKARGnLqAUcddyAcsmYgBoC09Qz3rBKY7vXoDHlL6r3flVEWoOZY6T/FJWf h5JONq15geJAjMEAAEKAB0WIQQWnetsC8PEYBPSx58Rpy6gFHHXcgUCaAtPUAAKCRARpy6gFHHX cisXD/9P57W0/UnC7KoUOw8VjozyNtjJ1rN06vVzNxprMdmp9PDpNlGb0vTLsahD+4NFVA3Q1BL p1W7I+viQtlMMu9GaPYfJgGOurfA8HdjHskblOFIVaifefVYzwy2jSyIPjndcW+rdrur5zeAwkl 2zepHYZVYpZK45EtIf+V/938Oo0Sfmprv9Jio66HVvXGnuznGrUD4gS7j1tXl1/KdBqqIks4J7K IZwYIGhxQCVmj55ubdey7G1qgtAqasXlnOmq9xRmLGU3IIqENBgY9EV9KwrH+voXt3ICY6gqxy5 ecCqIeMwR2gTvsucRyqxVP3ZfLDYlzvJG77PA5K+BBEorzi/oTKKRomwKzJl/s/iWZb4zX97gER t2Zzm2q4K5EzXkWxGUzYdSPep/j22uNtt+kTIzw6PK0XYmS5NPOcvVC8rmjW1NGTOGndaoMkDHY 6MGmD/rpGacA17KSYUf+2PPtddEV5m0SDFIR41604HfByN99tInJvAKoH7Kn9s39Mc0stpq/RdX tCJiiYx/RWCcSM5ECjAiBzfR0o3lAyuS7+JcM7IAzc+W1rRG7ZJM6VQyOw95oe3Iupn4SLvv6yR Yw2WuWfIJnLiAzyPLUNqqXVE3CeyFs8pJuou+r91bJDnhIWJo7Ukqz9HMV6keK0XO6MUEid9Dec y24dE/UdR6r4niw== X-Developer-Key: i=bartosz.golaszewski@linaro.org; a=openpgp; fpr=169DEB6C0BC3C46013D2C79F11A72EA01471D772 From: Bartosz Golaszewski struct gpio_chip now has callbacks for setting line values that return an integer, allowing to indicate failures. Convert the driver to using them. Signed-off-by: Bartosz Golaszewski --- drivers/pinctrl/mediatek/pinctrl-moore.c | 18 ++++++++++-------- 1 file changed, 10 insertions(+), 8 deletions(-) diff --git a/drivers/pinctrl/mediatek/pinctrl-moore.c b/drivers/pinctrl/mediatek/pinctrl-moore.c index aad4891223d3..827d0f191031 100644 --- a/drivers/pinctrl/mediatek/pinctrl-moore.c +++ b/drivers/pinctrl/mediatek/pinctrl-moore.c @@ -496,24 +496,26 @@ static int mtk_gpio_get(struct gpio_chip *chip, unsigned int gpio) return !!value; } -static void mtk_gpio_set(struct gpio_chip *chip, unsigned int gpio, int value) +static int mtk_gpio_set(struct gpio_chip *chip, unsigned int gpio, int value) { struct mtk_pinctrl *hw = gpiochip_get_data(chip); const struct mtk_pin_desc *desc; desc = (const struct mtk_pin_desc *)&hw->soc->pins[gpio]; - if (!desc->name) { - dev_err(hw->dev, "Failed to set gpio %d\n", gpio); - return; - } + if (!desc->name) + return -ENOTSUPP; - mtk_hw_set_value(hw, desc, PINCTRL_PIN_REG_DO, !!value); + return mtk_hw_set_value(hw, desc, PINCTRL_PIN_REG_DO, !!value); } static int mtk_gpio_direction_output(struct gpio_chip *chip, unsigned int gpio, int value) { - mtk_gpio_set(chip, gpio, value); + int ret; + + ret = mtk_gpio_set(chip, gpio, value); + if (ret) + return ret; return pinctrl_gpio_direction_output(chip, gpio); } @@ -567,7 +569,7 @@ static int mtk_build_gpiochip(struct mtk_pinctrl *hw) chip->direction_input = pinctrl_gpio_direction_input; chip->direction_output = mtk_gpio_direction_output; chip->get = mtk_gpio_get; - chip->set = mtk_gpio_set; + chip->set_rv = mtk_gpio_set; chip->to_irq = mtk_gpio_to_irq; chip->set_config = mtk_gpio_set_config; chip->base = -1; From patchwork Fri Apr 25 09:01:01 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bartosz Golaszewski X-Patchwork-Id: 885107 Received: from mail-wr1-f49.google.com (mail-wr1-f49.google.com [209.85.221.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0565824BD0C for ; Fri, 25 Apr 2025 09:01:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.49 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745571675; cv=none; b=hFcnmy6H1yhlEsvl59QjNeU66xQNEJIVnNSXXhhkGUpp1YwrewCK4rYn77FviZQFuehMN7pGWbCQBA0JZgfVrmxmW1ukAbKlmDxSV2M5uNRsp2+7bK+ELM8pzRYq4IxRt6x0ehvNLe/985acEFo+8U3KvFmyXUQPT5ggw1TNF9s= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745571675; c=relaxed/simple; bh=jbtD4lxoo1Rym8zGIQhQtZtmYwoyyWZdSONqwD+LmXY=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=R2QlyynPZvy4Z5Tu51bj5DsawOobFDgVzT8oR99je//KBVmMHagYMnb+Uyl0+tHZrXmHviWhZAqofhER5WIg5hYeqqZF/hIcHHhkw9Sfnmy0kwGzOL8DM7T4Fbz4wyLCrzhz4YB94xi/ex0fFGZ9Wr0SQsUvpTf09LjJn1wbWgg= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl; spf=none smtp.mailfrom=bgdev.pl; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b=H0lBOLMg; arc=none smtp.client-ip=209.85.221.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b="H0lBOLMg" Received: by mail-wr1-f49.google.com with SMTP id ffacd0b85a97d-39c13fa05ebso1286268f8f.0 for ; Fri, 25 Apr 2025 02:01:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bgdev-pl.20230601.gappssmtp.com; s=20230601; t=1745571672; x=1746176472; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=bSvrLQBfLq+B4ut1ceVEmi9/bo2rmWrizkJ6hXk1M/s=; b=H0lBOLMgy6mEpMCFeYJOt4AYsHm0+x5PW3AxnlmDOHAoEtnxziU02zBEN8dLJmFdy0 1z9E/BcVUqKsVmQOcaSTPkGdKhtnv7QMdPurpIAZ+OWnzZCRHaNmYuMWr5KjGZc+IAVR jyKqQO+AG39VmHx269jdEtCyIZbIhxCxrT35guldMi0/8nTyb7KOJFutI1ZikvZ1JfjR i4ynuU3F02m62MBmZeRuoL2nuqVtfPsjBZI21qzQbwxqgbXkOHIrE11lQAcLQgjTFGS7 FnTH1Y939hW03Cyx1PFL4oyMikGDtsLKGFo28lhB5hcPc4baVLkCP4FP5S8W9iV/B0CC 9/1Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1745571672; x=1746176472; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=bSvrLQBfLq+B4ut1ceVEmi9/bo2rmWrizkJ6hXk1M/s=; b=FS6BPrxW4qArVFrQA1OCeCjv4HvzV2jP3GIwABZvRbOWXPjzrdGRhpG2jbJwoN25Wc zwDpiYEX18E14NmAoCa+KzTh0qQAOAe0T/Hx+r/KkT7SUalhK81Kt4DGrgqlxpuZKTo/ mA4Ek3JxRsZOiE+YbgBCWfSwb5Y0+qn8HeNi6iJzXgH3yTyu1WpwLsbZ9PjrfI2W458q sJiEAHZFvvQ3Wd800wRGexfZnuFSmiFEH92e+7sXiU77falcUo8jshR8w7y8YoIVq9k+ UQ9hlupk8RttqeYbxWPB0BZpty85pnod1Rcme1ESK5thg8J5wxH2zSgGlXs7jzDK/E06 Mwrg== X-Forwarded-Encrypted: i=1; AJvYcCXjfbR/4RaszxAD6T+RHv4IEJ0CdI0w2E1FUs4QBRzBtpSUZMOYzr5vTn2PoPnQWODbMdWOhMSOpk0C@vger.kernel.org X-Gm-Message-State: AOJu0YyRp1Id6woNEaRbrSbcIUzrg9qltPi6qat41TMeSf/Ie4ooYT3r GQ/pL/idfnNWhbNmiMY43uFPGbbSgd6PfANyCT1pcrFaRtZUCsE3OwobpInUizI= X-Gm-Gg: ASbGnctYP84vTyfsXqy0ti05Cnba2CrfYRJF+4XG3RoeF7QiFcg6K316X4St45yVUpO ck6VmPIObiKdfUXUk2N7LyjrM8s5YaZaZNyxJW7qvsRw3gl79ZqynwhMOXBKJflyrLe0aT8w2zo BxX8XHfmexOpwxkAURf4cBaDf5RkQ0BChk2cVmWzBdBvSDYLVcYNmQbiGfObTgSGCm6bG8jlOEQ ZDf9i+qSI7Vk8GKvpnyUB1lJpAN0os7TS2E/D44lC3pp43HXeQzWKZvYIEcLUouqfoohxshgopJ V9bdgWLAVkId5aFJQDELHpF1sLoA1Iscdw== X-Google-Smtp-Source: AGHT+IESAKBg/vUZr7+HdyTu7Zt6c8/2gvrqKe9AqCVjAbPvKvH7CRuaevUBHKKYT49ezlwSd/p7oQ== X-Received: by 2002:a05:6000:290b:b0:39e:cbd2:9211 with SMTP id ffacd0b85a97d-3a074faf2f4mr1109587f8f.55.1745571672261; Fri, 25 Apr 2025 02:01:12 -0700 (PDT) Received: from [127.0.1.1] ([2a01:cb1d:dc:7e00:3f35:2b31:c543:726d]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3a073c8c95dsm1696571f8f.3.2025.04.25.02.01.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 25 Apr 2025 02:01:11 -0700 (PDT) From: Bartosz Golaszewski Date: Fri, 25 Apr 2025 11:01:01 +0200 Subject: [PATCH 5/5] pinctrl: mediatek: common: use new GPIO line value setter callbacks Precedence: bulk X-Mailing-List: linux-gpio@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20250425-gpiochip-set-rv-pinctrl-mediatek-v1-5-93e6a01855e7@linaro.org> References: <20250425-gpiochip-set-rv-pinctrl-mediatek-v1-0-93e6a01855e7@linaro.org> In-Reply-To: <20250425-gpiochip-set-rv-pinctrl-mediatek-v1-0-93e6a01855e7@linaro.org> To: Lorenzo Bianconi , Sean Wang , Linus Walleij , Matthias Brugger , AngeloGioacchino Del Regno , Bartosz Golaszewski Cc: linux-mediatek@lists.infradead.org, linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Bartosz Golaszewski X-Mailer: b4 0.14.1 X-Developer-Signature: v=1; a=openpgp-sha256; l=1986; i=bartosz.golaszewski@linaro.org; h=from:subject:message-id; bh=DhR5Cx+h0tuPThTQMfkVBP7GDMglNgqo3TCYghOZtTc=; b=owEBbQKS/ZANAwAKARGnLqAUcddyAcsmYgBoC09Q1qfvXLmie8Ad0KxRLSMtwSzORIC9DHLME ux5GcRSG1uJAjMEAAEKAB0WIQQWnetsC8PEYBPSx58Rpy6gFHHXcgUCaAtPUAAKCRARpy6gFHHX cin/D/wN4TReNcVZdJpBQ3ij4ORtqXCjpIzT8TejLJmPbAW7VRLBI73Sot2lYEh6ivMjaPGV+Ez ff8t2p6qHWL0XyeySWLjPm6Sa+nVqRjbyFGUOty8iQicWy3VgU0h6OZYaOlbXE3HSchUFE7AuvP l/20EdnceslbHDVHXe3uDbsWvxyZn5zCj0Kq78XggHgGsprpI2qVyAFDUBbwaWh+1+myh7YJx/X yJvdjTBEdvqoMiqeuJaYhx/t/paIekWXTGSEKqVdHPp1hzb6KRCrycp6u6jzsZvnNsrMKcXHxb8 9/3Gc6GRcWE7CxSmBqB9B0mJTdhSHRZa3YIRQTpeMxWjxGa30VQ7vMJvHygVdwcFOueRtPlcXZz gU7YuuI7Ug885r7Xoodq798CBFf2KN6mjY699nAmfRjbxVv+FxH1WyP0WBmENEtDQ8VHxfPJbgP WWvfpj0aKZTuEMTvbguqYDv8tC6fjQApPkWtivimKfsAvwjsxNqFKKgcWTlaNMCai5ye1+WNLlF o2XVBinR1y8178arKTT0Sa1lWO97DQwu63sYqqlePtrT+KmXA6ixprYXzYR5iBLI0RZGMNF10bP T1xXXdlDIe8hx3XfKDVXoo/cUL60hAqfNjdG3/Z8zF7bbaR3dzsYYEOsDCOqiO/bRA3AGSM9R8D Y/dstQRT5IQGDZA== X-Developer-Key: i=bartosz.golaszewski@linaro.org; a=openpgp; fpr=169DEB6C0BC3C46013D2C79F11A72EA01471D772 From: Bartosz Golaszewski struct gpio_chip now has callbacks for setting line values that return an integer, allowing to indicate failures. Convert the driver to using them. Signed-off-by: Bartosz Golaszewski --- drivers/pinctrl/mediatek/pinctrl-mtk-common.c | 13 +++++++++---- 1 file changed, 9 insertions(+), 4 deletions(-) diff --git a/drivers/pinctrl/mediatek/pinctrl-mtk-common.c b/drivers/pinctrl/mediatek/pinctrl-mtk-common.c index 8596f3541265..de7bebb9a6cd 100644 --- a/drivers/pinctrl/mediatek/pinctrl-mtk-common.c +++ b/drivers/pinctrl/mediatek/pinctrl-mtk-common.c @@ -86,7 +86,7 @@ static int mtk_pmx_gpio_set_direction(struct pinctrl_dev *pctldev, return 0; } -static void mtk_gpio_set(struct gpio_chip *chip, unsigned offset, int value) +static int mtk_gpio_set(struct gpio_chip *chip, unsigned int offset, int value) { unsigned int reg_addr; unsigned int bit; @@ -100,7 +100,7 @@ static void mtk_gpio_set(struct gpio_chip *chip, unsigned offset, int value) else reg_addr = CLR_ADDR(reg_addr, pctl); - regmap_write(mtk_get_regmap(pctl, offset), reg_addr, bit); + return regmap_write(mtk_get_regmap(pctl, offset), reg_addr, bit); } static int mtk_pconf_set_ies_smt(struct mtk_pinctrl *pctl, unsigned pin, @@ -809,7 +809,12 @@ static const struct pinmux_ops mtk_pmx_ops = { static int mtk_gpio_direction_output(struct gpio_chip *chip, unsigned offset, int value) { - mtk_gpio_set(chip, offset, value); + int ret; + + ret = mtk_gpio_set(chip, offset, value); + if (ret) + return ret; + return pinctrl_gpio_direction_output(chip, offset); } @@ -893,7 +898,7 @@ static const struct gpio_chip mtk_gpio_chip = { .direction_input = pinctrl_gpio_direction_input, .direction_output = mtk_gpio_direction_output, .get = mtk_gpio_get, - .set = mtk_gpio_set, + .set_rv = mtk_gpio_set, .to_irq = mtk_gpio_to_irq, .set_config = mtk_gpio_set_config, };