From patchwork Thu Apr 24 12:23:23 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Zijun Hu X-Patchwork-Id: 885437 Received: from outbound.pv.icloud.com (p-west1-cluster1-host10-snip4-7.eps.apple.com [57.103.64.100]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 193A72367AE for ; Thu, 24 Apr 2025 12:23:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=57.103.64.100 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745497437; cv=none; b=XMV7+2iCGZt7ts3c5y9f9DG+Zc5rNLMKnj58NV8/Taai6/Y3tDgV5QrilomwUCbOk+hGi4Dw4PomSIe/nDMwvDNZK392Gz0ASFHtcWcH70Qcz0EXu2/sr9iVCjB71d2+WsxMFUU4vNTh14cMS4xI3NcEXMvUKlKfhdFFnVDwUH4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745497437; c=relaxed/simple; bh=xyn4t08/3/H1FQ9ERFo0iaNVmWPh8m4pr270tDN4EyU=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=JZwTT4MnhTtgruHsZR89cHb1Q/nvdkm9zXg78PQ+4a9JLK1PQ+0ZIJzURLJNhvRnLrL8q+cKeh+knsEw/dLKOTHbL/TadKuV/ISzc8Ox9LCc00d5Bck41bux2O6LvW6U0gW+d1PiJNHoKPPvnnzaJhUY+2HMZayemiylkIyPfPc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=icloud.com; spf=pass smtp.mailfrom=icloud.com; dkim=pass (2048-bit key) header.d=icloud.com header.i=@icloud.com header.b=P5xQbxtM; arc=none smtp.client-ip=57.103.64.100 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=icloud.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=icloud.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=icloud.com header.i=@icloud.com header.b="P5xQbxtM" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=icloud.com; s=1a1hai; bh=xe6UzvOMcVAJcVfnvcPb6lA8c70wu+ep9ZsTAP9kDaU=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:To:x-icloud-hme; b=P5xQbxtM7HIUtV0N5FrgLVxLQ0gkPDz1kQkP5HbT3F/LwfVUtJ+4pqL342Isuw43B iOuqtYRlGGqDczAYLRMRtzaUa6bX2n28cffb7riwhn1W5eitvMS0YCjZU1ffnduO0w o8NxdGJcWwu0XAHpA8HYjUjEpmIDa+fvF1sSS5LXRg3C71nNBy2EHnGzuLB+z25N1n mW547TGYpGBl5UwJnuiQ026AMrZbBlYvmMa5QWAeLeecpEn9bZehRFoBdSHLWqgF6v FWObkiQD94sKgfjG8M84Sxt4/powLjazOYoV6vi46b8tU7KvRchNLX+ao+eo2cuX6T zGM4Og5RWEMJw== Received: from [192.168.1.26] (pv-asmtp-me-k8s.p00.prod.me.com [17.56.9.36]) by outbound.pv.icloud.com (Postfix) with ESMTPSA id 42EBF180074A; Thu, 24 Apr 2025 12:23:49 +0000 (UTC) From: Zijun Hu Date: Thu, 24 Apr 2025 20:23:23 +0800 Subject: [PATCH v2 1/2] serdev: Get serdev controller's name by dev_name() Precedence: bulk X-Mailing-List: linux-serial@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20250424-fix_serdev-v2-1-a1226ed77435@quicinc.com> References: <20250424-fix_serdev-v2-0-a1226ed77435@quicinc.com> In-Reply-To: <20250424-fix_serdev-v2-0-a1226ed77435@quicinc.com> To: Rob Herring , Greg Kroah-Hartman , Jiri Slaby Cc: Zijun Hu , linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org, Zijun Hu X-Mailer: b4 0.14.2 X-Proofpoint-GUID: lubaLBDmipTmHZWQt1YEeUV3N27OX-Pb X-Proofpoint-ORIG-GUID: lubaLBDmipTmHZWQt1YEeUV3N27OX-Pb X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1099,Hydra:6.0.680,FMLib:17.12.80.40 definitions=2025-04-24_05,2025-04-22_01,2025-02-21_01 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 phishscore=0 clxscore=1015 mlxlogscore=958 adultscore=0 malwarescore=0 spamscore=0 mlxscore=0 bulkscore=0 suspectscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.19.0-2411120000 definitions=main-2504240083 From: Zijun Hu serdev_controller_add() uses hardcoded serdev controller's name, and that may be wrong once user changes the name after serdev_controller_alloc(). Fix by using dev_name() instead of hardcoded name. Signed-off-by: Zijun Hu --- drivers/tty/serdev/core.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/tty/serdev/core.c b/drivers/tty/serdev/core.c index eb2a2e58fe78fbbdb5839232936a994bda86d0b4..971651b8e18dcbb5b7983cdfa19e7d60d4cd292b 100644 --- a/drivers/tty/serdev/core.c +++ b/drivers/tty/serdev/core.c @@ -783,8 +783,8 @@ int serdev_controller_add(struct serdev_controller *ctrl) goto err_rpm_disable; } - dev_dbg(&ctrl->dev, "serdev%d registered: dev:%p\n", - ctrl->nr, &ctrl->dev); + dev_dbg(&ctrl->dev, "%s registered: dev:%p\n", + dev_name(&ctrl->dev), &ctrl->dev); return 0; err_rpm_disable: From patchwork Thu Apr 24 12:23:24 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Zijun Hu X-Patchwork-Id: 884273 Received: from outbound.pv.icloud.com (p-west1-cluster4-host10-snip4-10.eps.apple.com [57.103.65.171]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 09B432309B5 for ; Thu, 24 Apr 2025 12:24:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=57.103.65.171 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745497444; cv=none; b=JyC2mcFO6Iho/aC1KKPK/SRuSG8MsgV8i8pMU4F2yFrgyLhevZcr+gXhWa8HcOy+eBYMskIJqV1rmOK+uvntmKgHOllIAjWRHaoq4L8jd77SjqC963SGktgv3aQmdt+yTtLzuWOxYIzO7uglRGaUhVzKW4aHwOlgv1iyOyLg7kk= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745497444; c=relaxed/simple; bh=Svj8K2mMfw7MHqeGqhHzAiT2JUFa4P4M2Mj1oniQpxI=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=GTNDm//qIuD1RRHW27pLg/XoLOEnfIPfDhQXxR6SfhVqQQtBiMJUFJdnOo5hUYeAziI9rQWlr5gyGsu8zSM/s3l+aPcXXqQaPTmQLsfPqtOArJkeOjzn+1N5CMiqEayFoR0lZv7PdMWoxd3p6jBW5ajKmwd8HqCfNEsz59xpmF8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=icloud.com; spf=pass smtp.mailfrom=icloud.com; dkim=pass (2048-bit key) header.d=icloud.com header.i=@icloud.com header.b=v420VHWZ; arc=none smtp.client-ip=57.103.65.171 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=icloud.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=icloud.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=icloud.com header.i=@icloud.com header.b="v420VHWZ" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=icloud.com; s=1a1hai; bh=gzrc5Jt8l/p14lYtc9/COl7AJ4Ldszvxo6hIDOzbFJw=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:To:x-icloud-hme; b=v420VHWZySKjaGTu55npG0wDi7NWc9C9XKyZhky7BV/WD7vj+TjJRLKyr7y3iNmR3 DyGMT0YjgqwkILJIEcFHsCfGaKp2w9aoHROSxywRXZsfFKip9Js2B82qHmo/At2wCu 4kGXJA/VHDL2NN+fghpNwIqSIAyKLK3wrrlC/ok3wmmGQr4evOsu4QmGjeeKJCI5vs WIf02SWB0o+gKFvQSpwxeld7yv48oyRJiK4qZg3hrCbC9hB2QPOkYnwNybzj03g55F iWSqDG9tHdALMHwOd3IRX20nica55PiJb9beQTnpkKUTEdsxexZre11zmYFMSo3425 ZqJn1iUr1bGpg== Received: from [192.168.1.26] (pv-asmtp-me-k8s.p00.prod.me.com [17.56.9.36]) by outbound.pv.icloud.com (Postfix) with ESMTPSA id 1D5A71800631; Thu, 24 Apr 2025 12:23:55 +0000 (UTC) From: Zijun Hu Date: Thu, 24 Apr 2025 20:23:24 +0800 Subject: [PATCH v2 2/2] serdev: Remove repeated device name in dev_(err|dbg) messages Precedence: bulk X-Mailing-List: linux-serial@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20250424-fix_serdev-v2-2-a1226ed77435@quicinc.com> References: <20250424-fix_serdev-v2-0-a1226ed77435@quicinc.com> In-Reply-To: <20250424-fix_serdev-v2-0-a1226ed77435@quicinc.com> To: Rob Herring , Greg Kroah-Hartman , Jiri Slaby Cc: Zijun Hu , linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org, Zijun Hu X-Mailer: b4 0.14.2 X-Proofpoint-GUID: 0CwPusDRHzQvMoJAS0Ky4AcKP0w1k66l X-Proofpoint-ORIG-GUID: 0CwPusDRHzQvMoJAS0Ky4AcKP0w1k66l X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1099,Hydra:6.0.680,FMLib:17.12.80.40 definitions=2025-04-24_05,2025-04-22_01,2025-02-21_01 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 phishscore=0 clxscore=1015 mlxlogscore=999 adultscore=0 malwarescore=0 spamscore=0 mlxscore=0 bulkscore=0 suspectscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.19.0-2411120000 definitions=main-2504240083 From: Zijun Hu There are serval dev_err() and dev_dbg() usages shown below: dev_dbg(dev, "...%s...", dev_name(dev)) The device name is repeated since dev_dbg() also prints device name as prefix. Fix by optimizing the messages printed. Signed-off-by: Zijun Hu --- drivers/tty/serdev/core.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/tty/serdev/core.c b/drivers/tty/serdev/core.c index 971651b8e18dcbb5b7983cdfa19e7d60d4cd292b..f00106de76a0f1e547310c7d21cc2fe3d5869e28 100644 --- a/drivers/tty/serdev/core.c +++ b/drivers/tty/serdev/core.c @@ -118,12 +118,12 @@ int serdev_device_add(struct serdev_device *serdev) err = device_add(&serdev->dev); if (err < 0) { - dev_err(&serdev->dev, "Can't add %s, status %pe\n", - dev_name(&serdev->dev), ERR_PTR(err)); + dev_err(&serdev->dev, "Can't add serdev, status %pe\n", + ERR_PTR(err)); goto err_clear_serdev; } - dev_dbg(&serdev->dev, "device %s registered\n", dev_name(&serdev->dev)); + dev_dbg(&serdev->dev, "serdev registered successfully\n"); return 0; @@ -783,8 +783,8 @@ int serdev_controller_add(struct serdev_controller *ctrl) goto err_rpm_disable; } - dev_dbg(&ctrl->dev, "%s registered: dev:%p\n", - dev_name(&ctrl->dev), &ctrl->dev); + dev_dbg(&ctrl->dev, "serdev controller registered: dev:%p\n", + &ctrl->dev); return 0; err_rpm_disable: