From patchwork Wed Apr 23 07:53:50 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bartosz Golaszewski X-Patchwork-Id: 884110 Received: from mail-wr1-f50.google.com (mail-wr1-f50.google.com [209.85.221.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 771542741C3 for ; Wed, 23 Apr 2025 07:54:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.50 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745394845; cv=none; b=E0d9+hesaBpGyYiIlurWGtSvJHP/VM7I+LYDUDQ91ss8VpEYK3Udu3HW1Exp4yi7Ttax83burntHr0Q3baDFgIqEfwBEk82nTzcCMcVduYEU+fJPL4z+QNByiB7wGovQaLFEBK1rxxW9dIr2TpMoTKNx3iEbXHOxu98frK71OFI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745394845; c=relaxed/simple; bh=sCy5NeyycV32ZFT/SmRZqkdiozOKWMJ6jALzEvjVFEU=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=pQPfLBb16kXt2ld+atTcC15lwe7T7YrUOIh6VQox5eYp80+cPvl21Wv+MeLoyG7lvaO3CePpWE6AI+meQnWELb5m+g9ef1WfSE9LBZ7Nodx7TlrWyASQWnVqHeuayPMm205d6VD13Um2VEaE+gZwmBcY9VJQOzXkt4vRfXLiRiU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl; spf=none smtp.mailfrom=bgdev.pl; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b=vBU9ilyS; arc=none smtp.client-ip=209.85.221.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b="vBU9ilyS" Received: by mail-wr1-f50.google.com with SMTP id ffacd0b85a97d-3912d2c89ecso5056536f8f.2 for ; Wed, 23 Apr 2025 00:54:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bgdev-pl.20230601.gappssmtp.com; s=20230601; t=1745394842; x=1745999642; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=3Yu2B6Dfdj7hXwrKNPHrcuBuguJrhn9KHB4prAy73JA=; b=vBU9ilySXIUPoTG3iQbj/PbG9CD5+lKsJyTj1w9PWLdgoT9t4o+6eiyq3NG33yacTr ouUgMxmLxPArsotpZyWyO5nXLRFGeP2JrbgRpQ1VOqnxyc9BrkHTAPI1kv4cvlVq4+g6 DtSmNU+oGTtpJEeRdhyhzWgrLc9V7eSIsJ1wNhoHceQ2yBe4ugo0GcT0rhQqGs9H3YCL +QyUmlQa85be51mKmXJsoJsva4IWn+qsGU2n0KSAll4p1PMW4Oo66x9gp3sUYOUUYoUb 1YxUSyhx3J/QVDd9Yp7KhK00kHhhjzjwhcj2EL8CTG2S7c86XvfgxfIr7K+fMgQyuOp+ nXUw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1745394842; x=1745999642; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=3Yu2B6Dfdj7hXwrKNPHrcuBuguJrhn9KHB4prAy73JA=; b=EuP81mblYRFXT2U/JzluBHQF31SGu0Manwx0pvrmOptQw+4MNzC+NxPd8wtqY9deEL CRc+zFrDjUzf6v9GSAtgy71d4c5n4tc5TyRAxCWJ/IAdo4RyqUMLykHwGZs4TFJgrD7H wXjQBzoz3xq7g8i12wkcO2LhqfGqfvcGso+Nz+lc1s+kgsgnRC07EA7JyGA7FUJVq1bs gyoZ5dZfcgHpNIcG70vdFiPpDsIb9J26aU70MuDw/v/fS4qEPxrEdmBo3e53oByDabsb woSFKfAAIRwXYvQCDZINdlHSwbBcPuZhvt1NiZJ2q7IVSrWRFLHKQlXGH81B3n2l/Gmc GHAw== X-Gm-Message-State: AOJu0YwQMBUgNVjVa675urKuuEjb/hwPPul6/bDzdzDl2fmyazIweDxo znsv2PjvdWbNJw+7RgWzzWGfnxIeHX9oSyrC/Yo3p59jXzEf7STFlhu+9ow4IdY= X-Gm-Gg: ASbGncsnlaSu84JdnFmhOYescD3zYH4/FJe8hLoaFzmZxZDj18DqLwiUzeRHHHv0Wuf m+QZbcASLz4iz0x8mVfdsiYk+WHLMah7cIkeTy/VJEZXj4GVNY0tJ4HLFBUDkr70Wt5a5A/Zsv8 0tJFauPEQszEjTLNthieqggAKn3ufrPsUu/l6EvFQ3acNGXv2EcQf+5U6wtaXu9tNoA5D/ErlMr 1bpgfcVUWeV024WCkM+BoI23itl413Mc+s+4IYi4LSAdA3NYD+H031ScuIbpgHFH/ODFq35qRmH ATBHUT6qoNpxeUgZ2OpuOf4oR8ns8qCvOA== X-Google-Smtp-Source: AGHT+IHatYCxnScGlxG87IK46dtvJduo0XuMEsaC1y7/BEaXRE/DSRM5w5YythQpUe474HkAYKao6w== X-Received: by 2002:a05:6000:1ac9:b0:390:dfa1:3448 with SMTP id ffacd0b85a97d-39efbacfc53mr15450031f8f.43.1745394841674; Wed, 23 Apr 2025 00:54:01 -0700 (PDT) Received: from [127.0.1.1] ([2a01:cb1d:dc:7e00:74b0:71bd:6dda:dcc1]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-39efa4330d8sm18266655f8f.33.2025.04.23.00.54.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 23 Apr 2025 00:54:01 -0700 (PDT) From: Bartosz Golaszewski Date: Wed, 23 Apr 2025 09:53:50 +0200 Subject: [PATCH 1/4] leds: lgm-sso: use new line value setter callbacks Precedence: bulk X-Mailing-List: linux-leds@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20250423-gpiochip-set-rv-leds-v1-1-2f42d8fbb525@linaro.org> References: <20250423-gpiochip-set-rv-leds-v1-0-2f42d8fbb525@linaro.org> In-Reply-To: <20250423-gpiochip-set-rv-leds-v1-0-2f42d8fbb525@linaro.org> To: Lee Jones , Pavel Machek , Linus Walleij , Bartosz Golaszewski , Riku Voipio Cc: linux-leds@vger.kernel.org, linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, Bartosz Golaszewski X-Mailer: b4 0.14.1 X-Developer-Signature: v=1; a=openpgp-sha256; l=1615; i=bartosz.golaszewski@linaro.org; h=from:subject:message-id; bh=K5A9vi+sTXjh4YAzZucX9KK05Nsn0WvlpjHF6gNLFV8=; b=owEBbQKS/ZANAwAKARGnLqAUcddyAcsmYgBoCJyX/mB8z42UH7vVXi4u6OPF6UZICjwIQ3yLE HkQSNpBofyJAjMEAAEKAB0WIQQWnetsC8PEYBPSx58Rpy6gFHHXcgUCaAiclwAKCRARpy6gFHHX clLhEADKTRSWatjKVRUHVfZtcveYdXevLl6ot2u8ju67n79RYjtXSYoJZNSoUhLJysJx3uc98K/ Gz5Hk1uqM0IkpMDd+5wSXvadxG3pGF212nev9ze70d1fdfkTbgydPWhVYrFkmOvPumcFjOXAYpE 3jUiTpUV8mRCmlD6xUP/uXke9Zx++M+vO9m935xjeqZJ4/Y31u05FDd0C/P3FVAEjwQIQvg6i/9 V+6TxINRtHoLqnTc89xJnnS1BlljM+LAH/bvlNJfQZ6y5psArwBf5FUFv64xqPIDWS90hLy6TT6 G6LY7McaSa6o66JvL+qudztr/kEAiDEaBY/nVLzPD+p7gs2dXlzPcHaDNU0yKIhFwd2P9BN7H/J 5HiA5m+29RGUax0cP/BuX3xvwjQ1MXP7KPEQgd842OHvqFsVFDcqgoDP2Yc0iLJPnOdnw6z37bC aJig3cuBo3YNjCLcGZAHoEWBLb2lFn9otAgEMe5/ASUTnkg5hmHGFrCZsgqG8BVc9t8WmMtaaRi J1LOobI6UMC1kZC830TwHAKa5TjiB9I4B1sfKyAxbMr9mIR8JuLs1ZkoXmO9XsLRKFYC6/WuEKY hZ2m5B2oc1EutgqSbKRZBtYYQg3VX5swPxGuYFunNTZih4eqG5/thwyeQjG1QE9m6TSqgLi9iFk E/mUMgkgAUeQrUQ== X-Developer-Key: i=bartosz.golaszewski@linaro.org; a=openpgp; fpr=169DEB6C0BC3C46013D2C79F11A72EA01471D772 From: Bartosz Golaszewski struct gpio_chip now has callbacks for setting line values that return an integer, allowing to indicate failures. Convert the driver to using them. Signed-off-by: Bartosz Golaszewski --- drivers/leds/blink/leds-lgm-sso.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/leds/blink/leds-lgm-sso.c b/drivers/leds/blink/leds-lgm-sso.c index effaaaf302b5..c9027f9c4bb7 100644 --- a/drivers/leds/blink/leds-lgm-sso.c +++ b/drivers/leds/blink/leds-lgm-sso.c @@ -450,7 +450,7 @@ static int sso_gpio_get(struct gpio_chip *chip, unsigned int offset) return !!(reg_val & BIT(offset)); } -static void sso_gpio_set(struct gpio_chip *chip, unsigned int offset, int value) +static int sso_gpio_set(struct gpio_chip *chip, unsigned int offset, int value) { struct sso_led_priv *priv = gpiochip_get_data(chip); @@ -458,6 +458,8 @@ static void sso_gpio_set(struct gpio_chip *chip, unsigned int offset, int value) if (!priv->gpio.freq) regmap_update_bits(priv->mmap, SSO_CON0, SSO_CON0_SWU, SSO_CON0_SWU); + + return 0; } static int sso_gpio_gc_init(struct device *dev, struct sso_led_priv *priv) @@ -469,7 +471,7 @@ static int sso_gpio_gc_init(struct device *dev, struct sso_led_priv *priv) gc->get_direction = sso_gpio_get_dir; gc->direction_output = sso_gpio_dir_out; gc->get = sso_gpio_get; - gc->set = sso_gpio_set; + gc->set_rv = sso_gpio_set; gc->label = "lgm-sso"; gc->base = -1; From patchwork Wed Apr 23 07:53:51 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bartosz Golaszewski X-Patchwork-Id: 883673 Received: from mail-wm1-f49.google.com (mail-wm1-f49.google.com [209.85.128.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E89C82749DE for ; Wed, 23 Apr 2025 07:54:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.49 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745394848; cv=none; b=NLwujvtHLJPLFXP4DyPp8Z6CFrgXaD5c91zoeYvlCYfnINkNYxZl4ZiLPtdUxkE+Ow7LFj8lRD9BB55yTSUVCItgPnZ2+HsAGGOUS+7BzStTAEe91IlY6NZCsUXXMjdjTf3hiaCz3H5TkqSuZztCvb/15U6yCdqf+GFK5hqMfBk= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745394848; c=relaxed/simple; bh=3Ii8s2p/qcdFuMe8SVAPXc/efpCSMFMl0mlUoTEBswI=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=MhYeH4F6Z2jhJLEvPODGxa7YrLRYp9YoU8nupzEiuMwVDyh2I9G4dnOtEzuRT0EsG+CGwdMAyOYjNjTNCgdfgiuEVRxOAGYG8NjiMYdEqDWyuNpmDwav/ApTUkcqB7HHOF7L+Ea9mHomGnx8cQN26YLWx5L3k+0S9ob7Xmwb2Ig= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl; spf=none smtp.mailfrom=bgdev.pl; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b=mTnVEntE; arc=none smtp.client-ip=209.85.128.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b="mTnVEntE" Received: by mail-wm1-f49.google.com with SMTP id 5b1f17b1804b1-43cf06eabdaso58071645e9.2 for ; Wed, 23 Apr 2025 00:54:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bgdev-pl.20230601.gappssmtp.com; s=20230601; t=1745394843; x=1745999643; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=G50tHg+9cPiXzkRpuZie2LXfSMz7hYXUT5tobf0KFow=; b=mTnVEntEoLLNgtvVkc66Fo6QuA+P2oveflOhOrsm6JJfGRsB/k13MRHT5Znez7slnk ACvS9M0+fLtcWr0Fn78Ia1poKdOxzyYXQCueOTorKmwwPOHfAb6CQ6UQOg2xFtdAErf/ EvhNdKgbtORqh79UqpI/v1uFKvHTDpGhu1ixfM+tDY/qj61+LjTjfJT8vH5LWRVm2I2Y doqncjQdpYtlPFKcK25u35mSLlO9JfZyFg1+CN92JAROARI53POnmONnAzW/fo2E9VK1 XsazlD7SHJn0GgmcjB5rE6CPshbC4p4mOxWChuVL4MDwZvoJPEf33uE00yrcEwQvzWK5 n33A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1745394843; x=1745999643; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=G50tHg+9cPiXzkRpuZie2LXfSMz7hYXUT5tobf0KFow=; b=Ptzdb57g1v0WJaIGQG0eNFoaN6nKoqwoeGe0RdCVOm/AT5Ta2nUwvTLNUOISu5FeGR F1chpvIOwzlS9EeZirnA6jaFIKHzuSx9flep7S1V1J0SSxNGUo9UM4tFV7VTfgyGhDf4 dcQASqkAfbl+9gFhsmwITCDTl2tBi5AwJSzzJmdocvAdgjS/IXYMKlRMjkd6mcpeji71 CGsMX7HIrIyVrkYMvkUW5yqFHMMxc8Er4wD7ueA0DtaVMLnWcAPuQ00Jl42Jwe8X1GD5 WhKXdrGw/1M0sJATWuEKhrVOzhOPDt/Y9vumXR3ni8nbgnQhzEe/GwJvNdY+WtSkyqG0 EIIg== X-Gm-Message-State: AOJu0YzHNtOpm63bILJuTb3d6ApIPFyYeByDhJ/iU1PJY0x/IdOp52w6 S58h228S1s46DSvQvWNW3L4K58XyqKmGeQh0Te6Dhn4utwvL33fLhoSEtJiY+dc= X-Gm-Gg: ASbGncsHxwRDMcfpiIEzGBYd9thd2hTfAf0zbElt+AQJZoRAd+TK78U33h/+Lvm/vMU qB+1r8hU8VbKCz/vj+ELBWQFZWSw2I2N6R8IzMUwhq9Tcm8UlHs1zaQS4XGOChyXHptwyTLprhO 0amZ1velSWTuObDX+DwyebMAGAP3aWr+ULordqswbPW2+HL3lj7msgtBEEZSNYBtitIhNwj5pI+ crXJPq7Db3buT8/A9CnAtN/AWIqSdKF28ZzAQ/n5NGZrUzPCu350XnzqZHk3eJ/1cvWkyb/FZex CmLwPqGe7VI2XVnMdf+vZdTz0rifrzjNmSqjNK8y1BXn X-Google-Smtp-Source: AGHT+IGvXTJ6ZnfxoE28QibdMukAk1jobBJ6uY3/oOh8NYBRChEhWLE8jpG+gXPQsyB16QsY+BFf1g== X-Received: by 2002:a05:600c:a088:b0:43c:ec28:d31b with SMTP id 5b1f17b1804b1-4406ab9767bmr210592445e9.10.1745394843119; Wed, 23 Apr 2025 00:54:03 -0700 (PDT) Received: from [127.0.1.1] ([2a01:cb1d:dc:7e00:74b0:71bd:6dda:dcc1]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-39efa4330d8sm18266655f8f.33.2025.04.23.00.54.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 23 Apr 2025 00:54:02 -0700 (PDT) From: Bartosz Golaszewski Date: Wed, 23 Apr 2025 09:53:51 +0200 Subject: [PATCH 2/4] leds: pca955x: use new line value setter callbacks Precedence: bulk X-Mailing-List: linux-leds@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20250423-gpiochip-set-rv-leds-v1-2-2f42d8fbb525@linaro.org> References: <20250423-gpiochip-set-rv-leds-v1-0-2f42d8fbb525@linaro.org> In-Reply-To: <20250423-gpiochip-set-rv-leds-v1-0-2f42d8fbb525@linaro.org> To: Lee Jones , Pavel Machek , Linus Walleij , Bartosz Golaszewski , Riku Voipio Cc: linux-leds@vger.kernel.org, linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, Bartosz Golaszewski X-Mailer: b4 0.14.1 X-Developer-Signature: v=1; a=openpgp-sha256; l=1542; i=bartosz.golaszewski@linaro.org; h=from:subject:message-id; bh=l2zdj6xneEh/Gk26Dc0eMWJRRxQPVwCJnsn65X8LVNg=; b=owEBbQKS/ZANAwAKARGnLqAUcddyAcsmYgBoCJyX/ngp3PcuZDqy3Ua2tfkLyx1/xsgD8bsIE joXG4dBiPOJAjMEAAEKAB0WIQQWnetsC8PEYBPSx58Rpy6gFHHXcgUCaAiclwAKCRARpy6gFHHX coIND/0UvM9H0Fn75mnFJ4Ib5MXYYwVT9suj73IBJKfYp7aqXXoxUcpByilyJ0agYWNMRhsobGO s/oI89fln0XTsleS8uMc8pXvuoTi0KcatR3NeGiCGlZBev0oNvaMVkn9ZLEF4EJw0fMtBxYMn3k Z6BST6/1+6uX9OyKUdDUzZNMyCRztmf8yWk/vdoKTLEUxzW88ppyl3vAu/ZYFr2QBuB1ynJLv5i eA0FcaWCTC8RmOKE+v4q5r0n0sdAC6aIBLOuQ/gqn22wDqVZMGXDPtKwryaS3urFcGTtAcsfC2N 2FmLLkH4/mYSliEIiY7RW+U5AsxItOtl1iba3SI81o2Ym73rUsTCVfX14CpuhRSZksGkAW1kwBI 6Ihdv6hXi7/EBQAb98xTY5EzPvDm8mqLSTJE466nlZ7+CJImoq0nuQpLVcL6uGOjdjlNOLJFhM3 sMg1EoAFfFiJyiF77za1Mh+7wZOKV1poPoWdjQ6IfXZNMXzxlZLRiHoXDYvU3OP+U67D9w1NZWj 0awPnKFtkMeQdnCAxADE0KoplYdX8M62s3MajaeD2Hl73UAqaXVgN6BiEYuL3qEKO0V7oDa2Hcm 7IFwc/x9HWBiVQYNodydT3su07qbOXk4eoK68fqNS2TLGQ+JEQ6Lu+o+ZOTJcWaVSnO2exudDds VN9GzjLQ1pCJcIw== X-Developer-Key: i=bartosz.golaszewski@linaro.org; a=openpgp; fpr=169DEB6C0BC3C46013D2C79F11A72EA01471D772 From: Bartosz Golaszewski struct gpio_chip now has callbacks for setting line values that return an integer, allowing to indicate failures. Convert the driver to using them. Signed-off-by: Bartosz Golaszewski --- drivers/leds/leds-pca955x.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/leds/leds-pca955x.c b/drivers/leds/leds-pca955x.c index 24a40a1cdb15..42fe056b1c74 100644 --- a/drivers/leds/leds-pca955x.c +++ b/drivers/leds/leds-pca955x.c @@ -495,10 +495,10 @@ static int pca955x_set_value(struct gpio_chip *gc, unsigned int offset, return pca955x_led_set(&led->led_cdev, PCA955X_GPIO_LOW); } -static void pca955x_gpio_set_value(struct gpio_chip *gc, unsigned int offset, - int val) +static int pca955x_gpio_set_value(struct gpio_chip *gc, unsigned int offset, + int val) { - pca955x_set_value(gc, offset, val); + return pca955x_set_value(gc, offset, val); } static int pca955x_gpio_get_value(struct gpio_chip *gc, unsigned int offset) @@ -737,7 +737,7 @@ static int pca955x_probe(struct i2c_client *client) pca955x->gpio.label = "gpio-pca955x"; pca955x->gpio.direction_input = pca955x_gpio_direction_input; pca955x->gpio.direction_output = pca955x_gpio_direction_output; - pca955x->gpio.set = pca955x_gpio_set_value; + pca955x->gpio.set_rv = pca955x_gpio_set_value; pca955x->gpio.get = pca955x_gpio_get_value; pca955x->gpio.request = pca955x_gpio_request_pin; pca955x->gpio.free = pca955x_gpio_free_pin; From patchwork Wed Apr 23 07:53:52 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bartosz Golaszewski X-Patchwork-Id: 884109 Received: from mail-wr1-f46.google.com (mail-wr1-f46.google.com [209.85.221.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id ED1B3274FF6 for ; Wed, 23 Apr 2025 07:54:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.46 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745394848; cv=none; b=oEwpxjShkNPQUdBlPUSNl/E00iVX2uJPHptG/V1MBsYqbqZj4lkdXbbHwA7GHsxcE2/zoC0s8I1bwsYL/dfyPMPpUfwoyLGggjCh1HV6KmmuooeKQXsyift784txa9yqTfDv/9AG72RnXV67JH4RS1g4CNPbxzJMnZ6yvPyq9FU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745394848; c=relaxed/simple; bh=zxOjYTiJyy84RQtnZPalRY61UtBT2cLl+d5QqitJRy0=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=PYtrt+uxJgRjIuagfoVTg7QN/RrBKPz47CK5uCXcLMhAQCcmolZJ4PxYzXTWcEp8AYHHrFxHefIdP7JUoVaDp229kIB0bx7KB2n0mbGurkpNwyhLsxsVD/kISic73xwuLoOcIcb6xcHhyNaHHUb+QY9jSQyEMJiNH51gaKYsjEE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl; spf=none smtp.mailfrom=bgdev.pl; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b=sD1EDxSL; arc=none smtp.client-ip=209.85.221.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b="sD1EDxSL" Received: by mail-wr1-f46.google.com with SMTP id ffacd0b85a97d-39149bccb69so2813075f8f.2 for ; Wed, 23 Apr 2025 00:54:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bgdev-pl.20230601.gappssmtp.com; s=20230601; t=1745394844; x=1745999644; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=awmpLsPRHTvySKAhJ2vpQU4oTjj4fckiHhE0P3e8Csw=; b=sD1EDxSLOBZMDiLk/qGgOMmAw1fNF7boSwGBkMJXDAtrD3ZP/qQ8gH9x/79R/7AN6q zWa1fLzuGZoV//mf8oxsOGL3Ui94T+1VCBTXjX7B66VqNTZvj5rBo0IAbQWdAkVjkZdm ZL3uzMYvoXbDH6YBr1s4UVPHiczQdccRY1r7/gGjC+gUXxxgRRLSwEUjPVDeVPJm8Sgq WZ48aPsh2uG6gb8KoZnI/VpkA/Cvdm0bWazt7ijzaoCYwsLxgK8GP1qniH5QpgVGV/vi hSf9NfY850pqB808P03DlEnDvx6tMJxB4hzoijudLXpOnSGQVQLTW6CRUpJZxMRGDsMA SREw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1745394844; x=1745999644; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=awmpLsPRHTvySKAhJ2vpQU4oTjj4fckiHhE0P3e8Csw=; b=pjfLBlLO6tjZ25/IVR6D4AxWesngUKsZMEfyN0fNZru3xJwp4iYjp62JNBN+0YSCCd HUKMz1G9CDgWBU7YwsE3Lr1SxT9bDGJOL2Tv8/vF0eeLNJeOZb9M/urzKLLy19wN0Xa6 BO6BGZR1259Qq7m9OzmcrKKE0uInBFH8aWrg3nEnjV/RxO/gXycxoL2leDnBrPv2P0Dh /LudEdBrCQjhbIpnyxGR8tQaa+upTOoWx6IqzHpVzkYkUz+Uruqzzz1jUA7KpmOEvH8X 7pKePIE7FBbhn/bXJOOzwcp62MgwVXe2U9sVkludoLCk02U4qf74B/NIfUSPo5ssTXdH 2Xkw== X-Gm-Message-State: AOJu0YzC9FrD6xvl61ATEywQdv2tiECPZBKcmClYQP6Z+e1Xu0uzBIK/ cfWMcGSwjt7vZTN3UITaeeTZ9MkIolYwSJPvrH3OUOg8igcwNdS/ppOJziAX//4= X-Gm-Gg: ASbGncvfJ2cSrznvZuciapVBPxFk1K9E3YwhRjeTtsulaXI/aM4n5M9EMmBlMedLBYW jKInwEVdGY/kCwB0Qbt1+DVKTqM6K2hq6RIvSh0+W93wNiWPT8XXo/BmJVmua94mGonmswjUlzn +EStCqvGp2aitkZMl67IzeORTRAGqTBFnJhAGOal5VSddraj1b1yljZEEBDghh6QwVpknejm7G7 BGT/60EImMLvL+Yqg7XgVYS3vvGmxrclxHD1CFgwa+m8iwFm7PEijvOwgu49UNP493k/hCttAkh XM18r3vQ8E3fqtI2Y3gmPuUDhcaS82clJw== X-Google-Smtp-Source: AGHT+IHpJiw5FVvm/29U2iCX1LZCw0i/Nbm/maOexa2urIHeoGl97Wey43Yj0psGVkkZuo14ySAJXA== X-Received: by 2002:a5d:5849:0:b0:39a:c80b:8283 with SMTP id ffacd0b85a97d-39efba5b647mr15739927f8f.31.1745394844088; Wed, 23 Apr 2025 00:54:04 -0700 (PDT) Received: from [127.0.1.1] ([2a01:cb1d:dc:7e00:74b0:71bd:6dda:dcc1]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-39efa4330d8sm18266655f8f.33.2025.04.23.00.54.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 23 Apr 2025 00:54:03 -0700 (PDT) From: Bartosz Golaszewski Date: Wed, 23 Apr 2025 09:53:52 +0200 Subject: [PATCH 3/4] leds: pca9532: use new line value setter callbacks Precedence: bulk X-Mailing-List: linux-leds@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20250423-gpiochip-set-rv-leds-v1-3-2f42d8fbb525@linaro.org> References: <20250423-gpiochip-set-rv-leds-v1-0-2f42d8fbb525@linaro.org> In-Reply-To: <20250423-gpiochip-set-rv-leds-v1-0-2f42d8fbb525@linaro.org> To: Lee Jones , Pavel Machek , Linus Walleij , Bartosz Golaszewski , Riku Voipio Cc: linux-leds@vger.kernel.org, linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, Bartosz Golaszewski X-Mailer: b4 0.14.1 X-Developer-Signature: v=1; a=openpgp-sha256; l=2010; i=bartosz.golaszewski@linaro.org; h=from:subject:message-id; bh=Q4N59dzS+Vuc+KWJbtCOPhsNB+gdq0KgGsw4pEhqZY0=; b=owEBbQKS/ZANAwAKARGnLqAUcddyAcsmYgBoCJyXc4I884o6/Xyc/tB3w4hoVI2mzM6RHhnTy h8HDxNzCriJAjMEAAEKAB0WIQQWnetsC8PEYBPSx58Rpy6gFHHXcgUCaAiclwAKCRARpy6gFHHX cmdJEACil87EJKYf+Q8ROqUg1EIZAdyX1ELY8HGoJKDg50NwtPybyVb9CryftIWOX/JNRLrITVb aGTfPVIOTPwNPha9yMuXqYqQpTXhaAJctQmIdudIfaTcYHXSeYtKixn37VA0h8hXaoZ8NVtaGuF clbey04B1txEdgOZgXv9Y/XcGdA78fAQoVitn7PG5Lg59qc4qtFElYep0bVF6QVMXn+WmmIvrJH j5xYt0FJGJ8cUUjNw/fhOOXV/XuYdPMpoILT9vA02uwgATbfjx/h7IjB22xsUXXBWcZCiWDDqJD iAJqABycco25U5TSpkJJYUommbclinDkjx4Gf41yIKblHRIf1z7Raxy2UwNlmHGj2wPqySedLHa /Or+31/FeHIvds4F7AK9v2ZJ0/yRfeAqC0Ev0vuSNHKlsMiKXy6KgAAQPDFO1BMZsyXwvDQpB7b TQUCNdO3xF7C690ep9kQNJ8mWpLovYUlMgKVD6+L6M3TmUt3vac26UQP26+H1wt4YDBigXPNp8d TrfFRNTyuWZUbffroo1Z3kolwGlIXnGldSOYKwdPRoxakHKI/pMc6R/W0l76EG13XpD7XEjs/su zUNSqmIDVG20uzcIMAQhIIr8mLeHDpsNS0hodQE9VXhaU4UGI5LSbpkC9Lh+XSBxc2/opu5CkJ9 F7+HOsImPhA2FDQ== X-Developer-Key: i=bartosz.golaszewski@linaro.org; a=openpgp; fpr=169DEB6C0BC3C46013D2C79F11A72EA01471D772 From: Bartosz Golaszewski struct gpio_chip now has callbacks for setting line values that return an integer, allowing to indicate failures. Convert the driver to using them. Signed-off-by: Bartosz Golaszewski --- drivers/leds/leds-pca9532.c | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/drivers/leds/leds-pca9532.c b/drivers/leds/leds-pca9532.c index 1b47acf54720..7d4c071a6cd0 100644 --- a/drivers/leds/leds-pca9532.c +++ b/drivers/leds/leds-pca9532.c @@ -318,7 +318,8 @@ static int pca9532_gpio_request_pin(struct gpio_chip *gc, unsigned offset) return -EBUSY; } -static void pca9532_gpio_set_value(struct gpio_chip *gc, unsigned offset, int val) +static int pca9532_gpio_set_value(struct gpio_chip *gc, unsigned int offset, + int val) { struct pca9532_data *data = gpiochip_get_data(gc); struct pca9532_led *led = &data->leds[offset]; @@ -329,6 +330,8 @@ static void pca9532_gpio_set_value(struct gpio_chip *gc, unsigned offset, int va led->state = PCA9532_OFF; pca9532_setled(led); + + return 0; } static int pca9532_gpio_get_value(struct gpio_chip *gc, unsigned offset) @@ -351,9 +354,7 @@ static int pca9532_gpio_direction_input(struct gpio_chip *gc, unsigned offset) static int pca9532_gpio_direction_output(struct gpio_chip *gc, unsigned offset, int val) { - pca9532_gpio_set_value(gc, offset, val); - - return 0; + return pca9532_gpio_set_value(gc, offset, val); } #endif /* CONFIG_LEDS_PCA9532_GPIO */ @@ -472,7 +473,7 @@ static int pca9532_configure(struct i2c_client *client, data->gpio.label = "gpio-pca9532"; data->gpio.direction_input = pca9532_gpio_direction_input; data->gpio.direction_output = pca9532_gpio_direction_output; - data->gpio.set = pca9532_gpio_set_value; + data->gpio.set_rv = pca9532_gpio_set_value; data->gpio.get = pca9532_gpio_get_value; data->gpio.request = pca9532_gpio_request_pin; data->gpio.can_sleep = 1; From patchwork Wed Apr 23 07:53:53 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bartosz Golaszewski X-Patchwork-Id: 883672 Received: from mail-wm1-f45.google.com (mail-wm1-f45.google.com [209.85.128.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D0D7F275845 for ; Wed, 23 Apr 2025 07:54:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.45 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745394849; cv=none; b=lib4/FWBJZIr6JXt6rKfAscqyqWtsoOZS3UV+5InFT0oFFVpG8T3VCYZnVoozxQ+u/Nb7iNfYYfpfzHYEB1ysNNL/FW8sCaOpKXea/dNvR57iH49NUvIc3GZp4a1JvdGpkb95XiN3TupBIZ8JUr/8aI3/9LqMOJs/43Kj/E9ctg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745394849; c=relaxed/simple; bh=VqGDq+aiJzH+1k4/p5pVXAekbmppDm03yyolVhT8cKU=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=K4QVKr0uwPGPP7CFaj2tYOKFiCePr7pWu9/Nx+bXxwqoXy3bfdPQGrsJxaHWNU/1ZXksYk7Xf7lHydObhgrFB8yf9P6skTTjr6dilRPkfKZ3UY1Py98vOt+hjTCW89gSlDdG8OR8cGpVlliCzSwCQjQX2LKtvUIb1HWQY5/n/mI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl; spf=none smtp.mailfrom=bgdev.pl; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b=yJ+9L7cy; arc=none smtp.client-ip=209.85.128.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b="yJ+9L7cy" Received: by mail-wm1-f45.google.com with SMTP id 5b1f17b1804b1-43ede096d73so44344805e9.2 for ; Wed, 23 Apr 2025 00:54:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bgdev-pl.20230601.gappssmtp.com; s=20230601; t=1745394845; x=1745999645; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=GTFfJZb1P5uU8ezKo9spOiDP3fTS97bBPzPp1VNuiFE=; b=yJ+9L7cy5xIO1QVUjmi9YeiPTmQ7PuD63tm5UuRxkJBYFgRZN0FSYTHOVGN9FFFMFW CgtGeE2PoYmae2C7F1v+wqFFfoT6XF0nGtH2vgbVqbhlAJJEZDpoN81O9Ac/xfbOVe8T QVPcMFWvaU9TuWiuM3gugil2F5FYaxupnwGn38DJ4nbooyukMN+dDn+OcjEZqn66HTrK Ms9/ggo2XVvJwtw+Awx8smTUnzESrhIP6kak81WLJP/AyTM9arr/itEdk+hlIVskcDn6 Qf7F/xN0TBjh6KdjZb0wit3WzBYtGLUXFh2f+jh85WRox2z6j+ZmdvnFRR8efh8pXjCS GVZw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1745394845; x=1745999645; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=GTFfJZb1P5uU8ezKo9spOiDP3fTS97bBPzPp1VNuiFE=; b=FCHZdpfrcNHDOwhPLWIQouoUmdcDjoD54zUJcfZ6vvg+LIAsPB5IuEwbANC76NgEYq Mh3iBBxe9uluJGKgCnuhU71XDd3oCYFiAisklGgLuD51hw36l4gFUDFOv600DIC/6X3D 56HEyRw19UB1NoYQICtPmsm4YIgT1bOVMdB2Ki6XbyMYX/3xfUfALq/euUj3S+3hI38j 8jlPtL10XWn/sJs7eG7FyksOjpEJXYe0hftBVAxwZzPUQD4AsUJa91gNuRvmSNAwgUTw SudhFWYQVM/TFNvwUrkT2aP0T2r6Wi/2J26PoPcwo7Alc4meMsZ17Cjz3ccQTzvyKaYK kvbw== X-Gm-Message-State: AOJu0YygSlXMEMJA5rvz9Z3G2aNv7Lwo2mfUaQnR3fvPnBLD+6qHD5rp zFHbsZIrrY8/M94xMq6rz4CTCUDnAVzi+v5+7pmxm+6Y5vCHddIPK3+5j8oxbUc= X-Gm-Gg: ASbGncs0sGIJvbCNjHWa8EP8xhZRfX46qHlok0fGQCnKnSqQjGd9BGymsNRv1gfuDVj m+0lvmmDpN3ccStNgg+thV75D5VnzemVsjZ23GfOKkmdnikPrSc6QM1X7zBreEf3zAtyKMCPVL/ 4+Qmw3ZSucpiDY2BVdST0bFGP9dIEV8sQ3Hi/DgMdURxfmLTQhgT7eMYJvJuhwH/fxzO/kCtXdk rniTpJ0ZNlUA8YQrSUVqWff//1zBn4z7iLdNoNvtDdsjnJMn7puuAvM8U0OqvcWyQKnYg5A8Set ifXj9P9l5ARLHnna4cAibnbwlHmwS2XNRl10uaAF65eM X-Google-Smtp-Source: AGHT+IGTjzRevoWNUsBJdpmO0+4XcLcpnz8hcwqfrYaEOvZnTxWcAwwm6v+Zm7rMHLQ3zUTTTB4kuA== X-Received: by 2002:a05:600c:1548:b0:43d:300f:fa3d with SMTP id 5b1f17b1804b1-4406ab7f661mr150504825e9.5.1745394845053; Wed, 23 Apr 2025 00:54:05 -0700 (PDT) Received: from [127.0.1.1] ([2a01:cb1d:dc:7e00:74b0:71bd:6dda:dcc1]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-39efa4330d8sm18266655f8f.33.2025.04.23.00.54.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 23 Apr 2025 00:54:04 -0700 (PDT) From: Bartosz Golaszewski Date: Wed, 23 Apr 2025 09:53:53 +0200 Subject: [PATCH 4/4] leds: tca6507: use new line value setter callbacks Precedence: bulk X-Mailing-List: linux-leds@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20250423-gpiochip-set-rv-leds-v1-4-2f42d8fbb525@linaro.org> References: <20250423-gpiochip-set-rv-leds-v1-0-2f42d8fbb525@linaro.org> In-Reply-To: <20250423-gpiochip-set-rv-leds-v1-0-2f42d8fbb525@linaro.org> To: Lee Jones , Pavel Machek , Linus Walleij , Bartosz Golaszewski , Riku Voipio Cc: linux-leds@vger.kernel.org, linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, Bartosz Golaszewski X-Mailer: b4 0.14.1 X-Developer-Signature: v=1; a=openpgp-sha256; l=1758; i=bartosz.golaszewski@linaro.org; h=from:subject:message-id; bh=j50twcusbXfbWf3YimG8kilK3UrQntg92BiiLpapoiE=; b=owEBbQKS/ZANAwAKARGnLqAUcddyAcsmYgBoCJyXXWKiAH3snFZHuRbLDBqkRUlZiVNabT/vi W2Az4GKo/aJAjMEAAEKAB0WIQQWnetsC8PEYBPSx58Rpy6gFHHXcgUCaAiclwAKCRARpy6gFHHX csOmD/4z8pV0ShS8Bn+cluVeSrGpphqnovNsAHA6+L3NqKstpdKCMPStq21vJwK4g0mxS0hWlcS W/xwr4ddv3T9CvuZwJXyS7Qsh0WGkIrfEB6jWJn8zwbVmsNCnhvq+2geTenkaVPKnom/4ctM5j4 JgsfG9W9EsKZmGRPe0IlnNhYGnrgwwKhPfh0FEzyqylBMBT3LDWTQ80EfwgIUjP2RsJz8laoB50 ddVugrvsnNWDihdOrIbIo+zST06DfSO5zbXNSywQ/eAZ+/PLO4SpYiNOQRkbpwQkQ+9EzIcCOFn cXVbzHvISKu+pMczH2P959jlGJTH8z/bWQoQI8jQRqfHQSG1ty/je2WdbzcwPEhxmvIQMptJw8j cphEyFKe6MMttqhABUYsYNSBFfHYdZMDtGEfth03zput/5fK950xdoMp3rIdIUtPoLfbTeNv6GO hQfx7dRubXy1YAi/UYOKd5DXqD/NjH94DTTiI1jmVAClq6lQrdBg0jEvJYCSe+x1Dtulx2A7DMy XoRGElSeAKl6Xl0dphxCCmFmCdeqggex2mMrB2WtNCC8dvRYFOPV9mGqU3ScI5IliD6RvVjisvh SbVb4siNzfRdTGn/30tY7d5lK031ZpAZm55H710vzt14UeGyNepkLazvm3OW+IpHgdMCcJ4VT6X svAfxJVCje8xDhg== X-Developer-Key: i=bartosz.golaszewski@linaro.org; a=openpgp; fpr=169DEB6C0BC3C46013D2C79F11A72EA01471D772 From: Bartosz Golaszewski struct gpio_chip now has callbacks for setting line values that return an integer, allowing to indicate failures. Convert the driver to using them. Signed-off-by: Bartosz Golaszewski --- drivers/leds/leds-tca6507.c | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/drivers/leds/leds-tca6507.c b/drivers/leds/leds-tca6507.c index acbd8169723c..89c165c8ee9c 100644 --- a/drivers/leds/leds-tca6507.c +++ b/drivers/leds/leds-tca6507.c @@ -588,8 +588,8 @@ static int tca6507_blink_set(struct led_classdev *led_cdev, } #ifdef CONFIG_GPIOLIB -static void tca6507_gpio_set_value(struct gpio_chip *gc, - unsigned offset, int val) +static int tca6507_gpio_set_value(struct gpio_chip *gc, unsigned int offset, + int val) { struct tca6507_chip *tca = gpiochip_get_data(gc); unsigned long flags; @@ -604,13 +604,14 @@ static void tca6507_gpio_set_value(struct gpio_chip *gc, spin_unlock_irqrestore(&tca->lock, flags); if (tca->reg_set) schedule_work(&tca->work); + + return 0; } static int tca6507_gpio_direction_output(struct gpio_chip *gc, unsigned offset, int val) { - tca6507_gpio_set_value(gc, offset, val); - return 0; + return tca6507_gpio_set_value(gc, offset, val); } static int tca6507_probe_gpios(struct device *dev, @@ -636,7 +637,7 @@ static int tca6507_probe_gpios(struct device *dev, tca->gpio.base = -1; tca->gpio.owner = THIS_MODULE; tca->gpio.direction_output = tca6507_gpio_direction_output; - tca->gpio.set = tca6507_gpio_set_value; + tca->gpio.set_rv = tca6507_gpio_set_value; tca->gpio.parent = dev; err = devm_gpiochip_add_data(dev, &tca->gpio, tca); if (err) {