From patchwork Sat Apr 12 10:15:00 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dan Carpenter X-Patchwork-Id: 880631 Received: from mail-wm1-f50.google.com (mail-wm1-f50.google.com [209.85.128.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 41C131DB13A for ; Sat, 12 Apr 2025 10:15:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.50 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744452908; cv=none; b=rNvGJ46ISCI0ZfF8bbQvd1+HwAjeJfiDdHfvJqSShju42IiWF0rLiOjm0XlNvFyzwDofrClxk8hw6kLnhb6AO5o3Wdw2oxDCxKgfx9Sa80+bTw30YmiV1U5pbEGwdYs39pA93rakT2exVnCVci0+iL26xyEWmAs/FuKfa48pGh0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744452908; c=relaxed/simple; bh=ec9o+usvzaDmx3DGgMMTtjczEBdGtLbMmGO/AqUrtyA=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=XXSJPKRue2ygIV7kEUawclg+QkCfvIgY9NMXpMUojk7X/cY3CVfXlZU8Es2Kd31gRynDdPO77mc3imDkbFecTfO5WJ2qEha43CRNQOxNkYkJh+jmmNNLnOpEtWoPPoSLybzeJA+xMOPZedA/vs85FBjXpWrg6WeMcmGsu6JF4No= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=F1PVhk6Z; arc=none smtp.client-ip=209.85.128.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="F1PVhk6Z" Received: by mail-wm1-f50.google.com with SMTP id 5b1f17b1804b1-43cf3192f3bso28398485e9.1 for ; Sat, 12 Apr 2025 03:15:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1744452904; x=1745057704; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=A7fHQVByAhO5ET8TfAMvUtvtE+Jqiz2kAUnhQyP8lMo=; b=F1PVhk6Z51Oudl1g3lLBJ7pmr+ufCqsoQq0K6obGNgVmnzRPgWJHKWJIX9hJYKD0Uc lfwWu0B2MwIh5JzpyCpbQmpg2xiH1QYa2NLhoqjoEstoZ6RJW0VNaig2UhCeM0ghI5jm ucdk2tTHqK45RBjtLPdOFN8EFadyvOxAy1IDaUkSXGxmyLwTGga+JRO1fdKmjNneGGHR gXA9aucLQhEbmMWzFlahBWHD0DA+5zH1zor3Yxw5SKItJS+Hj43VdN4MEjA3Vv570ZRy DoiFckxN+pynPNJsqT/YD5YNeRP27vOFYrk8Ue8d1a0Bm4VkjsfcDfDHDj22QTYo5VcX c14Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744452904; x=1745057704; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=A7fHQVByAhO5ET8TfAMvUtvtE+Jqiz2kAUnhQyP8lMo=; b=uLL8qB5zfbxveiiNQt76STXS/az2z3jpaCeMWnQnuLRwL82zc4VyzAlygmblSzXeBZ GSnBqIEl9uUSEF0Q3kCuaENAY6o/HWKFP9g75b5gOkeq4YA5tTjQfEXg08++dsWBrr/e RM0e/ZNc4eSADGSyRZOtbxocelv8AAixbMgZ5pUjHGsal0PFdV68YhRk8C8vlc33yMUe PIq8kt5u6dhCGO+2/ori5QTs/pMqx7q6fZc1Kel/Eh2wSTPm6uME6UEn3b9kDwHki7Rp BEpJHk6sB9maqTIFu+WihMFExq8aXUW4ZNhokYYrLqyv8bCANIQl5Xk6XTVCvNVwt739 WAJw== X-Forwarded-Encrypted: i=1; AJvYcCVuHlRPo/U4Y/3nd82wgtyHY3slcrGjcpBbZVa6+/32tsWhR1fGXGWG0stFfmSQSX7bDL+MJGs8Z7jl@vger.kernel.org X-Gm-Message-State: AOJu0Yz2aVKUwH9S5jSjk7k37E7mE5zxFAJENjL1XXyKPiizRH5QK+dM 93Xk8Xng0oHbIdb1EXa3sBeRn2CvTbTL6qaMFkI+LVKsy/ktQpVU6N/a2zu5xEQ= X-Gm-Gg: ASbGnctsx1pGl9QM6XHlu8Lgj5gxMKVGiqq0lwoahDagmzmkCo6N6xb3QOq1VJ3HXAO +pEmvtmeQjA3jnmgQTHcm+J3PT8RXOFiyKR7MoEUvk6bpDt1cC43pZ9S1r7H5fNgKE8a1Q2ZF2Z FANP6DyuxNsRyiQYIv4l/lkXAFt4CfoLziFjEpJR/16UndtlIZKr99KkmLMusTXMFNORLDxlfbW rLm/moQZc95Z9pB8mqtcZvEm2EXijvaXzIiwXN58GJ/MVnKYzEMojRZuacGe0RcBUplUMTkKZm8 u2TFw4tuhgmerZjtf4NnH25oqiJ9Jd+Lrn8/X0IZZH0pgA== X-Google-Smtp-Source: AGHT+IEb2YD4p8Gn575c6+UDDJnXqr10gazTooH6MgrOd67+x5QilRkEOOPF4Jo0Z3LOPZCEzBmVgQ== X-Received: by 2002:a05:600c:3848:b0:43d:988b:7732 with SMTP id 5b1f17b1804b1-43f3a94d9bbmr52535175e9.14.1744452904493; Sat, 12 Apr 2025 03:15:04 -0700 (PDT) Received: from localhost ([196.207.164.177]) by smtp.gmail.com with UTF8SMTPSA id 5b1f17b1804b1-43f23572b5bsm110862445e9.28.2025.04.12.03.15.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 12 Apr 2025 03:15:04 -0700 (PDT) Date: Sat, 12 Apr 2025 13:15:00 +0300 From: Dan Carpenter To: Koichiro Den Cc: Geert Uytterhoeven , Linus Walleij , Bartosz Golaszewski , linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 1/5] gpio: aggregator: fix "_sysfs" prefix check in gpio_aggregator_make_group() Message-ID: <30210ed77b40b4b6629de659cb56b9ec7832c447.1744452787.git.dan.carpenter@linaro.org> References: Precedence: bulk X-Mailing-List: linux-gpio@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: This code is intended to reject strings that start with "_sysfs" but the strcmp() limit is wrong so checks the whole string instead of the prefix. Fixes: 83c8e3df642f ("gpio: aggregator: expose aggregator created via legacy sysfs to configfs") Signed-off-by: Dan Carpenter Reviewed-by: Geert Uytterhoeven --- drivers/gpio/gpio-aggregator.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpio/gpio-aggregator.c b/drivers/gpio/gpio-aggregator.c index dde969f29ee2..b4c9e373a6ec 100644 --- a/drivers/gpio/gpio-aggregator.c +++ b/drivers/gpio/gpio-aggregator.c @@ -1016,7 +1016,7 @@ gpio_aggregator_make_group(struct config_group *group, const char *name) * for devices create via legacy sysfs interface. */ if (strncmp(name, AGGREGATOR_LEGACY_PREFIX, - sizeof(AGGREGATOR_LEGACY_PREFIX)) == 0) + sizeof(AGGREGATOR_LEGACY_PREFIX) - 1) == 0) return ERR_PTR(-EINVAL); /* arg space is unneeded */ From patchwork Sat Apr 12 10:15:08 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dan Carpenter X-Patchwork-Id: 880952 Received: from mail-wm1-f51.google.com (mail-wm1-f51.google.com [209.85.128.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5A6A71C84A5 for ; Sat, 12 Apr 2025 10:15:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.51 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744452916; cv=none; b=OxG2l1GqISYwre3OQ/KzQdtB7n5d4WNxPjLf3Z2CdLwZtiET7h8NaHKNptnUqMEr+NhJ01x8EuKkttLlFXBTi2Tc5GUscFBI6TGpqJgFvIBVbttqo2qpRh+SqPpLKo6jTbPcoZsEsh3PEtCLV6iu8MGQEZ6u5p5JsH9yyMASa0E= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744452916; c=relaxed/simple; bh=nBOw1K56zx+FMK3TMKr5Btqqg5rXK/cv3N2NaH/vMdo=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=YtY2k3GfmR82+CRgd22y3dMFoGhnoGhcJ7cntlOyb1Rdum4CMJmCcZtNjTzKhSS9S8QmHaIv9S8dH3gWPkjKwzYpCd52aZY+eHPVClQ6RK/6OE3sxSFKrtY4KF4HIgi5FHU10tW7d20M6FEsbLKxEzW7Xodww3uIMlLyYJDdPiY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=xBYzzEhz; arc=none smtp.client-ip=209.85.128.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="xBYzzEhz" Received: by mail-wm1-f51.google.com with SMTP id 5b1f17b1804b1-43ea40a6e98so24649185e9.1 for ; Sat, 12 Apr 2025 03:15:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1744452912; x=1745057712; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=5GJrIXgOBYoDItQRMyP/MgpEpQGYcUrfGmxOpH/blcs=; b=xBYzzEhzHFXcpcBzJmq0B9IAYznTalMzCksRN5T1D+7wOGD8Yk7zpc0JAAS6vxeEou XIzfSJBTuvxft7dI7QcfDjQB8OEXKjDIPhhBr25VXWUygk2/sMGnDKDlCpzX7U7i0kiD M2AeV6F/QkGytkaed0SAap/Qhi7cGxw8MJCstBUqzDiZ6nefxYt2UVd49VL/xhaasWFv UqO2IlJyU6s81bEe7x/35Yvp+SfmGpaluhM1UeLZ0idF3l4XECqglH+YgchNQ4+QlHqc 6JheP36meuxqvx4X9NJ0fS8mahHr9UaakLVtPFVHEj8IC/n4qq9yfPlXtE2dIj1HTYnq erag== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744452912; x=1745057712; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=5GJrIXgOBYoDItQRMyP/MgpEpQGYcUrfGmxOpH/blcs=; b=ccNGhyYRSvElitz+OshTPIrztzv8UTgrwdtr8AwGPjpZCTrN2YVwad/rAQAoqQ3M+D ufFlJJZVNNKn3WUhvG+Irkt1Jv5xtgkRqYcqS0q45Ki+YB/9zAb1vCxghCWmMZVUKXY4 ycrzIflXw0FppnhaDFJfQ7652A3jfFsWSl3opM8w0O1oJxlFZH+pktJp9ssZ7W4T7CPr /bV9zZLhMcpDWcIIJ5evwzZ2oaNJSKD2FFniw7EVIUhhoFf/mJ+hl+YEyN43GMbY+is8 ciT06X+E1V9qsSW2gIySfzuQQUrTzEID5PGp0KO1ghEsHeDamE3/gqW/pMZIXxcBT+NO 43ww== X-Forwarded-Encrypted: i=1; AJvYcCUkW7JnR+cAROIH1ZX4nvIzRXUhkfyF4RB2Jwls0d6K394ZVjAj3CJJ4KhFt4d16qsqgAStIMm076Pa@vger.kernel.org X-Gm-Message-State: AOJu0YzPsL/1EV+TP0eMW7tqZZtfqV+FtEo6Pdo6mnWRfz2HrZ9TfkVf 5LdeZChoDJa75HwzX1clShPS8c686A/1rJuUh+0bUbKDWtnHpHwltVRADMTZ91I= X-Gm-Gg: ASbGncs5dXeb32ld8WVLZmLquEBYSRPYD2WPo4AVC50LTdDJvxlZ/+r66suNMG4UK/c efMTKp0roxHs9eTc0e2gjoHOUDpxB6BOyxUs38jIJUHZYcAD1S2WA31k8EHowxCHucjvvAG89sx xIhhV9I0LKtdaNxd48GDZA++R5LbSoQCpuyf9YRxZgQNv/vGphtg7WJ3LDvzbFjt0Nntqj23DiO ZB9poBibp5FnpA60y0nW+3gxwKJ7aaUQ+kIA25kyODs7+m5Dy802C/PqFrvhoKfPZ3xMg+KV5k9 KGcWJxPMBqoMmc2v+yWbBqLlqJH3veoDzbaJcKYr9kXRPd5enx+2smOu X-Google-Smtp-Source: AGHT+IHJXNcS7Hluji03dQdPRwTs64eZnH+yKoBp7cnqjsxtXtXhSJ0iQiymmtzYr1P8d4dUS+aHoQ== X-Received: by 2002:a05:600c:1d83:b0:43d:300f:fa1d with SMTP id 5b1f17b1804b1-43f3a9aed73mr63941575e9.31.1744452912570; Sat, 12 Apr 2025 03:15:12 -0700 (PDT) Received: from localhost ([196.207.164.177]) by smtp.gmail.com with UTF8SMTPSA id 5b1f17b1804b1-43f235a5b08sm114474575e9.33.2025.04.12.03.15.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 12 Apr 2025 03:15:12 -0700 (PDT) Date: Sat, 12 Apr 2025 13:15:08 +0300 From: Dan Carpenter To: Koichiro Den Cc: Geert Uytterhoeven , Linus Walleij , Bartosz Golaszewski , linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 2/5] gpio: aggregator: Fix gpio_aggregator_line_alloc() checking Message-ID: References: Precedence: bulk X-Mailing-List: linux-gpio@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: The gpio_aggregator_line_alloc() function returns error pointers, but the callers check for NULL. Update the error checking in the callers. Fixes: 83c8e3df642f ("gpio: aggregator: expose aggregator created via legacy sysfs to configfs") Signed-off-by: Dan Carpenter --- drivers/gpio/gpio-aggregator.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/gpio/gpio-aggregator.c b/drivers/gpio/gpio-aggregator.c index b4c9e373a6ec..e1b2efc0df99 100644 --- a/drivers/gpio/gpio-aggregator.c +++ b/drivers/gpio/gpio-aggregator.c @@ -984,8 +984,8 @@ gpio_aggregator_device_make_group(struct config_group *group, const char *name) return ERR_PTR(-EINVAL); line = gpio_aggregator_line_alloc(aggr, idx, NULL, -1); - if (!line) - return ERR_PTR(-ENOMEM); + if (IS_ERR(line)) + return ERR_CAST(line); config_group_init_type_name(&line->group, name, &gpio_aggregator_line_type); @@ -1074,8 +1074,8 @@ static int gpio_aggregator_parse(struct gpio_aggregator *aggr) /* Named GPIO line */ scnprintf(name, sizeof(name), "line%u", n); line = gpio_aggregator_line_alloc(aggr, n, key, -1); - if (!line) { - error = -ENOMEM; + if (IS_ERR(line)) { + error = PTR_ERR(line); goto err; } config_group_init_type_name(&line->group, name, @@ -1105,8 +1105,8 @@ static int gpio_aggregator_parse(struct gpio_aggregator *aggr) for_each_set_bit(i, bitmap, AGGREGATOR_MAX_GPIOS) { scnprintf(name, sizeof(name), "line%u", n); line = gpio_aggregator_line_alloc(aggr, n, key, i); - if (!line) { - error = -ENOMEM; + if (IS_ERR(line)) { + error = PTR_ERR(line); goto err; } config_group_init_type_name(&line->group, name, From patchwork Sat Apr 12 10:15:16 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dan Carpenter X-Patchwork-Id: 880630 Received: from mail-wm1-f47.google.com (mail-wm1-f47.google.com [209.85.128.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 86E341C84AB for ; Sat, 12 Apr 2025 10:15:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.47 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744452923; cv=none; b=Y/5cyc3cicnm/oD77rAAUbxNOmV2B7jpu8KVwd3rmiBk9aXX3YN3MLCxXjsC95vlDhxnk4nTqbMCRxyXKxm4dCg1DoVbp46SJ8COnqnXBdJUhzO4xP1VQAkD78Hb8keK6DadQtiKgBV3PNb/D8z3xiAYd6tjWApPRX0I0vJwq2M= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744452923; c=relaxed/simple; bh=BqrtC68kvn5BE9H9YCrsaplk6/VrQpydGI+G/P4WsdY=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=jS6wjICzgWysSqPIW8tVx86KA9pGH0WYjGjRvhPfHFCanVR1BD11i4O0GRJH4L7aO7WdKuZnBcLpUWjGpCqEE5dMtkcTFBM6fP4o3eQn8+QU8SGqgXjZZsJxLRZfGcDXrfMLcVZGCVGgFACkXw1gfC09Q3QDinLiikt4wSxI9Kg= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=M6oVR4nr; arc=none smtp.client-ip=209.85.128.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="M6oVR4nr" Received: by mail-wm1-f47.google.com with SMTP id 5b1f17b1804b1-43ea40a6e98so24650605e9.1 for ; Sat, 12 Apr 2025 03:15:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1744452920; x=1745057720; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=+ugvrJgRiDNNRNpdggE4rPF10UbTBT1GSj6+8Qk5pqs=; b=M6oVR4nrpZoopLaQwHt/Av3GjrjcjVktwPDxUHnOYO7BKFCI8FVVkrcldC3/A4FfWU ydZC0tdu1GgYkaoS1PBw9vqjsRlnsCCqyJx0aiXv0cqHhXl90F3ram1HzNUZTR10soRY 2U9jVprQKxwscF0oNCSY1r8Hd/Oc4HhUWrV4RV5AaRgjc+yGrWUExQg25KWfgqLyVief hGLx+juwZ/mpsWfhKWMK00ltmOMVPJZSsUbn+fd6VcJbN8xCbb//L7rEoAw9ee38DU6w j3ErZUIDOz+qJbKBykP44hOUhKqp77KvwNPOzrlniNEepcSooP7UST75ppHDkRu6CINL jbOg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744452920; x=1745057720; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=+ugvrJgRiDNNRNpdggE4rPF10UbTBT1GSj6+8Qk5pqs=; b=jAHD0lG2rLT3AtO2Vqdshev9UZj7tlYu2xcUev75A9wpFMbR4Hr3Pjexp51HeZz88A N5yuN1JDLt1zO+jKx/lCcB9O20te6reUgm08ReVXNJ2c+5um+dnEw2ckts3ndxWzm+4C VaIKeFO1Ry0/cz7qD4d3mD+CfImxGU7ZV9Wn75aKv24F/G0ZlNoY2ryTXSRUYlqLYp3E g+i7iBowOUv3hxKbYAJvnFN5oun3ELtAYAS/DTTR8F6C/zSD37jFyWboi8NBqfcuYUEq gX5NRQD4T80YR9PznWRowqGFC82Q/zeNB9poYsbHXYaM50EWsnJJdQ2vgek27OHtvve6 xUpA== X-Forwarded-Encrypted: i=1; AJvYcCWAqD/2PE66i6IyZ4C/LDXtgRe5cuhoHz2eit4Q1Y9Oc5XFqs3aPTpG/bKJF8gfYVCBsY6enIsO8yLv@vger.kernel.org X-Gm-Message-State: AOJu0YxM2YyIUHbX+Wjo4pqJH5nokDaSDvbhokNdPh07P1+o6PxQUb2I Mz+R4ppU440HNLvuvN00SqHQ4sgvUlJAI2C9nF+Vv9npLbUkDbEINfnnLTP8crc= X-Gm-Gg: ASbGnctkU8Epn2nvwPYIOlzIXl0pow9HdkLyGdoNmCRfmd1+iqR/xa0cHxBY2ASmNDi Mlqy+JarStaQT6JCmPelMLVqDfBWCB7DzdxqvN83k+wdNZOK8YaRLhiysfQ8w++ucSbqaQ/2iEB GFDdb4BaoXmSE0S3wJWYiC9HmKIkw5aBnrF7SihccTa1LMlwEwkawBDNfwLRgE6Ef+Dh0S3Mqgg o23+uuTZcWEsJG1yGNP7QlXson7ZDs4RipN4OsB9nZCa5FrvfvLXg2O0ipynu8awWqSI44OMhVg VlMW9jSWfdSMaro4Z7yzQQx+p+FaMx/0ondHbhVV5KK3YA== X-Google-Smtp-Source: AGHT+IHrvgEuNDUHTE28uOmHTesN0mZlwCY5vOjmN/vbu7hehpaq9Iwk/+wcOFz2JAtbh1IuF1BaFw== X-Received: by 2002:a05:6000:1887:b0:390:f9d0:5df with SMTP id ffacd0b85a97d-39eaaec7a7bmr4206852f8f.52.1744452919627; Sat, 12 Apr 2025 03:15:19 -0700 (PDT) Received: from localhost ([196.207.164.177]) by smtp.gmail.com with UTF8SMTPSA id ffacd0b85a97d-39eae96bf97sm4590106f8f.25.2025.04.12.03.15.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 12 Apr 2025 03:15:19 -0700 (PDT) Date: Sat, 12 Apr 2025 13:15:16 +0300 From: Dan Carpenter To: Koichiro Den Cc: Geert Uytterhoeven , Linus Walleij , Bartosz Golaszewski , linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 3/5] gpio: aggregator: Return an error if there are no GPIOs in gpio_aggregator_parse() Message-ID: <9dcd5fda7a3819e896d9eee4156e7c46c9a64595.1744452787.git.dan.carpenter@linaro.org> References: Precedence: bulk X-Mailing-List: linux-gpio@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: The error handling in gpio_aggregator_parse() was re-written. It now returns success if there are no GPIOs. Restore the previous behavior and return -EINVAL instead. Fixes: 83c8e3df642f ("gpio: aggregator: expose aggregator created via legacy sysfs to configfs") Signed-off-by: Dan Carpenter --- drivers/gpio/gpio-aggregator.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpio/gpio-aggregator.c b/drivers/gpio/gpio-aggregator.c index e1b2efc0df99..62bb50af7cda 100644 --- a/drivers/gpio/gpio-aggregator.c +++ b/drivers/gpio/gpio-aggregator.c @@ -1128,6 +1128,7 @@ static int gpio_aggregator_parse(struct gpio_aggregator *aggr) if (!n) { pr_err("No GPIOs specified\n"); + error = -EINVAL; goto err; } From patchwork Sat Apr 12 10:15:25 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dan Carpenter X-Patchwork-Id: 880951 Received: from mail-wr1-f49.google.com (mail-wr1-f49.google.com [209.85.221.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7D20E1C84A4 for ; Sat, 12 Apr 2025 10:15:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.49 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744452933; cv=none; b=UwXkB6th4keRRHQtVXR3dcBgGwffGRA2hkjAOP3lDwZqp2xvsnbI5tksW4SNghNYMuHFPSC14D2uqdRe+SgYy7Ux4CfhZ+oJHtjacEXVw2MdIKidCo8K0nc4cCZwiDp+Yxk7U/DsRO9t7TqiwoczYAniyi2ANtqEVLwlputYy5w= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744452933; c=relaxed/simple; bh=NUlI7rfhNeG2einDOAQS0ehoOuYxAEcjEeCR3Ojkd94=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=MX5Bfwxabj6nm3iRUyASP+NvFJbo1zNA2UKCofRzC5G9H4G+n8u7e8zlx2X1ibSHUKz3nEf5JiF88svsJkKbexk+9/8+u4lp3JjHl+7twdqJHTIeiZzlqMR91i27hgw58JO4I3OvJRhruowKcuYACSsMGfn3IPnR0XSwrB/0ycA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=y04HooKI; arc=none smtp.client-ip=209.85.221.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="y04HooKI" Received: by mail-wr1-f49.google.com with SMTP id ffacd0b85a97d-39ac9aea656so2633150f8f.3 for ; Sat, 12 Apr 2025 03:15:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1744452929; x=1745057729; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=A1XAxbjahpYsXzMprDjhEjSwEqux/6xYa2KC6cfUrJg=; b=y04HooKIxLBF4qSp1eOrBPMgQLKnEApUdH1DCxcI0cKFlIwlCeFEzXsaifPo+jNNPr 1XLs86FFKBrhUmYoTmVlNOQvfn1VMMiUMquN6JrMAY9/Q2oiQJoVzS9ZP9aJnzTPBY77 oDqet4XLJ+A0QHO+AUE6qjkawtZ5phZWeTh3/XvdiJQCmggTjLgTtR0/kaJwgTqL0gDG BBfGoTxTYbL66bIKr5IekJIYHgwAZ71xmpxsdkhFZbYbpATLci/sfjwn33/BJghOnsLa rieTb/87dl/+cbayUQvkIrXNuYvukUdaU3S1JiRHIdn5XSd7I7fPEar/ajoA7pByKRxu wsKQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744452929; x=1745057729; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=A1XAxbjahpYsXzMprDjhEjSwEqux/6xYa2KC6cfUrJg=; b=ibxtdMYo5FiYZCH0moavUXOOcG4xhu/PuAYCJBpy00mG58GtNvxOFfpLuz5dLrT9KE FnO/u82VaUZ5LEa0oQHEiUkoeFH4Zer5SIA3aQmC9dJ+8aw8/hqOznE1xZTb5Twzh4D7 ROf2YfMb6/nXa/fMr7jkAh2LkkCVJ6VyGPlSkF5xFLG5BUiQ397PLBpoB7Rd4C0HM3pT 6NMVmKawDQlDdro6n8bRWjL9mDsoUMRDJ+Fy0wfIzB6lXnbwiKCR94jj2mKszu0ihh2/ L8RpA6GveVyqw6V4Q12aVixevEtlASRUlRvM1WkSx0yjIb1CAb/StkHzsRJSgSlHkF2S HdpQ== X-Forwarded-Encrypted: i=1; AJvYcCWLi3baxkRxtNB3/uRzRl8nVCwcX+jRRA8hcDbm0RR5s12UvWHAJV6xz4aqtlB51UfF/RF1NwPBmyKN@vger.kernel.org X-Gm-Message-State: AOJu0YwBFJ2M/LCtQtXXoUQGbnxc13QD4q1Pb5zS05klWilo1yhlDQSI xyuRck4dFfpEgTThXR/Hu7xciExVgZcM3QkgeR8QlDk5YMQvjGMMU8+xkLhD7Zs= X-Gm-Gg: ASbGncuqJaAMEhoFGyDgot7Uk4B6Q3ur9MyUbBNjTEl/WeE1LD0PmDf5JFBYi4DAvuO 65dOVDCN2BNXDvwBbGGOh677UmS7XhJrE1aNES+d4eUfLSBXsS23WySTXsfIkCuAE11qSfid4xH b6ml2Y0kVpoJOw2IGvvitS/u6FL1KdyMABzuWcbA2FMW3oRDiYkc7TnggtF+YAWemXzOg2OlqG/ EDgOCOSiVdZ54X1RVHytkncuLrdxspJLDTjvEqG2ZXMv+G2URs1k9Gxc8Ab2IkC7OQ1QlXLTMKP 5a+4YS+KKN3JPvUfSuR+Nk/WrcY5yLvLBNzbJJDq2MXrXQ== X-Google-Smtp-Source: AGHT+IHapgll/M9Y0x8YVjZfFG1kOPzA7Nw03Ls1YypBE3zK8Ial/wNTlxmGL7I6XZD3PCqHZHDMOQ== X-Received: by 2002:a05:6000:1848:b0:39a:c8a8:4fdc with SMTP id ffacd0b85a97d-39ea520372fmr5301002f8f.16.1744452928700; Sat, 12 Apr 2025 03:15:28 -0700 (PDT) Received: from localhost ([196.207.164.177]) by smtp.gmail.com with UTF8SMTPSA id 5b1f17b1804b1-43f207cb88asm112582865e9.37.2025.04.12.03.15.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 12 Apr 2025 03:15:28 -0700 (PDT) Date: Sat, 12 Apr 2025 13:15:25 +0300 From: Dan Carpenter To: Koichiro Den Cc: Geert Uytterhoeven , Linus Walleij , Bartosz Golaszewski , linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 4/5] gpio: aggregator: Fix error code in gpio_aggregator_activate() Message-ID: <79b804a0769a434698616bebedacc0e5d5605fdc.1744452787.git.dan.carpenter@linaro.org> References: Precedence: bulk X-Mailing-List: linux-gpio@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: Propagate the error code if gpio_aggregator_make_device_sw_node() fails. Don't return success. Fixes: 86f162e73d2d ("gpio: aggregator: introduce basic configfs interface") Signed-off-by: Dan Carpenter --- drivers/gpio/gpio-aggregator.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/gpio/gpio-aggregator.c b/drivers/gpio/gpio-aggregator.c index 62bb50af7cda..071d76dbfcec 100644 --- a/drivers/gpio/gpio-aggregator.c +++ b/drivers/gpio/gpio-aggregator.c @@ -626,8 +626,10 @@ static int gpio_aggregator_activate(struct gpio_aggregator *aggr) return -ENOMEM; swnode = gpio_aggregator_make_device_sw_node(aggr); - if (IS_ERR(swnode)) + if (IS_ERR(swnode)) { + ret = PTR_ERR(swnode); goto err_remove_lookups; + } memset(&pdevinfo, 0, sizeof(pdevinfo)); pdevinfo.name = DRV_NAME; From patchwork Sat Apr 12 10:15:31 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dan Carpenter X-Patchwork-Id: 880629 Received: from mail-wm1-f42.google.com (mail-wm1-f42.google.com [209.85.128.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EE25C1DB95E for ; Sat, 12 Apr 2025 10:15:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.42 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744452938; cv=none; b=WT4m1HfSwSawbu/BEB6npT/h7RGtPswN05emB+uLF1WBUlLPZE6lrZ5LKRicQBm8I++z3mnhiuYFYXN/UqloO98KDWIMo6zlIkEf3tzRhV3mfOODAa6EfuPrjrJhLMp82D8UMucafMgVxc4h81PmovsQGo/oasP+yYITfMwTss4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744452938; c=relaxed/simple; bh=U5hk+MMWODIgneoe/y7sjmG33jRN88m0448jMEiqvfE=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=JKcaJFuF75Y5VIQpGmZFAV8icLl+ctHH20iARh7QRC0uHkL1F/Caet+pnKocXpNfeVJ1uwQdwfw7re0rv28HhKcjRdLRNkLF4kNZBrKWC3hlSjYBJ4GE5uN3PX3BcqXYNYVIvT3N6+PdismP4Bp5dp0W56G0lqE1vg2su/aLlDw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=s8QrKQ0Y; arc=none smtp.client-ip=209.85.128.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="s8QrKQ0Y" Received: by mail-wm1-f42.google.com with SMTP id 5b1f17b1804b1-43cf257158fso20314695e9.2 for ; Sat, 12 Apr 2025 03:15:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1744452935; x=1745057735; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=e4ZyWmi66QBBd2EXEOk510Gi6AUK8otoa49t7kPH6c0=; b=s8QrKQ0YLrkvny7p8Vk4mO2D3IloATv5VmLyHCobKJi+7GeacHSRw9nmz4XUUBHUAk fT4IIXnCwFA7ZR2O+H7ICECgzt4XBo3H+r1XR27fvH9NWCPh+8Amxqe191qAOwAhawdx IK5Ss70MdpVbXL2zWsmM44rHOCcA5X+djAHUap92JMn3GkYkXGVkVq5Vi7s/OakqUGR8 cq7IkzWo9aS+OPY+3vLgIeSAYaPMUvf5eAfdUxujUVBvb8NuXoTb3UZyIxMtLlgXfTrh L4lLP/sXYHqKLCA3lc+vAPuC6YJBrV2azftWWH4Oiy1dVM7eCcXLx9rRCw1MKrkHrCzL jSCw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744452935; x=1745057735; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=e4ZyWmi66QBBd2EXEOk510Gi6AUK8otoa49t7kPH6c0=; b=SeE/0cca6l/EOoYk05UlbHlhRM5WN+VSULC64XtGj2imPlI8x+5QvDMHaIetVQKtZ4 Sz5+P5WwIDy/0NzR9rW7YDncn+Ia1+hDWa05ViW5fNRqX3zRKNWLdiGtnxagzRsAsFKX 32IzjbNeTaN/RXZTBUzdO0rvPhvw5aHZ5MUiw+eYb1XqdGES4V4Uw26PLtrrfvk6RlF7 qCGxW2elArIsZDloQYyZV07op2NiMBiolSI107MZe9hSMwI7dDb7yp0BBCOUJN2sZI7D HT4uEGL9kKrgRx8Wv3iUJGvTK3EQHUSVGgJ5KjT2PjYFjY3DkwwyoARkALbC7LgEQT7n JFtg== X-Forwarded-Encrypted: i=1; AJvYcCXnczRia7VH5L6d9G9pZ2/ZgfrnD7TlBSJJnvGHUfyxaSCoV7MLIdIFJ+Bp9cRP/43iQAZBu0ae6rSn@vger.kernel.org X-Gm-Message-State: AOJu0Yzz09qypRZbD+7CF/kO680r9T5HFggs0qkxOFFyfy15exgvkiSG Lv8tqxXUnLZtl+zQZrHMR9Kyc5sAMP4f1jnWQae0LsbOm5gmJH9vFnK6CVWh9Z0= X-Gm-Gg: ASbGncsEyH6xREkyS7/aW4CpJGC9TOkWnrxd9EsZiO32lDTj70+1NaH1GLrKEUqfcPc Qa7BBPFCd+xtN4Psw9wq8fJEfBlwY2ZQE9qkEpfyd3xJIGp4RhjeCzO1IZelJOO5j6vVEGr35JK LGRNrRBmux3EHJU16cDK2X5IlkaZgy3fTnm1J+6JGkFTlM7uM+QkREc+MrQ4LJUJ+B4Tlvfb1tG f8I7RbmQ2KeqKEKF8MU5dyCFSDECRHWd/AujfkLT79HynDb+VMAJ1msI+yN6UUbJ0G6yzupYh5I s8jRmiVqJVmPPBwEdo3IahOqVLNWjkIKCAMCzIXKHMygbg== X-Google-Smtp-Source: AGHT+IGQa6VYeWqqBTxj6y7PlQMkElGotH4Th/ZzP0eMaB+7v7hp4x7EvVajjz8OyBown1N1qO/VMQ== X-Received: by 2002:a05:600c:c87:b0:43d:abd:ad0e with SMTP id 5b1f17b1804b1-43f4aafa03amr1252175e9.18.1744452935145; Sat, 12 Apr 2025 03:15:35 -0700 (PDT) Received: from localhost ([196.207.164.177]) by smtp.gmail.com with UTF8SMTPSA id ffacd0b85a97d-39eae9640e3sm4735171f8f.12.2025.04.12.03.15.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 12 Apr 2025 03:15:34 -0700 (PDT) Date: Sat, 12 Apr 2025 13:15:31 +0300 From: Dan Carpenter To: Koichiro Den Cc: Geert Uytterhoeven , Linus Walleij , Bartosz Golaszewski , linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 5/5] gpio: aggregator: Fix leak in gpio_aggregator_parse() Message-ID: References: Precedence: bulk X-Mailing-List: linux-gpio@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: Call gpio_aggregator_free_lines() before returning on this error path. Fixes: 83c8e3df642f ("gpio: aggregator: expose aggregator created via legacy sysfs to configfs") Signed-off-by: Dan Carpenter --- drivers/gpio/gpio-aggregator.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpio/gpio-aggregator.c b/drivers/gpio/gpio-aggregator.c index 071d76dbfcec..6f941db02c04 100644 --- a/drivers/gpio/gpio-aggregator.c +++ b/drivers/gpio/gpio-aggregator.c @@ -1101,7 +1101,7 @@ static int gpio_aggregator_parse(struct gpio_aggregator *aggr) error = bitmap_parselist(offsets, bitmap, AGGREGATOR_MAX_GPIOS); if (error) { pr_err("Cannot parse %s: %d\n", offsets, error); - return error; + goto err; } for_each_set_bit(i, bitmap, AGGREGATOR_MAX_GPIOS) {