From patchwork Fri Apr 11 12:47:38 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Caleb Connolly X-Patchwork-Id: 880154 Delivered-To: patch@linaro.org Received: by 2002:a5d:4882:0:b0:38f:210b:807b with SMTP id g2csp741277wrq; Fri, 11 Apr 2025 05:48:03 -0700 (PDT) X-Forwarded-Encrypted: i=2; AJvYcCU6+yAD+0mYMgQT41bBkCe9fDvmu/yBITuFYNU4TNs9VRK8ZLEIzr0mQ/wtWmX4FbJyGl0Tgg==@linaro.org X-Google-Smtp-Source: AGHT+IHMX5ZT28X1nruRcp4sI2DebnKuNAKjlYTB553JGZ9qTw0sQWm39yQjOica/R0BQio+fLU2 X-Received: by 2002:a05:600c:4704:b0:43d:fa59:bced with SMTP id 5b1f17b1804b1-43f3a9bfc5cmr20750705e9.32.1744375683513; Fri, 11 Apr 2025 05:48:03 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1744375683; cv=none; d=google.com; s=arc-20240605; b=Tuy9v5CIJMi4l8DrqJB8oyT7BQkoW+Jg99GftZ0IDjTgQvIqkteRpO1N+YOBvXGrvw fW20SMZdfCTnNTWJpgCj3dxuTdCjvYRmeo/rMsbR10rVrm7zN9QV+RVkOuIMCNzrW8rm EJP8duFzMm0nRl6ifMf0dQr2E7g9lqCO1amRiHT1oeRx+fHFhSkU5Xsh/SzzyJ3Y1jHM UHYkV1nnVrYZkOW8nF0TYKv+iJMDXURSpth4zn3SJCjL+pMEOyaffFTrucjDRtp+/WHr nf2Ts+2iulUPMAsM/Nq3od2zC2yW1ri85z3G8Slas4puWA1mAe+MZYqZ/t4E2GMVc0j+ j1sA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:cc:to:in-reply-to:references :message-id:content-transfer-encoding:mime-version:subject:date:from :dkim-signature; bh=iRspixiP2BDoFtLSQctJ1k/6YWK73JbmOlYJPwbeZMc=; fh=TJCjflrKiBeSftjRSdah7JtSeIinGP9Gkkl07mj7NcM=; b=Or7WqZHFZD+KlKqSKXeFbDzUqLznaNQvHM6czIpogIS0EvBLB4MGUnEvV+hx8sVPel 6x1Q8Xrjnd6Mew3gaoXPiiEu646+Esgadr0ZGfbJZtyUTOe2IxCCffy8CNF90rbbRXBt bcqxU8bBm/mykxhBz7rNe2jrxlNPRC5O5csrxVbbt4b3CpATEBb5M3pofmiczWfNO/E8 GA55pF4rwq63B2pWeLvRFz/BOVlRbj3LS/toJsD6y3UXFaCFpxyfgN6ps5vXdDk3Zehc STRJi9ByVTr9yHpjXAJXUSyhKVKk4/DqHzg06XLit9wGkPp/UUYlvX+ptHDbB87oImqi djdw==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=B88i5KJk; spf=pass (google.com: domain of u-boot-bounces@lists.denx.de designates 2a01:238:438b:c500:173d:9f52:ddab:ee01 as permitted sender) smtp.mailfrom=u-boot-bounces@lists.denx.de; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org; dara=neutral header.i=@linaro.org Return-Path: Received: from phobos.denx.de (phobos.denx.de. [2a01:238:438b:c500:173d:9f52:ddab:ee01]) by mx.google.com with ESMTPS id 5b1f17b1804b1-43f29fe2eb4si35482495e9.46.2025.04.11.05.48.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 11 Apr 2025 05:48:03 -0700 (PDT) Received-SPF: pass (google.com: domain of u-boot-bounces@lists.denx.de designates 2a01:238:438b:c500:173d:9f52:ddab:ee01 as permitted sender) client-ip=2a01:238:438b:c500:173d:9f52:ddab:ee01; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=B88i5KJk; spf=pass (google.com: domain of u-boot-bounces@lists.denx.de designates 2a01:238:438b:c500:173d:9f52:ddab:ee01 as permitted sender) smtp.mailfrom=u-boot-bounces@lists.denx.de; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org; dara=neutral header.i=@linaro.org Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 1695283FF5; Fri, 11 Apr 2025 14:47:57 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.b="B88i5KJk"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 312E983FE1; Fri, 11 Apr 2025 14:47:54 +0200 (CEST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de X-Spam-Level: X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_BLOCKED, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.2 Received: from mail-wm1-x335.google.com (mail-wm1-x335.google.com [IPv6:2a00:1450:4864:20::335]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 228C783FDE for ; Fri, 11 Apr 2025 14:47:52 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=caleb.connolly@linaro.org Received: by mail-wm1-x335.google.com with SMTP id 5b1f17b1804b1-43d04dc73b7so20639215e9.3 for ; Fri, 11 Apr 2025 05:47:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1744375671; x=1744980471; darn=lists.denx.de; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=iRspixiP2BDoFtLSQctJ1k/6YWK73JbmOlYJPwbeZMc=; b=B88i5KJkuWp0M2mSw59XTZb8YfQrgTyQg4P5wfkMNPW0rXDPSUTERjjVolZI4dm4OE NlEnDWB67hRyMLZCzNZwEzW6MfcvZ4/D85CCar/1PxUOATTxQfM88C86e+iM3F14UQ9a FAyxeTX+uKaX/+SZ0ZxJNpuJTyuOL2aBMg6Sk/HYs0q8twWyd0aAKj2S8FD0FwklgCG3 bCzLh0sZH2e6QxWdiwVVvHreoUKYTxel7ivATu5DMXbm83XIA4xBQ9xynVHhVrBmA4s9 lIjthZEkyYsoJd+uJaCyPaXbPf6jervu8rQjoVbdL4ynD+1apR1R1HQoNbzIXnlcgoyG FDpg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744375671; x=1744980471; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=iRspixiP2BDoFtLSQctJ1k/6YWK73JbmOlYJPwbeZMc=; b=gueCeqbHkFZbMS4/ievMk/WKgY30RHgsejNmw1nWtItpeZuBeHi2lqLCvhVUzrR8VM vOMBOihz1suuIPPxeOcj8hjWdKtFYtfdYpq1SpHRd0twhntD1iWotFxbw2POcSS5MCPQ CbOwCd+4KbaPdzVGN78/wSVmpQGT8Egv+qKhjYe7dZGzyMUsRfIi9C9zU3AfABclldF+ f1ZUlQ6BWIY5RHs3vu6UwyBUxaBxIF12yAqJZTsyiHbs444/GWogrhumc0Th7ohA4oTS nIKenYNKCmtO8HhAgBwhBfa6GhXgDX2GwGEM4r1u0OYTO2pI0dwVhwjcyaa6IL8a0ffT RYww== X-Gm-Message-State: AOJu0YzGDbqpFa2boQuFsVXJvTMFiEs3NihcuCz1rvAd2iQJAqjlurYH FJ7doGvsfYEnDcPvGCkGESaTPFChc8C8Vwwfxw2QMcJ0gVTym4iZ7h/FtTWF+vc= X-Gm-Gg: ASbGncs+CE4MLuoFAr7HxOP5TBLrxCht8veZ5pZd+uwHyNOWyOy29/j3tgXxgh3V2+K Zf9geafZN7HdhVza4Q6CZN99x3bGIhow4BsCUsg+zb6jYKVRbyv4ubfYyRkEnlcGhJk/BMLK/e4 rFHISXrovt27Goaa6UX9Uwe5+lLSO1SnOPho5MP3xYJmFGkc8aiIgicv87a5DzEbW9mzsss6IYL 56JtsHrWr4nkmAzZak8TnU4VmZL1LZtOwvhXn0yPhiKx9OGgzCemKE3mSuEvvf+5Z2PWqjkxddX AQg8dHStb7NTVtxRsQcmXotSsokQ8izdJYa8P8gmzvrlj73YHzQEY6v23Sp5tzBpH0Vf0aXdW/3 MPx5tvOv+b2O2IMjniA== X-Received: by 2002:a05:600c:6a87:b0:43d:98e7:38dc with SMTP id 5b1f17b1804b1-43f3b055a75mr13869015e9.5.1744375671521; Fri, 11 Apr 2025 05:47:51 -0700 (PDT) Received: from toyger.tail248178.ts.net (35-60-142-46.pool.kielnet.net. [46.142.60.35]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-43f206264a1sm88299695e9.9.2025.04.11.05.47.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 11 Apr 2025 05:47:50 -0700 (PDT) From: Caleb Connolly Date: Fri, 11 Apr 2025 14:47:38 +0200 Subject: [PATCH v2 1/8] event: signal when livetree has been built MIME-Version: 1.0 Message-Id: <20250411-livetree-fixup-v2-1-1236823377bb@linaro.org> References: <20250411-livetree-fixup-v2-0-1236823377bb@linaro.org> In-Reply-To: <20250411-livetree-fixup-v2-0-1236823377bb@linaro.org> To: Simon Glass , Tom Rini , Caleb Connolly , Neil Armstrong , Sumit Garg , Lukasz Majewski , Sean Anderson Cc: u-boot@lists.denx.de, u-boot-qcom@groups.io X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=3586; i=caleb.connolly@linaro.org; h=from:subject:message-id; bh=PZwj/X0GyacoeT72dcXb1eQFSusHm6QwZ7CGU+yq/pM=; b=owEBbQKS/ZANAwAKAQWDMSsZX2S2AcsmYgBn+Q9zi/4h+H1gvr0P8pvmLeSCNYsBKj14WW5cX VEwDaBjY8aJAjMEAAEKAB0WIQS2UaFGPGq+0GkMVc0FgzErGV9ktgUCZ/kPcwAKCRAFgzErGV9k tktVD/9pnwl1Bv4+PaxC6Dm/Ga2yNaKMHsLxGj1/kooU4xnTbMTLgAg/splW7GIOZMYz239ya/E KA5UYtE7UvdUlMnyapcVR4WxrD70iftMAdKE5Evpl0dmFaQsDny21FW9QuO7lmstHsWrCiaYWkg Mo8DlV/6ubdzo2RR8eBR3k78slF/HMSLFXdnk/3r6eeJYORQJDp7Tjgc10Gl4NDqOesAJipXylE C+BVIoOnr0dnbgiZyscxUW/01/aoTec+NvWDkKRpzT5+c14ThQnn3SEw7R4wDgzfibRT5E8v1dl 1LhfFc5kO8rOI0uY+GHI1c8f0zBpx3745D2VTBRPQTjupkY/EN0ajllzNCd7q/s/QohFEyiFK4W tvOy3yhYxUWg4H17GyIefE0IkyFgyGOXAv1rQpoPoAsQVpAY9iLOYZXTIQPPfCqoQfKkpoez44+ Iec2zENMGnrQ3X9PUhe+wXI1eg9XvYvUYDgsLokn7vyCng/9KiX/YsZoUbJb+71z+p+8nmCiPee r89qADMss/GjoAPsPQXamja/I3/i78ZbTZFbPGEnuItYvKwyuL7Uph4G/FA8qsQRXRdMZ4NG8rz lnOIO2PqR61N7bRovYh3+ivgrz6pP7U5k0x2ir8t6ctM6VJo0aZugg7l1k+FDhELNEXSW4BNZGx xB+wXI3jhyQZ9zA== X-Developer-Key: i=caleb.connolly@linaro.org; a=openpgp; fpr=83B24DA7FE145076BC38BB250CD904EB673A7C47 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean OF_LIVE offers a variety of benefits, one of them being that the live tree can be modified without caring about the underlying FDT. This is particularly valuable for working around U-Boot limitations like lacking USB superspeed support on Qualcomm platforms, no runtime OTG, or peripherals like the sdcard being broken (and displaying potentially worrying error messages). Add an event to signal when the live tree has been built so that we can apply fixups to it directly before devices are bound. Signed-off-by: Caleb Connolly --- common/event.c | 3 +++ include/event.h | 18 ++++++++++++++++++ lib/of_live.c | 11 +++++++++++ 3 files changed, 32 insertions(+) diff --git a/common/event.c b/common/event.c index dda569d447851f559a83f98fb7b1f3543156eab5..8d7513eb10b61919e1e784481dfdcc076be14986 100644 --- a/common/event.c +++ b/common/event.c @@ -47,8 +47,11 @@ const char *const type_name[] = { "ft_fixup", /* main loop events */ "main_loop", + + /* livetree has been built */ + "of_live_init", }; _Static_assert(ARRAY_SIZE(type_name) == EVT_COUNT, "event type_name size"); #endif diff --git a/include/event.h b/include/event.h index 75141a192a48b0931667632f41be8ff4d6139f7c..1d267f1d10547642d381fa287ab4981a2bf03543 100644 --- a/include/event.h +++ b/include/event.h @@ -152,8 +152,17 @@ enum event_t { * A non-zero return value causes the boot to fail. */ EVT_MAIN_LOOP, + /** + * @EVT_OF_LIVE_BUILT: + * This event is triggered immediately after the live device tree has been + * built. This allows for machine specific fixups to be done to the live tree + * (like disabling known-unsupported devices) before it is used. This + * event is only available if OF_LIVE is enabled and is only used after relocation. + */ + EVT_OF_LIVE_BUILT, + /** * @EVT_COUNT: * This constants holds the maximum event number + 1 and is used when * looping over all event classes. @@ -202,8 +211,17 @@ union event_data { struct event_ft_fixup { oftree tree; struct bootm_headers *images; } ft_fixup; + + /** + * struct event_of_live_built - livetree has been built + * + * @root: The root node of the live device tree + */ + struct event_of_live_built { + struct device_node *root; + } of_live_built; }; /** * struct event - an event that can be sent and received diff --git a/lib/of_live.c b/lib/of_live.c index 90b9459ede313e492e28c8556c730f3bd8aaa9df..c1620616513c2e32448b4a6d156a9162d97c76b7 100644 --- a/lib/of_live.c +++ b/lib/of_live.c @@ -10,8 +10,9 @@ #define LOG_CATEGORY LOGC_DT #include +#include #include #include #include #include @@ -320,8 +321,9 @@ int unflatten_device_tree(const void *blob, struct device_node **mynodes) int of_live_build(const void *fdt_blob, struct device_node **rootp) { int ret; + union event_data evt; debug("%s: start\n", __func__); ret = unflatten_device_tree(fdt_blob, rootp); if (ret) { @@ -334,8 +336,17 @@ int of_live_build(const void *fdt_blob, struct device_node **rootp) return ret; } debug("%s: stop\n", __func__); + if (CONFIG_IS_ENABLED(EVENT)) { + evt.of_live_built.root = *rootp; + ret = event_notify(EVT_OF_LIVE_BUILT, &evt, sizeof(evt)); + if (ret) { + log_debug("Failed to notify livetree build event: err=%d\n", ret); + return ret; + } + } + return ret; } void of_live_free(struct device_node *root) From patchwork Fri Apr 11 12:47:39 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Caleb Connolly X-Patchwork-Id: 880155 Delivered-To: patch@linaro.org Received: by 2002:a5d:4882:0:b0:38f:210b:807b with SMTP id g2csp741342wrq; Fri, 11 Apr 2025 05:48:13 -0700 (PDT) X-Forwarded-Encrypted: i=2; AJvYcCWaH8skZFWOfF5iA7LdiKk9Rz8WW1GufDeBCL9OdWXj8zVS6zkoe0/Gwo+EsCjL9B3HDBVo2Q==@linaro.org X-Google-Smtp-Source: AGHT+IGoBG5MV7wbD4IlVCr2fxIc5muaKaV3sVUFveu3h/Pkha+GqWYYAIQok5zv6ARYKqIlbqch X-Received: by 2002:a05:6102:290d:b0:4c1:8f9b:19f1 with SMTP id ada2fe7eead31-4c9e4f12ed9mr1483662137.11.1744375693530; Fri, 11 Apr 2025 05:48:13 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1744375693; cv=none; d=google.com; s=arc-20240605; b=R9YhllQO4+nMu6UfCcjpBTFVjVUiSO1DdKJeRsXakVrt3JNmXgQS8M4nZyF67Hi4bN H1/ZwJb6QJbCRWKvVF03qzWVY60q/bIAWkmTHUSNqCPG7RccTXU9rYjrofEl+ppjIgU1 hS5xkAOJQJNsJk1k2/dOBZK+VCv5vBCLjuGGFAM61BzBwMAVvACI24DiNb4FNbJC93Va 5gD2MOcgLr+adbjBV3CBgcXmq38HLrNy1wFddS35aYz1usXPLUbKZ24gq807DNzWaf3h 9d76xXwU3pWnaQnAZE9XqZ0/Mn8Dxszhv/QXhXK0DIB94OWRKdpBd3+L2TPrIGQUtTcp zvcA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:cc:to:in-reply-to:references :message-id:content-transfer-encoding:mime-version:subject:date:from :dkim-signature; bh=1h7BUdmcue13UJ0vp9B5ZrdDJLLgHjxw10Rmee9iI9o=; fh=TJCjflrKiBeSftjRSdah7JtSeIinGP9Gkkl07mj7NcM=; b=brGC1gXXVIGPDAS35N1bxpA3qVP8+yGQHvxOcxzO3STCK8ixNJ0h8tGCktqzW8FieK Ybzsii4zbXbbB6/d1dKQJQpxaiPq/GlDBEEqyBYzDFKfgYa4rSWznJa2Xh91gJHLpQXn BUgFGHa/iG4h7ZcF24ONJMFWyLc3IVK1NXSDFkUFdL8Oc/4DLGY9wDLs4N4QiaH3XYYT adShrvHBnMJCQHgBgtc02qLhoGUs5t30jLOT3X1N0FVS9Jv/oItFAE2LueObuURo//xQ AvxjJYzihBKKt4Y0dEwEjAnkAPt9gQg1ZC2OPysL8Z9kIZFLEcwxzI6Pf1yxItBF9p72 sQ5A==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b="J2f4z/eU"; spf=pass (google.com: domain of u-boot-bounces@lists.denx.de designates 85.214.62.61 as permitted sender) smtp.mailfrom=u-boot-bounces@lists.denx.de; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org; dara=neutral header.i=@linaro.org Return-Path: Received: from phobos.denx.de (phobos.denx.de. [85.214.62.61]) by mx.google.com with ESMTPS id ada2fe7eead31-4c9c9890f34si2083864137.309.2025.04.11.05.48.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 11 Apr 2025 05:48:13 -0700 (PDT) Received-SPF: pass (google.com: domain of u-boot-bounces@lists.denx.de designates 85.214.62.61 as permitted sender) client-ip=85.214.62.61; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b="J2f4z/eU"; spf=pass (google.com: domain of u-boot-bounces@lists.denx.de designates 85.214.62.61 as permitted sender) smtp.mailfrom=u-boot-bounces@lists.denx.de; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org; dara=neutral header.i=@linaro.org Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 5F88683FF8; Fri, 11 Apr 2025 14:47:57 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.b="J2f4z/eU"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id BE53983FEC; Fri, 11 Apr 2025 14:47:55 +0200 (CEST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de X-Spam-Level: X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_BLOCKED, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.2 Received: from mail-wm1-x32c.google.com (mail-wm1-x32c.google.com [IPv6:2a00:1450:4864:20::32c]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id A9A0082B72 for ; Fri, 11 Apr 2025 14:47:53 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=caleb.connolly@linaro.org Received: by mail-wm1-x32c.google.com with SMTP id 5b1f17b1804b1-4394a823036so19610625e9.0 for ; Fri, 11 Apr 2025 05:47:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1744375673; x=1744980473; darn=lists.denx.de; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=1h7BUdmcue13UJ0vp9B5ZrdDJLLgHjxw10Rmee9iI9o=; b=J2f4z/eU/3f+b16hrgdlhNMvnwqtj5LHo0I1ZrKfl/HDBUxdM863CzyZfEdbFXOIOY 6iZgnFoiOMEr0+NLzecCdVfhX8L+HTlILohm60KZmBqaHZyYJKlaET/1ZOeIl8reJR/1 gmK1Dgx8jDethPfRmIkLVUP8hJLKS1XK20gSYdiglwAagyFkYpwGcodIGRij00FedR5+ BiCEfLRPOUbQCo1fVmNShXym6AYEXe/Mq3HzpLzzRKdiWs5vY9+Il4aVyH+X36HIp6uo 2TpMXKKBoDGqdQdozNcJFeeJkSwpvh1kQAZYpuDvSSBP0uRcpLv8nyefG4/hoCtXfWRQ YyxQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744375673; x=1744980473; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=1h7BUdmcue13UJ0vp9B5ZrdDJLLgHjxw10Rmee9iI9o=; b=hSTpw0DbGZmgazqVtUACIOKDjyA61m8ZK0VA8wnLJVMylQtd2GxSliJUS3KZkmAjui d0tiyZrBS1joo0oXsQOeKi7XrDgYJOB2WUpMFgF3EdfT5TtAji/mHD+yDe2u8EngBvGx LK4lRndOzDDUCwqt5kKfDICMJ3ao+JEGRSh0UZhN4NdDG/DMMK98X78RHIX6R6ZLg9kQ MLKj4MtaWaxNz1a2CD87b7tWdXmHNP3nZh2M3Vj9nWxzLOpzHTn8VCDd9m2FrIPpW+RM 5FEdhE1kTFEvMmR7MJTVPM6icafC5N/NQ33eGMU7ozMKWaimg3gW7c7Jnyk1HRfXNr4d oV8g== X-Gm-Message-State: AOJu0YxJagA2tWkCs6A3e6tKoc5LCb44G6xwx5YDHLrPTNA9i1b7a7X1 2PtMhcRRRcGabJibV6qx3zBftab0J526ggwdHt5RpwQDgSK/p53fgo3CAJ6LHpk= X-Gm-Gg: ASbGnctZVGu3V5Z2Qo9C7uScMu8IDRwuCDAoNE6uzJClqRb4ivwoF73jw3a7WihgN5v 6Gm3IE+5kLva7xrQyVU1/FJnCqQtbHf81ObVfWEJgFFgYK+ZXeMHtYMIdnIdZvEmCmZhMHRBpX7 vyAqGWSyFQAMdQ0idPkCmXpQDACFQMerMNScsr1vZ2wHjn20qr15ROjjfaJnHmb/pqR11l2qLtF +Sy8f4nnRy1xAF1IJBlAkb5uFBNV4d2DnHOXKKXIhJo4XZV5a80YzBcbEhgrmIRZVrSCvP2yONd 6va2ZgkEQ3J3vLAIKioji2pIdB0kkLVh4IxOWsWsgIY9gqMDVyDXtr6G9THMeOI/JmE5ToqS7co mD5TR6/6bAwcjOUwtPQ== X-Received: by 2002:a05:600c:574b:b0:43c:fc04:6d35 with SMTP id 5b1f17b1804b1-43f3c7857b2mr15731735e9.4.1744375673094; Fri, 11 Apr 2025 05:47:53 -0700 (PDT) Received: from toyger.tail248178.ts.net (35-60-142-46.pool.kielnet.net. [46.142.60.35]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-43f206264a1sm88299695e9.9.2025.04.11.05.47.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 11 Apr 2025 05:47:52 -0700 (PDT) From: Caleb Connolly Date: Fri, 11 Apr 2025 14:47:39 +0200 Subject: [PATCH v2 2/8] mach-snapdragon: use EVT_OF_LIVE_INIT to apply DT fixups MIME-Version: 1.0 Message-Id: <20250411-livetree-fixup-v2-2-1236823377bb@linaro.org> References: <20250411-livetree-fixup-v2-0-1236823377bb@linaro.org> In-Reply-To: <20250411-livetree-fixup-v2-0-1236823377bb@linaro.org> To: Simon Glass , Tom Rini , Caleb Connolly , Neil Armstrong , Sumit Garg , Lukasz Majewski , Sean Anderson Cc: u-boot@lists.denx.de, u-boot-qcom@groups.io X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=4696; i=caleb.connolly@linaro.org; h=from:subject:message-id; bh=ohlFA5WFbA+SNNitmNisDSZRuDqe1fL9TwcO6CTQbNw=; b=owEBbQKS/ZANAwAKAQWDMSsZX2S2AcsmYgBn+Q9z+23OL7uTb7BEj+uVsSseeqN7I97Ze/70J z5KPXOvkxSJAjMEAAEKAB0WIQS2UaFGPGq+0GkMVc0FgzErGV9ktgUCZ/kPcwAKCRAFgzErGV9k tq1hD/0aXVqxSPy3PQQIAyyh6B9pPFAxFKfjwi17/dQUg6+mSesx8n1SpfwUjUQzFafGXuqQqEC QaGz9uWJIWIaA/8YNXL/6Emrp1pm/Qlzvut+r/VXdsYA4QeDZDIHLvXQnAWZ0urPDo0Q3l1FRts qdt9ZbfNyWppZ8dodlcRrm+dsZSsauYrKsE7bBCwad1DPkyG8J1QuPoDGFGZidANyTRahONRIEa qK7p8YvOBjmvD4H942bXQOxULhzAJWb4evsRh8Id7LjGZeBdYuCgkxLPEtrfH8BNWAPZzBxtfqS RoFsK4mxwqO4Uln+6oOiuvy0HxfcWz7fIej+rwji1GPGN1Wb2CDE9qMCz17HsCzh7EoEiI5sbhj R8pBJ5kesf3AYdISy/kITFgPDa6A7OKvGTCgHvIlxwyUICoZ8okeC/FTGR7J1F5zl4vNrxtIF9m 38Bhsr5yhzZsZ6H0b8Y7RdqyVE/6ZXp9t61lH4z+ZRZAlrgpK9rNKkJtzEnc5ZCg1ELwm8qZwrd st4xWWF1QLjDf/coZ/zsCQQlftZfe8zD0tqDnHp0GeYRAFAB6HOSF+vVgLhbioSBQAEztklEzAo i06RgbsP2QGtrxGEyo6n2hSUGze4s4mir1eAAOqn8HKDBIE0Ui83ox2Tcy6LGDiAaA35jDQvQfH aLcg85eJfzDOhEQ== X-Developer-Key: i=caleb.connolly@linaro.org; a=openpgp; fpr=83B24DA7FE145076BC38BB250CD904EB673A7C47 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean This will now apply fixups prior to devices being bound, which makes it possible to enable/disable devices and adjust more properties that might be read before devices probe. Signed-off-by: Caleb Connolly --- arch/arm/mach-snapdragon/board.c | 1 - arch/arm/mach-snapdragon/of_fixup.c | 25 ++++++++++++++++--------- arch/arm/mach-snapdragon/qcom-priv.h | 14 -------------- 3 files changed, 16 insertions(+), 24 deletions(-) diff --git a/arch/arm/mach-snapdragon/board.c b/arch/arm/mach-snapdragon/board.c index deae4d323789eab75d5fe735159b4cd820c02c45..3ab75f0fce02ecffd476ebe2aa606b1a9024bbec 100644 --- a/arch/arm/mach-snapdragon/board.c +++ b/arch/arm/mach-snapdragon/board.c @@ -305,9 +305,8 @@ void __weak qcom_board_init(void) int board_init(void) { show_psci_version(); - qcom_of_fixup_nodes(); qcom_board_init(); return 0; } diff --git a/arch/arm/mach-snapdragon/of_fixup.c b/arch/arm/mach-snapdragon/of_fixup.c index 1ea0c18c2f2789a8aa054cd95bb9e4308d6b3384..70399307bcbda1e067230f00af6ba859a98c7ac0 100644 --- a/arch/arm/mach-snapdragon/of_fixup.c +++ b/arch/arm/mach-snapdragon/of_fixup.c @@ -21,8 +21,9 @@ #include #include #include +#include #include #include #include #include @@ -31,9 +32,9 @@ * USB controllers. Rather than requiring source level DT changes, we fix up * DT here. This improves compatibility with upstream DT and simplifies the * porting process for new devices. */ -static int fixup_qcom_dwc3(struct device_node *glue_np) +static int fixup_qcom_dwc3(struct device_node *root, struct device_node *glue_np) { struct device_node *dwc3; int ret, len, hsphy_idx = 1; const __be32 *phandles; @@ -100,11 +101,11 @@ static int fixup_qcom_dwc3(struct device_node *glue_np) return 0; } -static void fixup_usb_nodes(void) +static void fixup_usb_nodes(struct device_node *root) { - struct device_node *glue_np = NULL; + struct device_node *glue_np = root; int ret; while ((glue_np = of_find_compatible_node(glue_np, NULL, "qcom,dwc3"))) { ret = fixup_qcom_dwc3(glue_np); @@ -113,16 +114,16 @@ static void fixup_usb_nodes(void) } } /* Remove all references to the rpmhpd device */ -static void fixup_power_domains(void) +static void fixup_power_domains(struct device_node *root) { struct device_node *pd = NULL, *np = NULL; struct property *prop; const __be32 *val; /* All Qualcomm platforms name the rpm(h)pd "power-controller" */ - for_each_of_allnodes(pd) { + for_each_of_allnodes_from(root, pd) { if (pd->name && !strcmp("power-controller", pd->name)) break; } @@ -132,9 +133,9 @@ static void fixup_power_domains(void) return; } /* Remove all references to the power domain controller */ - for_each_of_allnodes(np) { + for_each_of_allnodes_from(root, np) { if (!(prop = of_find_property(np, "power-domains", NULL))) continue; val = prop->value; @@ -149,14 +150,20 @@ static void fixup_power_domains(void) func(__VA_ARGS__); \ debug(#func " took %lluus\n", timer_get_us() - start); \ } while (0) -void qcom_of_fixup_nodes(void) +static int qcom_of_fixup_nodes(void * __maybe_unused ctx, struct event *event) { - time_call(fixup_usb_nodes); - time_call(fixup_power_domains); + struct device_node *root = event->data.of_live_built.root; + + time_call(fixup_usb_nodes, root); + time_call(fixup_power_domains, root); + + return 0; } +EVENT_SPY_FULL(EVT_OF_LIVE_BUILT, qcom_of_fixup_nodes); + int ft_board_setup(void *blob, struct bd_info __maybe_unused *bd) { struct fdt_header *fdt = blob; int node; diff --git a/arch/arm/mach-snapdragon/qcom-priv.h b/arch/arm/mach-snapdragon/qcom-priv.h index 74d39197b89f4e769299b06214c26ee829ecdce0..4f398e2ba374f27811afd2ccf6e72037d0f9ee7f 100644 --- a/arch/arm/mach-snapdragon/qcom-priv.h +++ b/arch/arm/mach-snapdragon/qcom-priv.h @@ -8,19 +8,5 @@ void qcom_configure_capsule_updates(void); #else void qcom_configure_capsule_updates(void) {} #endif /* EFI_HAVE_CAPSULE_SUPPORT */ -#if CONFIG_IS_ENABLED(OF_LIVE) -/** - * qcom_of_fixup_nodes() - Fixup Qualcomm DT nodes - * - * Adjusts nodes in the live tree to improve compatibility with U-Boot. - */ -void qcom_of_fixup_nodes(void); -#else -static inline void qcom_of_fixup_nodes(void) -{ - log_debug("Unable to dynamically fixup USB nodes, please enable CONFIG_OF_LIVE\n"); -} -#endif /* OF_LIVE */ - #endif /* __QCOM_PRIV_H__ */ From patchwork Fri Apr 11 12:47:40 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Caleb Connolly X-Patchwork-Id: 880156 Delivered-To: patch@linaro.org Received: by 2002:a5d:4882:0:b0:38f:210b:807b with SMTP id g2csp741397wrq; Fri, 11 Apr 2025 05:48:23 -0700 (PDT) X-Forwarded-Encrypted: i=2; AJvYcCUOz+9c2otE3MFrNWkvyeo4fTl/DYgnimnI67CVoak3UZLmI0F2rXW8+ITO7SznDAXj8r3MEA==@linaro.org X-Google-Smtp-Source: AGHT+IEd0E5LSjCaql93uqxDI3j5XE83Vf1z/EwayZ+2qUbnaZbXjfaJYX8BRIqhkMLMMTt2jgXf X-Received: by 2002:a05:6102:8007:b0:4c4:e42c:38ba with SMTP id ada2fe7eead31-4c9e4f2283amr1495134137.13.1744375702900; Fri, 11 Apr 2025 05:48:22 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1744375702; cv=none; d=google.com; s=arc-20240605; b=TEJD2H19VxC0vInehFKeO6bhv4KkqGkL5x3PfjnWyJxAghrnCZEXnN6vxvsD/RFWaN 0NBBnoKVokL9hlhclvo92rYDzQz3zT47OH9EB5OvS709kdu6uiHi51IMGU6yGOCwjaqu TUmgvLouWO85mIdvQUIwxLnTc9uDLkfTs2P0oNRuNzmz/BLg4t9rZ9VwWfm6rE+PHojH rgPogpJAF+Ho5m19qHUJyP3bU/9OjGadbg+bEzgyrwo3/jvQK8PZ1ZDbFp/9I09gxWxe met/rj5u6M/1/KAokglpe4TPEuahfSENuiFH71ZKtM8Fe54X8kml49Isz1UCAEp+t6v2 lPow== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:cc:to:in-reply-to:references :message-id:content-transfer-encoding:mime-version:subject:date:from :dkim-signature; bh=rN2/t9X9csx7P8wW0eS4yF+EFxLwZyeSkdheVs30qJ4=; fh=qsEHxPwz7gvfHbf5sHcp5q1hoWpcZW3L+7PGTkgsjPU=; b=MhqKRLc7tXun07Nfh+7KZ9UfU4m8sDaUR7TLbAopvXLFeLztpyYzuHIqK3DyODwsdF ge9gAzDqxpDVRPP5CIJa1BKLTdqv/L0L9F3iqchUND87ILMyDEJTxNHeIWYZ7QGEReuh P2iacq3YM9gig8ea4lNMwk+sbMiB7ZLMvvwiKyU9s1bKnb8neXjkMbSU4n1sFVxWyJPE hVO1yqcea/GUWwpVI+BR/b43jHWhEVlOuvnkLFtUse/7Suyf36UbJxXI4R02G18p5L5f X1Lv+0BIcRtRP0i5shxODJWFaxeT4x/Z8vCXOcobQLoG9jKDYOmKuhrsA+KAWnJU9v/k 3sLw==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=ahZCDnqP; spf=pass (google.com: domain of u-boot-bounces@lists.denx.de designates 85.214.62.61 as permitted sender) smtp.mailfrom=u-boot-bounces@lists.denx.de; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org; dara=neutral header.i=@linaro.org Return-Path: Received: from phobos.denx.de (phobos.denx.de. [85.214.62.61]) by mx.google.com with ESMTPS id ada2fe7eead31-4c9c973e640si1824266137.33.2025.04.11.05.48.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 11 Apr 2025 05:48:22 -0700 (PDT) Received-SPF: pass (google.com: domain of u-boot-bounces@lists.denx.de designates 85.214.62.61 as permitted sender) client-ip=85.214.62.61; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=ahZCDnqP; spf=pass (google.com: domain of u-boot-bounces@lists.denx.de designates 85.214.62.61 as permitted sender) smtp.mailfrom=u-boot-bounces@lists.denx.de; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org; dara=neutral header.i=@linaro.org Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id A2EC083F7B; Fri, 11 Apr 2025 14:47:58 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.b="ahZCDnqP"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 2FA2083FF0; Fri, 11 Apr 2025 14:47:57 +0200 (CEST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de X-Spam-Level: X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_BLOCKED, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.2 Received: from mail-wm1-x336.google.com (mail-wm1-x336.google.com [IPv6:2a00:1450:4864:20::336]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 170AD83FE5 for ; Fri, 11 Apr 2025 14:47:55 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=caleb.connolly@linaro.org Received: by mail-wm1-x336.google.com with SMTP id 5b1f17b1804b1-43ce71582e9so15933945e9.1 for ; Fri, 11 Apr 2025 05:47:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1744375674; x=1744980474; darn=lists.denx.de; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=rN2/t9X9csx7P8wW0eS4yF+EFxLwZyeSkdheVs30qJ4=; b=ahZCDnqPjH25wYo1i2efOLgTDJXaR069RiYDacoieMHmsBMv4pUKQ+xEjo8HVlfjoa SJMNxX6iuDjpYVSS8fZ+gkChwC7RYjqn0eMdn9cocy4EKvFmNaPTPbTGbskaLvu8qCQP p25M3+bVfrMAfWCUulsz8cnbb5HmbBsRmn7A5CGyTQB1Kt8Poz+YoYT28MM7t3YACq7y 1Y2jjMsAysjmblPXMB0I9eck3HzMF2w0btxERj7ABSPQCafcQZs7W8CyFuI2kOuYUsvt b+LZL9VgkPYFNuY1PBwO347fJX8I2WBZIxGuZNcOU58+EjZu0I32ZI4lEIHdFck77rDX 1fbA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744375674; x=1744980474; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=rN2/t9X9csx7P8wW0eS4yF+EFxLwZyeSkdheVs30qJ4=; b=dLKwhJeMFNA6dgRB3+5x3zZWC3oLlRWFcYCHLcfb+vmGhsxVdq4IzrbHgnieg3WnXZ wmKiVFtqnwhAbXn96zBABNnyCtpcdHsKAS83BhFNCDi1R78+yhTzYGxaOdo7b+f6f4er tp5vK76/FNhJvl8gFmAvsKiUP5WKZmMt4dBN21T/WConpCKhEihn+8+qP7nRzE9fOQ7n XMGyUHoT2vtSUk1EPkhUivLMvJh6jQ/YSb2vXA29gjxCuBCxNWABwKq+GilsejTGXkoU cD/FmXik/nLk9yzlwb5UH+gIs25Vfh6JBQrtpuKZskGNQT8m4FZaj331BMOSvVekfyH9 GgXA== X-Gm-Message-State: AOJu0YwIQR63zTRRhKoL/KyRxRuME91Tmo1ON21n8c5AO+vZcpZyMZyi zmBOQkZqu01sdh58V4oYMmpwEp/sMGjufPq92pYlRIIcWOxAnqWRsKzrbnh21/p6b5+x2y9hSuo kN4Q= X-Gm-Gg: ASbGncuDxLsbJf8eYUX/tEoC47VIny9GxpNdvUEo2eoLZPZ4c2Uuxx47sjhh/0lKwF0 4L/NCdVnvRE/5TRvtaqIJ8DrkJGgQS8Fpjr1Sdzz15CdRYGzLQjheC5p9qn79eWMhyX7WfmZFuY q0Yh0ou6+Vl8N8WsJQSQj4pMxTwIdqPjeS0fhZ95dPkY5QKD0jZV2z84xe5Rh0/HjZrsacFiWix ExWwCvBh5q1DU14u255SxRasBuGqcx2gSBsUTEnWp6IeuSn9NDibPiWS+ZvzhuY/J61aw1SAv2W Q1Mw8XKKdeSZZ4eA/Bkg3H2f4k86AHBVilgG41cJ5WGGVNWc7jD8piqACDC4XmEdb2uaZPPFylo 87KlZdAjT6cw47hf4Lw== X-Received: by 2002:a05:600c:4e89:b0:43d:683:8caa with SMTP id 5b1f17b1804b1-43f3a95979dmr22242145e9.15.1744375674573; Fri, 11 Apr 2025 05:47:54 -0700 (PDT) Received: from toyger.tail248178.ts.net (35-60-142-46.pool.kielnet.net. [46.142.60.35]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-43f206264a1sm88299695e9.9.2025.04.11.05.47.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 11 Apr 2025 05:47:53 -0700 (PDT) From: Caleb Connolly Date: Fri, 11 Apr 2025 14:47:40 +0200 Subject: [PATCH v2 3/8] mach-snapdragon: of_fixup: skip disabled USB nodes MIME-Version: 1.0 Message-Id: <20250411-livetree-fixup-v2-3-1236823377bb@linaro.org> References: <20250411-livetree-fixup-v2-0-1236823377bb@linaro.org> In-Reply-To: <20250411-livetree-fixup-v2-0-1236823377bb@linaro.org> To: Simon Glass , Tom Rini , Caleb Connolly , Neil Armstrong , Sumit Garg , Lukasz Majewski , Sean Anderson Cc: u-boot@lists.denx.de, u-boot-qcom@groups.io, Sumit Garg X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=1142; i=caleb.connolly@linaro.org; h=from:subject:message-id; bh=sONotuULnc7O3riBg9ZpcKSp11F2nFGIEsZmBRNwE/c=; b=owEBbQKS/ZANAwAKAQWDMSsZX2S2AcsmYgBn+Q9zOEp/YYgUNrWEkJyJkmmOF2QuRMcRXGqZR HfhTn3LGZeJAjMEAAEKAB0WIQS2UaFGPGq+0GkMVc0FgzErGV9ktgUCZ/kPcwAKCRAFgzErGV9k trCND/wPoMuqelW1LYpyTkIZs1M2WCOqLFfHrm/XBLwWshB5xPUdUukKk9NzBun36F/Ko1qghWh bR/afV/DdChH1sCY/75Vy+r3lEoqKuy31a8g7HWNVmeh+YdcWeonBahoOWC7IQfBWZb6EJl7BeK STbmlMkFUQMe4ibHPlOmTqnfhqlPu11cm6v0O49jtfXHTG4sPC4yNZKfAvi6DcukfmwEGA5C+da hEW9DnszepTwPQreWF3b3963or2UhUTumUXalivQlO+Cl5mKm/O+KblqKMsoz193rtERKrkUjKl 6HrPZUF2H1sAqBHgssXDhnFMeklGE8iSNgcSPRR1o7D1h9BQuXs69hhmMc3YI8P3a2F+lpjgwam FecVOBNoVli5rAYbnnK9NlkqfqjelqQe9l5BgGXxPfj4cW4c67/q32vH722fSkV7vXzi78mvK7H 57q7kT19/xjWqd+TKrR6qWMbvIWDJmL/orZb0AfPrJAWlOzf77zn9gK9gwZelikcWkD4HKhIdgW 6+WGc2j5mAAm3d4O/QKy8kcb77Bxz/zmoRw9txPpUs0cztUTzynAQ/TLlf+TPd4E6iU+7EJv36h s1aDxfR2PnA1be06VgtHEkL8Nm+CRbY3QGkveEreFHVtYzfcU78UQ/xXqFMswapxHeAv4j+C4iG RP8WS6/MdmWZUDw== X-Developer-Key: i=caleb.connolly@linaro.org; a=openpgp; fpr=83B24DA7FE145076BC38BB250CD904EB673A7C47 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean There's no need to waste time fixing up nodes that aren't used on this device. Skip them. Reviewed-by: Sumit Garg Reviewed-by: Neil Armstrong Tested-by: Sumit Garg Signed-off-by: Caleb Connolly --- arch/arm/mach-snapdragon/of_fixup.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/arch/arm/mach-snapdragon/of_fixup.c b/arch/arm/mach-snapdragon/of_fixup.c index 70399307bcbda1e067230f00af6ba859a98c7ac0..dcd09ee7cac3e02287647c9e6df5575651e18e85 100644 --- a/arch/arm/mach-snapdragon/of_fixup.c +++ b/arch/arm/mach-snapdragon/of_fixup.c @@ -107,9 +107,11 @@ static void fixup_usb_nodes(struct device_node *root) struct device_node *glue_np = root; int ret; while ((glue_np = of_find_compatible_node(glue_np, NULL, "qcom,dwc3"))) { - ret = fixup_qcom_dwc3(glue_np); + if (!of_device_is_available(glue_np)) + continue; + ret = fixup_qcom_dwc3(root, glue_np); if (ret) log_warning("Failed to fixup node %s: %d\n", glue_np->name, ret); } } From patchwork Fri Apr 11 12:47:41 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Caleb Connolly X-Patchwork-Id: 880157 Delivered-To: patch@linaro.org Received: by 2002:a5d:4882:0:b0:38f:210b:807b with SMTP id g2csp741516wrq; Fri, 11 Apr 2025 05:48:41 -0700 (PDT) X-Forwarded-Encrypted: i=2; AJvYcCVIic1YEQv4g2SHmhoBaZKKmj+U0mk6aTs248yF7/fADwnbCJ8cVHl8KZNeFydWyV7S45/MIg==@linaro.org X-Google-Smtp-Source: AGHT+IHgOD9DmsFyDDjVJE69cBqlrkHZenZG3pnDBOTao/tmbArTQQGHRL/oZtDikfVTziXYPyfH X-Received: by 2002:a05:6102:330d:b0:4b6:9ba:72c0 with SMTP id ada2fe7eead31-4c9e3c724b4mr1675914137.1.1744375720852; Fri, 11 Apr 2025 05:48:40 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1744375720; cv=none; d=google.com; s=arc-20240605; b=UIALuz0IRg3Khs6tUmiZkmuV/8IRe/oCGZ1qrK5+5NoDyg7yTX1RpjHY33SwZc5SxM HLhWvo+bH05aODhpTY/ziqqsv6ehDcNzGCabcvu7mLIz/dLpx8A1snHH8PU0zicWRtHV u4TLEiQsAX5CjNpjt5MIdwQcMrrKcSGzdrquc7DnZvx8KseVLs5zu5a7KfSCvjV93ioV pNAOuvnDuQKwZQGnacR+holo49wPTYfZ9TxRA2xMrOzD56rfWuerobCae+77Q/MbR4iv yalWsTjyUDXHVKUlka02Xv+JKzyww6God79OXwbRM1L/3s2DLZohQZAYyqir0vUc6Gsy hmMw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:cc:to:in-reply-to:references :message-id:content-transfer-encoding:mime-version:subject:date:from :dkim-signature; bh=mxIX89NM3xuPk5XZ18wAkhZkHJGxePGi4hd4adg4MpI=; fh=TJCjflrKiBeSftjRSdah7JtSeIinGP9Gkkl07mj7NcM=; b=KBf+6DiVoTUVNmV3LOXv3tx6B8poalkYJ9+qcMGxUS0Gn8seWEnllIrsC1zpLAuXWc ZJJlpbSHH9Bf9zVUJ+i/9kxmIiz+3V5um7+RzrmDUGABa9YB6AwkDOSmm0TjzB+gLO3V tRyN7Hm3rLN7FRwr6P1mpuYHXErLQiS/b+fodB7DRT2wtCWq16bagvLmsTAki/k6Rr+g duZJ6hNDkKWeoIV32tZpnpIuZc0JjOEggBCXELzoZ5+aKpUtvGHz8A9QXHHAs1bWtMbl giao7LE/6DRWXsCfyk+QmsCWdPyexMYXRIjlgdUMQ8OfcBXh6Ry3ETfjU+U8JWIu1w7i vIBA==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=tNA1S2As; spf=pass (google.com: domain of u-boot-bounces@lists.denx.de designates 85.214.62.61 as permitted sender) smtp.mailfrom=u-boot-bounces@lists.denx.de; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org; dara=neutral header.i=@linaro.org Return-Path: Received: from phobos.denx.de (phobos.denx.de. [85.214.62.61]) by mx.google.com with ESMTPS id ada2fe7eead31-4c9c98c610bsi1830696137.439.2025.04.11.05.48.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 11 Apr 2025 05:48:40 -0700 (PDT) Received-SPF: pass (google.com: domain of u-boot-bounces@lists.denx.de designates 85.214.62.61 as permitted sender) client-ip=85.214.62.61; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=tNA1S2As; spf=pass (google.com: domain of u-boot-bounces@lists.denx.de designates 85.214.62.61 as permitted sender) smtp.mailfrom=u-boot-bounces@lists.denx.de; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org; dara=neutral header.i=@linaro.org Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 3612F84014; Fri, 11 Apr 2025 14:48:01 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.b="tNA1S2As"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 2BD6283FED; Fri, 11 Apr 2025 14:47:59 +0200 (CEST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de X-Spam-Level: X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_BLOCKED, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.2 Received: from mail-wm1-x329.google.com (mail-wm1-x329.google.com [IPv6:2a00:1450:4864:20::329]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 8C49783FED for ; Fri, 11 Apr 2025 14:47:56 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=caleb.connolly@linaro.org Received: by mail-wm1-x329.google.com with SMTP id 5b1f17b1804b1-43cfa7e7f54so12312555e9.1 for ; Fri, 11 Apr 2025 05:47:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1744375676; x=1744980476; darn=lists.denx.de; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=mxIX89NM3xuPk5XZ18wAkhZkHJGxePGi4hd4adg4MpI=; b=tNA1S2AsyQ6m3kk8X8KbwjK0YIsSfziT+NMN35Wuc0eM0sH+Kjb9xYY87iTtbiTVSW YWM+s+LTXlEqWXMVBUlGlGJxzxcvO8yCeOnHY310R133NnLeCrv7jUfXE7G6To6SjQ3e FbwILScGMqNcvphvL+85kw0bhiuYugIXyoE+Vl0RwlPeARh7m3ljI/HbrRJn9kjh1enn sKu2ZO/GjMX7A47Lzw/2EHjMMUaARzwiyIdQhdbyTBhm2BTjElDgik9p2BdGLdMpLtaQ CpItvlH41mOcwLNU7eIAJp/Euu4C+z2XMiAFk8ucifwAdtmuB7jTFN0T9UWcvIrzRRHa X5VQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744375676; x=1744980476; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=mxIX89NM3xuPk5XZ18wAkhZkHJGxePGi4hd4adg4MpI=; b=J0DSPXW57EXkd7OF6ufFP4slCBspYjn5v1CEu/pv13NYeX/5O/4MxU8Ay+PWzgKa+m yKgowzZ3UvOhAppimtri6nbm5a2nGsDiUpg5hTpr5XZFAimXCRPUH8bdgZ0lRIbCkhYj cJcjz88Hgh1sD496UqveMWXJ2TebyRrilLFl3KADgMow1kYrQBSVaKA2GfDsCwpXoy1N EAAuUCpNCawW0vUSLgs3EWjE1a+x7mZ8rzW+VU+TLBdSYjakSe/uiFiBB48ttTO96zPM l/PtbRHLBvZgQLyop63vlxKuZANvHzOJ5D/jesmOfbjy5moS8i8bnj5EDxjg8uMsowju sz+g== X-Gm-Message-State: AOJu0YwI0r/gdH9WEQRUGh6IBGGugRfCh5TMSaQ04YHm7UI6nYotPKH4 bntD8wju0am5in4rbqzTliGiV6YR2BUxWXdlJfl3cHMmLnj/JNP4WDx3AOLCMChj/KYSAXJg2Xx 3SfE= X-Gm-Gg: ASbGncu40w2QnMpVb9rV17EHxPslWtAGkBwT6YQB3Q7XUHJKfU1nJdREVLY1MDrKc66 V6DCdbXht0oasjT+6nc+jUxNkJNysWwdmOTX3surmu4Xr8SGyz2SgybKuuK1e4XXZ4yUHpf6F8z lEktKBvZqyVKvLebIL6UY0/eogqhSZvSKWq4gMHpREJn3CbOUXqSzqzuBWApsIAiti8gtCd8UWN 6VNjOcxQWWWG3XaT0ayKwohMEzx8o5H2kb1YdNIQRM+3D9/OSKc5/vKlGtMxYwzXSry+YetNDaP ODvAIw+m7ylNQc+sPN3gWBKe6xl5sYyOCElgL8t05H96W9pw8T57YnyqfYROb0mcV+B0ymnagWg ghM4iDhsFgViS1PsK9A== X-Received: by 2002:a05:600c:1d8c:b0:439:9737:675b with SMTP id 5b1f17b1804b1-43f39663a6emr23495505e9.7.1744375675964; Fri, 11 Apr 2025 05:47:55 -0700 (PDT) Received: from toyger.tail248178.ts.net (35-60-142-46.pool.kielnet.net. [46.142.60.35]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-43f206264a1sm88299695e9.9.2025.04.11.05.47.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 11 Apr 2025 05:47:55 -0700 (PDT) From: Caleb Connolly Date: Fri, 11 Apr 2025 14:47:41 +0200 Subject: [PATCH v2 4/8] mach-snapdragon: of_fixup: remove confusing log message MIME-Version: 1.0 Message-Id: <20250411-livetree-fixup-v2-4-1236823377bb@linaro.org> References: <20250411-livetree-fixup-v2-0-1236823377bb@linaro.org> In-Reply-To: <20250411-livetree-fixup-v2-0-1236823377bb@linaro.org> To: Simon Glass , Tom Rini , Caleb Connolly , Neil Armstrong , Sumit Garg , Lukasz Majewski , Sean Anderson Cc: u-boot@lists.denx.de, u-boot-qcom@groups.io X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=1362; i=caleb.connolly@linaro.org; h=from:subject:message-id; bh=KdNHBh7X+OPCjALeekUNGdO/oJkKXN6mVkabax6dwP8=; b=owEBbQKS/ZANAwAKAQWDMSsZX2S2AcsmYgBn+Q901/j+VvwVjjNE/jIknclxqqzDrYrmj3XI1 ktytHYmFj6JAjMEAAEKAB0WIQS2UaFGPGq+0GkMVc0FgzErGV9ktgUCZ/kPdAAKCRAFgzErGV9k tgG5D/40xHVxMosISGMOCQvL3J2S0LfmBPKFxHd+YLPCZTH3fxGn60EORod1xDzQ6qL9minM96H 6fzqh6OIaX32xPpENuO4i/CaZD14WgLhwTRaK6RBEPH8DVNtAv2R+MdB3eRhjS1FdRZ1/rPLh68 WnHfZgem51lxfXXZHzk3RhdAQeNoYgNw8SRWx23XgIdd53WgQDvfAqD9CwZJird2i5GJGUk+uIu X4gu35pncwmV+7TsBdjd4iGF1CtfCp4IU50RKLXLaX/gQ5TtXToBvlM1J7wN3Y0ud+bXaXGgAkH ywbswaU9evmt9Hffqxdn+qMO6uV1A8nBujVErVuNDyTiVkoLvAanj2idIPT82oyvc6Ny5Y2fg8D TUHIyhjPggQ76Ygnm/g1bJ+EOJi7nLWa8vdvwURxH4FBTS50HrCE/RoHR5VsGmjVNwwRrNoSVdN NnMHTV/pPENLPHA7wvIiDQ0yDi7M6yO0hoPYuQY0j3xJbcyimFieroDpKqcCD7c9mUIMyXNKxW+ x+1NdRC8oCrbzCatn63RTUGsngMLksBKsngWRV2tjny9sgiaGKCkri5B2MxXVRhb2zJ0fHMZioR vL9ou5sus1lpZoFIfva9IVreyiCmSotuEE97rRDiG8UuR1uR/f+gzCcE7zYb5CY+on1g2BbD6aR VB0V2R1vgJV5wAg== X-Developer-Key: i=caleb.connolly@linaro.org; a=openpgp; fpr=83B24DA7FE145076BC38BB250CD904EB673A7C47 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean The debug log here had the logic completely backwards, even though the code is actually correct. Remove it since it's extraneous anyway. Signed-off-by: Caleb Connolly Reviewed-by: Neil Armstrong --- arch/arm/mach-snapdragon/of_fixup.c | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/arch/arm/mach-snapdragon/of_fixup.c b/arch/arm/mach-snapdragon/of_fixup.c index dcd09ee7cac3e02287647c9e6df5575651e18e85..a5515c02d3de05944dfb7c1b2a5542631b517497 100644 --- a/arch/arm/mach-snapdragon/of_fixup.c +++ b/arch/arm/mach-snapdragon/of_fixup.c @@ -72,13 +72,14 @@ static int fixup_qcom_dwc3(struct device_node *root, struct device_node *glue_np log_err("Failed to read second phy name: %d\n", ret); return ret; } - if (!strncmp("usb3-phy", second_phy_name, strlen("usb3-phy"))) { - log_debug("Second phy isn't superspeed (is '%s') assuming first phy is SS\n", - second_phy_name); + /* + * Determine which phy is the superspeed phy by checking the name of the second phy + * since it is typically the superspeed one. + */ + if (!strncmp("usb3-phy", second_phy_name, strlen("usb3-phy"))) hsphy_idx = 0; - } /* Overwrite the "phys" property to only contain the high-speed phy */ ret = of_write_prop(dwc3, "phys", sizeof(*phandles), phandles + hsphy_idx); if (ret) { From patchwork Fri Apr 11 12:47:42 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Caleb Connolly X-Patchwork-Id: 880158 Delivered-To: patch@linaro.org Received: by 2002:a5d:4882:0:b0:38f:210b:807b with SMTP id g2csp741572wrq; Fri, 11 Apr 2025 05:48:49 -0700 (PDT) X-Forwarded-Encrypted: i=2; AJvYcCVN9Mptzg3aMYVTuIKIGh/k0DJ6MLlgaMZpvEcgX42k3lGsO8eXuVED6+VQIkoGamuCNucPRQ==@linaro.org X-Google-Smtp-Source: AGHT+IEP/MJtH1utqi1rDHgzKlhyFakVDj/5izX9s50QqxAXMvwTrCeIS3/bxw8TsL7eguqB1WCa X-Received: by 2002:a05:6000:248a:b0:39b:f12c:385e with SMTP id ffacd0b85a97d-39ea52019d7mr1858599f8f.20.1744375728872; Fri, 11 Apr 2025 05:48:48 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1744375728; cv=none; d=google.com; s=arc-20240605; b=MpB6cfmeLIK64mo8oaQbL6RFSJmasaC/paQYuhykQOTqzk1qgP8Vs2dn8G7nMQ4Z0a IRGklGhBFQG4nGTAa5L7Rr/h9uZOYkawJUu00WjC0KnDN9dPeWzA7WDZZ+R50Hit72pZ 2X+z4rOc5df5JUL19i2fHu5c4+RwB4/l+WktWi+0erV2iecjdzoF5NIVUrrprr9D4i6s XB400ER0bYPdDUIFYLNKSCQyLB4wTvjJtUYtFQnsLy4fSUPW3ojU8rUwvB9jU0Zjfh4r hXKmI/8bV9Rr5gaJ9h27jxytHim8CK02GrkV5kg8WwaFDnybaC3TLcc/MQZDViyJ2o0y MHxA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:cc:to:in-reply-to:references :message-id:content-transfer-encoding:mime-version:subject:date:from :dkim-signature; bh=0CLKStleFsDlucFcVBypNI53bNGF4KiYAU5jyo/fWc0=; fh=TJCjflrKiBeSftjRSdah7JtSeIinGP9Gkkl07mj7NcM=; b=ZMB15gVcqtrKXdTInEHs+s7T2JXXpEVjr6z+tb3ZeCOHdQVYce0keA6m36meGNrMwj AxoGnYL1tARfs6/MvwCFlaGjpQO1s8O2ForiXRIU+Ras786uHFycC3zOVm4/QVz8LYCw MiuMrn5MDIOex0chkazOQ4wr/IgNQTe4KfkazhCZQ5+zXHRcs7TRKnkEsS8FVy4nPSus umEEz2DJInPpaC+NBJeixaXnIX0q02FnabxAOof1CVftemqFZ1qGynK/PytCk/sPzSk2 TeqV/93iFNwonboFpAooVsK+Fk1H1r+DA8rs4kFB4aOwWOe0JvCZut/mhmunEmnFVmIC AJ8Q==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=kmO71LMt; spf=pass (google.com: domain of u-boot-bounces@lists.denx.de designates 2a01:238:438b:c500:173d:9f52:ddab:ee01 as permitted sender) smtp.mailfrom=u-boot-bounces@lists.denx.de; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org; dara=neutral header.i=@linaro.org Return-Path: Received: from phobos.denx.de (phobos.denx.de. [2a01:238:438b:c500:173d:9f52:ddab:ee01]) by mx.google.com with ESMTPS id ffacd0b85a97d-39eaf440497si916736f8f.668.2025.04.11.05.48.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 11 Apr 2025 05:48:48 -0700 (PDT) Received-SPF: pass (google.com: domain of u-boot-bounces@lists.denx.de designates 2a01:238:438b:c500:173d:9f52:ddab:ee01 as permitted sender) client-ip=2a01:238:438b:c500:173d:9f52:ddab:ee01; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=kmO71LMt; spf=pass (google.com: domain of u-boot-bounces@lists.denx.de designates 2a01:238:438b:c500:173d:9f52:ddab:ee01 as permitted sender) smtp.mailfrom=u-boot-bounces@lists.denx.de; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org; dara=neutral header.i=@linaro.org Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 7E46B84019; Fri, 11 Apr 2025 14:48:01 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.b="kmO71LMt"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 271E084009; Fri, 11 Apr 2025 14:48:00 +0200 (CEST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de X-Spam-Level: X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_BLOCKED, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.2 Received: from mail-wr1-x429.google.com (mail-wr1-x429.google.com [IPv6:2a00:1450:4864:20::429]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 1E3F783FDE for ; Fri, 11 Apr 2025 14:47:58 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=caleb.connolly@linaro.org Received: by mail-wr1-x429.google.com with SMTP id ffacd0b85a97d-39129fc51f8so1536412f8f.0 for ; Fri, 11 Apr 2025 05:47:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1744375677; x=1744980477; darn=lists.denx.de; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=0CLKStleFsDlucFcVBypNI53bNGF4KiYAU5jyo/fWc0=; b=kmO71LMtHEQX3arA5kMSWAnlLI66Mbz8cb9SlBETTGOPXsIXDd6sGJMEKyFnYVvCid TOzZ/PfZAg+s8HfQWYG8hjquMejFrczpQlU06KMio3culHQpZmjU5c1ZHXFq2TeBII72 4an73CWq5azueYK0VlXnrJCYFA8h8rCPB32c5UMNMWxvD6wtBgJCOsYnjT6dT5uuoJuP S+N2tviqfuTLFAvbOFbNeqRLMLj24EY1i2QcLP9mx7xgOF09qb1ejeuiPS9BHJz2Upsw mkYLeAA9S1NY9OAhP1s6fIpX2XShEtUHu2FOyMWT1jKoaSmbcYn/Ez1rxax41rhcL5pb B1AA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744375677; x=1744980477; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=0CLKStleFsDlucFcVBypNI53bNGF4KiYAU5jyo/fWc0=; b=Ule4t/G+P3dFlzIdFRbtjW1cPlavd2c0CMkMW3XKmQ1ggbuDtOJsrFqwYPBCYpsQFp fRHKftpcccBPE/5XacP1NPSxuCuTajzaSsrAbQ9Wc+Z6hietQiEgE+Ash3ehjCviWvTp z9hDYO/wL9JWuyxWYLCSxmriuCyC2lbVSlx8mjq/lCFIk0RYKgnR6tismqWWcaPZccQG a2sP8v6XReOhw0TQM2jmb18J7cw2RjIk8cwb3q5xRe9dNNM2YRZKSCB6rK+B+nflUPHx AWK4lvoP6SsnndamJoIcJgbQ84+jh4kbpweFvtMSSi5wdgUZ0uw8GuWFCmXj0p3Z9YbB uBkQ== X-Gm-Message-State: AOJu0Yxj5SpWy84Bgr5rFw0e41fJApAUTM2skIcxsu2d340f46fMf0Yl FnQofchBaKZ6i5Orm+57gbKTR2lVypqi9wl/jvd+ODeHmxbT1ZxWWDzqiIUFjy0= X-Gm-Gg: ASbGncuRKzSsoH49CSKCLnliRzfBFKvr8cg3r4y9HyAJDlAQTvFRCiGhQZgDp7kzdv8 mUD9xWsc2uStOaYDpDvcDtOvQCscjoYx6p2I9egvwwtGQwH1e92qAD48J2VfVq3jvu1RuJbtPAm OppYdL3R5gu3LUlcUArz3Sj0un7ENhucbovuXxT6lkKnqHqpB5o72UkyugU6oXDXYyOa6SROjsr MrKc+bhDcm1HaBtSJTlPpWlvM4wHCx9ITTOylP+WsLuGBF1JLFO24JjQgs3ETymRxIV5HvupVQu 7cnhmvRu3ih6riRZSL0O2Rnv3vsL3ZUiXv9HDKxz6u3sboJS8pO6C4aILIM4ptkqfmUnIT7VKa2 Ar0pTIuYb8wNrfESQMg== X-Received: by 2002:a5d:5c84:0:b0:39d:724f:a8ae with SMTP id ffacd0b85a97d-39ea5217203mr2103852f8f.33.1744375677572; Fri, 11 Apr 2025 05:47:57 -0700 (PDT) Received: from toyger.tail248178.ts.net (35-60-142-46.pool.kielnet.net. [46.142.60.35]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-43f206264a1sm88299695e9.9.2025.04.11.05.47.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 11 Apr 2025 05:47:56 -0700 (PDT) From: Caleb Connolly Date: Fri, 11 Apr 2025 14:47:42 +0200 Subject: [PATCH v2 5/8] mach-snapdragon: of_fixup: update comment MIME-Version: 1.0 Message-Id: <20250411-livetree-fixup-v2-5-1236823377bb@linaro.org> References: <20250411-livetree-fixup-v2-0-1236823377bb@linaro.org> In-Reply-To: <20250411-livetree-fixup-v2-0-1236823377bb@linaro.org> To: Simon Glass , Tom Rini , Caleb Connolly , Neil Armstrong , Sumit Garg , Lukasz Majewski , Sean Anderson Cc: u-boot@lists.denx.de, u-boot-qcom@groups.io X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=1060; i=caleb.connolly@linaro.org; h=from:subject:message-id; bh=ROoqDoPJ5ix1nRKD+zCXBiwhwz7iX1neYdedBALqDdE=; b=owEBbQKS/ZANAwAKAQWDMSsZX2S2AcsmYgBn+Q90qLNah/t8W9n7fmmCrEldLsdNm/Gn8K3Vk h+mnCc1V+yJAjMEAAEKAB0WIQS2UaFGPGq+0GkMVc0FgzErGV9ktgUCZ/kPdAAKCRAFgzErGV9k tpzVEACPrN0RTuxEjJ+Uq1AABodg0x+Zr8U3q8WR0DW2bWxgog2xP3OQLCoZ6CwYepc5YFvYaZN JjMATg3WZwtBLKSRPTdJ5y7KtniByK0UcFtZ/2zRbkrZ9Ty/SPO0WuzVeJBCEPanWimV+5bpqg0 VgWmxJXzJdgDF3dWU58HM/dQHm9XPom/ajyloJ5DS2OAWo81h58y5iyTgF7xiBBzdqmIMKnLpL6 R38H82G/gxR0XT09pFmJjWgrkndAuYSbbK3ktUVXZt20CX20g6uueVnmg/S7y9RlKrLhM0ynBmk 867doJwDKCptMF/joTDb137TmF750kVOmht22jDbFDb5WKlY4vQeluWC2IGdFMx6EzHU1I1v9aH jOkGWjvJV9rn1jPpFfJ2yILMKkUidCFIvfgTJ9aaJrWapjCAN4SXlIvcuCIhtcLjaDLgDKYZOvK VKN+YwK7gNr+RGAav7MlEN1h2d3GBeh5VcvqVdRRPDMo4SllDIF98lkXVpEvwdGDz8JxwBenNgm TIgwNK4anOiWA5T3wzwTqi5m4StHfbHbK8sUX9DeWpneo69+47AZEQMA7MvPoL6rmBw17lvTicf rhBeUUS+JNzJyApDsXd1xBaGsyY/rt8Ze2c6WeOLmiPqL7s2NgJ51xWu6/m2xWzU83UKwlHfHc3 5JqDrA31cvRtTFQ== X-Developer-Key: i=caleb.connolly@linaro.org; a=openpgp; fpr=83B24DA7FE145076BC38BB250CD904EB673A7C47 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean we don't rewrite the volume buttons any more. Signed-off-by: Caleb Connolly Reviewed-by: Neil Armstrong --- arch/arm/mach-snapdragon/of_fixup.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/arch/arm/mach-snapdragon/of_fixup.c b/arch/arm/mach-snapdragon/of_fixup.c index a5515c02d3de05944dfb7c1b2a5542631b517497..10053e48d88017d2179c96f2f3724c4d5dc4f3e2 100644 --- a/arch/arm/mach-snapdragon/of_fixup.c +++ b/arch/arm/mach-snapdragon/of_fixup.c @@ -3,10 +3,9 @@ * OF_LIVE devicetree fixup. * * This file implements runtime fixups for Qualcomm DT to improve * compatibility with U-Boot. This includes adjusting the USB nodes - * to only use USB high-speed, as well as remapping volume buttons - * to behave as up/down for navigating U-Boot. + * to only use USB high-speed. * * We use OF_LIVE for this rather than early FDT fixup for a couple * of reasons: it has a much nicer API, is most likely more efficient, * and our changes are only applied to U-Boot. This allows us to use a From patchwork Fri Apr 11 12:47:43 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Caleb Connolly X-Patchwork-Id: 880159 Delivered-To: patch@linaro.org Received: by 2002:a5d:4882:0:b0:38f:210b:807b with SMTP id g2csp741645wrq; Fri, 11 Apr 2025 05:48:57 -0700 (PDT) X-Forwarded-Encrypted: i=2; AJvYcCV4e0unLvn0MWv0pUmhhpyKTp7lhe5OKExSO7RpmQmeE+AlfY4p8CShuB4BYx8K22MRWDTVYQ==@linaro.org X-Google-Smtp-Source: AGHT+IGHmZLO2MgoEx2WRuhlI5hH6rtspzB53kD6rIE7gNPmHioeK93ngTWwEOd6WWYz6a4z9nSK X-Received: by 2002:a5d:6daa:0:b0:39c:dfa:d347 with SMTP id ffacd0b85a97d-39ea51f4467mr2314297f8f.2.1744375737451; Fri, 11 Apr 2025 05:48:57 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1744375737; cv=none; d=google.com; s=arc-20240605; b=bDqh26rUsRsrtWpNi4HSM7mTGIaUlJbo7JK3CU25Et6bi3vfc/AVoF1Xnnpg7tBvV5 9iHZFK/GSeYwtNtoAbzi7FjMgtEQl/DIYdtUSHQ2zhGhLT7xpFyBQLO/sco62K9NLCHB Yb7QmriwaHlYBl6duVkH4LMclnmKR2EBb7r3tAEU2xfqrl2QidNXqN4QeAqFnC2HJ0Uc VDWk1oaUyjHi28kCqp2rXWdYy6qasmgruF5KshRsi97WB3N9QRghFU/pqiMhSq/s6o57 XJxazgR6a8D0D9As/StdawS3CCxo13YeME9KYPMagEFZ2JIdX+1rjhUFXUb3a0rvhorr q+hQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:cc:to:in-reply-to:references :message-id:content-transfer-encoding:mime-version:subject:date:from :dkim-signature; bh=5VjAeINkyUoI8mMB8Rlc0rmVL7A0HFm/7qiHBgQUubg=; fh=qsEHxPwz7gvfHbf5sHcp5q1hoWpcZW3L+7PGTkgsjPU=; b=V65xWhg7BN+oU8bps78Y3pw7opzCImnoT5qe8aWW25N/FNAN04BVR282j31yL1BLdO 7BBJEuJPZjkXGQwYE81hYDcpDeRT4+OCOW0Ai7vyA4nIHLh4lMQTmPbzt9mYIZnbfmzu zQ/jTIV3vuifQ39D9RwqEovLv/qxQofyGB5/67HdqY0GfH38fZxFwHw8Ny2GwcUNgPJP U1bzVGTL5TPXXipDgzgtGXSTGDxCPso+uwpGiZYCTmmgC8E01tqs8RLfFd+FpoxP6nmT V8mpOHmo+rYFy/VXmZnKniVyIYQ4AkEki8Pt21M+WkoR6jHuXwPPJdTJ27VOPkbz4biP /jpA==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=RxZ9wwhu; spf=pass (google.com: domain of u-boot-bounces@lists.denx.de designates 2a01:238:438b:c500:173d:9f52:ddab:ee01 as permitted sender) smtp.mailfrom=u-boot-bounces@lists.denx.de; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org; dara=neutral header.i=@linaro.org Return-Path: Received: from phobos.denx.de (phobos.denx.de. [2a01:238:438b:c500:173d:9f52:ddab:ee01]) by mx.google.com with ESMTPS id 5b1f17b1804b1-43f20667d47si44464525e9.50.2025.04.11.05.48.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 11 Apr 2025 05:48:57 -0700 (PDT) Received-SPF: pass (google.com: domain of u-boot-bounces@lists.denx.de designates 2a01:238:438b:c500:173d:9f52:ddab:ee01 as permitted sender) client-ip=2a01:238:438b:c500:173d:9f52:ddab:ee01; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=RxZ9wwhu; spf=pass (google.com: domain of u-boot-bounces@lists.denx.de designates 2a01:238:438b:c500:173d:9f52:ddab:ee01 as permitted sender) smtp.mailfrom=u-boot-bounces@lists.denx.de; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org; dara=neutral header.i=@linaro.org Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id CC33383FFC; Fri, 11 Apr 2025 14:48:03 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.b="RxZ9wwhu"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 573C984005; Fri, 11 Apr 2025 14:48:02 +0200 (CEST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de X-Spam-Level: X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_BLOCKED, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.2 Received: from mail-wm1-x32a.google.com (mail-wm1-x32a.google.com [IPv6:2a00:1450:4864:20::32a]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 941EC83FF0 for ; Fri, 11 Apr 2025 14:47:59 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=caleb.connolly@linaro.org Received: by mail-wm1-x32a.google.com with SMTP id 5b1f17b1804b1-43cfba466b2so19745815e9.3 for ; Fri, 11 Apr 2025 05:47:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1744375679; x=1744980479; darn=lists.denx.de; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=5VjAeINkyUoI8mMB8Rlc0rmVL7A0HFm/7qiHBgQUubg=; b=RxZ9wwhuN0vgQymM5ZBaheGMuyxmEt5DQDk2TtXFP9I/vKax998r7ZgzVteK5TqBmv IW5mE6sYQM5xmejBij15JcS97s6oEChp/znX7Y+oDIjSRGDgXBVnX4IzgirUTIgp02Kz RfKJBNSDComNfdq+dene15tK2g2i3lRTeedT13kFwwsjv0YAj8epFyTzl+PYYDLMwNsl RUqy+sd6GjUzShy61jFopuLBVKO0+/9l+vmWw9gRW16eREUgz9Lt+WUbXeDm1HRMJPVU 5eZOkqj5MSS/jqH8LHRqFvhdYJocx24WOAYsEQg3Nh05FmKGggbI+4eA8iSXWdHyLCm6 IXMg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744375679; x=1744980479; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=5VjAeINkyUoI8mMB8Rlc0rmVL7A0HFm/7qiHBgQUubg=; b=xK22r3X8uBbwotpjWqgzRgHo/HG0+OQQ2EHgb5RTFSy3RnTN+2DHyn1AiuilX0P8wW /vkg3ZG/C/7bAlTJOSAPCe6oydbpl1sY7AGppfz/aFNhGItlfgY7wgYT8ELegBbRmcAg cpEFWqgL0DFJK2gkQVOKuKmggdo1AePMfh2HZ6GhKPruhYSpvYbNeOV7fZdtuFS1nM1z bLdZFMOU7pRRDdRZECDGw0n1Jc0BeHjHh180tVNhS2PpFLWWK6T1SZeBXt0Da+6MWwDY 5tmQvEzvQD6d3/T6HmPjTA2/rtMkHIkFyX2ml0uGaEQ9/Z/LARCWJLthOuqZ1dWUL+l9 s3Ww== X-Gm-Message-State: AOJu0Yx3/FRO34s+vLJ0+5AB9TlmWrqEW9JSIG2ZrPAh67Vny3G0G8Id 6Cji+WnIHeWqDEiEci76ngixyYYb7qPOHJniuOL7E8szmYpNZNrVQ/UPcfg6Dkc= X-Gm-Gg: ASbGncvU9NxL3vRQaen/sQf1Xbvgk70ZHIjFtMhu+4x/X+vxeP7sgZJQ9mKCxtCv6QG f/j2ZbsotP4nYt5bI7uCdEw1UT6fwF8mNGc7o2JtJhz1lFGQdk9IQpP345QYPpLKe3CAtErEsvK nFEimrYt80NwsP0J0+kdnmJmEcbKO+L3//ZpK0RZBOozKHtHx3WPpFvFELqXfN2ICwGdd0mXNyk yxXR3HmDRZCEKJ7tRyRQs3gJdJ5I2qypouL/In8cSMtgWSfFt+aXdztlAD5M/LoFTRyQPa0SKI0 a0VyI4KHlO9E/lkZBPS+4EMf5QsArOIaR/QtFYsfY9j4ltWyNzzifOnDpIqxxxZX6sll0tzXZVr Izt1w5XDC6kZhhSYJilTfbEB0j0qR X-Received: by 2002:a05:600c:8709:b0:43d:45a:8fc1 with SMTP id 5b1f17b1804b1-43f3a925e0amr25853195e9.4.1744375679036; Fri, 11 Apr 2025 05:47:59 -0700 (PDT) Received: from toyger.tail248178.ts.net (35-60-142-46.pool.kielnet.net. [46.142.60.35]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-43f206264a1sm88299695e9.9.2025.04.11.05.47.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 11 Apr 2025 05:47:58 -0700 (PDT) From: Caleb Connolly Date: Fri, 11 Apr 2025 14:47:43 +0200 Subject: [PATCH v2 6/8] mach-snapdragon: of_fixup: set dr_mode for RB1/2 boards MIME-Version: 1.0 Message-Id: <20250411-livetree-fixup-v2-6-1236823377bb@linaro.org> References: <20250411-livetree-fixup-v2-0-1236823377bb@linaro.org> In-Reply-To: <20250411-livetree-fixup-v2-0-1236823377bb@linaro.org> To: Simon Glass , Tom Rini , Caleb Connolly , Neil Armstrong , Sumit Garg , Lukasz Majewski , Sean Anderson Cc: u-boot@lists.denx.de, u-boot-qcom@groups.io, Sumit Garg X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=3162; i=caleb.connolly@linaro.org; h=from:subject:message-id; bh=uEd2ub++HG9dCbEmtDV+nXaF06/lbpP1gSd8mpDqjSU=; b=owEBbQKS/ZANAwAKAQWDMSsZX2S2AcsmYgBn+Q906inti+h5F8lw8SclZj+7uir16M/NGGwGd e6h02abeHmJAjMEAAEKAB0WIQS2UaFGPGq+0GkMVc0FgzErGV9ktgUCZ/kPdAAKCRAFgzErGV9k thepD/48ffM7q7KvKuoQlQJJdjcmFrcA2hDFrkQv3XQN5epxfHxAzcShLm9t8W9swauImJs/gQ9 vraU/qGDBGDin3Ta7W4Be7xT0d70LuQDF0gqCdavwp9CKx2PQe6vN4+ZWLrrGthY5+4YXkTu4DA I6qTlisIEZaNBt6+y8Q1qGz4cZKrafT0jUeLvRNR38BYU/zcdJIl2hifANwWuuZST867LUKZNDm yy15LhZUZsYO/SgMBSUU2qNUVT+s2kjrgO5M+a0mMIdcbYJy8bc3klmf1B+KTnLu2cJHuF3pHeN rn330wwhL2wvV3Lz7Fa3qhxKWv2IAO2a6U7MMhq3jreeG4bCuWTAEF0qh4ia3zSeS6n0x+7PC5f 5KSv35krOo2dVSXFR5MeGa6ZvDDHyvplJRjJli601/BrYVtvjkri+uwhZoqArpX7P3A3ri/spDU I9OWX8jlyjXNCHyPDx0ozQxlDpjGlHIJOQSYV0nPRpwV1sLvk4E4Vl02KjuFpMsoj0ViuE/6DOe 51JvvcZYBACMhs3c5D8qX16f/aFCtBzSH96lqun6E9p7tMQTZX5D64n6+aF+H9MECifzSabYICk nuD0grT84SNJRQvfK4XEHETT8IO9MfE2Mj/GtgnWsFby5ZKoaAACYn/Z1wq/lDq+9DuYJAK7VQ1 /72TJSfG2sYwcWQ== X-Developer-Key: i=caleb.connolly@linaro.org; a=openpgp; fpr=83B24DA7FE145076BC38BB250CD904EB673A7C47 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean The RB1 and RB2 have a single USB controller which is manually muxed between a type-c port and an internal USB hub via a DIP switch. OTG is supported in Linux, but the DWC3 driver in U-Boot can only handle a single mode, and defaults to peripheral mode. We did hack around this on the RB2, but the RB1 got left out. Now that we can fix up the live tree before devices are bound, drop the DTS hacks and do the fixup at runtime instead. Reviewed-by: Sumit Garg Reviewed-by: Neil Armstrong Tested-by: Sumit Garg Signed-off-by: Caleb Connolly --- arch/arm/dts/qrb4210-rb2-u-boot.dtsi | 6 ------ arch/arm/mach-snapdragon/of_fixup.c | 28 ++++++++++++++-------------- 2 files changed, 14 insertions(+), 20 deletions(-) diff --git a/arch/arm/dts/qrb4210-rb2-u-boot.dtsi b/arch/arm/dts/qrb4210-rb2-u-boot.dtsi deleted file mode 100644 index 7d1375f38c44d7bd54c022fa3d390f666a35d6ee..0000000000000000000000000000000000000000 --- a/arch/arm/dts/qrb4210-rb2-u-boot.dtsi +++ /dev/null @@ -1,6 +0,0 @@ -// SPDX-License-Identifier: GPL-2.0 - -/* This is usually OTG but U-Boot doesn't support that properly */ -&usb_dwc3 { - dr_mode = "host"; -}; diff --git a/arch/arm/mach-snapdragon/of_fixup.c b/arch/arm/mach-snapdragon/of_fixup.c index 10053e48d88017d2179c96f2f3724c4d5dc4f3e2..b398c6b7b9fdaddc03324921e6b955919f9c7675 100644 --- a/arch/arm/mach-snapdragon/of_fixup.c +++ b/arch/arm/mach-snapdragon/of_fixup.c @@ -98,8 +98,21 @@ static int fixup_qcom_dwc3(struct device_node *root, struct device_node *glue_np log_err("Failed to set 'maximum-speed' property: %d\n", ret); return ret; } + /* + * The RB1/2 boards only have a single USB controller and it's muxed between the type-C port + * and a USB hub. Since we can't do OTG in U-Boot properly we prefer to put it into host mode. + */ + if (of_device_is_compatible(root, "qcom,qrb4210-rb2", NULL, NULL) || + of_device_is_compatible(root, "qcom,qrb2210-rb1", NULL, NULL)) { + ret = of_write_prop(dwc3, "dr_mode", sizeof("host"), "host"); + if (ret) { + log_err("Failed to set 'dr_mode' property: %d\n", ret); + return ret; + } + } + return 0; } static void fixup_usb_nodes(struct device_node *root) @@ -164,21 +177,8 @@ static int qcom_of_fixup_nodes(void * __maybe_unused ctx, struct event *event) } EVENT_SPY_FULL(EVT_OF_LIVE_BUILT, qcom_of_fixup_nodes); -int ft_board_setup(void *blob, struct bd_info __maybe_unused *bd) +int ft_board_setup(void __maybe_unused *blob, struct bd_info __maybe_unused *bd) { - struct fdt_header *fdt = blob; - int node; - - /* On RB1/2 we need to fix-up the dr_mode */ - if (!fdt_node_check_compatible(fdt, 0, "qcom,qrb4210-rb2") || - !fdt_node_check_compatible(fdt, 0, "qcom,qrb2210-rb1")) { - fdt_for_each_node_by_compatible(node, blob, 0, "snps,dwc3") { - log_debug("%s: Setting 'dr_mode' to OTG\n", fdt_get_name(blob, node, NULL)); - fdt_setprop_string(fdt, node, "dr_mode", "otg"); - break; - } - } - return 0; } From patchwork Fri Apr 11 12:47:44 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Caleb Connolly X-Patchwork-Id: 880160 Delivered-To: patch@linaro.org Received: by 2002:a5d:4882:0:b0:38f:210b:807b with SMTP id g2csp741683wrq; Fri, 11 Apr 2025 05:49:06 -0700 (PDT) X-Forwarded-Encrypted: i=2; AJvYcCV20kx/MFLtWzkeChaliIbmIZsXNxBjF6jELWfgpcld3n3qKCp077cy0hJ+xH75xAL3lJwc2A==@linaro.org X-Google-Smtp-Source: AGHT+IEwhoDcxFYgSNJ96mDsp0uBLd7uIklf37xm/iv0KPDfIpTUcwASS91mbTgOjLbUlwZiil/h X-Received: by 2002:a05:6000:40d9:b0:39c:16a0:fee4 with SMTP id ffacd0b85a97d-39ea52133cbmr2392752f8f.27.1744375745814; Fri, 11 Apr 2025 05:49:05 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1744375745; cv=none; d=google.com; s=arc-20240605; b=ZoFnxI9eZW+d5nwag3Z+CDpaZzXU+w5FRzfM3Fdk9XtD0/0dXdBVJcMw9xKlL8QnLn 316VW0q/eDCZh5ffdw7rr9UOt6peaySJKWHjQJSHqOWCwwLKMsl0bv4CGy1XP4Sf+81s o+mmCpaf2u6TLgedpCoGiDz0LFX8E1a/xJF0X73/HoXp5zz+YRi60qougnLU2AL8/pRd FWCu7jWjuZI9b8yJHy0VzE/OmAyZIn+w8aA81IME86lPPaA1MpuAp0RTa5QpDn0MJFod gvdGQPbjW+955/hyRgnhhUm5I+y4IVOCkK+EhD14fiqoHdMQzfY2oE+lxU47ZHm+7tET ynCQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:cc:to:in-reply-to:references :message-id:content-transfer-encoding:mime-version:subject:date:from :dkim-signature; bh=+4Mzv1xKB9J/KHmbbrhduwbxjjdxt+NIIKcEUnNZcu4=; fh=qsEHxPwz7gvfHbf5sHcp5q1hoWpcZW3L+7PGTkgsjPU=; b=crsHb7qKXuemjapZ+dop/r1UukvS3Qc/9GHgNO04RXGJJSBWIuMDJpQD9sNoamX5cA 6N68aeMJQdWxmNNvYMskEg+eNj/S/nLyFAy8Jna2s/W1d+gjQ34RuKo3UNd9cBr1rROE g9zWfEuCD+6w4Tk4tHEvIDhX7dS32860stSI2wT8weDCbHJjYgLXkv4dstmTMcSP5EpB 8+MaAbRHYRa4r25PNMTP5g6Tyg5tZgXYYn+QrP3HICryyGradOw53Jyp/2JgzzO5nuhF wujxKJMkyE+2c+SqE/W/6BGlXkLHjwMdZtjeWULfqyBYeX+rvazq3LDBSKrBvMDM2su3 /zeg==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=UVjtUCeL; spf=pass (google.com: domain of u-boot-bounces@lists.denx.de designates 2a01:238:438b:c500:173d:9f52:ddab:ee01 as permitted sender) smtp.mailfrom=u-boot-bounces@lists.denx.de; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org; dara=neutral header.i=@linaro.org Return-Path: Received: from phobos.denx.de (phobos.denx.de. [2a01:238:438b:c500:173d:9f52:ddab:ee01]) by mx.google.com with ESMTPS id ffacd0b85a97d-39eaf43e31csi963151f8f.639.2025.04.11.05.49.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 11 Apr 2025 05:49:05 -0700 (PDT) Received-SPF: pass (google.com: domain of u-boot-bounces@lists.denx.de designates 2a01:238:438b:c500:173d:9f52:ddab:ee01 as permitted sender) client-ip=2a01:238:438b:c500:173d:9f52:ddab:ee01; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=UVjtUCeL; spf=pass (google.com: domain of u-boot-bounces@lists.denx.de designates 2a01:238:438b:c500:173d:9f52:ddab:ee01 as permitted sender) smtp.mailfrom=u-boot-bounces@lists.denx.de; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org; dara=neutral header.i=@linaro.org Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 1C3DC83FDE; Fri, 11 Apr 2025 14:48:06 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.b="UVjtUCeL"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 7040782B72; Fri, 11 Apr 2025 14:48:03 +0200 (CEST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de X-Spam-Level: X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_BLOCKED, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.2 Received: from mail-wm1-x336.google.com (mail-wm1-x336.google.com [IPv6:2a00:1450:4864:20::336]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id EE7F48400F for ; Fri, 11 Apr 2025 14:48:00 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=caleb.connolly@linaro.org Received: by mail-wm1-x336.google.com with SMTP id 5b1f17b1804b1-43d0618746bso14746385e9.2 for ; Fri, 11 Apr 2025 05:48:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1744375680; x=1744980480; darn=lists.denx.de; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=+4Mzv1xKB9J/KHmbbrhduwbxjjdxt+NIIKcEUnNZcu4=; b=UVjtUCeLpg4ynYg2kZF9wTlR7WLOsQtRiYynKmf4Zd6G2DpwBaMZUkAwjIodFN7P73 +0ac0YRidsIxoVY9eeWRvugwnlFLHYyWoUdy4159wgXsLcwXZ5h9ns48v8ugpeD9lHZt xFnR5WEINnoByXm4qZYzNh1iDn8muI0A8lHUi6/yvJyauP6NBWJv8ruQwgnsYSt79LFn ZbNUkOPSxRTPB457p4vbH1P/mSc60UIiYq5H6DSbpU0hTLVYGS15NJrNzQwod5mohpUk bHwKDO1LBq+08bnqslnk6d4m4gLeHBRM5eHSmZI4Uyrcysr6vDeIQ3EzOtAlKeZHPTAE gR+w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744375680; x=1744980480; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=+4Mzv1xKB9J/KHmbbrhduwbxjjdxt+NIIKcEUnNZcu4=; b=C1DX6bMvuJkpvQ8kDUHKYk62fV9iVHY1cerqrtMrQV1JrKpQzBjAiAbkyY6u0dmZQ8 7DPtkZxZNL+OskRnWl8dEhbBSAdoW2YnnUR2mIOWxzJeRbOx/DiuHkwaVoqxyqdWC0Yi sn73mMZ7cp1+HnwuIhIIelqQ4HqD9J1PBVVD29xDonlWGc/587Sbx3z3G/RBd9q2rH8m bP5QTerzgLasUCSDfqb2PrhTji77BX7D5D+DkeBMMI7Mb6dMCG+PeH9hYNYVSNREVXmE /7jlFK0LMUNM8e4cgsTQQ80QAWI0TvX3BUi5Y1LZXIvFJ7s/2AbZCSR109DVmyULotqY RUgQ== X-Gm-Message-State: AOJu0Yyhd4ISfMga0qcuy4/+MAMAlWHbbsf+uDBJeXrBiSbAvFxdSJSQ 4v4Wc+gXqaLuRqLVgjk8JtcLxp4ZNabov6dRAuUVuFyJmD8JXQjb/FGH9wbzNS8= X-Gm-Gg: ASbGncsQs28r4VxWLL/CoOiq1myQjZjXLsdHGKhF9QgT8Kk3cRrzFY3eyLzn2ZEBStC 4EEcLlP0jAukYfwZx/I8UzohvaGNDTKscvXt/+31QGtkE8qbl53kHIPBlGhucOyJsNcgnStIWcx S1HsJXciJUsFkiDFWm+xwHTRy5gVl6iiKvzlVzht8nFWynRabvhDVBFtmyvQmbW0bSFqY9YJIia QJSZuUZc/rTsox/ogItCQNmqyn95DLEPLx0y1pvF5bLg70bjchI7qpdGE6mRjV0fXI32Q7Mj5ea PD0RjqIg6xsjpTWo9/d5ys6PDmhcsh8kScBrNFX0UmM9mRCJ8phk95nJ3n9tU6hhlt5KNwseRFu YgDYflrEfp2bVW1Yt/Q== X-Received: by 2002:a05:600c:35cf:b0:43c:fd27:a216 with SMTP id 5b1f17b1804b1-43f3a9ab0f2mr17268295e9.23.1744375680477; Fri, 11 Apr 2025 05:48:00 -0700 (PDT) Received: from toyger.tail248178.ts.net (35-60-142-46.pool.kielnet.net. [46.142.60.35]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-43f206264a1sm88299695e9.9.2025.04.11.05.47.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 11 Apr 2025 05:47:59 -0700 (PDT) From: Caleb Connolly Date: Fri, 11 Apr 2025 14:47:44 +0200 Subject: [PATCH v2 7/8] clk/qcom: qcm2290: show clock name in set_rate() MIME-Version: 1.0 Message-Id: <20250411-livetree-fixup-v2-7-1236823377bb@linaro.org> References: <20250411-livetree-fixup-v2-0-1236823377bb@linaro.org> In-Reply-To: <20250411-livetree-fixup-v2-0-1236823377bb@linaro.org> To: Simon Glass , Tom Rini , Caleb Connolly , Neil Armstrong , Sumit Garg , Lukasz Majewski , Sean Anderson Cc: u-boot@lists.denx.de, u-boot-qcom@groups.io, Sumit Garg X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=1104; i=caleb.connolly@linaro.org; h=from:subject:message-id; bh=uOUNRhMRcPwqnuVm45bRX4aWzjuSI+N3wVTsv9rak1U=; b=owEBbQKS/ZANAwAKAQWDMSsZX2S2AcsmYgBn+Q90qWWbHD9GHDQH7Sr+AwUfAAckousrFnomY vzpNnXcA8yJAjMEAAEKAB0WIQS2UaFGPGq+0GkMVc0FgzErGV9ktgUCZ/kPdAAKCRAFgzErGV9k tsWWD/4mJ1kB+1tTTzKpcihHALMmT7PTXccwvjiGdBHeadmodElXR0Jm0BgsH0NOssa/ANkbbya XodJh/NxFme6ETGkIT9zEOuqXl+AmmAZeeqfomBGgjMQR0Ie2aaHRUaZ7qvIk/jDN510SO7c2In pYkzNFKc1eytTj0I4hVp8pIQqoKXcBoyNI+FbkjqshmlDmP3OLgRKWIp4MC5Pk+VYy+CYZJr3/T nV62BgH6IZTHDYVJsq6kfR3nupQgeA1UfWmL1waY3hsPceKQtir0DE6rT/4iBA3G3DZzehIy3FK rUkRdR0jjdn+OHKxXN+rrRgMw2Xwcc4mIg0L90Fop5NWV3k3Gyol5VMCBKJBGL4E2QT8le54adf zwSH1u55C3eADndqxpe2XCEwhKdtzOdE5KJPSy9gBHjtJ5lR3kp/xkfvlm4QMtC43hr3YuUk967 ObIE9ggYPhfMqh+HzMLQvRXBCH4G39oBoZXpktT8y5ZfNt/VsVsDeUnyEdRWgcVhfGzHmhs36Nb boqJ+wBIIMsL499Q0yzRdVKYRZRx5+h2OsUux6DrNYWINLaVbIRqu66YJwh67AFBtQaZi0yyl2R ZsgfoYsgHNoxT7WPQeT8mAuQ27tEhxwAivQI9p6A2F30rPBMhW8pysEGfm6M0k/K0S9M7J9RicN aoPdGjdllt4zf4Q== X-Developer-Key: i=caleb.connolly@linaro.org; a=openpgp; fpr=83B24DA7FE145076BC38BB250CD904EB673A7C47 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean The device name is always clk_qcom... Not very useful. Reviewed-by: Sumit Garg Reviewed-by: Neil Armstrong Tested-by: Sumit Garg Signed-off-by: Caleb Connolly --- drivers/clk/qcom/clock-qcm2290.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/clk/qcom/clock-qcm2290.c b/drivers/clk/qcom/clock-qcm2290.c index 1326b770c3ebd723120de4b6657aafac726023d6..fad104fb91aec8917de66b63dd546926c8856011 100644 --- a/drivers/clk/qcom/clock-qcm2290.c +++ b/drivers/clk/qcom/clock-qcm2290.c @@ -87,9 +87,9 @@ static ulong qcm2290_set_rate(struct clk *clk, ulong rate) { struct msm_clk_priv *priv = dev_get_priv(clk->dev); const struct freq_tbl *freq; - debug("%s: clk %s rate %lu\n", __func__, clk->dev->name, rate); + debug("%s: clk %s rate %lu\n", __func__, qcm2290_clks[clk->id].name, rate); switch (clk->id) { case GCC_QUPV3_WRAP0_S4_CLK: /*UART2*/ freq = qcom_find_freq(ftbl_gcc_qupv3_wrap0_s0_clk_src, rate); From patchwork Fri Apr 11 12:47:45 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Caleb Connolly X-Patchwork-Id: 880161 Delivered-To: patch@linaro.org Received: by 2002:a5d:4882:0:b0:38f:210b:807b with SMTP id g2csp741729wrq; Fri, 11 Apr 2025 05:49:14 -0700 (PDT) X-Forwarded-Encrypted: i=2; AJvYcCUY37LyOKa2WSYd1avDatTv255KCaOISaB+Woqngv8/Cn3ucs+X+y7eGRwKl2BaC+jn5tL2jg==@linaro.org X-Google-Smtp-Source: AGHT+IGUkMxt+uSQgP8a+5QW/iFAmyckCyxyIbwoCctLeMmDgw4ARIJj7360p0DQ45RrdKunHgeM X-Received: by 2002:a05:6000:18ac:b0:39c:142d:c0a with SMTP id ffacd0b85a97d-39ea52037f9mr2012288f8f.19.1744375753844; Fri, 11 Apr 2025 05:49:13 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1744375753; cv=none; d=google.com; s=arc-20240605; b=dmoG0EpYl5oe3ss7O2Iy2LQOzI2ilv4uA768SyUxo9T2JHLWISPXrnZVfMExQvc1ak Vgs8KwEaXQzs0zIURS4iVMZnSm0ICpe2OENDpbvwvfSBs8F70ez8SyGwn1cJd/NnspRe QJsD7pklZ9M7mhA7NYD5Uit1XwVs2cFoo1aBoJsS27RSQRAZ+sLec7zNvDjM5hI6FBMV U3h0sBozTL2U0a9OSJ+SPpCADSn/K/Pty3WuhO/ABbei7kccgUlM4/Qhi0xzbwLJDVfB ZH6g8F4m1ps75oT0RneUzgBAmEOWL73zfmcpoNdURuJoGPoVFzvWHiXhAK6IMxLWrd+3 8huQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:cc:to:in-reply-to:references :message-id:content-transfer-encoding:mime-version:subject:date:from :dkim-signature; bh=Vg4/vprd2sdTaChI4TunLLuWjsE1j/v1KJyQRDTO2tg=; fh=qsEHxPwz7gvfHbf5sHcp5q1hoWpcZW3L+7PGTkgsjPU=; b=JOXmm5+ZN252zzwhZWRM3H2jMyN1jg0ObjbTTqa051Gw7btXHtUDyUc2InjsXm3TSQ Vdu1dcCHVqlw1YgfrcG+MYGFwAYPCzMdFCohBosm0zntjsqpEFTXWP3WrdMdy4uI2wyf DAvGYdtNB0QHwp/OdtsAEZpd7OIPi/wEQFZnli5rGAnZL3hHfnz4id6u6pjxiVyEmBeA Utd0PFnne3UyyhgsHY6mUaqLemuU3yG6kLsPUWRv7U9zvUj/okjiwNt3lu0rhcBi5x7y NnoFSiV0iZBuc5qxcURf704+pPGE3NTVlpxrgaVeb40TcpAII3N9y8olCIZo2NuIeRLz jj5Q==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b="rgX/FDuV"; spf=pass (google.com: domain of u-boot-bounces@lists.denx.de designates 2a01:238:438b:c500:173d:9f52:ddab:ee01 as permitted sender) smtp.mailfrom=u-boot-bounces@lists.denx.de; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org; dara=neutral header.i=@linaro.org Return-Path: Received: from phobos.denx.de (phobos.denx.de. [2a01:238:438b:c500:173d:9f52:ddab:ee01]) by mx.google.com with ESMTPS id ffacd0b85a97d-39eae95fd7csi929817f8f.105.2025.04.11.05.49.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 11 Apr 2025 05:49:13 -0700 (PDT) Received-SPF: pass (google.com: domain of u-boot-bounces@lists.denx.de designates 2a01:238:438b:c500:173d:9f52:ddab:ee01 as permitted sender) client-ip=2a01:238:438b:c500:173d:9f52:ddab:ee01; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b="rgX/FDuV"; spf=pass (google.com: domain of u-boot-bounces@lists.denx.de designates 2a01:238:438b:c500:173d:9f52:ddab:ee01 as permitted sender) smtp.mailfrom=u-boot-bounces@lists.denx.de; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org; dara=neutral header.i=@linaro.org Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 5E0DB84002; Fri, 11 Apr 2025 14:48:06 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.b="rgX/FDuV"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 72B8584002; Fri, 11 Apr 2025 14:48:04 +0200 (CEST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de X-Spam-Level: X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_BLOCKED, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.2 Received: from mail-wr1-x434.google.com (mail-wr1-x434.google.com [IPv6:2a00:1450:4864:20::434]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 7581683FF4 for ; Fri, 11 Apr 2025 14:48:02 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=caleb.connolly@linaro.org Received: by mail-wr1-x434.google.com with SMTP id ffacd0b85a97d-39c0dfad22aso1012255f8f.2 for ; Fri, 11 Apr 2025 05:48:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1744375682; x=1744980482; darn=lists.denx.de; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=Vg4/vprd2sdTaChI4TunLLuWjsE1j/v1KJyQRDTO2tg=; b=rgX/FDuVzdiyUIWlaQTipll81sBJszRjb9WEY2iUkZR1mSMLGwKFV1u1Q4B2aof/p9 Hy+UG5iKwL5NAxb1dAyKb6GEYBaUTe0AgYP/FZ3CnTjAPAUwdRHvoXBCoKjtkoWg+gBx YeTxc4Ti5oOibskN5Ag3JKmSzBNQCrwYQhev+LZy48RgFNIVJLYXaErvfLEcuY6iyXS/ eD583bVH8IwHrvzT3PFRE2fS2FdiueHRNfL3EfqphleK9wZ/RkLY39AcsYFPcdfxog3q /wBa7K04hTEtBsulgUdZwdRfFDJWhjOsXjDr5Qrq5zEaVO98H3vugvmmOjX8cJ/JiBXW vkFQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744375682; x=1744980482; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Vg4/vprd2sdTaChI4TunLLuWjsE1j/v1KJyQRDTO2tg=; b=dfJq+4bqImb5s2yzul50pH4KTVntFm39Ih2+JdmpbRDAqHfp3vBBSR8A8PTDJ8von/ rwiWvpr5+fUBmePR1+0FdEUYl9Gqcn6LVQERTo129clvLPOtY5RxPoDw9kw9Sja9zGMw Pp9YUUin54Yf1UEouGACWKYj1clpSmgIn7Ml4UW2+330Ej+tYODC21Dr0SW9stlybVde PzUvUg2N8dww7w2QpLug39FYVF8CqFfWsVlbFgPJ4K7rfLJxflF1Hn2ztoz2BZSaW7Fb lNL0JLgiv8E+H0Ysy8t4RlsUCvLSOWLTueRGsd3HMB1jUMkfTtCtZ5wI1tbZNYLWj7SL yUjQ== X-Gm-Message-State: AOJu0YwAnmcfscz234zgrhcPs69ShBIncxLmAm+ePxpnz5xfI4MsmJHZ Ot8nTPk2hz3HTA3FhK/2i3X+QkDW9LmyKqilFSUIDYrlh9YWrzoEeFxwopkxvj0= X-Gm-Gg: ASbGncsf+HxzQjdAoVj+8H1RQH2StowK8NtQPjwLJ4oXzp0YSe/2JjnmSeLK78LjxGW EYmqJ/GAreBAdxSgvK0KdbcpNJYiJYNh8HNzyxBiE5n2fzvGnTNToTangHK3E7GsVUjgxfnBTz7 qPQspXJU7LIwsg0BwzHwlf+Omwch5s61WO6faAi0PYCHYYeTFGs/G9x0UjtlRZLnUF1jvJC8q0H sy71nS1lksULXeZ2SCCdhD/oKFGnkAhq4WnJgJpeXPU++uhTlr9NPtX0+vgOLohzdaL/AcvtjML 5+Aqd0JoyBdY9z4wwVb2t+qAGUkBBnO9SrlausW5aVSITfAr+n+nei6a0PMMe0M9B49zwFa8eJR sUy7FtSuNiNednV+NEw== X-Received: by 2002:a05:6000:2511:b0:390:ed04:a676 with SMTP id ffacd0b85a97d-39ea5216977mr2164153f8f.22.1744375681948; Fri, 11 Apr 2025 05:48:01 -0700 (PDT) Received: from toyger.tail248178.ts.net (35-60-142-46.pool.kielnet.net. [46.142.60.35]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-43f206264a1sm88299695e9.9.2025.04.11.05.48.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 11 Apr 2025 05:48:01 -0700 (PDT) From: Caleb Connolly Date: Fri, 11 Apr 2025 14:47:45 +0200 Subject: [PATCH v2 8/8] pinctrl: qcom: qcm2290: fix off by 1 in pin_count MIME-Version: 1.0 Message-Id: <20250411-livetree-fixup-v2-8-1236823377bb@linaro.org> References: <20250411-livetree-fixup-v2-0-1236823377bb@linaro.org> In-Reply-To: <20250411-livetree-fixup-v2-0-1236823377bb@linaro.org> To: Simon Glass , Tom Rini , Caleb Connolly , Neil Armstrong , Sumit Garg , Lukasz Majewski , Sean Anderson Cc: u-boot@lists.denx.de, u-boot-qcom@groups.io, Sumit Garg X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=1165; i=caleb.connolly@linaro.org; h=from:subject:message-id; bh=BO+kMwWeHDM1FfjmeCD6YNHRYohy8G04h8L0/gvLF5M=; b=owEBbQKS/ZANAwAKAQWDMSsZX2S2AcsmYgBn+Q90Cxb1ZsPiQbg47oiUJLBWYu5e6+dRPfa7v fJxUNbPW0SJAjMEAAEKAB0WIQS2UaFGPGq+0GkMVc0FgzErGV9ktgUCZ/kPdAAKCRAFgzErGV9k trq0EACKMOHmXD07ydgQ74sp7tXChsnIEE6MEu/amyFbZBk1ULtGIfZXhJU2q+TQZD8LyB5pDw0 Q6i7GRPXM4YozL5AIdwfalJ+eGq/bTB1kY2y6muGzruRY4pELQzI3peTrhQ0pZu9+PHrs5qBYH9 anbxCoLHHfY/j0Y+C2RWC4h8Eto2QyER5Ls42K830TCzw906B4jkBJRln9tYrTL8eOuq9KfM96i KRpIVZrsh/wcZBb/feHJsbl/QVMgesHFBGe9ZeO7EdbeFrkrkjYHB0W9kzQGTR6Fkuzl7gk6RVC YLJCA+trO/l1Do9vjT3+rSicfNh2duoD20kphIuUzWc9mjPnvpJaI55y2ajE/z60o0qgob3N9DJ eAcSrEFlr5Cz5dmQaLfwueTfj5xAG0I99/UxOua4SPgtj0XKn7uTsgi6HGLDgmH5cg9pShtSqlq 9Or/XbN7caThKs6PsbxRJbrTlJ5tM7jzCIJwROTuNlNf1cGpO3Fj1UY4Q8PGIAf/e4ZyTX20z10 nQijr0lUiq0rej6zvOB/Z2AYk93DAHgWxjrTS48Wzqj6A9iNxKTiFX/4GkLaQyvpsuPTHLxrWUi aYAis92kTdtkhwMKhFiUeSiWN6/0gx7Z5DfPO+rV1eF+qLRwggNMTLN3vUAReBKa7Khy+5d7KcX a60UNTQCQaRt2aw== X-Developer-Key: i=caleb.connolly@linaro.org; a=openpgp; fpr=83B24DA7FE145076BC38BB250CD904EB673A7C47 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean There are 134 pins not 133, oops! This fixes the sdcard on the RB1 as the pins now all get configured correctly. Fixes: 0ecb8cfcb930 ("pinctrl: qcom: add qcm2290 pinctrl driver") Reviewed-by: Sumit Garg Reviewed-by: Neil Armstrong Tested-by: Sumit Garg Signed-off-by: Caleb Connolly --- drivers/pinctrl/qcom/pinctrl-qcm2290.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/pinctrl/qcom/pinctrl-qcm2290.c b/drivers/pinctrl/qcom/pinctrl-qcm2290.c index 0c2222ce663e6d584d229e7521f88fedf8aa19da..84f76b63b93ad78182524661dba561672feb4c85 100644 --- a/drivers/pinctrl/qcom/pinctrl-qcm2290.c +++ b/drivers/pinctrl/qcom/pinctrl-qcm2290.c @@ -44,9 +44,9 @@ static int qcm2290_get_function_mux(__maybe_unused unsigned int pin, unsigned in } struct msm_pinctrl_data qcm2290_data = { .pin_data = { - .pin_count = 133, + .pin_count = 134, .special_pins_start = 127, }, .functions_count = ARRAY_SIZE(msm_pinctrl_functions), .get_function_name = qcm2290_get_function_name,