From patchwork Mon Apr 7 07:21:19 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bartosz Golaszewski X-Patchwork-Id: 878962 Received: from mail-wr1-f53.google.com (mail-wr1-f53.google.com [209.85.221.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3224D22B8BF for ; Mon, 7 Apr 2025 07:21:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.53 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744010486; cv=none; b=pEkpKYFthXTNkc7E6X9zwehWAepjubvJOust6hyN6mpVJXykaLNUeHoanHCm4tzlMPet3cbCaetHs+8d6ji0IhvOXqZ3LQnMwrPdYzrMNbIiabVlFALxg4yV4Mh/WlzKXD+M9KF8yC3xI5zctmHt2a28fVxUOY1pDMW+n5vKT0c= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744010486; c=relaxed/simple; bh=NYalEJMMKkwM5Ww4yh68/Dbtgd+QTQUq4aOgUJNHaQI=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=PTEbFP4HHQi00WML2aMgWVZ2SaZY6YRx8WVfpbA2eVpz8gEFqE3OA2Q25llqpb5JMkocciRZ21y/mfZJA8K7GFMgVnv/NqmH7lxymf7P1tMNdJtcyeIz1I2Dh0ZlrmrJgXfsYHrX3h+0OWisJO7ZveFqi8ZCKvJRQhhxFRbxgjQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl; spf=none smtp.mailfrom=bgdev.pl; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b=KCJZJVK2; arc=none smtp.client-ip=209.85.221.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b="KCJZJVK2" Received: by mail-wr1-f53.google.com with SMTP id ffacd0b85a97d-39141ffa9fcso4493332f8f.0 for ; Mon, 07 Apr 2025 00:21:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bgdev-pl.20230601.gappssmtp.com; s=20230601; t=1744010483; x=1744615283; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=VqYc0+h72+XOfzEYrjjYbBXS836lkHNvrPwnLM/zXmc=; b=KCJZJVK2/JA5wuwxf7A4bgN46RO/tJVg0A+Uaz7ym1swbuqoQ4pL+lJZnv+I00YWlV o3q6PY7iYklWmuys6qNRFXXuakEOit0y0WrFdjwbr8bd7Db9jqpeVZ2YYpvin8cPwTYZ a7uAFbJnu4sQrLwNQrGrm4HFiMTsyEVw4xGnrILEHinLeGH1cH+izchjK2mGGmZaEd1F vngJ3+x4U1L3kY/WHUrR/exNOcmTzFQSozKw7L20w6WAqQJW4qPDW2/RwREJjFewQyjw GpklP8fj8EGliZ5ELj0E7hBLsCnIi1fDbLh41ab+sT0liMiOP0wRIeEQZJe7DrYWCi/J cbeQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744010483; x=1744615283; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=VqYc0+h72+XOfzEYrjjYbBXS836lkHNvrPwnLM/zXmc=; b=rhtjjiY3h9DkHsbXA4mloC0WgMkYCfePGWlUHxBRv2onu+z0aeGp84SC65iSFXID9f Su37RrJiRrl27ZrAVkaEx3F3ZYUgkINq6hoLPWiSh6pu/0E8aKo4BQzRGf0JRA4bko/A ow8wpV0EUzs6Dosh15HVumXLrJId/uJONFpTRE2cO/UlaXNLvWd9MFPtdXSIBkQSdM/S sqy5Azo+bvQM0Ucvpox2Uf49t5rm9T3iD+aLY7qTgzRN/iCKYN1xO/eRr/ebYTHetPOM spyi2Lpn3fQApvvJGVdaclw2o22B7kQAsYkbEPt6Out8AXwCTgz3ZlFgu2OllEa3cLJf qWtg== X-Gm-Message-State: AOJu0YzZvAsB+zsKr4i2tDF3n2mQd8id6D3TM9GjIv8FHxnOP8IAJN5G /CY8QYw+7zCCOV1TFHxx0Beq7v6Ys6lyDez2PBAxPtqwDK+W1YHdk9+ZEfU2yO4= X-Gm-Gg: ASbGncs02eBt7uinbfIfhGM0M+WYtk94T3juG3n5okhMLMpP/g0lNWTOc1UVIM3xOoZ Im0CT34tZ2kKbv3jO4JW/CZiAgCVqIfV/31UU0ykOK/UFQoLJIInsYRIEk+png3ygvplXQRXoKy cIVPQz3KibxPp7ivUyy/s67fk3S9nf3LcJ+i01VtqjGEnYcphBfCRkv6pTcFtWeBAdG21112qWD HYPvbY2bA7jYd8YsK4C16JY8Pq06L5P/h9G9sOLJh1jgcEjAUfRAFz5oE3iWsXXnVONVt04O3Dc pESCzk7ESv6JgaxlImXH9OVb0I38Ej4UmfwCGw== X-Google-Smtp-Source: AGHT+IEylLp0D01gBNPQYuFsaV4Jo8rU+Y22RzbkmwIC8AAPBDzAqbMk4wdqcSVUg+5yIspCNTHcKw== X-Received: by 2002:a05:6000:1447:b0:39c:30c9:815 with SMTP id ffacd0b85a97d-39d6fc49b7bmr4954083f8f.21.1744010483553; Mon, 07 Apr 2025 00:21:23 -0700 (PDT) Received: from [127.0.1.1] ([2a01:cb1d:dc:7e00:8c64:734d:705a:39a7]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-43ec34bbd9csm119983655e9.20.2025.04.07.00.21.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 07 Apr 2025 00:21:23 -0700 (PDT) From: Bartosz Golaszewski Date: Mon, 07 Apr 2025 09:21:19 +0200 Subject: [PATCH 1/2] memory: omap-gpmc: use the dedicated define for GPIO direction Precedence: bulk X-Mailing-List: linux-omap@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20250407-gpiochip-set-rv-memory-v1-1-5ab0282a9da7@linaro.org> References: <20250407-gpiochip-set-rv-memory-v1-0-5ab0282a9da7@linaro.org> In-Reply-To: <20250407-gpiochip-set-rv-memory-v1-0-5ab0282a9da7@linaro.org> To: Roger Quadros , Tony Lindgren , Krzysztof Kozlowski , Linus Walleij , Bartosz Golaszewski Cc: linux-omap@vger.kernel.org, linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, Bartosz Golaszewski X-Mailer: b4 0.14.1 X-Developer-Signature: v=1; a=openpgp-sha256; l=806; i=bartosz.golaszewski@linaro.org; h=from:subject:message-id; bh=W3DX/G7SfvWTY6yhl3JHraQx6MB7aIVZCQYoNdF4OR8=; b=owEBbQKS/ZANAwAKARGnLqAUcddyAcsmYgBn83zxJSSL5ijCrjtatIGOOA7cJetXi6ApKG6BS DnLE57D+cCJAjMEAAEKAB0WIQQWnetsC8PEYBPSx58Rpy6gFHHXcgUCZ/N88QAKCRARpy6gFHHX cmxyD/9vrVD45lvCtqQR34ByKLHJguNZHFOLXIsO/zXYrKeQptI54MwWfVo0VZbGTB+Cz8hn8CQ E+Sq2eaJbEk/2wKaoYlgYaQ733hwqdJVS0N3nFZ5wnYIOF0UFflwczQbn2mGZPIitpRA5zbD/ZA IdgBaK4+B15XnDyHzQNPRHhnnfE07WhC1sf2jAvTVDaAatpas0Qp2rDjtC6ND30+te3izE9vIyE IHyuw6JAWCBNQOlhQi8J46NuTc/wQrVQySG/SyOcNhaJifApA5ktHTceJo4QQqhWVdnKPEVgsSm 7XAdvEzI9pykGIviK2Fmeiom112dSNFTc4lQdrBlEXiixe9IoB+oDHcfMkRjiiKYEIj9FFSSmco iGu7mQk6LiHwjxctfUdVJvV17lMxS5YP5r0xRT/aDNwCPvvqhBSg6uQC4CiMqmMWUXYbvZhpShW NHr8/oz0VVd6T3agK8Jvsp/dvejkqG/cEJ2WvNCGnQJ0Am+EQ9sZ5zcUe0FBO7fItwgZMBDx090 57aX8JezFk0Fh18o9T5u/Kecs0O3ek+M61z0/LzScugP3nU9+xlBtwbZXZQcJ32IYRlZ8L0JlBE q8STH8oyRsAGXZjwdDioGPqBsRotEXT//qs+D0zqSYFXOySpKWF/ciM+usfQECZsEk1YseebFKy 7Hy644u1zExqB4A== X-Developer-Key: i=bartosz.golaszewski@linaro.org; a=openpgp; fpr=169DEB6C0BC3C46013D2C79F11A72EA01471D772 From: Bartosz Golaszewski We have a constant defined for this purpose in the gpio/driver.h header so use it instead of a magic value. Signed-off-by: Bartosz Golaszewski --- drivers/memory/omap-gpmc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/memory/omap-gpmc.c b/drivers/memory/omap-gpmc.c index 53f1888cc84f..d4fe4c5a57e7 100644 --- a/drivers/memory/omap-gpmc.c +++ b/drivers/memory/omap-gpmc.c @@ -2376,7 +2376,7 @@ static void gpmc_probe_dt_children(struct platform_device *pdev) static int gpmc_gpio_get_direction(struct gpio_chip *chip, unsigned int offset) { - return 1; /* we're input only */ + return GPIO_LINE_DIRECTION_IN; /* we're input only */ } static int gpmc_gpio_direction_input(struct gpio_chip *chip, From patchwork Mon Apr 7 07:21:20 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bartosz Golaszewski X-Patchwork-Id: 879263 Received: from mail-wm1-f43.google.com (mail-wm1-f43.google.com [209.85.128.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2E54022B8D1 for ; Mon, 7 Apr 2025 07:21:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.43 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744010488; cv=none; b=UWEasN3kyiz7OmfFNnkkqFpOM29BoL/9pxVl4FcnJ1lm2BPiSKKPUVxnMr4k0W3DctdEWsUlhRqab4YXBwqsU/pQonnp9T3Rh1MvRFadvroMDAgW4daca6yvM2jIWBCQXX91urmpiUbF+H02n3kGxggPtLynVNeqQMF4y0zoQ2c= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744010488; c=relaxed/simple; bh=a+X2xbpBMey7kHH4SZHjVwfqMfk31JwTN71fTF53W5Y=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=lp3V9xzBln8f+TJThgNR0pZQgVnjJqiU6Xs1L0qymnY2W0/aqd6J9i0nVSZ2v8qT0YV73o/ZqCUzfzpdTcm9HIw6DujwnfYRSx2tZ4DaxzMBJ/bp8HUvUQeGpGu6S2n5J1Q8S2W85AP4Nt9C1NlJZDAWJmlY2a8qUOHpFcr7kPk= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl; spf=none smtp.mailfrom=bgdev.pl; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b=l5XYa4Ye; arc=none smtp.client-ip=209.85.128.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b="l5XYa4Ye" Received: by mail-wm1-f43.google.com with SMTP id 5b1f17b1804b1-4394a0c65fcso36741805e9.1 for ; Mon, 07 Apr 2025 00:21:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bgdev-pl.20230601.gappssmtp.com; s=20230601; t=1744010484; x=1744615284; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=vtgBZ7eU2RyQ7K9QClD4KK4V7G50PAjgBWwYE6tDnr4=; b=l5XYa4Ye9XNYijVUo/jis9T3jp2c660XZ+HkwMH+gg+yjSEN2fYvRyHWvvVg4iKEnQ sOQdCb0r7PxyO3wKGHTHM0bU4yRIO4mv3UqmF+NBaR9eDcaiFxY1Do1LjYCRs+V3eA2u L3sFuXVNCL8aLBHt1w+AFGtqegMF8X7SKOEzn7B8Ir0KeypRYiDMyjWEvPLWOXucX9Jb kRYV9oUBmiT4OUXZO8BfmzLL86q5MaHk6Mx5ncqduzN2d9vuefDEiWZrcEMysiuxd/vF F9MKrYjQhi29wgRkqfOrq/rU0/Dp2AqHPhqYE7SLP2tE4JBILfKbKwXLNZ5OvR2VNvDU 1PrQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744010484; x=1744615284; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=vtgBZ7eU2RyQ7K9QClD4KK4V7G50PAjgBWwYE6tDnr4=; b=XT3CczKxibH0lIrA1EGZuR+UoxYc2pK+1P1Kqh7vtHq8wa7qFe8ZmobmI2uKe755dO n7jgHOZskOsAaAUzOuMYyV7NK5g/MWF/ooiPadaqM0Cemydm/nsvWDwU7z1T0dbg6v+c fJhfyZLngPY/u4W3k3XMnEbEkQxKp+WgZM3Q6pyDim9pnPeLofB5ydnWqx89XAdXJD58 Ksiw9iIAUc3O4xK67fU5E7/eWTf1PtyOOqlW9X1QkHbtuLip5eILGo8IZ13uJZzN6qsH jX0mWjgXKYlOSDLxXiXIb2IB2r+WXwBxQwa4iMIR9CaDxJLLoK9ifHGxCTlFr05ZxRpn Px/Q== X-Gm-Message-State: AOJu0Yz8qX/QQuZOWZvvOw4/rJ6fAroWcY33WPPJFyfX+3sHFsmBGaep kjZtIqIfEOdNcAla+6k6gYsxFV26TPsFKWQemKtoT19DB3AiOVjx9FppP9o51Rk= X-Gm-Gg: ASbGncsnoen4ooT6vuoX+QA3fb7/Ry+BEMnfmdNWMl2VVcGgIWEfEScKRgQTnKFRasK 9iMO9677nK5aeQ+6FNoDQZhOWvdh0K6J7j1y5KYy/XxsdqoCLApyLjULgNJDOpXEdhTuD1Btrnn bWstRQm3XFwqwpc7r982elzdFol0dkrVqWdmpBZxhyjOzYvccLlOfEaQuDxgIzcWyDyyEuMDm6c 61W8nkf8BMgE4rbN1lQjOYbTOxq7z322e1st3qI682znXtcLKjmncU754y5OWrwRgyKU1KDxDNq ERecr2XXItewzW5SGnwRpa/RvG4Bq2B78boX/g== X-Google-Smtp-Source: AGHT+IEFfF6NsFb+iD2Dwb5PIsfcjTtavnPo1FW572AhfERUhpnGldlTQTty75Rd5V3CGThwZu431g== X-Received: by 2002:a05:600c:4449:b0:43c:fe9f:ab90 with SMTP id 5b1f17b1804b1-43ecfa18d6amr74518805e9.28.1744010484347; Mon, 07 Apr 2025 00:21:24 -0700 (PDT) Received: from [127.0.1.1] ([2a01:cb1d:dc:7e00:8c64:734d:705a:39a7]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-43ec34bbd9csm119983655e9.20.2025.04.07.00.21.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 07 Apr 2025 00:21:23 -0700 (PDT) From: Bartosz Golaszewski Date: Mon, 07 Apr 2025 09:21:20 +0200 Subject: [PATCH 2/2] memory: omap-gpmc: remove GPIO set() and direction_output() callbacks Precedence: bulk X-Mailing-List: linux-omap@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20250407-gpiochip-set-rv-memory-v1-2-5ab0282a9da7@linaro.org> References: <20250407-gpiochip-set-rv-memory-v1-0-5ab0282a9da7@linaro.org> In-Reply-To: <20250407-gpiochip-set-rv-memory-v1-0-5ab0282a9da7@linaro.org> To: Roger Quadros , Tony Lindgren , Krzysztof Kozlowski , Linus Walleij , Bartosz Golaszewski Cc: linux-omap@vger.kernel.org, linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, Bartosz Golaszewski X-Mailer: b4 0.14.1 X-Developer-Signature: v=1; a=openpgp-sha256; l=1429; i=bartosz.golaszewski@linaro.org; h=from:subject:message-id; bh=jArihSAhBxkP93ay/ZjcYrFJIACv3IqWH8LZYxUU1yI=; b=owEBbQKS/ZANAwAKARGnLqAUcddyAcsmYgBn83zxZ31S8gqjE6RumdrktJc88LidiJj2N2ODy PHjicRRsMaJAjMEAAEKAB0WIQQWnetsC8PEYBPSx58Rpy6gFHHXcgUCZ/N88QAKCRARpy6gFHHX ctBlEACgHv2EfbXGd6EpZZRTqnj38TMqOfFUzwWMCCrTlcfcRnT54k3uqFNxJhTNeordcuXHUxP H3t5PtMye9H/3zNS/z1vF6QxBbk0iX93iIoapVmHYGr8q/1vf5uguVbh+rbmGngIfp4zGLO6bqJ MjvrcDkZ2uVd7pS+gVGe7nN2Nby0yZVBcMw6fcYLcHUmmt+hMHzvdYPeX/WEqlJYh8Qg1FIk/jA eAdjOZoMy8p8ccg4W+fN1KkJskmsr+WvvDujB1ElpsPDKZe8a6GpNKKHqjYIuECh6WPpTU/2gUy 5ohToPPkGrrjRdG1QYNlVMGoYzSOhCPolc5jdjIfvTXw/RVpM1sXqRodWv30w0b7tKNkSNzCZW+ YQ+LzxNQ+FMRUeEXE7MiPiyUF5837ryugHAvKuucndYp7iLBhgO0RTypz0x74/vvZwhuCdBR0iU mFiyIcY4jqZMFF8asaURPotDzhHOugldYONXW10Vt9DDzLG6jRdRQd/XMT1F3E9YrztTkgb4SvA wh4lX2tS4jhk9o4gKjZSDvuA2aylctO3chJKWQA7IpUpRYhfLqgkgm8lsvGfPsU48VgQ+QU+f7X arm0viz+ZZTgdsILX9vUwDpG5FPdSBcMkEkNoEC8L0FOXrg42PZAurLO9Hy6+wdtzb2DKFRI9g7 pC3+JklCL61b41g== X-Developer-Key: i=bartosz.golaszewski@linaro.org; a=openpgp; fpr=169DEB6C0BC3C46013D2C79F11A72EA01471D772 From: Bartosz Golaszewski This driver implements an input-only GPIO controller. There's no need to implement the set() and direction_output() callbacks in this case, the GPIO core will handle it. Signed-off-by: Bartosz Golaszewski --- drivers/memory/omap-gpmc.c | 13 ------------- 1 file changed, 13 deletions(-) diff --git a/drivers/memory/omap-gpmc.c b/drivers/memory/omap-gpmc.c index d4fe4c5a57e7..a61e71c31f20 100644 --- a/drivers/memory/omap-gpmc.c +++ b/drivers/memory/omap-gpmc.c @@ -2385,17 +2385,6 @@ static int gpmc_gpio_direction_input(struct gpio_chip *chip, return 0; /* we're input only */ } -static int gpmc_gpio_direction_output(struct gpio_chip *chip, - unsigned int offset, int value) -{ - return -EINVAL; /* we're input only */ -} - -static void gpmc_gpio_set(struct gpio_chip *chip, unsigned int offset, - int value) -{ -} - static int gpmc_gpio_get(struct gpio_chip *chip, unsigned int offset) { u32 reg; @@ -2417,8 +2406,6 @@ static int gpmc_gpio_init(struct gpmc_device *gpmc) gpmc->gpio_chip.ngpio = gpmc_nr_waitpins; gpmc->gpio_chip.get_direction = gpmc_gpio_get_direction; gpmc->gpio_chip.direction_input = gpmc_gpio_direction_input; - gpmc->gpio_chip.direction_output = gpmc_gpio_direction_output; - gpmc->gpio_chip.set = gpmc_gpio_set; gpmc->gpio_chip.get = gpmc_gpio_get; gpmc->gpio_chip.base = -1;