From patchwork Sun Apr 6 20:35:30 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Krzysztof Kozlowski X-Patchwork-Id: 879699 Received: from mail-wr1-f53.google.com (mail-wr1-f53.google.com [209.85.221.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4E5074A21 for ; Sun, 6 Apr 2025 20:35:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.53 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1743971738; cv=none; b=MwWDE3N4SxuRnRmLfCuhomi3TA7D3FJptvQIS2Q/CVFo21jSRYxTwB1RyK3M1aOBmJCnTklikgxG0UADlDIUU2ranV701ZP+b62jZu3Uzg41cjjhwHadOG74QGmaVsIFpFYpdfiKn0G9EfzjZdnU6w9eZ9XrvgL+MlwoFtbQT8k= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1743971738; c=relaxed/simple; bh=UbI8Gh0YS/za2rbwjxm9DmBDDl36qAmIDgTkA7RT64I=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=G2VkcFLyt6c0TcmPlVfLq8nrR19cJX5gGFl0GgNH6h8GaJfR7eOtKWBV625KmEwKmaXIji2KBTpB7FrVQNXwusVz8SD6zSzk4bF1JXzJWXwKAbkCLjLUr0Q5sY1aVwaV1HU0sMbDR/N3A9pOyFB6lYjZZ4F/9jaeO3+X2Bp8InA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=WV7QwQl0; arc=none smtp.client-ip=209.85.221.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="WV7QwQl0" Received: by mail-wr1-f53.google.com with SMTP id ffacd0b85a97d-39973c72e8cso402699f8f.0 for ; Sun, 06 Apr 2025 13:35:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1743971734; x=1744576534; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=vqE+fJoQoP5EIZsKKCKpe2hB/iRkIebJfJA+OiuqQwA=; b=WV7QwQl0zGWbUNzrCOIl4wtl+cQmUZZRsXkkCgj92rTeCcPY+0btn4Vu7Wyd6JuIpB bWpQF2miyqzbM90o5VrxZbdWbcYFvkxlhuV/HAfzY0Ln8hqAZWyMlDq4C7QQ3NEiUm43 32aHP8oCUjT70ikONK4pI8GXZmVtq3NRq0ryECKXG8ch1FoN0XsFAans2GrkbhbDWu4o Yyxoc3L2gqMltlmnSY7E/9vZVEbAN5U4Qrye17/DZ6I/lklfqCV5S3GLyMwHP3Pz/w5Z hmuGNR/7+sTI5PciHmmvsS+5fKJUcnS4/aSYimYqth0b+Jbq7MjtgGtnpmnPlxS1Jl5Y zjnQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1743971734; x=1744576534; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=vqE+fJoQoP5EIZsKKCKpe2hB/iRkIebJfJA+OiuqQwA=; b=SwpA+Joyl0wHEG0wQt6DV2M7VYapAsZgmM4f2aXiyt+FUlM+bR88Q++Vty8OFrBFqs hSlUuSh9K/zVVl3cnYkyCnviFIPG28ga8dRtQDmIuwWlws/gGiSAfzwVv1nUOsidRXGW NokVDYeuASbKJL1Aq1jkRreomhmiQe7UI8qTdcG64M8V83jCgAhvFENIe2MjiLax4d5L CCfBA9HJ0Qfon4Vd6E/0EZSqSuj9emv8Xocg/4z1JkJsMrAPPq8BnrrHzZ4rWrF2H/gI uLtofHFfI+N2+Ya+vT47nP7BIMDg9cMj3LRSIX/p3SXsLSRcKIIuHx/qupHP66k8zYGQ dI/A== X-Forwarded-Encrypted: i=1; AJvYcCUVxtog8y/UbGrFuaCgL2sqXc2gPDxexteVV6ww4nXhBtI6328iioiM1DLraXaUSXcisJbHyvoZpkI0Lu4fmA==@vger.kernel.org X-Gm-Message-State: AOJu0YyMzgWVOJqSK9Ep1mIv+TlWDg/IQU2/sH4X4CiL8DB6tMyvHG7t IyAvSiXOFvOSjpL1FH4Jq2hZHoymI1dlTGgHIa0Km8bGuhYP82CAPPuz3GXm0fc= X-Gm-Gg: ASbGncuGPKU7iloiA7vD1JGMHWYwl8sS88a5aZVbRfUtjaBzev2tvDD/jEZ81r9hxVQ 9JkIm6IbtJ/WSexAaGe5khP8G4uMefeKP4bOlb4M/JSVKulHGyE8pQd7WS5lEhGT6uymwg+Jfxe 3f5fLfkgSAEx/vzofU1JHv3q0tOqhSzKr/oOrKI83OoIXmHkqEBlCLOJL2EwAsorx9sGFLtG84l Jmkq8mlth8RY3iI23LNtrlNKCZvwNzhGar6Zz/dsBtlyDSTby81bchISCKAd2qBbscV5fmUYrI0 IWbZXp59KNQtuUce7A0Y4vtyrTSlRsM/6B6l8Qcbdt9nc+5iVtDRHA== X-Google-Smtp-Source: AGHT+IGnWAB5N19dqxV+uf9H1b+D2cecFF/JdZzD4NafcpKENqOS32Y9IbVOYHktlCW19MYWLq1llQ== X-Received: by 2002:a5d:5983:0:b0:391:277e:c400 with SMTP id ffacd0b85a97d-39cba93faf2mr3373054f8f.13.1743971734540; Sun, 06 Apr 2025 13:35:34 -0700 (PDT) Received: from shite.. ([178.197.198.86]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-39d7c6d838bsm38022f8f.69.2025.04.06.13.35.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 06 Apr 2025 13:35:33 -0700 (PDT) From: Krzysztof Kozlowski To: Wim Van Sebroeck , Guenter Roeck , Maxime Coquelin , Alexandre Torgue , linux-watchdog@vger.kernel.org, linux-kernel@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org Cc: Krzysztof Kozlowski Subject: [PATCH 1/2] watchdog: stm32: Fix wakeup source leaks on device unbind Date: Sun, 6 Apr 2025 22:35:30 +0200 Message-ID: <20250406203531.61322-1-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.45.2 Precedence: bulk X-Mailing-List: linux-watchdog@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Device can be unbound or probe can fail, so driver must also release memory for the wakeup source. Signed-off-by: Krzysztof Kozlowski --- drivers/watchdog/stm32_iwdg.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/watchdog/stm32_iwdg.c b/drivers/watchdog/stm32_iwdg.c index 8ad06b54c5ad..b356a272ff9a 100644 --- a/drivers/watchdog/stm32_iwdg.c +++ b/drivers/watchdog/stm32_iwdg.c @@ -291,7 +291,7 @@ static int stm32_iwdg_irq_init(struct platform_device *pdev, return 0; if (of_property_read_bool(np, "wakeup-source")) { - ret = device_init_wakeup(dev, true); + ret = devm_device_init_wakeup(dev); if (ret) return ret; From patchwork Sun Apr 6 20:35:31 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Krzysztof Kozlowski X-Patchwork-Id: 878697 Received: from mail-wr1-f41.google.com (mail-wr1-f41.google.com [209.85.221.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 96BE21AAE28 for ; Sun, 6 Apr 2025 20:35:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.41 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1743971741; cv=none; b=cbuA612q3560eYXvQ84+rTunuKb1t45v7cdN7s/IK3kp+OWe41fBZrcbqjJZZsUh/PXuyy00xqfumzqlhe62JkQhbY4izKqGof2cRqO6rs9xjkXYi6E2L6aHd5WAHExzdr/JAPEZhmQI6DJV/zLm1Qz9Nayps7H1Fph/4ZVwnak= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1743971741; c=relaxed/simple; bh=uxBiam5DW4fuTxINZdCznl0HQyCEFQQbzh0ALsr6FA0=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=a0C9QzxI80gbWZbw7ClTf891l5Sg+31MtVIwakpPPDohFOTSQVLNzgR/GUuu+52Aq8wXGTx1pxeQx79/xzlE38OmC0iZT4TvLmVVn16r66W02lH6aUVEbXZUsc44gljHjJfsCLwf1gFQjh4O6AW1eJlCk+1XSnNuh0rjZxs2buo= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=LmdZc6YK; arc=none smtp.client-ip=209.85.221.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="LmdZc6YK" Received: by mail-wr1-f41.google.com with SMTP id ffacd0b85a97d-39d73b97500so60917f8f.3 for ; Sun, 06 Apr 2025 13:35:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1743971738; x=1744576538; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=/Oni6Z/lHvJDm4dC2qfnAqvwTkcCLV7N0fQ4hIhJQyc=; b=LmdZc6YKLWjjGvfDJFbbHiKFN6qSAL3CYaF0k3vCxV0eJfPzGfjoL+ytqWNzUyXaZi DZ/l8woh48oBPO79bC/1faGiI81LCsDND2Hj589/Ce7EpFSFlBADVBguzJxUJV/hZe9j cP4j+Zzfu7VaTuUc3OTYHZDxIXEr4hA9QFZyyPftW2YouTuJKmcJ+6XR89jgbxjKDS24 dxPYQ876x2W02KHb1Td6BK5axG15wbV1d2sTBlr8cLNHjzPTvlAWt3vKltgwh5RVd6RW bhPN0xbaDpeA4LL4d8noujrsErmhqkvaBblm3a44uGRLxxW3j+0rCtBN9GwdawBNz9YB GWQw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1743971738; x=1744576538; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=/Oni6Z/lHvJDm4dC2qfnAqvwTkcCLV7N0fQ4hIhJQyc=; b=vRLzsrFFmgpppLWkMIPWZCotu/C7VpKnBDxK8z+XzEdS7CULrRARY7dwFNWNyppqwj kf/NxIoZD5YLAaSSwV8UhvrBkcfLl5PU1y1IWPacf039IVeD/NvYr2SyL707jqcQTfJO 6jh2ZinCT5v5a3u5q5L2GefsH5ADPRuxAabCMWzz+k2AGzwo7B+TqaVb6MRB3R4seZ0L fY7kjyg7YrU4mQDuk9lahki9wCYLH4ksvb+iHXpb5wDjfZF2vxESwb+c2vRh33hGT5/G aK16759uTcRFizL/fTqI+/xWlVeX215LJTiYD7bBbwpO+Y3BsHOkp1zfQy6p22GWn5ny YGKQ== X-Forwarded-Encrypted: i=1; AJvYcCUS9qFRRmHUQDm+tQo93AgpyN4pW+Iss77hFmV4mHNRMngGaEo0Uy05vpSt4aOh7ZT2nCdofQnvxAcaLxbhjA==@vger.kernel.org X-Gm-Message-State: AOJu0YxHF4UzyfcxBi2kumVTBxjkfrONGuv6g35VUOp9dgGuZK0dnFQn 1E+fuIZmQ/GT2mVTFSSwdNkfklVdxPHIkrqZIqogxZbidu5R2+KHOHeUBFgok1A= X-Gm-Gg: ASbGncsqhwezR9zyTT/O8rkWy7HlIPZNIxUOoM2ZMc6S3AWSWmgxH2LfpDIhUB0VYJ0 Bg1PViJ3YwqlBuJU20ycUW0ax5ghd14Nw1KCJ6LDSuT2pdIQMEEL6i3l6e8iKsGP2V8J6pUx+Ab VugD29N0ingo49TKG4SY5NhPXpRAjRqfQhNds5t3PqSDFGNcubeV0wIvUOgSGIsseyz2YF0nXHd +FuxeeQrLnnylPiBi9B+JtfIMvytwHZwF2QhvK7DuCQSdmz4i07MdZOSUNonFTNeB49CWVcn7lB ikFsd2hwAZ0Vn3XiBP3yYw5P4Y7i5yDwGa1kY/wAz550Rhpz/AN/Hw== X-Google-Smtp-Source: AGHT+IFdkV0qo7M6MnBRCoiFVbhYiS1XD9xft1NUY735rauYmXbOkSn8HVSEp3wFfmum1Z3fJ/qIqQ== X-Received: by 2002:a5d:59ac:0:b0:391:2a9a:47a6 with SMTP id ffacd0b85a97d-39cb3595265mr3095383f8f.4.1743971737746; Sun, 06 Apr 2025 13:35:37 -0700 (PDT) Received: from shite.. ([178.197.198.86]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-39d7c6d838bsm38022f8f.69.2025.04.06.13.35.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 06 Apr 2025 13:35:36 -0700 (PDT) From: Krzysztof Kozlowski To: Wim Van Sebroeck , Guenter Roeck , Maxime Coquelin , Alexandre Torgue , linux-watchdog@vger.kernel.org, linux-kernel@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org Cc: Krzysztof Kozlowski Subject: [PATCH 2/2] watchdog: Correct kerneldoc warnings Date: Sun, 6 Apr 2025 22:35:31 +0200 Message-ID: <20250406203531.61322-2-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.45.2 In-Reply-To: <20250406203531.61322-1-krzysztof.kozlowski@linaro.org> References: <20250406203531.61322-1-krzysztof.kozlowski@linaro.org> Precedence: bulk X-Mailing-List: linux-watchdog@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Correct kerneldoc syntax or drop kerneldoc entirely for function comments not being kerneldoc to fix warnings like: pretimeout_noop.c:19: warning: Function parameter or struct member 'wdd' not described in 'pretimeout_noop' Signed-off-by: Krzysztof Kozlowski Reviewed-by: Guenter Roeck --- drivers/watchdog/pcwd_usb.c | 6 +++--- drivers/watchdog/pretimeout_noop.c | 2 +- drivers/watchdog/pretimeout_panic.c | 2 +- drivers/watchdog/wdt_pci.c | 2 +- 4 files changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/watchdog/pcwd_usb.c b/drivers/watchdog/pcwd_usb.c index 132699e2f247..b636650b714b 100644 --- a/drivers/watchdog/pcwd_usb.c +++ b/drivers/watchdog/pcwd_usb.c @@ -579,7 +579,7 @@ static struct notifier_block usb_pcwd_notifier = { .notifier_call = usb_pcwd_notify_sys, }; -/** +/* * usb_pcwd_delete */ static inline void usb_pcwd_delete(struct usb_pcwd_private *usb_pcwd) @@ -590,7 +590,7 @@ static inline void usb_pcwd_delete(struct usb_pcwd_private *usb_pcwd) kfree(usb_pcwd); } -/** +/* * usb_pcwd_probe * * Called by the usb core when a new device is connected that it thinks @@ -758,7 +758,7 @@ static int usb_pcwd_probe(struct usb_interface *interface, } -/** +/* * usb_pcwd_disconnect * * Called by the usb core when the device is removed from the system. diff --git a/drivers/watchdog/pretimeout_noop.c b/drivers/watchdog/pretimeout_noop.c index 4799551dd784..74ec02b9ffca 100644 --- a/drivers/watchdog/pretimeout_noop.c +++ b/drivers/watchdog/pretimeout_noop.c @@ -11,7 +11,7 @@ /** * pretimeout_noop - No operation on watchdog pretimeout event - * @wdd - watchdog_device + * @wdd: watchdog_device * * This function prints a message about pretimeout to kernel log. */ diff --git a/drivers/watchdog/pretimeout_panic.c b/drivers/watchdog/pretimeout_panic.c index 2cc3c41d2be5..8c3ac674dc45 100644 --- a/drivers/watchdog/pretimeout_panic.c +++ b/drivers/watchdog/pretimeout_panic.c @@ -11,7 +11,7 @@ /** * pretimeout_panic - Panic on watchdog pretimeout event - * @wdd - watchdog_device + * @wdd: watchdog_device * * Panic, watchdog has not been fed till pretimeout event. */ diff --git a/drivers/watchdog/wdt_pci.c b/drivers/watchdog/wdt_pci.c index dc5f29560e9b..3918a600f2a0 100644 --- a/drivers/watchdog/wdt_pci.c +++ b/drivers/watchdog/wdt_pci.c @@ -264,7 +264,7 @@ static int wdtpci_get_status(int *status) return 0; } -/** +/* * wdtpci_get_temperature: * * Reports the temperature in degrees Fahrenheit. The API is in