From patchwork Thu Apr 3 18:12:07 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mario Limonciello X-Patchwork-Id: 878607 Received: from NAM02-BN1-obe.outbound.protection.outlook.com (mail-bn1nam02on2078.outbound.protection.outlook.com [40.107.212.78]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E624A171E49 for ; Thu, 3 Apr 2025 18:12:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.212.78 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1743703933; cv=fail; b=Wnj5ir7otEET+vroCyYSkw37e4EgteGOfwBeI1SrUYpO6uw0ZK4guda9TSoSR9GmYZxRbLtQZvEtO9C3CkT7ktc32wkhwC5srXwHAy3Kv+JCRme371x3///AkuLtT1AXuC7WekqSJ3qQkK21jWjXlrU6dxpTXKxRVU6qkwlyjG0= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1743703933; c=relaxed/simple; bh=bb4VY4Bs6KRMRM4AL0dhlmsAjM93Ji9iKeUz9YG4EKI=; h=Message-ID:Date:To:Cc:From:Subject:Content-Type:MIME-Version; b=j/h22T6I9Hg71TuPN9hpCGrjOuhUAjVC7Q3DYA9uGwGKAqgDkQSg+S9zSKS0tTlh16dIkIX+gtE1kmgnoY/5iNR9apOGxAz5ZOiHwe5MOiXWgE+qm+SnI4nKJ0BEgSYsvn8Kx7U8vy1eVMcTEu5rK9PCxdTHggzKzhJtCQRFFRs= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com; spf=fail smtp.mailfrom=amd.com; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b=R4Pd08rb; arc=fail smtp.client-ip=40.107.212.78 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=amd.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b="R4Pd08rb" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=jDthszPFb5eDSp8HwbL0pAvUG0bQElkwyNdzPoHsYIArtK5RUmNMmZ8L2V8Vt0OxhTsJSmufeTrTZprK5uunQ/jfXSALT15Ehl53wxLAE78GZ8SUtpGu8gF/7YAoqJ2nMY7ikDf6JkiUTxAF8wcvf8zsbGn+28mbc+vmdJ50vJ/HM8IXerAbsTSDQlK+ifBHMCBhNdYxJu7f7teB0t8gIQ047Sv78J+dsU5f3+ZOex/HtigPytzaLVttcvCWhIU73JAjpw0ke0y983oARWqhRzUtkGbW1ACUMIfI7NCO59W9N4mmOFQJxH72NZPk/Juw5oJw8ECPJMLkbE6wncu2rA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=nD0FI5289vXuDEdRGnQ8gmShsbCv5LpmYkZm50trqq4=; b=hfllKT/LyygzRmbCqTAeRgpfT0xRfwxtl4rG7gEh9FPW/GDi6w0TkFTxYcWrUQYwjptAY4ofgCxgI1pvDc1t2FShAO6DaEjfEEQQmJ0RoRBJfOz5TDQSu8d4cZLMQGJP3tdDJcDOqxzn6sn9TBqjt9Hg71ifT5Ddua+nujMOwQQBSFMDyTiKT7txZnElCTIaiVL542hMyoeX5XBzeqBkNFxE5IhY0BoQYttR6KmKyLq0zXseOTO/Qddhrra3u2GZF6TZOaYJ5EF6xeLVH9igGNYowRgbjr3hT3viuAkMUalbahzhTSbTpWhZPCFMAVuX9yTX91PvLo5CwGzs4ekHpQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=nD0FI5289vXuDEdRGnQ8gmShsbCv5LpmYkZm50trqq4=; b=R4Pd08rbhbtsyOsEFA6NAPRaO6OunI7zQ3d6ZJKAoXyYGAAl1eqb8MZBBUGCNv7vKYeTHECpIDIyxNVZ/DzXGT66hB6QCvH8MN2nJ3XfVGgrlcEOn/e/wjSOxhVJqcdVfRG0kpy0HxR9PfpAg8RvNP8K3hXJeqJxzzxhUUhgZmg= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from MN0PR12MB6101.namprd12.prod.outlook.com (2603:10b6:208:3cb::10) by DM4PR12MB6446.namprd12.prod.outlook.com (2603:10b6:8:be::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8534.47; Thu, 3 Apr 2025 18:12:09 +0000 Received: from MN0PR12MB6101.namprd12.prod.outlook.com ([fe80::37ee:a763:6d04:81ca]) by MN0PR12MB6101.namprd12.prod.outlook.com ([fe80::37ee:a763:6d04:81ca%4]) with mapi id 15.20.8534.043; Thu, 3 Apr 2025 18:12:09 +0000 Message-ID: Date: Thu, 3 Apr 2025 13:12:07 -0500 User-Agent: Mozilla Thunderbird Content-Language: en-US To: Mika Westerberg Cc: "open list:USB XHCI DRIVER" , "Gong, Richard" From: Mario Limonciello Subject: Wake on connect / wake on disconnect X-ClientProxiedBy: SA1PR03CA0001.namprd03.prod.outlook.com (2603:10b6:806:2d3::12) To MN0PR12MB6101.namprd12.prod.outlook.com (2603:10b6:208:3cb::10) Precedence: bulk X-Mailing-List: linux-usb@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: MN0PR12MB6101:EE_|DM4PR12MB6446:EE_ X-MS-Office365-Filtering-Correlation-Id: d15fec8a-cfb9-4d37-9175-08dd72db0c86 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|1800799024|366016; X-Microsoft-Antispam-Message-Info: =?utf-8?q?O3T82uCJbFYPj+89cAX/k8tPbZZzJA7?= =?utf-8?q?g6gVwjc8twLdI34zAkhqwEI/e62uk2EDd+JNgqyKLptInWJDaPgdfVQI3jMtJ6UCP?= =?utf-8?q?vCbK4BF0uLVRx2cgXA1/p0wn98MflPGh1joLClHBvAu/DDrvPPc5N9P9s5gWzYWsI?= =?utf-8?q?hMaSYG8aLxmC+yLlrJWhPAzPe1Vmf6esY6AvWjpMNcUWT4A62p3gAu+s54OKbeCO5?= =?utf-8?q?mE49mzbWfPI0xaORpOjFsT17gbz1RS4MpQ3zxIERCdCiMei9NDZdC6xNJdVqv7aw9?= =?utf-8?q?PaN9z2KS2AXlKu3mfoxFwPoHVz7UHuf+5fWMv0O7W/7IZMO+stDr2ZU9dCF1CKsZf?= =?utf-8?q?R114rqxHwRkMOfq7+UJYkqILjxYtikr6j5zUNBuWmtDjhHFYPr/rOboDaW+kr2611?= =?utf-8?q?rwmX2V6zeXJpvaD+Zj4EI8Ux3EZCF03hTzUCsXTDh5tYGmKIbIQO4EynCzdQRz4f7?= =?utf-8?q?oOidah+t1AnrvnYWkct3B7QX9nYt+ZaOoSwuc056pDHDwpAR6pdl6CewEWS9VSzla?= =?utf-8?q?Wasn3XcuZtqZ53cwmJcrsqv3+A4mI5Mvo366CzMDNobO9Qbg5vaoQyqQKKXBzdbpx?= =?utf-8?q?qx280qnEXtW11k59lt3Z+o8geb8mdVaFdm1T86GWIgqgXPKBn+1apXkynx9ju+G88?= =?utf-8?q?2ro+zs/TAB8QNhGgc8/A+fQpd7c6v0NqK5XFOImQMTMc3VAGRXM93q7hAAv8ZXE3j?= =?utf-8?q?R4oDfUWEFxNT4J+5xZY2elD5QNAxD5afvM+E3buEqYBmhLHP04wt13vTzunCsTTty?= =?utf-8?q?MLj2KrMFEdo5b4rLOdLp+K67T61KRXjrPD1zu91H42yf+DGUjFlWwwA0Fvas4q63Y?= =?utf-8?q?cC6dbTTpjLsVt35EwTWsr79fx9Pk0+ObMtBIrRwq6kbAyedKn2HruJ+5WClNXDZER?= =?utf-8?q?RBhSTdJfFcd8ifbFQLo9JC9lzxJmyDQyuyRo6HUVU00X+qgwM/+cuzZOoLUsf/pGN?= =?utf-8?q?d4Qkaijx0uHgXj2omXeM3pFita7VISyLHOFyYXYSmhz5VXdyBbAHdDaCKYrZfXnGN?= =?utf-8?q?Llyn8XkqRxn9vN+VQdH/7vFiJj1LylKfk22qa2tIli6Bc86gyXGHYqTo/Bw1LPJTv?= =?utf-8?q?xN1VX7aApL096LqsuBcroBHaixNVvpEVRWdf+pARA+rGXhdBHtQgQ3oLH1zmmMt8i?= =?utf-8?q?DPWzLEqgqaxK045cvi/XepdFGDmE5tgCKgsZJjFh0iwTyd295EKgFA1XxcCfsaVkV?= =?utf-8?q?5KS6VpQg9fJKjCEyxICzPx8rB3HEwyb7u5bpgHPUR/iiSxzNcY0sTBg3OJwBP9hzw?= =?utf-8?q?mAYy0aDfWW1WS59YCJpL42xjJ9dWGAedTx8+muDibHtBW3t0pKXZgC/EoZ3vKQrO0?= =?utf-8?q?fa8NNKPwWCBK?= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MN0PR12MB6101.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(376014)(1800799024)(366016); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?q?V1TfEx206eQZAm6GapisP9u1A3AE?= =?utf-8?q?p92XMNiZtwU25WUAvl3wge1+mUn9Ty6ZH0sHvVVZOQVz+tTeO8szcpkOdToTArf4Q?= =?utf-8?q?91E/FaJZOm6DBUIB87vv+SpGZiKXfcKdLDwMTWCeah38EYWtlqOq+iNEp5+eGoKyE?= =?utf-8?q?wDMjGw9Tc7AJpfV3SvrNfT0n5VcipQz28+u914xubHIFtRt+VYP/L0SNlyMAtqFoJ?= =?utf-8?q?vGpwaQu16c3XyF0geBbvucYadqCYuMFhhv8rAXNV/0QewyNcPJNbh0jNy4FmV68+f?= =?utf-8?q?sGETMQ0AF1JDMWJIG0GM38GXGzRv5bzxSZ+/lbg1egUNzS2/qzsSuGXbiZcdFQTF7?= =?utf-8?q?18z1k3aYsmoMzh0ZtbcRerQWaNf++zDL60XT5s2hyYVZ13TrM+KVEn8A2CdVYqZr1?= =?utf-8?q?gS3K8+pTSPOKWeSangjwHJRN2DW3UfANCu5g+6jDJqn1g4RN3GE9jqfPQez1cQBE6?= =?utf-8?q?ndRDxults52ZiR2wR5NE42J+J3ra1XmcIePtp6AnZg5ACahfZaHIBfpdsGRHSkQYZ?= =?utf-8?q?lfkUayeolSc6bfrnKOb9ZW1mF1tY2THg+NmZ3jZYt3+sE2HCwix7sFHiPcJ+LTk6Z?= =?utf-8?q?T74g1d8FaVrtQZqTlJzs7vUYRnUgcIoNvKNcjwc0OxwWMHKGsSQ/TM2jvJztvx/rN?= =?utf-8?q?DWuLQhBjZ4mWAqIintUK5sBmMAOotbCK+OhpLJREFVYeIJnHn7RiJl35oW7ZKfC82?= =?utf-8?q?M677b/f9sehquobHVXH9qfooEX83tO3cba9NsdoGxcB9PDN7z7co6b55V7YcIOG19?= =?utf-8?q?ZEKarPR1hp4MeKdOn6/PWfUyUQkk6v+88lgskyBNL+XKHBcRvwgnVBhTCcBdA8BpH?= =?utf-8?q?2Iftb1uHSMX8XLZMPtnFPhDCntlXs0c7a3w3jThdHWv2h8rYWS0k85evz6qIrYJsg?= =?utf-8?q?cK61AaCP1DSozMlCKScoQ8Rvo9Q3OTSoda/ha0UAVNnJRs3vCdwK4BJhsZxT2jSeg?= =?utf-8?q?Q4rRK2B5RTQEAAjvGu8aZpyqHVxtEy94WhCFQS5fgP4tB/GSwkG7LHTbUFWW/KTXG?= =?utf-8?q?tjzll7s2BdBWH4MONBy+PwoW04WhaH4Ft3F5s+BTP8TDx92hnVySEcDicE8P4Womn?= =?utf-8?q?2bPz14GyPoOeSTh4ju8k5JnLnMIpwfskL0ugGx8IzO5KHNRZkmd/12w72E7nYFk33?= =?utf-8?q?W9K7KdcRLkpV5qHPOcGto6PeJRbUyXiuchEXeW2JfZ9yDj5eHnwxkHHFmB3nl0rXy?= =?utf-8?q?kmi5HqCjg8zbXsmL1hv26+D5ool4XvV8fe3Q935At+ZGpjVYjZ7n4eO8hHYDdpnjS?= =?utf-8?q?MFl6FKN7kjNdGC9m8QJiMwMUDHBJzdfPkNHA8Tfl/nqhaGFVLQvMZUd66Tj3eFFt7?= =?utf-8?q?fvKzFVdXKxSegqjDN62ZM2W2kMmZCt+TXQtybqjqznjgemiJpHB+lYZ/6Yzap2VEr?= =?utf-8?q?FN9JMXWlfVf1b3XfxnC4tyWZHcySNfoZNBkaNKG8Jga05dfKhehu0WeVTr3bmhxW3?= =?utf-8?q?IhipFZ36HooDeTgNR+C9TU6Rr32nWtAOAl304w8TtUDJ8X8UcZvmp0/yxlbQhjdQA?= =?utf-8?q?sUQzV5nSn/ud?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: d15fec8a-cfb9-4d37-9175-08dd72db0c86 X-MS-Exchange-CrossTenant-AuthSource: MN0PR12MB6101.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Apr 2025 18:12:09.1211 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: bHEc5i+iEOpEo2yrGxYITeCQBylNnbXxacNnGY5PCeJFPj4ftGEnkECMe6B8ffLj3HeedsTjUnjmBcqlyMrMqg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR12MB6446 Mika, Recently there are some conversations about wake-up from connect/disconnect happening and I wanted to get some background from you about the current policy set in tb_switch_suspend(). Wake on connect and disconnect are only used for runtime, not for system suspend. Would you be open to adding wake on connect as well for system suspend? This should help enable use cases like plugging in a closed laptop to a dock (which works on Windows). Something like this: Thanks! diff --git a/drivers/thunderbolt/switch.c b/drivers/thunderbolt/switch.c index 6a2116cbb06f..f2f6a085a742 100644 --- a/drivers/thunderbolt/switch.c +++ b/drivers/thunderbolt/switch.c @@ -3599,6 +3599,7 @@ void tb_switch_suspend(struct tb_switch *sw, bool runtime) flags |= TB_WAKE_ON_USB4; flags |= TB_WAKE_ON_USB3 | TB_WAKE_ON_PCIE | TB_WAKE_ON_DP; } else if (device_may_wakeup(&sw->dev)) { + flags |= TB_WAKE_ON_CONNECT; flags |= TB_WAKE_ON_USB4 | TB_WAKE_ON_USB3 | TB_WAKE_ON_PCIE; }