From patchwork Fri Apr 4 01:09:25 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Richard Henderson X-Patchwork-Id: 878187 Delivered-To: patch@linaro.org Received: by 2002:a5d:6dae:0:b0:38f:210b:807b with SMTP id u14csp3552201wrs; Thu, 3 Apr 2025 18:09:54 -0700 (PDT) X-Forwarded-Encrypted: i=2; AJvYcCUw4xWOGcdULr5O7/vVoQGqbEc+qT9ygglhzRpKcVpzMiY788jUj0HburO1YWjauijgbJs5cQ==@linaro.org X-Google-Smtp-Source: AGHT+IE3fbVG2Plsp3KqctCxJ77mup8+Xv4+jNMvUFrIX49nXkFzhZS4jtoqfi4AK+UvU+6UAC0J X-Received: by 2002:ac8:5a4a:0:b0:476:9b34:fe82 with SMTP id d75a77b69052e-479249512f5mr22188071cf.31.1743728994475; Thu, 03 Apr 2025 18:09:54 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1743728994; cv=none; d=google.com; s=arc-20240605; b=cICf0YTwzA0gDQzhNPx5F18CQUU8AibibnQpOlvoj0aSn/dTi0/OoLRpFhsd/2aFVs FaXParmnKsys5emcFmyARvYC6LvH64k9X7W0naCj39WCjbVWX5k15t0xiBB4DzY3XoLD UUl0J3xD4m9Yz4ZiKA/QjFuq/0fR/YHff8sNwZn7NJI54rjpLTgR6llgCktbDkICdbXR VHslbUK5dAAFvpM/enq4wt917EwhwWJj7Tc+x2KGRMA7WAoPihY+B2D/OthQnQAwogpo 4CdiwS55RqpstRHGieq4qmYlqhWYxkp45tt9P6DzPJ5Ujf5IeP4o4A/cc20YUBTIyC03 Js0g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=diH6J4hofBmrfzs6sIeDZ95DC3OrtgE6crTHghEG7+s=; fh=x0ZzhGsr3JmrPFRYRRRkJitROYWL5gGpezkblBLW0U0=; b=aKxKHrO0+iJdeZisxBBS5Fpa1Ft9b3xwC9F6TXvJjV8kjFOYpM6JcJqhCNrbf89QVh 7J54pzhP/At4IjwTAKBAnajlDVSfrRY7+PPNKmUPZ6s5nfdyLtz/jXIsucZMb8aPviJK ASgTtfce9smAyR4IvrRo+SMHihs8KL1wVSyhBKvlM39Zad5lAd/4cUsMGfvY8uAfhGvm YZ47lcuyHEteDqPy6yygh4gqBestWQWZxhLv0a8DnB+mRrydBJSe3UUyN7K+Vj3HYJnw d7S0XRlVErPKg5vU4QgUCMp7BKZ0VWVEstIq2saPsffstJusWlkKWShmfXUwAKFhUbIV iyRg==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=ABzPzSOX; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org; dara=neutral header.i=@linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id af79cd13be357-7c76ea9046dsi220769085a.386.2025.04.03.18.09.54 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Thu, 03 Apr 2025 18:09:54 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=ABzPzSOX; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org; dara=neutral header.i=@linaro.org Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1u0VYw-0008IC-KB; Thu, 03 Apr 2025 21:09:39 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1u0VYv-0008Hu-Ea for qemu-devel@nongnu.org; Thu, 03 Apr 2025 21:09:37 -0400 Received: from mail-pf1-x42b.google.com ([2607:f8b0:4864:20::42b]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1u0VYs-000815-UB for qemu-devel@nongnu.org; Thu, 03 Apr 2025 21:09:37 -0400 Received: by mail-pf1-x42b.google.com with SMTP id d2e1a72fcca58-72d3b48d2ffso1654677b3a.2 for ; Thu, 03 Apr 2025 18:09:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1743728973; x=1744333773; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=diH6J4hofBmrfzs6sIeDZ95DC3OrtgE6crTHghEG7+s=; b=ABzPzSOXmfE4BFkJC8Cof5GE8klzGF4axLSMMviLuP/7yF63XE86fB0IzXxvyqGsp6 ZBUf5nmoa2VA2PqUeKHC1lZcHpRZuMvSS3Uqj7/m4GuTvWrXXUHKAjeKEoHCEr4va+6Q l9BNgHDjdkZi4FFkdnhTgbbaRgZ5fCAvk7FxPIkmkSnKkX9/jePWYbTtDrcFugi2csjA UTgsgbg9flpSw/79S8ddA0rYb7qcOhIwJ/MSp08rm4N1xfVapsMUaNshNCU+ZcMyxX2d Fg7jN8kRnYZq93twHmm73cuNCF3bdo58w3UMU+4QblOqEpuyorSs2kzmR4SmOOLGR4qE fajQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1743728973; x=1744333773; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=diH6J4hofBmrfzs6sIeDZ95DC3OrtgE6crTHghEG7+s=; b=MS1+N8FzMzrdD65sKxgZNqrjCt4sSFyH9YitaYh4x1kqJNCuUL79bqDtngh2jparii ah7TEDs+hm0YNrVlXhls3fXiAHWupXHO5N5fAihcJjb3RUsHcvOtUQUOhse3bFJ/9u1H pSowQyNN0Job0v55yW3MVIw9kHePAbfxw1KNdIqAUzeHRh/51/VZ486jYo4JVNjGYf94 IavBLaGdW5yLSXL7KjZRqMq4hThvsJXxvuSzSHXUduZRoki86yWuZTz9wXLrDpkChbBr hwyB7ODdt/kUuyZVts2cq7n3dRiUWXmiaU/xnHT+NodIBCpFU0hTBRRs8Wa7PEiC7yl8 jh4A== X-Gm-Message-State: AOJu0YwJ6/Sc2sI3/7V9zXbjF8pHHabdXqnb3fterX0Q18Y6rvHMUk6E +fHDGNskfxawbGCQQwGzUzicLUO9oEox8L3DeyQc0BnbHUNKm/4xU11bagY1AeIwVi1MQWym3ez k X-Gm-Gg: ASbGncvWTAF76ic3HGZQFk5Yc0X8VwsU5GM/cxVsfgmCkLzWTn5/8C6ye7j7mu4/2mK iKEreX7CD1IlSvU7+WLji8YU0yQki1kIjvXrw0ew9GkM74JmRb0nhkPmzxTXQBdx5xQntn52caU 52lButRaFK1LOXyatDmcIKXggCtv6x1QMKbK9RikFT7tPw3caYhyJ9jdAd4IkO0X412mcMmsaZS qzUhKSUsirCQoy9MQzhpoWFJuXCt6dDdsgvU6FD4ZGw6kaY/Jo3CIr+wd3gkUk4IVeXChn7mbVT A9oxfI4Kkt3WVffgP9984vL0tiAXJxa1y7tu+Yjwlug1AiqtGzg= X-Received: by 2002:a05:6a00:228e:b0:736:62a8:e52d with SMTP id d2e1a72fcca58-739e4b5c16fmr2348934b3a.12.1743728973165; Thu, 03 Apr 2025 18:09:33 -0700 (PDT) Received: from stoup.. ([75.147.178.105]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-739d97ee2d9sm2171755b3a.39.2025.04.03.18.09.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 03 Apr 2025 18:09:32 -0700 (PDT) From: Richard Henderson To: qemu-devel@nongnu.org Cc: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= , Michael Tokarev , Helge Konetzka Subject: [PULL 1/6] tcg: Allocate TEMP_VAL_MEM frame in temp_load() Date: Thu, 3 Apr 2025 18:09:25 -0700 Message-ID: <20250404010930.164329-2-richard.henderson@linaro.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250404010930.164329-1-richard.henderson@linaro.org> References: <20250404010930.164329-1-richard.henderson@linaro.org> MIME-Version: 1.0 Received-SPF: pass client-ip=2607:f8b0:4864:20::42b; envelope-from=richard.henderson@linaro.org; helo=mail-pf1-x42b.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: qemu-devel-bounces+patch=linaro.org@nongnu.org From: Philippe Mathieu-Daudé Be sure to allocate the temp frame if it wasn't. In the resolved issues, incomplete dead code elimination left a load at the top of an unreachable loop. We simply need to allocate the stack slot to avoid crashing. Fixes: c896fe29d6c ("TCG code generator") Reported-by: Michael Tokarev Reported-by: Helge Konetzka Resolves: https://gitlab.com/qemu-project/qemu/-/issues/2891 Resolves: https://gitlab.com/qemu-project/qemu/-/issues/2899 Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Richard Henderson Signed-off-by: Richard Henderson Message-ID: <20250401144332.41615-1-philmd@linaro.org> --- tcg/tcg.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/tcg/tcg.c b/tcg/tcg.c index e8950df2ad..dfd48b8264 100644 --- a/tcg/tcg.c +++ b/tcg/tcg.c @@ -4671,6 +4671,9 @@ static void temp_load(TCGContext *s, TCGTemp *ts, TCGRegSet desired_regs, ts->mem_coherent = 0; break; case TEMP_VAL_MEM: + if (!ts->mem_allocated) { + temp_allocate_frame(s, ts); + } reg = tcg_reg_alloc(s, desired_regs, allocated_regs, preferred_regs, ts->indirect_base); tcg_out_ld(s, ts->type, reg, ts->mem_base->reg, ts->mem_offset); From patchwork Fri Apr 4 01:09:26 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Richard Henderson X-Patchwork-Id: 878190 Delivered-To: patch@linaro.org Received: by 2002:a5d:6dae:0:b0:38f:210b:807b with SMTP id u14csp3552367wrs; Thu, 3 Apr 2025 18:10:19 -0700 (PDT) X-Forwarded-Encrypted: i=2; AJvYcCUCQ0j7cKC/+BM2nxVQjNQGGbeovo1m/GWHrqih+9D/yKQTZ4nRYJyhULM26vc7WH2HXKJqwA==@linaro.org X-Google-Smtp-Source: AGHT+IGjKnCD2Wrxq9lpldNh/Ppko4OAi/TeSDSkn599qMt6kKprFNyuC3tHM6sMtW7GrnzlyCOH X-Received: by 2002:a05:620a:43a2:b0:7c3:cde7:a685 with SMTP id af79cd13be357-7c774d2c989mr248989685a.13.1743729019016; Thu, 03 Apr 2025 18:10:19 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1743729019; cv=none; d=google.com; s=arc-20240605; b=BjhPeVsGX6mGiWANniDdkq/NctAPn2YIugPK/NpcUpqcoTj0RX/f0IFl3d7Gl+Mu8O Xx5PUwccK4aQCONP+kTW2/yFdXSTp86v0Gr4rQFpjUakI3C/BCGrUU3iaPO22X11Sl+z vHix+aZyR874HlZJD0o89UhvQBnj1Un87Nl0SadXeIoPZstescUuxuRxU7y8RBH4Gu6Z kYGZHqcmHo98Up9sLQTZd0DA/DEUHKuzwXmPjtoaXLyVURu00UByVococVGDVAotwyMQ K2O/Ennv2w3MPqmnea2vUw1NDSMDdkLC9A43/G8iKMRWEsUnpjTqbPYRUfKJn21GZ0yS z6hg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=CU6NEy9CLtG6+OKRjCwFFP8/1QLHp65Fq8Qbm2hbk8U=; fh=jtFWq6letzT6F3FCTxnWN2OYP/gV3kW635YgGyA8cFM=; b=NUBbbdJNAZngG7Cc6odaQPfUuUjrQgL1OpEcnswyNgHUQh0SO/CeQ5dMxf9HV9XVMD Q8SxPS0Z6cZCiGODxwRH37cqd3zaR+EBUrH2pLpCT4I2HIvVSqXrFwE6L/l2DovKxEJV vclXU+xUBNDpshoDRyb7mXr8bQDkYGARsyNMYzJbu85BTUa95cBJP1GPI3EX17axgt14 Kbt2D77vJSPyugNxPlOdtsbNOJ6q/OZhsJw1IiWEQN4ek37/Tk4rKsfm+zmZq/HzyLp6 XT3ZyVQlb3dGF5UFEkEvxtu/aKYtWBRcIpZymrv0g1UuijISQKAs4+nJDpJTR6xcltLz UsEA==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=AxChLbVX; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org; dara=neutral header.i=@linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id d75a77b69052e-4791b07c0dfsi20986981cf.145.2025.04.03.18.10.18 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Thu, 03 Apr 2025 18:10:19 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=AxChLbVX; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org; dara=neutral header.i=@linaro.org Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1u0VZ1-0008J8-4Z; Thu, 03 Apr 2025 21:09:43 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1u0VYw-0008IF-G9 for qemu-devel@nongnu.org; Thu, 03 Apr 2025 21:09:38 -0400 Received: from mail-pf1-x432.google.com ([2607:f8b0:4864:20::432]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1u0VYt-000817-Ek for qemu-devel@nongnu.org; Thu, 03 Apr 2025 21:09:37 -0400 Received: by mail-pf1-x432.google.com with SMTP id d2e1a72fcca58-7370a2d1981so1267569b3a.2 for ; Thu, 03 Apr 2025 18:09:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1743728974; x=1744333774; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=CU6NEy9CLtG6+OKRjCwFFP8/1QLHp65Fq8Qbm2hbk8U=; b=AxChLbVX7DErS5F0R0WJ2oAhgezkGAGl7NSUoHxbazXDb5Gyy6bEGmx7S5G/47ChGo yFC+QYWNE4Gl2DiVU/Y/tqEaNrUZM1R42ILELM4u2ISMQLP4NtmCq4LIEZatn6JodkH2 Ni9krHkgFtXjrfS/Yxz3FYFvPWfKZk30OflYTKwvzULElwffR+LB+gcqvrw1BHTIX1FH 7DutCeGHINKoK5Yf7Q4WbDiZUugfcOps6KR8MdriPLhQFaWghmlbz7UsPAXSXYREsJr7 gUOkvO+CbgltdYTMo94Q4Z2m1qwSutj1r2xonY661ihctGrasfG4PH08iH9ivLQY5rpa sOQw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1743728974; x=1744333774; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=CU6NEy9CLtG6+OKRjCwFFP8/1QLHp65Fq8Qbm2hbk8U=; b=C5QN2Wj7PwL/rEEBrJ+1pZQS4CxeCiXJVfOb8oB9E6njAII6U0VR5SBhob2+jNkHNW KJp/HkHJZFOu/3x6cHBKkbZx57eSZlx/gdXtCLSnTArG8URKBy9ODwQoLWDKlLhIG4cb B7Yj7YZRBG/KyKzLG+NNfXEIb/NekVKp6N39ON2s2srKctg8fRRSLertQm6aLzMid3G0 YxhKGcNgbXCcDIXWqKJRif1xSgZbEFVh9A+UsKeOTxvoQmCYTasXuxZ2EMIMcd+/S9na VLZ8MEu5L1IemILceK0EY/Oj4gimGhRT/39+IOep/63efuSKvIRK0n6K+zgdTMM1QJyd pG4A== X-Gm-Message-State: AOJu0YyIEU7BLPlYOdeno6mGqGaShZZmE+BPZnw2EuyXz6yXCDa4+YWa Sjuq9Bu5PfRi4ezezahV0Pv7j0BfGApCp6I3d4yrTvlubQ5OuCeK7M3Z8SR2cJz4dDMlnZNcZ6Y 7 X-Gm-Gg: ASbGncv2WPPknAfW/lko/fZque2T3ULYEjrDkiMB9PXOdf09SDEJRqChHB9CHv/eVlV HMROADOGr6/YEBF+KCKsPiaQhVSAbwSlRHtiUJMl6MesRmrS81Oodj4lATRRZytMi+/Fog9wh4Y 0VtXWiIK3+EpXbVNXcb5zqY/ef40tEGupHLRI+QUI9ZYEsHt0sfpfwAX2qdPUSzUMKOfjYh3ovo GWoLQ/QLFIEHJGkpMdtxkywh9GRKc/KLAW7nG1fwBhQN3MANNll7x7Ez24JAQvZDngyUYLTRVzQ 9oY89Qw7rKq+2b7CUjs1sSMhx0Zpmw4GGSJD8cR9VgmMOofM8bw= X-Received: by 2002:a05:6a20:7f9e:b0:1f5:97c3:41b9 with SMTP id adf61e73a8af0-2010444e36dmr1860961637.5.1743728973975; Thu, 03 Apr 2025 18:09:33 -0700 (PDT) Received: from stoup.. ([75.147.178.105]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-739d97ee2d9sm2171755b3a.39.2025.04.03.18.09.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 03 Apr 2025 18:09:33 -0700 (PDT) From: Richard Henderson To: qemu-devel@nongnu.org Cc: Pierrick Bouvier , =?utf-8?q?Alex_Benn?= =?utf-8?q?=C3=A9e?= , =?utf-8?q?Philippe_Mathieu-Da?= =?utf-8?q?ud=C3=A9?= , "Michael S . Tsirkin" Subject: [PULL 2/6] tests/functional/test_aarch64_rme_virt: fix sporadic failure Date: Thu, 3 Apr 2025 18:09:26 -0700 Message-ID: <20250404010930.164329-3-richard.henderson@linaro.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250404010930.164329-1-richard.henderson@linaro.org> References: <20250404010930.164329-1-richard.henderson@linaro.org> MIME-Version: 1.0 Received-SPF: pass client-ip=2607:f8b0:4864:20::432; envelope-from=richard.henderson@linaro.org; helo=mail-pf1-x432.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: qemu-devel-bounces+patch=linaro.org@nongnu.org From: Pierrick Bouvier This test was randomly failing on our CI, and on dev machines, especially with QEMU debug builds. >From the information collected, it's related to an implementation choice in edk2 QEMU virt support. The workaround is to disable KASLR, to avoid accessing protected memory. Note: this is *not* needed for the similar test_aarch64_rme_sbsaref. More information is available on the associated GitLab issue. Resolves: https://gitlab.com/qemu-project/qemu/-/issues/2823 Signed-off-by: Pierrick Bouvier Reviewed-by: Alex Bennée Reviewed-by: Richard Henderson Message-ID: <20250328183816.2687925-1-pierrick.bouvier@linaro.org> Signed-off-by: Philippe Mathieu-Daudé Acked-by: Michael S. Tsirkin Signed-off-by: Richard Henderson Message-ID: <20250403203241.46692-2-philmd@linaro.org> --- tests/functional/test_aarch64_rme_virt.py | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/tests/functional/test_aarch64_rme_virt.py b/tests/functional/test_aarch64_rme_virt.py index f4ad4d33d5..a1abf584f0 100755 --- a/tests/functional/test_aarch64_rme_virt.py +++ b/tests/functional/test_aarch64_rme_virt.py @@ -87,7 +87,9 @@ def test_aarch64_rme_virt(self): self.vm.add_args('-fsdev', f'local,security_model=none,path={rme_stack},id=shr0') self.vm.add_args('-device', 'virtio-net-pci,netdev=net0') self.vm.add_args('-netdev', 'user,id=net0') - self.vm.add_args('-append', 'root=/dev/vda') + # We need to add nokaslr to avoid triggering this sporadic bug: + # https://gitlab.com/qemu-project/qemu/-/issues/2823 + self.vm.add_args('-append', 'root=/dev/vda nokaslr') self.vm.launch() # Wait for host VM boot to complete. From patchwork Fri Apr 4 01:09:27 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Richard Henderson X-Patchwork-Id: 878191 Delivered-To: patch@linaro.org Received: by 2002:a5d:6dae:0:b0:38f:210b:807b with SMTP id u14csp3552442wrs; Thu, 3 Apr 2025 18:10:33 -0700 (PDT) X-Forwarded-Encrypted: i=2; AJvYcCV+yJ7RYVhXNhoJi0Zm0tXIddYFWNVASv5nb0V+SEhqbmOUNGvuMv1YBK3+8D3pqocPIV913g==@linaro.org X-Google-Smtp-Source: AGHT+IGZIn1tLekqonfJe5BrlAoxUdTKjm1T4isBR1opYEQYMExxFxjdJem5lFUgsplAMfeCu3Ll X-Received: by 2002:a05:620a:190d:b0:7c5:562d:ccfa with SMTP id af79cd13be357-7c774e004bfmr238142685a.36.1743729033741; Thu, 03 Apr 2025 18:10:33 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1743729033; cv=none; d=google.com; s=arc-20240605; b=WAOulOiEX1EBYO+pAbePfk1W8AJyrzL6+/lJaiGfGkrYSC6akscDdGcwsRnv/15kIK gGlvuAqTCmYTQBIMGlj4iu988j1r3dg17d6KjqZnC6dPha1r5gH/VI58Us0/tdKb1OyV 8dV+I6wRD6AdlL8QepYu0unzQxx0K1n3NcxnsoBQiggjUE6AP8F8+9ODZKfp0gCHp0mD 5lThcdCaXuvdo9zaqF9o7cFwu2xfrS1ioT+jnmZA/ugHPt2iwc2mpNa70MwNy4g7OuzS VidkedSGW8q6PRNfio7vSN4MxNkier5XSdILHjvxnP444JyuWJ8pDo5T6Hob7I0nMnSo jOvQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=4BGzGdi+Q8YtuavjJZkyQGsY98kSfnKOoGLNVstGZOM=; fh=PF9ef/o3VlrPqKSIkD2nmbLrn/J9ixCbUNSAyHUdgCQ=; b=E3xA+pXmq+DHLAKpbNGC6EMibBbUu2u+CETXEQU2pD/r3F3Ng0rOJadjbxXiZxDZ/7 /mYP4cTJwQFV6tXp/J68LMcIlRXuizlMjFaAqAXmPzSzU8LjPlA7uOh0A2n91kKdlmTH /mqRLvyQPTSdLM2aYheyuB84OEcXts94kYRmGXoRMIr25FsAMV93HrgJMMUSBkuTmrjv NozTxzOIqkBt59ZtxkCIZQAQXrQnT7tX7+tJ9y/0OPIwFdxLes9ofeTE/2GW/wOKCujl LM5E/IttNytZz44zttsSa50LG56NUGdJB9SvwaOL2eOx5ea0xbQlyzcl0dLs0qntRtkO FeTA==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=kTwQ7i7c; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org; dara=neutral header.i=@linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id af79cd13be357-7c76e958f3asi218492485a.141.2025.04.03.18.10.33 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Thu, 03 Apr 2025 18:10:33 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=kTwQ7i7c; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org; dara=neutral header.i=@linaro.org Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1u0VZ2-0008KK-DA; Thu, 03 Apr 2025 21:09:44 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1u0VYw-0008IE-Fo for qemu-devel@nongnu.org; Thu, 03 Apr 2025 21:09:38 -0400 Received: from mail-pl1-x633.google.com ([2607:f8b0:4864:20::633]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1u0VYu-00081H-Gv for qemu-devel@nongnu.org; Thu, 03 Apr 2025 21:09:37 -0400 Received: by mail-pl1-x633.google.com with SMTP id d9443c01a7336-2241053582dso21836595ad.1 for ; Thu, 03 Apr 2025 18:09:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1743728975; x=1744333775; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=4BGzGdi+Q8YtuavjJZkyQGsY98kSfnKOoGLNVstGZOM=; b=kTwQ7i7cFyKSF+biVITBYYh/kmhnv25NkMwrQ3VAR3OEffXHTNHklDYVefGjGTkWzF eXkdgJZom5MDvhcxFbKSAUrly9YR8kpNwfDJQ66qq+sUmR5wLo2N9wfa+XzBGIVqO4Cp ep40RuAELOxsSVofP96/X67FoCRi8Y8XWF6r+uDor43QRa52Iw2W60mGYIJeTQJTOE+5 kWlNSdGG01vUyloVZufrSQkzO19Hzs/VWm+PudmmAxkQhRiJLF6/v5/FGcyhZbrqjtko tQMReF1I2FyxDTyHpwfKu5HheFzAWmG44ycBfVrL/n3LQBlOrF31SfQORzCJqpUFQzEM XF3A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1743728975; x=1744333775; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=4BGzGdi+Q8YtuavjJZkyQGsY98kSfnKOoGLNVstGZOM=; b=Qf+yl6rgL3Rbebe++xwsTFEse74QdgLQCIEFB9B3av1HR1dTdRRv7A45Gtin6Cvurn 7zBYOkvGkbWiphCBNI//6y/iscHndh0w6qvzB+3t5g8r5737b4ctg4nXlh50gxWKJCI+ 2r2V3IT+j9Kd3DSf/7xUSGpqUE3DFPEzf71Q00utUaV2+8nEow9t6mzy3IbZUmNKNkCf 4uoZfBOPfpLmx8kn0X7a61kf4kKgvFrcNNwh9reLnw4bgBGCQ2qhRBtAn6kOa3cAEPfD 1NzieG5ecWU2WTY4lvu2mZq6wxtTKW+eA7cCsvHa5vyfBV0r9j1UOHFG0w/FZGCDOhX1 O5eg== X-Gm-Message-State: AOJu0Yy7Z60WHDEKrf3DIAuc0JILgQ4KJFifJUk2QU4R9QNXw6gsYl1K 5PvgSTSH27OXI3FD/6gz7nn+8oVI18gDrolMaQF8Xp+6eQYjMezVdq/C9dQuWrySLOlxxLw2CaR b X-Gm-Gg: ASbGncuoX+7fJlEuAlzi7i3cdCnz6K8i8yBzHJzbVvEVNZNcxHxeidHwX1kMx4MUgGZ S0dBB3zS8xjIeLAB3raOpRw2PVkLjmfdFC3ijbj+8tyG16YZ0iZ1FFPw44jaCy2V6q86cWbtQm1 Ktq1f4tM3BGJEvsLOwAlh/gX3l4KcO02ZPzJT15PJ3GAXcrYvNJ/4oslcQFAWqEVNugYVeR1E/V 787zTHfJn1sct9VFcRBmHaRIeGfl/KCFAhGlvfF5Bpgs+65FGfIei5kpXjn+M0RyIECKRhmYme3 kkYzVvK8l010/Z8DQJM6W9pYzb7iev/P9ZvHlhfPud+pCy+vW+0= X-Received: by 2002:a17:902:ef0a:b0:229:1717:8812 with SMTP id d9443c01a7336-22a89eac8d3mr18321405ad.0.1743728974962; Thu, 03 Apr 2025 18:09:34 -0700 (PDT) Received: from stoup.. ([75.147.178.105]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-739d97ee2d9sm2171755b3a.39.2025.04.03.18.09.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 03 Apr 2025 18:09:34 -0700 (PDT) From: Richard Henderson To: qemu-devel@nongnu.org Cc: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= , "Michael S . Tsirkin" Subject: [PULL 3/6] tests/functional: Add a decorator for skipping tests on particular OS Date: Thu, 3 Apr 2025 18:09:27 -0700 Message-ID: <20250404010930.164329-4-richard.henderson@linaro.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250404010930.164329-1-richard.henderson@linaro.org> References: <20250404010930.164329-1-richard.henderson@linaro.org> MIME-Version: 1.0 Received-SPF: pass client-ip=2607:f8b0:4864:20::633; envelope-from=richard.henderson@linaro.org; helo=mail-pl1-x633.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: qemu-devel-bounces+patch=linaro.org@nongnu.org From: Philippe Mathieu-Daudé Since tests might be failing on some operating systems, introduce the skipIfOperatingSystem() decorator. Acked-by: Michael S. Tsirkin Reviewed-by: Richard Henderson Signed-off-by: Philippe Mathieu-Daudé Signed-off-by: Richard Henderson Message-ID: <20250403203241.46692-3-philmd@linaro.org> --- tests/functional/qemu_test/__init__.py | 2 +- tests/functional/qemu_test/decorators.py | 15 ++++++++++++++- 2 files changed, 15 insertions(+), 2 deletions(-) diff --git a/tests/functional/qemu_test/__init__.py b/tests/functional/qemu_test/__init__.py index 45f7befa37..af41c2c6a2 100644 --- a/tests/functional/qemu_test/__init__.py +++ b/tests/functional/qemu_test/__init__.py @@ -15,6 +15,6 @@ from .linuxkernel import LinuxKernelTest from .decorators import skipIfMissingCommands, skipIfNotMachine, \ skipFlakyTest, skipUntrustedTest, skipBigDataTest, skipSlowTest, \ - skipIfMissingImports + skipIfMissingImports, skipIfOperatingSystem from .archive import archive_extract from .uncompress import uncompress diff --git a/tests/functional/qemu_test/decorators.py b/tests/functional/qemu_test/decorators.py index 1651eb739a..50d29de533 100644 --- a/tests/functional/qemu_test/decorators.py +++ b/tests/functional/qemu_test/decorators.py @@ -5,7 +5,7 @@ import importlib import os import platform -from unittest import skipUnless +from unittest import skipIf, skipUnless from .cmd import which @@ -26,6 +26,19 @@ def skipIfMissingCommands(*args): return skipUnless(has_cmds, 'required command(s) "%s" not installed' % ", ".join(args)) +''' +Decorator to skip execution of a test if the current +host operating system does match one of the prohibited +ones. +Example + + @skipIfOperatingSystem("Linux", "Darwin") +''' +def skipIfOperatingSystem(*args): + return skipIf(platform.system() in args, + 'running on an OS (%s) that is not able to run this test' % + ", ".join(args)) + ''' Decorator to skip execution of a test if the current host machine does not match one of the permitted From patchwork Fri Apr 4 01:09:28 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Richard Henderson X-Patchwork-Id: 878193 Delivered-To: patch@linaro.org Received: by 2002:a5d:6dae:0:b0:38f:210b:807b with SMTP id u14csp3552561wrs; Thu, 3 Apr 2025 18:10:58 -0700 (PDT) X-Forwarded-Encrypted: i=2; AJvYcCXE7rP4H3vWycqdcwr6cJ4vGAJ0An1BH8j4E5E07Wp/8V9RDEJWxB+A0k7Ydzwdr6MvFdSHyg==@linaro.org X-Google-Smtp-Source: AGHT+IFR+eC/DEXckmFrIW2Cwh7Mui2gU2Wcd0dNcnqeCwJvG/4QNp9z4Wdwj5LlsImtaUTUTzh/ X-Received: by 2002:ad4:5b8f:0:b0:6e8:ec85:831c with SMTP id 6a1803df08f44-6f01e7944bdmr22255806d6.35.1743729058062; Thu, 03 Apr 2025 18:10:58 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1743729058; cv=none; d=google.com; s=arc-20240605; b=YQ11X+Z/Ej0U6m9Ph4DOGRCUR0c6sXZGrMs5kjgvw0rqyRb609Zxsu8riq2NkwnAiB WR9fVX3PWRWHzTrGzdCyHG48vlFpXtWjqOMkTJAGoD4kKJxhwFRC+XA7YfQjrs3ZKNQb 75LJJMdQlp5uRabuphda7hyuTv8GWz0D9IyyisVbrrraqnOkCYpon43azg6rzXMMccFZ fytP0t0073MOaS8qBNWNWxjJN++XixdftqutcKXS1Y0qdJa7rogvz8T2j/GD88lCpsRX Sy0nbXrckZ6t4vjfRpXWyHOb8aDTfxsfY1s+5KywJiGG//gaAVtHimZ9hOtFwiQlJjEl 0kfQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=VIRfp04i627hlfQrwyzx4Wu6n5OG/fKCaEKAfQ9ho1s=; fh=PF9ef/o3VlrPqKSIkD2nmbLrn/J9ixCbUNSAyHUdgCQ=; b=dLuvJmxvjEGQIg50sZRR/euyjrq0+t4huOnj8Fv41nLNJdsXi9jdgLk5THtnxF06Nt BAy0tXBQPby1ddqo+QtvwCaPFpCvyNnEhUiO06u4pmpUF1QzAwOUrQ50YcKbze5TNuEp pkBJQr9ZR7HkIH3q8UlCGOa0eMhgWdLVaT0dDFGHxD+7d384bNdAIee8cmVIrc1OgSBO YyoO0AtdncxM5puaFmEXowPGjiwS1otSyBwkfPGt6eL3zShxoZYtb73pue9L3eaXiyst DwakInLJC5RhjA+KbGNSrFghAc1Wv1dVqQrxE9D5UoIXRCbdN+n9qRQET9OSVhGfNUQ8 ESpA==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=os9Z4wzw; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org; dara=neutral header.i=@linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id 6a1803df08f44-6ef0f10d255si21759446d6.174.2025.04.03.18.10.57 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Thu, 03 Apr 2025 18:10:58 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=os9Z4wzw; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org; dara=neutral header.i=@linaro.org Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1u0VZ2-0008KM-F8; Thu, 03 Apr 2025 21:09:44 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1u0VYz-0008J0-24 for qemu-devel@nongnu.org; Thu, 03 Apr 2025 21:09:41 -0400 Received: from mail-pf1-x432.google.com ([2607:f8b0:4864:20::432]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1u0VYw-00081f-8c for qemu-devel@nongnu.org; Thu, 03 Apr 2025 21:09:40 -0400 Received: by mail-pf1-x432.google.com with SMTP id d2e1a72fcca58-736b34a71a1so1834697b3a.0 for ; Thu, 03 Apr 2025 18:09:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1743728976; x=1744333776; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=VIRfp04i627hlfQrwyzx4Wu6n5OG/fKCaEKAfQ9ho1s=; b=os9Z4wzwCFxxIjWXVcpDC3LkzkhSfUncTEgVtX0TUzAfLkDye1dpUrahlOX9UolMcr zJixZHBt8hiewdHHmWfSr09TqYParESXroz1fhxi3at1MQlZyla9Kc6WWFbVwSjYtKqK oLI2VVlxCIrdJIRcH8TRXZ70WzpXvY+A5Y08XE8jKnHVN5WdZwviFrZCN3xAG18Pns0b f/LlvwSQBNwpjVmwxjClk9JpajZtQr/1gMC+LoW/yAvyUDrj3wChlXQBr+DSGBLfSgy2 jhS4pywyN8cTlD2ZU5c6tHb5IbR3YLXNscsg3HDeJxCpVntFeVIIe1kNcAiDAyjI+z20 JeZA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1743728976; x=1744333776; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=VIRfp04i627hlfQrwyzx4Wu6n5OG/fKCaEKAfQ9ho1s=; b=c1A5lygN50tOtPFWPVZhpsIJd+QBk8+77Y0gkXb6wSWRg7eZxST3ahkqRDL15i2XW0 KuQStN+//e3T8/CPvjMKG3wCA0fQg8SD5KNCuQQ/zOBZBBChti377uY8krcZJeRT2XU+ xzIw1AVJPwuncBbMJIqtIFboRqROKjP8ii8pdrPBX0iQ0OdZb9IbSipxy0oX2cwJ7uv/ aYU1rovsi97DLZIP64FsipbRxZH1tUK5AaRNp0XsinZH6bdCreuskCX6u1J5bXjSL1cg 9K8JLcFDzdOnX7ArcfNpB4mN2CvR8I8qRyFtRGp07KFOQ0djQbeucMvGbd7Qv8+QqHt+ ftNg== X-Gm-Message-State: AOJu0YxjPEYIR0a5GLe54fwk0ddheEoLDzUVtlucdsrYSfBnHL6qgp7/ r0r1w4eFQy8UY8OjbIzhfYn4NOP9FSXDtD0Sp7/SfiwahI6L0kdcqptDsDlTisWIO8z4OGAZOfz W X-Gm-Gg: ASbGncvEt88qAFkDVcrV2gf8DYfE2Y0O+Ij74JV7Eg9jasZO32GA1QdZauBwgWcN/Ks XrtR3DmAtgxtCeMIHOv1fj/TmMyxWUXhDz+2BNDgO1T+vexnDnY5cSjFQW/m/YRxGzmy8PVCf/5 msMx4AvJGJ+yF4+gry9xCZ4iCdGup76bsn/ujtNPuvTZOFt1k21NTw875q/VPBRFzouoiVhdIrf USRN/FNNCZLjrHod4gyeT89uAZpCLMO6HivXheDaZoytJbdVprJXM37LoV2h3dgz0ZoRNkwM+VV t7dgm7pHhXABmG5MpEqy5YINEOqWzyOjWww2hI1HlWpXNevTWT0= X-Received: by 2002:a05:6a00:1147:b0:736:a973:748 with SMTP id d2e1a72fcca58-739e4f79870mr1895398b3a.22.1743728975961; Thu, 03 Apr 2025 18:09:35 -0700 (PDT) Received: from stoup.. ([75.147.178.105]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-739d97ee2d9sm2171755b3a.39.2025.04.03.18.09.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 03 Apr 2025 18:09:35 -0700 (PDT) From: Richard Henderson To: qemu-devel@nongnu.org Cc: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= , "Michael S . Tsirkin" Subject: [PULL 4/6] tests/functional: Skip aarch64_replay test on macOS Date: Thu, 3 Apr 2025 18:09:28 -0700 Message-ID: <20250404010930.164329-5-richard.henderson@linaro.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250404010930.164329-1-richard.henderson@linaro.org> References: <20250404010930.164329-1-richard.henderson@linaro.org> MIME-Version: 1.0 Received-SPF: pass client-ip=2607:f8b0:4864:20::432; envelope-from=richard.henderson@linaro.org; helo=mail-pf1-x432.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: qemu-devel-bounces+patch=linaro.org@nongnu.org From: Philippe Mathieu-Daudé As of v10.0.0-rc2 this test is still failing on macos: $ make check-functional-aarch64 V=1 ... ERROR:../../replay/replay-internal.c:235:replay_mutex_unlock: assertion failed: (replay_mutex_locked()) Bail out! ERROR:../../replay/replay-internal.c:235:replay_mutex_unlock: assertion failed: (replay_mutex_locked()) This is tracked as https://gitlab.com/qemu-project/qemu/-/issues/2907 Signed-off-by: Philippe Mathieu-Daudé Acked-by: Michael S. Tsirkin Acked-by: Richard Henderson Signed-off-by: Richard Henderson Message-ID: <20250403203241.46692-4-philmd@linaro.org> --- tests/functional/test_aarch64_replay.py | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/tests/functional/test_aarch64_replay.py b/tests/functional/test_aarch64_replay.py index 04cde433bc..029fef3cbf 100755 --- a/tests/functional/test_aarch64_replay.py +++ b/tests/functional/test_aarch64_replay.py @@ -5,7 +5,7 @@ # # SPDX-License-Identifier: GPL-2.0-or-later -from qemu_test import Asset +from qemu_test import Asset, skipIfOperatingSystem from replay_kernel import ReplayKernelBase @@ -16,6 +16,8 @@ class Aarch64Replay(ReplayKernelBase): 'releases/29/Everything/aarch64/os/images/pxeboot/vmlinuz'), '7e1430b81c26bdd0da025eeb8fbd77b5dc961da4364af26e771bd39f379cbbf7') + # Failing on Darwin: https://gitlab.com/qemu-project/qemu/-/issues/2907 + @skipIfOperatingSystem('Darwin') def test_aarch64_virt(self): self.set_machine('virt') self.cpu = 'cortex-a53' From patchwork Fri Apr 4 01:09:29 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Richard Henderson X-Patchwork-Id: 878192 Delivered-To: patch@linaro.org Received: by 2002:a5d:6dae:0:b0:38f:210b:807b with SMTP id u14csp3552520wrs; Thu, 3 Apr 2025 18:10:48 -0700 (PDT) X-Forwarded-Encrypted: i=2; AJvYcCUTxPx2vs743Lj4dCdDsNWd9Yn9z2jaaSwl1hQBnSWT2yN5nfKoYodLgrnz/8mPZRStDyNK2A==@linaro.org X-Google-Smtp-Source: AGHT+IGCmyiK8s0JvwDnHUFT6RFV/EgWbCxnhEhpVhwB0pJrt390s9xua1sD3XzOHOosWREKsy8C X-Received: by 2002:a05:620a:1991:b0:7c7:747f:89d0 with SMTP id af79cd13be357-7c774d250e7mr226769185a.18.1743729048613; Thu, 03 Apr 2025 18:10:48 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1743729048; cv=none; d=google.com; s=arc-20240605; b=feeN8VmIf3AujKVZyoE6xGLoM8Qhi8SZvzHaIlyMOPCZRyQajiySYfZmxAw/EfrCzh PSaNyPbGOacTLtK7V4dpdvDvR2+k8t1GrOw4sQi2yMtxPsyQyAiW4rwdkIEUFIGQlEhq MDy6/0DNla3a+q/hRD/pqHE6esHX3cSgma8bCIwNpnUGNjcXhnfBUNC1vKDaqwM8dddo 0uhnAjks7hjmX34tRcRflbsRzohAKaOPRg8fNAIkODCxUbWEa5z5NzTDc+dF4vW9eOfm VTyQdGoPvheESWFevBGLzyFBIhJhDdXd27udnhQt7qGgzIlGQR3Lvy9iG83Jz/4H0Oh/ Z5VA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=6ztloA/BrSXUCyjpky2M3ioZBF5Jl+KSjfz3+89E/Lo=; fh=wEtq+8Vyz1EsJG1VqGcD+wy8Y6jWeN/etbUYQVOp3pE=; b=eBm6cIeIV21I17vxcqNWYdosnQg0OiciL8kFIfjDyB14BVFjIdPH9SgAB/byhW/v+2 PrWwntnK8Q+S+CaWnnetWmSklNOm3eLWtPssXzKrDHR7DgF0saMztlX3eUbivdMV70Z8 +FsfHcwjqIdZy9L+hBsl94ux15/atuV6L2UbXHCsTPTCogASh6KcQrTWkhM5QnqRbzvj Fp9ul9BYHeG6CdNe340uWx/ldJEWjbUXbr3hKoph6vGWL5J2nnvTuSSo8a+cm68lWjTG +TOaEUF0yqth2PqlIfHsi/Z3YDxPDVrzQb0WK+i4PRiiisgnGH+NwDODEQvuqgagtFRt C9sg==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=ennFpXog; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org; dara=neutral header.i=@linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id af79cd13be357-7c76eabced6si223145285a.517.2025.04.03.18.10.48 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Thu, 03 Apr 2025 18:10:48 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=ennFpXog; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org; dara=neutral header.i=@linaro.org Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1u0VZ3-0008Kp-8F; Thu, 03 Apr 2025 21:09:45 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1u0VYy-0008Io-LG for qemu-devel@nongnu.org; Thu, 03 Apr 2025 21:09:40 -0400 Received: from mail-pf1-x433.google.com ([2607:f8b0:4864:20::433]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1u0VYw-000822-VJ for qemu-devel@nongnu.org; Thu, 03 Apr 2025 21:09:40 -0400 Received: by mail-pf1-x433.google.com with SMTP id d2e1a72fcca58-736ad42dfd6so1219898b3a.3 for ; Thu, 03 Apr 2025 18:09:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1743728977; x=1744333777; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=6ztloA/BrSXUCyjpky2M3ioZBF5Jl+KSjfz3+89E/Lo=; b=ennFpXogfkK2tuBWxEzEuRZIcVeXYGbqwwOf9ACHGM+Qbfi8CrI9MiVGq4pL2rmWsm uhGGAgsk9VrayoAjpBke64xIf9nSPfO2+JuKYusT5A/wrOj3TmNevyPsytSy1z0DygA1 ImawVVRky1pQMm76Roq87cCsTYmIXVLPL0+8tKbdFEYoQC/sMU3oaDtmaq8i4IwSpCjx 82rRE67ut3LbWxAyljPqmpYQBLC6xzsJvufbPYfCDx11oROtmBrBZD0CKZthkCpxi6y4 lnukozgbdCQpJqJntJquUJS0z6TW9yljH4AdUinuAS0PipL+uFJQPD+tEG2VU0Xd5M3w 8bew== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1743728977; x=1744333777; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=6ztloA/BrSXUCyjpky2M3ioZBF5Jl+KSjfz3+89E/Lo=; b=iNhAJiTEAJ24jIgp37v29M1+PcaxjAXAGlgCn+tMn6+glmEgRgvOLf5ybi7PNEvrJW ana6nSvLxsoP3oHwIyAbSM1H3ktKHa+ZqEuyoWf6Vpfclp731gs3XNlGTT8UrJOIZT5J lxmk356e+7oUf1EOH5Jn+YepXGEZwE9IsUhRDKVsHGx8rD7pQAVK8koNJ5W08Urttcvs wRTXY6BqqIsosSwDI2sbDUittTAHBfzppQ1kAf3ynuI9v93Q5POgVgpwcb+ZFwJ7w3Kb vD8JEdv3tbv+OxhvWd2gAWAr2Z/Qs5fw28CjPEwePdD9HRMZpUVCyu5x5NBd7sJEJObN wpVA== X-Gm-Message-State: AOJu0YyZQCHq2IcMuuaooX/lxno7y7QNR4bN7VXEuuvOSQcSBuW1XjY4 bftA4Im1iHvT2dDkDlEF62f2NHLcHGqyVw1lltx4godDFD7JFfIWtHrMvI+SI9KRxlAWU6hW4dp w X-Gm-Gg: ASbGnctBPb42h0/5vfrKCxuwB6Q9gq5Gmz+2IuHVJizD4QakV4/ze19BOY/EDzXguS8 gCFP4BwfqN6t2kuzaN2aoklJ1+AK2OIhXbwgCQxw85tPgbaMuifno6kBSBHDLyKuQsgkNg6aDB/ HZ0UE1/g9p48u4fPACcYgi1tnCc0gAr54SNEQz+UP5QOGyRMV++o0bNBg6BQ7P6LP+GHxwmPksE 1xti9SddSX7eOSntWsHvZSLr5Q+rJkMHQjVjGCpf9Xl/CA5yXVJ1J7i+VQUVP9Xr1TBj2QM+97L D+MU5rDgjBZK61a+rYSEusOa2rlqPYwba0yXzskDmvaUa551Y58= X-Received: by 2002:a05:6a00:3c83:b0:736:d6da:8f9e with SMTP id d2e1a72fcca58-739e46280bcmr1987163b3a.0.1743728977116; Thu, 03 Apr 2025 18:09:37 -0700 (PDT) Received: from stoup.. ([75.147.178.105]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-739d97ee2d9sm2171755b3a.39.2025.04.03.18.09.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 03 Apr 2025 18:09:36 -0700 (PDT) From: Richard Henderson To: qemu-devel@nongnu.org Cc: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= , Fabiano Rosas , "Michael S . Tsirkin" , Thomas Huth Subject: [PULL 5/6] tests/qtest: Skip Aarch64 VMapple machine Date: Thu, 3 Apr 2025 18:09:29 -0700 Message-ID: <20250404010930.164329-6-richard.henderson@linaro.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250404010930.164329-1-richard.henderson@linaro.org> References: <20250404010930.164329-1-richard.henderson@linaro.org> MIME-Version: 1.0 Received-SPF: pass client-ip=2607:f8b0:4864:20::433; envelope-from=richard.henderson@linaro.org; helo=mail-pf1-x433.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: qemu-devel-bounces+patch=linaro.org@nongnu.org From: Philippe Mathieu-Daudé First, the VMapple machine only works with the ARM 'host' CPU type, which isn't accepted for QTest: $ qemu-system-aarch64 -M vmapple -accel qtest qemu-system-aarch64: The 'host' CPU type can only be used with KVM or HVF Second, the QTest framework expects machines to be createable without specifying optional arguments, however the VMapple machine requires few of them: $ qemu-system-aarch64 -M vmapple -accel qtest qemu-system-aarch64: No firmware specified $ qemu-system-aarch64 -M vmapple -accel qtest -bios /dev/null qemu-system-aarch64: No AUX device. Please specify one as pflash drive. Restrict this machine with QTest so we can at least run check-qtest, otherwise we get: $ make check-qtest-aarch64 qemu-system-aarch64: The 'host' CPU type can only be used with KVM or HVF Broken pipe ../tests/qtest/libqtest.c:199: kill_qemu() tried to terminate QEMU process but encountered exit status 1 (expected 0) ... 7/26 qemu:qtest+qtest-aarch64 / qtest-aarch64/test-hmp ERROR 24.71s killed by signal 6 SIGABRT 2/26 qemu:qtest+qtest-aarch64 / qtest-aarch64/qom-test ERROR 71.23s killed by signal 6 SIGABRT Suggested-by: Fabiano Rosas Signed-off-by: Philippe Mathieu-Daudé Acked-by: Michael S. Tsirkin Reviewed-by: Richard Henderson Reviewed-by: Thomas Huth Signed-off-by: Richard Henderson Message-ID: <20250403203241.46692-5-philmd@linaro.org> --- tests/qtest/libqtest.c | 1 + 1 file changed, 1 insertion(+) diff --git a/tests/qtest/libqtest.c b/tests/qtest/libqtest.c index 2750067861..fad307d125 100644 --- a/tests/qtest/libqtest.c +++ b/tests/qtest/libqtest.c @@ -1788,6 +1788,7 @@ void qtest_cb_for_every_machine(void (*cb)(const char *machine), if (!strncmp("xenfv", machines[i].name, 5) || g_str_equal("xenpv", machines[i].name) || g_str_equal("xenpvh", machines[i].name) || + g_str_equal("vmapple", machines[i].name) || g_str_equal("nitro-enclave", machines[i].name)) { continue; } From patchwork Fri Apr 4 01:09:30 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Richard Henderson X-Patchwork-Id: 878189 Delivered-To: patch@linaro.org Received: by 2002:a5d:6dae:0:b0:38f:210b:807b with SMTP id u14csp3552238wrs; Thu, 3 Apr 2025 18:10:01 -0700 (PDT) X-Forwarded-Encrypted: i=2; AJvYcCUv6gvvBiK45V+dFJIfUO7h5jZYtAxl3vzaMY/wJSwrmda4eC9mRQq/FPO6uU64yRmCqJ1DZg==@linaro.org X-Google-Smtp-Source: AGHT+IG9q89QFdGaGFf+8gAMkstd46TVhVHMVWyiXGIOUs/Ef0yacPiTur6x3uDDxSH7Xia+6LOU X-Received: by 2002:a05:620a:460e:b0:7c5:5791:123d with SMTP id af79cd13be357-7c7759e9d3bmr131384685a.10.1743729001029; Thu, 03 Apr 2025 18:10:01 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1743729001; cv=none; d=google.com; s=arc-20240605; b=hSMeJ2a4g1EsUwdGt+0+6cq8DW+mGq2F+XWA9uDwLamDF59CttngaSSQKN7fwVb+0E Q72EPOvYQqrfdOTBN6tZDtHjH1px5YwS3hm7Qno+AtPQUBT4yJ0+vMk3jxX8ZkdTgv8W Ky61dWwNc7M4bvxAOZZbvmqg2+w3cqWj1la1WzQa/65eDxF/dsO+uU+ocj5ojcHIgEV8 bUh/eqSizre2ASDMgBLWpFcOdijYg3snVulTSUClkNnaZ9DzU2qw6XH4MDwPhaOb6CcP MTn/37/1ofJhpXgUEC/iHvtjNtMe/ue9AzI0gfcFG3NGNY2MOUzeuEob9ecc3Y5DOWet Dhng== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=1ppDuu7UF+45EoAIpM5719mvR+IPFOKbM/LYFUmyG2k=; fh=kQadAhxV42GJ3cd2VUw1RyURv/zJQGvmUdF7iLEVTtc=; b=Xd5V44um2FBwDm+p694djceiJ9+gpfy/vxpsF8v5o3RNL2LYgOo1R2tDLvkNdhuzRQ i7QyLuzbyIqicuk3T4zln7hD6uBLW3Iod/JgQgr+Hb6O+ekelwbG8kb6xtxw815nJpML T9A5TkvoRMdyUZLTfOrJmkJPqfY8/Lxdbl5w99EQsKecy8kaMwJLRoomQ+Ftg5o+ZrNh ZwgIMZhSByYw9vGW3tV09tvpsXqO2fNhre3ZxcZJpKyQncJSIH5STyHHUdcPHwNv1nU7 BYweEJ8AwyKuEx9Eho0FLwC5Yufiy8Zxp38M/XnQyyQiVcE0tx+GpbBxtaTq38oI/4us xcEw==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=tl7Wg7Em; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org; dara=neutral header.i=@linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id af79cd13be357-7c76ea5916dsi227915485a.206.2025.04.03.18.10.00 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Thu, 03 Apr 2025 18:10:01 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=tl7Wg7Em; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org; dara=neutral header.i=@linaro.org Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1u0VZ5-0008LS-0n; Thu, 03 Apr 2025 21:09:47 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1u0VZ0-0008JP-3T for qemu-devel@nongnu.org; Thu, 03 Apr 2025 21:09:43 -0400 Received: from mail-pf1-x42d.google.com ([2607:f8b0:4864:20::42d]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1u0VYx-00082L-JL for qemu-devel@nongnu.org; Thu, 03 Apr 2025 21:09:41 -0400 Received: by mail-pf1-x42d.google.com with SMTP id d2e1a72fcca58-736ee709c11so1313575b3a.1 for ; Thu, 03 Apr 2025 18:09:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1743728978; x=1744333778; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=1ppDuu7UF+45EoAIpM5719mvR+IPFOKbM/LYFUmyG2k=; b=tl7Wg7EmGsrnENd++SjSISFpuBgLQvQ75wYu5rt8JH0T6tBJoI9niO9Tytqp/F06Vh btMYjv5tYNeQpVg3GcvXbF3k2De5warbrxQOLYosiShAXdxwoFnwa0eaPUsE8/USWrSV /iz+Hdx/7n4fyhMn2K7yPA/6++e7KONuEa/iSLjBDnraEUVYK8GHzjWAZSQpbz3iGpFG 9hw8ZKvIx8+V12nzBkB41xe0RESYhfbuxSinhIc3pi1F5ZqZsn6gVCz8HAE9pjPo+BVx YKUC8rf+r+xcF6lWKO6DPSbgq87W8o6PedBUUXRxYdvLZzme5CLz8f0zEura5P7JjM5D 6Jng== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1743728978; x=1744333778; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=1ppDuu7UF+45EoAIpM5719mvR+IPFOKbM/LYFUmyG2k=; b=mdzV5G/Aei4MlrxwhqkVymUpAydLKK4ptxUyg6WljGDYEGlMm+GPYnoAb9viuk5L7l puAZP/FWW2Lz9TvmGIAaSHtJW/lxorP+Uvduc/sQLnSoyXPYdXY/0bLio2uKNQRq3E5P 4SXRe9iiN/KAEw0WXc6pnuKX42JPOATuH4kF6RuS9yx4UjtoFY3SCke4+LsYy5RaYvf1 KhYrLyToqUaGOHAvdIRRQWtwUWQTbYXcObYCaM/FMeoPS/GdFa//gEzCT+18Gt/RaWiL yyszx5ZSX5+iZ0GHxoo01dLZ3/RRDhzf0Cf36xWQC7Z5B8BgHEhuy0kFUzst/BhOIRfe zw2Q== X-Gm-Message-State: AOJu0YwjqZHGzQ7+rZv+7lxWZWLnbFjcSEufe9jl+gHxxONz61FchyMH KKHJAQy0dvY2DCwC33CApKPe/yuODrB6BVeB7nN07KJcIJX7mE5X7HHKVhxwJXhwzKUdhHBVeVJ 3 X-Gm-Gg: ASbGnctFhmkr6uat5ajn6vqkM5XOI96S8D70i+rTggQe+dQKd0dB4d2KrBqJFd2908U z36ZP3Tb9RQJLVLj8ufDPllaIZIv/LvN1im9kiq+xvq85B6/3u0x/MXF/L02N4Yx4aXerbGv97g MQ3YiXRIknGaoZWxQWDilRegDWxFztYKmWoU/BfpmAh2J9pFWi7PjYhmb6ZOChnyb1XgePh5biw L7YFsk2Ji7uJgwACNCioTUYUgdETrW0Z8h7Cw7L/Ld4uTRwcRPbiPgfy2f/o7ddfEGxT9SHt8A8 WzdFC9Z69REj0nJZeIRUJUF9lCwMlo4knwkZjYd8quIfW3AhYLw= X-Received: by 2002:a05:6a20:d489:b0:1f3:1d13:96b3 with SMTP id adf61e73a8af0-20107eab10bmr968530637.5.1743728978024; Thu, 03 Apr 2025 18:09:38 -0700 (PDT) Received: from stoup.. ([75.147.178.105]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-739d97ee2d9sm2171755b3a.39.2025.04.03.18.09.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 03 Apr 2025 18:09:37 -0700 (PDT) From: Richard Henderson To: qemu-devel@nongnu.org Cc: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= Subject: [PULL 6/6] hw/arm: Do not build VMapple machine by default Date: Thu, 3 Apr 2025 18:09:30 -0700 Message-ID: <20250404010930.164329-7-richard.henderson@linaro.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250404010930.164329-1-richard.henderson@linaro.org> References: <20250404010930.164329-1-richard.henderson@linaro.org> MIME-Version: 1.0 Received-SPF: pass client-ip=2607:f8b0:4864:20::42d; envelope-from=richard.henderson@linaro.org; helo=mail-pf1-x42d.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: qemu-devel-bounces+patch=linaro.org@nongnu.org From: Philippe Mathieu-Daudé Unfortunately as of v10.0.0-rc2 the VMapple machine is unusable: $ qemu-system-aarch64 -M vmapple [...] *** Terminating app due to uncaught exception 'NSInvalidArgumentException', reason: '-[PGIOSurfaceHostDeviceDescriptor setMapMemory:]: unrecognized selector sent to instance 0x600001ede820' *** First throw call stack: ( 0 CoreFoundation 0x000000019c759df0 __exceptionPreprocess + 176 1 libobjc.A.dylib 0x000000019c21eb60 objc_exception_throw + 88 2 CoreFoundation 0x000000019c816ce0 -[NSObject(NSObject) __retain_OA] + 0 3 CoreFoundation 0x000000019c6c7efc ___forwarding___ + 1500 4 CoreFoundation 0x000000019c6c7860 _CF_forwarding_prep_0 + 96 5 qemu-system-aarch64 0x000000010486dbd0 apple_gfx_mmio_realize + 200 6 qemu-system-aarch64 0x0000000104e6ab5c device_set_realized + 352 7 qemu-system-aarch64 0x0000000104e7250c property_set_bool + 100 8 qemu-system-aarch64 0x0000000104e7023c object_property_set + 136 9 qemu-system-aarch64 0x0000000104e74870 object_property_set_qobject + 60 10 qemu-system-aarch64 0x0000000104e70748 object_property_set_bool + 60 11 qemu-system-aarch64 0x0000000104e69bd8 qdev_realize_and_unref + 20 12 qemu-system-aarch64 0x0000000104e258e0 mach_vmapple_init + 1728 13 qemu-system-aarch64 0x000000010481b0ac machine_run_board_init + 1892 14 qemu-system-aarch64 0x0000000104a4def8 qmp_x_exit_preconfig + 260 15 qemu-system-aarch64 0x0000000104a51ba8 qemu_init + 14460 16 qemu-system-aarch64 0x0000000104f7cef8 main + 36 17 dyld 0x000000019c25eb4c start + 6000 ) libc++abi: terminating due to uncaught exception of type NSException Abort trap: 6 Disable the machine so it isn't built by default. This is tracked as https://gitlab.com/qemu-project/qemu/-/issues/2913 Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Richard Henderson Signed-off-by: Richard Henderson Message-ID: <20250403203241.46692-6-philmd@linaro.org> --- configs/devices/aarch64-softmmu/default.mak | 1 + 1 file changed, 1 insertion(+) diff --git a/configs/devices/aarch64-softmmu/default.mak b/configs/devices/aarch64-softmmu/default.mak index 93f4022ad6..ad8028cfd4 100644 --- a/configs/devices/aarch64-softmmu/default.mak +++ b/configs/devices/aarch64-softmmu/default.mak @@ -9,3 +9,4 @@ include ../arm-softmmu/default.mak # CONFIG_XLNX_VERSAL=n # CONFIG_SBSA_REF=n # CONFIG_NPCM8XX=n +CONFIG_VMAPPLE=n