From patchwork Thu Apr 3 20:32:37 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= X-Patchwork-Id: 877941 Delivered-To: patch@linaro.org Received: by 2002:a5d:6dae:0:b0:38f:210b:807b with SMTP id u14csp3465936wrs; Thu, 3 Apr 2025 13:34:17 -0700 (PDT) X-Forwarded-Encrypted: i=2; AJvYcCVvoU/bxvTmBTx+Dk5I9LQ27/sWn6kw6v4+8wxn5qs8wIACqsn2xHwIoPOf4XtdhNLBUE4pqw==@linaro.org X-Google-Smtp-Source: AGHT+IEO9X10USnFFQw1XsJVSLlSX/Taivj4krlyVIIbaYAA5KxutOcp6LeB/7gPSnO7SqfZ0r8h X-Received: by 2002:a05:620a:46a6:b0:7c0:c046:7c6b with SMTP id af79cd13be357-7c774e25ae0mr90478885a.53.1743712457089; Thu, 03 Apr 2025 13:34:17 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1743712457; cv=none; d=google.com; s=arc-20240605; b=cCWaE2mHOjfA07r3k3+SWwFsinqB4S9D+mj4wSUD+oFzsE1/zL4/1MeSLVA/0Bw0VD 8jvzwlKL2M50vOF+DC6dBtCTVVFnztLUMOKloqGO6p4JLbcJ8gNvxvzB6lEWLESfcfTz G+/DgdEjP7rqg68vOUiV8vgCqgVTlwVlucI27jmyODR8FYorJAlwmKPA+N145RuZj20f VZrUd3Ve+hDnn755Sh3HsSwGquErAHFAu8kxkR7BLctwDwdEimB5Ef4AaItu1Pkk+eqx OXoP8T9fyoBDfZOSXLJkJ/P59tUr0heC2G1/4joTCVyCWMMKb64jO2HCwYYw0ThYTgqz 4rdA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=VGswViVnnb77pop0AHAfmo4nHoQCnlrKr2lNkpeHI/g=; fh=Qc4cQUntwR3Euh7QCxyOiSz9zr+iWjIvrUa4zqJtwXA=; b=AntaQ7nFy4MRkBBlE7wqDOnuc4ZbjmyKj5uyKQu6oUehrok9uq8AzkAccpxaFWv30e 9pXo3fgBGs8XukXbakwUqYk4Qx8d9M0rVfxCj5vW8cZ0cImDeduDbpqxN31KxBNDUpfd BbRIPETHDJbAsyZ9x/Yc8Nkskdfyu4cNi6IpwLsQVNXu2WOerjyGntZa2Tg+UJ+AA8M6 mWrVrxeN7U2PHoaQ8oMDPzC//hgVyDkeIBbnLF7EUaDjcE7q1je1nfeLYs83ZBOlQRkF JSpPttaN0LA9Q2hhVS48a2GiOv6cijapy5kkvDFcVohJsEJzFtBFgo5GGCPV7B7F1186 sN7A==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=Y3FXd3Mp; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org; dara=neutral header.i=@linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id d75a77b69052e-4791b199071si17018561cf.429.2025.04.03.13.34.16 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Thu, 03 Apr 2025 13:34:17 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=Y3FXd3Mp; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org; dara=neutral header.i=@linaro.org Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1u0RF7-0003yT-1E; Thu, 03 Apr 2025 16:32:53 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1u0RF6-0003yI-0n for qemu-devel@nongnu.org; Thu, 03 Apr 2025 16:32:52 -0400 Received: from mail-wm1-x334.google.com ([2a00:1450:4864:20::334]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1u0RF4-00042g-5u for qemu-devel@nongnu.org; Thu, 03 Apr 2025 16:32:51 -0400 Received: by mail-wm1-x334.google.com with SMTP id 5b1f17b1804b1-43cfa7e7f54so8424185e9.1 for ; Thu, 03 Apr 2025 13:32:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1743712368; x=1744317168; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=VGswViVnnb77pop0AHAfmo4nHoQCnlrKr2lNkpeHI/g=; b=Y3FXd3MpOBD2xUC4hMS3N7an1JUPIjCdWo2arIB0xNseED/Ol3LGpUtt7UU7g1/ZLI LibpJWaBL1JgkqZdlNTn3iJLnTf7Yslmx4c39McWP0036evjcQEN6e+z/PKX1RF+9fAD 5YjrGIDeYxQmIi3WXgaN/qFo7CKVBl9aaVy+Jd/17/lTArcpGsX7iZRSfQu2APEscz8q h9b76pSWA9arfJalshQLa3QvtwOorbKK/zWBfcWcAhLrgNSoQdmJt8AN7swGYeLsCr2o N0tTkdc668fgBV9a0Bb3p1KrTQN5u7a7ku1jgJajwnd73AoAPjpywxNt8P6apAz2Qwrl uFKA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1743712368; x=1744317168; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=VGswViVnnb77pop0AHAfmo4nHoQCnlrKr2lNkpeHI/g=; b=wZKEFD+3Yu8pSxasOyULqNJ5+WiYUBUBkFrR2NBux5m0HbRo2GjwosyuK4wLTdE1oV uKjbU+291UYx7YkKTHe+ZEojDHh3RZ0ImZTzmOndtDkzhskx6NScVaqKAxEUJg4/x26W Jr4s+JYTw6+txsM/mSRYSDztQJmJVYJejB2UevD6ikr5oKrWvfqcQz/kNdz7YWkIZj0Z itLynAiTDFLyYRcGgM4ka7WwxshFX97mFwLuFUzAj8wV1gc0zjxFOJzCuRzhwt+QGlg6 JrUQ0ZzRnm4TEpib8Sa2HDSfcYbZ4pfFvdWezuNBVonvqE97exFv8SCr8qfwZzo8RHzd tidA== X-Gm-Message-State: AOJu0YyMnls58NMeaq0zWJ942YXh/wPFcz5Uw9aQyHrGzON5plXbIcFs hK7HECZlGSNx00U3BczV8W9kRW0HSeAhZ6MGXxatQTR5HNue7gtvO85F7DnmhH4ehfg5wvhqjU7 8 X-Gm-Gg: ASbGncvtN+qv+ATCJbf83iC2s4sansKBvaRb1bC4zd2gFCuUg3wCAvIJ6bevCaRloO8 OATpYbKKlL0ReZlw7tFF1y0b5lCA9ehwGXg/tLtfgFPjOpX8h2FQjreyMrqZ39kTN4usgdDQG8t n2ae4KXa5DKoUzmY2glQ+K5Ptb/W4nOA49YjaR7ufri4u34kgBp6pqS1WlpMbcU3Fo4chWJD9IW FxS9QDItkEKrzNu3YBMmoEeAhJQACakNZ2SUwrR+/H8LFgUnvzv6fBozYpIaFWkDjbGzXH5PJFc rd0XE/HV1c/QbWBc8SWpWURPp8/aP60DaMUDkwxheuZ1k7J5HqjuXDfa53RaMNsHhZVQqGDoFnQ BZlXO5oq79Fm/0Hiy4UExIPUO X-Received: by 2002:a05:600c:1827:b0:43d:174:2668 with SMTP id 5b1f17b1804b1-43ebeda3c57mr33607555e9.0.1743712368451; Thu, 03 Apr 2025 13:32:48 -0700 (PDT) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-39c301b6778sm2581591f8f.46.2025.04.03.13.32.47 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Thu, 03 Apr 2025 13:32:47 -0700 (PDT) From: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Thomas Huth , Laurent Vivier , Paolo Bonzini , =?utf-8?q?Alex_Benn=C3=A9e?= , Alexander Graf , Phil Dennis-Jordan , =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= , Fabiano Rosas , =?utf-8?q?Daniel_P=2E_Berrang=C3=A9?= , Pierrick Bouvier , Richard Henderson , "Michael S. Tsirkin" Subject: [PATCH-for-10.0 v3 1/5] tests/functional/test_aarch64_rme_virt: fix sporadic failure Date: Thu, 3 Apr 2025 22:32:37 +0200 Message-ID: <20250403203241.46692-2-philmd@linaro.org> X-Mailer: git-send-email 2.47.1 In-Reply-To: <20250403203241.46692-1-philmd@linaro.org> References: <20250403203241.46692-1-philmd@linaro.org> MIME-Version: 1.0 Received-SPF: pass client-ip=2a00:1450:4864:20::334; envelope-from=philmd@linaro.org; helo=mail-wm1-x334.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: qemu-devel-bounces+patch=linaro.org@nongnu.org From: Pierrick Bouvier This test was randomly failing on our CI, and on dev machines, especially with QEMU debug builds. >From the information collected, it's related to an implementation choice in edk2 QEMU virt support. The workaround is to disable KASLR, to avoid accessing protected memory. Note: this is *not* needed for the similar test_aarch64_rme_sbsaref. More information is available on the associated GitLab issue. Resolves: https://gitlab.com/qemu-project/qemu/-/issues/2823 Signed-off-by: Pierrick Bouvier Reviewed-by: Alex Bennée Reviewed-by: Richard Henderson Message-ID: <20250328183816.2687925-1-pierrick.bouvier@linaro.org> Signed-off-by: Philippe Mathieu-Daudé Acked-by: Michael S. Tsirkin --- tests/functional/test_aarch64_rme_virt.py | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/tests/functional/test_aarch64_rme_virt.py b/tests/functional/test_aarch64_rme_virt.py index f4ad4d33d58..a1abf584f0e 100755 --- a/tests/functional/test_aarch64_rme_virt.py +++ b/tests/functional/test_aarch64_rme_virt.py @@ -87,7 +87,9 @@ def test_aarch64_rme_virt(self): self.vm.add_args('-fsdev', f'local,security_model=none,path={rme_stack},id=shr0') self.vm.add_args('-device', 'virtio-net-pci,netdev=net0') self.vm.add_args('-netdev', 'user,id=net0') - self.vm.add_args('-append', 'root=/dev/vda') + # We need to add nokaslr to avoid triggering this sporadic bug: + # https://gitlab.com/qemu-project/qemu/-/issues/2823 + self.vm.add_args('-append', 'root=/dev/vda nokaslr') self.vm.launch() # Wait for host VM boot to complete. From patchwork Thu Apr 3 20:32:38 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= X-Patchwork-Id: 877945 Delivered-To: patch@linaro.org Received: by 2002:a5d:6dae:0:b0:38f:210b:807b with SMTP id u14csp3465991wrs; Thu, 3 Apr 2025 13:34:27 -0700 (PDT) X-Forwarded-Encrypted: i=2; AJvYcCWTqE5kcLf6hatpu0s1qX3hGI7XzKy+7I3LglWx7i83I3oOukFIel35Two5/bsA3piQ5ClMmQ==@linaro.org X-Google-Smtp-Source: AGHT+IFAQzRSyDjxGMHmFrMUwz7SK5coIvWyn7zVBV3KFGX4r7PG+psdnOUREKXq/hKZfELqALFl X-Received: by 2002:a05:620a:3908:b0:7c5:3c62:804c with SMTP id af79cd13be357-7c775a0fefcmr27635685a.21.1743712467014; Thu, 03 Apr 2025 13:34:27 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1743712467; cv=none; d=google.com; s=arc-20240605; b=evQLakg6Ugq8yh6vVqbJFYZ1hptOWmcOCWUtzjfmvculI6xbUS2UJSVw97OJecIQFR aDN9DhS9nvvPUIN7Fss99rKYXFAQ3TnY16swrJ0cnGuPNwH3N1Lkqp3zRifyGxk06Gbv qs1vm6MInch5Q0ryUt/pmcpP7H53/OBygq0moguAX9KthPCwQDZcF0sA9dcZBXLoDSuJ vDjff4K1kQd3ZYLzEmZnWbrSPth9O3jsgNl2h0Yht+9LID7EenBXkO7HIHZNJTC32dJl wN+d9Ox3xqn4TZRr4v3FmcTEvR2FgzMG7pCr0WVikKLgTQy7SYZSrhgr7JgHwGlo10Bk EmKA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=A6+6tP0FDiD90XBJa6S5dJ//D1whWgsc0bfGPime3dk=; fh=Mg3Q/MQi4drPeKmQITgpMs6kx0xorjEcFN5p6eOb664=; b=Aj4BTXF08+SZYoXodu56Mfd2bE3fgJnMtIaO+ZxP/QyHgnfl3+6GRFNvYvHgaF0tO4 9IU21c/OG8l3IA54MVjOL8XLh41hOWB70KN3xhPOFrgKvxzV2ZxWldF1PmYBS4ePniFH w0lFan68ckhqecNeb1O6uX5PcHGdaWzEnbJPCeC54VByeAd/GAoFymKgD6EEV7eA55/y D6lCL7g8ot1oZ5XlOUUggSMn4Aj/ZujoPC/ds2jMschY9ArfHMKXbjVAOQIK+7rpelYC mkRFdU6Qfpdxi0Uwq++iEh9WBsfDCHpNyieFjj7oeXoeNl4IUUKd34Oi13hVi/8+TkDy 279w==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=WdJsw10k; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org; dara=neutral header.i=@linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id af79cd13be357-7c76eae4811si176177785a.643.2025.04.03.13.34.26 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Thu, 03 Apr 2025 13:34:26 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=WdJsw10k; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org; dara=neutral header.i=@linaro.org Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1u0RFE-0003zL-RC; Thu, 03 Apr 2025 16:33:00 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1u0RFC-0003z1-9H for qemu-devel@nongnu.org; Thu, 03 Apr 2025 16:32:58 -0400 Received: from mail-wr1-x42e.google.com ([2a00:1450:4864:20::42e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1u0RF9-00043E-7Z for qemu-devel@nongnu.org; Thu, 03 Apr 2025 16:32:56 -0400 Received: by mail-wr1-x42e.google.com with SMTP id ffacd0b85a97d-3913958ebf2so963043f8f.3 for ; Thu, 03 Apr 2025 13:32:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1743712373; x=1744317173; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=A6+6tP0FDiD90XBJa6S5dJ//D1whWgsc0bfGPime3dk=; b=WdJsw10kcAtx2pl0+Kv6rdoaSX+pyOt6a/bLlprdrdDP10qy0IfxRYFa8Cz+dPOA2k 29GBzSxqd3ni9Fq7pNR5UC2dTWy5sCjMO45ikAtJlVwmvEJNgXfcFfWxFcCj8DK+euH5 qFVbfw/fUP16MGcDiF2Wbo5dHZH+26DSx2nJzG7OR654sqoEGrFaaX2yOrs5L2fiLKDe LSPeVBftYa7lQU6sU1KurhRA4UPCfS4TUGLGHa3tng2LN2O6b2g4FR4V/7DZwoRQEYo2 T9ooDlKQlL0iAf114hIoQMSWyh+79z8+dYv0TKLIMPG8pLN8i2vQihE82L00TimkYS/J R2Ag== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1743712373; x=1744317173; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=A6+6tP0FDiD90XBJa6S5dJ//D1whWgsc0bfGPime3dk=; b=XeR3E76sXlot+MnA047sBuympN0PPyEB6MZy5ksS1qtarj6Xg1VnmcuZSePE0bYIoB sgdOPOX/KqXZzaQG6JPtp+8LXcg5iZOGop5HqVtCOyOi8Xyoaa0WDG9t1GogBU+MO89G drN3fMIvU+hw0b3YkIVuqAq3JfJTFqVRjbPhnH3A/K+RF7u2skakKRw+BvYEq4agmgfC TRHF73hwZxfJ+m+T6S+OACcI3nxbCXz8ZJt8ZGc5hO07dRV8zkn0UuPKehx3jrBhDLtJ tHtQFQOKRLQd5IVC1hJi3K6PL1CaU/wpjMvnBuxzo+NPv8KjGWIieHvm+WUMLXHSRgfw dGmw== X-Gm-Message-State: AOJu0YyudKRFOEq1pkn/UekMfD8Hgo1Qu16TYX38uoS66TFmHys97ZHj dKD//9KFEE832MQbQNP3egtSFDxPR7DtJ/s/LRzBJLUCFDlq5SxeH/J5x5PbLzhreMlsxLmWc0x Y X-Gm-Gg: ASbGnctLO8P1DpOZXX6xhXv3/+TmMI0a0ZhNSbNHtcTqw+VfRW+BU5B1DPSjV9avTEH 7bMUp19JAyEJ1vhv9rmIpCG5MIRZUfe04b+fHyWuv8+6YYItIGhVyrpLZn+yUwMLHKefZk7y3jl wp7VtLkEjLYcC0KfYPs+xj31QU5ztS6LXyKYDgKHSeFqtbIf1DCjvpy3jNk4KJFWDK2xDWRSqc7 N7DBsNvV2rMhfB0VkGYlrJX3jD7TgylpnNCVzyvYxIaQHYCNWSyFTjxDB+qiucggcvftwS8rWuu 2AYqJoVN0S1yHaUoML7cvp6W0xOyT3zlqXlj3BBP1Ij2okSTwh3O3HscEavQNNduQJ9RrxKsZzs Yk0RGtaiagtB1Kn5WDJMG2FftFHObitS3+ls= X-Received: by 2002:a5d:5d13:0:b0:39c:1f0b:8f6f with SMTP id ffacd0b85a97d-39cb35a1821mr554968f8f.24.1743712373310; Thu, 03 Apr 2025 13:32:53 -0700 (PDT) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-39c30226f1fsm2703680f8f.95.2025.04.03.13.32.52 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Thu, 03 Apr 2025 13:32:52 -0700 (PDT) From: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Thomas Huth , Laurent Vivier , Paolo Bonzini , =?utf-8?q?Alex_Benn=C3=A9e?= , Alexander Graf , Phil Dennis-Jordan , =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= , Fabiano Rosas , =?utf-8?q?Daniel_P=2E_Berrang=C3=A9?= , "Michael S. Tsirkin" , Richard Henderson Subject: [PATCH-for-10.0 v3 2/5] tests/functional: Add a decorator for skipping tests on particular OS Date: Thu, 3 Apr 2025 22:32:38 +0200 Message-ID: <20250403203241.46692-3-philmd@linaro.org> X-Mailer: git-send-email 2.47.1 In-Reply-To: <20250403203241.46692-1-philmd@linaro.org> References: <20250403203241.46692-1-philmd@linaro.org> MIME-Version: 1.0 Received-SPF: pass client-ip=2a00:1450:4864:20::42e; envelope-from=philmd@linaro.org; helo=mail-wr1-x42e.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: qemu-devel-bounces+patch=linaro.org@nongnu.org Since tests might be failing on some operating systems, introduce the skipIfOperatingSystem() decorator. Acked-by: Michael S. Tsirkin Reviewed-by: Richard Henderson Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Thomas Huth --- tests/functional/qemu_test/__init__.py | 2 +- tests/functional/qemu_test/decorators.py | 15 ++++++++++++++- 2 files changed, 15 insertions(+), 2 deletions(-) diff --git a/tests/functional/qemu_test/__init__.py b/tests/functional/qemu_test/__init__.py index 45f7befa374..af41c2c6a22 100644 --- a/tests/functional/qemu_test/__init__.py +++ b/tests/functional/qemu_test/__init__.py @@ -15,6 +15,6 @@ from .linuxkernel import LinuxKernelTest from .decorators import skipIfMissingCommands, skipIfNotMachine, \ skipFlakyTest, skipUntrustedTest, skipBigDataTest, skipSlowTest, \ - skipIfMissingImports + skipIfMissingImports, skipIfOperatingSystem from .archive import archive_extract from .uncompress import uncompress diff --git a/tests/functional/qemu_test/decorators.py b/tests/functional/qemu_test/decorators.py index 1651eb739a7..50d29de533d 100644 --- a/tests/functional/qemu_test/decorators.py +++ b/tests/functional/qemu_test/decorators.py @@ -5,7 +5,7 @@ import importlib import os import platform -from unittest import skipUnless +from unittest import skipIf, skipUnless from .cmd import which @@ -26,6 +26,19 @@ def skipIfMissingCommands(*args): return skipUnless(has_cmds, 'required command(s) "%s" not installed' % ", ".join(args)) +''' +Decorator to skip execution of a test if the current +host operating system does match one of the prohibited +ones. +Example + + @skipIfOperatingSystem("Linux", "Darwin") +''' +def skipIfOperatingSystem(*args): + return skipIf(platform.system() in args, + 'running on an OS (%s) that is not able to run this test' % + ", ".join(args)) + ''' Decorator to skip execution of a test if the current host machine does not match one of the permitted From patchwork Thu Apr 3 20:32:39 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= X-Patchwork-Id: 877942 Delivered-To: patch@linaro.org Received: by 2002:a5d:6dae:0:b0:38f:210b:807b with SMTP id u14csp3465940wrs; Thu, 3 Apr 2025 13:34:17 -0700 (PDT) X-Forwarded-Encrypted: i=2; AJvYcCUgW1QCdJovuhfpLjyrNHGPO/ZGNdBe+TVNa0KWmCf8jFIm2oAFWPlo5SSUHocJmcsg7LrFCA==@linaro.org X-Google-Smtp-Source: AGHT+IF85WOqRRogjScSfunDigG/zR5kQiIESMo7ShrcU0aNpLpn8wlr1gLkdUD2m2mfAW6yrDgf X-Received: by 2002:ac8:5f83:0:b0:476:add4:d2c9 with SMTP id d75a77b69052e-479259260b3mr6876261cf.8.1743712457488; Thu, 03 Apr 2025 13:34:17 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1743712457; cv=none; d=google.com; s=arc-20240605; b=SO3fzmv6DMXT4nSaaNdL+MdZaJ3vpR4jmvNSOPxYXJEaQL9UmpaemIRaw/fZf2oS2J ADv6Sbkg/XDTdl4OoKZsUJrJXzxhTPLEQ8E16LvhOiypMrzM0V/tIeDpfN1cHe+/CZSg UE96GhLGOM6ybM6RuGYPtvBN11M4+rBazUfv30EA6f+7D/D/BKKj86yCONrCcR2kWwTW Tg/21Uqd26XcW50Cbn0O8aXmXR3AsPPbjh98fVDkY0ZaeqRy8mVBRE//22NKUzzCq4Fc mcmP8JDdM28mgq422LEJVvUc+a71+EHe4zaWC34m7G7mKXDannbD1cKIpiWQn4IbTvfl X2lw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=VUYVIflGesDLaaMP/ur2j2JEaJvbIDtPIxL00Q+AXXI=; fh=Mg3Q/MQi4drPeKmQITgpMs6kx0xorjEcFN5p6eOb664=; b=NkpAAMYk8MR5jgRnYbK5/j+WtNbbSq6uZpxxNHfOSNXI7Ke8NwGwPXRti5vtO8X89c cpVLgM1qylscDuNGe9dOC+2RnQB3wr4GM1b/fZ4RrSyXu01EVMQ2XyiS9ZJSK3/7tnrX DesrSoLiU38gxfWVFPpKq8AX686cAxWmogq7tDzJxNrT4OUXgk3twZAqjzrJ59wS2fTg k+OuAFFKXRbXaGMR9jRdtbLKTk+Mhgig0LbwHHNDI9xOZfCJPl70Sa2OITTtoWAfny5D aPLpXRDup/Afghg/+c2qv/wy30u5GrBLWQOS21nxptLOKx5HoKXmncH/ZuiI3S6t+6mc yNMw==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=icqd3iAk; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org; dara=neutral header.i=@linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id d75a77b69052e-4791b07b81bsi17034201cf.180.2025.04.03.13.34.17 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Thu, 03 Apr 2025 13:34:17 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=icqd3iAk; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org; dara=neutral header.i=@linaro.org Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1u0RFI-00040E-MI; Thu, 03 Apr 2025 16:33:04 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1u0RFG-0003ze-BS for qemu-devel@nongnu.org; Thu, 03 Apr 2025 16:33:02 -0400 Received: from mail-wr1-x42b.google.com ([2a00:1450:4864:20::42b]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1u0RFE-00043p-DK for qemu-devel@nongnu.org; Thu, 03 Apr 2025 16:33:02 -0400 Received: by mail-wr1-x42b.google.com with SMTP id ffacd0b85a97d-3914bc3e01aso876727f8f.2 for ; Thu, 03 Apr 2025 13:32:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1743712378; x=1744317178; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=VUYVIflGesDLaaMP/ur2j2JEaJvbIDtPIxL00Q+AXXI=; b=icqd3iAkO2LDQm4JW82e5i04PFlHoxB3gDl8VdEGpBq/VCNasoZBX2jjEa9UXmhj2b h8WsRgTSMiG1QcrzKZg27SV7PEZYWZBBQLUN6wwkR4cm3uYsweOABH0CjADd8/ItD6DD 5/EIDe0tlboP0MrPfIGxEzevlIw5AMUhiuXUhyJyz9Holziax1/B3ZNihiE7Exwi8au/ 7dWLMp5Ee6xLc8LAqBHDdFCGWcsxuksyZuuEK27XEdtmaj9yrKmChDKvVT3EUTTI3PA3 wjXS7ddQZJrO2MRLiJzS4h4S8cbp3N5RWem0T6aWJRu33AsI9It9ccNVhiO6wo4z4/3d rILA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1743712378; x=1744317178; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=VUYVIflGesDLaaMP/ur2j2JEaJvbIDtPIxL00Q+AXXI=; b=ERAtXEI638SdX7UxE9RCwOGc4Vx2EKyOb0VlQiYGj3B4+kEwn+bdjV2141yJ5HxLdO yStJ153qXO/eUzNpIqNHaJr8QsVa5D4/n0AL3bY9jbF4V8jMmYXmOh27zPg6RexOM+WB d/bneiUMWK6JYdcIBjNLjFyNqLBK2ejJ4FWuJwMOhXx/aM/zE+u3zYw9jA6mwOF0ODwF ZMkVakMX7MgH/lBaFMgHR0ymzcI3l4VxkwALGoPCBwEsAtLUrLd7n6HHhB2hIdgNB3l6 5Fjrmx8cYWfKbxGjKM0I+KlbHAvlDxfMWmJM/9qOgzS9Rr247zFrVuQnsnzoPXcCAP9C Po/A== X-Gm-Message-State: AOJu0YzeehLLqUfrXnkZbJc76IX0fabVNVO1zNKHczemRJFBDN07gOMj 1Iw2oZ7DuB3j1IMVKf4wkJkMOf/ZIbnZrJydBhPxNEEw9FqlQHRxw4jAUssW+nEcTVujtWNRls0 o X-Gm-Gg: ASbGncuii+ILu6TxidxTDJW61JxCkwVfbJflo7cZTHE6ImPSVTAJ1RC78StgBTJRefd pSMA4W+YqhggBrIbxIU/bDnkungc6SUvv42jvf+1FZTq5mII+92IqHeWAkUNNNqt3bHOKnU9p2U Zggo4+8XdbxsOvhvzsDCCOO60w5Drua1kqU66B8gg7WGsh+YQQT9nsvwswM9VmXdXSd2DaL+Zd1 a3K4OkJARicgIcdnUGgXw5Y3X5Vok71+JQwtloVENljuG2v/b9G8WO7rbkJi3nZ07y4YBCLWPHP /WzCdVqUdaDT2PUfbkwyT73QRNU0vZTi/mA886pXMVMKHrLEf0RTCdHU4Ai/MwivAZnujnoomSm /hJAsWe3UFDbkORWUuqJjplky X-Received: by 2002:a05:6000:4304:b0:39c:12ce:1052 with SMTP id ffacd0b85a97d-39d07bcd00dmr154832f8f.7.1743712378220; Thu, 03 Apr 2025 13:32:58 -0700 (PDT) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-39c301acec9sm2634257f8f.40.2025.04.03.13.32.57 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Thu, 03 Apr 2025 13:32:57 -0700 (PDT) From: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Thomas Huth , Laurent Vivier , Paolo Bonzini , =?utf-8?q?Alex_Benn=C3=A9e?= , Alexander Graf , Phil Dennis-Jordan , =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= , Fabiano Rosas , =?utf-8?q?Daniel_P=2E_Berrang=C3=A9?= , "Michael S. Tsirkin" , Richard Henderson Subject: [PATCH-for-10.0 v3 3/5] tests/functional: Skip aarch64_replay test on macOS Date: Thu, 3 Apr 2025 22:32:39 +0200 Message-ID: <20250403203241.46692-4-philmd@linaro.org> X-Mailer: git-send-email 2.47.1 In-Reply-To: <20250403203241.46692-1-philmd@linaro.org> References: <20250403203241.46692-1-philmd@linaro.org> MIME-Version: 1.0 Received-SPF: pass client-ip=2a00:1450:4864:20::42b; envelope-from=philmd@linaro.org; helo=mail-wr1-x42b.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: qemu-devel-bounces+patch=linaro.org@nongnu.org As of v10.0.0-rc2 this test is still failing on macos: $ make check-functional-aarch64 V=1 ... ERROR:../../replay/replay-internal.c:235:replay_mutex_unlock: assertion failed: (replay_mutex_locked()) Bail out! ERROR:../../replay/replay-internal.c:235:replay_mutex_unlock: assertion failed: (replay_mutex_locked()) This is tracked as https://gitlab.com/qemu-project/qemu/-/issues/2907 Signed-off-by: Philippe Mathieu-Daudé Acked-by: Michael S. Tsirkin Acked-by: Richard Henderson --- tests/functional/test_aarch64_replay.py | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/tests/functional/test_aarch64_replay.py b/tests/functional/test_aarch64_replay.py index 04cde433bcf..029fef3cbf8 100755 --- a/tests/functional/test_aarch64_replay.py +++ b/tests/functional/test_aarch64_replay.py @@ -5,7 +5,7 @@ # # SPDX-License-Identifier: GPL-2.0-or-later -from qemu_test import Asset +from qemu_test import Asset, skipIfOperatingSystem from replay_kernel import ReplayKernelBase @@ -16,6 +16,8 @@ class Aarch64Replay(ReplayKernelBase): 'releases/29/Everything/aarch64/os/images/pxeboot/vmlinuz'), '7e1430b81c26bdd0da025eeb8fbd77b5dc961da4364af26e771bd39f379cbbf7') + # Failing on Darwin: https://gitlab.com/qemu-project/qemu/-/issues/2907 + @skipIfOperatingSystem('Darwin') def test_aarch64_virt(self): self.set_machine('virt') self.cpu = 'cortex-a53' From patchwork Thu Apr 3 20:32:40 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= X-Patchwork-Id: 877946 Delivered-To: patch@linaro.org Received: by 2002:a5d:6dae:0:b0:38f:210b:807b with SMTP id u14csp3466028wrs; Thu, 3 Apr 2025 13:34:34 -0700 (PDT) X-Forwarded-Encrypted: i=2; AJvYcCVFLrvqVp3zqL1QcNBL3vJuIPdrZvOcv1pg1/oRu2RB4Xqw4VrIViM+/zj17qp/VKE+YCyvbw==@linaro.org X-Google-Smtp-Source: AGHT+IE1vuyJ4kusXp64253h4hvu+aVAHFO5a02dto08GVHRc/XMxPswklyUVZdCg5rK7QOEd2nt X-Received: by 2002:a05:620a:192a:b0:7c5:6a04:d0a8 with SMTP id af79cd13be357-7c774d27393mr98688985a.5.1743712474193; Thu, 03 Apr 2025 13:34:34 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1743712474; cv=none; d=google.com; s=arc-20240605; b=fS4IjtoeRCh4gfrARWV/6fUP+Ast0GPiPYaoOvd+N1X9dX0A3LLZ+p06dszSayS03D vV0fW2qfs7XwMhwZ10UkXR5NY4EEvnpY5wesb6pkRrRzi5ByaTKk795e9ZhCotWv3r+8 nHhqsclVXmECMpWdYEk89b/X46dQhevzPCSHA0G//ZoT6TP91lJV3EkYb1NRS5N1K44O M2Y0bQv19HCphBJg4dnzVjGDHn11zovT2pMSpeCQCyqess3pL7lxtr7ZKiVOfEDkpV73 a/tfuI5B6tbkAHwCPHTnyXn5eXZkQDBKSAByG2rpC/eOSKW/uuDEJTf5jnKyIxXMVAqI DAOA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=Lv7WRDAe+YGQs2mxscSeBnIuH1FPhg0M1NDpEDTQH9Q=; fh=Mg3Q/MQi4drPeKmQITgpMs6kx0xorjEcFN5p6eOb664=; b=HttXvVVB5hDRR7geRKfLaa0vFkhA8ufQ81zd9XSUho6gux9huHTa7EFknsr7aj+vlq 8zCEfWNrWrlxCN2E6Ww/Qn8BfgmhdpkoHd53xWtFYy+4tmxDYNEnzWLV8Md/odsbLdCN eAK3KNTmBiIqmADjAtZGbfQ+LSB686K3GXgQD2EdZ1UCpjWj8uGvqYz9SOg0NzGvaKU4 JfbhI2kgF8atDdHOK9yQBukpbNrQBmb3p3ndgzaY2RyEaoVGpbSSMGfCtSr0sI62AxA8 CFYRb8RaFNoDwqgo6wzklm8P1SfpTXVnadT6gM84vVD/IaXUhwGP4H+AtIcZ6vWWULzw cWmw==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=kG1+Z9th; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org; dara=neutral header.i=@linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id af79cd13be357-7c76e95de3esi182326785a.149.2025.04.03.13.34.34 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Thu, 03 Apr 2025 13:34:34 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=kG1+Z9th; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org; dara=neutral header.i=@linaro.org Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1u0RFQ-00040y-9I; Thu, 03 Apr 2025 16:33:12 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1u0RFM-00040V-6U for qemu-devel@nongnu.org; Thu, 03 Apr 2025 16:33:09 -0400 Received: from mail-wm1-x334.google.com ([2a00:1450:4864:20::334]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1u0RFJ-00044K-3f for qemu-devel@nongnu.org; Thu, 03 Apr 2025 16:33:06 -0400 Received: by mail-wm1-x334.google.com with SMTP id 5b1f17b1804b1-43cf58eea0fso6984905e9.0 for ; Thu, 03 Apr 2025 13:33:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1743712383; x=1744317183; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Lv7WRDAe+YGQs2mxscSeBnIuH1FPhg0M1NDpEDTQH9Q=; b=kG1+Z9thqJaXNdVDgkeNHywmAxsEN+Ssocu5xDV8l/V8ufcm3fsDPDpE2karm1hRsp cI2D0OO/g1QDnFsS/9habPvxRplPqxJgV77VK7Vb/NucSkjn+K3goLbG4sfYXkNG01SY 18w8LVhBVI06W5OILZ6MaocaOsCy/C9V5rmaD6Zp0pcIWjEHHUayjIIwD/Nw26ZE8snY 9WwOgBEDgUZa6Xyo4wnPGWtp4hxx9v1W/HvRacrfYjc8l0zdCmASkXwc48ZnoA6DA802 z3q5cwz95qYa7+UU+DGbO4emPvOVaUHULeCboUzVZ12lNUXEKG6nenUoUZi31CpgKVyx PxFA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1743712383; x=1744317183; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Lv7WRDAe+YGQs2mxscSeBnIuH1FPhg0M1NDpEDTQH9Q=; b=SXfUJFF9cqRn2AK+eWVCrGmROXQEWEcDQXxEgusClfFnSfj8XeaXbxKpIdPT7yFbxP ooUCzejnsOGfJKeA9ctbBhwbo+FrSnFCgXj8OF/vuKFB8gKnw3EnZ2Xz2fnFfr/lTGk/ 8DoxOML2d4cPrC/Ds1WR39VMClIp/JwPD3412SnCQ28HkJHZKbdRECdLk1zOWaSOhZwe tsaH6T9DlCVMiFw67Mhgnxt/jXprJCRKqYneqZ9LQoopytrfovWxIHgeniNM8wTZl4SS hIa2CGKcAH0ExyHKp+NdYNnKGj5KFpDwEWefUNz/rz1nuJGKneu6/r1ITluMOaq4kvxK LYUg== X-Gm-Message-State: AOJu0Yw9wXy3bTaJN1kRRfPZivPMdl+57PmNlG2Wp9IRW36cJZxYdBLe 8dm7elBgb+zzgB/PfwvEuUfkEHz+R+02v2rzX6AnhWRjZOmc0xTPSs2F2qeV7GmopWUEMzrAsGZ Y X-Gm-Gg: ASbGncubFWwuHf4Bc/dRrKGkPsfhOgedVRhUjgRctMtgCMZVcsbPmatqQRqO4/mXmBL rLAQwOqbVd/74LecJ5bU+0RwdoEdEd/cUz+CO4jkHoGEXVR990N60tAiYZRdQ9tUfuqqjphRJ6z 6P7kOSpxVD957VGoi5HeVDxTSZByzZWnIQun+oXVrx15DpABhSFD1kJ7XohBbGX4KPGwu7yTLiT gsUwQtN8OPV+xbWCYV41NZ6ogkjdKbSrUbF5mXnyrJrKYkuG9NEKnM5y9X+4ZpnzMy1LMReJWC6 e4SHhLZ1HwqGWJ2s0CQs1Mlc+Qj1j09wig2LH7xLdt6qeHn9mQwTIgOvR4sb4r3l0az/ixItkcR Y9ZjkY2ANfAZZ9Vg9fPWbh/Lw X-Received: by 2002:a05:600c:511f:b0:43c:e8ba:e166 with SMTP id 5b1f17b1804b1-43ecf9c3d51mr2840225e9.22.1743712383043; Thu, 03 Apr 2025 13:33:03 -0700 (PDT) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-43ec1660bcesm30716045e9.10.2025.04.03.13.33.02 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Thu, 03 Apr 2025 13:33:02 -0700 (PDT) From: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Thomas Huth , Laurent Vivier , Paolo Bonzini , =?utf-8?q?Alex_Benn=C3=A9e?= , Alexander Graf , Phil Dennis-Jordan , =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= , Fabiano Rosas , =?utf-8?q?Daniel_P=2E_Berrang=C3=A9?= , "Michael S. Tsirkin" , Richard Henderson Subject: [PATCH-for-10.0 v3 4/5] tests/qtest: Skip Aarch64 VMapple machine Date: Thu, 3 Apr 2025 22:32:40 +0200 Message-ID: <20250403203241.46692-5-philmd@linaro.org> X-Mailer: git-send-email 2.47.1 In-Reply-To: <20250403203241.46692-1-philmd@linaro.org> References: <20250403203241.46692-1-philmd@linaro.org> MIME-Version: 1.0 Received-SPF: pass client-ip=2a00:1450:4864:20::334; envelope-from=philmd@linaro.org; helo=mail-wm1-x334.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: qemu-devel-bounces+patch=linaro.org@nongnu.org First, the VMapple machine only works with the ARM 'host' CPU type, which isn't accepted for QTest: $ qemu-system-aarch64 -M vmapple -accel qtest qemu-system-aarch64: The 'host' CPU type can only be used with KVM or HVF Second, the QTest framework expects machines to be createable without specifying optional arguments, however the VMapple machine requires few of them: $ qemu-system-aarch64 -M vmapple -accel qtest qemu-system-aarch64: No firmware specified $ qemu-system-aarch64 -M vmapple -accel qtest -bios /dev/null qemu-system-aarch64: No AUX device. Please specify one as pflash drive. Restrict this machine with QTest so we can at least run check-qtest, otherwise we get: $ make check-qtest-aarch64 qemu-system-aarch64: The 'host' CPU type can only be used with KVM or HVF Broken pipe ../tests/qtest/libqtest.c:199: kill_qemu() tried to terminate QEMU process but encountered exit status 1 (expected 0) ... 7/26 qemu:qtest+qtest-aarch64 / qtest-aarch64/test-hmp ERROR 24.71s killed by signal 6 SIGABRT 2/26 qemu:qtest+qtest-aarch64 / qtest-aarch64/qom-test ERROR 71.23s killed by signal 6 SIGABRT Suggested-by: Fabiano Rosas Signed-off-by: Philippe Mathieu-Daudé Acked-by: Michael S. Tsirkin Reviewed-by: Richard Henderson Reviewed-by: Thomas Huth --- tests/qtest/libqtest.c | 1 + 1 file changed, 1 insertion(+) diff --git a/tests/qtest/libqtest.c b/tests/qtest/libqtest.c index 2750067861e..fad307d125a 100644 --- a/tests/qtest/libqtest.c +++ b/tests/qtest/libqtest.c @@ -1788,6 +1788,7 @@ void qtest_cb_for_every_machine(void (*cb)(const char *machine), if (!strncmp("xenfv", machines[i].name, 5) || g_str_equal("xenpv", machines[i].name) || g_str_equal("xenpvh", machines[i].name) || + g_str_equal("vmapple", machines[i].name) || g_str_equal("nitro-enclave", machines[i].name)) { continue; } From patchwork Thu Apr 3 20:32:41 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= X-Patchwork-Id: 877944 Delivered-To: patch@linaro.org Received: by 2002:a5d:6dae:0:b0:38f:210b:807b with SMTP id u14csp3465947wrs; Thu, 3 Apr 2025 13:34:18 -0700 (PDT) X-Forwarded-Encrypted: i=2; AJvYcCWm3gRZrlFr/gZoXqgn2tbEfNEIGGWY/1/QAIeou84w3mlXHdUmASyiGmh+/tizvKa/l00+jA==@linaro.org X-Google-Smtp-Source: AGHT+IEdoBitnyHxU1nwQNlbjZfu6ma87bwJn0dmeNMTKLaQRG3VQXujOyMjFfu2awwmgeBAXCx+ X-Received: by 2002:a05:622a:1102:b0:476:a713:f783 with SMTP id d75a77b69052e-479249cb245mr11425291cf.47.1743712458292; Thu, 03 Apr 2025 13:34:18 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1743712458; cv=none; d=google.com; s=arc-20240605; b=PTSog/9EdSE8cLh4FsEgoCYcivYhOcPLS+RjgCv2XwLtHtS22gsm6eRFqDezTtcYaK 7sOJLQgHQBem1fus4nId4JybpAxTYbZI9F7m2AYeXMXqzGWMRf8+sqk1w1lbI155vWyp 7xWT6BoPI7HAkXOVHd10jq+3i/elW1Rw7rf8g6Qq+cevZRAf9XAibXrujpjJyDhihGfW Lh9A6Ihmvy1AbluZ3iwU7lvgBsNKXD0dOHENQCv/MUzKV5B781wqWobO1uxZPfdQxepw xbAkJoo9PkE22JO45k5Mr7ChTnzW54jNnoOoACj3Vhp7dEMRa5sEb5oWq8YUvWm28a9X SuFA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=i7P8huLNBvJOP7nd4dB1l20n900j9HtETUh1v4TfTS8=; fh=sESPgU9JIyhj9bqSUDwaSvaNA+rDHMK4UocW1iEAgoM=; b=Eu1AyEpXgI5m+R8XCqEwnnmHEDMWXqBMxNaqsCkQc0HUy1Rx/dqgoeRycLPWUD6GWu ctlbdvw/Ed/cRC6F38NacP2kW8LnmnCqQperH73x1ZdZIhxXZ24VSE0+8DOKmNvIuth/ GmQhDf5oETrUwSseIjTjmilrvqz1FTxJXFMueZA6rDmr8FIaXbFaaqXZLI0jGPxcdoxb 20kVxHqujRTCDIvBTVNmypYaTS0OgkbS2mfYCAoAYu9oELtlqzNA/m4B2IsqFELUJKio Jmu83CTMZzWiFI6TVBtKfuMvYp204/CnCGcpMM/dd8z8Oqg3YOIkbnae3839Djdk5b1D ucdQ==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=BGRZwgNr; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org; dara=neutral header.i=@linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id d75a77b69052e-4791b1ed565si17801031cf.635.2025.04.03.13.34.18 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Thu, 03 Apr 2025 13:34:18 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=BGRZwgNr; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org; dara=neutral header.i=@linaro.org Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1u0RFa-00044y-83; Thu, 03 Apr 2025 16:33:22 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1u0RFP-00040t-Vi for qemu-devel@nongnu.org; Thu, 03 Apr 2025 16:33:12 -0400 Received: from mail-wr1-x435.google.com ([2a00:1450:4864:20::435]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1u0RFN-00044Z-V8 for qemu-devel@nongnu.org; Thu, 03 Apr 2025 16:33:11 -0400 Received: by mail-wr1-x435.google.com with SMTP id ffacd0b85a97d-39149bccb69so1177080f8f.2 for ; Thu, 03 Apr 2025 13:33:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1743712388; x=1744317188; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=i7P8huLNBvJOP7nd4dB1l20n900j9HtETUh1v4TfTS8=; b=BGRZwgNrZYhKyISI+Sp69uko6dWskSKz0zTeKDuCfgebBsnPXlBItKeeWHrwEi/j03 /GwLghqjdC9Zpcj6pht9DYAohk//m5zyljD+4qVtWdWjFgOeXvE8B9wzAPdkjaqweSy5 tKTyp5lHYz9OM538RG766oDSndZVyLXRXN7WKcTc16MFl5fRQFbN6Jjj0VbRTtrbykwZ Zd4QY3sZ9zVInLNYQmD34fEwD+pye+NRqQN6CeZmL6YiBisCQltJd8k9fXR95HRLKMK1 9EpqY2pbgBiB5WtCSlfP2rhJwWGdl1fLi1iBtwyjm5U6G+ObMIxNqK9toP9fqGkQ2i3n ySIQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1743712388; x=1744317188; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=i7P8huLNBvJOP7nd4dB1l20n900j9HtETUh1v4TfTS8=; b=u1Ikw7CEKm5MOw9swmHaF9iJosZtOljGjMd7n7PnKqplO3oPj8wTM6hIEpywQ+vPKj gEjbL+qDuWSN83wTPQIz/6lEozizc5LnUB4C7oJorLF9O8b5DFoOLCd9PyO9nn3Ae8Ph n1l0kjNmiOFaWLdvLLs6WQ2RpzoeH9cAPrgH6ZvyCN2Dh8l9P3uNMHSLO9qWjPxHnJZ7 9aZgFfYONVK+O5aq78GpJI2sjP10JgTryf6Ux39hC4JOq7feO+dGOeys6tXnv+W8jFBz KhPuZsqtUZjbGaTaKAbPL1SM49yRH+9tPC/7HygxmkuJNASnW9hReV8lT3HX7MkxIc8A Cqfw== X-Gm-Message-State: AOJu0YzEnambyn3cXFGFXqlYqlUlgWNsmnI+cHaMJTes9T05FJ4xGnml J7BAQAjITY09A4IkS4Ur+swUb9mo6JK6bIghIVCec5BFfEI7H7MpvDoyVYojdT2E5ezBNMSb/aQ 0 X-Gm-Gg: ASbGnct4y0pjgJs/4VVzgaZZR/RJr75uUwLSbEIeNLogqSonfdKP0kADwBfKqSmKpUN hptu4yyTJNVKMpQnan4cgpZjTtHvppWqdkWXfR+SEYBg2mdrhboBYE2cFFapmxgiey7mUc7ToMz hf5eNAdjsAhUEwVjP/6eXCFjHoALki0IlmDqJibztGnTSfhEe/rZblPmaUL5ctLqs18S/qLbckk /NnwhF+2fJk9pvWufRSoCFaFh/rrAOW674fGomej68h676QWfgxCfpgohEuT2vnunvvNe1I3wE/ qpVPmkCjDBFfF6SwPDbfetlA7N/lN5LJZs50az/seUO1PTYGMH9Ik0bhorA1qj10fla6KjUq6Kr 2P5FD139eBOW6f6x+rlpertPQ X-Received: by 2002:a5d:5f52:0:b0:38d:d0ca:fbad with SMTP id ffacd0b85a97d-39cb359bf41mr627115f8f.14.1743712387831; Thu, 03 Apr 2025 13:33:07 -0700 (PDT) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-39c3020dacfsm2666744f8f.72.2025.04.03.13.33.06 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Thu, 03 Apr 2025 13:33:07 -0700 (PDT) From: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Thomas Huth , Laurent Vivier , Paolo Bonzini , =?utf-8?q?Alex_Benn=C3=A9e?= , Alexander Graf , Phil Dennis-Jordan , =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= , Fabiano Rosas , =?utf-8?q?Daniel_P=2E_Berrang=C3=A9?= , Richard Henderson Subject: [PATCH-for-10.0 v3 5/5] hw/arm: Do not build VMapple machine by default Date: Thu, 3 Apr 2025 22:32:41 +0200 Message-ID: <20250403203241.46692-6-philmd@linaro.org> X-Mailer: git-send-email 2.47.1 In-Reply-To: <20250403203241.46692-1-philmd@linaro.org> References: <20250403203241.46692-1-philmd@linaro.org> MIME-Version: 1.0 Received-SPF: pass client-ip=2a00:1450:4864:20::435; envelope-from=philmd@linaro.org; helo=mail-wr1-x435.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: qemu-devel-bounces+patch=linaro.org@nongnu.org Unfortunately as of v10.0.0-rc2 the VMapple machine is unusable: $ qemu-system-aarch64 -M vmapple [...] *** Terminating app due to uncaught exception 'NSInvalidArgumentException', reason: '-[PGIOSurfaceHostDeviceDescriptor setMapMemory:]: unrecognized selector sent to instance 0x600001ede820' *** First throw call stack: ( 0 CoreFoundation 0x000000019c759df0 __exceptionPreprocess + 176 1 libobjc.A.dylib 0x000000019c21eb60 objc_exception_throw + 88 2 CoreFoundation 0x000000019c816ce0 -[NSObject(NSObject) __retain_OA] + 0 3 CoreFoundation 0x000000019c6c7efc ___forwarding___ + 1500 4 CoreFoundation 0x000000019c6c7860 _CF_forwarding_prep_0 + 96 5 qemu-system-aarch64 0x000000010486dbd0 apple_gfx_mmio_realize + 200 6 qemu-system-aarch64 0x0000000104e6ab5c device_set_realized + 352 7 qemu-system-aarch64 0x0000000104e7250c property_set_bool + 100 8 qemu-system-aarch64 0x0000000104e7023c object_property_set + 136 9 qemu-system-aarch64 0x0000000104e74870 object_property_set_qobject + 60 10 qemu-system-aarch64 0x0000000104e70748 object_property_set_bool + 60 11 qemu-system-aarch64 0x0000000104e69bd8 qdev_realize_and_unref + 20 12 qemu-system-aarch64 0x0000000104e258e0 mach_vmapple_init + 1728 13 qemu-system-aarch64 0x000000010481b0ac machine_run_board_init + 1892 14 qemu-system-aarch64 0x0000000104a4def8 qmp_x_exit_preconfig + 260 15 qemu-system-aarch64 0x0000000104a51ba8 qemu_init + 14460 16 qemu-system-aarch64 0x0000000104f7cef8 main + 36 17 dyld 0x000000019c25eb4c start + 6000 ) libc++abi: terminating due to uncaught exception of type NSException Abort trap: 6 Disable the machine so it isn't built by default. This is tracked as https://gitlab.com/qemu-project/qemu/-/issues/2913 Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Richard Henderson --- configs/devices/aarch64-softmmu/default.mak | 1 + 1 file changed, 1 insertion(+) diff --git a/configs/devices/aarch64-softmmu/default.mak b/configs/devices/aarch64-softmmu/default.mak index 93f4022ad62..ad8028cfd48 100644 --- a/configs/devices/aarch64-softmmu/default.mak +++ b/configs/devices/aarch64-softmmu/default.mak @@ -9,3 +9,4 @@ include ../arm-softmmu/default.mak # CONFIG_XLNX_VERSAL=n # CONFIG_SBSA_REF=n # CONFIG_NPCM8XX=n +CONFIG_VMAPPLE=n