From patchwork Mon Mar 24 02:26:54 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Peng Fan \(OSS\)" X-Patchwork-Id: 875835 Received: from AS8PR04CU009.outbound.protection.outlook.com (mail-westeuropeazon11011058.outbound.protection.outlook.com [52.101.70.58]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1C42913A41F; Mon, 24 Mar 2025 02:28:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.70.58 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1742783289; cv=fail; b=d4dwqMzOKLmDXkSCLg+va1n+Qs9ISargpIf7U3LfPA3mOMvBjEWtoCSqq3XwaFrdkKurQ7JgQQ9Y2prCEt16238HKbDfmMZxj5pV8+/0tss2fqBEQD1StNGKRSpJsAa8VwfMUOCSJDAsR5L85GFhuDUrFlUqldg1ck6qTX1RhR8= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1742783289; c=relaxed/simple; bh=4vNLP2c/6BCyUYt7t9hrt/lv306brQJy9Ej0gzwLyXA=; h=From:Date:Subject:Content-Type:Message-Id:References:In-Reply-To: To:Cc:MIME-Version; b=CIr6VCzt/2otvCg/nAtDUHZ2Z9teS1WSeIBfDbP03xf9rL1mdz1uOLGBqCQd2oRK6e1LeYj4FesgfbvnkXPHbOdMZXoMXIuyOLTMDdPDXYLire32dPM7kFcM0/ye/Z0UMmgWuAbgqmnFHlybRObr9wHkMffvfWMoq/sfnBJD0hM= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=oss.nxp.com; spf=pass smtp.mailfrom=oss.nxp.com; dkim=pass (2048-bit key) header.d=NXP1.onmicrosoft.com header.i=@NXP1.onmicrosoft.com header.b=ts8MrnCL; arc=fail smtp.client-ip=52.101.70.58 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=oss.nxp.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.nxp.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=NXP1.onmicrosoft.com header.i=@NXP1.onmicrosoft.com header.b="ts8MrnCL" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=F8G03xcj23xeet0BvdEoJpVieUv4gC8z+mN81e25K4FP88RH5ZxyQKZeByajy1mq/nF+nNz7H7MTtBBpiYq41qyxp+rf/H2caXCkaioiIulayh3w7Yd3HXU8RzcGYpQSFyt+rEdeJxC2IREfD/Iqim16F02nEg/fNiFItYmC7Aiytki9CqM2pcAQ+EIVfz8UPlJ8dzQpeb9ltNMdx2W8+Ms4ZzmVQ2hcPiVmHcKykQOsBk8PMmA+jLu9r4nnoRSfmZfPLOvB1cUJNrrUxKTSfF515M93Uw+ZT8cZTN7N5lY9FLinp4rpNwFk+YpgjzDVmFKtcVb9C02j8SdLjFWSfA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=r5rPs26f71GhOEMbPESTDzq/rS9rRl+5n49VPh/g3II=; b=f7UtMoFcIdO9yx9+5BIYBJSW3E1qDfK1vogKZOMVRhDxlkUVYaskv9gnpkQoz+dqcdhf0zXwrFRU3TKvWbA7QHgrlMRb/ukmqqf7L9WCi9mo1fIJviJG0Kvyau3LjlrgLjpZ/+HWmeEx6GJZZfSPxbah15gN9UXhCEKbnpD3t3kKhdZRdwGFd2IHS7YmxYfmCdz9Q3/yVCLcLLEA0ExqsaayvBQBezPQTEboKawOOuhKfzdc2wxhDbT1mQPcWp05GVhUT3QCDmGAKuxdIA8XFaY5l0FKk0nCGbSQ21OqkYt/lCBHVX4tYtrMYRKBouK9bN9bAPuLTPJPxtrDYSbXRw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oss.nxp.com; dmarc=pass action=none header.from=oss.nxp.com; dkim=pass header.d=oss.nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=NXP1.onmicrosoft.com; s=selector1-NXP1-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=r5rPs26f71GhOEMbPESTDzq/rS9rRl+5n49VPh/g3II=; b=ts8MrnCLwyrJFScXtblsK/AUnQnzj00ewl5dRjIYI1MgyAXBy+bAvMWqEpNsb9shpCuEx9vJMD6TQ1fdDvCQrMq0DGQIjdRHG5urUAkhqnjirzT5uC3aH3xb7rohmxnxMXGYtHGyA/isGe4PNHciLZB+YUy3v/wOctEA+xpmYx2wRcnUY2EE4cGO6d3hRDHGaXdpqDMFev5des8Qx9ypKCPwahsJsv6ltJJ3u2TBIwBbPQ4rdAJEehcd0R5NC4Zvg4CNZL10Cn33qZxpKIBO9aJY3Hno0uVoaiOozJC9uB9+RVcoXfxh3ImyOot4kkhgjFxQMgnHZ+mSh1BtcUqygA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=oss.nxp.com; Received: from PAXPR04MB8459.eurprd04.prod.outlook.com (2603:10a6:102:1da::15) by DB8PR04MB7019.eurprd04.prod.outlook.com (2603:10a6:10:12b::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8534.42; Mon, 24 Mar 2025 02:28:05 +0000 Received: from PAXPR04MB8459.eurprd04.prod.outlook.com ([fe80::165a:30a2:5835:9630]) by PAXPR04MB8459.eurprd04.prod.outlook.com ([fe80::165a:30a2:5835:9630%5]) with mapi id 15.20.8534.040; Mon, 24 Mar 2025 02:28:05 +0000 From: "Peng Fan (OSS)" Date: Mon, 24 Mar 2025 10:26:54 +0800 Subject: [PATCH 1/3] ASoC: codec: wcd939x: Convert to GPIO descriptors Message-Id: <20250324-wcd-gpiod-v1-1-27afa472e331@nxp.com> References: <20250324-wcd-gpiod-v1-0-27afa472e331@nxp.com> In-Reply-To: <20250324-wcd-gpiod-v1-0-27afa472e331@nxp.com> To: Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , Linus Walleij , Bartosz Golaszewski , Srinivas Kandagatla Cc: linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, linux-arm-msm@vger.kernel.org, Peng Fan X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1742783224; l=2462; i=peng.fan@nxp.com; s=20230812; h=from:subject:message-id; bh=SJchHRw4zZPQnugS+LAJqb6eMZ2l9bEbL+5vU36pmZA=; b=LzpZI5/I7MT5AcdPpMCfdi2XhaKUCRl4VIVwSOVAtllci7LletnO/DUG9E6G9SmPt3LILgjfN UDZ6imaNW8/DEjdoVKtwk4VRVn3TsrWIB4M7EeSPDZ9qIXXEFVfXXgg X-Developer-Key: i=peng.fan@nxp.com; a=ed25519; pk=I4sJg7atIT1g63H7bb5lDRGR2gJW14RKDD0wFL8TT1g= X-ClientProxiedBy: SI2PR02CA0014.apcprd02.prod.outlook.com (2603:1096:4:194::19) To PAXPR04MB8459.eurprd04.prod.outlook.com (2603:10a6:102:1da::15) Precedence: bulk X-Mailing-List: linux-arm-msm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PAXPR04MB8459:EE_|DB8PR04MB7019:EE_ X-MS-Office365-Filtering-Correlation-Id: fda346e4-6efa-40ed-8a31-08dd6a7b821a X-MS-Exchange-SharedMailbox-RoutingAgent-Processed: True X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|366016|1800799024|376014|52116014|7416014|38350700014; X-Microsoft-Antispam-Message-Info: =?utf-8?q?dg4hD/Hw5luooYCIZdD/dADREMGp8qd?= =?utf-8?q?VTJfLIC75nfzMdMkuYR8yCXeh1wIF0rDUE0iupncDT7i9QakUmDsH9AJZVoj59Kf0?= =?utf-8?q?pQFkVvhWV7YrjvylyTyqBWaNAbXpe1EvV/Hq9Qn4OGdOth6NipIsZGlqg1lrwbVVq?= =?utf-8?q?Du7uwKzOW3hj71o8ZmedOfaPApOn2kv4oBEL40kkma8fb1LxJRCHG559+yaAm39pT?= =?utf-8?q?6TVhmbd7mu9tjlrnG8Ps9AigmN1s+ksVgo6AntlOtXK1XSq97pZdlt7xMH//QSuVV?= =?utf-8?q?KbKKhfaT7BPeEi0k/KQkt7ncxHeEcBvl7WYoHp3hUimafOT+4IqtoybwrEDBd4dFH?= =?utf-8?q?tkcNyyr60YV7riH5G1zWeTGJ/u16oSFsMFRKp1rD0FqBphwGuD4l89EKbnE5QFSH8?= =?utf-8?q?iDwOEEA89QNcpskKTeGPmhTm4BQtepRaDPPYPv+8SkTfaLQt5lpfeX16S3Iqf+W1J?= =?utf-8?q?KI06o8WEBheI6vnH+ogYRT4D49j7Sy5JjjS4fX2S2HCtDIVLobU28MRlX/ZPfFVTC?= =?utf-8?q?NlsTCvtA9t0RsCgEOm4KyH5S8swC3Cu76GMLR9BVRbDjP5kzpvG9uH867KadoXNzx?= =?utf-8?q?7T1HZZsGj2qJFqDwf8g+Twfp9OOe8vqHJhLO6LgDGRHxFgbWlF/1+pNWcxW3B7Ttk?= =?utf-8?q?qikgPAxqiye/AEc46AKkXE+8359HGYj64SvAC+7/cifgb79urRFWf3Yvht2R6Yw0Z?= =?utf-8?q?WZumG4qeYqCmf+/ZvmMLcjq4pRAw9hQqJM4GEDZvx+cuuNMkLvueWepZE42yFhCpl?= =?utf-8?q?JEfygALx4E2xXqdi8niM5rKNYSznyfEyeya4IsnzvESzq5f9rD9GUDSz9ueIR0zmJ?= =?utf-8?q?jG/XvxusrHgi2pMuxcbhXOfVCxfHNx2x1hpq0OgIYPlWZ7yGl0Umj6crnZRnoXB/5?= =?utf-8?q?J1/ZFGx9Wdko1C2H/1YaE3k9zUE6lf6UOgLJsuxprmdGkIVi7aM2c382eI2ZrvXAU?= =?utf-8?q?CNMINJgIWpfEkWUHGURNaPdhWb2DE5fbzJkVH/snt0274DgGhlG7YJ3u2h1euvVgh?= =?utf-8?q?PZcE+jQaESpvlnOZMBOAWLuYmWpJ9fLMdWjNR7yfw9WhEK62LEw9BtaG/h8WsK4QJ?= =?utf-8?q?BVsfsMNvdYwczgqsPjdnH7CNopoNljStQx1G81wxl5ksu81Pf3isRr6kKq8IoqFA4?= =?utf-8?q?a9BUWkTJpV6c+KWMNvR7Cm5Y9ZRgzCK8nEFNmR2VFudhM1R9FLNppFyEtoutLv+PA?= =?utf-8?q?NA+FpoY2hMNjpAStgrOOe5ECnwmscNHVVxiMYDuUZxc+C96OcQiUhiy+bbZYC+XpH?= =?utf-8?q?E/LuNpBRH+tKGqcQYjCX861AYtGbce5fLSxrS1O/rOWxmZV/0ERZYFizTBLE3AYbw?= =?utf-8?q?H9xqW85FEJE0R6+km96Hpxdhl0RW+Sehy6AY6HxhqkA3GQhzIAbqUD/iWNVWvg2Ub?= =?utf-8?q?fe7dwL+KokJ?= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PAXPR04MB8459.eurprd04.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(366016)(1800799024)(376014)(52116014)(7416014)(38350700014); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?q?SEqQy4qnSAIIlV7LJUGTCp+3Qc96?= =?utf-8?q?MuUwbPYN3LtKpvu2uxwAvOkrGvXgBtgrER7CQb/W/ij0qlVLmnsgIBNAw7ExUrfVn?= =?utf-8?q?TtLhxVjAi7xdrFMpxR7AGHRwq2rUj+hY+vJYm5TgFnQQvwTKgkhMZH55sc47mkmr6?= =?utf-8?q?4s6VkOqlEPjq4La+caDV5AMXc0G5ja8q2WXEDIdtzyrcbsQ9r4p//eCjPG1ZkP8lh?= =?utf-8?q?c3GilbtkrfUBmWlk4KM9UwW6WXiDyZeBt51ytbtO+On5zEIXMSfZigFnWbgMBqYNK?= =?utf-8?q?RVpdhlFozD+w9VscMWtUGbKq+udeYR/By8hUih/CMSLeWOXVLg0RKBuLsTukzxm7b?= =?utf-8?q?uQj9eeG2AEMc2NcqiOk49OU+E8+hoeZf2rPaoyWB6XuUQbThE7VmpkKT9GoJ6qIQs?= =?utf-8?q?qgjAxmatJtGnVHlv+NOK9xrAXGm51/j6zbcDb2xpeZOW92pCV9fwpc2tHH8kS+MZj?= =?utf-8?q?S7ZcXjuHE18XJed3kbODCOwZRjvO7g+2L/P+wS42iZ3o/Qnksw5mR3RN1yf9T+BPj?= =?utf-8?q?wDbGbfBKj0Mfq9WUn7m/ALUIZQyCVpNXbkqY5IGOiE5MvvxyPvFehydlrNDF42/9E?= =?utf-8?q?S4GniyQw0NBbZ0iKMM6ORzaQCyrXmuPY3jfZ4mFR+gb4/4e6MMwsmi4EL19QoiyAw?= =?utf-8?q?+WkEc0qpiddx2Uoe4fsABYzDbb24ylspqZqH8Qi4itkyt00d4cA5o+4V502knLgy9?= =?utf-8?q?ml+X/1InSnp2edm9KPRCBT1oR2iv0x7ZSRSGXxvHLwEXtrYECB7zIe1d3R6XZkmKB?= =?utf-8?q?W2kLZc86B+EHH8z1iXs2MfqDz9OklwVxKztYd83oYTU65Eve3kBk4ftXL9GZ33UWr?= =?utf-8?q?h2NIyAhPvWBXfTiRnWTvlAGCRZSX/CFCldRQAr8qhlR8Nl6nPqiNg0TOx5LjUVQAH?= =?utf-8?q?ZPih11UuDIO+aK0gw/XB/SmBGx1YFa/RSE3p0SdCKz4rEKPzDUBHC6Duf7s/GxZgj?= =?utf-8?q?2tEijXuXSLkCnGS5RVbTZOWbMQGflXqlpph90JnCh4nHVgCtI2viQZs4fyWg7K6EZ?= =?utf-8?q?/gyq4DsiHv/xqWc5/4TiXoMlW4IhFbKSbDeWsQb8JdYQYFlYM4UuiLRc28bgy07LF?= =?utf-8?q?APB6w4/dICfZCovGwvwewNzDcBZpciZ/qayTF8hwcOKMeHvdYZLo37AgWOxhSRp2a?= =?utf-8?q?JOAjM9xR+rJwS8m831Ve4iO4WP/dnA2wFTieIaU44p9FLxy7lmSjBbdQK1PTNNPfh?= =?utf-8?q?aWi1594pDUqbaPbbnVn7gJwq/YsdZBs7lG1fv0nsjN+LPWPF9uGRNNtdG7Hi5J02y?= =?utf-8?q?afjITrVuix4VuokWuXlcpE//kZVr1k8G7X2DHi3Shyj2BV8dItg2azX9Yr+XCQC3J?= =?utf-8?q?qxzYpnnpUE9nGlRewCDdbgOmC6tFCpJvJ3ar/v6qSBYJ7OjhEnHu4KtALmIzyuoWg?= =?utf-8?q?31Ozm58RZtfS8RRU9AC8ZXAMXztrKYmjl3HOsMzuONti/tDBBfVbWJ81XLb8nfsvQ?= =?utf-8?q?Lfm8IfIh0pE0WR+6ye/vqeONJJqvaL9lZuj/t+30mi0AMqcz2gqNAwFempxVLOb/m?= =?utf-8?q?g0psFIESRQK6?= X-OriginatorOrg: oss.nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: fda346e4-6efa-40ed-8a31-08dd6a7b821a X-MS-Exchange-CrossTenant-AuthSource: PAXPR04MB8459.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Mar 2025 02:28:05.4001 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: nRfZikDnDqaFid/eS3G6cCko0IObfhWKLEcTC+v21/zvDevUUqcvGHoB5GpH+c939pkM6mHe/G4gLLrfsrMVrw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB8PR04MB7019 From: Peng Fan of_gpio.h is deprecated, update the driver to use GPIO descriptors. - Use dev_gpiod_get to get GPIO descriptor. - Use gpiod_set_value to configure output value. With legacy of_gpio API, the driver set gpio value 0 to assert reset, and 1 to deassert reset. And the reset-gpios use GPIO_ACTIVE_LOW flag in DTS, so set GPIOD_ASIS when get GPIO descriptors, and set value 1 means output low, set value 0 means output high with gpiod API. Signed-off-by: Peng Fan --- sound/soc/codecs/wcd939x.c | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/sound/soc/codecs/wcd939x.c b/sound/soc/codecs/wcd939x.c index 0a87a79772da6c0ed3c7dd7d098e949b9cead2a4..f8d7d03f84fcbca57826dd43e9281aff5b225525 100644 --- a/sound/soc/codecs/wcd939x.c +++ b/sound/soc/codecs/wcd939x.c @@ -15,7 +15,6 @@ #include #include #include -#include #include #include #include @@ -201,7 +200,7 @@ struct wcd939x_priv { u32 hph_mode; u32 tx_mode[TX_ADC_MAX]; int variant; - int reset_gpio; + struct gpio_desc *reset_gpio; u32 micb1_mv; u32 micb2_mv; u32 micb3_mv; @@ -3239,10 +3238,11 @@ static int wcd939x_populate_dt_data(struct wcd939x_priv *wcd939x, struct device #endif /* CONFIG_TYPEC */ int ret; - wcd939x->reset_gpio = of_get_named_gpio(dev->of_node, "reset-gpios", 0); - if (wcd939x->reset_gpio < 0) - return dev_err_probe(dev, wcd939x->reset_gpio, - "Failed to get reset gpio\n"); + wcd939x->reset_gpio = devm_gpiod_get(dev, "reset", GPIOD_ASIS); + if (IS_ERR(wcd939x->reset_gpio)) { + ret = PTR_ERR(wcd939x->reset_gpio); + return dev_err_probe(dev, ret, "Failed to get reset gpio\n"); + } wcd939x->supplies[0].supply = "vdd-rxtx"; wcd939x->supplies[1].supply = "vdd-io"; @@ -3290,10 +3290,10 @@ static int wcd939x_populate_dt_data(struct wcd939x_priv *wcd939x, struct device static int wcd939x_reset(struct wcd939x_priv *wcd939x) { - gpio_direction_output(wcd939x->reset_gpio, 0); + gpiod_set_value(wcd939x->reset_gpio, 1); /* 20us sleep required after pulling the reset gpio to LOW */ usleep_range(20, 30); - gpio_set_value(wcd939x->reset_gpio, 1); + gpiod_set_value(wcd939x->reset_gpio, 0); /* 20us sleep required after pulling the reset gpio to HIGH */ usleep_range(20, 30); From patchwork Mon Mar 24 02:26:55 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Peng Fan \(OSS\)" X-Patchwork-Id: 876096 Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05on2084.outbound.protection.outlook.com [40.107.21.84]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 76D2D176AA1; Mon, 24 Mar 2025 02:28:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.21.84 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1742783295; cv=fail; b=TWvFwnQDQEVGsJ3Cc+EzcweOlGnCbhhAeRBM3HqxSCu+affCbvFEVbs32MsQAdJRj2ZmwaMxMkAYQdPDRt/kzpixOq1Z76ZvZehpn0Ql3DirVnM9Cps+5CA0dcWIhnvLSQiawxWEOwhNgIn49CZ/8OvdaFsDAHh9q7Fs1juVQqk= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1742783295; c=relaxed/simple; bh=KBxeSXnXKIjfokub+bLhLidG9dyvfKY3BY7BhN7WgKw=; h=From:Date:Subject:Content-Type:Message-Id:References:In-Reply-To: To:Cc:MIME-Version; b=qNjms2FOW4TaZVE6vT/G6vQZdC/n3KsO3XzbXwtviHrDAv/p8wbnM5DU0AILqmje6lPjQX9HFaCXdsC5/uGtMwrjORwzJvyjGtudjyMxkZGz2wErjpsOIeyIQ7nAmYThWeHQKr7PgYFTl7jlyffUcUaZXkPyqTEuZ2pDl4Y5VxU= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=oss.nxp.com; spf=pass smtp.mailfrom=oss.nxp.com; dkim=pass (2048-bit key) header.d=NXP1.onmicrosoft.com header.i=@NXP1.onmicrosoft.com header.b=Y1jZiPAi; arc=fail smtp.client-ip=40.107.21.84 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=oss.nxp.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.nxp.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=NXP1.onmicrosoft.com header.i=@NXP1.onmicrosoft.com header.b="Y1jZiPAi" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=hv3CcZJCiqnCWFeGmQRGXOaMOrn/QaXDj/rteDAAYtAd5+knpJVUTG80EiQxTBuyibH0877nkIlz0L68FfdA0zJ9G2XxwlQaTZxYLRxA9refANoJUawcy+DIyoTbh8iPAarTyVlMbKpZzNYNVc7prVyGktGi5KnMp56vTlD8dL/LlBfUak6xcgZ9L7BJ6N/pdMXfEn9oV7bAGjET5ywQ7L3OvRQmQMiEZZ4YqNJDKfmV6n7jrVrvQCbedt369Cn2aNKO2I3Vht2nE7rJvdyK+/GZ9dKs0r27HKxa2RU0+LzGQZb0kefuqv5HdJTygr4rp2bBbHB4i1w/PN1OYtaArg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=J1aHxFRghZpOloeIDuKT6dsTXgOvoW/mciMTe63j39Y=; b=vdx65RNE3D+nXVn2y0FTHMZF0pU5pb0QQKG3L44zU0apf7PcmPzSSY8YC28BHvXhiIFcLL4nCIZ6opfGILae36/rlwFfF1DnbhpPOlvxMfK5c0HesWQWxBxxvOVaEJZbZvipz3kig072ZkYJwHV5SHQxiuIvWjlh4vxxxjMgQWHu45r1Omr3LAZ79Szed27rZhtgpMEqzGJ3e/UQ344ptFeC/4qFrXh2OSDtvR8gBhboxXLVishhwt4DCrEBAqTb9DZemX5wqE9DJLa0uPsS0LGpGkq2+Egxb3Op8G2u9aAAhqg7O7v9hjFu3uclEkErq2yFmKI8K8yppnn020H3AA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oss.nxp.com; dmarc=pass action=none header.from=oss.nxp.com; dkim=pass header.d=oss.nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=NXP1.onmicrosoft.com; s=selector1-NXP1-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=J1aHxFRghZpOloeIDuKT6dsTXgOvoW/mciMTe63j39Y=; b=Y1jZiPAiulZEq+6J5VrxhlMZ+9tKkJpAZDtTPFivKcuKxJn3rOKXgpOe5C5odjSp+2tLa3x2PxBVmQLC/Qzy+jCpupBxwib2K70WtSpoVyKKwMIquCZzQLJK/679wDDNeLKKJIWAIv1tRbOlVO3nl+FgJom+E8QUG1GuclJHu2rAnq4C71sRBbd73morBzSVui7kqA/UiHJWFKVk3J55GjkG4kPOHDuqEuL4dXs+K/iYZ5dvQxo4GncGj+1gB0W3omWFIJh7Q85jAdLS1wEFDyht4XKmTX28E29W6OYcfVFtVUxOudKL8cmsjgUL3TxGiww5QJ10ha8k8bTxW2FrkQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=oss.nxp.com; Received: from PAXPR04MB8459.eurprd04.prod.outlook.com (2603:10a6:102:1da::15) by DB8PR04MB7036.eurprd04.prod.outlook.com (2603:10a6:10:12f::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8534.42; Mon, 24 Mar 2025 02:28:09 +0000 Received: from PAXPR04MB8459.eurprd04.prod.outlook.com ([fe80::165a:30a2:5835:9630]) by PAXPR04MB8459.eurprd04.prod.outlook.com ([fe80::165a:30a2:5835:9630%5]) with mapi id 15.20.8534.040; Mon, 24 Mar 2025 02:28:09 +0000 From: "Peng Fan (OSS)" Date: Mon, 24 Mar 2025 10:26:55 +0800 Subject: [PATCH 2/3] ASoC: codec: wcd938x: Convert to GPIO descriptors Message-Id: <20250324-wcd-gpiod-v1-2-27afa472e331@nxp.com> References: <20250324-wcd-gpiod-v1-0-27afa472e331@nxp.com> In-Reply-To: <20250324-wcd-gpiod-v1-0-27afa472e331@nxp.com> To: Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , Linus Walleij , Bartosz Golaszewski , Srinivas Kandagatla Cc: linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, linux-arm-msm@vger.kernel.org, Peng Fan X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1742783224; l=2428; i=peng.fan@nxp.com; s=20230812; h=from:subject:message-id; bh=vXU5oXYDT7pq3hwycqWjcyFZmAO8bXnWtI77J5aaCG8=; b=Fm36vZcx4B+KH/INgDc/rnJ6v+ZEwNV1LwL/9wre18nc6M5z1AONBCk/rurqhQJ214wwBGfvZ N/Dy2rcijNYC8G3Y3Uxc745Lzi17uhHqntYxJyYKfDHVUl3k8B65VBn X-Developer-Key: i=peng.fan@nxp.com; a=ed25519; pk=I4sJg7atIT1g63H7bb5lDRGR2gJW14RKDD0wFL8TT1g= X-ClientProxiedBy: SI2PR02CA0014.apcprd02.prod.outlook.com (2603:1096:4:194::19) To PAXPR04MB8459.eurprd04.prod.outlook.com (2603:10a6:102:1da::15) Precedence: bulk X-Mailing-List: linux-arm-msm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PAXPR04MB8459:EE_|DB8PR04MB7036:EE_ X-MS-Office365-Filtering-Correlation-Id: affe3574-8ef1-4e6d-080a-08dd6a7b844e X-MS-Exchange-SharedMailbox-RoutingAgent-Processed: True X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|52116014|376014|7416014|366016|1800799024|38350700014; X-Microsoft-Antispam-Message-Info: =?utf-8?q?m93OsI9ZFwF19QbhkOYmorFmmKR8QsF?= =?utf-8?q?pKzoV1+aY2gTP3iJENHgz7WF9N6u8bfcflcFoosNNZKm7WMUA0rCt0vmHijvIbkIM?= =?utf-8?q?UwW8cWbLQ9GSqUN0sNDCjI/QfTiolXmsnTOiDPf+ipw0mPFRTn37TV1S76U0cs5cL?= =?utf-8?q?kxhzTxZou7SBHelgGXh4YYj3tgyObAuk/i1N6eteWG3vkCLKl9zwLjTZBk7VvFo5X?= =?utf-8?q?X2eiVw0qlGrJkwS8Wj+jhd0VLDdBC6M+P+7kXHJXVN9NUKH2YqhwHqAfpkF/mwMXN?= =?utf-8?q?30l55eS52Kr+Cr7PFG1jpsMkfyrCGCewutSdXQEtHfc9MGSf59SVvgb+Ppy8PnKQV?= =?utf-8?q?nfU1pwnUlebeIuL6v/UFRL48KGBR+dRTwn7kDJQhC1pB3C+tcnZxp4VG1xGKSTLSO?= =?utf-8?q?/MdJglW1cEaSIbnV9/1k2jftv5egEY3LRVuVfKeF2F+mXoMRrxDB1ZU/OGJtlEg3R?= =?utf-8?q?G55IBb5a+xQRzn1E1Q8MoLF40XzdEptnbA2hu62gfbByznWV3np+7FHynm6lTEbr4?= =?utf-8?q?JqRywD8cMpXFiyJMC7KWCSOxeLsZuakCPsCAHknFX6LJkDrv/EbyhcZRwP3UADXNs?= =?utf-8?q?hs1ZYGmMwc9zqeDM1E9QIDSuWCpXjuBqawDLXpj+3R1VDdrxt3synkn9lOEGauj0t?= =?utf-8?q?TxbquCVIg/x4lzz7ONbZWF+uemqM6/ci1PUNwr5uA1hdi+CuKd74Z4Y5ZUTm3flQk?= =?utf-8?q?Bla0yS/L4El1+3UT9vUKiaa6zPmKxLnDBxBBcgpBHYd3BJurn8I3lR786dUs+82K4?= =?utf-8?q?B+MLo3sFgI4G5dwGoOPMEAT5iQbWa+uPsdwrL4FAxn74eajrU9wItXUxh68sPWYy6?= =?utf-8?q?IUJLNZceHYDZEeQvq1TpD92TAGgHXGN2yLqG/TpkS8n3InYW85AO50tZk4osK8MRe?= =?utf-8?q?XuuzSPyysJMRMZ2AM5hOV2TMaibsUjOA0NEaM+M2vBuJEm8643LoQ2h2d+CPpXvcV?= =?utf-8?q?abqYDPq8JLO8rWoQ3dBzYDk0s+DAoMSaasgbNl4EP9/mvmJCCMaXUrmguK/anR4y+?= =?utf-8?q?n4uZcMRxHgrfBH3OV17ZAPe3nDUx82M1ORL5FDf/TH+dB8Qk/HGWwfDd5nE7xasXm?= =?utf-8?q?hPaQ1BsWia6E+uy0eIPMwJkWjRGWz9lpQol6Y/xV6niB4GheBhQchykHdoNPogY/g?= =?utf-8?q?DmSn9+Bxhlcyx+dU076x4sTSz2pNE+BR2k4YtwW85GWFa0GujOt2qmtwQByCL6ctJ?= =?utf-8?q?PBt754N75YHMjrg/kSRps+rm/2N1joj/xEQQxu+rrQQnz0QAiheOwQ9vOF5hdgakJ?= =?utf-8?q?UXL5gBLVkditlKJxmSfLwq433XPsRv9qCJajSaw0p3PskAKeWJyGnoX9LBo6/Gvgm?= =?utf-8?q?C43/EbavmUrhNCdfrFiFqru3DrKCQXCxkqqJxQeIozOg/5rt18eTMLTYmwqwZHvmH?= =?utf-8?q?b3+6KlkNSvs?= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PAXPR04MB8459.eurprd04.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(52116014)(376014)(7416014)(366016)(1800799024)(38350700014); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?q?gDE04ax21gNt5RE+Q012XSkm+GU1?= =?utf-8?q?F12vQMQ4R++G7Q/r6geX1Cc90dwzWkDvejRP33q/lCEllTHqzmYCw82U2M0z6Wb96?= =?utf-8?q?yCS+thyBRw5Kx84YNmLs92l5JuxNWt4Rh/79iBF5V4ZQ8U8spDCmklLXaAiYGF8Yu?= =?utf-8?q?XvA2dEMh9mwrVSUMCTrawB3nA3cAMY6k0Ir8o/OzFr4zzDpULtk+m9nIM+tMoEi0s?= =?utf-8?q?Tqch0uRzEOL18SduMUs/NuZ2YNlwC1ZR+Ah40E983CGjSY9fZgtrZy+bqV3o1pg1S?= =?utf-8?q?2J6TtzHc+0RVGdez/Ra063IRbtjfa8A9uUC/6ouwK7hT0xWPuUwavl8bKN7zWNC4Y?= =?utf-8?q?DAXtnb3Y6niJ+J/ReReIQHRLyRjMQPXyRIzd3AEJZuMth0o/IqfD6eVb2qIYwp4MO?= =?utf-8?q?RGGZZM2+Eh5xLNiwq0qba0DK0OCskOPYCYI/wCQqP0XF92080JbEBBYsaPGFVnBkQ?= =?utf-8?q?Wtfn2h9Hl8W4jgNE2u7JaEvhT6RZQRW7mA5qUsgEy6UYsRdQ+l+HSR3bhnm5vltpP?= =?utf-8?q?yc1hZD30AI5II782MhA8lrm7lWgTk55ipwf+EiaGrU9QVtRxhzArHsVNn3GMWCUfB?= =?utf-8?q?CrmGKBY4JhQ4HDkOK02HlFARljQ0lE8EVJUGD/332eXcUM6Q/S9+fpXZQk0+R4suN?= =?utf-8?q?7g8rzE22hTHeLGa1m5cXiL3vxBz/Dv4tKoeIM90sKnGrcfBlp/ypJGcVhI3Ktc/39?= =?utf-8?q?q71hgz+W9LceCbni5wRm3QorgUhLAvo6aGBF2r3qQMKQaMKaoP8t/nTbaS7Q3AUSR?= =?utf-8?q?kw/flclhu7SOxIhQRmJroCm6GgxKQB7+QER9nAFYo7S8ZsKD5Rz8pkbyBW1ey/R8m?= =?utf-8?q?qqMc+FsFi+yTQqrFEmytauCF1yDY9ZQ+aGZf89+7uA0dkJ+Poehi5xzrOPzjnF194?= =?utf-8?q?ww6vBDgy+LqlutEsXmjC/uBRabtn7hsRdQoHy6IBwFTO/fL8TK8pn3GI9PhpoitLC?= =?utf-8?q?MyCDJP0c6sJBv2iva6lZsgrRSDlrB7eEhZ2bM1LxjdoLtUcQdKLjRFYRXwwZeUG7j?= =?utf-8?q?jDvSJ47hwKrpggSgROPX/w2v26CiFPZEjFDm1ew9wXpLhCERul80vib7B228S/7nV?= =?utf-8?q?LtwmZVxaYybKBEQo7aW9YZubaMnX6CaJDNi5fOd7wzffT15hzYtA8kQg8RTquHU5E?= =?utf-8?q?99+9mKwiLLAL0y9uhAfHuxKnGfuoc9zsPLHsqaSql4tWtvY/Rn7ONqUjV/XGBx4U6?= =?utf-8?q?R0rvR31tofH/RTZQMH0w4c0fs0mD8vtzhQGs/s5bFCUsuzLbYJpDDApUiO0ONVTVa?= =?utf-8?q?1EMwUxJpoBpAGQgo9+tOMPgj9dwT81oE6F95q021PuJ6L1hWP7nqC2FFaDdvFiFlN?= =?utf-8?q?uCcjGSnz4e05Caku7dHXfMVdkFTeP5hlZnP4Y364u7Xr5SOCzy8C1dx5TvkxPHv9v?= =?utf-8?q?qvh8NXe+2W0cDFu0IZx1k9ceRlXq2QhvqIiJpGTiSxhjj+4bJH5Ue8jzc+y00Qa6Z?= =?utf-8?q?YNEIV0ijuoRWy8RpSMUWetgtgQh4sjlQcvjNIJVkE6wCbmlRnNC37OY2MBGYxVTjO?= =?utf-8?q?HxfOLUeLGIsa?= X-OriginatorOrg: oss.nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: affe3574-8ef1-4e6d-080a-08dd6a7b844e X-MS-Exchange-CrossTenant-AuthSource: PAXPR04MB8459.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Mar 2025 02:28:09.0778 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Ris/F3gmZ4u7INJ0utGpETmaefcL1brK8NOdsIC/7b1rRKJhToeBO+qzKsndpWY0bN9KVuEYtC1jOf/y0bts/A== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB8PR04MB7036 From: Peng Fan of_gpio.h is deprecated, update the driver to use GPIO descriptors. - Use dev_gpiod_get to get GPIO descriptor. - Use gpiod_set_value to configure output value. With legacy of_gpio API, the driver set gpio value 0 to assert reset, and 1 to deassert reset. And the reset-gpios use GPIO_ACTIVE_LOW flag in DTS, so set GPIOD_ASIS when get GPIO descriptors, and set value 1 means output low, set value 0 means output high with gpiod API. Signed-off-by: Peng Fan --- sound/soc/codecs/wcd938x.c | 13 ++++++------- 1 file changed, 6 insertions(+), 7 deletions(-) diff --git a/sound/soc/codecs/wcd938x.c b/sound/soc/codecs/wcd938x.c index 1ae498c323912ed799dcc033e7777936d90c9284..c70da29406f36883e4926eca40ab5ba5df02c383 100644 --- a/sound/soc/codecs/wcd938x.c +++ b/sound/soc/codecs/wcd938x.c @@ -11,7 +11,6 @@ #include #include #include -#include #include #include #include @@ -171,7 +170,7 @@ struct wcd938x_priv { int flyback_cur_det_disable; int ear_rx_path; int variant; - int reset_gpio; + struct gpio_desc *reset_gpio; struct gpio_desc *us_euro_gpio; u32 micb1_mv; u32 micb2_mv; @@ -3251,9 +3250,9 @@ static int wcd938x_populate_dt_data(struct wcd938x_priv *wcd938x, struct device struct wcd_mbhc_config *cfg = &wcd938x->mbhc_cfg; int ret; - wcd938x->reset_gpio = of_get_named_gpio(dev->of_node, "reset-gpios", 0); - if (wcd938x->reset_gpio < 0) - return dev_err_probe(dev, wcd938x->reset_gpio, + wcd938x->reset_gpio = devm_gpiod_get(dev, "reset", GPIOD_ASIS); + if (IS_ERR(wcd938x->reset_gpio)) + return dev_err_probe(dev, PTR_ERR(wcd938x->reset_gpio), "Failed to get reset gpio\n"); wcd938x->us_euro_gpio = devm_gpiod_get_optional(dev, "us-euro", @@ -3297,10 +3296,10 @@ static int wcd938x_populate_dt_data(struct wcd938x_priv *wcd938x, struct device static int wcd938x_reset(struct wcd938x_priv *wcd938x) { - gpio_direction_output(wcd938x->reset_gpio, 0); + gpiod_set_value(wcd938x->reset_gpio, 1); /* 20us sleep required after pulling the reset gpio to LOW */ usleep_range(20, 30); - gpio_set_value(wcd938x->reset_gpio, 1); + gpiod_set_value(wcd938x->reset_gpio, 0); /* 20us sleep required after pulling the reset gpio to HIGH */ usleep_range(20, 30); From patchwork Mon Mar 24 02:26:56 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Peng Fan \(OSS\)" X-Patchwork-Id: 875834 Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05on2084.outbound.protection.outlook.com [40.107.21.84]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F26C717E473; Mon, 24 Mar 2025 02:28:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.21.84 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1742783298; cv=fail; b=IgjpdFxl+7q1b5l/mYRmZaUS9eGs1QsdqpdSWsLPqTXTJ7SEc8cHssJPFlpUZ9i0eT42jMGR0Pf6baQ0JFIXfWZSAJibVCzwa82qj0AN+HKgSOGdGaUmMuhMV5u4AxqMBYNjKc1w69x4+Ry6KjvKoE6Dibihqck2evk4GIb3gbQ= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1742783298; c=relaxed/simple; bh=pCZv3a4HKoCo6tTULZ/T7f7WdQ66pPWFRweWebAtzs4=; h=From:Date:Subject:Content-Type:Message-Id:References:In-Reply-To: To:Cc:MIME-Version; b=iSHSwTsPvvRARiDs6+BN4aJ83vivs6IbabLQTkw14W0A4Bky8xOxCEdMW5wP+K/6h1oiYzdQ5Td+M2pt++hhV09UtkuDhJ/pEFoQm+8v0fOsbFua+IO6lQhSgoEvChxxiuDyTfEpuxOdaFYmrfFtSSB2gLjeesRqVpBjjAnUfkI= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=oss.nxp.com; spf=pass smtp.mailfrom=oss.nxp.com; dkim=pass (2048-bit key) header.d=NXP1.onmicrosoft.com header.i=@NXP1.onmicrosoft.com header.b=WLyvwy/S; arc=fail smtp.client-ip=40.107.21.84 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=oss.nxp.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.nxp.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=NXP1.onmicrosoft.com header.i=@NXP1.onmicrosoft.com header.b="WLyvwy/S" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=AUUVZgP4OQxAswXYC189NgbCIi5Y39RDPEVl4A8ugCAhQc1bXradaiwr9/dzGX2wY9Kr+1npfNEja3Z127vdv3mhTF7YgzgK90TEHXf6grH3HdHoN4PQmfxU+fQnSDgpzRMN1CGWcNjsGTj+V8RMrmTR77aSbxHZoFSRQdsMEZUGuzNnGaj2hHGXoeqUIISzIs3YLia2lGo7risFfcZpGfP0ehiiEenS/gEsWmLKxgJxp32Ne510TM7z3URxLwYeDNE9qHnHcDMBLNxPm4+Z3YIjD11WcR31xq9cuO2fAOugOLHjp6QP5MCtw8HVFoaNW7SDWe0z8ZL6CcDeIaCvIg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=FEUv2j/WYz/0UQb2CW3Xs6/R7GSMOigLx14jpL/CkgM=; b=Y4Qpvfee18JIlw6LeyAwunNR6+YYv8g56i1X26QNy0YX/IuCALU5KxCfuiZpgAxnuM/DBrZjJbyiSXHxJU6GqPyY7sBFvG14/LUNOqKASx7QN10uxgrOZTSS4k76JdcQjwkMXrRfH6FhWU8mvAiXpP64ejFZZXgGe2L8SBhlz/xo36EAqHvbQx64AdFuW+/PHDownbsqu/CTkDQYco82eEzfTO5L54DLCwbKpmuORyMAK9KAX1knAc7LVHjCodet1JsXJWk9dbxWJMCQ8Csv4uXdgDEoAgMl3ktZ/uYilJ8L0dK8yO6u6UjoXzQGf9pzi6080GGUr9FOzswPylsqVg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oss.nxp.com; dmarc=pass action=none header.from=oss.nxp.com; dkim=pass header.d=oss.nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=NXP1.onmicrosoft.com; s=selector1-NXP1-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=FEUv2j/WYz/0UQb2CW3Xs6/R7GSMOigLx14jpL/CkgM=; b=WLyvwy/SvAHUsf7DOPTp2FXnOCOzIHy2hGcjx0YqDYCxnUtGSQPK+oltOOThi8LysbnxHd+7VcWbtMHqdOPwxu61sFjiwKqyIi7weQ1uEtfCZGctuLqrGDLKTrAzozDOoZ9DK7gqjk8gWEZs3OPLhlitwwwtMX3fchDqrIwuu/5QRX8WD9Nan9ns3z0ntXs5v2ISBtud+QQL4dNdEI0WkX3HECsoBM0oiFl0G/kvwOuhOWEvRfmS4OuTtXal8c20S5lzI04PsDoa3uG+hFgtEDui5XHF/XCUpm6nQMlxJf5l/ymWnsa52NvPYyarh3kuJcB4A115Ux8hOJp4mvOjgg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=oss.nxp.com; Received: from PAXPR04MB8459.eurprd04.prod.outlook.com (2603:10a6:102:1da::15) by DB8PR04MB7036.eurprd04.prod.outlook.com (2603:10a6:10:12f::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8534.42; Mon, 24 Mar 2025 02:28:12 +0000 Received: from PAXPR04MB8459.eurprd04.prod.outlook.com ([fe80::165a:30a2:5835:9630]) by PAXPR04MB8459.eurprd04.prod.outlook.com ([fe80::165a:30a2:5835:9630%5]) with mapi id 15.20.8534.040; Mon, 24 Mar 2025 02:28:12 +0000 From: "Peng Fan (OSS)" Date: Mon, 24 Mar 2025 10:26:56 +0800 Subject: [PATCH 3/3] ASoC: codec: wcd9335: Convert to GPIO descriptors Message-Id: <20250324-wcd-gpiod-v1-3-27afa472e331@nxp.com> References: <20250324-wcd-gpiod-v1-0-27afa472e331@nxp.com> In-Reply-To: <20250324-wcd-gpiod-v1-0-27afa472e331@nxp.com> To: Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , Linus Walleij , Bartosz Golaszewski , Srinivas Kandagatla Cc: linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, linux-arm-msm@vger.kernel.org, Peng Fan X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1742783224; l=2351; i=peng.fan@nxp.com; s=20230812; h=from:subject:message-id; bh=w2kpHxzjhH5lUjvoGiVgliajpRhAKVQmnpgnfgKcfec=; b=cAGNjIfPTUMhCpIm+mGG29Y5M1UIfDYSN+SrEJSSkVz6KCJoFPCz/it6mQv89YFQUdWfJJgxo fPWTcDbkUwqDJzovc3BBRbZYE5i7iz9NHTOBedXOYeHnbmgkooSTeeg X-Developer-Key: i=peng.fan@nxp.com; a=ed25519; pk=I4sJg7atIT1g63H7bb5lDRGR2gJW14RKDD0wFL8TT1g= X-ClientProxiedBy: SI2PR02CA0014.apcprd02.prod.outlook.com (2603:1096:4:194::19) To PAXPR04MB8459.eurprd04.prod.outlook.com (2603:10a6:102:1da::15) Precedence: bulk X-Mailing-List: linux-arm-msm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PAXPR04MB8459:EE_|DB8PR04MB7036:EE_ X-MS-Office365-Filtering-Correlation-Id: 463e1f84-9e43-45b7-6f5b-08dd6a7b8676 X-MS-Exchange-SharedMailbox-RoutingAgent-Processed: True X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|52116014|376014|7416014|366016|1800799024|38350700014; X-Microsoft-Antispam-Message-Info: =?utf-8?q?XWbh7ba+0kiR2wZbll74n68k7mV7wlM?= =?utf-8?q?W5L4ZxYzRT4+zJkzaSNwjyJSp3FBeJg5a/6I3GEcLtnpUtJ0dGFfiSjSors2P/05F?= =?utf-8?q?KKKCHoOHkiaKdteiPmHcFx3NdmVA4cSkwtks6iAaPoYRwYCesWdTyBZnjceduhprM?= =?utf-8?q?cdvXXmLVz2o245d70n752S32kHkFghaANSdeZlrbYhupXIy6h/PpBNDZMo7q3ZKtq?= =?utf-8?q?rqY2sf9dpcqzaI1FG+Mbw1rBjH/N5Ocyf2QmUhyLnx1NhUjSj9sXu/WukOO9X4UQ1?= =?utf-8?q?03ctfdDZTQj6cBdOzFrUj4LpVJybZlvX5j6nnQEd+F6veT6TurpVRcY9bSXvQWECE?= =?utf-8?q?NsVoszV+uxnJXJdTAf6oTmekdGGdVBxElMrJOuElAQGsxibRMKuKxG1IcmDPThvVB?= =?utf-8?q?cjik1tMbchLkEPQamcy2pcIv2TS9p80myPZjeGs8HjmEZkFqOR+i5nnBAekRltUjp?= =?utf-8?q?ugAVb6L0uqIJFXBvhfCBRSnzpNQ02yGmmxAp/UnCBF/mXIh6oinB9sDIyqlLCCglH?= =?utf-8?q?rjpNfKfeNnJyu1wAMd6GwvKD82meEmZUzecoZFFO6TlynexguGU0ae1QABd6CeaSS?= =?utf-8?q?kjjMXaj1SHlryPQ+FuyBImC7f/5M8+syRy7F2PNcvjVv3uouBhRuKxj7YhPVAyt7M?= =?utf-8?q?ZxvaM8/90bk/N3SeQLLZlwhVa3I1O/hJBe2mGhsTJPUEjjSe7lMvC/MIhJGGDCcNs?= =?utf-8?q?SZdn7xm4WQJFgeXhXw2Uv/HZqclRXnNX1jcoF9kXaaJHuSwTxf2f5aVsGbnuwmbFF?= =?utf-8?q?ZuvT5iIq+rHk44ojTba65WFtDBI1PFMGvM9dfSmVNs/kGVYaEJana6ClbrvxWJbtC?= =?utf-8?q?M3P3j5TRkgthee8ENArFD0M4I7Rkiu2UxG9tkW2TY/LPrMStKd9iFWbewGl6EOsfR?= =?utf-8?q?AewA92qazqCwoAt4KjpB2m2/A6qzyHOLixpZKW8ehtDStAH0WOTyBRcW6qXAebKjp?= =?utf-8?q?XkE7EQvF1im7uqzHARz/AV6+L2XKWMlFXVHtdHu/0RVg1s+QHG7YhxLOg7ZT0f61+?= =?utf-8?q?RugOQuiUicRo3g9GvKJGtSQbHxHGQxXGn/VyLmLRBLNXcYQVc9xbzEcaIRD/JH9Qc?= =?utf-8?q?w0lD2hdqEGHsSuk/muVkUAjrbYNkZambXGm6exqQWd3MA5dwVZ2lHJjgMkgMfJmI8?= =?utf-8?q?2dsz3M92fM0VrSXwRpqmsXoFTUvEkqf/Kz9sML8YqztfEEW1jkp10Odc/NQEhfPAI?= =?utf-8?q?Gd1kxHGyicwlmi/OIDENMo5nx8bH9nyvj99EGGZM1TUMUrEGnvWdCeDFNa6j3rNlC?= =?utf-8?q?vZXdLoMgr8sxC2fYzNPyMm/TYj4HeL/2B5FZy6z7KhObmBlWqf/TGLv89H4GfAX/x?= =?utf-8?q?T3SeQa4V/6HssZWqujfsKghFRtzotJE4A+FwETMqfcXG4rKgJJTr/AKEcYWgfdWcU?= =?utf-8?q?rMIpqpMPp8m?= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PAXPR04MB8459.eurprd04.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(52116014)(376014)(7416014)(366016)(1800799024)(38350700014); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?q?3UVdDMuJ9aDLhVTvmXf1DynTvri8?= =?utf-8?q?960bt6aW/SHFj2RM7FE1W+9zEQ0VfzEFeOaMgNeWe/rwJKkUJ0/8gq+A+Qy9d8zXO?= =?utf-8?q?JRSnP9snS+kT5wH8Eh01Bt3uPu+DjT98nM6g2sj37kLYL8hjMMy0phmDxr3AmuQa6?= =?utf-8?q?qa4ETwdQrtnVvALrGRGnHwZdyDL2IHnnxQfS6fKtYpdgKrCdEDguXGo5jQTii7xv0?= =?utf-8?q?L7lbuzDWiLMiZiT+zudodiwJ3GOlfwS6ePjmcvVM9maNHAPOwQBEclYqW9MFxtXFF?= =?utf-8?q?PyhUKRMMXIETK9uLQmdZbX9tTZVGREKXy19LqpMiaIQbF+uWmT7Q1NKxIRQu3zgUB?= =?utf-8?q?pC8+lka7ms5XABiAqUrmZKuXn9Uu+k4t3xYZRZp5ll4euG2emEkJj+7UgrUpmzbcm?= =?utf-8?q?5bOasG6ZjP2Xuedb5wmwdKaTxk/UUa5UL0QiZjr8U+bLQjk5fNJ0//KMsi0K25Up3?= =?utf-8?q?xTjdCVA2KoTNgNhT479jgmnhL6IUOFDqn8G5/NGVczfngSWfaGRQCiu3+LW2h9GaT?= =?utf-8?q?PNmOFBZk+FmLWF4xNGA9Lp9idC4gxy/TsVQVxFpWUp4O3oT2aHFeKj8WTqz/ryxHh?= =?utf-8?q?uFJXmyV2cMvfqcHsqo0XYKiWTlaaSiCcARIXPJ5f47XGXcehR4F9+KCfICojy6y1M?= =?utf-8?q?wQtm8iVFIFP7rOqLn4DSSDWvyS2ZuFmhNZ97vxS85k4x/ltR1xL6dIrq8d83U3b4Q?= =?utf-8?q?WVgRaFo/Jtw1ahrjcfQz/UsuVC1fIkhaaFg1YmCAFa/1uXWK7aNLlbO6j7Hw2W8Ip?= =?utf-8?q?WBAIxM7sT0L/ueATV5ZClO74WRV458QVMsYSiovxynHcKlvHd8vfetVIqDc72SxOT?= =?utf-8?q?A4TREtGCrZjydNLvAMzUpNgQvIdT7Fp4OKGNgDslvwkAet1GRzWXryX/YfBQG5SVX?= =?utf-8?q?pt0b4t15/vITEiQOQarWsPcOdxZG37PIma7VBIRPWtN8z19fksNZlINfnHoKOK5L2?= =?utf-8?q?si/pdmy5VqXF1M+do12v++/P06uHUSB/5thUrKjMse+Rt/4jR5lMzgdW+9otsVJD2?= =?utf-8?q?P66gUSwv6Nq4WywN/T7hV70+7PA8gtcKLZ8jHStp5A4vrZRbPeWqHJKWOCRmIaDxJ?= =?utf-8?q?6256J66PA7J46Ijg0taEKLmV3ejMfs32MYQDU8I7Uapx58wI+1kx7pWjR1x8ukI3V?= =?utf-8?q?OGF/RfVEAs4mW3UxEsBLxOTwmZczGc+rBA9woYu63rzRhTnsHya84uSvUh1u1Yf3L?= =?utf-8?q?ZoapQRoHbZeM8psgLNPgsP+GlpWsF2JlUJ62Jku0UwnCmTrQUWaUFvnJ40RDCeASi?= =?utf-8?q?9q/GWufC7KH5dHY0uLvQEAuXxX/Uhrf+jJdufh/zZAmLoRjEknwj89kPgBqL24fxT?= =?utf-8?q?HG76c5UjPKIleSKRic97tzQ6kHRsxxCrPLgu0stv3aXvp3OvDP2GQOjsZhiXhFrLH?= =?utf-8?q?Gef3DyBLKEaZ+uZf/vJdVwwQIy9P1iFYNBU5OeOQxJcdgxqUUfD9sU2tCbmhxkbM6?= =?utf-8?q?7Rzb+0qk3oB1bnK84ESTrDCGzNOafhjHrDtL1KBizXlKEhYM/CcpYsxb2dQLjuRMf?= =?utf-8?q?DHrz1Q8ML4if?= X-OriginatorOrg: oss.nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 463e1f84-9e43-45b7-6f5b-08dd6a7b8676 X-MS-Exchange-CrossTenant-AuthSource: PAXPR04MB8459.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Mar 2025 02:28:12.7704 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: iI80whXRIhgrKnK3pEedIMobPZdhw3Sw+ROkGO8bhZHmgU52gR5OJ7kxGGjFCFOJM0JpFYPuOOrYp0E7R5BD+w== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB8PR04MB7036 From: Peng Fan of_gpio.h is deprecated, update the driver to use GPIO descriptors. - Use dev_gpiod_get to get GPIO descriptor. - Use gpiod_set_value to configure output value. With legacy of_gpio API, the driver set gpio value 0 to assert reset, and 1 to deassert reset. And the reset-gpios use GPIO_ACTIVE_LOW flag in DTS, so set GPIOD_ASIS when get GPIO descriptors, and set value 1 means output low, set value 0 means output high with gpiod API. Signed-off-by: Peng Fan --- sound/soc/codecs/wcd9335.c | 15 +++++++-------- 1 file changed, 7 insertions(+), 8 deletions(-) diff --git a/sound/soc/codecs/wcd9335.c b/sound/soc/codecs/wcd9335.c index 7cef43bb2a8800971604b0e1ac55aac26c5919bd..90cf4f79cbde5f704549d41771f085574045ff46 100644 --- a/sound/soc/codecs/wcd9335.c +++ b/sound/soc/codecs/wcd9335.c @@ -17,7 +17,7 @@ #include #include #include -#include +#include #include #include #include @@ -331,7 +331,7 @@ struct wcd9335_codec { int comp_enabled[COMPANDER_MAX]; int intr1; - int reset_gpio; + struct gpio_desc *reset_gpio; struct regulator_bulk_data supplies[WCD9335_MAX_SUPPLY]; unsigned int rx_port_value[WCD9335_RX_MAX]; @@ -4975,12 +4975,11 @@ static const struct regmap_irq_chip wcd9335_regmap_irq1_chip = { static int wcd9335_parse_dt(struct wcd9335_codec *wcd) { struct device *dev = wcd->dev; - struct device_node *np = dev->of_node; int ret; - wcd->reset_gpio = of_get_named_gpio(np, "reset-gpios", 0); - if (wcd->reset_gpio < 0) - return dev_err_probe(dev, wcd->reset_gpio, "Reset GPIO missing from DT\n"); + wcd->reset_gpio = devm_gpiod_get(dev, "reset", GPIOD_ASIS); + if (IS_ERR(wcd->reset_gpio)) + return dev_err_probe(dev, PTR_ERR(wcd->reset_gpio), "Reset GPIO missing from DT\n"); wcd->mclk = devm_clk_get(dev, "mclk"); if (IS_ERR(wcd->mclk)) @@ -5023,9 +5022,9 @@ static int wcd9335_power_on_reset(struct wcd9335_codec *wcd) */ usleep_range(600, 650); - gpio_direction_output(wcd->reset_gpio, 0); + gpiod_set_value(wcd->reset_gpio, 1); msleep(20); - gpio_set_value(wcd->reset_gpio, 1); + gpiod_set_value(wcd->reset_gpio, 0); msleep(20); return 0;