From patchwork Tue Mar 18 20:50:27 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Caleb Connolly X-Patchwork-Id: 874468 Received: from mail-wm1-f44.google.com (mail-wm1-f44.google.com [209.85.128.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 80493211A15 for ; Tue, 18 Mar 2025 20:50:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.44 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1742331059; cv=none; b=EHl6laju7ba/ih9MzxJar/sQUuQ0j0uD/BZQ93S7iU+FgP7+eU1jF13OcIZLWQd9oiM+39ymvrNBkQMoVH3jiqbxebNA9QomSueJMYGBy7PNcgMHAavf5CBF2pJhajm+JGx6b1LXfeH4xuT3duEZZ5emtLKhJnRX2GnPos6Tg2A= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1742331059; c=relaxed/simple; bh=xDd5pymcW0i1Wd8xe3YzO/vkoXoHglAxgaQ/uxX/1Rk=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=ZY7QZS7C+kdgH9QAAQcEcbSWAY6ndrFGoGD4Cd4DrYTArNngQ7l6P58Yhh7OJKS15GS7UY6mqcbkrWqET3vAGzy2mYv/HWl+XQl63cvqsECpv1+Ole0Aj2Ex0RGxlzfS0qmEb2cOf+80u3SevQaNdypXLSCfFYMM1q+m2dtc1zU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=DzXR9YcF; arc=none smtp.client-ip=209.85.128.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="DzXR9YcF" Received: by mail-wm1-f44.google.com with SMTP id 5b1f17b1804b1-43cfebc343dso27749915e9.2 for ; Tue, 18 Mar 2025 13:50:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1742331056; x=1742935856; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=3UohDItqJbHSrPJP72i3dlPHwcSi2GhbxMj73jX1M+o=; b=DzXR9YcF9jDmDiSRjebMBqNTc9Xr4qGrqF5CYRW1n39NGtk5k6pl/QY3jgEeg5WD4G b9TOVIPM6yD/nNAOepDwlmfsehP6R1tA6/HlX797tTNmUvgC/H3WNFR2RDARc6KrsERo II8SbketJEAPX4LW26on7dAUSKE3N+vH0ZEtv0ewbk+Qyu7B6J5k9imUqoRsYAmTWql2 dXcrZta8lY6/z1ucY3Uhb4E/ukieXbgqR3MmK0LmFcZN7Am7Em0CRlopc6CyMDf7W83U DTedvMybYy+hmpnaNaFODno6X6C371jyXxJ6EnsO97K+W2NrX6D9hPWbyAvLnxfZE+sD HRCw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1742331056; x=1742935856; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=3UohDItqJbHSrPJP72i3dlPHwcSi2GhbxMj73jX1M+o=; b=WTadm+F+ahpE4trOMEbzrmwqyesqDxW6Nz6kiutpsPX2numYwamJGkcW/HIeO9jq+K luKcdbY+mExHOX7m7VtADgB1B+g9UwRWwcjhYw7ej/9QVOzXB+U8Az/nlB6ejtPKoYtZ csZGMcSuALkyJrYaqUeieUIIl4P4cfehebQctmstfH31YxmLr2g+1RfSPU7t3UsdydZu ogHoYmr/X4PF4kI5JNJHAvYOi3auDIgD+D+4tL4etSZreMAnry2oO98MGBR7iUuebBCJ MYSGLJZ2LOe3LZkXYaLy3a/sH9Amp7vRibzU7mM3xfpC0w2BzMBHFO4kqLQ/3VlV/CO+ pmiQ== X-Forwarded-Encrypted: i=1; AJvYcCXwm3WAEQ9RFIYmp3svaT9InSkEaxMd1amFrYe602++KVLaq/vuJlTBWOJIJVbNSsa12ftr3dxgtPFdqBED@vger.kernel.org X-Gm-Message-State: AOJu0YzOF9zEgUCcxf6KYXPSmG7uFnXmvEQ/c7KynOG8NxG9GLjPLmhE IbCbkmemXPJwGZaKbnluSuafhThzkxwz2UJ4/lS80cZCD0BmIquM3gZd5O0YRQs= X-Gm-Gg: ASbGncvw8axe8asDCSMljNdCBqQrLKSJXPlQ7UvZ5OAjhRvC3TEfI1gLOfPyKyWmVbs JbLFl/TP0yBm0FGQRyT1OW1yrs24FzBPJgmSCZG2lcpw7PL8DqvMnK1Un8Bu6dHa2hpdSJpxmdk ewVLKkG/n64zm4WcCD9/u2b6gCzQvngBIRDFVpaLAYnccIij3y23uWAC205m1ST5u7EWWcoEqfj A0LM7igXlrpDH4Qm4LFiPe7FHu5RI+idOy69eqGMNOHZ/84ooe4HwngbXM4uEFqMCGUs+DYXm3M kIV0wdjfOOzJIww/7T1XuD9bfxLKi96TuCkHGeo4W56wcHv6EZZQKpSTouo= X-Google-Smtp-Source: AGHT+IEMGi6XLwyG661+0/YviXfVdYcrgXqlOdZMjARlupJXDIehoNdeJwTWQOa9f4YxNoViNwD+pQ== X-Received: by 2002:a05:6000:1785:b0:391:c78:8895 with SMTP id ffacd0b85a97d-39973b32028mr143871f8f.50.1742331055842; Tue, 18 Mar 2025 13:50:55 -0700 (PDT) Received: from toyger.powerhub ([2a0a:ef40:1d11:ab01:97b:e453:3907:27d2]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-43d1fe05e8dsm143198645e9.9.2025.03.18.13.50.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 18 Mar 2025 13:50:55 -0700 (PDT) From: Caleb Connolly To: Jeff Johnson , Johannes Berg , Kalle Valo , Rakesh Pillai , Surabhi Vishnoi Cc: phone-devel@vger.kernel.org, linux-arm-msm@vger.kernel.org, Caleb Connolly , ath10k@lists.infradead.org, linux-wireless@vger.kernel.org Subject: [PATCH] ath10k: snoc: fix unbalanced IRQ enable in crash recovery Date: Tue, 18 Mar 2025 20:50:27 +0000 Message-ID: <20250318205043.1043148-1-caleb.connolly@linaro.org> X-Mailer: git-send-email 2.48.1 Precedence: bulk X-Mailing-List: linux-arm-msm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 In ath10k_snoc_hif_stop() we skip disabling the IRQs in the crash recovery flow, but we still unconditionally call enable again in ath10k_snoc_hif_start(). We can't check the ATH10K_FLAG_CRASH_FLUSH bit since it is cleared before hif_start() is called, so instead check the ATH10K_SNOC_FLAG_RECOVERY flag and skip enabling the IRQs during crash recovery. This fixes unbalanced IRQ enable splats that happen after recovering from a crash. Fixes: 0e622f67e041 ("ath10k: add support for WCN3990 firmware crash recovery") Signed-off-by: Caleb Connolly --- drivers/net/wireless/ath/ath10k/snoc.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/net/wireless/ath/ath10k/snoc.c b/drivers/net/wireless/ath/ath10k/snoc.c index de96c3939ea6..01e26f259fdf 100644 --- a/drivers/net/wireless/ath/ath10k/snoc.c +++ b/drivers/net/wireless/ath/ath10k/snoc.c @@ -936,9 +936,11 @@ static int ath10k_snoc_hif_start(struct ath10k *ar) bitmap_clear(ar_snoc->pending_ce_irqs, 0, CE_COUNT_MAX); dev_set_threaded(ar->napi_dev, true); ath10k_core_napi_enable(ar); - ath10k_snoc_irq_enable(ar); + /* IRQs are left enabled when we restart due to a firmware crash */ + if (!test_bit(ATH10K_SNOC_FLAG_RECOVERY, &ar_snoc->flags)) + ath10k_snoc_irq_enable(ar); ath10k_snoc_rx_post(ar); clear_bit(ATH10K_SNOC_FLAG_RECOVERY, &ar_snoc->flags);