From patchwork Mon Mar 17 07:24:07 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Venkata Prasad Potturu X-Patchwork-Id: 874183 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3E3EFC282EC for ; Mon, 17 Mar 2025 07:25:15 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [45.14.194.44]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 89C826033D; Mon, 17 Mar 2025 08:25:03 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 89C826033D DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1742196313; bh=iI0gR3NvOrrqg2ic3pszD/K8KgVfjbDq24Mzc05Umsc=; h=From:To:CC:Subject:Date:List-Id:List-Archive:List-Help:List-Owner: List-Post:List-Subscribe:List-Unsubscribe:From; b=rGVMnGruIxsBBYgwMgjEIAoTcmzY9jBw7M7VNKNaKGFtfZnZH5x5WEWtmSqdJ0TUH 62lhXTeQEfPHuuDuzf65AtVd5AsqkjECGR+ck/GpZJNSjK05yHsGqfCeT+HTRI4dKP 3xxXmu7LI/uaemU929zYq4evHMnQgIML6oYNQ3/0= Received: by alsa1.perex.cz (Postfix, from userid 50401) id 251E1F805BB; Mon, 17 Mar 2025 08:24:37 +0100 (CET) Received: from mailman-core.alsa-project.org (mailman-core.alsa-project.org [10.254.200.10]) by alsa1.perex.cz (Postfix) with ESMTP id DF3DDF805BD; Mon, 17 Mar 2025 08:24:37 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 8CB3AF8055B; Mon, 17 Mar 2025 08:24:32 +0100 (CET) Received: from NAM10-MW2-obe.outbound.protection.outlook.com (mail-mw2nam10on20624.outbound.protection.outlook.com [IPv6:2a01:111:f403:2412::624]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-384) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 5B81EF8001D for ; Mon, 17 Mar 2025 08:24:29 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 5B81EF8001D Authentication-Results: alsa1.perex.cz; dkim=pass (1024-bit key, unprotected) header.d=amd.com header.i=@amd.com header.a=rsa-sha256 header.s=selector1 header.b=tCbSGR2V ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=KJK5n2/kMdT2T5tAG2+4+OzFnAV39C+12nnNQMCaBAnXJxcet/gtIPauZ6r4jNSGl0uxfQP9LKEuKKVCNxWvKXzy/u0smVQAXTWKzVwuy+2ONEU00B9JCCbF7jTIBPnVEhSDntOgJAqoj95SqvOvWUaOyv+Ke5qIvEVh2EWTgzggeZbdQkFiH3LiXlm2aUUPTOr6fBqj9EJ7+uyOX7DxYDJWfTVLhJhoDyXcraHmjjGSeCFT36U/RmVGUdOME4DMlQb8r6s4cDxLp7JEQyxa3qV3H7nmRHtPgkkaI3xJ8Cnpe+r8hhwVe+jNRWqbubp1atV5FaQd/KjmEpnCHB8x3g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=cvbojkVN+vekQ5YjjXWUPGF5dReaEudIB070wNCXyVA=; b=eTTq6Bb4mISfyYh2ycxL1gLz3+TeSFIbEz3rk2lXt9dv04Q5bQpl95QajV3ryMh5MIX+Ron3Ct0e0jXN3E4YBVzkYzyN9J0Tr8mju2fZOT6Rsb3yR6/3G3EdulTEMeSbjgDxh0Aht1cG/Zc2t4mu7ewKJi/a6565eaquIxNe2F/XS3bFQPMezWfgBNhsTwr5aljetwx7wJtrLlZkqWmtCbBHjCFuna4vJfW2JrfOCZV3PmnensfM53HtJ/tJrsQZ1GzBS8ZQeX4kSOlg9J4BA1h+EvBDmODp++eejMto8DOahSwDe7h8F2V5O0tapEWAa692dRcnj5EYROPedUfzLQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=kernel.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=cvbojkVN+vekQ5YjjXWUPGF5dReaEudIB070wNCXyVA=; b=tCbSGR2VcAI1JdnOYOB7Wkg897pbqV/U544Jt0+/FjMukzCyhCmjko5IAgPkBQ7cy/im12ZvL624kguYagjkI2/JTwKA8TP2JJmg+EZd4P3PZocKK7KP/Lgg0WvHO9ecex2Fx24Sp9tNN/c8PpFHez22GzyRzqlnk7jgMSrIURU= Received: from DM6PR02CA0086.namprd02.prod.outlook.com (2603:10b6:5:1f4::27) by SJ2PR12MB7992.namprd12.prod.outlook.com (2603:10b6:a03:4c3::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8534.33; Mon, 17 Mar 2025 07:24:21 +0000 Received: from DS2PEPF00003447.namprd04.prod.outlook.com (2603:10b6:5:1f4:cafe::ae) by DM6PR02CA0086.outlook.office365.com (2603:10b6:5:1f4::27) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.8534.28 via Frontend Transport; Mon, 17 Mar 2025 07:24:20 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Received: from SATLEXMB04.amd.com (165.204.84.17) by DS2PEPF00003447.mail.protection.outlook.com (10.167.17.74) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.8534.20 via Frontend Transport; Mon, 17 Mar 2025 07:24:20 +0000 Received: from SATLEXMB06.amd.com (10.181.40.147) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Mon, 17 Mar 2025 02:24:20 -0500 Received: from SATLEXMB04.amd.com (10.181.40.145) by SATLEXMB06.amd.com (10.181.40.147) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Mon, 17 Mar 2025 02:24:19 -0500 Received: from prasad-lnx-mach.amd.com (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server id 15.1.2507.39 via Frontend Transport; Mon, 17 Mar 2025 02:24:14 -0500 From: Venkata Prasad Potturu To: , CC: , , , , , , Venkata Prasad Potturu , kernel test robot , "Liam Girdwood" , Jaroslav Kysela , "Takashi Iwai" , Pierre-Louis Bossart , Bard Liao , Jeff Johnson , Greg KH , Peter Zijlstra , open list , "open list:SOUND - SOC LAYER / DYNAMIC AUDIO POWER MANAGEM..." Subject: [PATCH 1/3] ASoC: amd: acp: Fix snd_soc_acpi_mach id's duplicate symbol error Date: Mon, 17 Mar 2025 12:54:07 +0530 Message-ID: <20250317072413.88971-1-venkataprasad.potturu@amd.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS2PEPF00003447:EE_|SJ2PR12MB7992:EE_ X-MS-Office365-Filtering-Correlation-Id: 2e9e9850-f8f1-4e71-af0d-08dd6524bc2f X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|376014|7416014|1800799024|36860700013|82310400026|13003099007; X-Microsoft-Antispam-Message-Info: UQvnf+A+RwgXk21oeNe0UP4vXSnhOYAj01phfSzA5majXR8QH066stTIjTOhqOdeGMJxQSuFTD2lfBLlaizTxqYrgEh0f2AMu/drXGMpnIOb2mP61ynRFEI9UoARF4jMREMhU9JZmLCYS4O4WwgmMOQyBpVa4eLdbZB1eIhexMQAnMJHkE93EPVtsD+p3sVCn+aEjgzv7+biccA/izZBehZfGchJc6/h8FLY4+CYVk/9Th3lHuhjRDV3GPN4mQcIMhjsfRNe0bOVDlJIRJ0IZPu6joAV73/2fHu65OI8bcC8pqznC7u+e54j+gaJL2cc6idrE+e1osh/UPaOHZr2+AaIqQkZVeQDn0xmOuhDMgrm0Dj2LsD3+6B7Xy33L3IAGip3d9xs/8xqKfJQtvXFy8vJbeh4q6RVWrqtz0nd/ghF/w4CMELEMWkihdto8CUNc33Hyjg87z7L9e+r3wC9cmXBgASA1BUDEmfCaPsenwHNCmdikqBN6jfO5OOc0GiWikzvVYCl4VFo2LdGBuvk2Hz8gGH8S5A7xKEeqilVMqNfD/yurJss7vMgaiID1EF3+jKg0p8JiO6w+AjWVdS5RDekraH4y0tNBpxAuyJjgqounYqh4MMhcxNRhQwJi7d3OjN6NGeKffnbP07g9a5FHwrI4aWwswV4uaxfiaCFqWmc7OvviACvJtkTLJtS6GrAultBK69ybabHGgqRgMWczjBHY+UP48Hff7KbDpbSPNS3tdFcgbimIH6P3zI9so0//WZQu5YjBRcPohRfdLWgZyJjBX6B5Bi2dApd944ElY3yHD3WYWmuJjbVahTkpOg2FLf4pqaAvnLr3H6jRvdKe2ytamQyJ8bxqVr+NB/c/T+DWtCxHbt157MNzgkbegtMtqOjeuj7lfrJr6vynnfqFE2JthnqzbAfMKXuXhcK5HX1jVSfiPXXcYtz+QdemIyrEtazZClj/EIN1FGq8ve696pEJw8nqVT0CvZOBMb02l+TSevhJf6GSZho8teE+rjBb//U2i0Xk0TLoXAOcJ56LMZK7rvs2KXeNE1TBGkIpL65M65j5BWw5EN6dhWufD+PE7T5zTd65iRPk7aIjsn+thW4FSbqXdokIJVImxnQlwWMQZ/027lEf52U54TTQlcNKjc3hfjk6vyxk62vXIBCaCftGAie7RVxSd2jUJOqegimVw8bx7ZJ35jkm+w7Ih7PaxYjbnFyO/BnOkFyxUcyDwrAlt/t028/FjequZyUSZEwu+mDRVO+Df/mi1C8vyQTv8+6+4EkHxzh0LlcK67l5vMHTfMgKIS1nJ32vSCiUJCNPYvtG351kVuuPBxQ5WoYnU0V08v1fyzb7r5dWGQdZIug39RwKpMU5yIpstfL+hObaBizYvoi083COinT/7n2R7OtaLQHpiF3qrmIQ0waN7+wmK5g8t4jjWHo6weWKCFNxIfjcSEbxCoLS7JCE7WJzAgMwrrPYMpQnwmZ2moQKHnpSXUbWC0WeGAtZ+iJ600= X-Forefront-Antispam-Report: CIP:165.204.84.17; CTRY:US; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:SATLEXMB04.amd.com; PTR:InfoDomainNonexistent; CAT:NONE; SFS:(13230040)(376014)(7416014)(1800799024)(36860700013)(82310400026)(13003099007); DIR:OUT; SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Mar 2025 07:24:20.6010 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 2e9e9850-f8f1-4e71-af0d-08dd6524bc2f X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d; Ip=[165.204.84.17]; Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: DS2PEPF00003447.namprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ2PR12MB7992 Message-ID-Hash: 4XAVWQXLF6S7JWZIAK7PRK3DB22BPKCB X-Message-ID-Hash: 4XAVWQXLF6S7JWZIAK7PRK3DB22BPKCB X-MailFrom: venkataprasad.potturu@amd.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-alsa-devel.alsa-project.org-0; header-match-alsa-devel.alsa-project.org-1; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.9 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Move snd_soc_acpi_mach id's of all acp platforms form header file to amd-acpi-mach.c file to avoid below errors. ld.lld: error: duplicate symbol: amp_rt1019 ld.lld: error: duplicate symbol: amp_max ld.lld: error: duplicate symbol: snd_soc_acpi_amd_acp63_acp_machines ld.lld: error: duplicate symbol: snd_soc_acpi_amd_acp70_acp_machines ld.lld: error: duplicate symbol: snd_soc_acpi_amd_rmb_acp_machines ld.lld: error: duplicate symbol: snd_soc_acpi_amd_acp_machines Fixes: 6e60db74b69c ("ASoC: amd: acp: Refactor acp machine select") Reported-by: kernel test robot Closes: https://lore.kernel.org/oe-kbuild-all/202503160801.yExt0K2E-lkp@intel.com/ Signed-off-by: Venkata Prasad Potturu --- sound/soc/amd/acp/Kconfig | 8 +++ sound/soc/amd/acp/Makefile | 2 + sound/soc/amd/acp/acp-pci.c | 8 +-- sound/soc/amd/acp/amd-acpi-mach.c | 93 +++++++++++++++++++++++++++++++ sound/soc/amd/acp/amd.h | 79 ++------------------------ 5 files changed, 111 insertions(+), 79 deletions(-) create mode 100644 sound/soc/amd/acp/amd-acpi-mach.c diff --git a/sound/soc/amd/acp/Kconfig b/sound/soc/amd/acp/Kconfig index 157c124570c8..b9432052c638 100644 --- a/sound/soc/amd/acp/Kconfig +++ b/sound/soc/amd/acp/Kconfig @@ -28,6 +28,9 @@ config SND_SOC_AMD_ACP_LEGACY_COMMON config SND_SOC_AMD_ACP_I2S tristate +config SND_SOC_AMD_ACPI_MACH + tristate + config SND_SOC_AMD_ACP_PCM tristate select SND_SOC_ACPI if ACPI @@ -37,6 +40,7 @@ config SND_SOC_AMD_ACP_PCI depends on X86 && PCI depends on ACPI select SND_SOC_AMD_ACP_LEGACY_COMMON + select SND_SOC_AMD_ACPI_MACH help This options enables generic PCI driver for ACP device. @@ -47,6 +51,7 @@ config SND_AMD_ASOC_RENOIR select SND_SOC_AMD_ACP_I2S select SND_SOC_AMD_ACP_PDM select SND_SOC_AMD_ACP_LEGACY_COMMON + select SND_SOC_AMD_ACPI_MACH depends on X86 && PCI help This option enables Renoir I2S support on AMD platform. @@ -58,6 +63,7 @@ config SND_AMD_ASOC_REMBRANDT select SND_SOC_AMD_ACP_I2S select SND_SOC_AMD_ACP_PDM select SND_SOC_AMD_ACP_LEGACY_COMMON + select SND_SOC_AMD_ACPI_MACH depends on AMD_NODE depends on X86 && PCI help @@ -74,6 +80,7 @@ config SND_AMD_ASOC_ACP63 select SND_SOC_AMD_ACP_I2S select SND_SOC_AMD_ACP_PDM select SND_SOC_AMD_ACP_LEGACY_COMMON + select SND_SOC_AMD_ACPI_MACH help This option enables Acp6.3 I2S support on AMD platform. Say Y if you want to enable AUDIO on ACP6.3 @@ -88,6 +95,7 @@ config SND_AMD_ASOC_ACP70 select SND_SOC_AMD_ACP_I2S select SND_SOC_AMD_ACP_PDM select SND_SOC_AMD_ACP_LEGACY_COMMON + select SND_SOC_AMD_ACPI_MACH help This option enables Acp7.0 PDM support on AMD platform. Say Y if you want to enable AUDIO on ACP7.0 diff --git a/sound/soc/amd/acp/Makefile b/sound/soc/amd/acp/Makefile index 7c75892e678b..08220b9a3802 100644 --- a/sound/soc/amd/acp/Makefile +++ b/sound/soc/amd/acp/Makefile @@ -11,6 +11,7 @@ snd-acp-pdm-y := acp-pdm.o snd-acp-legacy-common-y := acp-legacy-common.o snd-acp-pci-y := acp-pci.o snd-amd-sdw-acpi-y := amd-sdw-acpi.o +snd-amd-acpi-mach-y := amd-acpi-mach.o #platform specific driver snd-acp-renoir-y := acp-renoir.o @@ -32,6 +33,7 @@ obj-$(CONFIG_SND_SOC_AMD_ACP_I2S) += snd-acp-i2s.o obj-$(CONFIG_SND_SOC_AMD_ACP_PDM) += snd-acp-pdm.o obj-$(CONFIG_SND_SOC_AMD_ACP_LEGACY_COMMON) += snd-acp-legacy-common.o obj-$(CONFIG_SND_SOC_AMD_ACP_PCI) += snd-acp-pci.o +obj-$(CONFIG_SND_SOC_AMD_ACPI_MACH) += snd-amd-acpi-mach.o obj-$(CONFIG_SND_AMD_ASOC_RENOIR) += snd-acp-renoir.o obj-$(CONFIG_SND_AMD_ASOC_REMBRANDT) += snd-acp-rembrandt.o diff --git a/sound/soc/amd/acp/acp-pci.c b/sound/soc/amd/acp/acp-pci.c index 9322379cb36f..e15904aabc06 100644 --- a/sound/soc/amd/acp/acp-pci.c +++ b/sound/soc/amd/acp/acp-pci.c @@ -137,26 +137,26 @@ static int acp_pci_probe(struct pci_dev *pci, const struct pci_device_id *pci_id chip->name = "acp_asoc_renoir"; chip->rsrc = &rn_rsrc; chip->acp_hw_ops_init = acp31_hw_ops_init; - chip->machines = snd_soc_acpi_amd_acp_machines; + chip->machines = &snd_soc_acpi_amd_acp_machines; break; case 0x6f: chip->name = "acp_asoc_rembrandt"; chip->rsrc = &rmb_rsrc; chip->acp_hw_ops_init = acp6x_hw_ops_init; - chip->machines = snd_soc_acpi_amd_rmb_acp_machines; + chip->machines = &snd_soc_acpi_amd_rmb_acp_machines; break; case 0x63: chip->name = "acp_asoc_acp63"; chip->rsrc = &acp63_rsrc; chip->acp_hw_ops_init = acp63_hw_ops_init; - chip->machines = snd_soc_acpi_amd_acp63_acp_machines; + chip->machines = &snd_soc_acpi_amd_acp63_acp_machines; break; case 0x70: case 0x71: chip->name = "acp_asoc_acp70"; chip->rsrc = &acp70_rsrc; chip->acp_hw_ops_init = acp70_hw_ops_init; - chip->machines = snd_soc_acpi_amd_acp70_acp_machines; + chip->machines = &snd_soc_acpi_amd_acp70_acp_machines; break; default: dev_err(dev, "Unsupported device revision:0x%x\n", pci->revision); diff --git a/sound/soc/amd/acp/amd-acpi-mach.c b/sound/soc/amd/acp/amd-acpi-mach.c new file mode 100644 index 000000000000..d95047d2ee94 --- /dev/null +++ b/sound/soc/amd/acp/amd-acpi-mach.c @@ -0,0 +1,93 @@ +// SPDX-License-Identifier: GPL-2.0-only +/* + * amd-acpi-match.c - tables and support for ACP platforms + * ACPI enumeration. + * + * Copyright 2025 Advanced Micro Devices, Inc. + */ + +#include + +struct snd_soc_acpi_codecs amp_rt1019 = { + .num_codecs = 1, + .codecs = {"10EC1019"} +}; + +struct snd_soc_acpi_codecs amp_max = { + .num_codecs = 1, + .codecs = {"MX98360A"} +}; + +struct snd_soc_acpi_mach snd_soc_acpi_amd_acp_machines[] = { + { + .id = "10EC5682", + .drv_name = "acp3xalc56821019", + .machine_quirk = snd_soc_acpi_codec_list, + .quirk_data = &_rt1019, + }, + { + .id = "RTL5682", + .drv_name = "acp3xalc5682sm98360", + .machine_quirk = snd_soc_acpi_codec_list, + .quirk_data = &_max, + }, + { + .id = "RTL5682", + .drv_name = "acp3xalc5682s1019", + .machine_quirk = snd_soc_acpi_codec_list, + .quirk_data = &_rt1019, + }, + { + .id = "AMDI1019", + .drv_name = "renoir-acp", + }, + { + .id = "ESSX8336", + .drv_name = "acp3x-es83xx", + }, + {}, +}; +EXPORT_SYMBOL_NS_GPL(snd_soc_acpi_amd_acp_machines, "SND_SOC_ACP_COMMON"); + +struct snd_soc_acpi_mach snd_soc_acpi_amd_rmb_acp_machines[] = { + { + .id = "10508825", + .drv_name = "rmb-nau8825-max", + .machine_quirk = snd_soc_acpi_codec_list, + .quirk_data = &_max, + }, + { + .id = "AMDI0007", + .drv_name = "rembrandt-acp", + }, + { + .id = "RTL5682", + .drv_name = "rmb-rt5682s-rt1019", + .machine_quirk = snd_soc_acpi_codec_list, + .quirk_data = &_rt1019, + }, + {}, +}; +EXPORT_SYMBOL_NS_GPL(snd_soc_acpi_amd_rmb_acp_machines, "SND_SOC_ACP_COMMON"); + +struct snd_soc_acpi_mach snd_soc_acpi_amd_acp63_acp_machines[] = { + { + .id = "AMDI0052", + .drv_name = "acp63-acp", + }, + {}, +}; +EXPORT_SYMBOL_NS_GPL(snd_soc_acpi_amd_acp63_acp_machines, "SND_SOC_ACP_COMMON"); + +struct snd_soc_acpi_mach snd_soc_acpi_amd_acp70_acp_machines[] = { + { + .id = "AMDI0029", + .drv_name = "acp70-acp", + }, + {}, +}; +EXPORT_SYMBOL_NS_GPL(snd_soc_acpi_amd_acp70_acp_machines, "SND_SOC_ACP_COMMON"); + +MODULE_DESCRIPTION("AMD ACP tables and support for ACPI enumeration"); +MODULE_LICENSE("GPL"); +MODULE_AUTHOR("Venkataprasad.potturu@amd.com"); diff --git a/sound/soc/amd/acp/amd.h b/sound/soc/amd/acp/amd.h index 796f8efd395c..928aa60ab386 100644 --- a/sound/soc/amd/acp/amd.h +++ b/sound/soc/amd/acp/amd.h @@ -277,81 +277,10 @@ struct acp_resource acp70_rsrc = { .sram_pte_offset = 0x03800000, }; -struct snd_soc_acpi_codecs amp_rt1019 = { - .num_codecs = 1, - .codecs = {"10EC1019"} -}; - -struct snd_soc_acpi_codecs amp_max = { - .num_codecs = 1, - .codecs = {"MX98360A"} -}; - -struct snd_soc_acpi_mach snd_soc_acpi_amd_acp_machines[] = { - { - .id = "10EC5682", - .drv_name = "acp3xalc56821019", - .machine_quirk = snd_soc_acpi_codec_list, - .quirk_data = &_rt1019, - }, - { - .id = "RTL5682", - .drv_name = "acp3xalc5682sm98360", - .machine_quirk = snd_soc_acpi_codec_list, - .quirk_data = &_max, - }, - { - .id = "RTL5682", - .drv_name = "acp3xalc5682s1019", - .machine_quirk = snd_soc_acpi_codec_list, - .quirk_data = &_rt1019, - }, - { - .id = "AMDI1019", - .drv_name = "renoir-acp", - }, - { - .id = "ESSX8336", - .drv_name = "acp3x-es83xx", - }, - {}, -}; - -struct snd_soc_acpi_mach snd_soc_acpi_amd_rmb_acp_machines[] = { - { - .id = "10508825", - .drv_name = "rmb-nau8825-max", - .machine_quirk = snd_soc_acpi_codec_list, - .quirk_data = &_max, - }, - { - .id = "AMDI0007", - .drv_name = "rembrandt-acp", - }, - { - .id = "RTL5682", - .drv_name = "rmb-rt5682s-rt1019", - .machine_quirk = snd_soc_acpi_codec_list, - .quirk_data = &_rt1019, - }, - {}, -}; - -struct snd_soc_acpi_mach snd_soc_acpi_amd_acp63_acp_machines[] = { - { - .id = "AMDI0052", - .drv_name = "acp63-acp", - }, - {}, -}; - -struct snd_soc_acpi_mach snd_soc_acpi_amd_acp70_acp_machines[] = { - { - .id = "AMDI0029", - .drv_name = "acp70-acp", - }, - {}, -}; +extern struct snd_soc_acpi_mach snd_soc_acpi_amd_acp_machines; +extern struct snd_soc_acpi_mach snd_soc_acpi_amd_rmb_acp_machines; +extern struct snd_soc_acpi_mach snd_soc_acpi_amd_acp63_acp_machines; +extern struct snd_soc_acpi_mach snd_soc_acpi_amd_acp70_acp_machines; extern const struct snd_soc_dai_ops asoc_acp_cpu_dai_ops; extern const struct snd_soc_dai_ops acp_dmic_dai_ops; From patchwork Mon Mar 17 07:24:08 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Venkata Prasad Potturu X-Patchwork-Id: 874458 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3820EC282EC for ; Mon, 17 Mar 2025 07:25:38 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [45.14.194.44]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 7C0DC6035A; Mon, 17 Mar 2025 08:25:26 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 7C0DC6035A DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1742196336; bh=6mGcPhSg6ORC89SZMicCnNxYy+WQF4rCZ0hGkCQsf3o=; h=From:To:CC:Subject:Date:In-Reply-To:References:List-Id: List-Archive:List-Help:List-Owner:List-Post:List-Subscribe: List-Unsubscribe:From; b=gyvAFDERFALasti0mX3v+S9tNRlj8my+drX366u3Tfv3MuLFui5vYrmPsish5WCRt Lf+2Jq6AljunSJ52f5tEOgT4iQLbfjuo5o/L7jSuHJROR76O9r92YqbXhS6Tx9e7ft X8Mxn+5tTm1UqllaRSAspHl6rP96emaa0HdficIY= Received: by alsa1.perex.cz (Postfix, from userid 50401) id 110F2F805E7; Mon, 17 Mar 2025 08:24:39 +0100 (CET) Received: from mailman-core.alsa-project.org (mailman-core.alsa-project.org [10.254.200.10]) by alsa1.perex.cz (Postfix) with ESMTP id A1F7BF805D8; Mon, 17 Mar 2025 08:24:39 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id A46BDF8055B; Mon, 17 Mar 2025 08:24:35 +0100 (CET) Received: from NAM11-BN8-obe.outbound.protection.outlook.com (mail-bn8nam11on20607.outbound.protection.outlook.com [IPv6:2a01:111:f403:2414::607]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-384) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id B06CFF80212 for ; Mon, 17 Mar 2025 08:24:33 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz B06CFF80212 Authentication-Results: alsa1.perex.cz; dkim=pass (1024-bit key, unprotected) header.d=amd.com header.i=@amd.com header.a=rsa-sha256 header.s=selector1 header.b=qxWxhIa8 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=aoaQv6qTvVY9y7LL9G61Rzgcgg5cR+BK+xUtZKLqmhFyRHEjJyluvsAouBIeuALDpEfQUdmMRf+NsJPb2WeEwzKMFjRlTunQ4q4lmJtDBFlm3l6IygzpLOVSVELAovb3mm/+jDRVC2zUbCzVf/Ufb6zrFY8LAclcXSEdVbMr7HJPbiMcIRAeciKamPQJwUZIGAVuzqoOryf8FddUfXO8Bd+HNTtZbHSNgtbEpgWLaFk4Iw6modWd7M/7FHGsx2gRMZFZ5A1flkikx6ChJyogRPYP8wXvqH2hkjY4pSAMivC8nQs6FdccN47PtYfWVvkUR+sHbMo5GeK1jI34yLQdTQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=IBvcRm1AsjDbfHH6FxFXEb6i1KdA61i2WlXZnRx9aas=; b=ARjwkkdiAHOCiHAELe5HXP90toKW9h57XMpEMbapU0RqZxyoeClfS9GO0QWVhJjeqZVx9hJgYv2lAEq7DyxE2Vqf+Iw5qbyeqex9wAdQwPHbKheJOEXDzMPqESj2egoerP98TkwZZseMLpspvBH2Aep6/hCs/Y99OGBVhvDyOU64T5eqxesi7BFOII6Tg++5oLoDxa9OQzNcK0j756kDENM4wIksfe1d+9Bg+hLr0wF15yK4T+WrPS4RaTGev9cDY6TTWwOT50U6hRgVnAK8RttbBfqENS3nzSkLLqqOfi6JuBos3rlG20yKJqI5EyCouOK41c5KH3U3fDLpVWKn+g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=kernel.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=IBvcRm1AsjDbfHH6FxFXEb6i1KdA61i2WlXZnRx9aas=; b=qxWxhIa8Mi7V5A+BL7e8qVg91qENlidDclBIHZ0vXBwx+ytTz46NC+9OFkuCDS5aGM+PsjwuQieg2AZ99avbo5AIrP44gcQ6Id/sbk57TFI/zh7wfUYmSXlJq4jrYj9OPSm+wla+TkjeUEc5uqlyri3Mg75yzNlM08tt73gJSRI= Received: from BYAPR05CA0018.namprd05.prod.outlook.com (2603:10b6:a03:c0::31) by SA3PR12MB8802.namprd12.prod.outlook.com (2603:10b6:806:314::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8534.33; Mon, 17 Mar 2025 07:24:27 +0000 Received: from SJ1PEPF00002323.namprd03.prod.outlook.com (2603:10b6:a03:c0:cafe::3a) by BYAPR05CA0018.outlook.office365.com (2603:10b6:a03:c0::31) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.8534.33 via Frontend Transport; Mon, 17 Mar 2025 07:24:27 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB03.amd.com; pr=C Received: from SATLEXMB03.amd.com (165.204.84.17) by SJ1PEPF00002323.mail.protection.outlook.com (10.167.242.85) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.8534.20 via Frontend Transport; Mon, 17 Mar 2025 07:24:26 +0000 Received: from SATLEXMB06.amd.com (10.181.40.147) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Mon, 17 Mar 2025 02:24:26 -0500 Received: from SATLEXMB04.amd.com (10.181.40.145) by SATLEXMB06.amd.com (10.181.40.147) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Mon, 17 Mar 2025 02:24:25 -0500 Received: from prasad-lnx-mach.amd.com (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server id 15.1.2507.39 via Frontend Transport; Mon, 17 Mar 2025 02:24:21 -0500 From: Venkata Prasad Potturu To: , CC: , , , , , , Venkata Prasad Potturu , kernel test robot , "Liam Girdwood" , Jaroslav Kysela , "Takashi Iwai" , Peter Zijlstra , Greg KH , Jeff Johnson , "open list:SOUND - SOC LAYER / DYNAMIC AUDIO POWER MANAGEM..." , open list Subject: [PATCH 2/3] ASoC: amd: acp: Fix acp_resource duplicate symbol error Date: Mon, 17 Mar 2025 12:54:08 +0530 Message-ID: <20250317072413.88971-2-venkataprasad.potturu@amd.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20250317072413.88971-1-venkataprasad.potturu@amd.com> References: <20250317072413.88971-1-venkataprasad.potturu@amd.com> MIME-Version: 1.0 X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ1PEPF00002323:EE_|SA3PR12MB8802:EE_ X-MS-Office365-Filtering-Correlation-Id: 6a3ceb86-9ad3-42e5-8e03-08dd6524c002 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|82310400026|36860700013|1800799024|376014|7416014|13003099007; X-Microsoft-Antispam-Message-Info: FP53HJVWDVLaq2Daq3Kq1vowcj8O9Kmj/JFNa68h7WzgwuqGPWCh/WD0PQCI21KLyq5yOvrf160Sr/4ZvMcI2iQYOf9ItJHJPYnfJsKaaVyDaMVHyVtDuDMj2RewxmH0O/HjvwHAJFQeGcZ/f2qtUcMuH1CdhfPJu+m0qudOPWyk4Lo4Lk3/YeoEODZFjEMUcztYIaUH2K7oOylXbcXelXhHonEsg6qk4bG3Wh8POlKjkIHMaZCd1a8+cS1laHKvnx9t6vtX1JsNJoNNV72o7rVR1D08jnphdcAaWjtxyYrznvJJ7LXyNbDbD3kj4gO8Tl/UiwDZRCspKAMCeVNleBnpopuVD2tbPQyi8+yZ88GQ3Ywqb2dKIO4+Pe9cd3kcpQ4AL62vuc7SzZ3ERml+5V6x3s5Cw39v6ty3uTChEgGQKust7lPyalUR2Z11PIgdA3OG4N1hsf4nV1vxu7KVPKeu9zqNaw31nUxKOyU16hCuewLlzao7T4r0E3g7Z0IvuRc9EuV7XkJfgzocvppmkz6ZStWOupGWUCfi3k5m7MbWuo9rS3CFHq2IOCtZeoTH7ucnjGmNAJFh1DNoZ4OjFrqPFazGyj9kt4qBOvRaLYrtnglCKWMaARakvJCUxc9l+BdpypQSEe4RciZgIGvQuj8JQT3d5NBlK3Qp/yWx2yVBWda5qHZNSDgs3jEzUlGK684SBvjPsP4IM87/C8bbHy669t0TpEoTYSdhZGHm3oZLpDlyr96k5QIAQj3OuGOtDGEx8EIrrJPF78Bsuty4TDYiH0lAVTR1fafiVxqdxvHzczjTwa4M9xEqSxEdW/1LyUY+NGAr7cHPwT5ttInk9YZLyLezE9IQB9zHpbfiSjZlLR7RbAZdHek3aPySab9qWjjjRvK2SrwVcFNhp8e3+vW58qENookjxA70BbygD+pJ5OO+/xgI7eQ64P0ZHdO4oDgZFLOswVRFYHpaPq51H4QAADwXC+bUZ+tBJa2TjAP97MurrZOazYp6vunDGfH6eXQPMDuwjzZ40B1jjtza4wEMKekYTWiBhaKPDj4BqMAge7Vz8iLwBHrs+6JprjcoxVsCc9cqDhLepvXEVE5c+Fjs7Z0sFbu0Zi6oSYO2hZAmgT28pvHaAHIMsEiBG/6n2ajOxuIn0O5i9GM9nKGGQa+/OC797MTfPROyK7hjgpx6ea+SZTZP5Gb37rnYSfIgTPl8EK2ge6XpiYdpuJJUYIYq5j7G6xxwAhX3/DF3ZJ/JgVjkquaaHlxggGmJnIn6hRemGlga9Xpz88X6pCz6LHfc4+fZ3joQ3LcxjPcSHhOrtQNIQG5S+NWQT/0IL3y9bq+REzxR/RmldlLdPNH9a8CIcSXIXVM1nWhNFYC23k9E6Ppkka/HOugrIZckSDJ8+CUnvKpRhF1Zr8uJi8n7kqDoc6hWW2/XdNdS3gNBRLjA0Hlc9f9mNo0H/4LTPOPcxXSOnxR9u1VJWK6u80aa91++vrUDLEOnxNySdMLlU7M= X-Forefront-Antispam-Report: CIP:165.204.84.17; CTRY:US; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:SATLEXMB03.amd.com; PTR:InfoDomainNonexistent; CAT:NONE; SFS:(13230040)(82310400026)(36860700013)(1800799024)(376014)(7416014)(13003099007); DIR:OUT; SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Mar 2025 07:24:26.9693 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 6a3ceb86-9ad3-42e5-8e03-08dd6524c002 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d; Ip=[165.204.84.17]; Helo=[SATLEXMB03.amd.com] X-MS-Exchange-CrossTenant-AuthSource: SJ1PEPF00002323.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA3PR12MB8802 Message-ID-Hash: F2LN222HIYI6VGAZ63ZBABLKDHA6NNL5 X-Message-ID-Hash: F2LN222HIYI6VGAZ63ZBABLKDHA6NNL5 X-MailFrom: venkataprasad.potturu@amd.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-alsa-devel.alsa-project.org-0; header-match-alsa-devel.alsa-project.org-1; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.9 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Fix acp_resource structure duplicate defination error by adding export symbol and extern keyword in header file. ld.lld: error: duplicate symbol: acp63_rsrc ld.lld: error: duplicate symbol: acp70_rsrc Fixes: f8b4f3f525e8 ("ASoC: amd: acp: Refactor acp70 platform resource structure") Reported-by: kernel test robot Closes: https://lore.kernel.org/oe-kbuild-all/202503160801.yExt0K2E-lkp@intel.com/ Signed-off-by: Venkata Prasad Potturu --- sound/soc/amd/acp/acp-legacy-common.c | 43 +++++++++++++++++++++++++++ sound/soc/amd/acp/amd.h | 42 +++----------------------- 2 files changed, 47 insertions(+), 38 deletions(-) diff --git a/sound/soc/amd/acp/acp-legacy-common.c b/sound/soc/amd/acp/acp-legacy-common.c index 255f90ca956a..5fad6c4a8d86 100644 --- a/sound/soc/amd/acp/acp-legacy-common.c +++ b/sound/soc/amd/acp/acp-legacy-common.c @@ -24,6 +24,49 @@ #define ACP63_PDM_ADDR 0x02 #define ACP70_PDM_ADDR 0x02 +struct acp_resource rn_rsrc = { + .offset = 20, + .no_of_ctrls = 1, + .irqp_used = 0, + .irq_reg_offset = 0x1800, + .scratch_reg_offset = 0x12800, + .sram_pte_offset = 0x02052800, +}; +EXPORT_SYMBOL_NS_GPL(rn_rsrc, "SND_SOC_ACP_COMMON"); + +struct acp_resource rmb_rsrc = { + .offset = 0, + .no_of_ctrls = 2, + .irqp_used = 1, + .soc_mclk = true, + .irq_reg_offset = 0x1a00, + .scratch_reg_offset = 0x12800, + .sram_pte_offset = 0x03802800, +}; +EXPORT_SYMBOL_NS_GPL(rmb_rsrc, "SND_SOC_ACP_COMMON"); + +struct acp_resource acp63_rsrc = { + .offset = 0, + .no_of_ctrls = 2, + .irqp_used = 1, + .soc_mclk = true, + .irq_reg_offset = 0x1a00, + .scratch_reg_offset = 0x12800, + .sram_pte_offset = 0x03802800, +}; +EXPORT_SYMBOL_NS_GPL(acp63_rsrc, "SND_SOC_ACP_COMMON"); + +struct acp_resource acp70_rsrc = { + .offset = 0, + .no_of_ctrls = 2, + .irqp_used = 1, + .soc_mclk = true, + .irq_reg_offset = 0x1a00, + .scratch_reg_offset = 0x10000, + .sram_pte_offset = 0x03800000, +}; +EXPORT_SYMBOL_NS_GPL(acp70_rsrc, "SND_SOC_ACP_COMMON"); + const struct snd_acp_hw_ops acp_common_hw_ops = { /* ACP hardware initilizations */ .acp_init = acp_init, diff --git a/sound/soc/amd/acp/amd.h b/sound/soc/amd/acp/amd.h index 928aa60ab386..863e74fcee43 100644 --- a/sound/soc/amd/acp/amd.h +++ b/sound/soc/amd/acp/amd.h @@ -238,44 +238,10 @@ enum acp_config { ACP_CONFIG_20, }; -struct acp_resource rn_rsrc = { - .offset = 20, - .no_of_ctrls = 1, - .irqp_used = 0, - .irq_reg_offset = 0x1800, - .scratch_reg_offset = 0x12800, - .sram_pte_offset = 0x02052800, -}; - -struct acp_resource rmb_rsrc = { - .offset = 0, - .no_of_ctrls = 2, - .irqp_used = 1, - .soc_mclk = true, - .irq_reg_offset = 0x1a00, - .scratch_reg_offset = 0x12800, - .sram_pte_offset = 0x03802800, -}; - -struct acp_resource acp63_rsrc = { - .offset = 0, - .no_of_ctrls = 2, - .irqp_used = 1, - .soc_mclk = true, - .irq_reg_offset = 0x1a00, - .scratch_reg_offset = 0x12800, - .sram_pte_offset = 0x03802800, -}; - -struct acp_resource acp70_rsrc = { - .offset = 0, - .no_of_ctrls = 2, - .irqp_used = 1, - .soc_mclk = true, - .irq_reg_offset = 0x1a00, - .scratch_reg_offset = 0x10000, - .sram_pte_offset = 0x03800000, -}; +extern struct acp_resource rn_rsrc; +extern struct acp_resource rmb_rsrc; +extern struct acp_resource acp63_rsrc; +extern struct acp_resource acp70_rsrc; extern struct snd_soc_acpi_mach snd_soc_acpi_amd_acp_machines; extern struct snd_soc_acpi_mach snd_soc_acpi_amd_rmb_acp_machines; From patchwork Mon Mar 17 07:24:09 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Venkata Prasad Potturu X-Patchwork-Id: 874182 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id F33E4C282EC for ; Mon, 17 Mar 2025 07:25:51 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [45.14.194.44]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 4A7236037A; Mon, 17 Mar 2025 08:25:40 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 4A7236037A DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1742196350; bh=s5oamb6a2qmfpjMpAPuFgUrH5vberIukY87Q6gKzRrM=; h=From:To:CC:Subject:Date:In-Reply-To:References:List-Id: List-Archive:List-Help:List-Owner:List-Post:List-Subscribe: List-Unsubscribe:From; b=fBqJ555GtL38OaDDbi/pK/0uGg9UYKa0HqDFt2dKPIMhwH0Xe+oaPFn5qlXSB5tx5 eZsvxmktKomrXpGe2cBdKNT5rUji+kI662s1C4E/tWNTiNxh+CGBc0OEwlsvUFz6SU 74/8ZvH3wLYKMVg9SGXyHiR2urSvjWvOhH8S65ro= Received: by alsa1.perex.cz (Postfix, from userid 50401) id E3D07F80608; Mon, 17 Mar 2025 08:24:47 +0100 (CET) Received: from mailman-core.alsa-project.org (mailman-core.alsa-project.org [10.254.200.10]) by alsa1.perex.cz (Postfix) with ESMTP id B7957F8060F; Mon, 17 Mar 2025 08:24:47 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 8FC77F805F8; Mon, 17 Mar 2025 08:24:42 +0100 (CET) Received: from NAM11-BN8-obe.outbound.protection.outlook.com (mail-bn8nam11on2060e.outbound.protection.outlook.com [IPv6:2a01:111:f403:2414::60e]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-384) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id C558BF805F5 for ; Mon, 17 Mar 2025 08:24:40 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz C558BF805F5 Authentication-Results: alsa1.perex.cz; dkim=pass (1024-bit key, unprotected) header.d=amd.com header.i=@amd.com header.a=rsa-sha256 header.s=selector1 header.b=p/CUoNVB ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=TrzP87WLUgyhZ4EO8Z0lmMDwS5cLzTpRsFZF0nlWX5lXspldEyAuQgRij0CY15CISIyOXr0IfPFQk7abyTL+4iabdNboD5h4ThGRbhle3um8zeYcd14847IkK+0nGZvOTBSlyIPpErUZPqzVVC7Ag3c+JYeQAnWXHTQ+bOFc5JuDQhgHM+ROG57HK+eqrGoa41iyFQiR6ph+dWt6Etbf3pMBBWGPgir/rcUYsInCho7s9ywvxmuF9xdGfvCkzwdUs26kNvvsdRYs2sB+74ZrbC1g66Pf4DznFmuM01r3wpqVCQdrhBtkp9K2OYcM0C26KRDkIGJsm8TCfb1rbxl85Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ggqSQm2k6sUoN56arrnjYVBjyLse4rBrlSmLhyqOgnw=; b=FZnZKlr3WXP9KEXkSyzQDHNiGgej9abGg33K7m9VM51+YP4PggmbE1VcAFwGKbeV0G9eo92wTtHV53VNRAM2H2esPwvpJVxHMrN1Pmi9tRnNdxX9cuOeU3zTHQNzeui2QCnZK1pm61+GiXnwkyESSXhp7oqeCdzeDBJN/7vpRR7/xRyG1bAtZ9RXBw/EC1L5+wZXezo1bW/LJh9/3OiYz/j/2aazZrgwG7u2pCSYfyp+If0UHBLcGWP1Rbqj3coRFr0/wSbI18d5yGn3DaHSOFOJSW9fuBhrGrKrrENh9KOymKRe2XYbe4IITeW+j7EOaDwAjlx9bUsGlhZ7Wo1bBA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=kernel.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ggqSQm2k6sUoN56arrnjYVBjyLse4rBrlSmLhyqOgnw=; b=p/CUoNVBaitlDgdqNBpDZjSAARZ4mZBv9vCK9AxJmAt0F2YRAYlCUml2kSauYaOcqM0xD+XfJPS7S36AVFAJRScrEApeWiWLX2hFBqcJB50xRtSP69Sst8jjDzlqgqpdZXcKloHR0troegjvaoIYbsGpPLxLKTIe0265ciAugRU= Received: from BYAPR05CA0003.namprd05.prod.outlook.com (2603:10b6:a03:c0::16) by PH7PR12MB7380.namprd12.prod.outlook.com (2603:10b6:510:20f::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8534.33; Mon, 17 Mar 2025 07:24:34 +0000 Received: from SJ1PEPF00002323.namprd03.prod.outlook.com (2603:10b6:a03:c0:cafe::af) by BYAPR05CA0003.outlook.office365.com (2603:10b6:a03:c0::16) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.8534.31 via Frontend Transport; Mon, 17 Mar 2025 07:24:34 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB03.amd.com; pr=C Received: from SATLEXMB03.amd.com (165.204.84.17) by SJ1PEPF00002323.mail.protection.outlook.com (10.167.242.85) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.8534.20 via Frontend Transport; Mon, 17 Mar 2025 07:24:34 +0000 Received: from SATLEXMB04.amd.com (10.181.40.145) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Mon, 17 Mar 2025 02:24:31 -0500 Received: from prasad-lnx-mach.amd.com (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server id 15.1.2507.39 via Frontend Transport; Mon, 17 Mar 2025 02:24:27 -0500 From: Venkata Prasad Potturu To: , CC: , , , , , , Venkata Prasad Potturu , kernel test robot , "Liam Girdwood" , Jaroslav Kysela , "Takashi Iwai" , Greg KH , Peter Zijlstra , Jeff Johnson , "open list:SOUND - SOC LAYER / DYNAMIC AUDIO POWER MANAGEM..." , open list Subject: [PATCH 3/3] ASoC: amd: acp: Fix acp_common_hw_ops declaration error Date: Mon, 17 Mar 2025 12:54:09 +0530 Message-ID: <20250317072413.88971-3-venkataprasad.potturu@amd.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20250317072413.88971-1-venkataprasad.potturu@amd.com> References: <20250317072413.88971-1-venkataprasad.potturu@amd.com> MIME-Version: 1.0 Received-SPF: None (SATLEXMB03.amd.com: venkataprasad.potturu@amd.com does not designate permitted sender hosts) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ1PEPF00002323:EE_|PH7PR12MB7380:EE_ X-MS-Office365-Filtering-Correlation-Id: d0776bef-4b80-4a13-1d8f-08dd6524c482 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|7416014|376014|82310400026|36860700013|1800799024; X-Microsoft-Antispam-Message-Info: FkEzTDFOBBIc4WLr0h2s0cVsb79C8D67tjN4v9USn/HEg8YptY6DaBHfi64WA4ZxLgeTOjQKAP3P25nSwckZWB+Ja7Pp9gG5xc9y6B4y1CdlIRZYlv51IKUpy8j0Wk28gCnfjYCsCwZYfqkp5F7mvwLss8tqvSc1UMWUj/O174EVkhElHwg7WE+i/TD+6ce1V1UTHv7IXGZSa6nfA0pdXNBr1zN6XCtZYgWemwHmeaQjRzd0AxOH0RXe2naYV05Mg5iFXahOKWBjvQCH8BWEsXieVNez2Nz8dsByaWrhEfIm4yWtDivfmyH4i6Z1I4mRNF0iUuD8AMHsU/1ufPVBP7xUxZG91DYvuOoIzxqX5PSvcmAiWAt9pYHf86RXQRAsdRKEGc+KOyisNGrCjSyd/OPfUP3ixPM5qXHMvPJqdeoYip7yXEIHpfG/4gtijkYsucTGD2CaZbyk4+Q5jIwidNWPqH2+b0yXi+xEV9syaFVnrM4QBqpc6GF4K3kWeXO0zIYBw/T7rZ1jkgLoX3z25+hhTk9ty2T4mBIqq03pGvCBhwLhVqpOdQsr5u9v5bBu8LbyDdUv2MrzEswRSyey2HCt6yXWuV4x55OXGu5jFAH/PRdDjl0tFpFeULPgZzPKjus9ErkawdkKMPCn1d2pKzR6Rd0lWPtEoxHzfz9Zzw8Yqgivr7SfO1vhN30W+VIQtmuAPJKZXfSixGt2XlrNZtWM/pM/b4UUUQfe3DWC16H1+yhnTx0+dO9kT0b+ZM0b2X1qO6428tFzawWElKWy3uUjWvvqQ1T5hXYhSN+zr60cW+9uryBiaCwaZ5CBa9sXUz9k1GzRYxrKwCgxuQEfvrJlW8CRCqLQI0ZYpViuj9LEz8HOtl26EcX971VjfCsK1No5mYkFW5z2peGMJaF1QGb4+YS98Q67mwPueq80j7yxXSkcl4TEe70NjUkHhIsQlfHVWLuRBiGcwNat90HUhzl0UUeCQjkaK0j7eyQ5bE6gij/e9XCtrC3Dz7d2Rcn5QZlDkNsrVKNIyl/tgYl+6MDy7Xrqexx1pb74/T0xIp56BFfPRY0CQ9JjoQjqhqmFDIMEg1H9W1hbjL/icQd1q/3lgYNs0sH1IowGrMvk0xr6Brc8ugtOpgTIH7NO4YbmzS0Gpyd+muza2oOP5boKOzl9RCZP8UmidfhxJlJWZNSHVaVuo55OTNDDcF1Q3YxEbdsQ12763dtKSjGCS5qpp0cQxm+yKxNjQ3ba32XRxtqMeWN5rrW7JavEcgcI4l3RIVqsiRdUlNiV/iX+UO5d9mNgOd0tpKlXWfNZVNP7dX+YZn/3zL3O/prTusIO/TO97P4rh0gNj7iRuyI2qlT8SUUdpyCGJ31pMd9+SthV9IGHic6RqFmT4avgPUS6FrJmHNfB9Wq70sSEk2AJO57JY6WtHyJ0E6ipviU72bLhBZHZZTEdERnfx58kw5gF5yNlxJc5UYSZCgydSrx9cA+bwhIf1Urqx8Crc69IJl0Og0s= X-Forefront-Antispam-Report: CIP:165.204.84.17; CTRY:US; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:SATLEXMB03.amd.com; PTR:InfoDomainNonexistent; CAT:NONE; SFS:(13230040)(7416014)(376014)(82310400026)(36860700013)(1800799024); DIR:OUT; SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Mar 2025 07:24:34.5161 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: d0776bef-4b80-4a13-1d8f-08dd6524c482 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d; Ip=[165.204.84.17]; Helo=[SATLEXMB03.amd.com] X-MS-Exchange-CrossTenant-AuthSource: SJ1PEPF00002323.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR12MB7380 Message-ID-Hash: UPWBWE6NKVBIODNTG5Y4AD6YPXZZQJA3 X-Message-ID-Hash: UPWBWE6NKVBIODNTG5Y4AD6YPXZZQJA3 X-MailFrom: venkataprasad.potturu@amd.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-alsa-devel.alsa-project.org-0; header-match-alsa-devel.alsa-project.org-1; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.9 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Fix acp_common_hw_ops declaration error by adding static and remove export symbol. sparse: symbol 'acp_common_hw_ops' was not declared. Should it be static? Fixes: 8ae746fe5104 ("ASoC: amd: acp: Implement acp_common_hw_ops support for acp platforms") Reported-by: kernel test robot Closes: https://lore.kernel.org/oe-kbuild-all/202503141442.iT0LHEMx-lkp@intel.com/ Signed-off-by: Venkata Prasad Potturu --- sound/soc/amd/acp/acp-legacy-common.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/sound/soc/amd/acp/acp-legacy-common.c b/sound/soc/amd/acp/acp-legacy-common.c index 5fad6c4a8d86..b4d68484e06d 100644 --- a/sound/soc/amd/acp/acp-legacy-common.c +++ b/sound/soc/amd/acp/acp-legacy-common.c @@ -67,7 +67,7 @@ struct acp_resource acp70_rsrc = { }; EXPORT_SYMBOL_NS_GPL(acp70_rsrc, "SND_SOC_ACP_COMMON"); -const struct snd_acp_hw_ops acp_common_hw_ops = { +static const struct snd_acp_hw_ops acp_common_hw_ops = { /* ACP hardware initilizations */ .acp_init = acp_init, .acp_deinit = acp_deinit, @@ -77,7 +77,6 @@ const struct snd_acp_hw_ops acp_common_hw_ops = { .en_interrupts = acp_enable_interrupts, .dis_interrupts = acp_disable_interrupts, }; -EXPORT_SYMBOL_NS_GPL(acp_common_hw_ops, "SND_SOC_ACP_COMMON"); irqreturn_t acp_irq_handler(int irq, void *data) {