From patchwork Wed Mar 5 10:14:48 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mathis Foerst X-Patchwork-Id: 870705 Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05on2065.outbound.protection.outlook.com [40.107.22.65]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 991902063F8; Wed, 5 Mar 2025 10:15:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.22.65 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741169730; cv=fail; b=urW1GDpOVHKvqVOFKk8xeTVOEg4wiIojhS9HbdQzAQ2H68TfKHw4pbQvSis4DEmNFP6Xy6gtVA7Lt20kI2bvwhUfH8RZeux4o2FSJ/fAY1IPZyTDkQmV80q4EQ2Ro6Nbwp5ugWaNkaZbotWJGks3d2XI1U7eOCGSnRhrKQIukbs= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741169730; c=relaxed/simple; bh=TwQZ1kx3BcEfthhx4JmM95SovqBvAcQLO/N0pIaSTl4=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: Content-Type:MIME-Version; b=Rbb8zagP1RkC0RGOgr9tohF1c9Kngfxyxj6DsbLy8lNXVeq6qj197lEkTcAjdZYX1lJ5JTVIwKCh+VsRbJMQNBqeHkAprWZPIvepxenQZCLzECfzqnnB7/yEjDJ+2vYWaii9X14TEYdRC5mSMdZ88sGVu3w71lvqcSUA57j4la8= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=mt.com; spf=pass smtp.mailfrom=mt.com; dkim=pass (2048-bit key) header.d=mt.com header.i=@mt.com header.b=eH3bA9BN; arc=fail smtp.client-ip=40.107.22.65 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=mt.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=mt.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=mt.com header.i=@mt.com header.b="eH3bA9BN" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=tEj57FNjrlZjL31UrnYO097gVmnhVjC9K63tzUkkrhAyj7HJ51ZAvWtQxZ63jfCXkW2bXkIc1d/LaJinwcwRJgXHrALfvU7ssH/fdx5JbDvPd/DF+n4wQ98ayZhWlLs+jJTpJqiAGYCnpk5hx/U+OzGKZ6Bd3c9RrVixrHDOjL22vFQjugM910M6ROg6ArQ8yOXaX1NUEErYGvoG/KzDSNPpJNInxuIieAfX+F15z7zHuhymJ03sp3W1SBG9pl6Z6S0YD1W8Umn6AiCoUVJXgrp93XYTAFEkBvzEzuwAFS5V07m4AnPsnvGjE8scV2LMyuXypcOwYUGLHlPbQ0lSgg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=pN6N0TVrLEpSMt01MGTsAcI9jPTC6JhWv2CPo4RXeoY=; b=CAmka89R89NE+nEkfV5Ypvo14k7pWCKMEIS3/kp7KuG2rrFHtyJdR7vM1Ca0JTiALgHpiqYsvkT5nOCH7ZE3n3CmsuAPzlIyRLeglOYdiijS1vU4UZhhR2uwwmugdpDNNxeb2/xAJ5VwuOQ81cv6u+6OXnrZzn2jQpeuN9h4mPyRhKu2Uv8zFNEJcPmExsBrRsN9ZNpXhDiAgqSmIjS5hpjqmFMtr3tSjOKkjVbIS2cxxgVC2er0iKd3Yp1cNtuqOhgJ7h1OYpXP+VtGfMHd1vJ8HkkhY0Z7zU1RAe0ACEIx/uwp2q568xIwS1yay9thNFMOvH839ur1FPBoROSkIw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=mt.com; dmarc=pass action=none header.from=mt.com; dkim=pass header.d=mt.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mt.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=pN6N0TVrLEpSMt01MGTsAcI9jPTC6JhWv2CPo4RXeoY=; b=eH3bA9BNvOc2IU3O5zmu51J4CyhGuYSQH2fi1UKFA8KkBehk+PUdcZvM/rCWJNqZq3CnmeA1debB0OmdS+AVv7+1hgiJm17z5GCHMfg8JpythvDm5VuyLDODv2sTjRbmUsAJltQhuwJ0j0tReLInB8Z/fYv9dxt1SWZFIhlu5hkxYSS8A+kXSyx9xplwHQDUqXC/+N4TCR/E7sjkOF4BxS58XhkUsqI0tlKt7O7nAcUsi3AV1oBsDKm0Oq8SrifVByWScyuyGqO8GadGTqTnmmn+RXSXHeih9VzUnPH2ChwFrm1wzh/F30qwzYuViPCNg6eHsOVhd74eeo5u0lL4uA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=mt.com; Received: from DBBPR03MB10396.eurprd03.prod.outlook.com (2603:10a6:10:53a::11) by AM9PR03MB7266.eurprd03.prod.outlook.com (2603:10a6:20b:261::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8511.17; Wed, 5 Mar 2025 10:15:25 +0000 Received: from DBBPR03MB10396.eurprd03.prod.outlook.com ([fe80::ee3c:c9be:681:c0bf]) by DBBPR03MB10396.eurprd03.prod.outlook.com ([fe80::ee3c:c9be:681:c0bf%7]) with mapi id 15.20.8511.015; Wed, 5 Mar 2025 10:15:25 +0000 From: Mathis Foerst To: linux-kernel@vger.kernel.org Cc: Mathis Foerst , Laurent Pinchart , Mauro Carvalho Chehab , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Sakari Ailus , linux-media@vger.kernel.org, devicetree@vger.kernel.org, manuel.traut@mt.com, mathis.foerst@zuehlke.com Subject: [PATCH v3 1/6] media: dt-bindings: mt9m114: Add onnn,slew-rate DT-binding Date: Wed, 5 Mar 2025 11:14:48 +0100 Message-Id: <20250305101453.708270-2-mathis.foerst@mt.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20250305101453.708270-1-mathis.foerst@mt.com> References: <20250305101453.708270-1-mathis.foerst@mt.com> X-ClientProxiedBy: ZR0P278CA0037.CHEP278.PROD.OUTLOOK.COM (2603:10a6:910:1d::6) To GV1PR03MB10412.eurprd03.prod.outlook.com (2603:10a6:150:16a::18) Precedence: bulk X-Mailing-List: linux-media@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DBBPR03MB10396:EE_|AM9PR03MB7266:EE_ X-MS-Office365-Filtering-Correlation-Id: 21614152-a131-4484-d91d-08dd5bcea4cf X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|366016|1800799024|376014|7416014|52116014|38350700014; X-Microsoft-Antispam-Message-Info: l45kGlkzZdpwrpsAPHrEE81cNh1AYjigTJhClMBhQroVH+Zu8yHKIkFL1vlCZxgVIFEtSyJPmi5Sw4LHMdM+nE2tkZLMx2pvE/2UOVZIbixpsXnVHvR8lBmldMI/Z5HM+BeTx5oNsRW6qnuuPLtHR7cdHvhKi8z9ovomBfPCW354eZ9/bJ9gmPe9B+ePP1QzYZ1duEjSHcfVOSzHDFpDLQ/c/TWswzoFn3+P1sqnAoVOCb01EabNkyR3o/1f/yU5HlTHxuxNmPnbnM9whlwHl2C/ulTi8QXdbzEpV6YHA0en21gV1n6lFJgZeIkW/D9DkmbMQ9+dh0a/x0oEm+PFFI9jyb0p8CANHAEL7pE7exyKkM3u6TUXsIX/tPy7ub0ErcAXxsC0jm5bJLpAP/tdM8X4wsJev/e8o7eGAhzs+EdKt1ndDd/W+0Z/FTYZt8fajd0xfC0mCRKA76vRtnuNMbjwExUBBprjvrQBt1aaf6qj1o7aryLNRb7+aLreu8eN3RHosUV/DVtBsCjmfLI4fpF0MEjEVfCi2Fa7WTZCZuT4RGhxNV5HV2QrNJZij/SeZhMFRNlJGizUpAlrQ4Q0HzljoixL+jk0FLMo5AyxwzsKZksDjV1DNmIssu3YMCr6aPsHNy1E9fmZBGMYqevNKN4Qx8XgGCPgyyE+UyrtC/xIij/NjqB5xydbVnzXZLk6FhlsWULAhOyXu1E0kuuBjf2bWIllTs+sqoQA1fceYGRpLWTgI23UrdcOEzW+Zm53BRCx8ApsEC+tZqJZVM8xGtQml1aweT+miIQ8xtR/R3ysFEiSmpZVH2qxzH6WOf0HbUb2OTRi929aDlavzvPwTTsET8/LTFut/e9UzPzzlTVD+2MX9oFexVIg9SAAS+Ftwx5l+d3shV75ZWQpxZD83yJSKXW/Ll1nMbMF5EFBh6vbS9hfMOXmpeHB+EA1ztodryBnAs/f6uoyTYh0/QzfAcHobIbxJTyhcQp+VElUgJ+xvaPgpgZ9HJQDVHvaDmTx3lRd1qeiJLBbruZBEfuxcKKU7RJ+OOHaVJT9i/p1Uwi29Unz2UNlBMm4ItYmP21O+LEn2HK6f/IovV2horhv1CmO8BQV1I+LLyIIBqxouIKtTFxryTNQZdXa5sX+NOxv5OY9tKGAQu2u0qmSCO6tZI9ISigH7j4apn3YHhh4J0Kqteq3Q7gJu4hKPi93MjXiRgB+fxDeSPxLUXKw9X7PRMBmnQdIpWdSN8xD03kJkVcPTrinWU8JsKLh2q4yWTPCU1dLnsdSOCm30hH70V/Q/+K49O6+Lmk4GvY7DGFFt9g4ybbTzaY2V736Hv0KW5/R+J7tsS7oGLgAxMz/IEfjRQ8pb2oCwm07qlB8sCczIHpwIMEmytAVMPymAuDwxpHHtlKqHDCkj0bxFNh4YMChvphbcvb2mKGsTkZPNO50gyJTnQ+wV6XKi2+Hy6v5EMd/ X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DBBPR03MB10396.eurprd03.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(366016)(1800799024)(376014)(7416014)(52116014)(38350700014); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: yDahtqhnhOBvRv2Io4kWQdciD14AIbTIpSqkG7qzFfdFpqELRMh7B65YK1P3Wj6/qqqtPOnrG57iTneAHYOskfCu8/Koz+nYUcj7pd0mdJN67XUMcHeMjWHMSjMtUio2SEWVC4wOAlZ/1Qg/agQ4hoZHQ8D/WpglCpMLVbvLmkFxqEI31UcgmWEhmigFGSJZ36UWnElfbGMfUleLuE4URbwNflowWE4mXVTFOYEAfeUqTanIcdCqnoCBfIaCHeVnbcYYro3HmW4bB7Iyf5lTaYa6p5Rt2Fe38EwCi82mXjE5VSRok/5YXC+gANJYUbL0AI4DSXGsTyna2y6xqCdh3ifbu/FgQlDmwvaX0qZfKAacHm7bMDeimIs0wSFGOPK7nakCjLoK505VqAtIbKyRhF6gIKHtPtkGpWerB2gHNZLuqfsf6+yMcP6OWzcKHtFspkEN/9nDyKndQiTuErDIIEP70Ry8hHV8VebOXp8TWQmZYjVWBHCsgMidm/LIjrbCpN77RDd+k7WvE6hnGXjkPXO+qBl4fbjT6uX/sF7AIZRs7MmGYBPpLKecRAdZNc7drqYwuTUOEywkjgJL52UPJEeWTZj5c9ReuRqRcG2jbPboGjIsnj1tbPCu2a61iG3wBZtV7QilLTXifb3m9UEceorh3T8URnNngFHu86JMTp26ZTbAMXJYgc/vSkn+QC3Mq8/IGYvrR8sqWnL7Q622y+NgMYgDiPBAKWZkSiB3+mkxy9TS/VRj5MQd3L4L+Cf+nUGq1UYDWLedRsIsjpeSTt4sU7O3iLTX+BA9B7wtt6saEN42G9HupNYTQMXIMJUTKfpNO0MqZcApgowo3d6xCVnnnBCgzuufx0b286ppGhQp6/l2093Wqw5GtQpLhZtuxlHBbtA0MSRv6jSsoLJR4DsBqeE5Y20GS9pVG2RPcvw3GrTUJww53FQ3esFr98GWFmQbP28hjslK0bVjmT8e4uv2ZitLtCbbgqZWNjU8UVB2EOs/fy7N5VKx6F7kEOprB+jQE5YaDVW6/mgxDOJdjWxdureVzi5WKkA0ZqElnNIdRFSF0S6KfXqf3/Ti2iEj0I1di//RM/MGF901S1TrSSUJKgvD5qUvTbz3aS7X45vETtowMH86OewhJvPwANbST+imGLT7M1l7RigqVG1U0Q3lEU+lsxVBVMHuy4xZvZUJ3Rz4Sora4Lm0meVQ1nNwWeRtXfu9WiLh2qttpnA78BUOoFBXHDqBriCULMBpY4324H0nKwKb8PYENm055w0KYZ4X5AAvC3oPUNSQt2lmeoNKfUN5YfoAm9PQXqO2Ny7f5SDAMQxRKPEzyrTklg1drITH6BGoeLXfp2Rd3y2REFNklLSzhQs/PiG7gInaHis9Vy6M7bCjwteuG+cHEvdncMmdadKXxbvFHhYx8FLoKF1e9/BF3CCSAlCZGF/zxFePqD7cdrzA4HGrrJZU+t6FygHYYKyac42XDqUw7DQlplf7KI2AC/g3bn74bHf1gafWbvEa8RG6otCwtr1osGydPeXLhEeUfwMMSAyySnRTnEcnPAYNLWgaaLvBWYh4ozHs1Bp0gTwBd0P/XB87md2X X-OriginatorOrg: mt.com X-MS-Exchange-CrossTenant-Network-Message-Id: 21614152-a131-4484-d91d-08dd5bcea4cf X-MS-Exchange-CrossTenant-AuthSource: GV1PR03MB10412.eurprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Mar 2025 10:15:25.4209 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: fb4c0aee-6cd2-482f-a1a5-717e7c02496b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: nMMvO3AKw4mTqlAWK0axZn2sEJUsSRnUd6/n1s3miu5l3JajFcYQ9EefSxtQwY5Y2qOlVp2pqrSDlCb92SpwGw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR03MB7266 The MT9M114 supports the different slew rates (0 to 7) on the output pads. At the moment, this is hardcoded to 7 (the fastest rate). The user might want to change this values due to EMC requirements. Add the 'onnn,slew-rate' property to the MT9M114 DT-bindings for selecting the desired slew rate. Signed-off-by: Mathis Foerst --- .../devicetree/bindings/media/i2c/onnn,mt9m114.yaml | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/Documentation/devicetree/bindings/media/i2c/onnn,mt9m114.yaml b/Documentation/devicetree/bindings/media/i2c/onnn,mt9m114.yaml index f6b87892068a..c184bc04b743 100644 --- a/Documentation/devicetree/bindings/media/i2c/onnn,mt9m114.yaml +++ b/Documentation/devicetree/bindings/media/i2c/onnn,mt9m114.yaml @@ -70,6 +70,15 @@ properties: - bus-type - link-frequencies + onnn,slew-rate: + $ref: /schemas/types.yaml#/definitions/uint32 + description: + Slew rate ot the output pads DOUT[7:0], LINE_VALID, FRAME_VALID and + PIXCLK. Higher values imply steeper voltage-flanks on the pads. + minimum: 0 + maximum: 7 + default: 7 + required: - compatible - reg From patchwork Wed Mar 5 10:14:50 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mathis Foerst X-Patchwork-Id: 870704 Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05on2088.outbound.protection.outlook.com [40.107.22.88]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4B80E206F1B; Wed, 5 Mar 2025 10:15:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.22.88 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741169750; cv=fail; b=W366Ofm5DJr8C0JkaOJiCBLP6L9TY2c2wnbhGFj89pBCKN/F+8s6LdWJ69xLDD+1+4qYMPO54bRW/Tn4Qi6xnA3x6BGiR1jjrZ+pdkqoCJnWFWu4Pq+kSwg8utrQOpZJxKqvadkS+5BK+V4vbjT0IQhNBEKsGFvPZVb0fBNRD8s= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741169750; c=relaxed/simple; bh=HYwjPouo5PqXlBaVkKr2PMe8LuxOydElL1w+AICaYqM=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: Content-Type:MIME-Version; b=j8mu7/CPjajZH25LMz34pHQBrcbpM+BwGWxreGcuFZyfjv5MvZTu1SXkjhpgkivaRxu1y2xwkuSSvR1sGCI54Gr3gpPcMAcKEAiihW08q+XtQPWWLVHIQzGy1XkafJb4s64Us1mr838kuzRaRHA9I9gwemq86WgZOqvX5fTlUmw= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=mt.com; spf=pass smtp.mailfrom=mt.com; dkim=pass (2048-bit key) header.d=mt.com header.i=@mt.com header.b=sJUcAkLb; arc=fail smtp.client-ip=40.107.22.88 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=mt.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=mt.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=mt.com header.i=@mt.com header.b="sJUcAkLb" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=xbPnlK+766Cyn7beXwu759RhlHN9PXZeFNI2EyoQB1JjzcFKSbFvKUm7XZHJushfyUMTSjLWaiQE8U8DLRShgR8ozqBBqOPQfasYWQ7B46eAmLrEovQki+P2uOzlDoJfqu1Vf0fmrMsX0UGg4J01dhF7echs8jJhgpPmxNmVg2YmptBvl/zip0OzSUWno3CP9NqTnMhooeZxGyOAXlUYPvaXJk4ZjFt4hk8ixjLUhp/4RgJJSF5rDbR+ZJAsiKWDrO1Wy4mS6nYqcEw6ls4pWY45o1Wdi4ZI3c1U0aEHvYjscE8VfksEvdhWgi1aTCndLXjs7TmN4iR22g/AAMQyFw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Kor3lTNIKR1gra6DwDrdViuy7QPKz38qsXiT/yG3VRQ=; b=Y8WjeTf3Q5Zg53HrSGV5PvQHTDJVfaWMi08CgovL9zDr+kq2JrVxD5Ti+79TZZBL4SrFZM71MXyXk50fomZiJuPGbJ3cohKpoIKGXjBV9zMX4PVhnZDlvmXrZFG0AmRFHwErv4ak4dOIfZ6SLOMawpp84Fbd5jhxJbFSBBri559rggajhLGpL68p2iwus6lY0aB55AsyBNCWYKl5F0fUADlZuCLSFaevOwbJgakacgLGqNl0b7rvulw70MSyGEmMupwvXe6Q9LHMj018BP6WjvPIXYaMkL9CCnfZjulPCP5481TBiizRqmKkqUF2BmNV5qJfKFaFWI1ruatAyYJ/Eg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=mt.com; dmarc=pass action=none header.from=mt.com; dkim=pass header.d=mt.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mt.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Kor3lTNIKR1gra6DwDrdViuy7QPKz38qsXiT/yG3VRQ=; b=sJUcAkLbbq7XFQHfJDRb9XjL5DQMATtoO7R4PsKMWpNA3kqJ2/JLb+KLdCIBlSF+nvKeNY80MM1AL80m7YqM4s2YT5OQNad6ny53B4PdxeIId5tWRUWOnXyBcO4M0JV3YHq5ZotrWJHtQMqcqI1AleRsv0NgwxyjvvNJJ4AnpsxanrAI3rN0dFkYh3kPXPu5rBckb0lI4ySIRSaLNhmyOG6UlrqEuQfAKMsGj+m5aniCvka/pQDqAlQA0HlQT98Hvzp2TV2pb4HeJagqqO3mNvv5LGb/x9iODpsHCXMk6/pkmQUH4nvA+LyKyGQ8Ru60IHgCRUxG6JbB8lS7IKMxKw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=mt.com; Received: from DBBPR03MB10396.eurprd03.prod.outlook.com (2603:10a6:10:53a::11) by AM9PR03MB7266.eurprd03.prod.outlook.com (2603:10a6:20b:261::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8511.17; Wed, 5 Mar 2025 10:15:45 +0000 Received: from DBBPR03MB10396.eurprd03.prod.outlook.com ([fe80::ee3c:c9be:681:c0bf]) by DBBPR03MB10396.eurprd03.prod.outlook.com ([fe80::ee3c:c9be:681:c0bf%7]) with mapi id 15.20.8511.015; Wed, 5 Mar 2025 10:15:45 +0000 From: Mathis Foerst To: linux-kernel@vger.kernel.org Cc: Mathis Foerst , Laurent Pinchart , Mauro Carvalho Chehab , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Sakari Ailus , linux-media@vger.kernel.org, devicetree@vger.kernel.org, manuel.traut@mt.com, mathis.foerst@zuehlke.com Subject: [PATCH v3 3/6] media: mt9m114: Factor out mt9m114_configure_pa Date: Wed, 5 Mar 2025 11:14:50 +0100 Message-Id: <20250305101453.708270-4-mathis.foerst@mt.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20250305101453.708270-1-mathis.foerst@mt.com> References: <20250305101453.708270-1-mathis.foerst@mt.com> X-ClientProxiedBy: ZR0P278CA0013.CHEP278.PROD.OUTLOOK.COM (2603:10a6:910:16::23) To DBBPR03MB10396.eurprd03.prod.outlook.com (2603:10a6:10:53a::11) Precedence: bulk X-Mailing-List: linux-media@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DBBPR03MB10396:EE_|AM9PR03MB7266:EE_ X-MS-Office365-Filtering-Correlation-Id: b82e36d0-7bf8-4b6d-c8b3-08dd5bceb10b X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|366016|1800799024|376014|7416014|52116014|38350700014; X-Microsoft-Antispam-Message-Info: V/9tdXObp8bWQpjKagV0+tReZIcITw1Pw0UuOzF74TEZ8oxiQmd3Qk6qJFvZ5eBz6FANs+P/++nGCLDrA8pjR3Wbp5ZjqlDF1eZC68YoddeYSP2iOBt6+YBk6HQPx4xevTXT6Ru4V1FA5vUueJKTjk09DQgdEjf5I6eWn40KkYOgyqTuKzsK6ypyfYt7mIeZyZLjTQQUtKD2wmwfTm2oSmNCBRCTaeKrmMFZ8ISa+sYJJk96JXY3z7griWjMg6UVhAanhn6EwhoID8Mc/EJqDD5J8lhZYNQTlVkCbSEXK0k0Obbjw7sAgt3xDE3RAPk6EC9e5APxhNX18ruGeL0ZDA7Kd1f4EVNtlSXzEEikz1RgoHvTiiBzCrZYqN/AK2F6+trEf0oTAvmksRXSU9n5ZTVtaEuXjgvdkt8SeaCy0R2x8t8e8ay1EMvtVn7sLO8yK7mMZrGXeY2HzO+3XjQN+Z1wgQj+oZ0ouMEyM6+quVPyGhSdYUi/xRpdW3VSt9lNREJKRGCeOTQfEL/fmbw0wIecfwVlXOBfTAtpsKW1FN6mqFuDeCtcqKlMbETFOEEvpZov68gr/hFPjoVlZufmOkTmC24ummxzm2x+RZoVsZcEm9NiHtzkntn/7SU949HXyeWKEo198WDbPahXIz8uGc2ZWoNn0Y45XKEksWMmz2qa9tMn0Qd+yUaGsLnggRkJTFBzJ2EARtLWQjuM7Ek4kwvLGMBO7ZK7G+h2G9j4eqKzES9XAzgPkO/bG2tFw8rFY82rLMbOecnrCzRM4Z0ihmPYJX9xnqFFhWwOU3G+mV6h1QJP7bL9aYOe1FPSiM/zD7nr1xrfdqjBmcR72gkSMnO8HiNJghU31/q1yq5C2SS22r1uGJWBKpBfZw679aj+A3rNBILxMDj4klz1id3Udb6IJukOe6bpSY3FtwuYuNd6kRwti4O6mTIbHtpVvam4iIPsv84OQcs6ZOwUK0fLEgrhiYjiWJxY42A8a/TmL6ZEsBFtXwdpkzf3c65Wn6NZ46qUBIJrrgwyPoXwA17AD4pAN/ydi6fsr1vo58s+JpF6jDOFLP8yYd1iBl2iwHrN0IjBQNHl9EVy99YI8xvUFR7YO9V3P8EvUxuydxpipmBCCmiZJsFj3L2TMjXdY92jiWkWkCvE3Znhurz5TYcOloMcgtfHhgfhdPfgrly7kP7mHmb4O1pcJBjrb9I4UlGXWQyVQ1WI5OMDyLTMOS5CJ/kS1JkbKTqHjnZSF0wtqIAJhoEJFJibtsAIzaR7bBD7v0pGH3FPRYyoLUCUFO8FcDg0vwvp3EYmATsEe4PLdqSm9OLRTQtyA09ATqahxh1IYX3stT5AUp0Z/matxBwsoyhyC43Rf3Tnr86npiPXbJbsF9ir3f4GgkSvRbq7mNwPEpKWjUn/nNCqATjNeGtV7WGos/75rXpx6QBsLt7S2cBtyQBrkdTTLUwL8KarRKA9 X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DBBPR03MB10396.eurprd03.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(366016)(1800799024)(376014)(7416014)(52116014)(38350700014); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: P77Xo2zmdOaWZwhLsnYcyFIhiLjw+7PLLap1TmjzkXwTx+feBSD5l7ZdOUR/RXJVmlolSXoG0Lh2VAE6B2Wct+msVlLTB4xwxkhlW6tvXeja6i76LypIc+iNVtDEMl8nXhAJ4MN06M1O2WoOgsBuQg2QfD124Xwl/3jmgtW3x/j/+LuRGF4Ov+ct9Zx5oMFo4XeuMuV0tT39ESA7sGAbrytesXijbjsiBef7CL+K3g5SNZfnqXyBEapM3iShDqaQZxv05lXjftZJ6kRW/IgPb9lbg2FfQ5oORuIGmU/QHh5ST93h357mqvEGiwjKXnj0rJZt9eZ53AOQy25lyxxjL4/JzL5atvWW3b5EcpoP7jtyFZyUufs7UIMX/6awcl0po2rWaTRg8uQ3a5uJOGD8ADJ/ug4xmUoir0KDxSi0mtCdZ95xB07YazbrNG69ZClFRn7gWcA08x214QyOjDjirkdXBiJgWCaBxz7WxXr16BUiMlHkz3gdilg9OVOdRvl3iBgobs/oKb0OXif7vDpTEnhwDefNo+b18BvZVwU63rqYXjFpS8egtwFLN8OPY2puP8B11UO3jcb/S+cKypQDJmAqDhw4fBX49HbZ2ku4SOUqZbZ1Z/zULJEgzOOZSx6VsDJrRZ5Ote1/FoOorn7z3HFQe+EYcVWvugmlB+6ApezZKdX8eYkl00DPlD0EiJcJpOMSxQXHikvrJmxzQbPS9fXScZhS9XAxnMCuncEi0yhGzPuv1VSQJhRrZLerCfgziNMjaii0q6IKLf2S8trGoR45FniYMWpg7gKZJt0hrwKTDYpRBYOEDqjRqc9TTNN70jzj4hE+VPSkqRPIiUqhi6CF/4vvYwSMKW6yiz4B9elzLARpmNzmI/ibcEYDWv4MxrTHGKEgF0oplj+eNLknUqJd9mDdeooiUsrn4WV9nCBs++nDZfRbgj1yZ00AK0hDGIo0RzBCKx70yeloqu3NhCob5FKLGHWf2Htw0swMFyMATfVD6MJPjdheTtSh6CeBbdq8trdCGYt3/peF8UjzBNJKsGfWXVYOs65kPXtsQZWUmNJdRgCVxiKCdG3umTEcoXpIpMzSQRGJDqLsrx7u3aaTK1VOXB+Ou6/zUHHKrOgVF9aKBK1hi1ZMI/sw+AIhYjbzMCxllgvchmTxVuJoabSfffzQzrBwqKZIq/RLjhVogoeH64A0C4xw6b6qBG0WQ7mXxb4Kjh4wOWLsNAnOcWp18qKgb0ZA29AdFySY1ki66ACN101SH56+yvBaNYlq62ozmqAkpmIWd1KPHvpBqeCZ4X6WWiFgYKEyH9uDQ/j4bDr5VMVlosirc3A7GnPQyz/4Uv7CekNs+P3kyiu+9oLKZCMqs6/dPUCWmUDgrLMAJnj/F4f0V03TMgo6g1z1DMY+TJ0qLE6NbnvN1YHkZmltInMR0/7+lJT9i0TmHGJ0FigWPfwigGRkXngFZEAn2PAvjQw7+D/dAJMWvrezFoOwj/MXUTUWHJY1ZS4bJmUA3cvo+rXsrcUrOS7GlEQ1b+dbFL+Usom3NrTN9bPrGRUOYsi9x1g6kdyjeYondnGYIbT2RZ2dI+7PWHTE8TiI X-OriginatorOrg: mt.com X-MS-Exchange-CrossTenant-Network-Message-Id: b82e36d0-7bf8-4b6d-c8b3-08dd5bceb10b X-MS-Exchange-CrossTenant-AuthSource: DBBPR03MB10396.eurprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Mar 2025 10:15:44.9753 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: fb4c0aee-6cd2-482f-a1a5-717e7c02496b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: AhKybMYkJQ2em+0yNjWOullYKKpDtJ0VMiZevLryYYXRd3HXOhlElG+yhI0NuBVyxzuzvZ6yhBIZ/YW2QpkQ9Q== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR03MB7266 The function mt9m114_configure writes the configuration registers of both, the pixel array (pa) and the image flow processor (ifp). This is undesirable if only the config of the pa should be changed without affecting the ifp. Factor out the function mt9m114_configure_pa() that just writes the pa-configuration. Signed-off-by: Mathis Foerst --- drivers/media/i2c/mt9m114.c | 49 +++++++++++++++++++++++-------------- 1 file changed, 30 insertions(+), 19 deletions(-) diff --git a/drivers/media/i2c/mt9m114.c b/drivers/media/i2c/mt9m114.c index b06003b69f6f..9a49dab65180 100644 --- a/drivers/media/i2c/mt9m114.c +++ b/drivers/media/i2c/mt9m114.c @@ -789,39 +789,22 @@ static int mt9m114_initialize(struct mt9m114 *sensor) return 0; } -static int mt9m114_configure(struct mt9m114 *sensor, - struct v4l2_subdev_state *pa_state, - struct v4l2_subdev_state *ifp_state) +static int mt9m114_configure_pa(struct mt9m114 *sensor, struct v4l2_subdev_state *pa_state) { const struct v4l2_mbus_framefmt *pa_format; const struct v4l2_rect *pa_crop; - const struct mt9m114_format_info *ifp_info; - const struct v4l2_mbus_framefmt *ifp_format; - const struct v4l2_rect *ifp_crop; - const struct v4l2_rect *ifp_compose; - unsigned int hratio, vratio; - u64 output_format; u64 read_mode; + unsigned int hratio, vratio; int ret = 0; pa_format = v4l2_subdev_state_get_format(pa_state, 0); pa_crop = v4l2_subdev_state_get_crop(pa_state, 0); - ifp_format = v4l2_subdev_state_get_format(ifp_state, 1); - ifp_info = mt9m114_format_info(sensor, 1, ifp_format->code); - ifp_crop = v4l2_subdev_state_get_crop(ifp_state, 0); - ifp_compose = v4l2_subdev_state_get_compose(ifp_state, 0); - ret = cci_read(sensor->regmap, MT9M114_CAM_SENSOR_CONTROL_READ_MODE, &read_mode, NULL); if (ret < 0) return ret; - ret = cci_read(sensor->regmap, MT9M114_CAM_OUTPUT_FORMAT, - &output_format, NULL); - if (ret < 0) - return ret; - hratio = pa_crop->width / pa_format->width; vratio = pa_crop->height / pa_format->height; @@ -853,6 +836,34 @@ static int mt9m114_configure(struct mt9m114 *sensor, cci_write(sensor->regmap, MT9M114_CAM_SENSOR_CONTROL_READ_MODE, read_mode, &ret); + return ret; +} + +static int mt9m114_configure(struct mt9m114 *sensor, + struct v4l2_subdev_state *pa_state, + struct v4l2_subdev_state *ifp_state) +{ + const struct mt9m114_format_info *ifp_info; + const struct v4l2_mbus_framefmt *ifp_format; + const struct v4l2_rect *ifp_crop; + const struct v4l2_rect *ifp_compose; + u64 output_format; + int ret = 0; + + ifp_format = v4l2_subdev_state_get_format(ifp_state, 1); + ifp_info = mt9m114_format_info(sensor, 1, ifp_format->code); + ifp_crop = v4l2_subdev_state_get_crop(ifp_state, 0); + ifp_compose = v4l2_subdev_state_get_compose(ifp_state, 0); + + ret = cci_read(sensor->regmap, MT9M114_CAM_OUTPUT_FORMAT, + &output_format, NULL); + if (ret < 0) + return ret; + + ret = mt9m114_configure_pa(sensor, pa_state); + if (ret < 0) + return ret; + /* * Color pipeline (IFP) cropping and scaling. Subtract 4 from the left * and top coordinates to compensate for the lines and columns removed From patchwork Wed Mar 5 10:14:52 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mathis Foerst X-Patchwork-Id: 870703 Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05on2050.outbound.protection.outlook.com [40.107.20.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E20D520766A; Wed, 5 Mar 2025 10:16:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.20.50 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741169767; cv=fail; b=dh0g0o7ahu3VzqF09S55ujnKZ3JsM9cnpjWwSbCEMRxDjW/o3bXWoQbaNH2iqb7JocGqmizrvfu3YiGi6X22gt5zJ0R/xTV28w6kXSbf6jZDas5RVLWRh845ArmzFw7dglR0kZFY5oJQgLt7CtJaZQwYRmRwdrSf69lgCOUe8N4= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741169767; c=relaxed/simple; bh=Dkr+pAnHom+1qnjfXIntxIyeinqj6BxatODxq71cc6A=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: Content-Type:MIME-Version; b=d6b1gv2VOdivYzzy7z9WkZERWSxejwuGA9hBAL/bCW866msWXKT6dpMgreACPVxllHtmMoaHaIhBLXA+Y7GZSlPtib+WpjwgTyah1Aphzh7IDoFifXoHoox7IwDkCZDn5U/S9m4omKFiUWNoyG7MX/4YhBFZUaRFq+3R60R4b8o= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=mt.com; spf=pass smtp.mailfrom=mt.com; dkim=pass (2048-bit key) header.d=mt.com header.i=@mt.com header.b=uc9H8QI1; arc=fail smtp.client-ip=40.107.20.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=mt.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=mt.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=mt.com header.i=@mt.com header.b="uc9H8QI1" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=X4Q0T7S52XoWxnof10gzXIIql7TfL5V6Gu6lh4WypkUJ0kPd/EzNQ/FcmJhveTIxelBI+IUGTFOhR1Kn/ejTpaNBkq34u7MGR8Ug7dSGrNs66zKphoOSaoSNrRa63Gx2ov9XmoD/U0up3sPTnqIhPVqoy6sKt2Tm2h6BXviHV0MZ+3+OBlSfKrpwJL5UchZFwkZaONqpcQXcIt6gA2YNUjCtFwfU/SycUpFohOBSWMrstw5edwMwHIty8e5wAklXJY2avfZWQjCHj/J+WtMtGTTe2dAFL+UDNgMMmOR3rak4ozGg/TAVIhbB722hqgA/OUlVpU5gjLGpZX8D0H39rg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=xBj7Rt7rd2WVhxT4Ohiz7RBupOnBbZRC2Aazq7L+16E=; b=tfQyIQ+djqt3oMwubPFvL/T7z+YX44+pWtAEvT0uvQjEGTPs7gak1lfvsUgwXMePapdzSHs8WjWmbDBtcgMqbRnKo507YAFNa+EpO3jpnZu4PQRIK6fPohzQj1oZ1+D5ZT0JpaZDxIawPXe85/U1m9gsu0jF2JauBexz0gfzbKfp0atlIGHo+WSht3hKGRk8GthDtYb1YtFutW7EXMzNY36MUDnbPFsIbiDUV/X+RbN72LHt1ofbMsARMgyqM1OlnoWo9yMU/QJHlWSG0Tbm+fGhIlJGTVkVaQpU7ekWFcr1GNV54fHCxbk2sv3utVQSXU6alifomIlmVXOPUD0NZQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=mt.com; dmarc=pass action=none header.from=mt.com; dkim=pass header.d=mt.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mt.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=xBj7Rt7rd2WVhxT4Ohiz7RBupOnBbZRC2Aazq7L+16E=; b=uc9H8QI1PYS8IgBhl/icEMiXHJMpc1acU+kAJkShL5aFRSiE4XJu8aM+/9ia36yfZlJaFaUFm4hjBzWyBfZkAvQPXUkx6ZetRhS8v9ju2qMFk18ycVR5KsYF9vCn1I9tJFN2hePXL+6adudmOxcI4oU6pcDwIo9P1sy8SnIuVvqVt6Vun8P0kBHzLjYtKEB6jTV72vJ9gG4ScUVBvyS7HULMPCeetcjfNVi5x7u3nLx6if1eH6Ugaauo4rr+GbzDiSXYlv6WXSgYSnsMxNRDzvBj0haEP/v9Ly9YqtT2KBNfX+tZAjAnDeiUkWV8Bc7YIf9/7xxV79XOvtCFTihPTw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=mt.com; Received: from DBBPR03MB10396.eurprd03.prod.outlook.com (2603:10a6:10:53a::11) by AM9PR03MB7266.eurprd03.prod.outlook.com (2603:10a6:20b:261::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8511.17; Wed, 5 Mar 2025 10:16:03 +0000 Received: from DBBPR03MB10396.eurprd03.prod.outlook.com ([fe80::ee3c:c9be:681:c0bf]) by DBBPR03MB10396.eurprd03.prod.outlook.com ([fe80::ee3c:c9be:681:c0bf%7]) with mapi id 15.20.8511.015; Wed, 5 Mar 2025 10:16:03 +0000 From: Mathis Foerst To: linux-kernel@vger.kernel.org Cc: Mathis Foerst , Laurent Pinchart , Mauro Carvalho Chehab , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Sakari Ailus , linux-media@vger.kernel.org, devicetree@vger.kernel.org, manuel.traut@mt.com, mathis.foerst@zuehlke.com, stable@vger.kernel.org Subject: [PATCH v3 5/6] media: mt9m114: Fix deadlock in get_frame_interval/set_frame_interval Date: Wed, 5 Mar 2025 11:14:52 +0100 Message-Id: <20250305101453.708270-6-mathis.foerst@mt.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20250305101453.708270-1-mathis.foerst@mt.com> References: <20250305101453.708270-1-mathis.foerst@mt.com> X-ClientProxiedBy: ZR2P278CA0002.CHEP278.PROD.OUTLOOK.COM (2603:10a6:910:50::7) To DBBPR03MB10396.eurprd03.prod.outlook.com (2603:10a6:10:53a::11) Precedence: bulk X-Mailing-List: linux-media@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DBBPR03MB10396:EE_|AM9PR03MB7266:EE_ X-MS-Office365-Filtering-Correlation-Id: ccd20a50-224e-43d3-b7f6-08dd5bcebbf8 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|366016|1800799024|376014|7416014|52116014|38350700014; X-Microsoft-Antispam-Message-Info: dDua4JKZmObYEIAK1LZwHkKp0AT68HhgUBsfmoroRPmOvkg2g3ATE80WFaDKp+ef3yp8M4VJoTGNh96MdzwWAD7vS/dGWNHKm89jByvtgmx1Mtj+jwyUWxpie5sEIaQ1LVI4cz1JDLuVgNYSyFzOealIZA50otIXmJPvTcAq70fq9P9b4fEpW/AzTd54q0dv0j4W//aT5IxA3iPVXIiMCsYTF1DP4M7hXHi0wi2Xn++nSd97qnZf4xdUKLtyHccbsVYmFkG3RP4MfjvGKHbBGi+Pj2Ggu0f/OidHdwlljkTmBXupQiJmQ7YlqnWqgdYmhmXwr2ATifSbkeaoRYKPCEq4QJvOHi26J2n/NH8rSZUY1nbiZ5wXUVK3T0gULTe/zm6RkW2I4g24mCvYbcCQ2RPHam0yiMJu5iqmaTHXQzgPxsb0zcU8hzWJ/68Dv6Co9aLpPq1okSHFAFB2O/92WnKRTTJoRv7GBx2EcV+b9A1h3LdNqONtpu2FytJM8oM1Pb1RKHKOALY3Kp1QTs8GxF4UhtrtecyfNHaYJLSUPyfOAS9Ti+Je/dRV9LcvqctMaEANFdZDhrGxOaLBOOQQ5LWr0bFj7Tp4UcgaOM52ZODQUd+T7/9NyKojDKUsiODvRKuwEJ5D6XXfwYGiNN9sAwgZmVsILYPQiE3XqsciNgPt3BKQJElO+W0C5U6PWLGfmTTx2lzGunIMo9wauC1YLl/WaXzKrQKoA2j62robAtNVuwjfQRqdXuunMJzNPSeC3KscryeQLv4WgZ5UCCxNjA9RbN5oH7D2kh855mNJJ68fv1i3FgizapSa50fmrcqekx5vm3IetTeiUwylB1HH4QVdmX7pB9C9hyn5Br+lLmiX53cHlPSUqq/UrIKKtb047WoiKgzGWDUKc8D1DPYTq8Oz1pLj4GCThOJJYdB7X8ajIiiqbNsvW9XMkbAshqPIbAqFiVGizE6BX1V94RXDSACY/myosxQFAEb1vGbYPtfebUDYhY/SNeLY9geAAs8kJ7fnUCoZWAt0Y9Tr9r1h55YcohyyVQAPoW4sXb/yMJsMYjiY09/JIwDI13QraB3dD7M2bJo7pUYsOhZt3pzt35Pt72uP5CR9IoJ5USjL3gx4JinZcn3DlyA2TC88wQlSiPjxcVET+xFxi5SXvYgWNMWN4YVpp0lAnYm2UkNh53tz/rtSfnw+eppJNv198c6465ZzLe+Un6GP1gGejjYr72MVkjM/lYPA+2r25paheTEjngmEVLqqHSx73ZoT6iBdtxX+/wg4h+pNRS9TvDRyH9XnbGKB1pPQsumqo1Lm1ZG0TYixAORhYDKsr5hbYaaAz1x0SZfHrNm0/Q7gpXTAzG1ifnyf4uhkzBYAYp65A9CHrUmH6wDWizMLJdAp+Rb3dtU0l31ThZCaFMSAvsgRzXAqRmDg10xSbywADeAQg+bdOh7dAegBEnNve/lwXXE2 X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DBBPR03MB10396.eurprd03.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(366016)(1800799024)(376014)(7416014)(52116014)(38350700014); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: /6ubdccQEFliGVxFKlq9R0rw+4OlckniOHnbnr2F/UCzSscewJQSEzwne9bZcgF/w4+tvCQKiHxcf0S2DkfU7+ZqZQNmpbxkIXAN6McXbE0itKU8KHAyV9Tqgv7MuquMV8uwcrChECBzT/4+vx5LZuoP3/s09KBIux20Xhg7aPaBCrKb0maR/0ONGLps0JzrA/C0VFcOKH8/bDgRldXZXrKxHQXiA2mVSP294gmlr3jZfZlMW8nSDqjskU0ip8lLL3w3LkN62OFfS/aVB4A6z+5aselq+wrZZdRfQw64eaQ9GvSCMFQQDxeP8r/IjAEKq/e0KA7QWGF/d21szTUrPjcKbhfrnFWZT93sZJ3RMpuorVyuiX47oE6sD/r0adF4Pp80YlYA0d5QnNOvg10sCpfgclqP4ZHWPzdA5EUWzxsd6QblVkFQUgWHMnUHTd0nfF4OOA+XSp5H06UhFtB1a5MNI8JSQwqsss3tJ3VBEV9CADyxCtmpABj06ZBGO20NMczWtRRb7tlgm4C6hvixtM2/7VGjdbHu3vnsLe9fR2kDAc+D/gy3nm0g/lZ2kJjMpsMjmpeQ8qBnyaA0NWFjkvuY8A++Aa7t7McE7pGmE2+JGKRtDTeMl1Ei81sMxqCsmSbyHmIYyJnSmurybtSzmHNo60rlnBgRq4BiAu7BOb/qfqa5ZHQ9LVDBv9jLTaS9KvLZ0BJbbjgDWCX4EMgXfXDa3GVY91asVA6K9AK7ucS0OrGO8BdEf1gXhAb0oG1gDD93Z84JLgCWSkQc/3NUlQDyDoTl75L2KUs357w2HUzAyyXoTlfJMJSfq728k4m/AMpL83vo8mcSVqvPw+u8KfwHheAGJUJpmthgqdVsFLFIcbiS2G93YZxWFYxL8ifol5hhW33dfzYejJ+3XL6dF7Sd1wVMXURtL3W+AhDtRut/PUjLrjSLBxHtbRM2UQS6Ohcj2LVZ2ievx5c/lG2vWt6DSziuAHVXETGkXqNuYOkOHTjanDIs+DeP2QZTfXH4hVB+7gIcqPkiFL4XDbRzz/jMMgZGPIKKlG870OAx+mRbX9Nr0+kqJ1fKwoidshUzHU2cBBjggqI/GSrk7FTAoM9d/70KmQR1Zre6BY9Qn99ZKgv1WgP5pXsvSZh+SVLuELA3TqDESZ1EQATjasVu1u9VCl0y0HNbxgZ6yKM3yKZYByvXuEyzsS3mlmFd85o5XgzEpf8RYRlx8Rrs+3X/pK+laCah/EWS8+Wtgpf30TVqNtQvnPFazwmsXaEslA1Roikw+OWc5dNltP1jCmcE6GUnINHZJNJ5vHsGXFK69Eh3j3jwHdZcHGg+XaLVvb3DLpN0a3NbnaPREOFGz70ohhCN7RF191V4zRAlRmxaB0yTG1srKRdshJ8dXijfkP8nJTyQvRCPQhiUaoqpl4yKqwZCekl4/YLMz8bjjw7drU2A2f3MEntzKPtXmSht/VgihD7Z0cCFLkivkLjAbL/uV+A88/CYgGVB1LA7SV3ge6xqjQvRBFgGudMiMBGgI5HDWUXEFFRND7IK6NLUIts59bMU7/NEvv6B7KndALmkTRCuMlym84VD88Kvbd7nb/o8 X-OriginatorOrg: mt.com X-MS-Exchange-CrossTenant-Network-Message-Id: ccd20a50-224e-43d3-b7f6-08dd5bcebbf8 X-MS-Exchange-CrossTenant-AuthSource: DBBPR03MB10396.eurprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Mar 2025 10:16:03.2974 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: fb4c0aee-6cd2-482f-a1a5-717e7c02496b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 2WZtqFICo/BYpD8P70Mm19LNdR48nyfUcbgPp1l8OzFq5KjITWDl+5VQ0D3EJH8Wn9fmgPKfy9vQlZseubNw7Q== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR03MB7266 Getting / Setting the frame interval using the V4L2 subdev pad ops get_frame_interval/set_frame_interval causes a deadlock, as the subdev state is locked in the [1] but also in the driver itself. In [2] it's described that the caller is responsible to acquire and release the lock in this case. Therefore, acquiring the lock in the driver is wrong. Remove the lock acquisitions/releases from mt9m114_ifp_get_frame_interval() and mt9m114_ifp_set_frame_interval(). [1] drivers/media/v4l2-core/v4l2-subdev.c - line 1129 [2] Documentation/driver-api/media/v4l2-subdev.rst Fixes: 24d756e914fc ("media: i2c: Add driver for onsemi MT9M114 camera sensor") Cc: stable@vger.kernel.org Signed-off-by: Mathis Foerst --- drivers/media/i2c/mt9m114.c | 8 -------- 1 file changed, 8 deletions(-) diff --git a/drivers/media/i2c/mt9m114.c b/drivers/media/i2c/mt9m114.c index 65b9124e464f..79c97ab19be9 100644 --- a/drivers/media/i2c/mt9m114.c +++ b/drivers/media/i2c/mt9m114.c @@ -1644,13 +1644,9 @@ static int mt9m114_ifp_get_frame_interval(struct v4l2_subdev *sd, if (interval->which != V4L2_SUBDEV_FORMAT_ACTIVE) return -EINVAL; - mutex_lock(sensor->ifp.hdl.lock); - ival->numerator = 1; ival->denominator = sensor->ifp.frame_rate; - mutex_unlock(sensor->ifp.hdl.lock); - return 0; } @@ -1669,8 +1665,6 @@ static int mt9m114_ifp_set_frame_interval(struct v4l2_subdev *sd, if (interval->which != V4L2_SUBDEV_FORMAT_ACTIVE) return -EINVAL; - mutex_lock(sensor->ifp.hdl.lock); - if (ival->numerator != 0 && ival->denominator != 0) sensor->ifp.frame_rate = min_t(unsigned int, ival->denominator / ival->numerator, @@ -1684,8 +1678,6 @@ static int mt9m114_ifp_set_frame_interval(struct v4l2_subdev *sd, if (sensor->streaming) ret = mt9m114_set_frame_rate(sensor); - mutex_unlock(sensor->ifp.hdl.lock); - return ret; }