From patchwork Sun Feb 23 16:42:02 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kuan-Wei Chiu X-Patchwork-Id: 867791 Received: from mail-pl1-f169.google.com (mail-pl1-f169.google.com [209.85.214.169]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AF188139D0A; Sun, 23 Feb 2025 16:43:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.169 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740328995; cv=none; b=bLtQwgyAIOmzxpCzrMgpfuHnBl7cmZYzisnn9UAVxbQAQdHGRiUp6FrXx4a6Rk7/ytTexhep9kE3rfG5PGmH2NXhhkarNP0mFVEWOlIxUcpHArrEcS1KBqEkQHB0lU3yPLcduZ3dJWn5XhyaoxjtszSjQCzP4f3kVRjsBt2N+eg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740328995; c=relaxed/simple; bh=43hnaHhMRxNK7BTgr+5PulsKt9J23D55SyRDpX/bt90=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=s3zv3GQiZpfo6IW2RcctFiIJlUaa/6uWm8lq5uDKV4/77jEIo+xFTPJeOqLw2Km1S/lElfV6wb2ZjrbeHLLZBaZ4CW7L2VKz0Z5w1Kuk0Bd1za6udMRuStDjWbLmqgiMQ5rSp6fHH+NaDtbozqkKd8+XlrlAFfVCsX/3r0pIzP8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=TKsdnawl; arc=none smtp.client-ip=209.85.214.169 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="TKsdnawl" Received: by mail-pl1-f169.google.com with SMTP id d9443c01a7336-220e989edb6so99060595ad.1; Sun, 23 Feb 2025 08:43:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1740328993; x=1740933793; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=BwB7nlCWtszUSdGoti59nJGyNKtl99nOClvJi35M3DI=; b=TKsdnawlw0n7oMwMyT7nm8NDvayL3m0UL27ebyhZdvFUvOn7ii0ls86EUMK9Nhm0kt zju+zYHGjR9quGbP837NNf36tZSe93J0GCbCJ9dS5wJNGKPJ+slEH9iF10ccKds8DDEB oudKmvjeK8fK+2UtGb1SpiA+dH8IQ2oWeBv53ltzPWPOwq4itCdwWa5e754iqEGBfpJX hyVFqkn2bEOXUXXHdVTPKFBns15BSbOmndxYtNpcGhDbLaS8crWYrf1LiCVOQV7y+KIf goSLYEk2U8pv9xIYKCO/GNTjKQ2CQpxP2mv0o2h+UXfHWNAGhxqZqTpF+iygfvJIMf1M GQYQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1740328993; x=1740933793; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=BwB7nlCWtszUSdGoti59nJGyNKtl99nOClvJi35M3DI=; b=fDXDgz8F+dIuQKJqe7e12PzMFHIyJm32A5XT2vBtXUF07PLs/MqbBtjVWtICZauHGh 9WTQOWhLPFlDzFsTnwjHi4g4JPgIuS81Or+4thMKFFSWsKO0O9UVOuNa7+vKW+bos653 7aKQKdW8XIzTFL+w4w6WR8DiMRX7PiZnWEOxXqRubbc+K3O1CfyWGdgY4KZZNjr0+I5m O5N71R73e1ZRTWAD6AaGOqbqOLLQlKMnSLHRtCEYk3okHBUswnP0JAaki9ZEFTILLP3F +ZjwEmeaeuRB080RFEiNEFt4Pt4VQYrpeTBu30ixNbbvvAMFO9BCCp+rmjrbioHwVEwW WHeQ== X-Forwarded-Encrypted: i=1; AJvYcCU5MIdi0zb9aIlxdNXVfxllpy79CZKi2f8sL0iJuwGF2bkLc4i/S3X8JDxcswnhT34o7e0=@vger.kernel.org, AJvYcCUR3DX4pIo3afByBH0Mdza/1TrN8iN2tgsw5UFi4JXK0OeAyv8DZ5WHj3UEBi6v/i73FRM1/dI4QW2uRQ8=@vger.kernel.org, AJvYcCVXWvvwyMsqVx0FoCXqYavYWTAjbnHyY1MdeUMDZf79WqrZDBpCP2oBRofI/3E5AiuIFlOSPbcrRjcJLPzTfhA=@vger.kernel.org, AJvYcCWJReCJbfQtoraICHwfUO0hgH1h3txpoE9yLxt0kfD06KRGNYQq+kVdvCjCfERZLF+PyIuM1jQ9@vger.kernel.org, AJvYcCWLMrBiFrjMt7Cch+kNF3cfszGLg3bFLn3jO8WFXwi9b/xnmFxnfzKgyJnyAAGg9vr+SOofLAF6ojSQzMqJ@vger.kernel.org, AJvYcCWPJZYA8tcFuBsxbcIDX1RIpxH43FS4OHcKBzL5wYabadKL4t8spw7cWANrD7Sq+q+7ebOsj1bStTvTLf4E@vger.kernel.org, AJvYcCWwm5TLzrsBv85nEWeXFUyyGw5E6DWAfU1VIqIx83QpqTwhkJqEdowm0uZ6pxX3cU59tQZmW2UmaXHDXIU=@vger.kernel.org X-Gm-Message-State: AOJu0YwcCDLf8N6ZTO/u8XP2Y7hZMcaexQABDHyuh+TUMEHkE5R68U5d UKH1x/WeIuuAz4xUqej0RL88fwp7XWL76um+dxrMiSYHrAtYgCJe X-Gm-Gg: ASbGncvfskBEGdJ5pEt/+YPukeq8IgIvfZj7k+W+dVTe51gEtTak6OzLrVWQqKE9lnr MapmqJdWgazClGqAo1H2CG4GZRR36uxb4q1MF2CcgdHODQ37+1kLXcKd6lJfxgrEOgpv9JYSrot dZ26S1e9If+knQq4wSyyXskWR74yryL1cl3b3VByhk4kOWRAbWzfqB8QL1ArJV1iF52fX4doNdM NTXMUDcFAYkqDiYE/xzfzBeUd71dZsLiufkAdiAH51QUkzgeLQfi4WX3UHd+njHoCu6KyzXE4gS oNE4BCOeH9/Qo0ukfXr0i56RrjrvYwefL7NlDyw6mUMf9j5pJqbogN/P X-Google-Smtp-Source: AGHT+IE58QWfaLQcoNHwIYpospn75AI8MBIDPjCyLRCCZKoYKvgXR3FRMWiJgPdm5hfaVo9o7EyRAQ== X-Received: by 2002:a17:902:ce05:b0:21f:baa:80c1 with SMTP id d9443c01a7336-2219fff2c88mr180524175ad.53.1740328992776; Sun, 23 Feb 2025 08:43:12 -0800 (PST) Received: from visitorckw-System-Product-Name.. ([140.113.216.168]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-2fceb09f6e0sm4935080a91.44.2025.02.23.08.43.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 23 Feb 2025 08:43:12 -0800 (PST) From: Kuan-Wei Chiu To: tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, dave.hansen@linux.intel.com, x86@kernel.org, jk@ozlabs.org, joel@jms.id.au, eajames@linux.ibm.com, andrzej.hajda@intel.com, neil.armstrong@linaro.org, rfoss@kernel.org, maarten.lankhorst@linux.intel.com, mripard@kernel.org, tzimmermann@suse.de, airlied@gmail.com, simona@ffwll.ch, dmitry.torokhov@gmail.com, mchehab@kernel.org, awalls@md.metrocast.net, hverkuil@xs4all.nl, miquel.raynal@bootlin.com, richard@nod.at, vigneshr@ti.com, louis.peens@corigine.com, andrew+netdev@lunn.ch, davem@davemloft.net, edumazet@google.com, pabeni@redhat.com, parthiban.veerasooran@microchip.com, arend.vanspriel@broadcom.com, johannes@sipsolutions.net, gregkh@linuxfoundation.org, jirislaby@kernel.org, yury.norov@gmail.com, akpm@linux-foundation.org Cc: hpa@zytor.com, alistair@popple.id.au, linux@rasmusvillemoes.dk, Laurent.pinchart@ideasonboard.com, jonas@kwiboo.se, jernej.skrabec@gmail.com, kuba@kernel.org, linux-kernel@vger.kernel.org, linux-fsi@lists.ozlabs.org, dri-devel@lists.freedesktop.org, linux-input@vger.kernel.org, linux-media@vger.kernel.org, linux-mtd@lists.infradead.org, oss-drivers@corigine.com, netdev@vger.kernel.org, linux-wireless@vger.kernel.org, brcm80211@lists.linux.dev, brcm80211-dev-list.pdl@broadcom.com, linux-serial@vger.kernel.org, bpf@vger.kernel.org, jserv@ccns.ncku.edu.tw, Kuan-Wei Chiu , Yu-Chun Lin Subject: [PATCH 02/17] bitops: Add generic parity calculation for u64 Date: Mon, 24 Feb 2025 00:42:02 +0800 Message-Id: <20250223164217.2139331-3-visitorckw@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20250223164217.2139331-1-visitorckw@gmail.com> References: <20250223164217.2139331-1-visitorckw@gmail.com> Precedence: bulk X-Mailing-List: linux-input@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Several parts of the kernel open-code parity calculations using different methods. Add a generic parity64() helper implemented with the same efficient approach as parity8(). Co-developed-by: Yu-Chun Lin Signed-off-by: Yu-Chun Lin Signed-off-by: Kuan-Wei Chiu --- include/linux/bitops.h | 22 ++++++++++++++++++++++ 1 file changed, 22 insertions(+) diff --git a/include/linux/bitops.h b/include/linux/bitops.h index fb13dedad7aa..67677057f5e2 100644 --- a/include/linux/bitops.h +++ b/include/linux/bitops.h @@ -281,6 +281,28 @@ static inline int parity32(u32 val) return (0x6996 >> (val & 0xf)) & 1; } +/** + * parity64 - get the parity of an u64 value + * @value: the value to be examined + * + * Determine the parity of the u64 argument. + * + * Returns: + * 0 for even parity, 1 for odd parity + */ +static inline int parity64(u64 val) +{ + /* + * One explanation of this algorithm: + * https://funloop.org/codex/problem/parity/README.html + */ + val ^= val >> 32; + val ^= val >> 16; + val ^= val >> 8; + val ^= val >> 4; + return (0x6996 >> (val & 0xf)) & 1; +} + /** * __ffs64 - find first set bit in a 64 bit word * @word: The 64 bit word From patchwork Sun Feb 23 16:42:04 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kuan-Wei Chiu X-Patchwork-Id: 867790 Received: from mail-pl1-f179.google.com (mail-pl1-f179.google.com [209.85.214.179]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 74A7D1411DE; Sun, 23 Feb 2025 16:43:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.179 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740329016; cv=none; b=Ejmx1oaS82IdH9AgpIEKw/qpVzmH7qOrHDNJzQebuwjii8vOCGymNfCTVVj6gI6jbTkQ/jkseGsdxmpyAsYGT2J5XxJAxDAIabu/+gCHYPmue5aFYrj0VyjnPNYVeUzhd3oTqWeuxqP5gfX1RXebkJlEkLyPYDO0p5z3pHT/yqA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740329016; c=relaxed/simple; bh=090s4Ovpl+A5aROx9Sbb2Y+qxVciWEvZposjEggOoUo=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=O5C0l2hbOaafyRVjOnqLoXS0MsX/dyLmUOxIkpbOyiRN/Lw3ksnC5IaTKSWe+6QqpsVS1uVEA+eDUx69fq49/6+9mRZCUcf0huN6ZzSxanW6AdDRuAWDrJs/iaxEyRKDuacCwXjh9lwwIxRQIx4Q5OGvto3KJrzDluml+kWjTPI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=iyfZG0Xq; arc=none smtp.client-ip=209.85.214.179 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="iyfZG0Xq" Received: by mail-pl1-f179.google.com with SMTP id d9443c01a7336-220c2a87378so61384815ad.1; Sun, 23 Feb 2025 08:43:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1740329014; x=1740933814; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=eJ7uyC7/exlluLKkDx5P6Zr0yOli/KDaWMiD/A1Io8w=; b=iyfZG0XqaBs1MjoxkMddkcRwbf7kSoMFC1zG3W02EKxfB+o1Jp+vD6q7whfyCYA12v 6mxV35+D82fqynspjP5NfXKmdvvhsPRSPfwthshrZhzwAts7YhxhzXJr1A7A00+uq4SF 7k6yZvQmrswme7r1gLZLfJlnvnLNmLsmCXzDj8ROCTT6ohM87/HSJFKn53HQlGz7safB /rLZbThr0U0OOpbgQXdEzjWuwHieIJwnwVs5wu5WF49gHBbTDdJFBv6o1QvbOdpTdtd7 LN3txgD1pRLWDfETIWeNYVSyg/nvZG5y7OVy8eTff33ywVjjzfMEMRTCnvEbn9PRNWFn wg0g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1740329014; x=1740933814; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=eJ7uyC7/exlluLKkDx5P6Zr0yOli/KDaWMiD/A1Io8w=; b=SIRi99hzq4p4a+l7XpiqcWL6peXLfciaAsUwSb5xzX4Cx25cXrl15jPwSIK1T47PFV 6TEaakVzq3wSnG6SSmac1ctGL6fuGx+k+bQj5LCUQt5onA7np+Z9SU+23I/pawrLSEpg +0s0DoXl54/YOGfFk/FykcvH1woFtlri0YtaIChRefd33HkFJHREhnTmUtX5n74/CJDY AQ7a1xUzmIWCUVzxqhIzxlGWed/RrwTVNjcbioEZM40zX8JmRmmEhekw8fMR5XGDrpMZ KBuTqdbrQ06LwLvN5bI/Go0h07/05WItn0qHrNvOUSCtaaDzOk6bDA7dWkGc3gXhqu3f SsqQ== X-Forwarded-Encrypted: i=1; AJvYcCU3W+I3bIrTcjgFXHOPxzRsilUWmmodLwNnkvY+/gcVH0lNfEMDRUsvX0h3XGXNMygOfqmjntZHTWuPfew=@vger.kernel.org, AJvYcCUK/qSFOcO5h/qRmxeWCz/7JImpmwV+Tx/QcZhOJ/n/UlAdailrpPiTY9NdbiwrJLiUEhykoD5PYf0mjc3A@vger.kernel.org, AJvYcCUNO2IshK6LYZETi1i9gyVHCU5D+Y7hwqKl5VjRUPgdn9m9pFRKZ1mrbMc7OX8+GgZcmt6xNaXmNc8K7ryukD4=@vger.kernel.org, AJvYcCUl6lR/whG71J520Nca84FGj6tWf9ONO7VVSc3A7MUNHlKOHycfCyindoD/eRQ077YnyVy4knbw@vger.kernel.org, AJvYcCVXL2YUrwgUECmTS3a3cazGPKwKi2/QYfERno2kuQ7I+tts6oOLsjgrsE8NAnxOXgQFXP0eAXQSfKyCHYg=@vger.kernel.org, AJvYcCVmff/MA38timfkUDAN+C1yaRzqAeuWDZ0Pc1qA7zEiYP8wn3wT3IL+KG7W6aUJ5Hs+e4N8zsqe5ln7hnqa@vger.kernel.org, AJvYcCXBZUkgzlqvJZvVWUc5pYZk39ouBJUbAsJziCaCW8fCfEkMRrxmfIkmlfOAHk8iuPeU8Tc=@vger.kernel.org X-Gm-Message-State: AOJu0YzZhBJy+678ebhk+rL+NFZj71kDq2xi+jSvSa12wU430oVpz9aL sdDkLkyVrZiEq4RpMC65tCENIcCiITws3Ac1p6LPptnOjxQsUWFo X-Gm-Gg: ASbGnctr2Vdd4kZQJeRo2/bZuqpcAXhMx40E1sjtVLNjAeu0oNE2bf2whlDZ1EqK6Az ViQJ0rzCDfzA4eLH0Cybt8HhzRulHfC9IuDyhQ/iuTYgod3dZjJeosFSUJbwdrH5YF2n+kh4P8r IPKNoZk4g2/HAlCAbtr/liBJK4XT+QTcWiIFt76Ka7GF796V8aBwRPJbUV9bi+oZ9FA0CpDClZ2 UCaZcpbi07VdJkh4pJ9ymRfhxvHu0k5JAGMqR9L0ob9eXIHlNnZJIAyjJ677ZuwMIUFpXoIAdvO Uq9dfuFR+wdKRpLkhf3+kQIdgb1efwsgPIrPPg1zi2JcgnONDWYNf5b4 X-Google-Smtp-Source: AGHT+IGEf83VZ2oIxRJRK+CnkiI3bN9hJqE3s48Hx05CleZdaHJAPpPthd1i56ltfHnEYIca1Ehjjg== X-Received: by 2002:a05:6a21:394c:b0:1ee:cdda:b8ea with SMTP id adf61e73a8af0-1eef52f7d5fmr16011633637.19.1740329014620; Sun, 23 Feb 2025 08:43:34 -0800 (PST) Received: from visitorckw-System-Product-Name.. ([140.113.216.168]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-2fceb09f6e0sm4935080a91.44.2025.02.23.08.43.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 23 Feb 2025 08:43:34 -0800 (PST) From: Kuan-Wei Chiu To: tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, dave.hansen@linux.intel.com, x86@kernel.org, jk@ozlabs.org, joel@jms.id.au, eajames@linux.ibm.com, andrzej.hajda@intel.com, neil.armstrong@linaro.org, rfoss@kernel.org, maarten.lankhorst@linux.intel.com, mripard@kernel.org, tzimmermann@suse.de, airlied@gmail.com, simona@ffwll.ch, dmitry.torokhov@gmail.com, mchehab@kernel.org, awalls@md.metrocast.net, hverkuil@xs4all.nl, miquel.raynal@bootlin.com, richard@nod.at, vigneshr@ti.com, louis.peens@corigine.com, andrew+netdev@lunn.ch, davem@davemloft.net, edumazet@google.com, pabeni@redhat.com, parthiban.veerasooran@microchip.com, arend.vanspriel@broadcom.com, johannes@sipsolutions.net, gregkh@linuxfoundation.org, jirislaby@kernel.org, yury.norov@gmail.com, akpm@linux-foundation.org Cc: hpa@zytor.com, alistair@popple.id.au, linux@rasmusvillemoes.dk, Laurent.pinchart@ideasonboard.com, jonas@kwiboo.se, jernej.skrabec@gmail.com, kuba@kernel.org, linux-kernel@vger.kernel.org, linux-fsi@lists.ozlabs.org, dri-devel@lists.freedesktop.org, linux-input@vger.kernel.org, linux-media@vger.kernel.org, linux-mtd@lists.infradead.org, oss-drivers@corigine.com, netdev@vger.kernel.org, linux-wireless@vger.kernel.org, brcm80211@lists.linux.dev, brcm80211-dev-list.pdl@broadcom.com, linux-serial@vger.kernel.org, bpf@vger.kernel.org, jserv@ccns.ncku.edu.tw, Kuan-Wei Chiu , Yu-Chun Lin Subject: [PATCH 04/17] media: media/test_drivers: Replace open-coded parity calculation with parity8() Date: Mon, 24 Feb 2025 00:42:04 +0800 Message-Id: <20250223164217.2139331-5-visitorckw@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20250223164217.2139331-1-visitorckw@gmail.com> References: <20250223164217.2139331-1-visitorckw@gmail.com> Precedence: bulk X-Mailing-List: linux-input@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Refactor parity calculations to use the standard parity8() helper. This change eliminates redundant implementations and improves code efficiency. Co-developed-by: Yu-Chun Lin Signed-off-by: Yu-Chun Lin Signed-off-by: Kuan-Wei Chiu --- drivers/media/test-drivers/vivid/vivid-vbi-gen.c | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/drivers/media/test-drivers/vivid/vivid-vbi-gen.c b/drivers/media/test-drivers/vivid/vivid-vbi-gen.c index 70a4024d461e..90fafa533ccd 100644 --- a/drivers/media/test-drivers/vivid/vivid-vbi-gen.c +++ b/drivers/media/test-drivers/vivid/vivid-vbi-gen.c @@ -5,6 +5,7 @@ * Copyright 2014 Cisco Systems, Inc. and/or its affiliates. All rights reserved. */ +#include #include #include #include @@ -165,12 +166,7 @@ static const u8 vivid_cc_sequence2[30] = { static u8 calc_parity(u8 val) { - unsigned i; - unsigned tot = 0; - - for (i = 0; i < 7; i++) - tot += (val & (1 << i)) ? 1 : 0; - return val | ((tot & 1) ? 0 : 0x80); + return val | ((parity8(val)) ? 0 : 0x80); } static void vivid_vbi_gen_set_time_of_day(u8 *packet) From patchwork Sun Feb 23 16:42:06 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kuan-Wei Chiu X-Patchwork-Id: 867789 Received: from mail-pl1-f169.google.com (mail-pl1-f169.google.com [209.85.214.169]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7FF25139CFF; Sun, 23 Feb 2025 16:43:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.169 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740329038; cv=none; b=EUwYN3rIsVWV4yxw7/pVKDX1Kioq0gixTiV3Pn44AGjNEK2JUKpqKmH18mdIKzEgFFxsnm2euxPk1HQzOj6pFhvMmAUUw7kc+VHuou0jOLP57OZFM6/DTyVw7+cJdZp2v3TzkvPxMg9YPCxFG/iQINtnxip0jP3QpiM+iXptOww= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740329038; c=relaxed/simple; bh=j2/wDG0L2QiKPBmNCWrxOGnHtFWO5kAL6+5E33WSh7Q=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=FZ7SWqY8VZCdZzR7DmS1qMixDXeoUMCqgooAD0rkZNQpp72fYxxItR2V3Rv6y43vcF5kaew3dkTtk3Sxr2C1TK0wjc+zEOYWdJkfdfKXoYjKkORkN4joRxMBN85a3A0/e5sEWEK56E+aqwDwNGJfcwe616wVpqrF4zCzvk3G3n4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=WlaMP9VZ; arc=none smtp.client-ip=209.85.214.169 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="WlaMP9VZ" Received: by mail-pl1-f169.google.com with SMTP id d9443c01a7336-220bfdfb3f4so82162245ad.2; Sun, 23 Feb 2025 08:43:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1740329037; x=1740933837; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=TZw0QJRtM6IhR4KZmh2KNqroHre3ebnX5GDU+1y6qXk=; b=WlaMP9VZRsohRrWYHbk4AbUXEfMt1i+S3ts4Z0o0QfXd32Qs/n4hDfYwpOdOcDa861 e9aQA0PSgpEDi0krvkfquG+2o+qJxZvHLQU3HmhNIIhhg5SPN3BG6GK2gKko+SLq+zqg FgJbB6e5lYguV8TUvOx1jubOmDWCydVw5cFshvmLNZsYVi7tcxk99nNB4aqhjIq0gKUa vBFMZLFpnKnSrFkc1j4rAPi6WzN0+qFfhVqkDb9KYsOsiiUUrwYgK2EYGsMkabKDgwXK nAixB7L1eualVy1xKOEImoM/Q3TtEb7+6TDPyCQo2HieWvQZep7mR0dxnGSBmFBGuLyu nddQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1740329037; x=1740933837; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=TZw0QJRtM6IhR4KZmh2KNqroHre3ebnX5GDU+1y6qXk=; b=p41yBlXyuqmsJPVY6WajIlrGsXavFe+nl/Sowd4smJsLDZHf45xp6oAr/3Njo+j7fL QbNX4VhjPNGgLUJXHFl3p445mFa9F9h2GRvg3IZJo3B0zKtz1+luzZOt66AwvtDnFvtC saekuaTMY80zZ6NBO0g7Ak6RRRtr+9/nWqAAETst+s21aLPMmEBJmAXQboMEAjhPWyzB FaOZAKsJo+dcDBpidxKSK/NX4a2pQEWzJ2Kc1YFu1PvWfUP+mSgkyCfKYh4kw8wlXkjg pB4QnlpE+NeHBXTZpV+N2EXxixOL51YzOW2RkX38F5BAwTt63c3WpDtB8Vopkc92h3OO YWqQ== X-Forwarded-Encrypted: i=1; AJvYcCUOp2gewHu93H6bEZVdM7BkpAa7BbOEJZBLeuph5FIwP8i4YPAZT5WPPrkNLMHSw6g6AQB26OJjX+s//to=@vger.kernel.org, AJvYcCVSzoLqGkVN9QyPZfi1+JhDNEY8BP5a2JcVRBrVt6WYEAe41xqcIARZJfYlBKKD6wyWKU737RnnmSM392Go@vger.kernel.org, AJvYcCVlmxxiIOV3CDu9M2Wg7suwL5hzamHjSohg2GJckk4FV/+4M3gGURB7Pmn9GheLiGsWfYTeFGJwcwDTtHA=@vger.kernel.org, AJvYcCWHSWIAThPEQZZfeyuE5LZnc0T6cw+m6cOESGu3XhwQ+OHheDAIZIVjeHc2c7SlZFED1TUCPMM2@vger.kernel.org, AJvYcCX7b1Ne4uYWWU8cd7hpdCVuEvyBnbTZqXUGkD2Dpe7kADjU4qMAlYUPYX3KcOqYEhnS+6rwxS5Ham16HG/AQlA=@vger.kernel.org, AJvYcCXbDJ+VWDfZ9t7nVtz0snv6W+S0EVVc7oJeeG3MX4OlYbpZjR2ebmP/6w5aEMrj+lCbEhU5nHxteVYj9wkc@vger.kernel.org, AJvYcCXt7B5ZwJxm80ChPwPayYE0Vy+hmSRGm/5H58bJwhcL1u4VM/xGeh+hRVckugF6BAB8Cug=@vger.kernel.org X-Gm-Message-State: AOJu0Yw8fY1fpGZU1a/p2bhSf67ybd5X0pZgPRVh9FArcuOW6yy6VWNo e8t5Xrq0jxY7e7IoXAuyOSCosjJtFbdbU/dDOV23oSvPFsfqZaS7 X-Gm-Gg: ASbGnctplhvF5YIZmJrS17fTwkd3nN/JsC9nm60daCRKBUkwO93SG+7tqJkGoVaLq6L nWXolo9O3NHcQkwIJqsqc/rFL0YcSq8+lS7ULgbnzfljVm4oQjmwh2koHig33C5IRDX7vHrfdap ZhorCzeJyvsRUWv/jBtK4ruaj0Hh3R2VSoIjJ06kGFQpB7T0CklFYqtMUgtly1UXrYb/erzQdWw ULMP6w0xKuznLjHWfOQ4GJp+mi+jdfTREQHoQ6ApL89dep70Ml3FtpYK7UE88EDiuZ9dDMwakfb 9q1MGaYwWfqlxYb+XZzQ8Ud9TTy2A0Jo6lux/Etoc/hlohNYiBXo+A2D X-Google-Smtp-Source: AGHT+IEgNthmnTYYE27hPhlCIM7V4DPg7XXe7YBwN1u1Fl+WN3rwEYwr5OtCEkA4s1cdBmE2mWkiww== X-Received: by 2002:a17:902:db07:b0:216:73f0:ef63 with SMTP id d9443c01a7336-2219fff4377mr185099965ad.49.1740329036761; Sun, 23 Feb 2025 08:43:56 -0800 (PST) Received: from visitorckw-System-Product-Name.. ([140.113.216.168]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-2fceb09f6e0sm4935080a91.44.2025.02.23.08.43.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 23 Feb 2025 08:43:56 -0800 (PST) From: Kuan-Wei Chiu To: tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, dave.hansen@linux.intel.com, x86@kernel.org, jk@ozlabs.org, joel@jms.id.au, eajames@linux.ibm.com, andrzej.hajda@intel.com, neil.armstrong@linaro.org, rfoss@kernel.org, maarten.lankhorst@linux.intel.com, mripard@kernel.org, tzimmermann@suse.de, airlied@gmail.com, simona@ffwll.ch, dmitry.torokhov@gmail.com, mchehab@kernel.org, awalls@md.metrocast.net, hverkuil@xs4all.nl, miquel.raynal@bootlin.com, richard@nod.at, vigneshr@ti.com, louis.peens@corigine.com, andrew+netdev@lunn.ch, davem@davemloft.net, edumazet@google.com, pabeni@redhat.com, parthiban.veerasooran@microchip.com, arend.vanspriel@broadcom.com, johannes@sipsolutions.net, gregkh@linuxfoundation.org, jirislaby@kernel.org, yury.norov@gmail.com, akpm@linux-foundation.org Cc: hpa@zytor.com, alistair@popple.id.au, linux@rasmusvillemoes.dk, Laurent.pinchart@ideasonboard.com, jonas@kwiboo.se, jernej.skrabec@gmail.com, kuba@kernel.org, linux-kernel@vger.kernel.org, linux-fsi@lists.ozlabs.org, dri-devel@lists.freedesktop.org, linux-input@vger.kernel.org, linux-media@vger.kernel.org, linux-mtd@lists.infradead.org, oss-drivers@corigine.com, netdev@vger.kernel.org, linux-wireless@vger.kernel.org, brcm80211@lists.linux.dev, brcm80211-dev-list.pdl@broadcom.com, linux-serial@vger.kernel.org, bpf@vger.kernel.org, jserv@ccns.ncku.edu.tw, Kuan-Wei Chiu , Yu-Chun Lin Subject: [PATCH 06/17] media: saa7115: Replace open-coded parity calculation with parity8() Date: Mon, 24 Feb 2025 00:42:06 +0800 Message-Id: <20250223164217.2139331-7-visitorckw@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20250223164217.2139331-1-visitorckw@gmail.com> References: <20250223164217.2139331-1-visitorckw@gmail.com> Precedence: bulk X-Mailing-List: linux-input@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Refactor parity calculations to use the standard parity8() helper. This change eliminates redundant implementations and improves code efficiency. Co-developed-by: Yu-Chun Lin Signed-off-by: Yu-Chun Lin Signed-off-by: Kuan-Wei Chiu --- drivers/media/i2c/saa7115.c | 12 ++---------- 1 file changed, 2 insertions(+), 10 deletions(-) diff --git a/drivers/media/i2c/saa7115.c b/drivers/media/i2c/saa7115.c index a1c71187e773..b8b8f206ec3a 100644 --- a/drivers/media/i2c/saa7115.c +++ b/drivers/media/i2c/saa7115.c @@ -25,6 +25,7 @@ #include "saa711x_regs.h" +#include #include #include #include @@ -664,15 +665,6 @@ static const unsigned char saa7115_init_misc[] = { 0x00, 0x00 }; -static int saa711x_odd_parity(u8 c) -{ - c ^= (c >> 4); - c ^= (c >> 2); - c ^= (c >> 1); - - return c & 1; -} - static int saa711x_decode_vps(u8 *dst, u8 *p) { static const u8 biphase_tbl[] = { @@ -1227,7 +1219,7 @@ static int saa711x_decode_vbi_line(struct v4l2_subdev *sd, struct v4l2_decode_vb vbi->type = V4L2_SLICED_TELETEXT_B; break; case 4: - if (!saa711x_odd_parity(p[0]) || !saa711x_odd_parity(p[1])) + if (!parity8(p[0]) || !parity8(p[1])) return 0; vbi->type = V4L2_SLICED_CAPTION_525; break; From patchwork Sun Feb 23 16:42:08 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kuan-Wei Chiu X-Patchwork-Id: 867788 Received: from mail-pj1-f45.google.com (mail-pj1-f45.google.com [209.85.216.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 42E0713B280; Sun, 23 Feb 2025 16:44:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.45 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740329062; cv=none; b=CfMJk3brgSQIXegzLE8cumE9ISSFCaT0l5QbAOr8pRx+wd2Qo7n7QUXUwZRm8O4MMMYiK3lfriLDRTFFKR62YII/RJRX2MzTGmSul5D9vL6Yv2In/OhQ/uN1IK3gUxNvLxnxtQGintp4OlBSbLHSFI5QTRPq6Fctb6igrZjs2nM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740329062; c=relaxed/simple; bh=HKAn3f+7sbHTTp+UNFXBUa/TbF/WrljtWVRMW4BZHbw=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=nRbqHnwuOIcGdv3eDxVkIEghVcdNvjWUgNbLxENhnX/Bki0vqDPEkaArns9MrHRUHk9CIlLd7OBFKpAy8JoSHyywXevEZ83pTu8nNawvB7M3sybLPFS6D2dMKvbRRop+N+vinCHrt9Bhe7UtFt0ChC2f0LfOIdYMghaLOPg2LiQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=R3ILKsQD; arc=none smtp.client-ip=209.85.216.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="R3ILKsQD" Received: by mail-pj1-f45.google.com with SMTP id 98e67ed59e1d1-2fc1c80cdc8so5668623a91.2; Sun, 23 Feb 2025 08:44:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1740329060; x=1740933860; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=EcXJ496C/2+0qa2GsfTbiscKGioWO59ZW48/kJd6oSs=; b=R3ILKsQDeSASlpib/utH1OBIIvgkbhHKtzCiJKemgAPlVFtDHx0/4XMqZJ4nDybQzs U154M++P8t3jcEkfluN+cVLpu3Nfd8HGHcaPxo5HOZJcpy+r/fzrFuvFtutRYJ5lc9aw 8NzMzLZMXu2HtvqZB1EkZGnPXVdg7queQYG3aOJmVnGlJQlF+libls8umbgRzyviUI1Y gHT0NaVpQJ8S7brJ5FKN4xcgOejWPk3LQFdsLDSGzQxyATcnHybFyVi/BweRSflcS+E/ yHIPAdZfXVAya7CImLvTTgxBqSAmgRgSvB/lmNsRYyzeKiHuQ36mVWeEYsSy8RbcL6Nu yFRw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1740329060; x=1740933860; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=EcXJ496C/2+0qa2GsfTbiscKGioWO59ZW48/kJd6oSs=; b=T29ZWCteeGMQCfJaGGkWZaM720v4IoZ9596slC9BPcijvCdNLLsMTiHsDFt7Xox2+V xOmC0pYlPa3HvBhdj/FZf1l1ZXf7xxxf/9rzaGZ652FQ3Ut6g8VUk7O+TZrQcEaiBIfG OqehBplnImUDY/XZzeBNQLY26XqpN9LWZWTBEcvwcOhV/Xn0ZT5IFAhKMUd8IkAjJKsr YnxnjEvE29xUDnbc3gHJIjfXuGawxY7/VuSTY8bpUcOZIVm9y9rWTewQjdA3rjwYJqg3 X9PUe3kil1kvDVPXDiha1TMKSGQotGeWxmdR+SBVNG2ILv84WPVcIZxmdvKlxP+bqOHP E07g== X-Forwarded-Encrypted: i=1; AJvYcCUIiJXLPh2ZYk9mgOmeqvLvhCIv47Uas0VP30JgTvWA1egtfe6tpfYoswgeM50LNChREHg1pucGvvU5aX9T@vger.kernel.org, AJvYcCVXkjUUxT+k0aXZTfUxzPOA4gRj5aL9DzLIvBvZQ6gn3PoD1wk1vycSOX7ahRH73DHlxWrPYPMGclIGVcM7@vger.kernel.org, AJvYcCWJppFVd+Ue3OwqTDVDstl/tfcAYMCUEwoeKUqtg7O5d44czHyOrgorfXGtCTgzQHK6Ocy5Qs5e@vger.kernel.org, AJvYcCWMMvHL80mI7FkffHtPzjlsb3icGkr2JVgxC7Vgyex06/lR2Xa8fepuLEfF5mtlgS/Hfq0AQHJROi+h8rPGoss=@vger.kernel.org, AJvYcCXRW3UbJAOGsxC7iW+e/XMPtMwZtXjUU1PwknAsuJjqqg7w5tFetCBW925b/xfyWNdLTwY=@vger.kernel.org, AJvYcCXTSmcYnxIktHvPHMd/AJ/Y+9nF0mLcXXOAqJqINoxB+cRSFewZqUphNkM1f1KIuAKFWSSb7PcGr3BMEFY=@vger.kernel.org, AJvYcCXUn7OIdwtPUnZt+rgVBnadqcGbfFGqzq4q992HzPac4lzT4eZ9YKttYvR5AebNDKVvPpLV89NegB1BXb0=@vger.kernel.org X-Gm-Message-State: AOJu0YzhDvu2SBx9jwAyLagkCciFBY5559S2PCxVQ17gYfQs1QcQGOSC 6S1S7+hytA/Zoim5pt6RDcIPZS5pkt4M1yS32LARcAhXGPrx1n1p X-Gm-Gg: ASbGncueRaW4oDsHSOMFOCQPhtjChu0Xj44bILDXw9/R51VBW69kx7GJ/Qhh6qk42WW qAKZNVCTQxZ+Y8Cm59Fa2zYY9suR2BeHL1VZify76PVVCV6JcylTj4Q23ijWXbfERfNotTPTHw8 S2hgYcbAr+JwRekz3KIhZaj5ACnxwJlqO7/+j17a6jWv9N0n1zbrXc18mKIDVv6/irwUdClPm8Y kDdzrG6Fn6O3z1C0XkRchaHeglNMS6N2tBmsFkan6fzv39zi4/EpGtEDUv1rs05ANegK/aRpfri TvdhBda1E9qTsetkFPsJ/1a2jLfZua4w76Y/2L1Vz9MsbPTVNVUBL+dB X-Google-Smtp-Source: AGHT+IHbMWEVOubhP8X9psmxxmvHUjnp2Da3yrH5tyGilfGOwqHtwm1WTVAYDoMFuzjd1nirp2a0lA== X-Received: by 2002:a17:90b:2f10:b0:2ee:f076:20f1 with SMTP id 98e67ed59e1d1-2fce75d8389mr20940871a91.0.1740329060473; Sun, 23 Feb 2025 08:44:20 -0800 (PST) Received: from visitorckw-System-Product-Name.. ([140.113.216.168]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-2fceb09f6e0sm4935080a91.44.2025.02.23.08.44.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 23 Feb 2025 08:44:20 -0800 (PST) From: Kuan-Wei Chiu To: tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, dave.hansen@linux.intel.com, x86@kernel.org, jk@ozlabs.org, joel@jms.id.au, eajames@linux.ibm.com, andrzej.hajda@intel.com, neil.armstrong@linaro.org, rfoss@kernel.org, maarten.lankhorst@linux.intel.com, mripard@kernel.org, tzimmermann@suse.de, airlied@gmail.com, simona@ffwll.ch, dmitry.torokhov@gmail.com, mchehab@kernel.org, awalls@md.metrocast.net, hverkuil@xs4all.nl, miquel.raynal@bootlin.com, richard@nod.at, vigneshr@ti.com, louis.peens@corigine.com, andrew+netdev@lunn.ch, davem@davemloft.net, edumazet@google.com, pabeni@redhat.com, parthiban.veerasooran@microchip.com, arend.vanspriel@broadcom.com, johannes@sipsolutions.net, gregkh@linuxfoundation.org, jirislaby@kernel.org, yury.norov@gmail.com, akpm@linux-foundation.org Cc: hpa@zytor.com, alistair@popple.id.au, linux@rasmusvillemoes.dk, Laurent.pinchart@ideasonboard.com, jonas@kwiboo.se, jernej.skrabec@gmail.com, kuba@kernel.org, linux-kernel@vger.kernel.org, linux-fsi@lists.ozlabs.org, dri-devel@lists.freedesktop.org, linux-input@vger.kernel.org, linux-media@vger.kernel.org, linux-mtd@lists.infradead.org, oss-drivers@corigine.com, netdev@vger.kernel.org, linux-wireless@vger.kernel.org, brcm80211@lists.linux.dev, brcm80211-dev-list.pdl@broadcom.com, linux-serial@vger.kernel.org, bpf@vger.kernel.org, jserv@ccns.ncku.edu.tw, Kuan-Wei Chiu , Yu-Chun Lin Subject: [PATCH 08/17] lib/bch: Replace open-coded parity calculation with parity32() Date: Mon, 24 Feb 2025 00:42:08 +0800 Message-Id: <20250223164217.2139331-9-visitorckw@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20250223164217.2139331-1-visitorckw@gmail.com> References: <20250223164217.2139331-1-visitorckw@gmail.com> Precedence: bulk X-Mailing-List: linux-input@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Refactor parity calculations to use the standard parity32() helper. This change eliminates redundant implementations and improves code efficiency. Co-developed-by: Yu-Chun Lin Signed-off-by: Yu-Chun Lin Signed-off-by: Kuan-Wei Chiu --- lib/bch.c | 14 +------------- 1 file changed, 1 insertion(+), 13 deletions(-) diff --git a/lib/bch.c b/lib/bch.c index 1c0cb07cdfeb..769459749982 100644 --- a/lib/bch.c +++ b/lib/bch.c @@ -311,18 +311,6 @@ static inline int deg(unsigned int poly) return fls(poly)-1; } -static inline int parity(unsigned int x) -{ - /* - * public domain code snippet, lifted from - * http://www-graphics.stanford.edu/~seander/bithacks.html - */ - x ^= x >> 1; - x ^= x >> 2; - x = (x & 0x11111111U) * 0x11111111U; - return (x >> 28) & 1; -} - /* Galois field basic operations: multiply, divide, inverse, etc. */ static inline unsigned int gf_mul(struct bch_control *bch, unsigned int a, @@ -524,7 +512,7 @@ static int solve_linear_system(struct bch_control *bch, unsigned int *rows, tmp = 0; for (r = m-1; r >= 0; r--) { mask = rows[r] & (tmp|1); - tmp |= parity(mask) << (m-r); + tmp |= parity32(mask) << (m-r); } sol[p] = tmp >> 1; } From patchwork Sun Feb 23 16:42:10 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kuan-Wei Chiu X-Patchwork-Id: 867787 Received: from mail-pl1-f171.google.com (mail-pl1-f171.google.com [209.85.214.171]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6C8C8131E2D; Sun, 23 Feb 2025 16:44:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.171 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740329083; cv=none; b=QMKR1f3dns8YWh67aCOoH7jTLD63FuLeoFRi36ZtgMvjsU0r9ALv6WGEMZf85QTmPsFyQ3s9Y+Y2oo+l1S+7JREbaoCw/ftMOQO+9BdKmObxYlXhhbIulqcvmV1vOR/RDGnPxzI0z+mAtS5cK2yzXu7axp/C5UhrEbrzJJMpkvo= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740329083; c=relaxed/simple; bh=WDPrYaKj7s26kse115+qww0IFHKFhkIMhznNoEr7JrI=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=sH68+igD1+43EbmOW+GL+FfWsjF5jU7a/zqRtm416Q3uHd2NLfdCcUEu8WjZ5ahIgtx9cQ4VHUUI7Y+eEwzLOdhRRAMX2V0N/RgDfDQZY022dPDJQ6j0cDQ7DkJ0LPPIx5SzydW35JPtRqPLs/YWXSiNnS1pkkn+Qi+qgis/b78= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=ADZ7gxID; arc=none smtp.client-ip=209.85.214.171 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="ADZ7gxID" Received: by mail-pl1-f171.google.com with SMTP id d9443c01a7336-21c2f1b610dso104724335ad.0; Sun, 23 Feb 2025 08:44:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1740329082; x=1740933882; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=OqxvpgZHoGiLr6YH8sD6RZa4e3r1mx+K51Pz7JFmQwA=; b=ADZ7gxIDL709u0YQSMQHvULAQ8Ucdzp0AT3lw5q6S60FTdYGoVIumGyrbroMSUIEh7 qqVG9ugCVZkYnQr3XaRflEy6sLwpXPzjyA6xswL0ean/g4PGblZ5RuN9STLpo8Vm7KmY V+rEBkYn/4cUp98RS2OkCBDGvs0jYq5zVta2w6KtDKWJCwL6SWPGdkjWYkC9ufV5pFON FQC3LrK9O1mgBAmO+acQ9KcvIXH7OIffXNlJEaX49uL6M7YaUSxiFqCpoP2LCvjkf5Oo rk3S5yFqR6DfqsxmgMdWiixX2iZlbLCKaby7NHB8qbwigeGovmPLLS7AqsjFk1xLYs4L fqQA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1740329082; x=1740933882; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=OqxvpgZHoGiLr6YH8sD6RZa4e3r1mx+K51Pz7JFmQwA=; b=RjWbFNGHXgqAGbx0Jd0+bmcHoBb/4YSqj3EIA4Xi86HDMM1N+Ez0hraCkB/mdwKW6T yIK00qpXIPqThO25puVpJeQVbr30t6L7X/Wu/nCv1dxv8Lwbh1avTIYOrzmlwJacD8T/ ACsQ8c7KxVqAKtYde6x6QOZf/7Qfyea8grgcP1qrd38NunyNmxlPgMPnhNwqFdBWYZY/ btVyB6/VqBeIW5DQ3Hr6/QXhdypbx4dW63FLB5pVpbTe/aWTmK44CemrykHn7p0ejFuB 2DYTuCN/zXSgvxrre6QC5cSyClykimVRvplxjye5pU7rOPAVnF8TUW75l5o/KnOSWXQZ y3Ww== X-Forwarded-Encrypted: i=1; AJvYcCUZnpCcrbtVCU6K17P3J6pvQeT7f3mQjKlPG6UbPbiVkifZ5XjBy88bgXoNQFMvxMzJWF6707rKwlmhLDsA@vger.kernel.org, AJvYcCUqNzaUaXrobg82XZ6Z6QZRXuo/ur6JeeBuYyiM+Jp12pX4HGMv2Hom5sjX/yqv4nvfzRSKnel1LtcOjI0x@vger.kernel.org, AJvYcCVX1r4X1YLRJE4Rl9XjBu7+HB4y7eQFZ9HZgXet6oXGvkJVUTs7Ja5cc1O5G6G0cbr1jqg=@vger.kernel.org, AJvYcCWRstbOcQmjUtR3OStu1LxylsBMtq3Y8OuYx4h8+vHcaRHrgV5teqPo4GLGQn3Yq2WgawytI7nvU/esXWUySsI=@vger.kernel.org, AJvYcCWVz5NRAyVfPXxrms71Ha7Hv1ZoF32UMyFEeWQwTsF+o4p8sh5bLlr36Rg9wKLANdx4nq8twJ3QfmdOW/s=@vger.kernel.org, AJvYcCWhlaZVZZSlXvgd2ZA0/5ep6lRFXHV4CS/Eh795sG0jX5nsBkdG2aUUd+zT5vnKUd7wKxlLmhco@vger.kernel.org, AJvYcCWktI3G0JIVlLBcm9DA793sngVWTGeobwPvuJ9cmNd1cdZMXOD5W0Tyy9Rj46+kOuLgyrn0MWvkAaCH3rw=@vger.kernel.org X-Gm-Message-State: AOJu0YzSqcRTYRA2ibYL5iuVx3eEKygpFWpvZRbQZwDfUQtlTpOJBMAR uyXnAC1cr7VIZAaR4XzlIYPtkdzTfK6Uhz05pNmVbbeT49T0CC1g X-Gm-Gg: ASbGncs8I//+CcjnqJ5R5msYctnDkgMd6qwKPHfAdtcY6/RsDiy+rzx32fSUOeu+KAX vpVmXDae2I3EwZ5UjR5Fk4f7twByZ4Zx6WCvFoTvFgTUc8Y1WyM6UYsNvVM6oRgAWlP/c8pFARD ZdrcrcUyQrucbrFTA4oJBfsDCPdEVZIuddy5v8ybXmMxSnlXIuZeOUpnNGlzxiXX6immwkgo8iB kf0a+b9M5J0Q3hj15aZvDp76yHdYBHOeYbdn1S2QKIoVOfJmDOPWX638JVF3kGpvvxx7bAXu20b ccvYuhT7w1Y+CxNNbHqmwbAk8gFBZ3RjECaqoNpxD3FOtEDOY8GQnrbt X-Google-Smtp-Source: AGHT+IGsE1LtqpOiLzBH/xsJP0qffWffejZOaFdgJ8XT2KOaHV87U7eq24SL1hIn8uNFPIxHHHWZ4w== X-Received: by 2002:a17:902:d54c:b0:220:e023:8fa6 with SMTP id d9443c01a7336-2219ffd8556mr169735225ad.50.1740329081702; Sun, 23 Feb 2025 08:44:41 -0800 (PST) Received: from visitorckw-System-Product-Name.. ([140.113.216.168]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-2fceb09f6e0sm4935080a91.44.2025.02.23.08.44.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 23 Feb 2025 08:44:41 -0800 (PST) From: Kuan-Wei Chiu To: tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, dave.hansen@linux.intel.com, x86@kernel.org, jk@ozlabs.org, joel@jms.id.au, eajames@linux.ibm.com, andrzej.hajda@intel.com, neil.armstrong@linaro.org, rfoss@kernel.org, maarten.lankhorst@linux.intel.com, mripard@kernel.org, tzimmermann@suse.de, airlied@gmail.com, simona@ffwll.ch, dmitry.torokhov@gmail.com, mchehab@kernel.org, awalls@md.metrocast.net, hverkuil@xs4all.nl, miquel.raynal@bootlin.com, richard@nod.at, vigneshr@ti.com, louis.peens@corigine.com, andrew+netdev@lunn.ch, davem@davemloft.net, edumazet@google.com, pabeni@redhat.com, parthiban.veerasooran@microchip.com, arend.vanspriel@broadcom.com, johannes@sipsolutions.net, gregkh@linuxfoundation.org, jirislaby@kernel.org, yury.norov@gmail.com, akpm@linux-foundation.org Cc: hpa@zytor.com, alistair@popple.id.au, linux@rasmusvillemoes.dk, Laurent.pinchart@ideasonboard.com, jonas@kwiboo.se, jernej.skrabec@gmail.com, kuba@kernel.org, linux-kernel@vger.kernel.org, linux-fsi@lists.ozlabs.org, dri-devel@lists.freedesktop.org, linux-input@vger.kernel.org, linux-media@vger.kernel.org, linux-mtd@lists.infradead.org, oss-drivers@corigine.com, netdev@vger.kernel.org, linux-wireless@vger.kernel.org, brcm80211@lists.linux.dev, brcm80211-dev-list.pdl@broadcom.com, linux-serial@vger.kernel.org, bpf@vger.kernel.org, jserv@ccns.ncku.edu.tw, Kuan-Wei Chiu , Yu-Chun Lin Subject: [PATCH 10/17] net: ethernet: oa_tc6: Replace open-coded parity calculation with parity32() Date: Mon, 24 Feb 2025 00:42:10 +0800 Message-Id: <20250223164217.2139331-11-visitorckw@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20250223164217.2139331-1-visitorckw@gmail.com> References: <20250223164217.2139331-1-visitorckw@gmail.com> Precedence: bulk X-Mailing-List: linux-input@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Refactor parity calculations to use the standard parity32() helper. This change eliminates redundant implementations and improves code efficiency. Co-developed-by: Yu-Chun Lin Signed-off-by: Yu-Chun Lin Signed-off-by: Kuan-Wei Chiu --- drivers/net/ethernet/oa_tc6.c | 19 +++---------------- 1 file changed, 3 insertions(+), 16 deletions(-) diff --git a/drivers/net/ethernet/oa_tc6.c b/drivers/net/ethernet/oa_tc6.c index db200e4ec284..f02dba7b89a1 100644 --- a/drivers/net/ethernet/oa_tc6.c +++ b/drivers/net/ethernet/oa_tc6.c @@ -6,6 +6,7 @@ */ #include +#include #include #include #include @@ -177,19 +178,6 @@ static int oa_tc6_spi_transfer(struct oa_tc6 *tc6, return spi_sync(tc6->spi, &msg); } -static int oa_tc6_get_parity(u32 p) -{ - /* Public domain code snippet, lifted from - * http://www-graphics.stanford.edu/~seander/bithacks.html - */ - p ^= p >> 1; - p ^= p >> 2; - p = (p & 0x11111111U) * 0x11111111U; - - /* Odd parity is used here */ - return !((p >> 28) & 1); -} - static __be32 oa_tc6_prepare_ctrl_header(u32 addr, u8 length, enum oa_tc6_register_op reg_op) { @@ -202,7 +190,7 @@ static __be32 oa_tc6_prepare_ctrl_header(u32 addr, u8 length, FIELD_PREP(OA_TC6_CTRL_HEADER_ADDR, addr) | FIELD_PREP(OA_TC6_CTRL_HEADER_LENGTH, length - 1); header |= FIELD_PREP(OA_TC6_CTRL_HEADER_PARITY, - oa_tc6_get_parity(header)); + !parity32(header)); return cpu_to_be32(header); } @@ -940,8 +928,7 @@ static __be32 oa_tc6_prepare_data_header(bool data_valid, bool start_valid, FIELD_PREP(OA_TC6_DATA_HEADER_END_BYTE_OFFSET, end_byte_offset); - header |= FIELD_PREP(OA_TC6_DATA_HEADER_PARITY, - oa_tc6_get_parity(header)); + header |= FIELD_PREP(OA_TC6_DATA_HEADER_PARITY, !parity32(header)); return cpu_to_be32(header); } From patchwork Sun Feb 23 16:42:12 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kuan-Wei Chiu X-Patchwork-Id: 867786 Received: from mail-pj1-f42.google.com (mail-pj1-f42.google.com [209.85.216.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 147D7209F52; Sun, 23 Feb 2025 16:45:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.42 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740329106; cv=none; b=t6iQcEDrvoTrhIadD8lJkO2fUraZcLTkck85/+vemiMD3uKKwZjtJTvA5648s+WuPM8yPehIqPxKKWJ4ct4yikiuRLAChNdibo6v/STkUzL2qRRlk7QtM238RycKy14BcE5kePFiDaQzsE9qiU0Eq8qfgqRR905EsDZxFCIcBqo= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740329106; c=relaxed/simple; bh=TwYwZvCrklNfcmQ95nA9Xu2F+v+lRRPBTM6pl81qOZE=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=N2sWytL9Bksbl4MTRYAdNQ5SkkG4uERxPVLEsV7ECrCHCwbSnuMBrMQFW7jm1O1rAlXSCrGN6J4Mc4veBFGsXEYmO43LdgUuoBjJXtcp4id6Jt/LxcfJ8tYO+LSPsR8J6a7Exljo+0sAHYLuhhyh4ztLyY0W76v2VajSO/hOK4Y= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=WJrRDO4H; arc=none smtp.client-ip=209.85.216.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="WJrRDO4H" Received: by mail-pj1-f42.google.com with SMTP id 98e67ed59e1d1-2fcce9bb0ecso7231962a91.3; Sun, 23 Feb 2025 08:45:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1740329104; x=1740933904; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=HQRFKAla41Ay10wYFnrS+X/WAyPF0gKgODKhC/FC/AE=; b=WJrRDO4HwGn1ZbY5wFm3Tq38zpYftE+Y3tkiAGJsV7pKU/czwr+UfVg/uNFacEELDA KNyHEX0lYtuBx8KmMBaaw+vfEuNbgBvNWvQ6w2qge5IfSmEl9D7slkaGD0mWFEgAVSbV VyM99H48P/JvlPd/Vw9g183RePBp0XNuL7FE2uKk4OXmII2Y115xb/1gHPSt4gGRXBtS dUhpEtjnE1bVgWs0LnKoV5Ua4CkbePvbXCYrDCjEEDM5ryFVvOKHS1Js+kujfDpO6mPm hOZjmSMskwTEmWlCAjiYhVUmn5KgN+v1muo2gUsjkY5mSd0VgLMlOm96XYE5K5zqaUtB GYKw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1740329104; x=1740933904; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=HQRFKAla41Ay10wYFnrS+X/WAyPF0gKgODKhC/FC/AE=; b=FcG1wJ2EB4qQazt58TiHedsFLTWwRbes5wDhhxvNSLHLrDuMDFd7p82rwggV2LgrO6 kuhUhZdmQNIq2+G/WlTRVkUb8bsvwi+LzDdd/NXM5TYBpTZyTmSZ3wbqEGVrtk8XK0I5 8rV3BwptjM0yZZPswqMul3IDhNFbN+efDDBNMkw3IwCSMU4iXA08EnISrRLsWu3qJj7v Kj8RgLXkbCxi1W/sSnhJw/zmRysryoT6SyLQhDVpgzdMWuqoS+rWvsfBE55I5dP0K8ZD IMLyS/biQjZsQ/PzRnH5VA3qY6hN/iREjXNQWKntF4PgN7AEgM5BRHLXGSzPW6bSZKh6 DL1w== X-Forwarded-Encrypted: i=1; AJvYcCUu8yHzO1pXoP+l2ElT40uAaRKK0EusGJpkwGZ1/eyu6zQXeGLUO66XTTOa//8hfwNcet3evX43OhIUXUQ=@vger.kernel.org, AJvYcCVh0VPfD33lnFTAmim6cr9rQDL3TyHaM+ztP3yuRGHNK2AWQHccS3P78ytI7Ar84Z61fFCfbxK4vn7+zwA=@vger.kernel.org, AJvYcCViOgQ7BkC6KsmEWwkBUZWta3E4QmuCXUMLP6/5jd9JrOK84AX/w5WSNjszXP0SJPPokms5/vU+eMIo/NrZ@vger.kernel.org, AJvYcCVpldCENwX8uGAIUTT6oDIMCj026OKc1PSuRBqPpjlQit7upspLe4M2ztm2Pn+FtYNpVeI=@vger.kernel.org, AJvYcCWCTAsUxtm/Ck1ZcNVoe8+iHi5Fl1nCK9W2rCyaoXBgGOzqFFtDt7Si1UzheYVnBzeLODQjtEWz80ai74Lb9yg=@vger.kernel.org, AJvYcCWbUrD2XRBuBqK70efe5/cPWQrbRlTll6iFJV2QK4JFNI0tm3AVwL2GcWiW0Bd/0ZphEDDLUnppOG6hfF6k@vger.kernel.org, AJvYcCX/56P0qRkLWWbdixhr72ip8PflClQvlOd1viMpn2VHsJ8hJKp8vg82RtAxysiBmjZ+1lSo2Kmt@vger.kernel.org X-Gm-Message-State: AOJu0YzC/zSJYG9db96yeiW/p8SQgUcTsXciW+V/jB4Igq5ECSxCH+gD jRKizmGxEKAVMoFfdPS1HrLy/4g4x/pFlg0GwDiNZ8GQ8pEYlXjv X-Gm-Gg: ASbGncuTydqelhzyEFXc+mr+PV1G2HIH5umt18oanO9xfM3XZz3jLhAuWI6DH0zvAVb e6bPml7B0WhRcvRAVy8Hios+BOnvHXiRHZoZAfCML05QrlQNmEQA7OKAnye/AsHIYfoxXyCi0vk ieq2O3cBvEXltqg52JJyK5zxAHUXsl0Oly/aFavvunTJ3E9hG5edgaU1PKMJYJ2rEF9fKIcTBoz rSj5+O2lgpZAGrZE/HoJpkQI5bNpzccP3dI1BiNuHEadcGxrXChsrcn3gzk8DIn4eRa4Adjukcv iVLtt+3VXapdvWTh4T5RfwJ3/K4ygPbZS75Nb41ydV7SyzdCiGmFzNb2 X-Google-Smtp-Source: AGHT+IGJMVNjh2ZkbH600/jnGa2+6i7gpIXMvZAnEqRCXvTYi+XMSGJQL5WK3aQh+mNtGiJ0yE3iuQ== X-Received: by 2002:a17:90b:2590:b0:2ee:df70:1ff3 with SMTP id 98e67ed59e1d1-2fce75e1b18mr21089922a91.0.1740329104301; Sun, 23 Feb 2025 08:45:04 -0800 (PST) Received: from visitorckw-System-Product-Name.. ([140.113.216.168]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-2fceb09f6e0sm4935080a91.44.2025.02.23.08.44.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 23 Feb 2025 08:45:03 -0800 (PST) From: Kuan-Wei Chiu To: tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, dave.hansen@linux.intel.com, x86@kernel.org, jk@ozlabs.org, joel@jms.id.au, eajames@linux.ibm.com, andrzej.hajda@intel.com, neil.armstrong@linaro.org, rfoss@kernel.org, maarten.lankhorst@linux.intel.com, mripard@kernel.org, tzimmermann@suse.de, airlied@gmail.com, simona@ffwll.ch, dmitry.torokhov@gmail.com, mchehab@kernel.org, awalls@md.metrocast.net, hverkuil@xs4all.nl, miquel.raynal@bootlin.com, richard@nod.at, vigneshr@ti.com, louis.peens@corigine.com, andrew+netdev@lunn.ch, davem@davemloft.net, edumazet@google.com, pabeni@redhat.com, parthiban.veerasooran@microchip.com, arend.vanspriel@broadcom.com, johannes@sipsolutions.net, gregkh@linuxfoundation.org, jirislaby@kernel.org, yury.norov@gmail.com, akpm@linux-foundation.org Cc: hpa@zytor.com, alistair@popple.id.au, linux@rasmusvillemoes.dk, Laurent.pinchart@ideasonboard.com, jonas@kwiboo.se, jernej.skrabec@gmail.com, kuba@kernel.org, linux-kernel@vger.kernel.org, linux-fsi@lists.ozlabs.org, dri-devel@lists.freedesktop.org, linux-input@vger.kernel.org, linux-media@vger.kernel.org, linux-mtd@lists.infradead.org, oss-drivers@corigine.com, netdev@vger.kernel.org, linux-wireless@vger.kernel.org, brcm80211@lists.linux.dev, brcm80211-dev-list.pdl@broadcom.com, linux-serial@vger.kernel.org, bpf@vger.kernel.org, jserv@ccns.ncku.edu.tw, Kuan-Wei Chiu , Yu-Chun Lin Subject: [PATCH 12/17] drm/bridge: dw-hdmi: Replace open-coded parity calculation with parity32() Date: Mon, 24 Feb 2025 00:42:12 +0800 Message-Id: <20250223164217.2139331-13-visitorckw@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20250223164217.2139331-1-visitorckw@gmail.com> References: <20250223164217.2139331-1-visitorckw@gmail.com> Precedence: bulk X-Mailing-List: linux-input@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Refactor parity calculations to use the standard parity32() helper. This change eliminates redundant implementations and improves code efficiency. Co-developed-by: Yu-Chun Lin Signed-off-by: Yu-Chun Lin Signed-off-by: Kuan-Wei Chiu --- drivers/gpu/drm/bridge/synopsys/dw-hdmi-ahb-audio.c | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/drivers/gpu/drm/bridge/synopsys/dw-hdmi-ahb-audio.c b/drivers/gpu/drm/bridge/synopsys/dw-hdmi-ahb-audio.c index cf1f66b7b192..833e65f33483 100644 --- a/drivers/gpu/drm/bridge/synopsys/dw-hdmi-ahb-audio.c +++ b/drivers/gpu/drm/bridge/synopsys/dw-hdmi-ahb-audio.c @@ -4,6 +4,7 @@ * * Written and tested against the Designware HDMI Tx found in iMX6. */ +#include #include #include #include @@ -171,12 +172,7 @@ static void dw_hdmi_reformat_iec958(struct snd_dw_hdmi *dw, static u32 parity(u32 sample) { - sample ^= sample >> 16; - sample ^= sample >> 8; - sample ^= sample >> 4; - sample ^= sample >> 2; - sample ^= sample >> 1; - return (sample & 1) << 27; + return parity32(sample) << 27; } static void dw_hdmi_reformat_s24(struct snd_dw_hdmi *dw, From patchwork Sun Feb 23 16:42:14 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kuan-Wei Chiu X-Patchwork-Id: 867785 Received: from mail-pl1-f171.google.com (mail-pl1-f171.google.com [209.85.214.171]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9294E148855; Sun, 23 Feb 2025 16:45:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.171 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740329127; cv=none; b=Pmvi5MGs4CGqcDqIgUQrmYX9SkeT/230+jcWfKGl/hlA6SeOdqw4dP6oUXQM0Kr+9j0sbTuo7gdqKrIZ+2bHa1SYswZkFlVqFqefYSpxQq9eLsGbhxdrr55icEguNLxKMOCYyfgBRG5xsCUcHbVXQ+y8G0KfPvuDVmqMP1fPbOQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740329127; c=relaxed/simple; bh=6rZCyADuBKXQMtzY8frtZm7r8BeFGku217x/vpm4MWM=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=Rxop20NNpPU8ixfZwn/UlNae0TyDyjd1mfIVYo0t5LCKzkGM4dE5lPfGgSvt8dKGQzkdKy1KxneYa6ouiHqTdqOVb67nQm9v1gU5fCCHZtI2oH4P123aYomEk8EBAjkT7fu/LoR6Bfvi5uwETNvNncxGYmoXBIILuyQGk3J+n40= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=JfTCDukj; arc=none smtp.client-ip=209.85.214.171 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="JfTCDukj" Received: by mail-pl1-f171.google.com with SMTP id d9443c01a7336-220c8f38febso75266735ad.2; Sun, 23 Feb 2025 08:45:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1740329125; x=1740933925; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=gCIStMwChzl4Z+E/b6UIovNeeE8MF3lkiK/lI/bZwfc=; b=JfTCDukjbBJT2W7yVzFjj7T5q5uqZ8dNgk03wchMdovW4zRrsFDdELrLB018HphpSs wAOCZ3/+QK2JmHebMj8B/VV7iYFbr8K0BW2skZ9qUepvjKIFnk0Wd8/RRS/UJmM96Ma6 Ew4RWH1ONzd61W8qkSb9otoeRi3itPB+zcEj015gfIYDEfHGqRuQMXi26F6TjCodppRG Mobgap2eGKVcLw/saDIZ9kEuXcyG2Zj9eDEkjtOflvOrWOORViZ+K1MxFXQFLxkFKzZP DphC9t4bUhNREtZa1/XNiSDObl4F7xLW2s6RPqaxFhB6athUu/+nPfDVTfVznBIXW+WN An8Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1740329125; x=1740933925; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=gCIStMwChzl4Z+E/b6UIovNeeE8MF3lkiK/lI/bZwfc=; b=O+AsickG588ekk1DfchWmstTOp7LGGvffQBxSxfwRiRWqjYtQup19MZagKzwPt4dfA j7qGdyFtnWqSih0wTfK5MyJXmXTx1fm4/vxq79OjverW1XsHyAqa6Y6qj9V3GQOcG4HL /Woz/5pqGhzSqbKOhQJNTo+i6JRVHOUj2mzyi5pVK2m0iNU0XI4M0y1WnsszvU8rVJ+x IScoVxnz0735EvmZ1OTjt1mYLKdqxmP+RD1g0EBuFcJntpowEk1GqbzeYcCAkaLnDMTJ mYyKkWmfWqsf2oQjqR19+hlgMzi+DNEMDIp8EwyXGp98aFuOymNneFX5d/4gaK1rQ0sZ 6Elg== X-Forwarded-Encrypted: i=1; AJvYcCUaUgm/NCP94l6rc3MpOumO6RLjkC6k3TD2x1UT3fpWc6GB1s2LOdBvLbZR7mYjcXAShZoqSopLdG6I/aTG@vger.kernel.org, AJvYcCUgyn53jMNLGciRl0bYm1mzhGaevpXZU8+yugO+6HUs7o9WpzMRYTdOXX70XjzcddNpE8ndm6BrSdf29xY=@vger.kernel.org, AJvYcCVi99Ah7MezQVwGFIzRBb/3iHsReiGaUJROqzZQZ9q4Uv2P5yLooIJEnBZJHVkf23vhni7nmAaeZ6NiLJs=@vger.kernel.org, AJvYcCW55LzFs6Rr0EYhmbbB4M/AQ2GDAx9KGdhnCM6hAt4UAhlNBnsae1owj4nYRntEZRBDVl6H9GwP@vger.kernel.org, AJvYcCXlWjHjJFAXiUZh76rkN+AEsJUDqh0E1ugDI9xKIBUM8Rb+i5E4UZto5maJM4W2bTeQeQ69lYqWPDi5VOzO@vger.kernel.org, AJvYcCXmibcnZvtT3iKJHL8gPQ0N8aRXquRNt3TdFrOmvAbms8i+RbYQzZ5RYvyYNbXZahtcRPuQjY0/zCXi5Z4t1GA=@vger.kernel.org, AJvYcCXwqpDjZqU2cebCLCZADoHyyVZyCu+BPTarAvGiX94cIJxboeHqAFr8Ll0yZP+NTmA5Ci0=@vger.kernel.org X-Gm-Message-State: AOJu0YyXtEN/NpR1jyyd2WFsOtcZule4yzMoRrJtdz16lgZBJs+5cxuT t1VB1OzKkJBaaYIS7aEw5K8aK8NpPPl3j6w5QAPG1B0fEvI/M3aQ X-Gm-Gg: ASbGnctlwlrbhc0HTXGUZDh3rXN/ZkFdFJXYCO641cqEo2CWlhGwqBIT6kHIS1ILwCi Yf0FIqfvvPTKjEHbaUNuskaRWI2YUPBTYI0Qtdh+9XtC8Fq39G+hW/2HHAflxlEeSeMByR3IacX Fbon/z0RgI+FbnN7oWm6WqdTDrySzeKEy+AVSZGr72aw1ux5riZBpd2u8apm7Ov5x5EtRH1d/rI xdRQudSI3I894Atuw4YbUptWR5E0PXIrh7i/AGnZENZGE4wmw/FlwVwF25jKYR7t5dBBi+j3aV0 TVMKbmU3C4/z2toA4jHqoYmtSUw5runwxDSumOhPL7ziV9ctuTUhm7OZ X-Google-Smtp-Source: AGHT+IFs3TQ1rSxmmbPXVRsSl3rqDEDcDSV6UQtHXLRs1szh2ELiA6tHTHYs6po5Gu/F9oStBVoG9Q== X-Received: by 2002:a17:90b:4fc9:b0:2ee:dd79:e046 with SMTP id 98e67ed59e1d1-2fce78a3738mr17084857a91.13.1740329124995; Sun, 23 Feb 2025 08:45:24 -0800 (PST) Received: from visitorckw-System-Product-Name.. ([140.113.216.168]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-2fceb09f6e0sm4935080a91.44.2025.02.23.08.45.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 23 Feb 2025 08:45:24 -0800 (PST) From: Kuan-Wei Chiu To: tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, dave.hansen@linux.intel.com, x86@kernel.org, jk@ozlabs.org, joel@jms.id.au, eajames@linux.ibm.com, andrzej.hajda@intel.com, neil.armstrong@linaro.org, rfoss@kernel.org, maarten.lankhorst@linux.intel.com, mripard@kernel.org, tzimmermann@suse.de, airlied@gmail.com, simona@ffwll.ch, dmitry.torokhov@gmail.com, mchehab@kernel.org, awalls@md.metrocast.net, hverkuil@xs4all.nl, miquel.raynal@bootlin.com, richard@nod.at, vigneshr@ti.com, louis.peens@corigine.com, andrew+netdev@lunn.ch, davem@davemloft.net, edumazet@google.com, pabeni@redhat.com, parthiban.veerasooran@microchip.com, arend.vanspriel@broadcom.com, johannes@sipsolutions.net, gregkh@linuxfoundation.org, jirislaby@kernel.org, yury.norov@gmail.com, akpm@linux-foundation.org Cc: hpa@zytor.com, alistair@popple.id.au, linux@rasmusvillemoes.dk, Laurent.pinchart@ideasonboard.com, jonas@kwiboo.se, jernej.skrabec@gmail.com, kuba@kernel.org, linux-kernel@vger.kernel.org, linux-fsi@lists.ozlabs.org, dri-devel@lists.freedesktop.org, linux-input@vger.kernel.org, linux-media@vger.kernel.org, linux-mtd@lists.infradead.org, oss-drivers@corigine.com, netdev@vger.kernel.org, linux-wireless@vger.kernel.org, brcm80211@lists.linux.dev, brcm80211-dev-list.pdl@broadcom.com, linux-serial@vger.kernel.org, bpf@vger.kernel.org, jserv@ccns.ncku.edu.tw, Kuan-Wei Chiu , Yu-Chun Lin Subject: [PATCH 14/17] fsi: i2cr: Replace open-coded parity calculation with parity32() Date: Mon, 24 Feb 2025 00:42:14 +0800 Message-Id: <20250223164217.2139331-15-visitorckw@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20250223164217.2139331-1-visitorckw@gmail.com> References: <20250223164217.2139331-1-visitorckw@gmail.com> Precedence: bulk X-Mailing-List: linux-input@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Refactor parity calculations to use the standard parity32() helper. This change eliminates redundant implementations and improves code efficiency. Co-developed-by: Yu-Chun Lin Signed-off-by: Yu-Chun Lin Signed-off-by: Kuan-Wei Chiu --- drivers/fsi/fsi-master-i2cr.c | 10 ++-------- 1 file changed, 2 insertions(+), 8 deletions(-) diff --git a/drivers/fsi/fsi-master-i2cr.c b/drivers/fsi/fsi-master-i2cr.c index 40f1f4d231e5..8212b99ab2f9 100644 --- a/drivers/fsi/fsi-master-i2cr.c +++ b/drivers/fsi/fsi-master-i2cr.c @@ -1,6 +1,7 @@ // SPDX-License-Identifier: GPL-2.0 /* Copyright (C) IBM Corporation 2023 */ +#include #include #include #include @@ -38,14 +39,7 @@ static const u8 i2cr_cfam[] = { static bool i2cr_check_parity32(u32 v, bool parity) { - u32 i; - - for (i = 0; i < 32; ++i) { - if (v & (1u << i)) - parity = !parity; - } - - return parity; + return parity ^ parity32(v); } static bool i2cr_check_parity64(u64 v) From patchwork Sun Feb 23 16:42:16 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kuan-Wei Chiu X-Patchwork-Id: 867784 Received: from mail-pj1-f52.google.com (mail-pj1-f52.google.com [209.85.216.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B9BB6137930; Sun, 23 Feb 2025 16:45:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.52 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740329150; cv=none; b=sMjG86hZ5lDwKeHYpc/tOGsq3SYTStzQzzgbPF0kNQM7I0lw+uCSbn6qgf1ObssRVDrHMNvn6LLjColZHAwjjiChkoe0/+KCdYhWoDZ+E3fdID5GPa8T0C/Ahty6XFeac9ZfRZNP6CK0vrmsW5JS3lCawfq10mgYoRLFo6if74E= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740329150; c=relaxed/simple; bh=AY7VWX2z+11go+VbveW5z1yOms0/k4EYUoJbq8u7HBw=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=adpufmmXG8C3XdI+e8/g/3QT8UWr32r7d3jiDZ22GmARMOC4mB6IJXfXRQpneC4Z6qu/ENO/iWEJii9Sw/EXwXpeQr39OQB7HETXlRyiwRL73LPhDHt6w8T90yycsINGLU4OrrGGgB1NvGph7o/v7I66LbtK5C6VN4IC2OYZIZw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=g8AppjX1; arc=none smtp.client-ip=209.85.216.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="g8AppjX1" Received: by mail-pj1-f52.google.com with SMTP id 98e67ed59e1d1-2fa8ac56891so5837975a91.2; Sun, 23 Feb 2025 08:45:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1740329148; x=1740933948; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=rykqQnwPkGRFwR5KILLeuUxXhWjh1d/Lo2VO4W9LQtQ=; b=g8AppjX1q7orQDA+2QKzU3q7cWnXKqgNb0wIbRdzynsL5tsiw8tseGPc26/YAWKwQW gpyfFFt77Jxih32U1zytNghaN+NkZLdXbzZgjiNJJpiKhzAxHIywImsNbrjGEZN0l9iS ss+dnkXKn1NnFjh/oyBB6FJz49L0dYBiSppy0lHVWMGIf7CzSE8KJ382KbHfsOxDySYH h/oHNjtdoMWVWz4RriaMY42Xk5abn0rd2c/XjZy7JBzfazux74dnzzGxkvr9c2xBSQMQ tBHce7g8v/7UGy7hEw0JSBmei0pmnVpGW43jM0IJcv5YIo4GDjH8ccCdinu680tmuf2z kWmA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1740329148; x=1740933948; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=rykqQnwPkGRFwR5KILLeuUxXhWjh1d/Lo2VO4W9LQtQ=; b=c9Hj8ATAU9JOCi1wfP/st6dQhwgCmWyGiwTjfAzm6BwfDunvZAB5ZyABbNbqohJfNw hjI2+3veGR0D3eQwj44As64PdH3yxp6JMDY+naZeG0BFjsrtpR0VUgpR1Roy08aBqXDY xnoZTtVZHNzyuaoOweOdAYXWvJNwG6gRtloxWOV3CPsza400Rwf8XKp8Mk27TUUvVdpF rLmBYsuqW0abEBnNuVlYJlsZV+cNHDldKZxZZn+YO+qZkYL6dc50NjkJ1vE01saylCht ksZ9VIOCqtIdaC6/+TUgQrpaxSeYT6Bof9D79ZuXDTm0zSS77NHB9NcthrMDJNr9o19S 881w== X-Forwarded-Encrypted: i=1; AJvYcCU35m9qzcX/gJX9mKiHpZYjI+846ytMaEt9bpd3vubk1oqBre+PAgOwJU4+g9SyHwSN5BXoWucm@vger.kernel.org, AJvYcCURuXKfFqgS4ngPhla33efARqpxb15U8lcK/tjbR4+uf2baJRL5q7rUaN4kzOv7Z0rnDteI76ykkWnRTwc=@vger.kernel.org, AJvYcCVbw20TAQTMJC+Y0btKxAAthvvV+57A4P4fj/3ICDffKkAPc+Df+yJfMnuH/1jTDLyrTWI=@vger.kernel.org, AJvYcCVq2bydlecAZYAFkpsCqipRqm515D/y+JLAtKi3FHy+KjrWAcrHGwdooyfRTYPaMrABO5Fxr2QqASbDeAk=@vger.kernel.org, AJvYcCWJiFv35jBPq8WW9o8/Coa/VTaKaCojxlMGd//niWRgoY+9ObyZJNVx2OWtBWeWZh5D0TRzQhbfhF7R9453@vger.kernel.org, AJvYcCX6YNFdtLYBoJY1wQMyV1D/b2g5xylM2KgQFdvPF+HRMJzWwVyQZxy/ZqSl6OCRGw6wK6rplT2ngUpTKs3K@vger.kernel.org, AJvYcCXpPh5qVHV6cqRgxGXlhzRc1uLCXsBWfMiH9SLRfTbG/1zpSeyqzsL7i/GMpmR7oRxJxiyTKrMaeoaDjSWhPgw=@vger.kernel.org X-Gm-Message-State: AOJu0Yxa7ogc5cXaB24k8UUMzJR8PZd1joNMpVKxS3A6vkqdqaoQWxrX q06IoPUmcui+FKuOXwgElrNR7D9Lu+S0zwPWaROPlhF+eoVEQWiu X-Gm-Gg: ASbGncue435tB+uzrGzQ+M6U/FRUBUztXnnvxtHQJImnN1aP0O5eMFaNZ0CEGF5+bqd 0owCpuDy4E+6H9zTZpuud7KYaoPhsiSW+RWJVyzq+UmD2I/b8Hbdo47ugL3ehcqUNS4Bol22b24 hyawPXOXcTjHdR8l56Cyr9Z41JIk3U8ret7+qq5TUionyqwUMK+1ozcALmBcO442Yxczqi6qLHB HP2apy5hfG7oYbJ5FPRhk609byF0r2deyCXkCq6KrsZLJ+9KxcWeMoAwGhO6r6+jva1cw7Arhq7 W7tDciTXhIeXlbA2NRnRqhXEvNFKZ+AJgtS1PgiBFjj8OeTpUyfj+6C1 X-Google-Smtp-Source: AGHT+IH16ghKmcmHU0dMEzazIh6n32euSF7ezcTZFrtw55Mtl4npk2uitkdtvmkXgShJlJHnv8p1XQ== X-Received: by 2002:a17:90b:3c03:b0:2fa:12be:f16a with SMTP id 98e67ed59e1d1-2fce7b43488mr17785880a91.29.1740329147892; Sun, 23 Feb 2025 08:45:47 -0800 (PST) Received: from visitorckw-System-Product-Name.. ([140.113.216.168]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-2fceb09f6e0sm4935080a91.44.2025.02.23.08.45.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 23 Feb 2025 08:45:47 -0800 (PST) From: Kuan-Wei Chiu To: tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, dave.hansen@linux.intel.com, x86@kernel.org, jk@ozlabs.org, joel@jms.id.au, eajames@linux.ibm.com, andrzej.hajda@intel.com, neil.armstrong@linaro.org, rfoss@kernel.org, maarten.lankhorst@linux.intel.com, mripard@kernel.org, tzimmermann@suse.de, airlied@gmail.com, simona@ffwll.ch, dmitry.torokhov@gmail.com, mchehab@kernel.org, awalls@md.metrocast.net, hverkuil@xs4all.nl, miquel.raynal@bootlin.com, richard@nod.at, vigneshr@ti.com, louis.peens@corigine.com, andrew+netdev@lunn.ch, davem@davemloft.net, edumazet@google.com, pabeni@redhat.com, parthiban.veerasooran@microchip.com, arend.vanspriel@broadcom.com, johannes@sipsolutions.net, gregkh@linuxfoundation.org, jirislaby@kernel.org, yury.norov@gmail.com, akpm@linux-foundation.org Cc: hpa@zytor.com, alistair@popple.id.au, linux@rasmusvillemoes.dk, Laurent.pinchart@ideasonboard.com, jonas@kwiboo.se, jernej.skrabec@gmail.com, kuba@kernel.org, linux-kernel@vger.kernel.org, linux-fsi@lists.ozlabs.org, dri-devel@lists.freedesktop.org, linux-input@vger.kernel.org, linux-media@vger.kernel.org, linux-mtd@lists.infradead.org, oss-drivers@corigine.com, netdev@vger.kernel.org, linux-wireless@vger.kernel.org, brcm80211@lists.linux.dev, brcm80211-dev-list.pdl@broadcom.com, linux-serial@vger.kernel.org, bpf@vger.kernel.org, jserv@ccns.ncku.edu.tw, Kuan-Wei Chiu , Yu-Chun Lin Subject: [PATCH 16/17] Input: joystick - Replace open-coded parity calculation with parity64() Date: Mon, 24 Feb 2025 00:42:16 +0800 Message-Id: <20250223164217.2139331-17-visitorckw@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20250223164217.2139331-1-visitorckw@gmail.com> References: <20250223164217.2139331-1-visitorckw@gmail.com> Precedence: bulk X-Mailing-List: linux-input@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Refactor parity calculations to use the standard parity64() helper. This change eliminates redundant implementations and improves code efficiency. Co-developed-by: Yu-Chun Lin Signed-off-by: Yu-Chun Lin Signed-off-by: Kuan-Wei Chiu --- drivers/input/joystick/sidewinder.c | 24 +++++------------------- 1 file changed, 5 insertions(+), 19 deletions(-) diff --git a/drivers/input/joystick/sidewinder.c b/drivers/input/joystick/sidewinder.c index 3a5873e5fcb3..9fe980096f70 100644 --- a/drivers/input/joystick/sidewinder.c +++ b/drivers/input/joystick/sidewinder.c @@ -7,6 +7,7 @@ * Microsoft SideWinder joystick family driver for Linux */ +#include #include #include #include @@ -240,21 +241,6 @@ static void sw_init_digital(struct gameport *gameport) local_irq_restore(flags); } -/* - * sw_parity() computes parity of __u64 - */ - -static int sw_parity(__u64 t) -{ - int x = t ^ (t >> 32); - - x ^= x >> 16; - x ^= x >> 8; - x ^= x >> 4; - x ^= x >> 2; - x ^= x >> 1; - return x & 1; -} /* * sw_ccheck() checks synchronization bits and computes checksum of nibbles. @@ -316,7 +302,7 @@ static int sw_parse(unsigned char *buf, struct sw *sw) for (i = 0; i < sw->number; i ++) { - if (sw_parity(GB(i*15,15))) + if (parity64(GB(i*15,15))) return -1; input_report_abs(sw->dev[i], ABS_X, GB(i*15+3,1) - GB(i*15+2,1)); @@ -333,7 +319,7 @@ static int sw_parse(unsigned char *buf, struct sw *sw) case SW_ID_PP: case SW_ID_FFP: - if (!sw_parity(GB(0,48)) || (hat = GB(42,4)) > 8) + if (!parity64(GB(0,48)) || (hat = GB(42,4)) > 8) return -1; dev = sw->dev[0]; @@ -354,7 +340,7 @@ static int sw_parse(unsigned char *buf, struct sw *sw) case SW_ID_FSP: - if (!sw_parity(GB(0,43)) || (hat = GB(28,4)) > 8) + if (!parity64(GB(0,43)) || (hat = GB(28,4)) > 8) return -1; dev = sw->dev[0]; @@ -379,7 +365,7 @@ static int sw_parse(unsigned char *buf, struct sw *sw) case SW_ID_FFW: - if (!sw_parity(GB(0,33))) + if (!parity64(GB(0,33))) return -1; dev = sw->dev[0];