From patchwork Sat Feb 8 16:30:03 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Thomas_Wei=C3=9Fschuh?= X-Patchwork-Id: 863509 Received: from todd.t-8ch.de (todd.t-8ch.de [159.69.126.157]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 647CB190058; Sat, 8 Feb 2025 16:30:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=159.69.126.157 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739032225; cv=none; b=Mh0+DrrBBCUr60LM9+Cn8nfqhjcX6ky8nYjtRsCfuiJLgKjJqssp/+2/hKmtQbiFWnI6kOdd1MdySxQUiR0+9KkvukUsfkzmmyneNxSdB85HzENT9bxqvws53r2q25xsEOE4mL173aueluJUBPVq9RF6YlazuDx60oMbGBVQ6e0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739032225; c=relaxed/simple; bh=sYRKMT0vGlnOGYLve/adGBTos+uJOf24RZ51165VgKE=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=HO8zrZBRCLHdeO3pfRG3/FbFnfVxHCXutO3ggqLn+osQl0m43BEvCywj5xt9DeUN3QY4bK1DHc1Ri9WD9WS9uRuL6vQVcsBEcqZc6lGTHbrUwfo3kBC/jKzkAm3+5M5fyfme6mhRbsh3r3xUmIsrguMsgCiJkX9IJQkULZaI6o0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=weissschuh.net; spf=pass smtp.mailfrom=weissschuh.net; dkim=pass (1024-bit key) header.d=weissschuh.net header.i=@weissschuh.net header.b=km/7xp1c; arc=none smtp.client-ip=159.69.126.157 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=weissschuh.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=weissschuh.net Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=weissschuh.net header.i=@weissschuh.net header.b="km/7xp1c" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=weissschuh.net; s=mail; t=1739032220; bh=sYRKMT0vGlnOGYLve/adGBTos+uJOf24RZ51165VgKE=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=km/7xp1cFfR9NSoY3z5kaC7HUs+YiojI38gCnAIjepfiDD5je2niXMa5Uk91s3jT2 4QAVe8BxZ2DXtcg1Jmb3Hi/pXqYV2gZ/db0/S33OcZZxzEX1qo1H/tcKcxgl8mGq85 iv/izZHLtsR+bebZ5A7VEgKVvJGalr7f5CbjY6/s= From: =?utf-8?q?Thomas_Wei=C3=9Fschuh?= Date: Sat, 08 Feb 2025 17:30:03 +0100 Subject: [PATCH v3 1/2] leds: st1202: Check for error code from devm_mutex_init() call Precedence: bulk X-Mailing-List: linux-leds@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20250208-must_check-devm_mutex_init-v3-1-245e417dcc9e@weissschuh.net> References: <20250208-must_check-devm_mutex_init-v3-0-245e417dcc9e@weissschuh.net> In-Reply-To: <20250208-must_check-devm_mutex_init-v3-0-245e417dcc9e@weissschuh.net> To: Peter Zijlstra , Ingo Molnar , Will Deacon , Waiman Long , Boqun Feng , Pavel Machek , Lee Jones , Vicentiu Galanopulo Cc: Andy Shevchenko , linux-kernel@vger.kernel.org, linux-leds@vger.kernel.org, =?utf-8?q?Thomas?= =?utf-8?q?_Wei=C3=9Fschuh?= X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1739032220; l=973; i=linux@weissschuh.net; s=20221212; h=from:subject:message-id; bh=sYRKMT0vGlnOGYLve/adGBTos+uJOf24RZ51165VgKE=; b=tQeWG+KIeTmjQPrjsXBwafB/SalYFnXx5cABMiVr33xT+6nAHRklD75bDSCkD43a+Y4cqIuC6 PvhnuU0fibKCn8ioaqcZ8g0yqpxsAgD7+UmQH4JFxn+0KAwoGHXuNkh X-Developer-Key: i=linux@weissschuh.net; a=ed25519; pk=KcycQgFPX2wGR5azS7RhpBqedglOZVgRPfdFSPB1LNw= Even if it's not critical, the avoidance of checking the error code from devm_mutex_init() call today diminishes the point of using devm variant of it. Tomorrow it may even leak something. Add the missed check. Fixes: 259230378c65 ("leds: Add LED1202 I2C driver") Signed-off-by: Thomas Weißschuh --- drivers/leds/leds-st1202.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/leds/leds-st1202.c b/drivers/leds/leds-st1202.c index b691c4886993f3e371e857543863c9a724742f39..657c62cb24fa726622369fc965fa7195e73170f0 100644 --- a/drivers/leds/leds-st1202.c +++ b/drivers/leds/leds-st1202.c @@ -356,7 +356,9 @@ static int st1202_probe(struct i2c_client *client) if (!chip) return -ENOMEM; - devm_mutex_init(&client->dev, &chip->lock); + ret = devm_mutex_init(&client->dev, &chip->lock); + if (ret < 0) + return ret; chip->client = client; ret = st1202_dt_init(chip); From patchwork Sat Feb 8 16:30:04 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Thomas_Wei=C3=9Fschuh?= X-Patchwork-Id: 863510 Received: from todd.t-8ch.de (todd.t-8ch.de [159.69.126.157]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B75121F30BF; Sat, 8 Feb 2025 16:30:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=159.69.126.157 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739032224; cv=none; b=KrKMJ2wpgEH6znmAmlAvT7lZAcwuuNOUcwhCfJvUofXLMsCvtpAPyB32xES5YGCb/61VTFZ6D+yR7wNafpSOlhKT7TyvO+OngV6IFn1fvatHoo8S8PYXAv95vZ2SSJrpcv4QPil3reZ3q9rvaOjwDWx5YnGDfNz+9IYcrZsD7Vw= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739032224; c=relaxed/simple; bh=CaCYZdoznE8WXB+t4HNPsgCbCMDDiyEbSGnXkSMn6g8=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=G3XqCAxCgR50uWQrFqHZjrpvSaUGfqgJnIol/k7IQ7PwZMp8ZQRstFY3GRb4x2oRXTim/yZwvA0RKbC4XkbKtBd3md+hmMwF/wG3NFolOD4tcvphsQMZbXhXsqGjjarVkSr5uV5F5eI74F0V5XTlSisYvpdoTMDMHBk7yIY+auI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=weissschuh.net; spf=pass smtp.mailfrom=weissschuh.net; dkim=pass (1024-bit key) header.d=weissschuh.net header.i=@weissschuh.net header.b=btzsGsCk; arc=none smtp.client-ip=159.69.126.157 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=weissschuh.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=weissschuh.net Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=weissschuh.net header.i=@weissschuh.net header.b="btzsGsCk" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=weissschuh.net; s=mail; t=1739032220; bh=CaCYZdoznE8WXB+t4HNPsgCbCMDDiyEbSGnXkSMn6g8=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=btzsGsCkKjEIbxIsSJ24YcyNkyx8a1wyGV4gJyzf+IvG2MzjPEFuJmFxSXEH2U0Ip DlhKzBfeFOsWUnsY9a0rZPrHhA7sk5E+UTtgCTRdaTfoR3YB9M45yY7WXGHYxR772n kSkeUfQvaZ43A12mVABwc00sWINulKz6JeSvxcuU= From: =?utf-8?q?Thomas_Wei=C3=9Fschuh?= Date: Sat, 08 Feb 2025 17:30:04 +0100 Subject: [PATCH v3 2/2] locking/mutex: Mark devm_mutex_init() as __must_check Precedence: bulk X-Mailing-List: linux-leds@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20250208-must_check-devm_mutex_init-v3-2-245e417dcc9e@weissschuh.net> References: <20250208-must_check-devm_mutex_init-v3-0-245e417dcc9e@weissschuh.net> In-Reply-To: <20250208-must_check-devm_mutex_init-v3-0-245e417dcc9e@weissschuh.net> To: Peter Zijlstra , Ingo Molnar , Will Deacon , Waiman Long , Boqun Feng , Pavel Machek , Lee Jones , Vicentiu Galanopulo Cc: Andy Shevchenko , linux-kernel@vger.kernel.org, linux-leds@vger.kernel.org, =?utf-8?q?Thomas?= =?utf-8?q?_Wei=C3=9Fschuh?= X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1739032220; l=2032; i=linux@weissschuh.net; s=20221212; h=from:subject:message-id; bh=CaCYZdoznE8WXB+t4HNPsgCbCMDDiyEbSGnXkSMn6g8=; b=0ZxN+2uSZvaFdCeSXX5kVzhUxZVR9ll2dqmtVANSNQIw2rGkOw9DGeuBvPeweEjcp65yEp/1u RLtjJtBcFV7Cq5ngLpBp2isXBaOuAoQat+2hIOOtSA56SBuIsM7A8+m X-Developer-Key: i=linux@weissschuh.net; a=ed25519; pk=KcycQgFPX2wGR5azS7RhpBqedglOZVgRPfdFSPB1LNw= Even if it's not critical, the avoidance of checking the error code from devm_mutex_init() call today diminishes the point of using devm variant of it. Tomorrow it may even leak something. Enforce all callers checking the return value through the compiler. As devm_mutex_init() itself is a macro, it can not be annotated directly. Annotate __devm_mutex_init() instead. Unfortunately __must_check/warn_unused_result don't propagate through statement expression. So move the statement expression into the argument list of the call to __devm_mutex_init() through a helper macro. Signed-off-by: Thomas Weißschuh --- include/linux/mutex.h | 11 +++++++---- 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/include/linux/mutex.h b/include/linux/mutex.h index 2bf91b57591b49e4668752e773419ae945f124da..970b0526c549b699e7e4e1ba522696537957e069 100644 --- a/include/linux/mutex.h +++ b/include/linux/mutex.h @@ -126,11 +126,11 @@ do { \ #ifdef CONFIG_DEBUG_MUTEXES -int __devm_mutex_init(struct device *dev, struct mutex *lock); +int __must_check __devm_mutex_init(struct device *dev, struct mutex *lock); #else -static inline int __devm_mutex_init(struct device *dev, struct mutex *lock) +static inline int __must_check __devm_mutex_init(struct device *dev, struct mutex *lock) { /* * When CONFIG_DEBUG_MUTEXES is off mutex_destroy() is just a nop so @@ -141,14 +141,17 @@ static inline int __devm_mutex_init(struct device *dev, struct mutex *lock) #endif -#define devm_mutex_init(dev, mutex) \ +#define __mutex_init_ret(mutex) \ ({ \ typeof(mutex) mutex_ = (mutex); \ \ mutex_init(mutex_); \ - __devm_mutex_init(dev, mutex_); \ + mutex_; \ }) +#define devm_mutex_init(dev, mutex) \ + __devm_mutex_init(dev, __mutex_init_ret(mutex)) + /* * See kernel/locking/mutex.c for detailed documentation of these APIs. * Also see Documentation/locking/mutex-design.rst.