From patchwork Mon Feb 3 10:57:56 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Abel Vesa X-Patchwork-Id: 861889 Received: from mail-wm1-f48.google.com (mail-wm1-f48.google.com [209.85.128.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 36B6B20126B for ; Mon, 3 Feb 2025 10:58:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.48 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738580305; cv=none; b=Zw5YzfIqu9kUXxIsWRCD8DYeW/pjV+/jvzh/li/LR2eSl2oF0bDjXHZDrBQK5uYOLuMut4NYwK3LEwwT49ExtzYUqThwnW/7GHgrK8uSQgvVLCoMvBCv78hlSd2XMCOOry+Rq3b71UU4MfwA94PzNBNpBsZfaHmysdZYFzKeuTM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738580305; c=relaxed/simple; bh=GWDPLjsD/LaP+fD+1LfYD/7l93rcVcvESuGQSIuupYA=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=SuTLPNwiUbNsONTewhxrc1XyCj44dV55hLgoPqBLWpXGigpz3b4oHKWQlQKnhLR4U3CfBrCD4QONEFr6ekpmoB7RojDDvd6EfPO+3kqnTAEAWWu1cBUYy1Lw63C2nBnXIrskJvlFTVVQWcKpunoE1GfNLUJ0AKI+xkIanacNvNU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=haz9mpsj; arc=none smtp.client-ip=209.85.128.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="haz9mpsj" Received: by mail-wm1-f48.google.com with SMTP id 5b1f17b1804b1-43624b2d453so48882825e9.2 for ; Mon, 03 Feb 2025 02:58:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1738580301; x=1739185101; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=S2PDrSggs/qvWJ0wmbl57SFwliqss9oSkkJg/zY+uKY=; b=haz9mpsjY6zn2KC+36gXFNwgVw7L2jQ5LfcKMxK1YM2kfOYdQM1mivK6vTsfxUSPZ5 DHwYpDySNsj8VZYakSFK0FM0IsgZRGR1jMUy6CtH2dxgdr5IFSyNfViP0D0oU0L0SXHw krd5Rq1ndOPCh3UlK1BlexgWEK32mIfAsmLXdpqFV7+jIn8lvswwGJh3I1dVnK0lxzyI 4K1Ofao2fbDXQr+B4RbhJ76mX8NmwF122663zl5A6t7nZB5kP1G4XcZGHbC4YIDOPjv/ FSgMKvrG0FY1C+CKqitJsVRbfaDeETjnXv4dkeK/FYqa6+BPMrW9kcJwpKRLHniGDplV pm0g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1738580301; x=1739185101; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=S2PDrSggs/qvWJ0wmbl57SFwliqss9oSkkJg/zY+uKY=; b=OQLuxAtOY54E4EE79dQ9U2SH6iU1cf9c716Ee8Jr2TURUfCxcDJ9RlCUS+LOZkwxf0 dwOGGPgwA3xQbMXGC+OKw3kCkTBPBi/e5oda4wdOWY5txK1UYpenXvrfZ3OASw8WkeGZ hZvprp2U64mEZMxX8+dFd18Ljxyryw1vM6oaOjvZ6rkBP+FUVsyb5wYwCQJStScrJrK9 GFgmLuO0G469o/yyAqeNIOMWhoMplcychCmaUbUHolE9hWpCJoLwkzyQBUHlcePsiHxn oHrf9cim2HyFLbhE6vrPhh/qVxHxLgMbd/jmmHP1KBsQBfhNu5P0oASXa8cT7a27IyA6 45BA== X-Forwarded-Encrypted: i=1; AJvYcCVjdw6bDO3NUaUo0g6SPcgfHP8VFw/XxTYrJW5CXwR4Jiyef2C58nqBoqlCVaCjW52v8tDTs4pDTQIOntli@vger.kernel.org X-Gm-Message-State: AOJu0YyJq81NPbbOgJZxnltaubXiwxHJrPiQHrsso3yUCRmWLDZKDwC8 Sz0rEDJDOqezn1/W3O96KMW3/cK6gD3RSQODufu8pN1uSI0sVBC2HVv/XtvMxFE= X-Gm-Gg: ASbGncveouT7bXIRXbT0zR6g2rzNo48ssy7vfVZ/Iq2F6j2hnidJVmQgtKZVHWkLD9F 5BMTPtv0It3p/KVVoHQQJ5q1fpTLsgYYbzyWaSqEnDspzE+CkFA/zEQSTPwKrUNGMEHsukpGKKn +4icticc1OVmWEr1QavpPJINfrbV4EAWVMe9Ov5qcekFbW5RWmO2iph5a3vGij8JmS/C7soKAZl iK+9zjtT7zTCMe9ok9lBb3zHErrk8JimqdR15I8csm/VGKy2pF54eqyJqoDmCX0RRT0PP5Jizt1 U/RnWukSH4A7g6Q= X-Google-Smtp-Source: AGHT+IGN36phU2HT7tCupyKJD12EwPvmQAUkoCX3ifHXulTtaxt/EYCFNMaPrYCZ0Vr2bnElK/dpDg== X-Received: by 2002:a05:600c:4753:b0:434:f817:4492 with SMTP id 5b1f17b1804b1-438dc435842mr215585115e9.31.1738580301516; Mon, 03 Feb 2025 02:58:21 -0800 (PST) Received: from [127.0.1.1] ([86.123.96.125]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-38c5c13a0efsm12555083f8f.60.2025.02.03.02.58.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 03 Feb 2025 02:58:21 -0800 (PST) From: Abel Vesa Date: Mon, 03 Feb 2025 12:57:56 +0200 Subject: [PATCH v5 1/4] drm/dp: Add helper to set LTTPRs in transparent mode Precedence: bulk X-Mailing-List: linux-arm-msm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20250203-drm-dp-msm-add-lttpr-transparent-mode-set-v5-1-c865d0e56d6e@linaro.org> References: <20250203-drm-dp-msm-add-lttpr-transparent-mode-set-v5-0-c865d0e56d6e@linaro.org> In-Reply-To: <20250203-drm-dp-msm-add-lttpr-transparent-mode-set-v5-0-c865d0e56d6e@linaro.org> To: Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Karol Herbst , Lyude Paul , Danilo Krummrich , Jani Nikula , Rodrigo Vivi , Joonas Lahtinen , Tvrtko Ursulin , Rob Clark , Abhinav Kumar , Dmitry Baryshkov , Sean Paul , Marijn Suijten Cc: Bjorn Andersson , Konrad Dybcio , Johan Hovold , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, nouveau@lists.freedesktop.org, intel-gfx@lists.freedesktop.org, intel-xe@lists.freedesktop.org, linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org, Abel Vesa , Johan Hovold X-Mailer: b4 0.15-dev-dedf8 X-Developer-Signature: v=1; a=openpgp-sha256; l=4430; i=abel.vesa@linaro.org; h=from:subject:message-id; bh=GWDPLjsD/LaP+fD+1LfYD/7l93rcVcvESuGQSIuupYA=; b=owEBbQKS/ZANAwAKARtfRMkAlRVWAcsmYgBnoKFE89QOXDiWSJro65eII8Rv3UxY8Qc4UyUUI 531ArtGoZaJAjMEAAEKAB0WIQRO8+4RTnqPKsqn0bgbX0TJAJUVVgUCZ6ChRAAKCRAbX0TJAJUV VgtjD/43YCJn+kR3wQvW34kEv7ddETk/bpBbvc+gF6M7mOlHTfHynaAffq939L1AgY2sKs0Ehem W3Ql9tbPbR5GPSxwLs+TK6wRt6Gqia8dwDdS+GRPBl8JtMFEI3Hf1Rzs9akUdToFV5BFIaqm1a+ zZgwAdSycOWeyoVwotoojTFVBH5l9iHVl7xJkcCIMYP+LRke8XLepAW23jcYrjpo0Af3uk2UxZv PNigdxWHhIMyubZI1QzE8RoaJFLVEvwiIymaaICaU51PXN4p+651Jgyz5v2Wd/zWAelnH89HFV3 jhVfTpHgVEx/2ELpV2HjnWApWKO2y3UxalTfbG4z4twC6sR8bj4zoR3e6A4H+tp3ZM/IL++quo6 toJJwamCFUy0XUFSQm7HY4z1jVrWNvtns4yBm6c+iAXAIIKtoDfgI/XWCrEo514Qyeoba45IovW VfyWGZpYEEIKw1TOCGMMdEqUCikLbg9UtID5UCtqGU4oQelo06HWIJCYrvH3cblppwNc5gRacyb v2MIbm8qQ4wPv8iltN0OK+XRbanbtcC9N5PbB5x+eX3pswEUz51It3L3cSRY1HGLKuB3w0vDchB Kt6XEsCoDVip8OJAOhfAc79z2yz0Xvjz1chZCqg/vNqm06bjUOuQWUYVQRlEh+hX7WVf/Grria5 86nPpHdX0g3xNrQ== X-Developer-Key: i=abel.vesa@linaro.org; a=openpgp; fpr=6AFF162D57F4223A8770EF5AF7BF214136F41FAE According to the DisplayPort standard, LTTPRs have two operating modes: - non-transparent - it replies to DPCD LTTPR field specific AUX requests, while passes through all other AUX requests - transparent - it passes through all AUX requests. Switching between this two modes is done by the DPTX by issuing an AUX write to the DPCD PHY_REPEATER_MODE register. Add a generic helper that allows switching between these modes. Also add a generic wrapper for the helper that handles the explicit disabling of non-transparent mode and its disable->enable sequence mentioned in the DP Standard v2.0 section 3.6.6.1. Do this in order to move this handling out of the vendor specific driver implementation into the generic framework. Tested-by: Johan Hovold Reviewed-by: Dmitry Baryshkov Reviewed-by: Johan Hovold Reviewed-by: Abhinav Kumar Signed-off-by: Abel Vesa --- drivers/gpu/drm/display/drm_dp_helper.c | 61 +++++++++++++++++++++++++++++++++ include/drm/display/drm_dp_helper.h | 2 ++ 2 files changed, 63 insertions(+) diff --git a/drivers/gpu/drm/display/drm_dp_helper.c b/drivers/gpu/drm/display/drm_dp_helper.c index da3c8521a7fa7d3c9761377363cdd4b44ab1106e..ea3ad0fe51c4ce13961f2918cd651ab2d23b4edd 100644 --- a/drivers/gpu/drm/display/drm_dp_helper.c +++ b/drivers/gpu/drm/display/drm_dp_helper.c @@ -2817,6 +2817,67 @@ int drm_dp_lttpr_max_link_rate(const u8 caps[DP_LTTPR_COMMON_CAP_SIZE]) } EXPORT_SYMBOL(drm_dp_lttpr_max_link_rate); +/** + * drm_dp_lttpr_set_transparent_mode() - set the LTTPR in transparent mode + * @aux: DisplayPort AUX channel + * @enable: Enable or disable transparent mode + * + * Returns: 0 on success or a negative error code on failure. + */ +int drm_dp_lttpr_set_transparent_mode(struct drm_dp_aux *aux, bool enable) +{ + u8 val = enable ? DP_PHY_REPEATER_MODE_TRANSPARENT : + DP_PHY_REPEATER_MODE_NON_TRANSPARENT; + int ret = drm_dp_dpcd_writeb(aux, DP_PHY_REPEATER_MODE, val); + + if (ret < 0) + return ret; + + return (ret == 1) ? 0 : -EIO; +} +EXPORT_SYMBOL(drm_dp_lttpr_set_transparent_mode); + +/** + * drm_dp_lttpr_init() - init LTTPR transparency mode according to DP standard + * @aux: DisplayPort AUX channel + * @lttpr_count: Number of LTTPRs. Between 0 and 8, according to DP standard. + * Negative error code for any non-valid number. + * See drm_dp_lttpr_count(). + * + * Returns: 0 on success or a negative error code on failure. + */ +int drm_dp_lttpr_init(struct drm_dp_aux *aux, int lttpr_count) +{ + int ret; + + if (!lttpr_count) + return 0; + + /* + * See DP Standard v2.0 3.6.6.1 about the explicit disabling of + * non-transparent mode and the disable->enable non-transparent mode + * sequence. + */ + ret = drm_dp_lttpr_set_transparent_mode(aux, true); + if (ret) + return ret; + + if (lttpr_count < 0) + return -ENODEV; + + if (drm_dp_lttpr_set_transparent_mode(aux, false)) { + /* + * Roll-back to transparent mode if setting non-transparent + * mode has failed + */ + drm_dp_lttpr_set_transparent_mode(aux, true); + return -EINVAL; + } + + return 0; +} +EXPORT_SYMBOL(drm_dp_lttpr_init); + /** * drm_dp_lttpr_max_lane_count - get the maximum lane count supported by all LTTPRs * @caps: LTTPR common capabilities diff --git a/include/drm/display/drm_dp_helper.h b/include/drm/display/drm_dp_helper.h index 8f4054a560396a43750570a8c2e95624039ab8ad..3311df3b58255cf0620391d0948ccf6b569a8a34 100644 --- a/include/drm/display/drm_dp_helper.h +++ b/include/drm/display/drm_dp_helper.h @@ -630,6 +630,8 @@ int drm_dp_read_lttpr_phy_caps(struct drm_dp_aux *aux, u8 caps[DP_LTTPR_PHY_CAP_SIZE]); int drm_dp_lttpr_count(const u8 cap[DP_LTTPR_COMMON_CAP_SIZE]); int drm_dp_lttpr_max_link_rate(const u8 caps[DP_LTTPR_COMMON_CAP_SIZE]); +int drm_dp_lttpr_set_transparent_mode(struct drm_dp_aux *aux, bool enable); +int drm_dp_lttpr_init(struct drm_dp_aux *aux, int lttpr_count); int drm_dp_lttpr_max_lane_count(const u8 caps[DP_LTTPR_COMMON_CAP_SIZE]); bool drm_dp_lttpr_voltage_swing_level_3_supported(const u8 caps[DP_LTTPR_PHY_CAP_SIZE]); bool drm_dp_lttpr_pre_emphasis_level_3_supported(const u8 caps[DP_LTTPR_PHY_CAP_SIZE]); From patchwork Mon Feb 3 10:57:57 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Abel Vesa X-Patchwork-Id: 861597 Received: from mail-wm1-f45.google.com (mail-wm1-f45.google.com [209.85.128.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1AFBF202C2B for ; Mon, 3 Feb 2025 10:58:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.45 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738580306; cv=none; b=lcTN29gkk7gwCosW/TG4BvdeQzccGEkGKVSBn6wKpMbVWbOIumMZZfVeGifbyfEPUdC8CSjJnTx1pjbgbA4/5gMXLRNHTafxUCOhrMYuMcoM1wuu/1+XLqzlyKbFjE4YI3SRisOqJpJl4+SRtIF2ARu1k2Ub5Pj10qgTNOGBN6g= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738580306; c=relaxed/simple; bh=zSpYhtCfdoGV8lx5sZ6QJCKOEoZaxgqNtvMuGie1uZU=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=MuXmE8/Ws39GmrKHR4MNMaQBPKwP8XJL0QYHud9Wek1SqcC65xIqYM0Nekl9phetaHKNxVjelsOWoGpOqWWIn31vpg8I34gc73ogmYe+XzKOLBrwX4ZVizKUf5KDjl2VKAhnhTkEwG8p8SNFyUAATZrd8IM0C+dNMOlMLPciYyM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=oFn0AqyD; arc=none smtp.client-ip=209.85.128.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="oFn0AqyD" Received: by mail-wm1-f45.google.com with SMTP id 5b1f17b1804b1-436a03197b2so28627485e9.2 for ; Mon, 03 Feb 2025 02:58:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1738580303; x=1739185103; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=8ja7AsPHVhh/ztffyEqltS3S3NOI8MWwC75cFS3zUfQ=; b=oFn0AqyDQKlemBaVDjTX4pJs5/VGamluSVuQgt32LxS1ovbXgxDSu16gKXM7fN/vui ABtZE4yAe9pY9ZqAuhj60FnKwqc42AsgJrB2ZqQwWxpOzN/HMmi8OaeAJT0BaU5wbLsS IPc6mR5ih+3xvMZwyykO7BFxfavkr2B3ZfZ/fpKCEOHZqFbmpokwF9iMtRSS38n+oqRT KaO6nZ0P7k1IR9gj7Pj+taMmYtO6SA3ERx6P07jEJmdtjjLPOIaCCu/JlmoWTViixt6c Iz0erCaBFqE4ezY59YVSXSMzQTGReO3PtSBMKO61gmcniFWlQJsdARzX/kXsmMC1y7WE hN2w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1738580303; x=1739185103; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=8ja7AsPHVhh/ztffyEqltS3S3NOI8MWwC75cFS3zUfQ=; b=c3de2udOoJqct1yVtzOFyAI6S7NYf7J0d/XyrFyEcHnXIxVLxNPQq6KHuOuLTG2m3E 7wmOwt+ihuzYJauEoRAa/dmuEeGG41I2fESntTNMPhNC4RPVUaxmouwGJfx3+OSC8OBS G1UJtuEWf+sVEOZkORhM/1R7DX3Ln6VyabB7bs+PI9d1/mlsZQ4LkTBUvXhZtpDFpekP kgAlkXT6aSZuDfCkqEJhtlW/Q2M/PYpD16CdTqW9RS0jfa57GsHqUVoKWhfbGYhRN0Ut ZPSEwxeo0WJ7A8kgeHyGG6HexmuwPrgcLTkZqQkccoFFRg7mokg5O3O2LPpDnlEvDtFJ XQ9Q== X-Forwarded-Encrypted: i=1; AJvYcCVg7vGRGpOBaqakGy9/A7C0ci+5jVU1m2puaxhY86FAqNGK/nCitFkiCVV/kYWxOgHJyfm4qQrOGtrerYBS@vger.kernel.org X-Gm-Message-State: AOJu0YzCyFDMwc5luX7Uhqr+uR7QuGCBOk5g/97rrTXdaYHSTOh/1OA3 z6tTGptRpx0suK4keJc+K6d63cHRe/SSMUYGGdL64Rk2L90xZVgoSNxyYv8EinQ= X-Gm-Gg: ASbGncs5DZ7+GceBLBIV+Ydgs++rYd8wW0nnm/y9PUMQfYGbJ9sn/45dUify24wiqdw NTADIAd0H8GMa60rH+lFXPNHEJv+P9+QCVP4aczFZ64DF0S9pKgFEmfRDMwzxg7No7wU8iqPbrC EaGveNBWH0v2MlRsywsu3FaJp36kTL0megxIsrawUdS8khSb7zhk+nAD800ewp4PM0tYZctXSMf qS1xiGAowAPP2m/jSlcXccF197WFW1NEeHhX9/3NHlOrOa+426Ics4po2SpI9hjn9OBXnONr2S6 ilz3A/KBJpT8z4s= X-Google-Smtp-Source: AGHT+IFthNBbLjS02kgsZVYwGukRDHyL+VpzJLps1CtcKLr/74/ZMFJ692muUaKO63TfDrMyjpuBEw== X-Received: by 2002:a05:600c:a44:b0:436:488f:50a with SMTP id 5b1f17b1804b1-438dc3c877cmr187531275e9.17.1738580303507; Mon, 03 Feb 2025 02:58:23 -0800 (PST) Received: from [127.0.1.1] ([86.123.96.125]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-38c5c13a0efsm12555083f8f.60.2025.02.03.02.58.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 03 Feb 2025 02:58:23 -0800 (PST) From: Abel Vesa Date: Mon, 03 Feb 2025 12:57:57 +0200 Subject: [PATCH v5 2/4] drm/nouveau/dp: Use the generic helper to control LTTPR transparent mode Precedence: bulk X-Mailing-List: linux-arm-msm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20250203-drm-dp-msm-add-lttpr-transparent-mode-set-v5-2-c865d0e56d6e@linaro.org> References: <20250203-drm-dp-msm-add-lttpr-transparent-mode-set-v5-0-c865d0e56d6e@linaro.org> In-Reply-To: <20250203-drm-dp-msm-add-lttpr-transparent-mode-set-v5-0-c865d0e56d6e@linaro.org> To: Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Karol Herbst , Lyude Paul , Danilo Krummrich , Jani Nikula , Rodrigo Vivi , Joonas Lahtinen , Tvrtko Ursulin , Rob Clark , Abhinav Kumar , Dmitry Baryshkov , Sean Paul , Marijn Suijten Cc: Bjorn Andersson , Konrad Dybcio , Johan Hovold , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, nouveau@lists.freedesktop.org, intel-gfx@lists.freedesktop.org, intel-xe@lists.freedesktop.org, linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org, Abel Vesa X-Mailer: b4 0.15-dev-dedf8 X-Developer-Signature: v=1; a=openpgp-sha256; l=1634; i=abel.vesa@linaro.org; h=from:subject:message-id; bh=zSpYhtCfdoGV8lx5sZ6QJCKOEoZaxgqNtvMuGie1uZU=; b=owEBbQKS/ZANAwAKARtfRMkAlRVWAcsmYgBnoKFFwp0Q3Pa0vilB+WV1NstXg3L+NhCg1dZF4 9nljGvt4aaJAjMEAAEKAB0WIQRO8+4RTnqPKsqn0bgbX0TJAJUVVgUCZ6ChRQAKCRAbX0TJAJUV VrpLD/9KZyQu8jIhJYXTVneqLeoUWkoZlTZO4UcXbLROqhAXzJHfoudtKqN6Uo7EBphzOjbqXkw L8V+j/CO9idN63ZqcHf5mQVmuMbjNWkvIeCsMq42M6ZZUmACXguioar1CbFgHQ8E5OB3ianHEyo ZEHBtewoLDvvkXGlx3Dhb/8MfMTiYeF5sCXozl5qdc2wrPhXO76+U+tpsexdEQxTUK/9iVE89x8 sQlehJqfxHeZsz1PaavyvnQPc+KVvbdFdkwFfGWPYbSFn/TWOSkjIF64HS8q0tjcDLBDaXEr4yJ 3hG+Wvz8DC9sXLujBQLUZXZIhqAdcPWUfiBvW5BZUB6B6Awfu0UwoRjExTQfKwqCOYPWJIXMRWq XbMkXFpQno5vlWWimF249S1Y9vIUWhyJro/PosAXnBrUzNzjS79NpAqD0GuP+vmBod/t5Ls/p10 9M+KuiUzWArjDa4v0ZnRNhI4u+OUeTTrlDC9KGoKvArCLJwhmhkPaFQ5Kh0Za84DPk+SIcH3t8A u6SJ5QH/UTUb0MV3fg93+zQPTV4ZrYguUN4qyIgiulEbIPa1hYwBNs+96lfizy3+QAUO58clj/D PjEX7lpaZSm1/2PAINaciL/swbWOOjlUQMlUEe7fDoN+tTtc4cdp5Gcig7ewkuC47gVY46TdH1d raWn+ZZSSCri46A== X-Developer-Key: i=abel.vesa@linaro.org; a=openpgp; fpr=6AFF162D57F4223A8770EF5AF7BF214136F41FAE LTTPRs operating modes are defined by the DisplayPort standard and the generic framework now provides a helper to switch between them, which is handling the explicit disabling of non-transparent mode and its disable->enable sequence mentioned in the DP Standard v2.0 section 3.6.6.1. So use the new drm generic helper instead as it makes the code a bit cleaner. Reviewed-by: Lyude Paul Signed-off-by: Abel Vesa --- drivers/gpu/drm/nouveau/nouveau_dp.c | 17 ++--------------- 1 file changed, 2 insertions(+), 15 deletions(-) diff --git a/drivers/gpu/drm/nouveau/nouveau_dp.c b/drivers/gpu/drm/nouveau/nouveau_dp.c index bcda0105160f1450df855281e0d932606a5095dd..55691ec44abaa53c84e73358e33df1949bb1e35c 100644 --- a/drivers/gpu/drm/nouveau/nouveau_dp.c +++ b/drivers/gpu/drm/nouveau/nouveau_dp.c @@ -79,21 +79,8 @@ nouveau_dp_probe_dpcd(struct nouveau_connector *nv_connector, !drm_dp_read_lttpr_common_caps(aux, dpcd, outp->dp.lttpr.caps)) { int nr = drm_dp_lttpr_count(outp->dp.lttpr.caps); - if (nr) { - drm_dp_dpcd_writeb(aux, DP_PHY_REPEATER_MODE, - DP_PHY_REPEATER_MODE_TRANSPARENT); - - if (nr > 0) { - ret = drm_dp_dpcd_writeb(aux, DP_PHY_REPEATER_MODE, - DP_PHY_REPEATER_MODE_NON_TRANSPARENT); - if (ret != 1) { - drm_dp_dpcd_writeb(aux, DP_PHY_REPEATER_MODE, - DP_PHY_REPEATER_MODE_TRANSPARENT); - } else { - outp->dp.lttpr.nr = nr; - } - } - } + if (!drm_dp_lttpr_init(aux, nr)) + outp->dp.lttpr.nr = nr; } ret = drm_dp_read_dpcd_caps(aux, dpcd); From patchwork Mon Feb 3 10:57:58 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Abel Vesa X-Patchwork-Id: 861888 Received: from mail-wm1-f45.google.com (mail-wm1-f45.google.com [209.85.128.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3F01B202F67 for ; Mon, 3 Feb 2025 10:58:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.45 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738580309; cv=none; b=oqaR02rAq/EVSL0tQXoYEeHipP2KcpS6OCzzRgMP0bah1JpDdj5QLTfUX/PiW+HgjZJ3LwfXFbtUssK7Nuxqz9kUFmnW71HqHcG0+yoFIdW84jMxR2MpVbSJSRJ8U4YUUxVEwCXXuZru1H15V7ZyrnHgbtO5zUuq3gNC5Ie+okg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738580309; c=relaxed/simple; bh=i0gLL9cKFwnwAUFAvwIYOq+eSp8wWGGPgQgjnTN3PKE=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=fAfMeYnHGJoHtQGBMatt9/7nUb+RtK6pfmx4n02J3l4pmF5EqSeAJQswEdjETJJmLkPynphpiF/6hNe1xLC/LX+zWhZf/sjZYGJpcBr6p40aa9z2lYh6+Z+NcMXJajsDpAmKQEZorHH3X9lZjQMvoWR4pf+wvTRgukmKYUCDiXU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=KBLvF040; arc=none smtp.client-ip=209.85.128.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="KBLvF040" Received: by mail-wm1-f45.google.com with SMTP id 5b1f17b1804b1-436326dcb1cso28742305e9.0 for ; Mon, 03 Feb 2025 02:58:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1738580305; x=1739185105; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=9rGR892CsW48bbjquxFjsrZJbQNkPKwTMgb7XwAF2pQ=; b=KBLvF040pM9184uMDMM/fMU8IvS4ZAuGbecuZ3Nh8AIosPsJQIwy6qVxUz10DdFWje WDyw9cgl5jNWdtmEpTk8T0cWP1rKMhfoQ+egB/kNf81I535ttJikq/gcbc4zam+fni8V +QiLYrxD5cs0CPvFjuuLq8IEI52bFQUqGDEhb8QrYwZFiJ0rSVaaoly8aHb/fzZq1CZG rgDY2scNnkVwIgNpesQJeaAG/TkrIJJ06gJydLVuhZPQvmOdMmXMCcGPDMdfkWr+cQCC zhX47MHXu+yhmVwhu1/d6nM+/EOZ5/nH4grnR6FXdxiw9RBaZ4X60XdrSOD+nI4xmqtL GEAA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1738580305; x=1739185105; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=9rGR892CsW48bbjquxFjsrZJbQNkPKwTMgb7XwAF2pQ=; b=Dk0hhyY5953VrBFPCy97WHpp5eQxxzBew5D+b5EarRXyuSl0+J4gavwhCiDNd6LP6n S8Z7aLva7/twzlFatIcCUGVESO/cYot4sBD5wjhUFL1WvCNckXhHSYa9sC/CQEmHeuzO QG+s4Y/vQI6+qOSXSKuCBRVtrZIcsWYf5MfQpwkrFB3AacR7c75hguHNFDOgJpMtY2sh lgMn32YvCsvHLHX47n2cY//XG3N99V6jw9yLcZHaFM2IM1MmR6+7NqIsSZaf/KdPAbER cTfddvhSV3SB+sqRG7AY5hJX/dtdASmasr4k4BermBHZ6rUy9fpA4JdiphIsfC+5r5H8 bTIw== X-Forwarded-Encrypted: i=1; AJvYcCUH2whkHPkNNFTnikxhx5aWahNVJMg55G+MUvm78AslNp2Wey7lrRKeLZitesR8ba7qMkR4gjD5yvpH4AGJ@vger.kernel.org X-Gm-Message-State: AOJu0YwD0SPFllMHC7LAa7Dn7Ea50LpCAHeNBesa+p8yu158gVixcBbt tUX4kjkQVUOd3rJiyk8fqQr7uGUIAPnp8e/IWVY9Ggh9ptg4c3iMHEDiK/GVQkA= X-Gm-Gg: ASbGnctuW20mzkxrB1icqUsYzmx3Ly7iRFfVfgDWeB7KNl00HIOC1jTDGb7k4dt8Lsr KRfOGgUBFR6/cm7B4CtQI0/yPF2cmyJokRd2WdXcsxfmKxgzEUvc5E38x2K0PxEyovI3hJ9xger fmT7ZyNasbPwv1wUFA5GCIzYKi/Y7JNAh2Cj2/fdwqi5a/npMHWyTEAhg4KXrEpz0DycJcmLly2 pfgOdUs0rX4+gLNvxzd3ZouPWtTTkAY4IiSuReJPyf03ln0eDprAjvTHMZb99k6m9stt6YQvNs2 wvIOFN90BKvL7kM= X-Google-Smtp-Source: AGHT+IFSasDqEOzfX51Cb+efM0QKQ3elXk+hBHYXZYdwzgdqIdkhz/Op8fasjqvlbzslKL+ssHNviA== X-Received: by 2002:a5d:6d0c:0:b0:38a:6929:ff9e with SMTP id ffacd0b85a97d-38c51946af3mr15013169f8f.7.1738580305547; Mon, 03 Feb 2025 02:58:25 -0800 (PST) Received: from [127.0.1.1] ([86.123.96.125]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-38c5c13a0efsm12555083f8f.60.2025.02.03.02.58.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 03 Feb 2025 02:58:25 -0800 (PST) From: Abel Vesa Date: Mon, 03 Feb 2025 12:57:58 +0200 Subject: [PATCH v5 3/4] drm/i915/dp: Use the generic helper to control LTTPR transparent mode Precedence: bulk X-Mailing-List: linux-arm-msm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20250203-drm-dp-msm-add-lttpr-transparent-mode-set-v5-3-c865d0e56d6e@linaro.org> References: <20250203-drm-dp-msm-add-lttpr-transparent-mode-set-v5-0-c865d0e56d6e@linaro.org> In-Reply-To: <20250203-drm-dp-msm-add-lttpr-transparent-mode-set-v5-0-c865d0e56d6e@linaro.org> To: Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Karol Herbst , Lyude Paul , Danilo Krummrich , Jani Nikula , Rodrigo Vivi , Joonas Lahtinen , Tvrtko Ursulin , Rob Clark , Abhinav Kumar , Dmitry Baryshkov , Sean Paul , Marijn Suijten Cc: Bjorn Andersson , Konrad Dybcio , Johan Hovold , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, nouveau@lists.freedesktop.org, intel-gfx@lists.freedesktop.org, intel-xe@lists.freedesktop.org, linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org, Abel Vesa , Imre Deak X-Mailer: b4 0.15-dev-dedf8 X-Developer-Signature: v=1; a=openpgp-sha256; l=3093; i=abel.vesa@linaro.org; h=from:subject:message-id; bh=i0gLL9cKFwnwAUFAvwIYOq+eSp8wWGGPgQgjnTN3PKE=; b=owEBbQKS/ZANAwAKARtfRMkAlRVWAcsmYgBnoKFHEE1x6guj2+EFNZpgvNKSLMm0sxnSo8XDB ultsrbwiS6JAjMEAAEKAB0WIQRO8+4RTnqPKsqn0bgbX0TJAJUVVgUCZ6ChRwAKCRAbX0TJAJUV VrQMD/9ZbpIZU+o65MtFjC7Lzb0Aw68FMO4/mI5BTwjbk/4A9V72TEg3Npiq8ArwZ1e9Fyb198d RlPUg5v1NRguCXwPgx5Im1wTWKo5ntOzsQC+nbzFuWO2alKkcnCBW2+n3Usud9raVxTj2NBpEF8 b6LICKL7tcGZhhhYewU10Ta1pScIoYnrjGsoxl3IaK322mXuf8sQNGF486p60IVHeEfwY9h040/ /f/I+wt3ADnPQtjxGwMjQxCqi+Fjk259rhIpwn5Dwid3++ZMX1mjk1DxyBU7i/6NKM/38oAyoS0 /iubtZbC6+ssuxcFdu0TN2ideAZLCIB+bGzDdlyTqXvZAmrNfvnerEo4Dpom9Tg65ql71KMXMw0 9xbPF1r2shnWKqNDR7ZCzSeTdJnn+ManTv/kZUwWxEW1dW6SUqXrrbuGhmkb1L3rgxPKQFyCqcG H1LLJdtpczf/yH8tmyWmlpAbBp9jE5sTdj601fsf2E71Q8twQmlEVM3MTjypO0bcdZy8f81lAa6 fPR7nWGWLeOCNpJK/9rSxzxRIc/d8UVY7YVw/PQq0M6HiDHH4khXZvTz/7IkAzDfZmeuPD1NDPq RKPceFqsfbHAKpJVzM+S5SQZ5sw9tn+VtmquzckpoJuocNO0LK6mGnOZFpVCLQITKBVS65LEn/v za3N8+9CZVBz7Rg== X-Developer-Key: i=abel.vesa@linaro.org; a=openpgp; fpr=6AFF162D57F4223A8770EF5AF7BF214136F41FAE LTTPRs operating modes are defined by the DisplayPort standard and the generic framework now provides a helper to switch between them, which is handling the explicit disabling of non-transparent mode and its disable->enable sequence mentioned in the DP Standard v2.0 section 3.6.6.1. So use the new drm generic helper instead as it makes the code a bit cleaner. Since the driver specific implementation holds the lttrp_common_caps, if the call to the drm generic helper fails, the lttrp_common_caps need to be updated as the helper has already rolled back to transparent mode. Acked-by: Imre Deak Signed-off-by: Abel Vesa --- .../gpu/drm/i915/display/intel_dp_link_training.c | 24 +++++----------------- 1 file changed, 5 insertions(+), 19 deletions(-) diff --git a/drivers/gpu/drm/i915/display/intel_dp_link_training.c b/drivers/gpu/drm/i915/display/intel_dp_link_training.c index 8b1977cfec503c70f07af716ee2c00e7605c6adf..c5bad311edf7b9a5cebb633b9e9692bae397f9ed 100644 --- a/drivers/gpu/drm/i915/display/intel_dp_link_training.c +++ b/drivers/gpu/drm/i915/display/intel_dp_link_training.c @@ -119,9 +119,6 @@ intel_dp_set_lttpr_transparent_mode(struct intel_dp *intel_dp, bool enable) u8 val = enable ? DP_PHY_REPEATER_MODE_TRANSPARENT : DP_PHY_REPEATER_MODE_NON_TRANSPARENT; - if (drm_dp_dpcd_write(&intel_dp->aux, DP_PHY_REPEATER_MODE, &val, 1) != 1) - return false; - intel_dp->lttpr_common_caps[DP_PHY_REPEATER_MODE - DP_LT_TUNABLE_PHY_REPEATER_FIELD_DATA_STRUCTURE_REV] = val; @@ -146,6 +143,7 @@ static bool intel_dp_lttpr_transparent_mode_enabled(struct intel_dp *intel_dp) static int intel_dp_init_lttpr_phys(struct intel_dp *intel_dp, const u8 dpcd[DP_RECEIVER_CAP_SIZE]) { int lttpr_count; + int ret; if (!intel_dp_read_lttpr_common_caps(intel_dp, dpcd)) return 0; @@ -172,22 +170,8 @@ static int intel_dp_init_lttpr_phys(struct intel_dp *intel_dp, const u8 dpcd[DP_ return lttpr_count; } - /* - * See DP Standard v2.0 3.6.6.1. about the explicit disabling of - * non-transparent mode and the disable->enable non-transparent mode - * sequence. - */ - intel_dp_set_lttpr_transparent_mode(intel_dp, true); - - /* - * In case of unsupported number of LTTPRs or failing to switch to - * non-transparent mode fall-back to transparent link training mode, - * still taking into account any LTTPR common lane- rate/count limits. - */ - if (lttpr_count < 0) - goto out_reset_lttpr_count; - - if (!intel_dp_set_lttpr_transparent_mode(intel_dp, false)) { + ret = drm_dp_lttpr_init(&intel_dp->aux, lttpr_count); + if (ret) { lt_dbg(intel_dp, DP_PHY_DPRX, "Switching to LTTPR non-transparent LT mode failed, fall-back to transparent mode\n"); @@ -196,6 +180,8 @@ static int intel_dp_init_lttpr_phys(struct intel_dp *intel_dp, const u8 dpcd[DP_ goto out_reset_lttpr_count; } + intel_dp_set_lttpr_transparent_mode(intel_dp, false); + return lttpr_count; out_reset_lttpr_count: From patchwork Mon Feb 3 10:57:59 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Abel Vesa X-Patchwork-Id: 861596 Received: from mail-wm1-f45.google.com (mail-wm1-f45.google.com [209.85.128.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 27DE1202F97 for ; Mon, 3 Feb 2025 10:58:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.45 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738580311; cv=none; b=le/DNigR2R8nOKISYvdlixBPFF1zInVUifD4CSsmTk6JJmAuk49Yk1fLlUje19aECk0r4/K8qTyujo/VR29ffkmHwIW9PGYCCN799G9RrGqLrGjaM6xe5SU0aT9C0GkMG7JzC+peFO+3ut0AG+GfO2L3HZFKF0lB5aZs8qxGVv8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738580311; c=relaxed/simple; bh=Jh+EL4p/6JSMFadATMQ/dMawzZEL4l2MOkq/1iyumns=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=pd2aWmfzIA23jy07wZHKtKl9stFLsh/PFD4cz0kTElugtIw7/ghQ2FsFju0r9awo0LiNMz7SQOm2ToQ/IGUnn7F2+QmFw6yB6IeO1n0nr89bhMfvT/t2t4R1evrKLCV9OEnxtVjouweG4dz4AQteBNvtjvbnMRDs1QDnQAyONOM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=sDyDYXVN; arc=none smtp.client-ip=209.85.128.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="sDyDYXVN" Received: by mail-wm1-f45.google.com with SMTP id 5b1f17b1804b1-4368a293339so49773175e9.3 for ; Mon, 03 Feb 2025 02:58:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1738580308; x=1739185108; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=YU2toixtghG/UIHIgDfi+TrJAb+KbxkNuLjUS/jgDXM=; b=sDyDYXVNFP+iewVdmnRCOTGbB8y1zrIccusyVzUPSBbgkIsQB7aC0cfik+PBycS4Am J+TwWKqOqbdXe1UgHVTSwOl4LM8Ey4NRML6gfy4YXr1gZFLyQzqt7tpA30BeLx+aTP5G 8+vtiNJtmtQV+wzh/u7f4CWan+VhimqYarzI974NqFmvKOMuVNcdKRXwuhLSX/VXdhOm tE+YNG1fMr0Sh7d6wMCGGfA4YiIpFNjjc4E6r7VSb/0B4IP8ufzC3DtYVAFiX22R289n +LB2hE03iFXO56yimOiujIdS+SJXsgbdweOshpYRFeWQfaAB+TVUsct+xsH5KOKxXpXl 01QQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1738580308; x=1739185108; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=YU2toixtghG/UIHIgDfi+TrJAb+KbxkNuLjUS/jgDXM=; b=i25lXnt6gk+ZehTiWpw1KsttUTC2LvUKmoQxGnHshnZP53GHsT23ubk3/rwYucW0+M eJTCVZqqhZ8KE4CON/LkwxitkbzJBaYPK5Wse1HPdG/3/tucOep0YBQ8lafaWk2yX1rL 15Ir55G2wN6KLpPd6Wzxq235IFzGe9sAMAyUIvFI5bccVjYZxh0pb3eoBFV0EfYpV3/p euBfptX2anu5RQyRZwFEsEOQ7j/6v0PFAdzr417ldvpx2Dec8CkTFGmhZt19yt/cos98 1ToMCCmWM3/3iLIHmWtBQjrunuZm3YLNaAIYZqOWYhTVYckT6duZClf5blEsmZDkD0EY WlIQ== X-Forwarded-Encrypted: i=1; AJvYcCWh2ntTCXYHIcWrB+L0wqUvZ2faDvhFFgS9nfaFHOjtoy0qKuWJ+dwpobPm/+aH0tp9Nnku2yK9codVmCom@vger.kernel.org X-Gm-Message-State: AOJu0Ywf17g5WC8fbRbh09xzIDxIyRHDSQxEP6uXynPslesLXKdS/1e8 KkSdpRMRWM1osvfanhrzrPFcLqtzjtkVzB01OqFkZuw8ZKUOLU47OwFyQifh5TE= X-Gm-Gg: ASbGncsXR3U+UyMgqO4qHV+UUhaDsVNlMxU2W+aQjPBPIesvDcKz/8dDgEAJV2GcR9z gIEeo/kbojAx0bbKym7wIcD6Gi3iVrDnSw5ecgczb3UXE8LVXIL4FK3LwnVn51BKePvZpc76t7I df7A75rhMeMguH0tBeW5rob3HmL/DFpFF75lsMBXT9xMhh7eTP3E3gedVXjDoio03816ZgMqHLF KXdTClXYCvCJywNZ5pz7/FruAmG+9kce/gcX4XAxP/K/CB8dV4qGJApKu/NiwNmPXKcaCtKG7Ed iouIayKl9dNdOl0= X-Google-Smtp-Source: AGHT+IG3sxZoF1BxKwDs6D8yKh85vjYaq2CGCwZLuA4JBiE6X/IAqNanFP9ag+j0VZ8Qqg5mgek9bg== X-Received: by 2002:a05:600c:35d1:b0:436:1971:2a4 with SMTP id 5b1f17b1804b1-438dc3cc9f1mr185238805e9.17.1738580307609; Mon, 03 Feb 2025 02:58:27 -0800 (PST) Received: from [127.0.1.1] ([86.123.96.125]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-38c5c13a0efsm12555083f8f.60.2025.02.03.02.58.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 03 Feb 2025 02:58:27 -0800 (PST) From: Abel Vesa Date: Mon, 03 Feb 2025 12:57:59 +0200 Subject: [PATCH v5 4/4] drm/msm/dp: Add support for LTTPR handling Precedence: bulk X-Mailing-List: linux-arm-msm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20250203-drm-dp-msm-add-lttpr-transparent-mode-set-v5-4-c865d0e56d6e@linaro.org> References: <20250203-drm-dp-msm-add-lttpr-transparent-mode-set-v5-0-c865d0e56d6e@linaro.org> In-Reply-To: <20250203-drm-dp-msm-add-lttpr-transparent-mode-set-v5-0-c865d0e56d6e@linaro.org> To: Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Karol Herbst , Lyude Paul , Danilo Krummrich , Jani Nikula , Rodrigo Vivi , Joonas Lahtinen , Tvrtko Ursulin , Rob Clark , Abhinav Kumar , Dmitry Baryshkov , Sean Paul , Marijn Suijten Cc: Bjorn Andersson , Konrad Dybcio , Johan Hovold , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, nouveau@lists.freedesktop.org, intel-gfx@lists.freedesktop.org, intel-xe@lists.freedesktop.org, linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org, Abel Vesa , Johan Hovold X-Mailer: b4 0.15-dev-dedf8 X-Developer-Signature: v=1; a=openpgp-sha256; l=3226; i=abel.vesa@linaro.org; h=from:subject:message-id; bh=Jh+EL4p/6JSMFadATMQ/dMawzZEL4l2MOkq/1iyumns=; b=owEBbQKS/ZANAwAKARtfRMkAlRVWAcsmYgBnoKFIouFywSlDaZiCw4jErWqSRIqEpI3epr4AW pUfu6e93kKJAjMEAAEKAB0WIQRO8+4RTnqPKsqn0bgbX0TJAJUVVgUCZ6ChSAAKCRAbX0TJAJUV VkinEADM92QE1zN3OdqwoLmwOoyxpCMwh545d6+dM1Jydy6p2+/Kc4BB1xjuxNF1HNo5rtoqH07 ym9dN4Q2Qq7XF1KIk/3CrsDT4I6xsQyH+dZXcInkRjCUYzr92gP/vw1kR3ZEqKR0MhGKoby+vee AMNZ73KL9sbyxqDOSvYlfU64YT+4M3Y0RjyunUFlc8d0B77KoL9D1lf+9S/cf/VIG5xt10eHvCI Y/7TVphY3czZAV8pnzwIf8rvKl8ovXxM1wuxLd5rbHSICbG9xkbeuPm9Gk0ayUP21CpdlnMwnrO ZgiMbd646uADECWUTsnLP+vy/yGmYdZk+wxCNssoiv8Uwdn5ZBIDrTreTRLOTRfs0yrkWKw+2Rr nvsWS9eg48JbmcR2ZEUHO9TK8fTbA7zOnb/X1M9Xm6dTObpCTrH/1WvFKyJHOT+F8lkUhOhWYM5 FHml27aV+44Peh/GLto6Qzz4d2+f92sCsBH9ywrCKadg7S/0e9kxiYCsVG5CPv74tlxnI1MJTIk 38joR4PETewNrhxKk1ppq87XoZJCSGrVxk/IZsbYHALamKacJUTrn6kJ91yS/mNIU23LtyOTkdh M2PhJ+2wRSHuQtQv19TyrWt+d38PCVc5NM4iGWqb0J4QbPzEgPwhp1xeCLwRcvp1mk/vM6udNFY hRWMZsNaZcQlw7w== X-Developer-Key: i=abel.vesa@linaro.org; a=openpgp; fpr=6AFF162D57F4223A8770EF5AF7BF214136F41FAE Link Training Tunable PHY Repeaters (LTTPRs) are defined in DisplayPort 1.4a specification. As the name suggests, these PHY repeaters are capable of adjusting their output for link training purposes. According to the DisplayPort standard, LTTPRs have two operating modes: - non-transparent - it replies to DPCD LTTPR field specific AUX requests, while passes through all other AUX requests - transparent - it passes through all AUX requests. Switching between these two modes is done by the DPTX by issuing an AUX write to the DPCD PHY_REPEATER_MODE register. The msm DP driver is currently lacking any handling of LTTPRs. This means that if at least one LTTPR is found between DPTX and DPRX, the link training would fail if that LTTPR was not already configured in transparent mode. The section 3.6.6.1 from the DisplayPort v2.0 specification mandates that before link training with the LTTPR is started, the DPTX may place the LTTPR in non-transparent mode by first switching to transparent mode and then to non-transparent mode. This operation seems to be needed only on first link training and doesn't need to be done again until device is unplugged. It has been observed on a few X Elite-based platforms which have such LTTPRs in their board design that the DPTX needs to follow the procedure described above in order for the link training to be successful. So add support for reading the LTTPR DPCD caps to figure out the number of such LTTPRs first. Then, for platforms (or Type-C dongles) that have at least one such an LTTPR, set its operation mode to transparent mode first and then to non-transparent, just like the mentioned section of the specification mandates. Tested-by: Johan Hovold Reviewed-by: Dmitry Baryshkov Reviewed-by: Johan Hovold Signed-off-by: Abel Vesa --- drivers/gpu/drm/msm/dp/dp_display.c | 15 +++++++++++++++ 1 file changed, 15 insertions(+) diff --git a/drivers/gpu/drm/msm/dp/dp_display.c b/drivers/gpu/drm/msm/dp/dp_display.c index 24dd37f1682bf5016bb0efbeb44489061deff060..1dd8f94e27475ae5b5b25d80f758968e6818f6cc 100644 --- a/drivers/gpu/drm/msm/dp/dp_display.c +++ b/drivers/gpu/drm/msm/dp/dp_display.c @@ -367,6 +367,19 @@ static int msm_dp_display_send_hpd_notification(struct msm_dp_display_private *d return 0; } +static void msm_dp_display_lttpr_init(struct msm_dp_display_private *dp) +{ + u8 lttpr_caps[DP_LTTPR_COMMON_CAP_SIZE]; + int rc; + + if (drm_dp_read_lttpr_common_caps(dp->aux, dp->panel->dpcd, lttpr_caps)) + return; + + rc = drm_dp_lttpr_init(dp->aux, drm_dp_lttpr_count(lttpr_caps)); + if (rc) + DRM_ERROR("failed to set LTTPRs transparency mode, rc=%d\n", rc); +} + static int msm_dp_display_process_hpd_high(struct msm_dp_display_private *dp) { struct drm_connector *connector = dp->msm_dp_display.connector; @@ -377,6 +390,8 @@ static int msm_dp_display_process_hpd_high(struct msm_dp_display_private *dp) if (rc) goto end; + msm_dp_display_lttpr_init(dp); + msm_dp_link_process_request(dp->link); if (!dp->msm_dp_display.is_edp)