From patchwork Mon Jan 27 14:17:16 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Michael Tokarev X-Patchwork-Id: 860264 Delivered-To: patch@linaro.org Received: by 2002:a05:6000:18c8:b0:385:e875:8a9e with SMTP id w8csp2044602wrq; Mon, 27 Jan 2025 06:26:48 -0800 (PST) X-Forwarded-Encrypted: i=2; AJvYcCVk+mG5qgDaSpsX7768T9JiAgAwZM4S2oOVPOMzNvS4lUldbbJhVmj3IPAd/uSW3AzejcAGxA==@linaro.org X-Google-Smtp-Source: AGHT+IHgBSW0hpD8zhPD6gxUBja/3TV0/vlF3r7tYsbVOH1foHN0CnaFzx7ez+LGb7HelXrzbL1O X-Received: by 2002:a05:6214:ca9:b0:6d8:ad28:adbf with SMTP id 6a1803df08f44-6e1b21a0c5fmr604311586d6.20.1737988007837; Mon, 27 Jan 2025 06:26:47 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1737988007; cv=none; d=google.com; s=arc-20240605; b=QWdJZ48DFpdCMH35Hcn16lsBH/OAdtaH6B4Jr0TY4c0/UmxT7Sylyupqh24ZdrlmOG T1c/Yo7tG7PUy8y2rBi89sfHQ7Y5P23TpKZ3SNGTNBF33HQjAUqIp2sEz1j8letU6Bwz rtdOU0mtImyFIplZXQ7Zb7SwdpJ+BH9XfIkT9iDMiz+YXjTorjpznWvdOSUg2dNjANFy ooptkJ4qVrpYvbJJIs89Cgm7GSXC3nuuzhtqxI38G2lVh7VO6dYUo6hcgEdOVfHoEJGF H4/TeUvyq/DFtk9pJvxLA9Jq+pMI9/bwFMBeZ4xhfD/+/ZvE2pc63Aprb6PoU05L4pHy tfjw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:cc:to :from; bh=XCEFpe4Ue760/IPZuqwjqpZVx5VdQa70mRKgKJi6lxQ=; fh=pf+ec3LEfrqMT+5gdCXHweMh6LzvAi5DC66/0Pko6EE=; b=BC/LWusSN/1YZ+Jd3p9G1XJZXQVIC26sAvdZULdoeypq8H9oF5YkaRt2O6KgzzdJe3 g9Nw49fZiN/+hYg5d6ylwOaThkhQS4wsEmD9Y6p3YQLiulsCk8A6J72HoNJyl1MSSv7Z iHsSIwXFcMnglcpnFxQTUe6mFL9uC0u6yW/BMaVrG1z1XlmTmj58KbnbEtwQfJ/RjZA7 1tSFZ04pRMQtZNM0duV8S1nv68V4bX9z+x6Xy3o6x5nzEoK6RpAFRB++AxnfcOYbHxC6 RM2sF7D76VrNINT1mcJXXBDD339RvczvH4NgrEF00mwrMyhd/6TOzeobjglegZMUHSN1 yfng==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org" Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id 6a1803df08f44-6e20525e381si99810636d6.82.2025.01.27.06.26.47 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Mon, 27 Jan 2025 06:26:47 -0800 (PST) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org" Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tcQ2y-00047F-Ku; Mon, 27 Jan 2025 09:25:10 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tcQ2d-0003S8-J6; Mon, 27 Jan 2025 09:24:43 -0500 Received: from isrv.corpit.ru ([86.62.121.231]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tcQ2b-00031S-MW; Mon, 27 Jan 2025 09:24:43 -0500 Received: from localhost.tls.msk.ru (mjt.wg.tls.msk.ru [192.168.177.130]) by isrv.corpit.ru (Postfix) with ESMTP id 5269AE0F71; Mon, 27 Jan 2025 17:24:11 +0300 (MSK) Received: by localhost.tls.msk.ru (Postfix, from userid 1000) id 5E85951D61; Mon, 27 Jan 2025 17:18:03 +0300 (MSK) From: Michael Tokarev To: qemu-devel@nongnu.org Cc: qemu-stable@nongnu.org, Richard Henderson , wannacu , Pierrick Bouvier , =?utf-8?q?Philippe_Mathieu-?= =?utf-8?q?Daud=C3=A9?= , Michael Tokarev Subject: [Stable-9.2.1 02/41] tcg: Reset free_temps before tcg_optimize Date: Mon, 27 Jan 2025 17:17:16 +0300 Message-Id: <20250127141803.3514882-2-mjt@tls.msk.ru> X-Mailer: git-send-email 2.39.5 In-Reply-To: References: MIME-Version: 1.0 Received-SPF: pass client-ip=86.62.121.231; envelope-from=mjt@tls.msk.ru; helo=isrv.corpit.ru X-Spam_score_int: -68 X-Spam_score: -6.9 X-Spam_bar: ------ X-Spam_report: (-6.9 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_HI=-5, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: qemu-devel-bounces+patch=linaro.org@nongnu.org From: Richard Henderson When allocating new temps during tcg_optmize, do not re-use any EBB temps that were used within the TB. We do not have any idea what span of the TB in which the temp was live. Introduce tcg_temp_ebb_reset_freed and use before tcg_optimize, as well as replacing the equivalent in plugin_gen_inject and tcg_func_start. Cc: qemu-stable@nongnu.org Fixes: fb04ab7ddd8 ("tcg/optimize: Lower TCG_COND_TST{EQ,NE} if unsupported") Resolves: https://gitlab.com/qemu-project/qemu/-/issues/2711 Reported-by: wannacu Signed-off-by: Richard Henderson Reviewed-by: Pierrick Bouvier Reviewed-by: Philippe Mathieu-Daudé (cherry picked from commit 04e006ab36a8565b92d4e21dd346367fbade7d74) Signed-off-by: Michael Tokarev diff --git a/accel/tcg/plugin-gen.c b/accel/tcg/plugin-gen.c index 0f47bfbb48..1ef075552c 100644 --- a/accel/tcg/plugin-gen.c +++ b/accel/tcg/plugin-gen.c @@ -275,7 +275,7 @@ static void plugin_gen_inject(struct qemu_plugin_tb *plugin_tb) * that might be live within the existing opcode stream. * The simplest solution is to release them all and create new. */ - memset(tcg_ctx->free_temps, 0, sizeof(tcg_ctx->free_temps)); + tcg_temp_ebb_reset_freed(tcg_ctx); QTAILQ_FOREACH_SAFE(op, &tcg_ctx->ops, link, next) { switch (op->opc) { diff --git a/include/tcg/tcg-temp-internal.h b/include/tcg/tcg-temp-internal.h index 44192c55a9..98f91e68b7 100644 --- a/include/tcg/tcg-temp-internal.h +++ b/include/tcg/tcg-temp-internal.h @@ -42,4 +42,10 @@ TCGv_i64 tcg_temp_ebb_new_i64(void); TCGv_ptr tcg_temp_ebb_new_ptr(void); TCGv_i128 tcg_temp_ebb_new_i128(void); +/* Forget all freed EBB temps, so that new allocations produce new temps. */ +static inline void tcg_temp_ebb_reset_freed(TCGContext *s) +{ + memset(s->free_temps, 0, sizeof(s->free_temps)); +} + #endif /* TCG_TEMP_FREE_H */ diff --git a/tcg/tcg.c b/tcg/tcg.c index 0babae1b88..4578b185be 100644 --- a/tcg/tcg.c +++ b/tcg/tcg.c @@ -1489,7 +1489,7 @@ void tcg_func_start(TCGContext *s) s->nb_temps = s->nb_globals; /* No temps have been previously allocated for size or locality. */ - memset(s->free_temps, 0, sizeof(s->free_temps)); + tcg_temp_ebb_reset_freed(s); /* No constant temps have been previously allocated. */ for (int i = 0; i < TCG_TYPE_COUNT; ++i) { @@ -6120,6 +6120,9 @@ int tcg_gen_code(TCGContext *s, TranslationBlock *tb, uint64_t pc_start) } #endif + /* Do not reuse any EBB that may be allocated within the TB. */ + tcg_temp_ebb_reset_freed(s); + tcg_optimize(s); reachable_code_pass(s); From patchwork Mon Jan 27 14:17:21 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Michael Tokarev X-Patchwork-Id: 860261 Delivered-To: patch@linaro.org Received: by 2002:a05:6000:18c8:b0:385:e875:8a9e with SMTP id w8csp2042973wrq; Mon, 27 Jan 2025 06:23:04 -0800 (PST) X-Forwarded-Encrypted: i=2; AJvYcCX/uRG4PGptUqjpYRFPOiD3nuUo0/mBphn5Do02CkgIogzUfEWMxLC7Jftk8KBXRU5UNT98Fg==@linaro.org X-Google-Smtp-Source: AGHT+IFFSaKquP593pCnN9kAXCr3uoeGgeiNHCcED/cNhD7kYcwKcwCbKHJs5Tr/YfgV9SGUm9FE X-Received: by 2002:ac8:5989:0:b0:466:a04c:e9db with SMTP id d75a77b69052e-46e12b7beeamr675927561cf.33.1737987784159; Mon, 27 Jan 2025 06:23:04 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1737987784; cv=none; d=google.com; s=arc-20240605; b=ZEwpxxFccg4LAIUuKyRSlN3FnrwN6DRNz7AhqmQLnmVjtQylUJKRv+vvA4DAS66ZuL Esb4rLC1s/qWkolOEJQCxRkWYvmkdIDeo6nhUDyzOpZYgdy0Pfypmk4EhzRkBQ08XBbw qdQicGwYOkmwS0fSW6SSeVnKOf10S/pW8/sEVNjzlt+QFVkk7HlxjeTeJKTMEmJuy9X5 Eh9s7PYnjGovIozH1KxOx9z0iuTGcFaHHOdq2cnRhr0r84fCCPlYF9TWgIN2cg7L3QA9 CN/JrF3M2+aFU6JasSZWIJ3cO1Mirltd0Ck8rt6AoButMqWDKJE/Pm42b4VHvbWNzBKN +3pg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:cc:to :from; bh=rwLFSTNQyQzeYzOlABMGr4/WYUVrw2WoeRH5UVRUEJY=; fh=L196pQKRERZGaJF7hFtC+jRPyzKAn1vHHXd3Z6ZIEH8=; b=V9K8HHYL2t7JR27my2wOv1MnTOvbAO2YYbuEFVNvyQELcHkwhypfoCwwLxCCXFpJGi yPAumC4IY3Ce7BHcPyv8ql1slJoJJisn1Z20eEor35ep2FaUSrhOpDzSmF5AKsRjNVYd YAdr1oAvK/UL3OrYCrN8s6ScPEMYjHGPGPlQ3F3/AcqzkpIcMJl5WHUz1F8iELRxu+y/ zaYqHhbIoe13m+U4u4AhRNAs7J7wvJAC46wNtGOQXm5B/3NLjRTG4ypv+eJyZ6swkA4u TDgYFKlirrnpSF72PtsFhmhC5Bk+i3LxiU4LnsDdfxpNKOYiyAhatoF5VxiJxgLDw2nV pYuQ==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org" Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id 6a1803df08f44-6e206011752si102912786d6.371.2025.01.27.06.23.03 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Mon, 27 Jan 2025 06:23:04 -0800 (PST) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org" Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tcQ05-0003mP-76; Mon, 27 Jan 2025 09:22:05 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tcPzx-0003Ty-Nv; Mon, 27 Jan 2025 09:21:58 -0500 Received: from isrv.corpit.ru ([86.62.121.231]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tcPzv-0002qQ-FH; Mon, 27 Jan 2025 09:21:57 -0500 Received: from localhost.tls.msk.ru (mjt.wg.tls.msk.ru [192.168.177.130]) by isrv.corpit.ru (Postfix) with ESMTP id 3CED8E0F49; Mon, 27 Jan 2025 17:21:25 +0300 (MSK) Received: by localhost.tls.msk.ru (Postfix, from userid 1000) id 6A57451D6B; Mon, 27 Jan 2025 17:18:03 +0300 (MSK) From: Michael Tokarev To: qemu-devel@nongnu.org Cc: qemu-stable@nongnu.org, Peter Maydell , Richard Henderson , =?utf-8?q?Philippe_Mathie?= =?utf-8?q?u-Daud=C3=A9?= , Michael Tokarev Subject: [Stable-9.2.1 07/41] hw/intc/arm_gicv3_its: Zero initialize local DTEntry etc structs Date: Mon, 27 Jan 2025 17:17:21 +0300 Message-Id: <20250127141803.3514882-7-mjt@tls.msk.ru> X-Mailer: git-send-email 2.39.5 In-Reply-To: References: MIME-Version: 1.0 Received-SPF: pass client-ip=86.62.121.231; envelope-from=mjt@tls.msk.ru; helo=isrv.corpit.ru X-Spam_score_int: -68 X-Spam_score: -6.9 X-Spam_bar: ------ X-Spam_report: (-6.9 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_HI=-5, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: qemu-devel-bounces+patch=linaro.org@nongnu.org From: Peter Maydell In the GICv3 ITS model, we have a common coding pattern which has a local C struct like "DTEntry dte", which is a C representation of an in-guest-memory data structure, and we call a function such as get_dte() to read guest memory and fill in the C struct. These functions to read in the struct sometimes have cases where they will leave early and not fill in the whole struct (for instance get_dte() will set "dte->valid = false" and nothing else for the case where it is passed an entry_addr implying that there is no L2 table entry for the DTE). This then causes potential use of uninitialized memory later, for instance when we call a trace event which prints all the fields of the struct. Sufficiently advanced compilers may produce -Wmaybe-uninitialized warnings about this, especially if LTO is enabled. Rather than trying to carefully separate out these trace events into "only the 'valid' field is initialized" and "all fields can be printed", zero-init all the structs when we define them. None of these structs are large (the biggest is 24 bytes) and having consistent behaviour is less likely to be buggy. Cc: qemu-stable@nongnu.org Resolves: https://gitlab.com/qemu-project/qemu/-/issues/2718 Signed-off-by: Peter Maydell Reviewed-by: Richard Henderson Reviewed-by: Philippe Mathieu-Daudé Message-id: 20241213182337.3343068-1-peter.maydell@linaro.org (cherry picked from commit 9678b9c505725732353baefedb88b53c2eb8a184) Signed-off-by: Michael Tokarev diff --git a/hw/intc/arm_gicv3_its.c b/hw/intc/arm_gicv3_its.c index bf31158470..752322a3e7 100644 --- a/hw/intc/arm_gicv3_its.c +++ b/hw/intc/arm_gicv3_its.c @@ -465,7 +465,7 @@ static ItsCmdResult lookup_vte(GICv3ITSState *s, const char *who, static ItsCmdResult process_its_cmd_phys(GICv3ITSState *s, const ITEntry *ite, int irqlevel) { - CTEntry cte; + CTEntry cte = {}; ItsCmdResult cmdres; cmdres = lookup_cte(s, __func__, ite->icid, &cte); @@ -479,7 +479,7 @@ static ItsCmdResult process_its_cmd_phys(GICv3ITSState *s, const ITEntry *ite, static ItsCmdResult process_its_cmd_virt(GICv3ITSState *s, const ITEntry *ite, int irqlevel) { - VTEntry vte; + VTEntry vte = {}; ItsCmdResult cmdres; cmdres = lookup_vte(s, __func__, ite->vpeid, &vte); @@ -514,8 +514,8 @@ static ItsCmdResult process_its_cmd_virt(GICv3ITSState *s, const ITEntry *ite, static ItsCmdResult do_process_its_cmd(GICv3ITSState *s, uint32_t devid, uint32_t eventid, ItsCmdType cmd) { - DTEntry dte; - ITEntry ite; + DTEntry dte = {}; + ITEntry ite = {}; ItsCmdResult cmdres; int irqlevel; @@ -583,8 +583,8 @@ static ItsCmdResult process_mapti(GICv3ITSState *s, const uint64_t *cmdpkt, uint32_t pIntid = 0; uint64_t num_eventids; uint16_t icid = 0; - DTEntry dte; - ITEntry ite; + DTEntry dte = {}; + ITEntry ite = {}; devid = (cmdpkt[0] & DEVID_MASK) >> DEVID_SHIFT; eventid = cmdpkt[1] & EVENTID_MASK; @@ -651,8 +651,8 @@ static ItsCmdResult process_vmapti(GICv3ITSState *s, const uint64_t *cmdpkt, { uint32_t devid, eventid, vintid, doorbell, vpeid; uint32_t num_eventids; - DTEntry dte; - ITEntry ite; + DTEntry dte = {}; + ITEntry ite = {}; if (!its_feature_virtual(s)) { return CMD_CONTINUE; @@ -761,7 +761,7 @@ static bool update_cte(GICv3ITSState *s, uint16_t icid, const CTEntry *cte) static ItsCmdResult process_mapc(GICv3ITSState *s, const uint64_t *cmdpkt) { uint16_t icid; - CTEntry cte; + CTEntry cte = {}; icid = cmdpkt[2] & ICID_MASK; cte.valid = cmdpkt[2] & CMD_FIELD_VALID_MASK; @@ -822,7 +822,7 @@ static bool update_dte(GICv3ITSState *s, uint32_t devid, const DTEntry *dte) static ItsCmdResult process_mapd(GICv3ITSState *s, const uint64_t *cmdpkt) { uint32_t devid; - DTEntry dte; + DTEntry dte = {}; devid = (cmdpkt[0] & DEVID_MASK) >> DEVID_SHIFT; dte.size = cmdpkt[1] & SIZE_MASK; @@ -886,9 +886,9 @@ static ItsCmdResult process_movi(GICv3ITSState *s, const uint64_t *cmdpkt) { uint32_t devid, eventid; uint16_t new_icid; - DTEntry dte; - CTEntry old_cte, new_cte; - ITEntry old_ite; + DTEntry dte = {}; + CTEntry old_cte = {}, new_cte = {}; + ITEntry old_ite = {}; ItsCmdResult cmdres; devid = FIELD_EX64(cmdpkt[0], MOVI_0, DEVICEID); @@ -965,7 +965,7 @@ static bool update_vte(GICv3ITSState *s, uint32_t vpeid, const VTEntry *vte) static ItsCmdResult process_vmapp(GICv3ITSState *s, const uint64_t *cmdpkt) { - VTEntry vte; + VTEntry vte = {}; uint32_t vpeid; if (!its_feature_virtual(s)) { @@ -1030,7 +1030,7 @@ static void vmovp_callback(gpointer data, gpointer opaque) */ GICv3ITSState *s = data; VmovpCallbackData *cbdata = opaque; - VTEntry vte; + VTEntry vte = {}; ItsCmdResult cmdres; cmdres = lookup_vte(s, __func__, cbdata->vpeid, &vte); @@ -1085,9 +1085,9 @@ static ItsCmdResult process_vmovi(GICv3ITSState *s, const uint64_t *cmdpkt) { uint32_t devid, eventid, vpeid, doorbell; bool doorbell_valid; - DTEntry dte; - ITEntry ite; - VTEntry old_vte, new_vte; + DTEntry dte = {}; + ITEntry ite = {}; + VTEntry old_vte = {}, new_vte = {}; ItsCmdResult cmdres; if (!its_feature_virtual(s)) { @@ -1186,10 +1186,10 @@ static ItsCmdResult process_vinvall(GICv3ITSState *s, const uint64_t *cmdpkt) static ItsCmdResult process_inv(GICv3ITSState *s, const uint64_t *cmdpkt) { uint32_t devid, eventid; - ITEntry ite; - DTEntry dte; - CTEntry cte; - VTEntry vte; + ITEntry ite = {}; + DTEntry dte = {}; + CTEntry cte = {}; + VTEntry vte = {}; ItsCmdResult cmdres; devid = FIELD_EX64(cmdpkt[0], INV_0, DEVICEID); From patchwork Mon Jan 27 14:17:27 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Michael Tokarev X-Patchwork-Id: 860260 Delivered-To: patch@linaro.org Received: by 2002:a05:6000:18c8:b0:385:e875:8a9e with SMTP id w8csp2042960wrq; Mon, 27 Jan 2025 06:23:03 -0800 (PST) X-Forwarded-Encrypted: i=2; AJvYcCXY2fzuwi5v5OBdinkVUVeEmuDAHq43yCn3gCLDRzJn7dOBk5V2hOICvNujh+8pbSZbQI5Amw==@linaro.org X-Google-Smtp-Source: AGHT+IHeq6TpVPxHQxeDJoziwq3XEYdFn3w1y1V9wfb4nmN4llxCVsYYSeJJ8H8S1bddVyo0AEW1 X-Received: by 2002:ac8:5802:0:b0:467:71bb:480c with SMTP id d75a77b69052e-46e12b96cf4mr604194241cf.49.1737987783602; Mon, 27 Jan 2025 06:23:03 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1737987783; cv=none; d=google.com; s=arc-20240605; b=iILG4arfKqTRpnigr1CY/m3EHT2HFNZ3Wc18d0ELfVTekkPI+2IwC/X1PrfRPJ8ka2 WQ0sAaxcIZb6BwAezrrrxxVMZDMVDi8GBxJmqz5942yU/PSalMPlFnp7vyMgwS4QE5zo KJFr2JwHgebh6AghgTo4/o2Z9CvmZSy8ea18E/oQFNVYxXktgBIk8edgveuOLfq0MQc3 K9nf4ic/UYW90FHOTD9STkbw1iP06GNV2kAGpA/XwPsdB84N/YqkuRM/3iStdo8sYxAS t1Y73vrpQsDuBtZ3psij28k4XVx97gMw83T90DPY/1p6tl8jA/dT1obnK+Sj4Y9qXt6W xj1w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:cc:to :from; bh=PQn0buRCobehxOf7so+pr2WTSkngqZG98VIQnKDy11Y=; fh=9huKQHkgI/I6TYR+tXMRab7SsZa9txramfDjkvZAuXQ=; b=Znh70iRZ3MLSxdNxxJEZnOgt0elYyTxghBCMTPWPavET2EAujt5RIwoJfwutMsIV4v oJYqQr2LNDvYmp569bJdZNDjFTVVYTzj5wGp+tSKJpZk8NiDryxZ3wzvsyalpJ19NJ6c Qa8nN+zRo/oq6dczx40iB2mmOqoNKu9eVEgd4dvROC33S5VVVX4VQnpcmoNYLg4cDOa6 VPh3I6ukNi/kb37aSeqfreYCDtolWQHnZaK8eSTpJTvYFpI4KawNfq+DiukqfjOUaX81 ipoFkXvpZCzleYoq9uK0B2rps527/HBlajGph6z0vcLfsiA90iTNC4JRaINuSyPAOkfi J6rg==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org" Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id d75a77b69052e-46e66bab184si106761611cf.595.2025.01.27.06.23.03 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Mon, 27 Jan 2025 06:23:03 -0800 (PST) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org" Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tcQ0T-0004TL-Bp; Mon, 27 Jan 2025 09:22:29 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tcQ02-0003kI-1x; Mon, 27 Jan 2025 09:22:02 -0500 Received: from isrv.corpit.ru ([86.62.121.231]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tcPzz-0002rD-Tx; Mon, 27 Jan 2025 09:22:01 -0500 Received: from localhost.tls.msk.ru (mjt.wg.tls.msk.ru [192.168.177.130]) by isrv.corpit.ru (Postfix) with ESMTP id 5047EE0F4C; Mon, 27 Jan 2025 17:21:25 +0300 (MSK) Received: by localhost.tls.msk.ru (Postfix, from userid 1000) id 7936E51D7C; Mon, 27 Jan 2025 17:18:03 +0300 (MSK) From: Michael Tokarev To: qemu-devel@nongnu.org Cc: qemu-stable@nongnu.org, =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= , =?utf-8?q?Alex?= =?utf-8?q?_Benn=C3=A9e?= , Michael Tokarev Subject: [Stable-9.2.1 13/41] docs: Correct '-runas' and '-fsdev/-virtfs proxy' indentation Date: Mon, 27 Jan 2025 17:17:27 +0300 Message-Id: <20250127141803.3514882-13-mjt@tls.msk.ru> X-Mailer: git-send-email 2.39.5 In-Reply-To: References: MIME-Version: 1.0 Received-SPF: pass client-ip=86.62.121.231; envelope-from=mjt@tls.msk.ru; helo=isrv.corpit.ru X-Spam_score_int: -68 X-Spam_score: -6.9 X-Spam_bar: ------ X-Spam_report: (-6.9 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_HI=-5, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: qemu-devel-bounces+patch=linaro.org@nongnu.org From: Philippe Mathieu-Daudé Use the same style for deprecated / removed commands. Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Alex Bennée Reviewed-by: Michael Tokarev Signed-off-by: Michael Tokarev (cherry picked from commit 916f50172baa91ddf0e669a9d6d2747055c0e610) Signed-off-by: Michael Tokarev diff --git a/docs/about/deprecated.rst b/docs/about/deprecated.rst index d8dc29d0a4..b1f4a51325 100644 --- a/docs/about/deprecated.rst +++ b/docs/about/deprecated.rst @@ -75,7 +75,7 @@ marked deprecated since 9.0, users have to ensure that all the topology members described with -smp are supported by the target machine. ``-runas`` (since 9.1) ----------------------- +'''''''''''''''''''''' Use ``-run-with user=..`` instead. diff --git a/docs/about/removed-features.rst b/docs/about/removed-features.rst index ee6455aeee..563a614738 100644 --- a/docs/about/removed-features.rst +++ b/docs/about/removed-features.rst @@ -518,7 +518,7 @@ and later do not support it because the virtio-scsi device was introduced for full SCSI support. Use virtio-scsi instead when SCSI passthrough is required. ``-fsdev proxy`` and ``-virtfs proxy`` (since 9.2) -^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ +'''''''''''''''''''''''''''''''''''''''''''''''''' The 9p ``proxy`` filesystem backend driver was originally developed to enhance security by dispatching low level filesystem operations from 9p From patchwork Mon Jan 27 14:17:28 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Michael Tokarev X-Patchwork-Id: 860263 Delivered-To: patch@linaro.org Received: by 2002:a05:6000:18c8:b0:385:e875:8a9e with SMTP id w8csp2044111wrq; Mon, 27 Jan 2025 06:25:39 -0800 (PST) X-Forwarded-Encrypted: i=2; AJvYcCUU07IagCPcg1X03wkXjIZof84+kzhPBiDch69iz9ym3JNe6mQKdoj5IfS4Q+JTG5A5MfyOcw==@linaro.org X-Google-Smtp-Source: AGHT+IGnb2ZM4shigdLlqZg+5h93RUsfmH++U3JrDUpHUT5tWRvDviNSgVzia7fbIwjwbnOFpqFO X-Received: by 2002:a05:6214:3292:b0:6d8:9f61:de6c with SMTP id 6a1803df08f44-6e1f9fd21abmr279431856d6.18.1737987939222; Mon, 27 Jan 2025 06:25:39 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1737987939; cv=none; d=google.com; s=arc-20240605; b=RggKmLHN2lJixsxQPYxIwhvHCz12Nd3c+ZTYc78WFrF407SAb7hySJFw6P2tO/WU98 TfBYOuQYhReXXRtPOfQKmcYQWTXV4XmsFJWf5nFOV1pZ70kLTM8O5pFeQ/m1jcctYvqR +jmum9pPnkfubc1/D3MmzyIoIe+YHnKtDYtWatCLGi/ogqwybd29RP2Niw3pMdsWDYEc /zwwBpzpUuT8V8/zYHdsJYFQ9QpBEtzE432EcpywGAjXCXy0IC3SDp5EhoWtApO1jGPF qFd6/mQ/q54/JtkywjizJ2tr9i8W+CrKtyDvhq28KSJNoNZWKaZw3OKiTa/elVhCvCOK yuVg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:cc:to :from; bh=f3UKYMYUd18mWxIOE9OhR6rMvNFWzBvZnHmYjOoCrr8=; fh=9huKQHkgI/I6TYR+tXMRab7SsZa9txramfDjkvZAuXQ=; b=X6pAdRel1zUBmi0VihcqcJ5KG4nrerfu7ZZY7lmD8G5CaBObC5e77HNTklMnhvz5Ig gaWP7O07W6cwfk3XkeUJ6nYJoZa4NjuOzcvoByuWaBI9M/zclx1NRIFpGKoJZC10gXef rOWxPI5p1e1+T2VkxzAbSAZMHYMBzh1VOQZ7nSipKgHPS0YwYOypXXlNYG+oDP2lNGIU qbjVut9moGJk6aNh5SpqfcfjZf1bKK86Uap9tuYwc9bX6iUCHONrZRAZNCuu9H9tO1Ah rt/k1oFqXwmYQ3bEc5ND6sm9GlSCVjhHnGS+I9ZQWZEBOrcfY08zMGe/CaFboxYYcPlg dsIw==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org" Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id 6a1803df08f44-6e205f03b05si94694076d6.350.2025.01.27.06.25.39 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Mon, 27 Jan 2025 06:25:39 -0800 (PST) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org" Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tcQ09-000408-Gu; Mon, 27 Jan 2025 09:22:09 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tcPzy-0003W6-IP; Mon, 27 Jan 2025 09:21:58 -0500 Received: from isrv.corpit.ru ([86.62.121.231]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tcPzw-0002qh-OT; Mon, 27 Jan 2025 09:21:58 -0500 Received: from localhost.tls.msk.ru (mjt.wg.tls.msk.ru [192.168.177.130]) by isrv.corpit.ru (Postfix) with ESMTP id 42DD0E0F4A; Mon, 27 Jan 2025 17:21:25 +0300 (MSK) Received: by localhost.tls.msk.ru (Postfix, from userid 1000) id 7BADD51D80; Mon, 27 Jan 2025 17:18:03 +0300 (MSK) From: Michael Tokarev To: qemu-devel@nongnu.org Cc: qemu-stable@nongnu.org, =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= , =?utf-8?q?Alex?= =?utf-8?q?_Benn=C3=A9e?= , Michael Tokarev Subject: [Stable-9.2.1 14/41] docs: Correct release of TCG trace-events removal Date: Mon, 27 Jan 2025 17:17:28 +0300 Message-Id: <20250127141803.3514882-14-mjt@tls.msk.ru> X-Mailer: git-send-email 2.39.5 In-Reply-To: References: MIME-Version: 1.0 Received-SPF: pass client-ip=86.62.121.231; envelope-from=mjt@tls.msk.ru; helo=isrv.corpit.ru X-Spam_score_int: -68 X-Spam_score: -6.9 X-Spam_bar: ------ X-Spam_report: (-6.9 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_HI=-5, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: qemu-devel-bounces+patch=linaro.org@nongnu.org From: Philippe Mathieu-Daudé TCG trace-events were deprecated before the v6.2 release, and removed for v7.0. Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Alex Bennée Reviewed-by: Michael Tokarev Signed-off-by: Michael Tokarev (cherry picked from commit b4859e8f33a7d9c793a60395f792c10190cb4f78) Signed-off-by: Michael Tokarev diff --git a/docs/about/removed-features.rst b/docs/about/removed-features.rst index 563a614738..93086f9cd5 100644 --- a/docs/about/removed-features.rst +++ b/docs/about/removed-features.rst @@ -1077,8 +1077,8 @@ processor IP (see `Intel discontinuance notification`_). TCG introspection features -------------------------- -TCG trace-events (since 6.2) -'''''''''''''''''''''''''''' +TCG trace-events (removed in 7.0) +''''''''''''''''''''''''''''''''' The ability to add new TCG trace points had bit rotted and as the feature can be replicated with TCG plugins it was removed. If From patchwork Mon Jan 27 14:17:42 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Michael Tokarev X-Patchwork-Id: 860265 Delivered-To: patch@linaro.org Received: by 2002:a05:6000:18c8:b0:385:e875:8a9e with SMTP id w8csp2044630wrq; Mon, 27 Jan 2025 06:26:51 -0800 (PST) X-Forwarded-Encrypted: i=2; AJvYcCW0vR9D5g/e1yYiqLUx/bEAh8kCeM2993Blk65xX51NMZzpsEGlvqsU8k1QLyjKpgEEJ6zIAw==@linaro.org X-Google-Smtp-Source: AGHT+IHw2zHzDxy2lErUctVzRTRy5HOyRn2OI4LAd0ZO50P42gcDj/Do2+xGylY/4YyijfJQw3yr X-Received: by 2002:a05:622a:4c:b0:468:f722:d44c with SMTP id d75a77b69052e-46e12a3fa99mr655817901cf.21.1737988010903; Mon, 27 Jan 2025 06:26:50 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1737988010; cv=none; d=google.com; s=arc-20240605; b=cKM9qDqBjwgO5noEdIni04mw04ggEfJQYZv8T55BF5KHxHN4egK0hGClri30ied2ZT AD6MfxcK3DN9mSuly+8MeIkK/6RPLsfWcn5egDjba8p6wXlhmW56AUnbf2/6JE6Jjav6 xRlOUs/Uc4n/oXu2jCYepLj2s2EHfuE2uhD0ov8IpKvwwe9gxViuectUKSkO9cHskB6I br2amlHEY//Sdyp7iHNpitgR/XvR+Y4rBTL8S4/uzaf3zKmrLC7fCo6qDs+rfL4L/KrR +ggtL7mUoI8Q4AWw8SdW2+gunqF76B561u875m+qX45cgTdMfCGVoFcIcbFrpKgwKAP3 MHVg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:cc:to :from; bh=EbClx/7Ch7hY9t9jKX1RHRTDQ5CcQtqkBLqGZpNEigs=; fh=+5Hc+HRFXzif30KS8a8zfdpFc6Ps3s7165GByRHu2ck=; b=FnEK9jB6TAvSA/N51usxx9+Ic4ZHGs1qIcX/Dj5YnsAGyoOCNPOw2ihKyRNMq9upq5 V0bymPem8bYeAMgMAF/OeUnCQCGwmn2YQPkgp6V/CnjgUFtdmCYPM4w/4AKXXSpyypb4 fFvJRGts0WxGsvApXF0Ml2iehCSFIC+IZdAgwNb1x1kuCAAaa8WesGsjri2vijJwCJDn gQusoyflwSBMfHcRRkQG4dvyFAgErq0frh130lujsVD10f0Mz5s6XmD9VCGz2RXiiZds I2pAOJIQYkkQNBONXU1D287yVnx75aVBEiJDpacJujZN2igPXOl+GxNRkfeLkZHn6rRO rZTA==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org" Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id d75a77b69052e-46e66b888b2si108109201cf.421.2025.01.27.06.26.50 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Mon, 27 Jan 2025 06:26:50 -0800 (PST) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org" Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tcQ4N-0006iG-RT; Mon, 27 Jan 2025 09:26:31 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tcQ47-0005qH-4d; Mon, 27 Jan 2025 09:26:17 -0500 Received: from isrv.corpit.ru ([86.62.121.231]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tcQ45-0003K0-BJ; Mon, 27 Jan 2025 09:26:14 -0500 Received: from localhost.tls.msk.ru (mjt.wg.tls.msk.ru [192.168.177.130]) by isrv.corpit.ru (Postfix) with ESMTP id A698DE0F84; Mon, 27 Jan 2025 17:25:41 +0300 (MSK) Received: by localhost.tls.msk.ru (Postfix, from userid 1000) id 9DEB751D9D; Mon, 27 Jan 2025 17:18:03 +0300 (MSK) From: Michael Tokarev To: qemu-devel@nongnu.org Cc: qemu-stable@nongnu.org, =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= , Yoshinori Sato , =?utf-8?q?Alex_Benn=C3=A9e?= , Thomas Huth , Michael Tokarev Subject: [Stable-9.2.1 28/41] tests/functional/test_rx_gdbsim: Use stable URL for test_linux_sash Date: Mon, 27 Jan 2025 17:17:42 +0300 Message-Id: <20250127141803.3514882-28-mjt@tls.msk.ru> X-Mailer: git-send-email 2.39.5 In-Reply-To: References: MIME-Version: 1.0 Received-SPF: pass client-ip=86.62.121.231; envelope-from=mjt@tls.msk.ru; helo=isrv.corpit.ru X-Spam_score_int: -68 X-Spam_score: -6.9 X-Spam_bar: ------ X-Spam_report: (-6.9 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_HI=-5, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: qemu-devel-bounces+patch=linaro.org@nongnu.org From: Philippe Mathieu-Daudé Yoshinori said [*] URL references on OSDN were stable, but they appear not to be. Mirror the artifacts on GitHub to avoid failures while testing on CI. [*] https://www.mail-archive.com/qemu-devel@nongnu.org/msg686487.html Cc: Yoshinori Sato Reported-by: Alex Bennée Signed-off-by: Philippe Mathieu-Daudé Message-ID: <20200630202631.7345-1-f4bug@amsat.org> [huth: Adapt the patch to the new version in the functional framework] Message-ID: <20241229083419.180423-1-huth@tuxfamily.org> Signed-off-by: Thomas Huth (cherry picked from commit ec2dfb7c389b94d71ee825caa20b709d5df6c166) Signed-off-by: Michael Tokarev (Mjt: fixup for missing v9.2.0-421-g65d35a4e27a8 "tests/functional: convert tests to new uncompress helper") diff --git a/tests/functional/test_rx_gdbsim.py b/tests/functional/test_rx_gdbsim.py index 5687f756bb..7daf1571c4 100755 --- a/tests/functional/test_rx_gdbsim.py +++ b/tests/functional/test_rx_gdbsim.py @@ -25,13 +25,16 @@ class RxGdbSimMachine(QemuSystemTest): KERNEL_COMMON_COMMAND_LINE = 'printk.time=0 ' ASSET_UBOOT = Asset( - 'https://acc.dl.osdn.jp/users/23/23888/u-boot.bin.gz', - '7146567d669e91dbac166384b29aeba1715beb844c8551e904b86831bfd9d046') + ('https://github.com/philmd/qemu-testing-blob/raw/rx-gdbsim/rx/gdbsim/' + 'u-boot.bin'), + 'dd7dd4220cccf7aeb32227b26233bf39600db05c3f8e26005bcc2bf6c927207d') ASSET_DTB = Asset( - 'https://acc.dl.osdn.jp/users/23/23887/rx-virt.dtb', + ('https://github.com/philmd/qemu-testing-blob/raw/rx-gdbsim/rx/gdbsim/' + 'rx-gdbsim.dtb'), 'aa278d9c1907a4501741d7ee57e7f65c02dd1b3e0323b33c6d4247f1b32cf29a') ASSET_KERNEL = Asset( - 'http://acc.dl.osdn.jp/users/23/23845/zImage', + ('https://github.com/philmd/qemu-testing-blob/raw/rx-gdbsim/rx/gdbsim/' + 'zImage'), 'baa43205e74a7220ed8482188c5e9ce497226712abb7f4e7e4f825ce19ff9656') def test_uboot(self): @@ -40,9 +43,7 @@ def test_uboot(self): """ self.set_machine('gdbsim-r5f562n8') - uboot_path_gz = self.ASSET_UBOOT.fetch() - uboot_path = os.path.join(self.workdir, 'u-boot.bin') - gzip_uncompress(uboot_path_gz, uboot_path) + uboot_path = self.ASSET_UBOOT.fetch() self.vm.set_console() self.vm.add_args('-bios', uboot_path, From patchwork Mon Jan 27 14:17:44 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Michael Tokarev X-Patchwork-Id: 860262 Delivered-To: patch@linaro.org Received: by 2002:a05:6000:18c8:b0:385:e875:8a9e with SMTP id w8csp2042996wrq; Mon, 27 Jan 2025 06:23:06 -0800 (PST) X-Forwarded-Encrypted: i=2; AJvYcCWrkwGVK8jIqxRDIEUFGOOqtk11xI/PNDXes5OB9QdmA2o6ric7Se7Sxv4oq74xu1fPfmYVKw==@linaro.org X-Google-Smtp-Source: AGHT+IEzlifpIhjqf5GeNPw8EDg+CpVUG/uMbHDQfyydS0uvACnizvCaN+Ph/Ocl1VaJxyOntJy2 X-Received: by 2002:a05:622a:1496:b0:461:18f2:49be with SMTP id d75a77b69052e-46e12b4b584mr674287211cf.21.1737987786581; Mon, 27 Jan 2025 06:23:06 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1737987786; cv=none; d=google.com; s=arc-20240605; b=Skzf3S2LhnOZDqPrXWZinejQe/B6RJMaeJrjJ3IKZTgB2Fn9eWcpB8MsFhb86Xmq+4 vAE4luJXViArppV513ogOdsaKvVklImilDSnp6oSSMmf2uoY+/QdUPBcve/GonyiaRRQ aoAd8S3GKpPQ7qCshL1pmxxFWpsjfbU4j/hEBN2fPeb92ds31ogXBF6upnWsU9u7S7j8 ki/wNt9HoA3s5xEJ/HuYwnDD0IwnmZkyUdasTqU58iLYSbr0S3GombLf1t1nCy6IeD4X UNJg8Rfq8aHKGNsraMDXqhxRq/FRl01cYieOpE1FvBXBuWy3eKQiVvA28TAzxOJ0UMh0 AXEA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:cc:to :from; bh=fDAeT3j4h3KklQPGKWzpygh8Csi/C+3BBUGnv5ZT1jE=; fh=kw4ZO+6IUAH2m1CybY1ZdEQH84QWaRRMBESpWX/a5n0=; b=CHRelRxCIUBK7BxAJ9c4i/u9iqCFl8LMcsSyMHtNOlGlPRIvRLHygxMb/GDRvDPUfz 5sRxKSlBmoilVMrYTldzWCddGrrOvHOWC8+/TuFp1ORZb+ytZLt1Bj+EUoVFER+rKDFL j3J7NCBJGHSu/OLM/f9mZFXwV33BWwI2dNqGPf3FLbCWe/xybuPOvMcCqk10KsHGSDQH d6Eu7pp2W+Tmf0SJP4O6rlhJAmu5Cs7/z5oxWcc5DdnIMI9hYH16LRKHxALJp4t+ltLI uhBuQXLahxPw7XK9IPyZPKopQmgYjT5KMfl0x6emu6nM5HLDGJYku0KYUzFrjkZNi4cM aW3g==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org" Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id d75a77b69052e-46e66b87c47si97082381cf.404.2025.01.27.06.23.06 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Mon, 27 Jan 2025 06:23:06 -0800 (PST) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org" Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tcPyc-0002L7-3u; Mon, 27 Jan 2025 09:20:37 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tcPyT-0001uU-6G; Mon, 27 Jan 2025 09:20:26 -0500 Received: from isrv.corpit.ru ([86.62.121.231]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tcPyQ-0002gp-40; Mon, 27 Jan 2025 09:20:23 -0500 Received: from localhost.tls.msk.ru (mjt.wg.tls.msk.ru [192.168.177.130]) by isrv.corpit.ru (Postfix) with ESMTP id 336B1E0F3B; Mon, 27 Jan 2025 17:19:55 +0300 (MSK) Received: by localhost.tls.msk.ru (Postfix, from userid 1000) id A3C3151DA1; Mon, 27 Jan 2025 17:18:03 +0300 (MSK) From: Michael Tokarev To: qemu-devel@nongnu.org Cc: qemu-stable@nongnu.org, =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= , Thomas Huth , Richard Henderson , Michael Tokarev Subject: [Stable-9.2.1 30/41] tests/qtest/boot-serial-test: Correct HPPA machine name Date: Mon, 27 Jan 2025 17:17:44 +0300 Message-Id: <20250127141803.3514882-30-mjt@tls.msk.ru> X-Mailer: git-send-email 2.39.5 In-Reply-To: References: MIME-Version: 1.0 Received-SPF: pass client-ip=86.62.121.231; envelope-from=mjt@tls.msk.ru; helo=isrv.corpit.ru X-Spam_score_int: -68 X-Spam_score: -6.9 X-Spam_bar: ------ X-Spam_report: (-6.9 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_HI=-5, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: qemu-devel-bounces+patch=linaro.org@nongnu.org From: Philippe Mathieu-Daudé Commit 7df6f751176 ("hw/hppa: Split out machine creation") renamed the 'hppa' machine as 'B160L', but forgot to update the boot serial test, which ended being skipped. Cc: qemu-stable@nongnu.org Fixes: 7df6f751176 ("hw/hppa: Split out machine creation") Reported-by: Thomas Huth Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Richard Henderson Reviewed-by: Thomas Huth Message-Id: <20250102100340.43014-2-philmd@linaro.org> (cherry picked from commit a87077316ed2f1c1c8ba8faf05feed9dbf0f2fee) Signed-off-by: Michael Tokarev diff --git a/tests/qtest/boot-serial-test.c b/tests/qtest/boot-serial-test.c index 3b92fa5d50..7759e8c970 100644 --- a/tests/qtest/boot-serial-test.c +++ b/tests/qtest/boot-serial-test.c @@ -185,7 +185,7 @@ static const testdef_t tests[] = { sizeof(kernel_plml605), kernel_plml605 }, { "arm", "raspi2b", "", "TT", sizeof(bios_raspi2), 0, bios_raspi2 }, /* For hppa, force bios to output to serial by disabling graphics. */ - { "hppa", "hppa", "-vga none", "SeaBIOS wants SYSTEM HALT" }, + { "hppa", "B160L", "-vga none", "SeaBIOS wants SYSTEM HALT" }, { "aarch64", "virt", "-cpu max", "TT", sizeof(kernel_aarch64), kernel_aarch64 }, { "arm", "microbit", "", "T", sizeof(kernel_nrf51), kernel_nrf51 },