From patchwork Mon Dec 23 14:30:43 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Vinod Koul X-Patchwork-Id: 182409 Delivered-To: patch@linaro.org Received: by 2002:a92:a146:0:0:0:0:0 with SMTP id v67csp499596ili; Mon, 23 Dec 2019 06:31:05 -0800 (PST) X-Google-Smtp-Source: APXvYqwzgwVsrybbsV2IaWggJK9MgfomP2NrUvxmQ5IwCQ+YLwEu5FZ10W1N5r5lPE62iFnVN2Fg X-Received: by 2002:a9d:6859:: with SMTP id c25mr13323186oto.205.1577111465418; Mon, 23 Dec 2019 06:31:05 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1577111465; cv=none; d=google.com; s=arc-20160816; b=OUSy8ECRaMnJnlBLC8YYZdBKHD9BnURsjh9oyX1ct/zbSYCE6iDAA38im5Vyrc+Ou+ NoVf9bZRL8HqhDTszy8E56suZPkdkajBCsmMxsC0IrO1zD61MkjAupEjQb/JJ0U3Nb+K 2GabmXnsnU+BCTMhAta3T+U8WOn2UAkpBrEo3AgAC9dk5WDl6A7nP5esaK5x6qqw/kZw 1YIBszlu4JVj6EfsCRUppvLnX7T4sErG7r5O+o/9QDncvycrDuL1KyWnHEBmd00yaLQ1 Icyp/qHu+e2kTfCfwcc/LUOrz/EM94oIsev1kHeJSQGgmhu/zcb5TatSdpvJmebefuUX 8gHw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=DJqApxFb5ZGMSfNjofWTVhHta6ncngoPD4n/98MfKSs=; b=Xvr5B+eoLtUy+E0reZkiLhQ49+tQgBkm3rHrbUxcYfLUIWucU3MhzugTrAVIMKCoEY tuZVvfmSK7LkGwaiEKEeOxURUT6lf5m/pWP9U0wWCIJEAp4FavM7qU07GjQexAHbTaqr uFPzq79lcgiP67YniGL70xYqeu/nSNK/SzBDk7qqiCwopvfOTeKJefMJPv5ffiA57hok IjhIccMbjl9GEGZ/rqT8T0TikFl8if+GkBksw/PEvoEPFfOASZup1RVgR7cBOtWogiBf yxcOLjGEUqqjxyJyatnGECkypz3oNEZOIKHq5+FZu6nF/BlOP2Hfs0GPa8Lfg2zo4+LL fAkQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=hNVaCVZe; spf=pass (google.com: best guess record for domain of linux-arm-msm-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-arm-msm-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id j16si10298556otp.316.2019.12.23.06.31.05; Mon, 23 Dec 2019 06:31:05 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-arm-msm-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=hNVaCVZe; spf=pass (google.com: best guess record for domain of linux-arm-msm-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-arm-msm-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726885AbfLWObD (ORCPT + 15 others); Mon, 23 Dec 2019 09:31:03 -0500 Received: from mail.kernel.org ([198.145.29.99]:51400 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726840AbfLWObD (ORCPT ); Mon, 23 Dec 2019 09:31:03 -0500 Received: from vkoul-mobl.Dlink (unknown [106.51.110.206]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id B605020715; Mon, 23 Dec 2019 14:30:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1577111463; bh=HbnZQLpmgHXuQZD4rzr1fzFLDl+IaGj4mWYVNAsbNqI=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=hNVaCVZeiTF3YPNzO7IGoU5IepR3bZV0K/2HZ+Hv91LB+uQrhQYYKDDPMB8jnzNen IOfNb1pOzdg2N2TPDHLrJ9TtpMvt61fV+7qj3Tp8JNa8pqzlGOg/h6ngIJklHqOE+Z pA93xoX2rdzKSCyo4FHL3z+y/ic3E3dxiOrL+sm4= From: Vinod Koul To: Kishon Vijay Abraham I Cc: linux-arm-msm@vger.kernel.org, Bjorn Andersson , Vinod Koul , Andy Gross , Can Guo , Jeffrey Hugo , Manu Gautam , linux-kernel@vger.kernel.org Subject: [PATCH v3 1/4] phy: qcom-qmp: Use register defines Date: Mon, 23 Dec 2019 20:00:43 +0530 Message-Id: <20191223143046.3376299-2-vkoul@kernel.org> X-Mailer: git-send-email 2.23.0 In-Reply-To: <20191223143046.3376299-1-vkoul@kernel.org> References: <20191223143046.3376299-1-vkoul@kernel.org> MIME-Version: 1.0 Sender: linux-arm-msm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org We already define register offsets so use them in register layout. Signed-off-by: Vinod Koul --- drivers/phy/qualcomm/phy-qcom-qmp.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) -- 2.23.0 Reviewed-by: Manu Gautam Reviewed-by: Can Guo diff --git a/drivers/phy/qualcomm/phy-qcom-qmp.c b/drivers/phy/qualcomm/phy-qcom-qmp.c index 66f91726b8b2..1196c85aa023 100644 --- a/drivers/phy/qualcomm/phy-qcom-qmp.c +++ b/drivers/phy/qualcomm/phy-qcom-qmp.c @@ -166,8 +166,8 @@ static const unsigned int sdm845_ufsphy_regs_layout[] = { }; static const unsigned int sm8150_ufsphy_regs_layout[] = { - [QPHY_START_CTRL] = 0x00, - [QPHY_PCS_READY_STATUS] = 0x180, + [QPHY_START_CTRL] = QPHY_V4_PHY_START, + [QPHY_PCS_READY_STATUS] = QPHY_V4_PCS_READY_STATUS, }; static const struct qmp_phy_init_tbl msm8996_pcie_serdes_tbl[] = { From patchwork Mon Dec 23 14:30:44 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Vinod Koul X-Patchwork-Id: 182410 Delivered-To: patch@linaro.org Received: by 2002:a92:a146:0:0:0:0:0 with SMTP id v67csp499744ili; Mon, 23 Dec 2019 06:31:11 -0800 (PST) X-Google-Smtp-Source: APXvYqz5P4sdnX5mndIWd2vOe5Javrw0n1A1JHhkaXOyE3k2St0fJ787RWi609bGfnpLjGYItWMJ X-Received: by 2002:a9d:3cf:: with SMTP id f73mr33026809otf.11.1577111471090; Mon, 23 Dec 2019 06:31:11 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1577111471; cv=none; d=google.com; s=arc-20160816; b=0ZvgFDB1cL+D1KbSvS1AzscI6kIf+C68ZVBiGQANaD22Sdna/Fhncie7KeWU2jvWey gydnt5jHPnkJyPwA07htKWjjFwZJI0rBhjAbecJZrnVQ1R5Bz40SZghJZ7J5JmqUlPOr 1CZ6Sgnreb2REFgP1mgDgG8qj1G8yhufEFgdAmutbskMDd8dLybNnl9ObFhUalNLlaMZ 1Dw/UYPeX6oYNay4OonQG2jO1Q4Z5fcQMhvbcDaVaVIG4x6ULS0Mfg7HEPVjIEmwWfB9 BriX2GVKg0gbVdOvy3D+vQ1Sa5jK6X33POJ4e1Wgg2w7BVh7VPowFGbkWQu/P1NhQvCh CpdQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=on+Pa+MXTGtCE0604unuxwF2agvrwlqfr3e9YJX4Ufo=; b=Eyko6wDkIPqn1JDBzNgq9hFRL3UJcR/j/6Jg6AEI8h0B/UFEldpDN0eOKofidtgoYM bh6PiKEG5Vze466ijdTbs5ShyV5RexWw9YWNCQoWB04jSgECgHN6UeUiM0Vfp7h5ESnd I2xbyPiZXDWAqoM9O+eZVBNqSdPld595AGYpvjuEqa2e8s9w/AY5EokCh6r09GfJiXUy nxGOLWA0huiyWdX7KUzog0l9VlkRVEPMkUZElQSmzkUBTtwp1HP3BzV/Vx1W9MGNEG46 J820tXJ5/0YY4Pyo2kYsGawDcnfGHStPNK1ynZGNWt6xl/4i7KRfAlOH1D4SxvK21k9e XD/Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=mP71U7+b; spf=pass (google.com: best guess record for domain of linux-arm-msm-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-arm-msm-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id w26si9128548otl.213.2019.12.23.06.31.10; Mon, 23 Dec 2019 06:31:11 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-arm-msm-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=mP71U7+b; spf=pass (google.com: best guess record for domain of linux-arm-msm-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-arm-msm-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727049AbfLWObJ (ORCPT + 15 others); Mon, 23 Dec 2019 09:31:09 -0500 Received: from mail.kernel.org ([198.145.29.99]:51638 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726997AbfLWObI (ORCPT ); Mon, 23 Dec 2019 09:31:08 -0500 Received: from vkoul-mobl.Dlink (unknown [106.51.110.206]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id D14F52073A; Mon, 23 Dec 2019 14:31:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1577111467; bh=3cUpT0mny7tfDIGYn2V0LDUiAbt2ffFJwm4dcoAsQww=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=mP71U7+bwHXCPh8kzD4jtLNTeggnElMia699oF1a+KgUrxT0I/ZkvNkzZWxyw2MwB Mt3RoYgMTmLkEzqWaPl2pHoBacKGcFqHK4tZ+Dzborinh8XjyHY8IiM8U5Qf0T/cJF ljin2oev0Bk/UOk5D2/4dB0KK1Cg3d76l7+nYBQ8= From: Vinod Koul To: Kishon Vijay Abraham I Cc: linux-arm-msm@vger.kernel.org, Bjorn Andersson , Vinod Koul , Andy Gross , Can Guo , Jeffrey Hugo , Manu Gautam , linux-kernel@vger.kernel.org Subject: [PATCH v3 2/4] phy: qcom-qmp: remove duplicate powerdown write Date: Mon, 23 Dec 2019 20:00:44 +0530 Message-Id: <20191223143046.3376299-3-vkoul@kernel.org> X-Mailer: git-send-email 2.23.0 In-Reply-To: <20191223143046.3376299-1-vkoul@kernel.org> References: <20191223143046.3376299-1-vkoul@kernel.org> MIME-Version: 1.0 Sender: linux-arm-msm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org We already write to QPHY_POWER_DOWN_CONTROL in qcom_qmp_phy_com_init() before invoking qcom_qmp_phy_configure() so remove the duplicate write. Signed-off-by: Vinod Koul --- drivers/phy/qualcomm/phy-qcom-qmp.c | 1 - 1 file changed, 1 deletion(-) -- 2.23.0 Reviewed-by: Manu Gautam Reviewed-by: Can Guo diff --git a/drivers/phy/qualcomm/phy-qcom-qmp.c b/drivers/phy/qualcomm/phy-qcom-qmp.c index 1196c85aa023..4f2e65c7cf45 100644 --- a/drivers/phy/qualcomm/phy-qcom-qmp.c +++ b/drivers/phy/qualcomm/phy-qcom-qmp.c @@ -885,7 +885,6 @@ static const struct qmp_phy_init_tbl msm8998_usb3_pcs_tbl[] = { }; static const struct qmp_phy_init_tbl sm8150_ufsphy_serdes_tbl[] = { - QMP_PHY_INIT_CFG(QPHY_POWER_DOWN_CONTROL, 0x01), QMP_PHY_INIT_CFG(QSERDES_V4_COM_SYSCLK_EN_SEL, 0xd9), QMP_PHY_INIT_CFG(QSERDES_V4_COM_HSCLK_SEL, 0x11), QMP_PHY_INIT_CFG(QSERDES_V4_COM_HSCLK_HS_SWITCH_SEL, 0x00),