From patchwork Fri Jan 17 23:40:27 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Manuel Fombuena X-Patchwork-Id: 858415 Received: from GBR01-CWX-obe.outbound.protection.outlook.com (mail-cwxgbr01olkn2048.outbound.protection.outlook.com [40.92.112.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 62B5C1DE8B7; Fri, 17 Jan 2025 23:40:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.92.112.48 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1737157244; cv=fail; b=DKhxIeH1s+HUGrgjlm25Nj+mB9Gkd955NvSyIfijHye0dL8BFMdfEkx+XoBRfl6irSIpLJ15Juhy//ZrGQQF5GbgM9r4oZVvOCHWMhr9gkS4QwgMEx35TXXpQZAZG0DDdydSeg3RnwKvWxDn+9RrYe8JOaC6DNBI4nxaQzCFdjI= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1737157244; c=relaxed/simple; bh=hRVn4644dpgs01/+pFm+Kug1oolgFC1dj4b8PExnEKs=; h=From:To:Subject:Date:Message-ID:In-Reply-To:References: Content-Type:MIME-Version; b=hI4bb8+rz/WbCfKIKA0cR6Uw1470T2rwbPK/gun3WDkcYZ76uAECEzCaMdoQcw0ML4D+tXkqxeXMFwiQUv4ehSmUzVUHgv4ShYRIx3K5vHbDEIsZVuI2ob/+tRE8TjplGbjx90aAxPVdkFxjMzT5HwvUp8is9nRe7X3feGAyG6U= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=outlook.com; spf=pass smtp.mailfrom=outlook.com; dkim=pass (2048-bit key) header.d=outlook.com header.i=@outlook.com header.b=m6l9xBm5; arc=fail smtp.client-ip=40.92.112.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=outlook.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=outlook.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=outlook.com header.i=@outlook.com header.b="m6l9xBm5" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=YcbiUI0CatpKI6bsF3Iiq2Sz6+XEKhCEPy8o1iKth2ciEbhFo2/8CJRZEN4Jvnezc4lkGp+RI92OcaLcRyWLYywTVwi1G6N3sNt08LfdYsnqQ/MC65tfFPgDNX2MrocZ1Go6wVDIeSk4JoOPGkZ1x44egjfSKKbTY7btL5Sm6bAIChl/DRb02Wjo2mCb7V/XhlaVclV2BDje7eQEVoPZEhCE+0V2E4PmHMLnmuhT5388D/YwIe0ig5jqYSas85GFSw6lEj2Jh9VqzaFy0UevOoY8e3khlRVl+mVJAh5E+6jmK4jklWcy/ZbMPtRKO+YGpWJEyx4CkRxc3LAP56pyrA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=+ZJBY+tRiyU5lRK4Q9axrQ85I7SfOhWcopMeYJcKGDo=; b=YmS061Ow3OEOShlbKW4tv05NgsDAm75xYccPwBPyhZeLgGdKP5fpNW2r/pyUQb3wZubo5AkGWzICdBJvcL/Ug42rkjL15Dd54kwOwwJUsb810xiZExpi3qoqLTpomfMP7jUkExRrgwPkgY5kuNyZB64uqwyqoh0JcXE3L6160Q6UNwQPr8s/IQPivlAhjzdjggdpOcisbOXM59oKpA+0KciClt9Fsbn8Qyat9IeYKuIq4gZyYAoGuXNeJvHjHtpOf7gVQlk6MG8PIa5r/KMieVvmnL/9DankeLihW5N4HSo2Vdcj58D+Edg2JZJLD0y7j+GjV2XeBAU2yvj4nz+qqA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=+ZJBY+tRiyU5lRK4Q9axrQ85I7SfOhWcopMeYJcKGDo=; b=m6l9xBm5YD5tzCqahdp2VfykyHAe+HnZBzWdS86Pv+Nj38c8v5PXyCxnQ38R4Hvqy5DakEyfv8pt8vDSP6VAlAeNGe0LS+FkJtv9jjmBL7JE2pE0kYTAkNzogYJOWS1FC8pvEUz1MamSp4N4hFA9aC7LmF0ABNE7pR52B/nPCv/xh0NcG0SWaUbueS7Rip1pe42H15USemQasrOBKdHT2/QhaVXcZCkFHKL6jS+eiNRGZMDTNxT3L/fHED/Hj4muwhzOW9l+mMdd83rVFBnSddL1l+7Sie1Q7VJ2cK6ukIo7bmcOlPonRcL/MCkuEpmUhWlWMuf240GGhavYjvCPlA== Received: from CWLP123MB5473.GBRP123.PROD.OUTLOOK.COM (2603:10a6:400:160::13) by CWXP123MB4166.GBRP123.PROD.OUTLOOK.COM (2603:10a6:400:b4::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8356.17; Fri, 17 Jan 2025 23:40:35 +0000 Received: from CWLP123MB5473.GBRP123.PROD.OUTLOOK.COM ([fe80::c0fe:9ff5:51fd:3fdb]) by CWLP123MB5473.GBRP123.PROD.OUTLOOK.COM ([fe80::c0fe:9ff5:51fd:3fdb%6]) with mapi id 15.20.8356.014; Fri, 17 Jan 2025 23:40:35 +0000 From: Manuel Fombuena To: pavel@ucw.cz, lee@kernel.org, corbet@lwn.net, linux-leds@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 1/5] leds: leds-st1202: fix NULL pointer access on race condition Date: Fri, 17 Jan 2025 23:40:27 +0000 Message-ID: X-Mailer: git-send-email 2.48.1 In-Reply-To: <20250117234034.670794-1-fombuena@outlook.com> References: <20250117234034.670794-1-fombuena@outlook.com> X-ClientProxiedBy: CWLP123CA0273.GBRP123.PROD.OUTLOOK.COM (2603:10a6:400:1d5::20) To CWLP123MB5473.GBRP123.PROD.OUTLOOK.COM (2603:10a6:400:160::13) X-Microsoft-Original-Message-ID: <20250117234034.670794-2-fombuena@outlook.com> Precedence: bulk X-Mailing-List: linux-leds@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CWLP123MB5473:EE_|CWXP123MB4166:EE_ X-MS-Office365-Filtering-Correlation-Id: 9aeb4c58-3ac2-48fe-190e-08dd3750570f X-Microsoft-Antispam: BCL:0; ARA:14566002|8060799006|15080799006|5072599009|461199028|7092599003|19110799003|440099028|3412199025|41001999003; X-Microsoft-Antispam-Message-Info: 3w3+uQYrle/2JveI0Jj+3ylESe6jclehD8IXTKeFLO9B4Sn1qcDKKS2koLZM49vhGACk9rE5yYYg0OJ4dC9anHlhYJUux3FvKUrR0GkDY7U6MEYv1dQcvphQkCD3zmD8fLsZbDjFl/RDYIbTQPTNPUd/A/pKFlEL0Hmytge5fpDAt8GlQ2H2Qbt5mO/vUrGYgQQ3KIzRHPLtLefqWPpuSB1DRaTXEnXbhM6S3JgLDdWDo9WmAqx2Pu/n+FpctWlg2j37TwTpZvA23QEKUUAqtzw7cHExk8dP4bhWlUObaBMCx7o8TKCWAvu9xhsvXCmLe4gGG/FJneRxVM84RzMFG5rTz4smhfoawg9maaoAEz5Xm0J9mFz3SKLGkcSUDKNXODQMTMqKWVnQaWMP0cFBjKyBAVOjIJPIRcYLXYs/Jio7Ut1zisgX2KLph9O8FENb8HHBDDPuJNm0UruFVM7O2AUYND9CWjkiu0d07Ogot0i0yqyz7EvFq6//cpx1pzjEF3d2aoCBcSeBXXBJeVVIDZoO3Q9fl5+0nzKezloe5qnqTjvJF0wUl7weiS/VH/cHrNpHgno39wS5chcTOAyIqXoFkmza+1SaleyQYf3rqb36gwFqfgzSyIzfAL+5xL/M0qrjoI0lpR6lcTbcMCtqLLwZg54E7ccR6rCWaoFKA56WFtC/1Neh/9VdfhzNE1luaM6mxmbEsSJbQ+sOngweb8N+jz93g5Cz9ndV8UKtzRYaA7ByYEbf35aJz018wPUqB7LkZ6yknNzQGwT5JdStgQppEv/TwhGpMCzuaQKEZzm4tEfauxLOOA661IvThEaTG99pNL2dTY02DEF9xg7xazbYxwVzDiOREwX+760nS21l7FM2YPYTz+goI0QoDpod1fCijVQsyaT6m4tcyCNNvN1CzFl5LobifOcxiZBKESMuqVxz92LJkoK39jSIWzDI4Z6L+twUAbwlDd8lAlKOCBL3szUtjnpixWU9jA2MQ4kSvNZZz69B5qmD5L2DFwDi/91QK2NdYnmJJ4wz5zh7KZ4tnunZKE+QPUMz1Hw7cMvkGNxN9XME941kmw3jB/3BSSnXMncodiWlrPvvgpa9A542SU5fYmj0nNWbRKlpsz8= X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: FfAGB24K3WJf6Nf5h6R8i0LzWDXirnTmBnTWVNCNdhj+ph0iE4M6TxGIGFsqd/gHJuSStMdtuk6j0ERZxVFRWFqQ18irrm/ij2aFsRGAsiJc6yjbZJroICk6xfsD1YnjceoN3TAztDx04G1UmdCdrewns8VEnaE3j12XPz1UDUzc5IA+gV+M6YcolQNCvGrXnnUqrge4SQ3ScHyzmdbNVAP7WAX0Qq10cP2DS6v7N9mSUWRRxvSCnrUtGZ8mK6TlhClpWWenOqY08UDAf9164ifQ4yLZGIQOKKyZG4oUHedcYR8VV4iVeVhpdvK8Ra6qa1MW82n8+yQZfD0Ta4Ec2nLT05cFO9HUdzT9TV9hBIzQ+HXYGjW7y+IwrL03iJznjWATWYBV6X24DPoExeTw8uCTiqcHOzzA82n0dPWXQqsIbWjP2UIOg92vk962gwk/kNRmdPG6iB4IYHJEL3IZzhhzM9dTTQNvEOtrxvkFgfNlr8houVleGD3gBVF6tkg7/WWZN1iyzoBt+ZTa7mS1xyYks5l/CzbEVG5olFGdz97Bh0mBYa8GlrKwfEhgOynp6aEDfgi+qnw2eeuE1Yl+kzxEoIy6ihJzBpRY17+Rjn8tWJ5KWykhPiKg8tOxN4qcXWNBtqRH2iTtd1QTrel19jYsFexIN6InuEXMQ3jRG+wlGFdkkQsauJXfjEAwawnSXyKRVknMgQFJAlPpbLxojMf1rRdZ5Rg8JqEgyiBwuYdExw9imqAZyO9gBkkp9jF7Eyh8ZD1I+9+Rlxm59qVWoYt2g3k89Y+utNW3FZ9+rzDp1+tZipjWheLWzn4BHy6BTjdHKP2JMokjfPcV8ls88Drm+trxU6OblZOO5N8fGM7UT07wl/w13SkM4PBGbwrY/Svi/B46um/NLX7YFE0oO4j7F22u7HAW2GJk4bxyzIjdw0tsyuneA+5avJFtx4hX/Jm85+Vj+PnNtcgJByjUGX1McJNM+9oylLC3/qSFajy4i8b07OX1BBKgudUa8vS8a8v1ZWh4VGV6Q9232+utGl98O1297/p/hCSUDhn2oke8p59uPQp2jQdt9EX9Kg3SOvL6WT8IeHSkK29SypEcDOUBdDSV8xpl07TSdWOrFZF/cW0cAFQwFJQieGx/gQTZJmI0rscmDoLTKYWgRZ0WNhHmlcjztUCs7aiFmTpuBwqBppbs+6M6mwHFgTRLclRYMW2YnuKrjFZLiSQ2AWBr2t/SI9G23CMnj8+57CcxbpibgCUUC1s5RPGvW8ZRsQ2fwpohigfI4pIhlgFaotzWEEwymlNZ7lOJApJtM6Nrf9g= X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 9aeb4c58-3ac2-48fe-190e-08dd3750570f X-MS-Exchange-CrossTenant-AuthSource: CWLP123MB5473.GBRP123.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Jan 2025 23:40:35.7113 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: CWXP123MB4166 st1202_dt_init() calls devm_led_classdev_register_ext() before the internal data structures are properly setup, so the leds become visible to user space while being partially initialized, leading to a window where trying to access them causes a NULL pointer access. This change moves devm_led_classdev_register_ext() to the last thing to happen during initialization to eliminate it. Signed-off-by: Manuel Fombuena --- drivers/leds/leds-st1202.c | 21 ++++++++++----------- 1 file changed, 10 insertions(+), 11 deletions(-) diff --git a/drivers/leds/leds-st1202.c b/drivers/leds/leds-st1202.c index b691c4886993..e894b3f9a0f4 100644 --- a/drivers/leds/leds-st1202.c +++ b/drivers/leds/leds-st1202.c @@ -261,8 +261,6 @@ static int st1202_dt_init(struct st1202_chip *chip) int err, reg; for_each_available_child_of_node_scoped(dev_of_node(dev), child) { - struct led_init_data init_data = {}; - err = of_property_read_u32(child, "reg", ®); if (err) return dev_err_probe(dev, err, "Invalid register\n"); @@ -276,15 +274,6 @@ static int st1202_dt_init(struct st1202_chip *chip) led->led_cdev.pattern_set = st1202_led_pattern_set; led->led_cdev.pattern_clear = st1202_led_pattern_clear; led->led_cdev.default_trigger = "pattern"; - - init_data.fwnode = led->fwnode; - init_data.devicename = "st1202"; - init_data.default_label = ":"; - - err = devm_led_classdev_register_ext(dev, &led->led_cdev, &init_data); - if (err < 0) - return dev_err_probe(dev, err, "Failed to register LED class device\n"); - led->led_cdev.brightness_set = st1202_brightness_set; led->led_cdev.brightness_get = st1202_brightness_get; } @@ -368,6 +357,7 @@ static int st1202_probe(struct i2c_client *client) return ret; for (int i = 0; i < ST1202_MAX_LEDS; i++) { + struct led_init_data init_data = {}; led = &chip->leds[i]; led->chip = chip; led->led_num = i; @@ -384,6 +374,15 @@ static int st1202_probe(struct i2c_client *client) if (ret < 0) return dev_err_probe(&client->dev, ret, "Failed to clear LED pattern\n"); + + init_data.fwnode = led->fwnode; + init_data.devicename = "st1202"; + init_data.default_label = ":"; + + ret = devm_led_classdev_register_ext(&client->dev, &led->led_cdev, &init_data); + if (ret < 0) + return dev_err_probe(&client->dev, ret, + "Failed to register LED class device\n"); } return 0; From patchwork Fri Jan 17 23:40:28 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Manuel Fombuena X-Patchwork-Id: 858416 Received: from GBR01-CWX-obe.outbound.protection.outlook.com (mail-cwxgbr01olkn2023.outbound.protection.outlook.com [40.92.112.23]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E3B3C1DDC0F; Fri, 17 Jan 2025 23:40:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.92.112.23 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1737157241; cv=fail; b=r43AhhurPkiG8+1WT+gXhDi0GAy/84OL1JQT4vAzsVy8ssVTNerBRq2BF/c24HcJEXiFdpd0j4ALnaJYFASuBh/8eCMdyjx3aOOOg9nWB5vJ33E0c1NI2xtPvLFGfyFq4I9CnlydUKByKa6b208o6XmszK/+Ah2VQxxD8oTLC7o= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1737157241; c=relaxed/simple; bh=WiG2bX6V1A0y46pxpoCSREfSI8ZkVt1LrWNMcECe918=; h=From:To:Subject:Date:Message-ID:In-Reply-To:References: Content-Type:MIME-Version; b=G/WyVC5oFWq16ttEleDw2yM/ajFLivTfxmpcdJqYoXEVkSN6s2g7MjRhsesJBnteN1XvejnI/7pc4YJjVwIfZ7ZmksAW5NyYXbJ9+6Jf8G/t6LGqC+aDQUHUJabo7nt7fozNpKDVjJrxZsfZenMxd+92bgiqKi0GZWLvJ10V13k= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=outlook.com; spf=pass smtp.mailfrom=outlook.com; dkim=pass (2048-bit key) header.d=outlook.com header.i=@outlook.com header.b=HJyf2aKA; arc=fail smtp.client-ip=40.92.112.23 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=outlook.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=outlook.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=outlook.com header.i=@outlook.com header.b="HJyf2aKA" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=VIWBLo6dOop/ojLahJuCsCbvteSyR+xohrglGZ7ZEpal+0GXza7DANoZ5PtQ2wu475bl0RUOuSObeW72JNoWOd8is9vOsa6k+98Yr+kC4s757bCXDhDaWtmRFgkOVmk0iYEfqhsk+VaLnX0i1RYIiO5gv9vdSO7WeB4v0PUmU1t1vkxsLjUqfsdTIANHfEVHX5PKSLxNBjJ1GbwhfZkg4cxqkJw5QDWCmpgm8glPgXQFAanoo8wg3awORy36xgPOGskO8sK05eMDAGzndIGHJQx1bzYF+et/Wrf2yGCKQDD/yePMfVPV+N2OnJev7PeOStrbOGCQFmBn0Y3qlHLK2Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=0AzLQwmGaXuUyhKvYIvXIoJlxmpHxgvilNBqAEC+Ix8=; b=FxHeUk2HO7DzNMDa8z+rH9ikBppDnY3LWLJ80F9n/gXQ8WHyZGZUGIkk36l09nsudOGTy28vhuGA7p7IHE+O57Tqx1tQXaUwuRq8Ls0MzelZ3ezMm2pZw7p08MujJOJwcBaRmWIGkGTNpuuirXQuosiuvX+AZaWDNltLhxlOeBxqSU4IxpxpbM50ewJ09EXiH6dvmjpjU04hb5SGhTjAhBVGPVbfsodfzgDY1zcC+ZD/+vRbBbpR+Hc/qczKMVc0RpTuPx8Kocmdu+Ar5hKOpadWzS6m6o4qmNDlNdvVQV+l72wshyoaU9I0/0wwqSiRZX9Nbsh3MM08elnSEkm91A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=0AzLQwmGaXuUyhKvYIvXIoJlxmpHxgvilNBqAEC+Ix8=; b=HJyf2aKAQpA/tK+Kv6jM4KBmADdB3MuX839BR2RKjCtRCKh7JMRQdIm+NFW/WqDA3OK23feVlODB5FVkA8oFUuV2xHvvPgvC6JYW0c4VMwhuDi00b67XT0xBOIn59L/SF+0uf5dBwDtAaSAEIHNctfGIOF3l+jX28TQeLeYkVpbztjFVcG2/9qGMcSYbTsH43RDBBgXidloecF1oOqlpF0O87tUbaJnc+fwoI1fFwA+nJg8HIs05Vy+6/E27Byp3TBlErYFkv6r09uwFmC8nT0ct4RB53SACVdnWMEdU/hDMDSWbjLP4eibE3IMPV6Wxyr7gV5XXiKIoTC+aL94/Bw== Received: from CWLP123MB5473.GBRP123.PROD.OUTLOOK.COM (2603:10a6:400:160::13) by CWXP123MB4166.GBRP123.PROD.OUTLOOK.COM (2603:10a6:400:b4::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8356.17; Fri, 17 Jan 2025 23:40:36 +0000 Received: from CWLP123MB5473.GBRP123.PROD.OUTLOOK.COM ([fe80::c0fe:9ff5:51fd:3fdb]) by CWLP123MB5473.GBRP123.PROD.OUTLOOK.COM ([fe80::c0fe:9ff5:51fd:3fdb%6]) with mapi id 15.20.8356.014; Fri, 17 Jan 2025 23:40:36 +0000 From: Manuel Fombuena To: pavel@ucw.cz, lee@kernel.org, corbet@lwn.net, linux-leds@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 2/5] leds: leds-st1202: initialize hardware before DT node child operations Date: Fri, 17 Jan 2025 23:40:28 +0000 Message-ID: X-Mailer: git-send-email 2.48.1 In-Reply-To: <20250117234034.670794-1-fombuena@outlook.com> References: <20250117234034.670794-1-fombuena@outlook.com> X-ClientProxiedBy: CWLP123CA0273.GBRP123.PROD.OUTLOOK.COM (2603:10a6:400:1d5::20) To CWLP123MB5473.GBRP123.PROD.OUTLOOK.COM (2603:10a6:400:160::13) X-Microsoft-Original-Message-ID: <20250117234034.670794-3-fombuena@outlook.com> Precedence: bulk X-Mailing-List: linux-leds@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CWLP123MB5473:EE_|CWXP123MB4166:EE_ X-MS-Office365-Filtering-Correlation-Id: bb0da065-8a19-48aa-9756-08dd3750575b X-Microsoft-Antispam: BCL:0; ARA:14566002|8060799006|15080799006|5072599009|461199028|7092599003|19110799003|440099028|3412199025|41001999003; X-Microsoft-Antispam-Message-Info: rxFKtT9T6rqjXSgjFdRCgN58ns+H4yI8moh+1jQ1nYHinyeMkgngY6HDDEP/wVwprTzv4HA8HcsTkAZ0/lG3HK1pdSWrMDyPLUNuyayQWS3wJINAhJ46JQ4eMRvJ/Vdcyq9r1hOJ7ciw6Kt+kKY21KdnIUh1MsTLv0002ZaGGy97EENMAjQyS/cThPqimpF81M8RR6kfK8sia7fEqVRovX7TPl0OI+lQniB+kFWHFbc9eGnJHxLNWbI6ktDAb1KOUIsaVY4DsJxcwftpU8lLnVwLl3fVmXmhlTHnic3QUcgshv0xakJokIosPWtTNFES6WfTixtchm27a0PQylynK5KoJKjSQ5kE/JUJ2m2e9rA5oRnjqebMgsfdNiGHAUeOI1Qhk8TgVzdszvU23boyj2JgOs6TiLQvZt7MQiq7ER1i/TEkDYr8vjIsrXuLezoMvfvJIk6fU755qmurVFL0NOwSO9Ae6yN7jZn98Ba0aNoaR0sZGOYu46PuEGuWfsuKLpgw8fGoAJB7xwrzkqWwcI2biZ0gzp2ok5ugJ1fMTM35iL5Q55L6derhWNCj6Gsv8S2+mPee9i+wasm616xq7e8zLCQi8sljDq5ljor5LFEYjt1Qt6UOXdr1MWGYTlMcmM3r9KbIxGZHB3uWLjZ4r20U6ZTWyl0zghxlEMKB5l+eUAwN95hOiCbuJf0vu+rg/qHUQPudPH3ng/N7HeVDEcSp85xy/xptftiraDlVkB/KEz8atvrH2gfGrAq4M4KWHMNhv2qdpd6FJ8YHHhJW50YYdwrNpB0a4svBRCj3s2llYlFid/Qd0b8Pc3Y5VC8CVkeqfciJ68k6ZZPyLXsUfjRARluZrMO1dK4IzOnQwXpOquHeviHgQs/y7pUjfJgxAoIuOCVK+6hNAsmbgBOrTWGvwHSubmlRUl0PMZEdeFMn/I95YwejocuT/ancEr7+NKiX02Wogtfpfo18VBUXiVWTGwlP6yeAjF0vC2mXZIarvFnxf1NTi1eC+1j4fZSNmk06MbhzTJPW8hS+38snApnhwz6rX7HA33g82z+GwoQg/Oas7oxpJdHK8hcp0mlkgNaxEMcerC/ZhJb65DAk7oFBOpjXTJrsPk/kPEKWC+w= X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: /Plu6dk84rbKaPxDKPM3A4MmO9jG3+K3HJqVH10a0vVC3WiBlEkyDKwhNxDWuP4of55oAPOqy6ngDn1AGVTjN2QDaJcvX5bN237BmiBGdwf7wa97MwYAyWxJQMwm69uXWXbeM+ABTYbIDBPzFGaSoVYTf2leUskA7JDxwrQwRPSyGch4O3zfkGbzMTCRxBGKceb+da6vpSpKnc9WMdxanalK5osBOl8rFMcbA5+fdwNi/nnStY817wsz1mA0NIOeXl1poUuaeBhO1rd74bAw1zt8YtiU5nukBvFqMwI+o6qmaK9PPmPP/a6VZTtjXrwhQ8s6UqjvpIy/AQJhYIQw0Pbw0yLIJf2Qwvcq33iE7FXUepWp5tM3sn3FVNMvwYdisoFE/HG3AhtD4fI/kX+8nDvBuugsFCMRhX97K49Mg9A7al+UXVwwbaV/RYon9w640uVduhdBkl4ya4KBkMJmV48DSxOSHXZ9bjnQri8egKvKf12retdJOl1OZYePN+iV/9wgnCYG0m+sft/r5hLesxco8gtcVPDuOmmW8DGs90JUtj+HvyIebXlDh0uTeTEu1VMgrKNY6uSEDOHvEtuG8xsYBsz4RKEZB/NionZflTagiAcFk6m3+39vzrfKYof1MxuTvYY2096KjJ20cXO9/eFQOq2i3xkuZmf+oFsHbUD/DkpAz2JmvlMxw+xyNxGBM6YsGiA6bUab5qv0Xm8bQ51f0mjxWM5slqEcqMufmU8Nt+cunHT9fpsgZcQSIF4ow/n8fd/VLCJorFbKRqh+vU3/QJgYsDBeWaNh+9B9l8BF4mAmcLVXsvUS7hylM//yihT5MIkLAJ2RS9Bhs+2blCLaer17IM3U0PV2vxKLeuRAiZr9ZP1GUnP5lnFecIno56alpXo2aG5EKWipR1OtpX/Ln908qIjNRVBirsljATW20dM+2Zp/B2ayUq7T5riGgesNd3hb6lXmrj4V7YX8rz5wXI5qMXeVtpSpjQ6iWD60cq7Up8AfxECg9y3BLNV40PF1scCwNsvo6/xd0wfpByM7tI/FMHUJhJx9yX2hKP0xoQkRNR0GvTIJ6h1+pTap7/969tO4Tiwa7y/gZWgiM7qwpJvDedK0qkERvQFNYPg2EiNXu2mt9C8P/ohkr1v9sjt7y3/XQHCfHpkIJOazhLsUJa982Lt2Za1CJPaCfJJBK4ZaQsrbDOjAdQLrxu/6lQVl51fv9HuWddf4Fu6GMnxL0wNM6TJRt8TR/mJot/8z2UbyopGZqwyqlaie9OcEGQqrvslRMKLI4ViOEb8S3nCE/5qoUu8oWQZFHgc5DSE= X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: bb0da065-8a19-48aa-9756-08dd3750575b X-MS-Exchange-CrossTenant-AuthSource: CWLP123MB5473.GBRP123.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Jan 2025 23:40:36.3039 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: CWXP123MB4166 Arguably, there are more chances of errors occurring during the initialization of the hardware, so this should complete successfully before the DT node childreen are initialized. Signed-off-by: Manuel Fombuena --- drivers/leds/leds-st1202.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/leds/leds-st1202.c b/drivers/leds/leds-st1202.c index e894b3f9a0f4..927874f20839 100644 --- a/drivers/leds/leds-st1202.c +++ b/drivers/leds/leds-st1202.c @@ -348,11 +348,11 @@ static int st1202_probe(struct i2c_client *client) devm_mutex_init(&client->dev, &chip->lock); chip->client = client; - ret = st1202_dt_init(chip); + ret = st1202_setup(chip); if (ret < 0) return ret; - ret = st1202_setup(chip); + ret = st1202_dt_init(chip); if (ret < 0) return ret; From patchwork Fri Jan 17 23:40:29 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Manuel Fombuena X-Patchwork-Id: 858709 Received: from GBR01-CWX-obe.outbound.protection.outlook.com (mail-cwxgbr01olkn2023.outbound.protection.outlook.com [40.92.112.23]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D311B1DE8A0; Fri, 17 Jan 2025 23:40:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.92.112.23 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1737157243; cv=fail; b=E6rIwJyuLNZXUxg2M6Cn4VwDjXw3YiQJWuPSnp7x0/vbZGQoGgte1/F/B9O/WJuoglrfuJFcSKHKTJuXXkTmESHaOYM97qRfb9HBeHXKv0MIAHt5SRlCwZSeV5RnUvIhFOpFxVFNdkuLGGv/BB2eNaKckZl8tgmmwc5hVWXU8ls= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1737157243; c=relaxed/simple; bh=D4K9r6e8+Sk1BS+2VGhIrg5v2AEBsDv5XXQuSlnTfiY=; h=From:To:Subject:Date:Message-ID:In-Reply-To:References: Content-Type:MIME-Version; b=emuWfFYv3/rZaZ2iKrEYdX8w6Ier/LFbR5j/lUOwefLG+F8krJbmPd4VoxhszIrLdEM9YZIYK88s+WErTn0JxMQ8AeD3uD2aCnP9pYitjb4nDKofzMgF7s0aTmGB7wwumvUeOenkxppBTjZC6ood1veCtABuZc3KmwGgOclYWrE= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=outlook.com; spf=pass smtp.mailfrom=outlook.com; dkim=pass (2048-bit key) header.d=outlook.com header.i=@outlook.com header.b=syYHg4IS; arc=fail smtp.client-ip=40.92.112.23 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=outlook.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=outlook.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=outlook.com header.i=@outlook.com header.b="syYHg4IS" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=cu8AqyX543K7dXIVlfYF13iOswLXullxrkYOhmTc7ZRCmhity/nrB5syjkBrm6SRUpfwVmHaRB9i6TJze53V1/1QnOxZWlEDQGiw58Vl6Baq1PYD9USaTiGgfgmk04+9DkrgTWg/CZAXEteLLBvFUUrpOusWCdnfdlaZtAwYzOQuS5yYdM5FIfGRSHQVZd5KcTh/7gPs/tQP3fmqQ3BbhvP4gHABWUVRW55curLVX0PL9FVRfx1d3gjCFc/4VrEGeBNs7FlyNWhKedJJnCa+MByroy0jVgJNJgXEp7+61by1dsPwEVUOvktVBu2HtB50Yi3ARQRj08H8j9+Lj1K6pg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ogS6YfdqA8BdxG9LAhhchBsCc1A0frBaELQUTCigOQE=; b=cIJZcgXHm7n6bzs9O/LR8InCojqjTctkSWWzEHr80Jw9kIfO45nNC6J4+QUvTgpIb89vu9yo8Oosw9pFVsNC//SPP4a7L85s677TeY1ajy5JNbwtm/V1M9RJEu2RHugzr2SCUqHOtJs5Pv/f4B4BgUsansfG4zFHkafDMKRiEqMUY6GLVbdmqLu6LTgf868tKkKr+D8GQ4I3It6b3szruHBGamIYom4f3bLN0pXTQ0CJhF/axAPeCx3FscmWQU/jR7CKz5eI/M85x5g+8oH4+M+wFRr66/EGcf/QNYFSQMQ/C0Kg+DXdxWOOpxbMlq3NfqBAGPjv1TdwNVBZEqvvwA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ogS6YfdqA8BdxG9LAhhchBsCc1A0frBaELQUTCigOQE=; b=syYHg4ISn/HJzDxnogfMmUf2N8PUAt5t2dRKGPvYU3cOm/THCxpMAtn7Xg8MmkL9K0K0LDpvTqdINpZXQvX2m/TnIoOofyzGjwoCICJXcztKhgxewbBMk/WgrziOP9RbK5vA8APuHZwc6qitEPVKUS6KY3W3/pKMn3rDDQeZaTSaKwYYDvZYWlL5IbUJBTquLGr6X5jt4W/djJxnM7K0oI9t1y8Ax6s9ZDsQlNHmbvomOEy8OW9CdszZewnt5mgjM/tWBtCvpfREcFUIv7w+ZFf5P7UEE+23R1h9CKe1CAklxu27SLvlAKJDDPH470UU8wkG+QKvocQ8l5Y/zpxETw== Received: from CWLP123MB5473.GBRP123.PROD.OUTLOOK.COM (2603:10a6:400:160::13) by CWXP123MB4166.GBRP123.PROD.OUTLOOK.COM (2603:10a6:400:b4::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8356.17; Fri, 17 Jan 2025 23:40:36 +0000 Received: from CWLP123MB5473.GBRP123.PROD.OUTLOOK.COM ([fe80::c0fe:9ff5:51fd:3fdb]) by CWLP123MB5473.GBRP123.PROD.OUTLOOK.COM ([fe80::c0fe:9ff5:51fd:3fdb%6]) with mapi id 15.20.8356.014; Fri, 17 Jan 2025 23:40:36 +0000 From: Manuel Fombuena To: pavel@ucw.cz, lee@kernel.org, corbet@lwn.net, linux-leds@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 3/5] leds: leds-st1202: spacing and proofreading editing Date: Fri, 17 Jan 2025 23:40:29 +0000 Message-ID: X-Mailer: git-send-email 2.48.1 In-Reply-To: <20250117234034.670794-1-fombuena@outlook.com> References: <20250117234034.670794-1-fombuena@outlook.com> X-ClientProxiedBy: CWLP123CA0273.GBRP123.PROD.OUTLOOK.COM (2603:10a6:400:1d5::20) To CWLP123MB5473.GBRP123.PROD.OUTLOOK.COM (2603:10a6:400:160::13) X-Microsoft-Original-Message-ID: <20250117234034.670794-4-fombuena@outlook.com> Precedence: bulk X-Mailing-List: linux-leds@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CWLP123MB5473:EE_|CWXP123MB4166:EE_ X-MS-Office365-Filtering-Correlation-Id: f5e7cdbd-ffcd-4378-c258-08dd375057ac X-Microsoft-Antispam: BCL:0; ARA:14566002|8060799006|15080799006|5072599009|461199028|7092599003|6090799003|19110799003|440099028|3412199025|41001999003; X-Microsoft-Antispam-Message-Info: =?utf-8?q?RV7yPdotspndY1EHhVUBpD9LLG8a1Ds?= =?utf-8?q?AOW51M8jIzX27/rDsC2xhSkroXJ2tKPDA6P7QfACoPDCtg6aX/R5PUsDaVRLTwfnm?= =?utf-8?q?KRvWeb+WkquM1at41/qft0AxVg0Okxbu33IeuugIFe/m+136J80QbUb+PxVF2p25Q?= =?utf-8?q?2OjIw7v85VJ1KXnizO/eJp3QKLS9Go9FvGA73MLymc7cGkQJc0i9T9cwhWTaz+sNx?= =?utf-8?q?Y4nHNvpFRhNgisD0mzjtk0W24gGIJqU6TKURaWxy1bcdQrQUr51wohzcdZ7jMZ1/V?= =?utf-8?q?weurCGBszaT56gjueIw11lMQbPVrQJn6wl84vz2ll1vfLBXQmSm/4qnhFmQYkbqOB?= =?utf-8?q?+O7OKhjR8JWCzDc8iMiPRurHXKhC7BHPjYqLjr1hZiwpuNwAzQ4rnYfyPYSdOvdtd?= =?utf-8?q?N9g8nLMFH5BwosVif4TotY/+FUpUlsgcZEcbLiF/r22OQRUKqHBvCXXVcN0iVG3AS?= =?utf-8?q?kbEX7rfi2COdsIIWNnOm51Eb3SEborxOhZQ0U8heX29bK5+1O0urkDxNK0EcNAuET?= =?utf-8?q?yEWTyzb+IXRqjpFXpTFhDR0mOo9ubxkMUelAsO107zfyZT2Mmpn7z2fZ8yeUHxgIR?= =?utf-8?q?U5flmPwAaQonItHCxv8Y5RGNikZX0m6TzHRzZbVfkKboDZK5XJjWpzqG+wZn83s+w?= =?utf-8?q?HftFrNOpV+5U7DV0O+oklBSyhNFO3jjDW1hhu0yYZqy5JUCV9Ck8SQomrXp/hjxZj?= =?utf-8?q?KdadvnO3rzZ9AN57cjDz3IXmUrD2b5Lz6JHreB6RkcWqu9pO4ki3ljqQeR8v53dxh?= =?utf-8?q?QoM5F3jfAg56knFeAM5632ue9kGfm9Qnxx3nWAdnis0RirTOcJSH9CfOg/5zKT/UH?= =?utf-8?q?0uaxG8Afu8/hVVEPCMRSiMTkX3AKN7LZqAqDvwF/dXncGSDtnVb0k5uZGfwTh5C+m?= =?utf-8?q?5oWmwiOQMOst8MYBXij2DpQSbPVfhkdMjOFaiwo02sBl8kD5hATXYZ5zWV7xbxuxd?= =?utf-8?q?LL/7oVyIm249hrbhy9QUOF3Plkm0KFgf0zx/6QdnRCPeB2iXIKGfQ5ti92G+qbnvP?= =?utf-8?q?ntOoOHyNPEdNsDbK5U8XXjNMfLd29Ae4SxB110i3jfPJEAly5is3nDEwSK9yL56p5?= =?utf-8?q?OS9veC6XxjW00+kTOcDcsNxYoBXczHnGyOU9wQ=3D=3D?= X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?q?PCy7CPpTMyeTLHc6WavFiorRQLac?= =?utf-8?q?+3OUGkeQ4rWgAKYZv/EKbtZCPcbJlSYRS9n3LTjrBQQz2NTYFq06mzy8y9W65KzEU?= =?utf-8?q?vceIM4FA1IbUDRtpEl//31XneVR/bsUw9qsGzI7vVYVDhJ/r5jpKnTT15wFA5Pkmd?= =?utf-8?q?wgWQY7X4TNInazGwuan+/fUz22AeGY9K6SdDWZA/77RiWqST+EHrk1MZZAIvVFbQt?= =?utf-8?q?T2H22gd/z6r9CYpzOlXymY5GUZGoaEL60DUX22Nc0xN2ZNvM6TXxgrWOOV5VU8+3t?= =?utf-8?q?f+7A0gXle+lNunrHtYQLGDwMR2jHy9sjz6s1nE3ez/GGj12P8Y63eiQfc+Bf+D4M1?= =?utf-8?q?xYE3fqMeHiqAMt/dg6Y1DMuCSC0KnvncbysBVb8OahMpd55KUxTl1zw8RwUTdXQTm?= =?utf-8?q?lqV39OpjqcCVZ56c0dua4s/iZ3DC7mYRY2eHzAvHYitIuIlm9Lk7+yzoiShLl9/8/?= =?utf-8?q?FwYLg8mEbP/+1yKYIubaAPT17sO2G4z8b/ml67W6XJC8STrwBAqrjHNFk3Eb3tlVh?= =?utf-8?q?NGuJ3xB5Xa3FJMfvlHMlRMuA9VMTwGGZQ1pXikg/A9KjfyxlaEmgzYxyiQJh6tF2A?= =?utf-8?q?5rZnM4PuXtTMPJNF/JBoMuiw4OG1jeE0ZmUres7sZRtiEQHUr458owFxay+kWYlFy?= =?utf-8?q?m+N3I1tms2OBM5lGajHZD8a77nRe6xSjRKmr8T9kWu7f08CkUvZ6ID9VRNaeTUa46?= =?utf-8?q?8dGyw7AmPeM3D4L36RJ3hqCXb9PQ0Dc6NRkKXuSGVhmThQ/araPrTyRzp3Sd9Pqlp?= =?utf-8?q?yty+sNoRgfxmj7AVejDguxccGkOOmybJ92THFL24q9kBFdYNkwhb+OWMAE+UU4XvP?= =?utf-8?q?kgdKFovduQRwXel1IoSsXNKsDWW34/j9YkeNtocLKB7n/oULv1ryiWcDgbhhVBSXC?= =?utf-8?q?04cWqsnWFERXDKbWgW2XzJZG49+9fnysLePkqHBL8e8uoky5oaebXga6Zk5YWs67c?= =?utf-8?q?yMV+D8biZurVwDs5C8fiQessDgCoOWN6Tgott+2/7MuebWmafJCQ4SF3EfHk+cSZz?= =?utf-8?q?4z4BFq16OEAk6CEut/vxFOp1h/ymhYsZ+AggJzOpmKhtZnZ9MRRXTuxre/O1pojvW?= =?utf-8?q?nJUCac78YBwXkUBYaqlEoDUwkZhjsbPInsiT/QNG3zutKjmDu4JUPB2uOLCgissMB?= =?utf-8?q?cBj99gU+jScgiWfLIkJxL7uIxA0eNapC+R8u0sxYa0qlbdupseoJDqE2A3Zgy5QiH?= =?utf-8?q?2l3Y2Eo1P4xIwI00djbm+yMLtnyLMuZl48qeQUL3a4FJ1XiP2QuJvi7NowJM=3D?= X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: f5e7cdbd-ffcd-4378-c258-08dd375057ac X-MS-Exchange-CrossTenant-AuthSource: CWLP123MB5473.GBRP123.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Jan 2025 23:40:36.7556 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: CWXP123MB4166 Minor edits regarding use of spacing and proofreading. Signed-off-by: Manuel Fombuena --- drivers/leds/leds-st1202.c | 48 +++++++++++++++++++------------------- 1 file changed, 24 insertions(+), 24 deletions(-) diff --git a/drivers/leds/leds-st1202.c b/drivers/leds/leds-st1202.c index 927874f20839..cb4797ea8f3a 100644 --- a/drivers/leds/leds-st1202.c +++ b/drivers/leds/leds-st1202.c @@ -16,27 +16,27 @@ #include #include -#define ST1202_CHAN_DISABLE_ALL 0x00 -#define ST1202_CHAN_ENABLE_HIGH 0x03 -#define ST1202_CHAN_ENABLE_LOW 0x02 -#define ST1202_CONFIG_REG 0x04 +#define ST1202_CHAN_DISABLE_ALL 0x00 +#define ST1202_CHAN_ENABLE_HIGH 0x03 +#define ST1202_CHAN_ENABLE_LOW 0x02 +#define ST1202_CONFIG_REG 0x04 /* PATS: Pattern sequence feature enable */ -#define ST1202_CONFIG_REG_PATS BIT(7) +#define ST1202_CONFIG_REG_PATS BIT(7) /* PATSR: Pattern sequence runs (self-clear when sequence is finished) */ -#define ST1202_CONFIG_REG_PATSR BIT(6) -#define ST1202_CONFIG_REG_SHFT BIT(3) -#define ST1202_DEV_ENABLE 0x01 -#define ST1202_DEV_ENABLE_ON BIT(0) -#define ST1202_DEV_ENABLE_RESET BIT(7) -#define ST1202_DEVICE_ID 0x00 -#define ST1202_ILED_REG0 0x09 -#define ST1202_MAX_LEDS 12 -#define ST1202_MAX_PATTERNS 8 -#define ST1202_MILLIS_PATTERN_DUR_MAX 5660 -#define ST1202_MILLIS_PATTERN_DUR_MIN 22 -#define ST1202_PATTERN_DUR 0x16 -#define ST1202_PATTERN_PWM 0x1E -#define ST1202_PATTERN_REP 0x15 +#define ST1202_CONFIG_REG_PATSR BIT(6) +#define ST1202_CONFIG_REG_SHFT BIT(3) +#define ST1202_DEV_ENABLE 0x01 +#define ST1202_DEV_ENABLE_ON BIT(0) +#define ST1202_DEV_ENABLE_RESET BIT(7) +#define ST1202_DEVICE_ID 0x00 +#define ST1202_ILED_REG0 0x09 +#define ST1202_MAX_LEDS 12 +#define ST1202_MAX_PATTERNS 8 +#define ST1202_MILLIS_PATTERN_DUR_MAX 5660 +#define ST1202_MILLIS_PATTERN_DUR_MIN 22 +#define ST1202_PATTERN_DUR 0x16 +#define ST1202_PATTERN_PWM 0x1E +#define ST1202_PATTERN_REP 0x15 struct st1202_led { struct fwnode_handle *fwnode; @@ -99,9 +99,9 @@ static int st1202_pwm_pattern_write(struct st1202_chip *chip, int led_num, value_h = (u8)(value >> 8); /* - * Datasheet: Register address low = 1Eh + 2*(xh) + 18h*(yh), - * where x is the channel number (led number) in hexadecimal (x = 00h .. 0Bh) - * and y is the pattern number in hexadecimal (y = 00h .. 07h) + * Datasheet: Register address low = 1Eh + 2*(xh) + 18h*(yh), + * where x is the channel number (led number) in hexadecimal (x = 00h .. 0Bh) + * and y is the pattern number in hexadecimal (y = 00h .. 07h) */ ret = st1202_write_reg(chip, (ST1202_PATTERN_PWM + (led_num * 2) + 0x18 * pattern), value_l); @@ -288,8 +288,8 @@ static int st1202_setup(struct st1202_chip *chip) guard(mutex)(&chip->lock); /* - * Once the supply voltage is applied, the LED1202 executes some internal checks, - * afterwords it stops the oscillator and puts the internal LDO in quiescent mode. + * Once the supply voltage is applied, the LED1202 executes some internal checks. + * Afterwards, it stops the oscillator and puts the internal LDO in quiescent mode. * To start the device, EN bit must be set inside the “Device Enable” register at * address 01h. As soon as EN is set, the LED1202 loads the adjustment parameters * from the internal non-volatile memory and performs an auto-calibration procedure From patchwork Fri Jan 17 23:40:30 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Manuel Fombuena X-Patchwork-Id: 858708 Received: from GBR01-CWX-obe.outbound.protection.outlook.com (mail-cwxgbr01olkn2023.outbound.protection.outlook.com [40.92.112.23]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 064C91DED67; Fri, 17 Jan 2025 23:40:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.92.112.23 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1737157245; cv=fail; b=GqWQqHs+PoudXrcn5AIMg6KCR/1X6SqSpIbGYQYj41lP2+qyEkMOJLNPze+KgknIgpGC73OOXCsDofUY1wBe6BAQKM8lIJypmHyP9kt47b3+8st0gE+ldF0TOzaiYuI5eVlYIGvu2UueFl+nr11id19HjvG0fS8yu3Qq7tTTzPY= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1737157245; c=relaxed/simple; bh=CeEs0tEqh2VHiqu0nnNFXcqlyix7Jwj+FjjUb3X6PdA=; h=From:To:Subject:Date:Message-ID:In-Reply-To:References: Content-Type:MIME-Version; b=KiFFpkCJFhXAN6dQRhNjo2hOFKcysaQQNmKVAAs/0IbceMnVjEirZsWBzknOZU+kIERcYn482hxjnox40sNhO5863G83Pw5v1lbZr1MdNMvXzq2D27nGkjzqeHfqRYPryaDVNWzLVkX7IuqgEk3ZINax0EMUUWyPvt3FnKht5j8= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=outlook.com; spf=pass smtp.mailfrom=outlook.com; dkim=pass (2048-bit key) header.d=outlook.com header.i=@outlook.com header.b=csQCGSf4; arc=fail smtp.client-ip=40.92.112.23 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=outlook.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=outlook.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=outlook.com header.i=@outlook.com header.b="csQCGSf4" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=JHWP/Fyr1yhBOpSZRZ5tT6A1bkUp7vkc9gXEWkUQ7LHL6fmfV4vKR8OBth9EC2i4ece94StEmOLb2xXcK7g+ZZl2tyJeOUWiM+QeIF6BLjNs/uVxSj1RhOyMCYnlClPnNrS4usI15HBiBADV7qOB/JJh564lnk0r8VSx1k88O6IjebJZosy+JYJt2TrtKUTbcEK/r40ocntvL6JCiqtWN5PHLYrcnhbapdvtWaxgccxmAxYQzjuKUvi6BMuAnqzy0Vh03PnnoKK2xxgiyyWa6jEHJVDirAt3hn/l17xFMELyyC4eooTVPLVcU3Dbd+nom+x5ORHJ3QiTqFXBw2YEJQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=BPY0T2zsvShqqsPZGHaIhc8jpaX8rvAk63Ts2YuoaZk=; b=tMIQl6hYrz/Xvi9s1onxwTFq7r6hF9oYWiWTNY/u0bbOJk/vbYoVdXTjC326Tj3jjMM3YDrfBv0ogcvg8OXN//DuTVEtuYYzgPfCVCdVdWYxSy2ORfuZzu+jZMcbBJlt+SlzYDjh5TYH5wBSmAHNQctzznxYDlDoGQj3JcYf5sor/aIfjwqdD8EKvFQ7Z3phN01Dad+4cd6cn3PLefZk7uTnVUQ1klGgHaxl3T2m6muVrPsV+F8T0U4aRUSTELRHQWE17fmzhhpIwSdw/dhJ5A505pqpRUYZ0J9MUhKrXTnkHUfeu+OMfk7eaPHdom5yMvBT2FeDF9aKB4bxDH2BjA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=BPY0T2zsvShqqsPZGHaIhc8jpaX8rvAk63Ts2YuoaZk=; b=csQCGSf4rYJQ+YIvmZRiKwokJkHcI2C8b89UWsocD9ImmJ8DYfc73kPFzLfVX7YSBshaULHq8DEx8cYNzNkGIDJq5D07r3ZOFJGwkqIHlAhKmpXSgN7y6gyccKUCG2ZHLuuqZ2GR9MnvrLzI+90tP1rFVaRWtfTjcG7EsoK7vaO2Tb/CAgQYH0rIm7x32/zjY8P1tSFupuLtgnIIQDXsgJ9pcSugqXVP6p7irbEXGMjPRXyF4MBo3HOBljYnTHAxPV8rk4MmWxmgKFXtbZuOHkvOpVXDrrq9HNk0o1ckTjz/EhwGakoOemmTYEB8MxMuEHvfSkzkZhq0RblaaS8BIQ== Received: from CWLP123MB5473.GBRP123.PROD.OUTLOOK.COM (2603:10a6:400:160::13) by CWXP123MB4166.GBRP123.PROD.OUTLOOK.COM (2603:10a6:400:b4::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8356.17; Fri, 17 Jan 2025 23:40:37 +0000 Received: from CWLP123MB5473.GBRP123.PROD.OUTLOOK.COM ([fe80::c0fe:9ff5:51fd:3fdb]) by CWLP123MB5473.GBRP123.PROD.OUTLOOK.COM ([fe80::c0fe:9ff5:51fd:3fdb%6]) with mapi id 15.20.8356.014; Fri, 17 Jan 2025 23:40:37 +0000 From: Manuel Fombuena To: pavel@ucw.cz, lee@kernel.org, corbet@lwn.net, linux-leds@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 4/5] leds: Kconfig: leds-st1202: add select for required LEDS_TRIGGER_PATTERN Date: Fri, 17 Jan 2025 23:40:30 +0000 Message-ID: X-Mailer: git-send-email 2.48.1 In-Reply-To: <20250117234034.670794-1-fombuena@outlook.com> References: <20250117234034.670794-1-fombuena@outlook.com> X-ClientProxiedBy: CWLP123CA0273.GBRP123.PROD.OUTLOOK.COM (2603:10a6:400:1d5::20) To CWLP123MB5473.GBRP123.PROD.OUTLOOK.COM (2603:10a6:400:160::13) X-Microsoft-Original-Message-ID: <20250117234034.670794-5-fombuena@outlook.com> Precedence: bulk X-Mailing-List: linux-leds@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CWLP123MB5473:EE_|CWXP123MB4166:EE_ X-MS-Office365-Filtering-Correlation-Id: 47bc8b78-d24c-4c55-a503-08dd375057f0 X-Microsoft-Antispam: BCL:0; ARA:14566002|8060799006|15080799006|5072599009|461199028|7092599003|19110799003|440099028|3412199025; X-Microsoft-Antispam-Message-Info: gRwLWODQ0HA1nE1uNYP+PA/DeTUsQbSOkhshSDU3B/ga+CS9qFX1+umJuj9FlTnr96PYaA2Am7j7HSUMdpBvYm1cj4DRXnXDPbIHTJKRMupgXvl3ozg0ABPo/UfMxjuXQQkyAQCEJosglvMhgjiMjFDBFUYgSo83FppBcZDgMey5+vI9zmn1d+FUX6CN5XLYsuALng8rGlsaLE7JlgrfOua6c5db3XLE0E2aTtUNcvVeU/Kiv0QL5AFn3tGa4DgQS3bPRa171RmOx+acglPNDPQKCLSTHojMiI/EqkaQ7OYcyAstAaZ6NKkhO+NA72PWT7FTQAo45Z62qo3CXSE35RnlJa8R1Hf6rm+77C3jvk+no8Md6vmFA2waNveT88dV5vYqCMB6PfJJtS26weApVucryJR9GuFO2xbWn10PWFlIvJuxmwfmx/6aBkNo3Pz3S2h7ADx0kmTV6bZ212613640JtSecvPinaboGE5QRvGmgkLbOR0wAXUvcF4CNxaUu320H/y8pbRXo+MEDrdW72TwFVURAzVMXYU2r2MejMOMSu6QVXA4cKY/gPO/WV9oGT6XQd4EYHcLUDTPHpPMqGHnjRaSpgGhYJUa79eKG6eSI00B+4kYEGTMbiCS6t/JJsOOJ68e7ahRJJ5GBKfyrplnVaDBZgAfYLj1unIYKQZuHH4tEL86dLbZEXlABq6tptg76tBWMKl/ASeNLnXROAgaT0EAtvY2lQTNGDJDSqwJHdzdl4TFGm0Xh+xOdzDM5uTzQBaO8X/KElR34eANMhHq8qOEN3qvr/YIRSAO+UPcHcLmckrcm4IUOjpfcBeDQ7xtJkq8rbAgMPDLSuNe2lQNF5qLYJ4oqEBzEiEoH9febrYc59nHJCzuPJcGfjAFzpDrrOHzF0SyhdRW6HZfAT8kdZD5VyIDOL/gWrJzqkxTA+NCiV5Jn6t308RKn27ilte5X8vObrtH1VESbfp2A98h72wb2HdTUeciw9uTRo7Ul8d33ewfAr1dLNxVlduWvwDYYsY6YvbD3NFTgQVYvP67x4M42k6z12fwbPLhn/VF59Z85lcRA73mB5qe03b9JB7x1/bWyh8dJS5wEOXazQ== X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: E8R47Qo2mw3bKQQVE36+lWnH8HX4PtZpXAqHK8aUj/3TkDEmzrNBHp2inVHN/OdF95b1VX7cWnFHBtKGrvU/Po5r1J/JXNrybYtj/1lUDKk60P6PCzVBh/sFBrIfUTHptLBmJhQA37KBH329icdJjsWar3JfKD+Vc5zCJbx/XhS7/VuxZI3F3g57T9CY6aagFG+P5eKgK8etwzoC/YsBF7ELRxEfjYElaTXExuNOLf4EwXVtjogXtXMwdZPP4u9tc5pIIQES4LqPOs+ql2x5j9HN9Rbs4gCdGF2Ujx7L7D/DJADyD5e423tZDvjnQ6S8PjX7FHmTXo25gXoDhBNNwO2oCV0+7np0PEr8bjk2Zq7rWQmGVf2sTwJMPXWH6qKylcENJ3ciPYBdgQGZM4FL5Rrz7jZkUrGW+yoeS7dPOMnA6HQufdTkKhZ0ni0BBWjU7DewcpoAGbMjGxjD61k/h4aRg5QhAyo161+1YXsRxouMsuHNVIpt9v+kl8DJ5fb+nvqj4otteizidbQHgjuLzO3nJBWpqfH2y2S6AawL6WTr0q1AS8Hv7h1OOwtCLHLUN6zYvLGOPQLdPXt+zykqy0F8z6QXqFDjxI//P8hqkbCio4hIKkJk2kvkcXNhRSK6827sXnxg7G1SlQgulvgwclyQ1N2uMAOnZCF0cUIIan9yYDWTvwLQ20LCtTaiQeST0Vj4YTF7JgiXb/X52SkLHBQqbGCfaI5s6aIaPCJ44decqvwnaYsqEvlVWkVR39M9YJ6UQhe93vLiRQjTAV1b0k2VEcK8Zrf78izziUT1jQ15pj96gojygtHm2b3I2owkx6XV7EGd+1fYFbbJngpcmqNQ9dVwSB2/HiRFclQtQNQPKuYi+YKwtqqXeSYMv7WbLwawse4OJ4y5mKw3q+aO30SGv85/iO+OeWeBa7SsjZNj5hRHBy04ILJNPKSNq8l3lY4Q7pJrARR1UGR+Rqnz210wksDxOZUnfQ06VCRF+5RhjCPRUV2SqRKlh/oNlTmmoqTR+j6ZjvPugN3TJmSFLXpWJttrGxlnQejM+7De6F+XT8P9w7xzHsEmFNW6TwxDNK5JIrJsCeCy8/L5bhtYaltkQhiiEw/DNAGvVYV1jp6EvL2ttXPoaUBFZuR6mdzELTBwASrup/qUaqkM4qCedkqsKAox0ISdZBxPu8tN1QxSbEjT+5k/Cx0EpmJHGeWA/mBOfALnhWRZ2ZoDWSvkB66sSFpnWtXtXRwljBTBG8jUcOpxDoe+HW3PPIuTpb/gnzYicSa0qhjnIcqlYmfmUnIoGcPo929lWKDsaYT4D4s= X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 47bc8b78-d24c-4c55-a503-08dd375057f0 X-MS-Exchange-CrossTenant-AuthSource: CWLP123MB5473.GBRP123.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Jan 2025 23:40:37.1886 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: CWXP123MB4166 leds-st1202 requires the LED Pattern Trigger (LEDS_TRIGGER_PATTERN), which is not selected when LED Trigger support is (LEDS_TRIGGERS). To reproduce this: - make menuconfig KCONFIG_CONFIG= - select LEDS_ST1202 dependencies OF, I2C and LEDS_CLASS. - select LEDS_ST1202 - LEDS_TRIGGERS is selected but LEDS_TRIGGER_PATTERN isn't. Add select LEDS_TRIGGER_PATTERN to Kconfig to meet the requirement and indirectly document it as well. Signed-off-by: Manuel Fombuena --- drivers/leds/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/leds/Kconfig b/drivers/leds/Kconfig index 6efd514bfb48..b585548c51cb 100644 --- a/drivers/leds/Kconfig +++ b/drivers/leds/Kconfig @@ -960,6 +960,7 @@ config LEDS_ST1202 depends on I2C depends on OF select LEDS_TRIGGERS + select LEDS_TRIGGER_PATTERN help Say Y to enable support for LEDs connected to LED1202 LED driver chips accessed via the I2C bus. From patchwork Fri Jan 17 23:40:31 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Manuel Fombuena X-Patchwork-Id: 858414 Received: from GBR01-CWX-obe.outbound.protection.outlook.com (mail-cwxgbr01olkn2048.outbound.protection.outlook.com [40.92.112.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 53ED51DED71; Fri, 17 Jan 2025 23:40:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.92.112.48 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1737157246; cv=fail; b=UEZrogm2kHhXOKAfaQFsZslxhPHEzlAlWyDM5HeHS7Cfe3gVvk+CjtgTFPL6XBlZkUkR0pNxSq40/2u+th7CX7PsZ/Z01gljWe/AndcjWsKVCB3aCeK2msei609TKTIVUwPHyWcY2j2iXdQ2/puBMdZ8llpb3ZJzGLd4l/dNRKI= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1737157246; c=relaxed/simple; bh=lgiXXvCaKcBCyhP26HiVwsbPcg2M35/IDLImVgQ7rhc=; h=From:To:Subject:Date:Message-ID:In-Reply-To:References: Content-Type:MIME-Version; b=XgxBKHGPWsXHHZsr1jbkA4PzTO57bD/QNBVhpXIgQIFTOa6Iffn5qfsMcf42PJwe8SimitbTR4js4xCccSoEs/5ZOmr/mGUn21/6ADuxuKRmogB+wnH+Ut/RoYvspHeiMDLTGZ8h0EWCES8L/OCFHe6inlbqR3Ci1w/88jsQ98w= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=outlook.com; spf=pass smtp.mailfrom=outlook.com; dkim=pass (2048-bit key) header.d=outlook.com header.i=@outlook.com header.b=meMnbOpD; arc=fail smtp.client-ip=40.92.112.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=outlook.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=outlook.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=outlook.com header.i=@outlook.com header.b="meMnbOpD" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=ZQqbN+TzuTAxDh3yuI2N44sZSLzb1xNlt8h91TDrhnCFRDjAzx+mlg714PH/gSjKCA1hANuPqtHchvd/KHmyZpDCyVAzE0+XimvUkLt+CUww1wKvxcghipO1mfmqyTlQy926SgoNixEPsX+FHxp9sC1nhmHXoSoXwCPhLwaMQqdLdrTvQe9q4cpbmRHVBCiu34I7HGtHeFgjEgIhWrEcA3nOPpve9Vahz2mE36qe5wUp++NtduvCWsB+eMw0K/6e0TE2bPZJkP7jo85acFxCR9sR2ijoxRQwQGnGIWTZ3jvfe/jineQlG7zl6GxTGyVmKjzb6h7AZvnDXw+pnbGPhA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=c9v2O0/2Rxg68/EBe1Ab+v/cvXrGzztTeldf326wlbw=; b=tUOQfhxUna6JH0JXddhVZnaOsa06hYEbutrliB93e14kBleUHrTlzsnxZnX28Fjl3U88hutGhagaa/Q0wecqEm9mcnL8+jo5MhKPNwBi0plIYi0pBrYIpE8P7A89S3DmhUu/LGUdtQAe//yFjCDB0O5G6ve92TSxEKdbqjfEYB5zkMzMCyjmG6h9D3ybM7noXUaWy2P9bXtKMMUpx5Dpk6MYiCK87WukGJrwf14LVRmPrXecoxMbLVNtRMN0CAX+6VaqqkMKmLg01WC45wguKirwIj9NXxP9RpPfPy3d4km0Ch11frN6yhmsmnZrLJKO4i2JYtgJEokbV26K95t7XQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=c9v2O0/2Rxg68/EBe1Ab+v/cvXrGzztTeldf326wlbw=; b=meMnbOpDAs3inAx3/hB3JrkmVDIlOWnUcGAl0PZy1hcehNiuva1G69kESfXZW4n3wmENnA8wVP3abLkAyNr644wt9m1FuYuL8ShKCN99chn+Z0PEEHDQLXlkXxFuJb0aIPuY3QjkZzctN1M93xfbj3IDUsP8OcF5FC8WbTrRM/CBRgIsKbkNzxvB5W9OomS/EzF31zHJ1nu8RR/MPmVIEmY373BSyTUPpT2Z+OacreLUDGc20HtX0x258IfQ54zaDhsPtjAnC/mMgEggunPteO6Tf8xt3Vmf4wRo9Y1KWKYc18SlWP/lP3I1iFeFSIRHhN9YIe6U6jvLR3jUw23DGg== Received: from CWLP123MB5473.GBRP123.PROD.OUTLOOK.COM (2603:10a6:400:160::13) by CWXP123MB4166.GBRP123.PROD.OUTLOOK.COM (2603:10a6:400:b4::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8356.17; Fri, 17 Jan 2025 23:40:37 +0000 Received: from CWLP123MB5473.GBRP123.PROD.OUTLOOK.COM ([fe80::c0fe:9ff5:51fd:3fdb]) by CWLP123MB5473.GBRP123.PROD.OUTLOOK.COM ([fe80::c0fe:9ff5:51fd:3fdb%6]) with mapi id 15.20.8356.014; Fri, 17 Jan 2025 23:40:37 +0000 From: Manuel Fombuena To: pavel@ucw.cz, lee@kernel.org, corbet@lwn.net, linux-leds@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 5/5] Documentation: leds: remove .rst extension for leds-st1202 on index Date: Fri, 17 Jan 2025 23:40:31 +0000 Message-ID: X-Mailer: git-send-email 2.48.1 In-Reply-To: <20250117234034.670794-1-fombuena@outlook.com> References: <20250117234034.670794-1-fombuena@outlook.com> X-ClientProxiedBy: CWLP123CA0273.GBRP123.PROD.OUTLOOK.COM (2603:10a6:400:1d5::20) To CWLP123MB5473.GBRP123.PROD.OUTLOOK.COM (2603:10a6:400:160::13) X-Microsoft-Original-Message-ID: <20250117234034.670794-6-fombuena@outlook.com> Precedence: bulk X-Mailing-List: linux-leds@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CWLP123MB5473:EE_|CWXP123MB4166:EE_ X-MS-Office365-Filtering-Correlation-Id: e5c147c7-00f2-4781-c3c3-08dd37505832 X-Microsoft-Antispam: BCL:0; ARA:14566002|8060799006|15080799006|5072599009|461199028|7092599003|19110799003|440099028|3412199025; X-Microsoft-Antispam-Message-Info: 0hwVoKb2SfpextlL0B123xlm0bIdAWDy49EqnFulgyw4PxVRgiagKoASFcUOi7imWRUyoyaOU4sTXw3P/z/1bAmPGIp0zauHRYeKTBS+MD4WFsmTX9hQ8MX7AQrNoQNHyIdpUdwBtVDv8bO3UjKt7AT00R2j4ja8hKqRkMCtsXMNpKYFznAc4C0KCGJ5qpMvRQzVhCMC4JkQk/XPoWFYVsytTLL7A3p2LllwdUQCPl7lE6HQD3Cds+m57p50tsMUJ07JfwgUV1F/QdZ44hguZEuCtTWr2BQKkuVyLogwGfuDYoYdBfBbulfdYzBH2jzF+LRlxkAI9+Nm53YWd6ABwZkAGtKdJcRrgB3j6K4yB4ODRmf9zePyTLhOhioAj3ClAIiOJO4NxS1+JGHeAGA1Z1RgitQmuN7Ok9imGP78wLombAMJzQnD42UMefGsVJ6GBLlGPod45ENIgitTBYSPUCr+wjbqqsJLbTx8vmt6pgk8N9mjnJE/yEfipSbHg2CPjcyugpw+d6gD7tNItvLJCMX+clezQZevvp/RtwN2kZlzy/1671uaTnJ6X8XKSshO7b2pumHJxTzPDnil9F+tEGeWYay0neU9jpLGxED1KKz/hvVWp0G9VbpVezNOBdnSD6Bo7ezE7Ndr0uFP6y8NBcvmM282KLFNwC7FuUSnoC3XKyxALs0D4ZnAi+zV9G5y6mkH1uyRbNH4/yZZzM9BO15EpzVIf1Pu+GpLdwfXOeWUDG5+SUvQn+En6Hq5RuIbzMQrkSRTZ8CHGJewSHngFnb7NLFCZ76CGD50YmQGVz76nr1+Oe7+rLboURBxC7c+7I+rqhjvpyfUrm4nfhWvmIhBSfU0FSalKE8LK+DTkzIgmQDVuhWAjjRRMFW2F9wJgIa5fpLJdYFVuaViRrupzJQi2tx3EzYFQdKVWnlDGK1SJ8Pnqt1Z0UBTER9hxG9s9d6rzch6b5hc78+F0igjzRu0IojoqVveAIFLTf3pkwSXF41LLFablJKCc9cnLnFyw1IjAmRFN6Wh9GS7y3tsZ1iqtM8oCUJG4/P9i+ue+kAgwKc8JDg2cdv1Wb/IJ/sAQ2HzWrx0ouPSNrTOmFDugg== X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: Y2NHcSOzoaCFqwJQSx68tPtJ5Mr6O4I8YAqcXR1NwwgGcL+A0e1JrBV/AR6RMwJpQwzs70mXx4g6+z2mKe3IUtFDfs51U2uhgHRdPA6DqeGoabT812QCaxdzwJ1dA6GmuNlsb0kSaLPQBRp71UswNc7wP4QUGVIpjtamthLkhdNJFB0JHr5/VUaze97jXHA8R4loSvZ2hu7cBil92E334zM+gtIh+KNCea2wkdkZffgYxKh/MLILYYZyuLXieJcEe+suRtC3QHHDsvSGzVvIJMPa7nXzuFShGrd5Xvp8OmNHPZcgaxj1D0QxENVpw+OBE/0qkeHRyeTZPBMaGzTJfYun6gfClNAOHdxNSCxfhvQTTDwK7OA02NRbu7W89sfOoWMPFo4NIjm241eiOsWC/9xNiUK4N1x5v1FUC34tTA7HQdpVrubIvOpjeNLalfQH3eyg2PpAgJN3NMAEctHyIEqi7Vct4Fu3MM8TrOUWr5XYpldOsvkKM/5GvqtoFh/3OHB+79ejgHSMwXiEL6W7VRc//yBWa73K53xojWDtVQXXnZu1C+Cf2hIWF52dMqd515hVMRC5aARw7Nj7k7pc9oIuzI4h8xtQTKFIQvrxckBLhC0tNv07YG74Wu/PGhfiNsR5IF58BMAwVk+mBEb9RWgn735ETZMDSjNiHlakV9shrJjCDPF6QVnIFhgUSJjgP2jOHHpjfn6osozV7x+nuahaO5dqs/XHJGROYlzoqz0+Ap0lUPSRZoxeMu1ucJny3zVawl4znFfF+B++RvHnKaePFUcsXObXwmucLiDwjtowJrMqUOOlZ6jioDpE8AHgqvBUJW6o2SiwvFlRKgfPHuZbHZXoofLtURW13p3hoUT1fD53M+k2KIiGju9F6mnPKMjON+XrE0HdGw5gvTmGiNxxR2Ob1mnj7LKpZow2muhQ1PJSqx/+O/85cU5lB07tUBFVAIZMZJOQGZRQpeKNDrn3k1s7U6gDS39yOcTa1eQSqj5UyxCA09JdpTtjqtC1qMPnMiWfPVMBGAD2E7csaGOdT165JOD7uxyaMcLiODoujBzn2Pstk4DRAebL6FYnGGBf0g/BZUOzTjx0SShbbt62XnP2Z+jW33eX7xW1P8jPkuN90Y3Tklr5nkZnaLCQeEXq7Eqy0x4oXwZuvwSifce+l+rStV+mBIKQqLbtYdQRzbgV0RhSEz25BlPeHVGDJkXjlhgl7VMF4P1sCmBXSqREJC9G3TddLh9YRiVWGH4lsrLjTopWa6hQB8HUMNWjfuzzLrTAgvss/02sPPBw2MY8e/PAxyrTuSEBsMV2Tr0= X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: e5c147c7-00f2-4781-c3c3-08dd37505832 X-MS-Exchange-CrossTenant-AuthSource: CWLP123MB5473.GBRP123.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Jan 2025 23:40:37.6288 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: CWXP123MB4166 No other LED driver is listed on index.rst with the .rst extension. Remove it. Signed-off-by: Manuel Fombuena --- Documentation/leds/index.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Documentation/leds/index.rst b/Documentation/leds/index.rst index 0ab0a2128a11..76fae171039c 100644 --- a/Documentation/leds/index.rst +++ b/Documentation/leds/index.rst @@ -28,5 +28,5 @@ LEDs leds-mlxcpld leds-mt6370-rgb leds-sc27xx - leds-st1202.rst + leds-st1202 leds-qcom-lpg