From patchwork Sat Dec 28 11:54:36 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Michael Tokarev X-Patchwork-Id: 854007 Delivered-To: patch@linaro.org Received: by 2002:a5d:4888:0:b0:385:e875:8a9e with SMTP id g8csp5638670wrq; Sat, 28 Dec 2024 03:55:43 -0800 (PST) X-Forwarded-Encrypted: i=2; AJvYcCVycTT7VtmalXXDyiuJKILZo5K0vcpfiSL5JNtBiYAWh63cjs5TEkx4sv8Za7f+ivhvmTFH+w==@linaro.org X-Google-Smtp-Source: AGHT+IHi0Lu/whwt7MloAbijdsct1smdUrENiu0sL/JEkfiWDsBHX6BVz1zi2H6/zDdKv81Ko4cO X-Received: by 2002:a05:6214:1c8e:b0:6d8:a0c8:e467 with SMTP id 6a1803df08f44-6dd23344c84mr481325686d6.13.1735386943260; Sat, 28 Dec 2024 03:55:43 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1735386943; cv=none; d=google.com; s=arc-20240605; b=GHl1FS089WfT9Ygg/JzlIwN4DhGRHgiPLlEFujkaIA1JRW7ofWSH73A2qPDfg+cVz1 DriD0IzZwP7pc1UoR0JYr6Mh2Z/gaeVDDLI753V0xAwTrjLcHyr7pR+8mNl9VdYRJpqG KdVE9kRBvrcuAVXCS++n4Nuy09wgwGwIYwSWoQ94dtj4ka7v6N1q04HqF59382go/7wW 2HSpAj1zOvUrpoCFvy8QGPF6Nxr89EtDHf9LS0df/mo791YTuNclQAYDKrncuCeMrgM1 xgNusZKwh39ygecuUBfSmcRZ7GHBggCmpcaRNiw2QWUsPzahDl/y9Qa7pOIYTR4FAAXN T9vA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:cc:to :from; bh=TvbBmrV1GO9eVm3DnmG094O6B0xx+E1eMd/JYtZGp5U=; fh=Tst9A3s8N0JIiybDPLWp/hEhg66+XwiI7lxkBByeslA=; b=cAblFr89sQt9WyivFOPZ1CdqfMWN6AEVOrY9izWb7oeNKlbvsebpqrni69bvoaUVdq YiA4vQT4PIEz8Jmvrv+g837nYIhExGbwdmsSRs6MO1RQO4jVBSqdgli6wXMalCdO2VDI BleD1PtI08N+jVQmokHpPbzSl0s47/T5hTN1TqqvE4+nWP3wHCeimXyRxsNT1Ga8oPZW 0crQCWyf4VBsveWS9KdL1DuufQCjCDzeHN9FYKgKnQpCCa+Xq6cWQRkke1LtlcwSxGRJ RLmIVvG/n/i9hK7BcK5jfpcCPaI9AzGemmGJuDUVkik5RSsAvcaZguTTYJ2rT6VaA/MF Q+pg==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org" Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id 6a1803df08f44-6dd1836fb3asi221833066d6.509.2024.12.28.03.55.43 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Sat, 28 Dec 2024 03:55:43 -0800 (PST) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org" Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tRVPK-00062h-VY; Sat, 28 Dec 2024 06:55:03 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tRVPJ-00062I-Hs; Sat, 28 Dec 2024 06:55:01 -0500 Received: from isrv.corpit.ru ([86.62.121.231]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tRVPH-0005lS-N9; Sat, 28 Dec 2024 06:55:01 -0500 Received: from localhost.tls.msk.ru (mjt.wg.tls.msk.ru [192.168.177.130]) by isrv.corpit.ru (Postfix) with ESMTP id 6D38DCC821; Sat, 28 Dec 2024 14:54:06 +0300 (MSK) Received: by localhost.tls.msk.ru (Postfix, from userid 1000) id 4422F4615E; Sat, 28 Dec 2024 14:54:46 +0300 (MSK) From: Michael Tokarev To: qemu-devel@nongnu.org Cc: Pierrick Bouvier , qemu-trivial@nongnu.org, Michael Tokarev Subject: [PULL 01/11] docs/devel: remove dead video link for sourcehut submit process Date: Sat, 28 Dec 2024 14:54:36 +0300 Message-Id: <20241228115446.2478706-2-mjt@tls.msk.ru> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20241228115446.2478706-1-mjt@tls.msk.ru> References: <20241228115446.2478706-1-mjt@tls.msk.ru> MIME-Version: 1.0 Received-SPF: pass client-ip=86.62.121.231; envelope-from=mjt@tls.msk.ru; helo=isrv.corpit.ru X-Spam_score_int: -68 X-Spam_score: -6.9 X-Spam_bar: ------ X-Spam_report: (-6.9 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_HI=-5, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: qemu-devel-bounces+patch=linaro.org@nongnu.org From: Pierrick Bouvier Reviewed-by: Thomas Huth Reviewed-by: Richard Henderson Signed-off-by: Pierrick Bouvier Reviewed-by: Michael Tokarev Signed-off-by: Michael Tokarev --- docs/devel/submitting-a-patch.rst | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/docs/devel/submitting-a-patch.rst b/docs/devel/submitting-a-patch.rst index 10b062eec2..03b2ac298a 100644 --- a/docs/devel/submitting-a-patch.rst +++ b/docs/devel/submitting-a-patch.rst @@ -252,10 +252,7 @@ patches to the QEMU mailing list by following these steps: #. Send your patches to the QEMU mailing list using the web-based ``git-send-email`` UI at https://git.sr.ht/~USERNAME/qemu/send-email -`This video -`__ -shows the web-based ``git-send-email`` workflow. Documentation is -available `here +Documentation for sourcehut is available `here `__. .. _cc_the_relevant_maintainer: From patchwork Sat Dec 28 11:54:39 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Michael Tokarev X-Patchwork-Id: 854010 Delivered-To: patch@linaro.org Received: by 2002:a5d:4888:0:b0:385:e875:8a9e with SMTP id g8csp5640235wrq; Sat, 28 Dec 2024 04:01:30 -0800 (PST) X-Forwarded-Encrypted: i=2; AJvYcCXaLfMyVVJi/82wJMLBxdZhSkotaAz6TKDmYtRM3rXRmHwBm/pyevjxgmmoOLZzz5xTiKShqw==@linaro.org X-Google-Smtp-Source: AGHT+IHQKRtHzbZ4e7lqfFc2kerdr5dr+MvZ/bX72o5L9VIk0Lye684MOC/V0CTdVN9h5C8mEkZi X-Received: by 2002:a05:6102:dd1:b0:4b2:af3b:90e2 with SMTP id ada2fe7eead31-4b2cc35dd51mr25191179137.8.1735387290700; Sat, 28 Dec 2024 04:01:30 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1735387290; cv=none; d=google.com; s=arc-20240605; b=WL6gtXJGeN3u2LrgfjZdONOXU1AI7rVxFVBzSErL0P1pPSfZeJ2SEjj/KplmbzocmV jq/jOPOuQRd3XMyHE+tH0OLSkGhQXLJt6aTLcHqQo0hrP1v1uwA1+hhnGZtX+i5lTWyD F7+4v2FAal4CztwBGkqxA+IdvEoVyaqJ1YN/tzL3x/VKVI1odT2cnm3Ip+7s/SlAFaRF mra+P0Hy07tNar6fm0xjNrWFhTYKJjENsJVVyzBDj3lRKV/DIaGtBhEJkLueE4o4V3cd bhekTXOl3Mc/rmJbPJL6tSzkGg/EP9fFcxxfTyug/7ZUeoogPUIEblPMWKB9jbzzEt1t 1UyA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:cc:to :from; bh=8J9rPkxEEOUYaDg376t0ux3x8JmNvXwmVqMo6F/GPro=; fh=Tst9A3s8N0JIiybDPLWp/hEhg66+XwiI7lxkBByeslA=; b=eRe5KrH/gfW+nFazcSlVZakS6znbCFGNge/2oySj5wtt9qDrgrx87uGftg0c+Nqfe0 +7pthTX/iUJURdmbiC+kspcA2ehh30Pk3LUJw/rsU8gDbt6eVcrYoU6g1uUVFpDGeOMI k+LPrA+rciY0YD+IZ4fLqMPOO4rnfyr5dzDRkWc7u8vchgHJ706EKiSCiqVXYDbcpR06 0ewQCutkt4/9IQDTm58A5nmHL4BvJeZe7vJzSqx/OKe8F+CjdzeRLrFzcc3/KSVCggeE V8W126YMKdoDYDfvC5ID1jGiUzFRoA8tHSfSsZ4wA8eclMLIFZWW1vo6SVvu/WJA3/sn vHiw==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org" Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id ada2fe7eead31-4b2bfb1dcabsi6586102137.301.2024.12.28.04.01.30 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Sat, 28 Dec 2024 04:01:30 -0800 (PST) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org" Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tRVUz-0003Ed-VF; Sat, 28 Dec 2024 07:00:54 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tRVUW-00039i-Rw; Sat, 28 Dec 2024 07:00:33 -0500 Received: from isrv.corpit.ru ([86.62.121.231]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tRVUT-0006gI-OF; Sat, 28 Dec 2024 07:00:24 -0500 Received: from localhost.tls.msk.ru (mjt.wg.tls.msk.ru [192.168.177.130]) by isrv.corpit.ru (Postfix) with ESMTP id 9DE2ECC838; Sat, 28 Dec 2024 14:59:39 +0300 (MSK) Received: by localhost.tls.msk.ru (Postfix, from userid 1000) id 4AA7E46164; Sat, 28 Dec 2024 14:54:46 +0300 (MSK) From: Michael Tokarev To: qemu-devel@nongnu.org Cc: Pierrick Bouvier , qemu-trivial@nongnu.org, Michael Tokarev Subject: [PULL 04/11] vvfat: fix ubsan issue in create_long_filename Date: Sat, 28 Dec 2024 14:54:39 +0300 Message-Id: <20241228115446.2478706-5-mjt@tls.msk.ru> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20241228115446.2478706-1-mjt@tls.msk.ru> References: <20241228115446.2478706-1-mjt@tls.msk.ru> MIME-Version: 1.0 Received-SPF: pass client-ip=86.62.121.231; envelope-from=mjt@tls.msk.ru; helo=isrv.corpit.ru X-Spam_score_int: -68 X-Spam_score: -6.9 X-Spam_bar: ------ X-Spam_report: (-6.9 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_HI=-5, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: qemu-devel-bounces+patch=linaro.org@nongnu.org From: Pierrick Bouvier Found with test sbsaref introduced in [1]. [1] https://patchew.org/QEMU/20241203213629.2482806-1-pierrick.bouvier@linaro.org/ ../block/vvfat.c:433:24: runtime error: index 14 out of bounds for type 'uint8_t [11]' #0 0x56151a66b93a in create_long_filename ../block/vvfat.c:433 #1 0x56151a66f3d7 in create_short_and_long_name ../block/vvfat.c:725 #2 0x56151a670403 in read_directory ../block/vvfat.c:804 #3 0x56151a674432 in init_directories ../block/vvfat.c:964 #4 0x56151a67867b in vvfat_open ../block/vvfat.c:1258 #5 0x56151a3b8e19 in bdrv_open_driver ../block.c:1660 #6 0x56151a3bb666 in bdrv_open_common ../block.c:1985 #7 0x56151a3cadb9 in bdrv_open_inherit ../block.c:4153 #8 0x56151a3c8850 in bdrv_open_child_bs ../block.c:3731 #9 0x56151a3ca832 in bdrv_open_inherit ../block.c:4098 #10 0x56151a3cbe40 in bdrv_open ../block.c:4248 #11 0x56151a46344f in blk_new_open ../block/block-backend.c:457 #12 0x56151a388bd9 in blockdev_init ../blockdev.c:612 #13 0x56151a38ab2d in drive_new ../blockdev.c:1006 #14 0x5615190fca41 in drive_init_func ../system/vl.c:649 #15 0x56151aa796dd in qemu_opts_foreach ../util/qemu-option.c:1135 #16 0x5615190fd2b6 in configure_blockdev ../system/vl.c:708 #17 0x56151910a307 in qemu_create_early_backends ../system/vl.c:2004 #18 0x561519113fcf in qemu_init ../system/vl.c:3685 #19 0x56151a7e438e in main ../system/main.c:47 #20 0x7f72d1a46249 in __libc_start_call_main ../sysdeps/nptl/libc_start_call_main.h:58 #21 0x7f72d1a46304 in __libc_start_main_impl ../csu/libc-start.c:360 #22 0x561517e98510 in _start (/home/user/.work/qemu/build/qemu-system-aarch64+0x3b9b510) The offset used can easily go beyond entry->name size. It's probably a bug, but I don't have the time to dive into vfat specifics for now. This change solves the ubsan issue, and is functionally equivalent, as anything written past the entry->name array would not be read anyway. Signed-off-by: Pierrick Bouvier Reviewed-by: Michael Tokarev Signed-off-by: Michael Tokarev --- block/vvfat.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/block/vvfat.c b/block/vvfat.c index 8ffe8b3b9b..f2eafaa923 100644 --- a/block/vvfat.c +++ b/block/vvfat.c @@ -426,6 +426,10 @@ static direntry_t *create_long_filename(BDRVVVFATState *s, const char *filename) else if(offset<22) offset=14+offset-10; else offset=28+offset-22; entry=array_get(&(s->directory),s->directory.next-1-(i/26)); + /* ensure we don't write anything past entry->name */ + if (offset >= sizeof(entry->name)) { + continue; + } if (i >= 2 * length + 2) { entry->name[offset] = 0xff; } else if (i % 2 == 0) { From patchwork Sat Dec 28 11:54:40 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Michael Tokarev X-Patchwork-Id: 854009 Delivered-To: patch@linaro.org Received: by 2002:a5d:4888:0:b0:385:e875:8a9e with SMTP id g8csp5638805wrq; Sat, 28 Dec 2024 03:56:23 -0800 (PST) X-Forwarded-Encrypted: i=2; AJvYcCXGQD5UmxVhc2oRYHbeKC59gRckamd3KqmndxV0LooGCTGroFFjc7mO3MRGigVQJZUUssF9hA==@linaro.org X-Google-Smtp-Source: AGHT+IGs4mr4POGUBdnBCqwhgoSuj4mGdcwmfhYfquZ0NX43eL0D9m+hbGGZyCShP/GuqJbgQkFV X-Received: by 2002:a05:620a:2487:b0:7b6:cedf:1b48 with SMTP id af79cd13be357-7b9ba70310cmr4149896085a.3.1735386983407; Sat, 28 Dec 2024 03:56:23 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1735386983; cv=none; d=google.com; s=arc-20240605; b=YTTnucJ/9EfqMuDIeCNQDQK8VcV+7K3jxSxiSbNpP7kaqEdU2m03OSqltpv/qrCpqR V3tYLl/bvV43NjRXF3549seaA0s0WT2y0xQj0PEupysPCo8X5+za1tIIbz9w+HEYI2Ie vzu/CoAxOKz79jjTav+IY+Qzi34U3oQgaeRcCc9I4KMxUQTs63r4PmoStopftaHgE3Gz 5aShvdKTvXfsNC45gQp9un7oWeX6w7XdJmsRYbPzH6gUvoOMhWWdxQxfKpWedJ65xhJH e/lg0HGrfsHch6BvOSeAIY2NNkN1/h8yLaMg334QygJX5hu5aGTpXKGUYcWXzoN3CUEr VV8Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:cc:to :from; bh=IDhNIRUMc+prHZrHzzKzltCSxZwS3DWWD3/vEFzsNFw=; fh=IMXbw0xx+6Q/2UEl1nyvDi1qBBGGml6rPCVUBtTSKyg=; b=IsexMMwsCd5W7UpzvRKCVt5g5zbM6rbTkta1OIysTu66eY6h5cO6jAdpGL8j0+qCwW PY3PBR7kKRNMa17knmc4uJRCfRmCs2g9FKVusIQCOQaYp8fL0WWnAR1R5nO6/SPKoEnJ tFhVxKNDk6m6CYd5InRigIWesfyNH6tamr0tr+84xro4xUmVwMS9viDdzvz8m3/6eLa7 GqUdJeAxQkNQDjtF41S3hC8k5oV1lY6RK81G1ZW6cCtEMaQa1w13Mz/vClly8KviqsfD cwS/KdhOxv/a4mI4gLYV9K/ymXqiy3kfllisBLZiGIqVXBhrB6hMQ01qna617fQfmXI2 sAyw==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org" Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id af79cd13be357-7b9ac2ce370si2642414785a.201.2024.12.28.03.56.23 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Sat, 28 Dec 2024 03:56:23 -0800 (PST) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org" Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tRVPP-000659-R0; Sat, 28 Dec 2024 06:55:08 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tRVPN-00064Y-Ke; Sat, 28 Dec 2024 06:55:06 -0500 Received: from isrv.corpit.ru ([86.62.121.231]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tRVPK-0005mQ-Sf; Sat, 28 Dec 2024 06:55:05 -0500 Received: from localhost.tls.msk.ru (mjt.wg.tls.msk.ru [192.168.177.130]) by isrv.corpit.ru (Postfix) with ESMTP id 7501CCC823; Sat, 28 Dec 2024 14:54:06 +0300 (MSK) Received: by localhost.tls.msk.ru (Postfix, from userid 1000) id 4D0D646166; Sat, 28 Dec 2024 14:54:46 +0300 (MSK) From: Michael Tokarev To: qemu-devel@nongnu.org Cc: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= , qemu-trivial@nongnu.org, Michael Tokarev Subject: [PULL 05/11] docs: Correct '-runas' and '-fsdev/-virtfs proxy' indentation Date: Sat, 28 Dec 2024 14:54:40 +0300 Message-Id: <20241228115446.2478706-6-mjt@tls.msk.ru> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20241228115446.2478706-1-mjt@tls.msk.ru> References: <20241228115446.2478706-1-mjt@tls.msk.ru> MIME-Version: 1.0 Received-SPF: pass client-ip=86.62.121.231; envelope-from=mjt@tls.msk.ru; helo=isrv.corpit.ru X-Spam_score_int: -68 X-Spam_score: -6.9 X-Spam_bar: ------ X-Spam_report: (-6.9 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_HI=-5, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: qemu-devel-bounces+patch=linaro.org@nongnu.org From: Philippe Mathieu-Daudé Use the same style for deprecated / removed commands. Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Alex Bennée Reviewed-by: Michael Tokarev Signed-off-by: Michael Tokarev --- docs/about/deprecated.rst | 2 +- docs/about/removed-features.rst | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/docs/about/deprecated.rst b/docs/about/deprecated.rst index 267892b62f..d6809f94ea 100644 --- a/docs/about/deprecated.rst +++ b/docs/about/deprecated.rst @@ -75,7 +75,7 @@ marked deprecated since 9.0, users have to ensure that all the topology members described with -smp are supported by the target machine. ``-runas`` (since 9.1) ----------------------- +'''''''''''''''''''''' Use ``-run-with user=..`` instead. diff --git a/docs/about/removed-features.rst b/docs/about/removed-features.rst index 9bebee795c..68fe0b47f9 100644 --- a/docs/about/removed-features.rst +++ b/docs/about/removed-features.rst @@ -518,7 +518,7 @@ and later do not support it because the virtio-scsi device was introduced for full SCSI support. Use virtio-scsi instead when SCSI passthrough is required. ``-fsdev proxy`` and ``-virtfs proxy`` (since 9.2) -^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ +'''''''''''''''''''''''''''''''''''''''''''''''''' The 9p ``proxy`` filesystem backend driver was originally developed to enhance security by dispatching low level filesystem operations from 9p From patchwork Sat Dec 28 11:54:41 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Michael Tokarev X-Patchwork-Id: 854008 Delivered-To: patch@linaro.org Received: by 2002:a5d:4888:0:b0:385:e875:8a9e with SMTP id g8csp5638780wrq; Sat, 28 Dec 2024 03:56:17 -0800 (PST) X-Forwarded-Encrypted: i=2; AJvYcCXIAtqj10Z4JVGuJpd6+o6Gwfrpe0o9S8SzeWSrVIZFUVxC8YHMuAZwX1YQiUlb4S998GFtow==@linaro.org X-Google-Smtp-Source: AGHT+IH9fT4z6yGKZJ/84Lug5UvzcBksb21pn0TcriM8QfeqXx0RYeZtq0/4l70shLFsStsalhpY X-Received: by 2002:ac8:7f4d:0:b0:467:770f:70a0 with SMTP id d75a77b69052e-46a4a8b7a33mr507401301cf.10.1735386977277; Sat, 28 Dec 2024 03:56:17 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1735386977; cv=none; d=google.com; s=arc-20240605; b=CT4ZCCw3HkoR5B2vivYTnfkuzCIDAI7HNBch5soxgyrgSmEHPl+Ljc8m9xYHVu0Igk mABQRrdIjgfurF7xEkAyJXPOELcJLuHoOQaiJFJJP1mJykJtLP9CqCMEdmSDlnCsONcH TT/6KCCIPvPyytPr2Rdn0BxJLMMJLYhLKkXea6VnH3cmBynEscpgd/O2z7wsVPrHW6Og TbwOQaqlmn6Ce7jNsMnRpmFP0qspzUNp1QG351UnDlBBzxx5w1tIvgJPkdGAcTXXpbtY 19zawoIFNde53HlJST89TRwqXGdQZxtxAcHJxsm3zm0wqehSed+lTeUa28bXo3KqwMRP UmBw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:cc:to :from; bh=2Fc1ytSfckFh4nRaAT1zaHU1UL2lp8bMGghH4W0fCks=; fh=IMXbw0xx+6Q/2UEl1nyvDi1qBBGGml6rPCVUBtTSKyg=; b=S4U2SlOXuF6DFpxXKyEb84QAt9WwwvyECZzZtBoHDooEG7w7QohdF+Tr2Tkbaea7M3 EQYymu3mOBK/+uC2u1L515PrA9Pw2jR8Z6fwEr6TFIWQOwYmJNGDRNx4yAYvrcWSnAzE iEnetHvmJw6rDJvF57jC2mBOOBoVQ28sYvEQe0+h2OOwOUWyPGJhSbifFCI9BQhdTM5C tk9UxxVANw0w3+DPLRvSpS9jzFp2u3fthez6p0n9o7PPkXYaffi0+C+PIFTnyDrFikFT 4lEy/cQNBUAcuEsRjUPzB9OA3oqI4lC9BMzIyrVL5z6mdgZevX6AaJrqgqiaG9In4Y46 iHuA==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org" Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id d75a77b69052e-46a3ebfeb26si240569751cf.641.2024.12.28.03.56.17 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Sat, 28 Dec 2024 03:56:17 -0800 (PST) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org" Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tRVPT-00067F-4p; Sat, 28 Dec 2024 06:55:12 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tRVPQ-00065q-PX; Sat, 28 Dec 2024 06:55:09 -0500 Received: from isrv.corpit.ru ([86.62.121.231]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tRVPO-0005y0-W2; Sat, 28 Dec 2024 06:55:08 -0500 Received: from localhost.tls.msk.ru (mjt.wg.tls.msk.ru [192.168.177.130]) by isrv.corpit.ru (Postfix) with ESMTP id 7B578CC825; Sat, 28 Dec 2024 14:54:06 +0300 (MSK) Received: by localhost.tls.msk.ru (Postfix, from userid 1000) id 4F9C346168; Sat, 28 Dec 2024 14:54:46 +0300 (MSK) From: Michael Tokarev To: qemu-devel@nongnu.org Cc: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= , qemu-trivial@nongnu.org, Michael Tokarev Subject: [PULL 06/11] docs: Correct release of TCG trace-events removal Date: Sat, 28 Dec 2024 14:54:41 +0300 Message-Id: <20241228115446.2478706-7-mjt@tls.msk.ru> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20241228115446.2478706-1-mjt@tls.msk.ru> References: <20241228115446.2478706-1-mjt@tls.msk.ru> MIME-Version: 1.0 Received-SPF: pass client-ip=86.62.121.231; envelope-from=mjt@tls.msk.ru; helo=isrv.corpit.ru X-Spam_score_int: -68 X-Spam_score: -6.9 X-Spam_bar: ------ X-Spam_report: (-6.9 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_HI=-5, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: qemu-devel-bounces+patch=linaro.org@nongnu.org From: Philippe Mathieu-Daudé TCG trace-events were deprecated before the v6.2 release, and removed for v7.0. Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Alex Bennée Reviewed-by: Michael Tokarev Signed-off-by: Michael Tokarev --- docs/about/removed-features.rst | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/docs/about/removed-features.rst b/docs/about/removed-features.rst index 68fe0b47f9..e3a87f3f55 100644 --- a/docs/about/removed-features.rst +++ b/docs/about/removed-features.rst @@ -1087,8 +1087,8 @@ processor IP (see `Intel discontinuance notification`_). TCG introspection features -------------------------- -TCG trace-events (since 6.2) -'''''''''''''''''''''''''''' +TCG trace-events (removed in 7.0) +''''''''''''''''''''''''''''''''' The ability to add new TCG trace points had bit rotted and as the feature can be replicated with TCG plugins it was removed. If From patchwork Sat Dec 28 11:54:42 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Michael Tokarev X-Patchwork-Id: 854011 Delivered-To: patch@linaro.org Received: by 2002:a5d:4888:0:b0:385:e875:8a9e with SMTP id g8csp5644102wrq; Sat, 28 Dec 2024 04:11:51 -0800 (PST) X-Forwarded-Encrypted: i=2; AJvYcCXgk/L1JdXwCSTpdX+tmNo9JVwZvY/0D55l1S2HyS0Ro9YbhRE7Buzvi5pQ3KzUOi2kffcEWA==@linaro.org X-Google-Smtp-Source: AGHT+IGy3Yictnmb3cOpkYF+7pLFhqDc9WYjLtgPVU9WRxhuIcxR8I2kXFg+u4DLdCf6tpDtySNO X-Received: by 2002:a05:6214:f07:b0:6d8:88cf:e690 with SMTP id 6a1803df08f44-6dd23308e19mr531625806d6.3.1735387911691; Sat, 28 Dec 2024 04:11:51 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1735387911; cv=none; d=google.com; s=arc-20240605; b=EZNFuc96WZQMozWIhR/IuCpfNg3LWSmwaVTUSEwFFzzJYkd5LRbOfJDlxWMUxus1r1 xDVyC5JG5fFk42qTnD1j8P++UOW1cWEooG1m+OAu74d8OIGrY4xwc1De8LzZI7Pl+GYm k1e44kr1TiDnLoisxRc0XBCjR4WzHYBXAcKuTW9hAbGetNYW4+EDCLweay7LuuEdeRiQ DrX5QkLjvIB2uWXodwDEBoK8B+EHmH4XmP0Fbam5eb4gCC14t0rSCtUdR8G7h+Sq4h3b mVaUWfQhivaKIptHp2w738+S0FKTSTGVAh2LrR5Pg8sHQLijhMhwrckTQ+lmCWrKc1MX rQmw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:cc:to :from; bh=/DZkMCn5YgTs3VbXFJMUPQ1+wtj/qjELlflMOOdxBKQ=; fh=IMXbw0xx+6Q/2UEl1nyvDi1qBBGGml6rPCVUBtTSKyg=; b=KEKfJ2J44f5WN/yJ97uQ4ZFSbuf4oCNaz6r9U7Z6OGqcNYGl2tjXpkB0mGmJjS4wLO XYshdwxPdWlERd9OugMYwxi5qIm+QInaDxeHs7MkaWP/aYTsLAJMs6xIO8X42513E77t n1lSbH8x3p7tzwR0uD2ybgr/peIH8NoZKqRPrS283PEWTyfvvDUK4G4Wr0kN2jhGyKx8 ge51nd/R799TlYj38BsdIkYjIky7prx/ikYRh7zOyaNwA6bJzcN27zVpy/6UnJpwsQnM FnF8KBW77j64ty9azVJvJy6DzbQKgS96uxvbkcOrFDu6Nppxtu98HPsosabQAPPXFbs2 aPxw==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org" Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id 6a1803df08f44-6dd182533f4si228080706d6.369.2024.12.28.04.11.51 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Sat, 28 Dec 2024 04:11:51 -0800 (PST) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org" Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tRVeq-0007XO-BB; Sat, 28 Dec 2024 07:11:04 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tRVeG-0007TU-HY; Sat, 28 Dec 2024 07:10:30 -0500 Received: from isrv.corpit.ru ([86.62.121.231]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tRVeC-0001oE-If; Sat, 28 Dec 2024 07:10:26 -0500 Received: from localhost.tls.msk.ru (mjt.wg.tls.msk.ru [192.168.177.130]) by isrv.corpit.ru (Postfix) with ESMTP id EB194CC84E; Sat, 28 Dec 2024 15:09:39 +0300 (MSK) Received: by localhost.tls.msk.ru (Postfix, from userid 1000) id 520564616A; Sat, 28 Dec 2024 14:54:46 +0300 (MSK) From: Michael Tokarev To: qemu-devel@nongnu.org Cc: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= , qemu-trivial@nongnu.org, Michael Tokarev Subject: [PULL 07/11] docs: Replace 'since' -> 'removed in' in removed-features.rst Date: Sat, 28 Dec 2024 14:54:42 +0300 Message-Id: <20241228115446.2478706-8-mjt@tls.msk.ru> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20241228115446.2478706-1-mjt@tls.msk.ru> References: <20241228115446.2478706-1-mjt@tls.msk.ru> MIME-Version: 1.0 Received-SPF: pass client-ip=86.62.121.231; envelope-from=mjt@tls.msk.ru; helo=isrv.corpit.ru X-Spam_score_int: -68 X-Spam_score: -6.9 X-Spam_bar: ------ X-Spam_report: (-6.9 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_HI=-5, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: qemu-devel-bounces+patch=linaro.org@nongnu.org From: Philippe Mathieu-Daudé Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Alex Bennée Reviewed-by: Michael Tokarev Signed-off-by: Michael Tokarev --- docs/about/removed-features.rst | 20 ++++++++++---------- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/docs/about/removed-features.rst b/docs/about/removed-features.rst index e3a87f3f55..cb1388049a 100644 --- a/docs/about/removed-features.rst +++ b/docs/about/removed-features.rst @@ -403,13 +403,13 @@ Sound card devices should be created using ``-device`` or ``-audio``. The exception is ``pcspk`` which can be activated using ``-machine pcspk-audiodev=``. -``-watchdog`` (since 7.2) -''''''''''''''''''''''''' +``-watchdog`` (removed in 7.2) +'''''''''''''''''''''''''''''' Use ``-device`` instead. -Hexadecimal sizes with scaling multipliers (since 8.0) -'''''''''''''''''''''''''''''''''''''''''''''''''''''' +Hexadecimal sizes with scaling multipliers (removed in 8.0) +''''''''''''''''''''''''''''''''''''''''''''''''''''''''''' Input parameters that take a size value should only use a size suffix (such as 'k' or 'M') when the base is written in decimal, and not when @@ -510,15 +510,15 @@ than zero. Removed along with the ``compression`` migration capability. -``-device virtio-blk,scsi=on|off`` (since 9.1) -'''''''''''''''''''''''''''''''''''''''''''''' +``-device virtio-blk,scsi=on|off`` (removed in 9.1) +''''''''''''''''''''''''''''''''''''''''''''''''''' The virtio-blk SCSI passthrough feature is a legacy VIRTIO feature. VIRTIO 1.0 and later do not support it because the virtio-scsi device was introduced for full SCSI support. Use virtio-scsi instead when SCSI passthrough is required. -``-fsdev proxy`` and ``-virtfs proxy`` (since 9.2) -'''''''''''''''''''''''''''''''''''''''''''''''''' +``-fsdev proxy`` and ``-virtfs proxy`` (removed in 9.2) +''''''''''''''''''''''''''''''''''''''''''''''''''''''' The 9p ``proxy`` filesystem backend driver was originally developed to enhance security by dispatching low level filesystem operations from 9p @@ -532,8 +532,8 @@ security model option, or switch to ``virtiofs``. The virtiofs daemon ``virtiofsd`` uses vhost to eliminate the high latency costs of the 9p ``proxy`` backend. -``-portrait`` and ``-rotate`` (since 9.2) -''''''''''''''''''''''''''''''''''''''''' +``-portrait`` and ``-rotate`` (removed in 9.2) +'''''''''''''''''''''''''''''''''''''''''''''' The ``-portrait`` and ``-rotate`` options were documented as only working with the PXA LCD device, and all the machine types using