From patchwork Wed Dec 18 16:36:46 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnd Bergmann X-Patchwork-Id: 182011 Delivered-To: patch@linaro.org Received: by 2002:a92:3001:0:0:0:0:0 with SMTP id x1csp888081ile; Wed, 18 Dec 2019 08:37:11 -0800 (PST) X-Google-Smtp-Source: APXvYqxQ4txr/eQ8ZJ+jaxGerqsCQG0YnzGaMGaYxcmqIpiHlZwlq+7+Zmp6lYjqrS064rtEcZnO X-Received: by 2002:a05:6830:1db3:: with SMTP id z19mr3701980oti.152.1576687031589; Wed, 18 Dec 2019 08:37:11 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1576687031; cv=none; d=google.com; s=arc-20160816; b=Dazp8dNc/kRHY2JfYgQLrWwBp1AxwQIu0hS6yKUpOGNrVNph3mErh4cJsgQUXEV1X7 3k+BkVJBOTXSUwnnWYIrA8S8vcKL9H66jwUPftTFIKJ4ydsyExqN3R8y50Mwt0mThoJr 5iG8cs/5hbTuPyinup1gZC+5IaqpvQ0KdRUFmI2lVVnVtNc9uDv9bgd8imoE8hFxVxwY 5KjqB5VM7Ke5wiFFD0Z6lN3IDKw1DRCKQhd/ENbY1/+2YLtW4jAet3Ww56rf8JamuadC b5CSaS/8ty5oCdVxQnkQ0l5Se7ii59DGdn/W4AqxnnXoDzJEQ9pnPNm3lYyhMCLA2JlZ h0Tg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=lZU9sZvN6MzTM2AiKnU8F91woq/zkBHyP2osuaaZlMc=; b=L7Phrj85swHicZOvehRhyoVLqH1Idw83RtxWl7YBFB5D0zYdrpCwxzm1lWQ94fx8Zd JWsLNn7dezSfQOqBo7nMFsOTfuD2+1PZs5+NNeDjURR6BrS93dEjCMtgExmhaN4myJGr gSfUKDDoK856xVFjhOypyQst6kignv9CB7CBjCrHErbKf4ikk1kqWwC2d+MIVidlVg8h KVVV3CRONCubHPJQ6hzMVaE5AO92g0N0EfnxS8cjzSTff5kUq5pv/DaGTg+CtQFvIgFC xmSbwPwzHiYCPAHtNjBxYE5+N950eBszolxzNwLfUpnpxzMlBJxfadu/08e/nVdhlSr1 m/XQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-gpio-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-gpio-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 10si1557752oin.212.2019.12.18.08.37.11; Wed, 18 Dec 2019 08:37:11 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-gpio-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-gpio-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-gpio-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727225AbfLRQhL (ORCPT + 5 others); Wed, 18 Dec 2019 11:37:11 -0500 Received: from mout.kundenserver.de ([212.227.17.24]:44107 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727185AbfLRQhK (ORCPT ); Wed, 18 Dec 2019 11:37:10 -0500 Received: from threadripper.lan ([149.172.19.189]) by mrelayeu.kundenserver.de (mreue108 [212.227.15.145]) with ESMTPA (Nemesis) id 1MG9Xu-1iTL6J1RBk-00GY5i; Wed, 18 Dec 2019 17:37:03 +0100 From: Arnd Bergmann To: Charles Keepax , Richard Fitzgerald , Linus Walleij Cc: Arnd Bergmann , alsa-devel@alsa-project.org, patches@opensource.cirrus.com, linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] pinctrl: lochnagar: select GPIOLIB Date: Wed, 18 Dec 2019 17:36:46 +0100 Message-Id: <20191218163701.171914-1-arnd@arndb.de> X-Mailer: git-send-email 2.20.0 MIME-Version: 1.0 X-Provags-ID: V03:K1:qgb4fv+y9jcZDdpdrYUzzZ6dcoTpOmWPWNxttY6NQEFKg1bDoXQ B8bqBnvvxos5FtMQnxCDOFQ527z89fM6fqTggu4VOZPdwXxYEy9r3w37gzECjT+eMTqGnF6 ly9JMYeZKcJe3EuopMcDg8AL0lA4eT/yhs+C/64xsg5ABByb1llXoz3Uc2UmzGq6ONJoy1g 2REgf8iAJKqKqxht1sJYg== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1; V03:K0:R7XF/1zRMos=:rp3V/WKf77fEMd73eFH0AC XfE2lkTKfYE6GtWPmzrYqXady4wg1PyKRAzgDKWZ+CA7kxJfOpadlZEtW9HC0hXifbbvMxhlo FtoXE7p2C+rWifRMsZXInr6rGUuBikVCCZ/CW2UETfN+C7MYdQNwDVyyvngfeBcCJ4cUG88NA kiyyMvEvtHt+4ygR4JtIS+yfqMiwmOY5ZB0npBnlXMYHsl02BbpcyeAPbK8DOFs+lTviqgMAh UIvMh4BINzOYUeTL6KlCeFGBrxRqrfGKHZl5gvIReuITkcnCMEfwgSEQ4yXE05kQopQsvzdma ImHi5E7Jhae12wCiWvk1qoQkZF/yqssco3orf/ancxLSwnUpRY4ULKkguqBj497u1WWjjQ4c9 YF63nQRZ5abYyHbNdTJKZCGckwfJclo1WW7zIPa4L3Juz/LgjkqhzXVjNyP3m5eBhLlhdixhl 7d9S6QTHnJW8iW+GNYkACv5GoV2RLjORwRv6Q96vtJ7kT8FwkRvhn4jwvHmI5p8nXlFoIDA2+ WnwqOtgjmyEkDsNZBH/ZdPy1TTtVBJuB5xOwUHzHkzAA+SbBqMcsgmj979dYVSS4oHvmEE+tz Os0lKHQ3ejWk2A6v4KTFKjyxtLvW7l5y3v2Smc9adP6kqYzmOsf+oOQ9Vm5KLDP6zfIIZUR2j xx9aAE4XwAPBfvkNfn7q4gYRBxqj89Emcgr1I2c9VvP5CInn7T7Qi/s78hjLPrcSNti1Xd4nt 8ZDNyamZZprFN8sHMIZo/tBD+SozGu1kGrg9O2LM1v3OpR8Hg2hx1utXYSKWZn8mFRMhABuvS Hl42gTjKfBvHrpWXhGPbfVEet4eapQAgdBDFtHT3aB/EBWANHtmm5/QrIq6BoaYBj2H9O/Y/b q+zRAyjuqTC7A1AQglAg== Sender: linux-gpio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org In a rare randconfig build I came across one configuration that does not enable CONFIG_GPIOLIB, which is needed by lochnagar: ERROR: "devm_gpiochip_add_data" [drivers/pinctrl/cirrus/pinctrl-lochnagar.ko] undefined! ERROR: "gpiochip_generic_free" [drivers/pinctrl/cirrus/pinctrl-lochnagar.ko] undefined! ERROR: "gpiochip_generic_request" [drivers/pinctrl/cirrus/pinctrl-lochnagar.ko] undefined! ERROR: "gpiochip_get_data" [drivers/pinctrl/cirrus/pinctrl-lochnagar.ko] undefined! Add another 'select' like all other pinctrl drivers have. Fixes: 0548448b719a ("pinctrl: lochnagar: Add support for the Cirrus Logic Lochnagar") Signed-off-by: Arnd Bergmann --- I wonder if GPIOLIB should just become mandatory when enabling the pinctrl subsystem, or if there are still good reasons for leaving it disabled on any machine that uses CONFIG_PINCTRL. --- drivers/pinctrl/cirrus/Kconfig | 1 + 1 file changed, 1 insertion(+) -- 2.20.0 Acked-by: Charles Keepax diff --git a/drivers/pinctrl/cirrus/Kconfig b/drivers/pinctrl/cirrus/Kconfig index f1806fd781a0..530426a74f75 100644 --- a/drivers/pinctrl/cirrus/Kconfig +++ b/drivers/pinctrl/cirrus/Kconfig @@ -2,6 +2,7 @@ config PINCTRL_LOCHNAGAR tristate "Cirrus Logic Lochnagar pinctrl driver" depends on MFD_LOCHNAGAR + select GPIOLIB select PINMUX select PINCONF select GENERIC_PINCONF