From patchwork Mon Nov 25 11:21:35 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?b?KO2VmeyDnSkg7J6l7J246recICjsu7Ttk6jthLDqs7XtlZnqs7wp?= X-Patchwork-Id: 845536 Received: from PUWP216CU001.outbound.protection.outlook.com (mail-koreasouthazon11020139.outbound.protection.outlook.com [52.101.156.139]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9BAAC198A19; Mon, 25 Nov 2024 11:21:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.156.139 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1732533701; cv=fail; b=COPiiFuExCIyyxNHTVGXO38+Wg49F4SBnY5JDCXuku0VICo1xZr0S1wemmRUgCdeguNbG6Z7K88KeXTfQyOp7BDFHzCszxYCVFEET6QTfWkJzaQSZ5MDvlhBOhZ1Gz050B1PkAnL4hVj/7Q8gv6RKVxr+IX81Y+7+hZAzjKEdII= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1732533701; c=relaxed/simple; bh=TQzQzqPoVX3t86N+eoYcAWGHm+nyrgNnBgR7RJdZ2iw=; h=From:To:CC:Subject:Date:Message-ID:References:In-Reply-To: Content-Type:MIME-Version; b=ugARSSdi/o6lq+WkTjG6l8QsdbcwDtB2b7mBhqU8YuUeZhSO5YCXFPknNOB6Spsw2qQ8lxKS+pIhOj5JQEql34/tfqINTjfTNff2nAhYne+eUMP8hf6QAccDK3Uhzk0ngwoxZlTz0bttQVGZ27GfV5cjAC6m4xTNWutRzRFPVAA= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=unist.ac.kr; spf=pass smtp.mailfrom=unist.ac.kr; dkim=pass (1024-bit key) header.d=unist.ac.kr header.i=@unist.ac.kr header.b=PZNXFSVT; arc=fail smtp.client-ip=52.101.156.139 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=unist.ac.kr Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=unist.ac.kr Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=unist.ac.kr header.i=@unist.ac.kr header.b="PZNXFSVT" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=wkuOxdzKLblxQiMjxM0qDio9CD8gVc76W/yOF7Fk8DJG/72iQLKKrcegyZnRQ7Vma15TTDKeTm4+wShyXC2z/Ehr8tMXFCHnv9XeNTrf00yqAg4oPNcl3JVnA/8Fb0YAYE01v+mNh9961GWdT69W68kCWmMgKPEkV1JkmR9Oylp46yaseNOFOYN0wTeBcf/2NUzP1+tynufTLv8YCU5FlbeuGF99V8qWMI8ocjnQGEAP0nzqoUs8IvKl/xNq2uQM6CqXPJ4tuw0h7Q4MTXGeCTqdNrnU5GPelvgI6Of34x33mC9n+6mlMUiCuKKvs1v8cvA+cYk7cgHpEbFO+/qNRg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=TQzQzqPoVX3t86N+eoYcAWGHm+nyrgNnBgR7RJdZ2iw=; b=tviooZuoXiRzxvp5m0NQfsvXQCuqiThRyah2Ls0N6TFOw0fMcEuf9UOo4B18AWdnIx3twT+NJJ8A+a9/VuS6f5TZEjIBe/Aji+saloE2WQ0gEyfFu7krM9jrt7X1ABrDkJHhKCsMY5f2gzQ82Ya8ZDMgsKZLFl4A38dZVmzpN56fr517fxycgD2hPAqhJxLa/qpK6r1EO9rv/dxu2/Ua4N2WTmdezTyi5lUtxXjRvVlI5bQ/HheFJKStLNBXLJRNHUCFuTv7myWtQ4RZ5HU8IQJNXw35ig0rTTs2h31/BKyrWBV7BzrzIKqz6sGBD79OfQaP/tcthDR741o6vyTd2A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=unist.ac.kr; dmarc=pass action=none header.from=unist.ac.kr; dkim=pass header.d=unist.ac.kr; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=unist.ac.kr; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=TQzQzqPoVX3t86N+eoYcAWGHm+nyrgNnBgR7RJdZ2iw=; b=PZNXFSVTpHwawdnW+syU8a5LRobn/l66bGC90YmKYOKHNthbIFzSP1Zm2VUanHk1/q2ys6BlV1xYy3eyWLtKn6Iq6RR1y5mpDSI86NeDIb3lEOC2yUSYpWWkpSwBE5K4fXaQjtfFRcPxBXZ5y9MR6GQrCnKy8C3GyUSsR9IQioE= Received: from SE1P216MB2287.KORP216.PROD.OUTLOOK.COM (2603:1096:101:15d::5) by SE1P216MB1962.KORP216.PROD.OUTLOOK.COM (2603:1096:101:f6::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8182.20; Mon, 25 Nov 2024 11:21:35 +0000 Received: from SE1P216MB2287.KORP216.PROD.OUTLOOK.COM ([fe80::abfa:51df:7a24:2f06]) by SE1P216MB2287.KORP216.PROD.OUTLOOK.COM ([fe80::abfa:51df:7a24:2f06%6]) with mapi id 15.20.8182.019; Mon, 25 Nov 2024 11:21:35 +0000 From: =?utf-8?b?KO2VmeyDnSkg7J6l7J246recICjsu7Ttk6jthLDqs7XtlZnqs7wp?= To: "James.Bottomley@HansenPartnership.com" , "martin.petersen@oracle.com" CC: "njavali@marvell.com" , "GR-QLogic-Storage-Upstream@marvell.com" , "linux-scsi@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: [PATCH RESEND] qla2xxx: Fix START_SP_W_RETRIES returns positive EINVAL Thread-Topic: [PATCH RESEND] qla2xxx: Fix START_SP_W_RETRIES returns positive EINVAL Thread-Index: AQHbPyv85Cfgq/gmnkyVNLOsUVYuDrLH2dMJ Date: Mon, 25 Nov 2024 11:21:35 +0000 Message-ID: References: In-Reply-To: Accept-Language: ko-KR, en-US Content-Language: ko-KR X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=unist.ac.kr; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: SE1P216MB2287:EE_|SE1P216MB1962:EE_ x-ms-office365-filtering-correlation-id: b9ce9248-93b8-4412-b3bb-08dd0d435263 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; ARA:13230040|376014|1800799024|366016|41320700013|38070700018; x-microsoft-antispam-message-info: =?utf-8?q?28DlcZG1BGU1Mvt4hRBNb7+g0Awa2Ft?= =?utf-8?q?Q92WKgAGmOKrRIIlOfCBFY3sFS7qB2xz3tBV34dLhswIz/BT7d0Lc+2cXCBd+STK+?= =?utf-8?q?mkefkeMgew/SwYPKFYAao1k4UagWW4SSNouNICw5fz0FWLtjaw1VKgYp6ZJLMF6d0?= =?utf-8?q?7Bat4bxXAXrw9hZakrZ+N2fry0sRww5tYDkOCBAb2MlJxAEU4mGvZyM7/wpSjs9cA?= =?utf-8?q?Jbm2D+fUwEeH09fFBx59GNDsXsct89l/Qrs27kUW0wWo6kx3Uo+Gf6j/8rQSUtSH/?= =?utf-8?q?6qhQtYOrmQglN7Nz2XkCSUI3T61iBgeSjumWuwHIFDvaiz+1Ti1l4UuJER6c1VkkZ?= =?utf-8?q?bABEIHE6G0DVIX15P68GKWqHJ7aOLW5yNQmkxMjpHPhQFXD5azsvhXIskJKbRF4zx?= =?utf-8?q?lZhD9fudQicJ6JexDogMI6jqUU3iKPNxbhVYby6i8jzGmptt529FfAjDnNs29PIGH?= =?utf-8?q?IBvry9Zy3y2xvT1wTZM289jb3oQFR2/PO4vrTRDiHW9y1jem8Kmc60Mu5PKvywWPV?= =?utf-8?q?sNr8OMj318bctOLUTjqfLANg39EozntuI8opyVB3C/LVQpl98rhxsjM8YRCrEggD9?= =?utf-8?q?7CDLOKBSCfXkoZ5CgMubCtVldPmmmog7WTW80U4HmteSEP27yxQYtKWqvmXp8l19g?= =?utf-8?q?eKMu7CV5kJPjbaBzCuHm8ab8Fg7GGaoYsB7xrpU3AWR5u8GiEPwDGzQWsBXi8/fsH?= =?utf-8?q?X/0u3gNBUXS1N4a2PUayzOpJYvgRCDMth+zcf+cONTCp3BQgQr8T6eXGkdUdbmpmV?= =?utf-8?q?E4CXs0NkjmMse4uZTNHYEgHXa22V+keCTz4uA/oZymzbwpX8+Im6QtYpfG8LI881p?= =?utf-8?q?euqctonp8oHlh7kideRnPVNbTjM1Cqt1SRKxS9BvNl3FbnMlA/0dij1T7zfc6/WrM?= =?utf-8?q?LkYVAa+N80H3wf0im9iZ0Eps6dl1HD6JCzQnrcA3Kkg7VV7G6ypRywsgqT8JCrVgv?= =?utf-8?q?9sMMrysbXaGZCVE36sYNOWcwJdeeSz67P7itOLBfxPEfLTPbQB//6x45x5xp/QYbN?= =?utf-8?q?GLsPMsip1yq+F1ezYEDzF30dSau4E0JlZWu2pJ8xE6zvO7evGDomLRN7MX/HM+muz?= =?utf-8?q?UydIiaxKY3bgwz4qK9dm638vMA9tbH6YeBvPTzWMswjuHcslSRy4zIkL5ZZoDcCXZ?= =?utf-8?q?qQ9KBT+LHYezKIYvbghIONU/KX6PyX966YLwxKGwvoypRhxJj9wX41wiuhjS7csyE?= =?utf-8?q?YmTL0ffHJCObyNtLzD502K1ypfD6I+epF1WMl09Q62+kgw/o6bTAO3h6GFePTDoBf?= =?utf-8?q?PLFLqF8rxSE0cYSBt2/IVPgmkUxcbwkeG8SD3+IsJWOHG1f2DFrHF73Be4oEjuIUY?= =?utf-8?q?oYI2ZNF/7ucD+IlCe49MUU8EK05L9OlkcA=3D=3D?= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:ko; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SE1P216MB2287.KORP216.PROD.OUTLOOK.COM; PTR:; CAT:NONE; SFS:(13230040)(376014)(1800799024)(366016)(41320700013)(38070700018); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?q?cyWYMt3/YHf/BB2v7HANLQkDMMf8?= =?utf-8?q?5uEr157uez27UFcutUlaUjbW6IUSwhCMrG342H8JxL6hQWnlsWB1mX6X9XRLeejqF?= =?utf-8?q?O/XOS8TXJ3wr6RByHs0pZJ6y6EcI0dURsEtm3DLSACA3QkmWfyapvK6YAWKYtcTmI?= =?utf-8?q?ilC4EdOgPQKGnoe3PITTB1k2MacwaYZ4V41Y1x5mUTn0cePlCPoWvwFUUnIuXBXyL?= =?utf-8?q?jWCB4Q/q0WvOvSn/UlCDibOzJWwhq7H342mGsOLzKgBb9Z+iDKDWoXj/wxkxGyA1t?= =?utf-8?q?qptcEOl4J04goJ37vJLGhdEO/y+iUx52WpQrWMJ/dExTgbFsO0m4KbwiMVu1/tseN?= =?utf-8?q?EP/m8XMRxswrf1zxzwEkn4/S2fkqHIalPNylI5BhMQOAmfwRa46BgONJ7vN7Iqxrr?= =?utf-8?q?/KAaR6et4W+N3NfeK+wDEHkklpXpeXPm/CZO+IhO/cDnaTJqnopg2BqvN1QVYboXz?= =?utf-8?q?0kaWL+Q5jbt5H36XyfqflwpkaVA+JAJk1zCnGi65KDoUpU/59PJnDYJQIttKE4tyn?= =?utf-8?q?aVuLYVmj+vbInuoc2qHajojMdcZFEmh3p13kKXBw29UxuMEZSenE00ZkT9EuOrvb+?= =?utf-8?q?J7qa8asFx2nUA6KDpa9t9eDPF+XqF1KvgmB9dejbUOPSB0biMBPRz8gSMEufG57Do?= =?utf-8?q?p7UWVCQQ5E0aZxaAvqfkdwc/STc6MNwhSapNNh1TQh3axJrGGnUc17zPjeuaYTfeT?= =?utf-8?q?3+VIbG8ZWkQob3nk8LPocvte4nIi6RUYZcb3g9gT3rS31I1WSPaH9d7S3Tpsj1fX7?= =?utf-8?q?kAGGhBHi11Ha4FN/f6CxsLZFkFakbmHbpr4E0i6zWDfkrP8cN9LCi0ttC/Jta2mKe?= =?utf-8?q?bdGwvOU4tRkv/Il4dWiVnBTtpGilYTT3C6iJS3hPgJaRzFMxT5K70IB/KmM5cSkTw?= =?utf-8?q?6dW9bHcFT8edzXPXJdRXy2UvJj+Dp1u9HwuTEYiXZ0nBZ866L8omF4npTp96r29vK?= =?utf-8?q?1kp8AGLF5cKDkZWIIUh6tBayJHISpINplbE8qQgH0JuffXJ1G7pFBiqvPabgP70u2?= =?utf-8?q?Ingdi9f8Av9039Nlw4XqPNyB+5EiEOgkBbllQ02ov3UstbULFdb/iBympd3Es+hzI?= =?utf-8?q?uFMkBBL5+pLlOaBN+VxOqc0pw4xN2PIxbabekDiDc27UvacoHeGO7W79izVER+Sqb?= =?utf-8?q?9XS+i1S/jNm7Dg+AKue3jGvZZttAqJb1kDTdM/XDPd3Xv6QnQgHxLBtl7xStTChZN?= =?utf-8?q?e9pM6FbKyTEMiEvUQx8FUFdNkybslqlYr4v7rmPaF6brMFJA7IjdrVWTVR0juldxA?= =?utf-8?q?vjeOtIwFxVBvaO2CStIywp+vnVMXDjzmY/X+vE38PfjbQ0Ofg1kdDiahQhB9jXGZd?= =?utf-8?q?4bIRnjFoR2ByaXhhmEfhrBuN4v84Id/ys2yIz5d2CYGImOWwo1aSgCj61Y/DF77Vl?= =?utf-8?q?hVFyA+EOiyWQc3KxQ0YRmJ984xKS+mP0FSfNy7FLOkv8oNKYhqKB6v87lYEgsEQ9F?= =?utf-8?q?rivuwvw5sdhycjIuL3OYd6xLdj6ZITFpi9ZSMZXVo6KDz0eEt2q7DN7pZ9BHMsr8T?= =?utf-8?q?osZivcC0BbST?= Precedence: bulk X-Mailing-List: linux-scsi@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-OriginatorOrg: unist.ac.kr X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SE1P216MB2287.KORP216.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-Network-Message-Id: b9ce9248-93b8-4412-b3bb-08dd0d435263 X-MS-Exchange-CrossTenant-originalarrivaltime: 25 Nov 2024 11:21:35.2323 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: e8715ec0-6179-432a-a864-54ea4008adc2 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: ex1ZPYYTPaNd04Oz8wfOjd+RsHOgXM5V8j3FDU6z6mPbpRQcHYKZ4RqnlK0fOfileCfoyyLpC0rcAnlMMNWdbw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SE1P216MB1962 >From 6e78ff23b9f11f6896c09299e0a38b4443420eed Mon Sep 17 00:00:00 2001 From: Ingyu Jang Date: Mon, 25 Nov 2024 20:20:00 +0900 Subject: [PATCH RESEND] qla2xxx: Fix START_SP_W_RETRIES returns positive EINVAL The START_SP_W_RETRIES macro previously returned a positive EINVAL code when chip generation or login generation mismatches were detected, potentially leading to improper error handling in caller functions and creating security risks if the error state was misinterpreted. This patch updates the macro to return -EINVAL, aligning with kernel error handling conventions and mitigating unintended behavior in error handling. Signed-off-by: Ingyu Jang ---  drivers/scsi/qla2xxx/qla_init.c | 2 +-  1 file changed, 1 insertion(+), 1 deletion(-) -- 2.34.1 diff --git a/drivers/scsi/qla2xxx/qla_init.c b/drivers/scsi/qla2xxx/qla_init.c index 31fc6a0eca3e..089d560e4114 100644 --- a/drivers/scsi/qla2xxx/qla_init.c +++ b/drivers/scsi/qla2xxx/qla_init.c @@ -2059,7 +2059,7 @@ static void qla_marker_sp_done(srb_t *sp, int res)          int cnt = 5; \          do { \                  if (_chip_gen != sp->vha->hw->chip_reset || _login_gen != sp->fcport->login_gen) {\ -                       _rval = EINVAL; \ +                       _rval = -EINVAL; \                          break; \                  } \                  _rval = qla2x00_start_sp(_sp); \