From patchwork Wed Dec 11 12:56:09 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnd Bergmann X-Patchwork-Id: 181208 Delivered-To: patch@linaro.org Received: by 2002:a92:3001:0:0:0:0:0 with SMTP id x1csp493147ile; Wed, 11 Dec 2019 04:57:16 -0800 (PST) X-Google-Smtp-Source: APXvYqx0v6heS7ZQ3YISctupGGcmOneU1g6BGcskLzSrzHfDUu0JR60jgCHPwi0QqF0NkiZbTafb X-Received: by 2002:a9d:7a8f:: with SMTP id l15mr2018555otn.109.1576069036368; Wed, 11 Dec 2019 04:57:16 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1576069036; cv=none; d=google.com; s=arc-20160816; b=vGVc3A/n+iu88urZauI7EYcqXByrgVB7u/dgJMVxZqHixHJ92yrHKMCgTxRt/kz1sz e463I1RIP0D/Us6jcMttQxPcKbVH01uvHJ/trsRfVWbHtxSA2uZ/CQH9cmAYztzA010g kR1e6teEHNKApe2ErdYLU58B8RjRQYbaUTEypsbVKyOMCKZ6Fpq/7bhoZvYx8S6qUg9F wl4EZ9I0j/+QU/ci1N84e23ZYpck/1xR5jTeXNF0lQUIX6qDlVyvee3I/iWm3DxAVgNr SlAiy7PVG8UdBD2sRn6H8QcfSSTyMAo7v74Fv6PF1sJkbA2CGRWJILjJIIEbRNfNam0Z 4cJA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=CLThGYBqCItwxfHQeF6z9XFo/L6Z+05LV9loUOvAWJk=; b=mUaAjMwCeNbF+NSRKn27pFC/9jKp2ns6GR6mSwUX4EhUMi0JJvLPLpGhpTfrJP2B74 0y+lR3E8ORCUwSPiyvcd68p61Hn+2v6ZTqHjzMs2ARtMbSs+eUWP4pPdPnw9JZE1KAuc DEiCj0twuIwKuuDs9sG2gRsjJy6fic8pK5gBoGbxHTonLwuukUdjdzUJ62SjLqNPbmyM OlXwpH5Ji+5kejzKQr4onB+8uNNQEOD/pvxLg86gyl6RpnT6GNHHU5YKglYIGIUkrjJY ZCbHRCCkrePz95Z7yvO/H26mx127CyPfE6OxhhLN9tJyeS9nIRI0BLNbrciKsnTNsXRA qbKw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id a8si1103029otp.35.2019.12.11.04.57.16; Wed, 11 Dec 2019 04:57:16 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729363AbfLKM5P (ORCPT + 27 others); Wed, 11 Dec 2019 07:57:15 -0500 Received: from mout.kundenserver.de ([212.227.126.131]:46431 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727402AbfLKM5O (ORCPT ); Wed, 11 Dec 2019 07:57:14 -0500 Received: from threadripper.lan ([149.172.19.189]) by mrelayeu.kundenserver.de (mreue010 [212.227.15.129]) with ESMTPA (Nemesis) id 1MoOIi-1hugFE2B6e-00ol0h; Wed, 11 Dec 2019 13:56:48 +0100 From: Arnd Bergmann To: "David S. Miller" Cc: Arnd Bergmann , Ilias Apalodimas , Murali Karicheri , Grygorii Strashko , Alexei Starovoitov , Daniel Borkmann , Jakub Kicinski , Jesper Dangaard Brouer , John Fastabend , Andrew Lunn , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, bpf@vger.kernel.org Subject: [PATCH 1/2] net: ethernet: ti: select PAGE_POOL for switchdev driver Date: Wed, 11 Dec 2019 13:56:09 +0100 Message-Id: <20191211125643.1987157-1-arnd@arndb.de> X-Mailer: git-send-email 2.20.0 MIME-Version: 1.0 X-Provags-ID: V03:K1:6xobw418PyXkV3CYCKrKrkqYW/pQBVgYt++7QWDd1Gfizh2agwO DVm/zQK2J9mYF45nZz9r+hJW5WNEs79PYMDjvnpCSaz+juIGroWBy+kCKJnkSjiwJe11xtJ k/+cxrj1Koa2WOT96iYKn1gdzuSDKeOI8MdVKGY93tjVmy1yqI1rjd3nnnrS9tPiOVyoTsC /UcNApcongbQFK1MvZ1Dg== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1; V03:K0:o0oCe+1KPDY=:3I5WOPzsVQn/dZchhDjCqQ 362M8WJcGI1zUSC5T1bN8rol0rStp2wLcrxKXY6cluhRZo5wN8Jvxk/QLnjxYIRVTXT2MpWbB EWbwwJcZWosRBqy0qiRQMiTBFxrugsUEJqMDUyVUUIv6bELxjsLUpQP38V/bEXfuZojr/e4Iz fAc5mEgni8MZvt3ZpoLAcf/oqzg4kSt4ozZCtHCqHaGwj5pNcwkjslkFFJ0sGmdOxH7JEN97b aRxht6GJ4K5+oIaIgxo4aAIgD2UCZQt++998LUrdGAAatwt/dOaMbVkp/Z+aVkqk/pHPHwDEj QhPae0wjGTMc3aDNNftsZlRkgIxIk8vvU0qjXxKt4NBgUpul0TNMgSlTYAd3EOCMH5F5orh/d 47rul2ONxiLGR2eLHWxAyf/w6nP5CqBNuhYAftdpeBO8n8a2Iu1GDOJZTjMZmMxIt5G9CfdTb maj1cjiINatkodirADoJuRBBOWX8PXWMXTkkSET2JMv8mpcR/0V2GsjIRdLYHw4rPMEEoYuDP bkhtwEJMPj0JJfR6D/8UtHelmmEtbDaKcj+5m+I+k1zWE1Dom4Vih/NH4p4kYPBG2HyHEIDTF Jl5LLAYu1/lmyvi98ARkZ5znucnpkiSIlyTCQOi/jRs004JSUwSJli/V9/tZgsh/freQ2zvd8 ef0/tcmcni0MQ0ich7AoLXGPcaP8m7jyCqc4XjmMA1xe3jrMQvyjTvVlp8rCCUmXAj91vkgkK H/DWKrdI8c9/HoHxzSRqoiNyK4wM3fh2VoWnYKVoVXAYPkHSgZc/sl/CEzHyBSZJjnNaFoHpj T/v3JsjU2qv8AfVVyBxCy0URjCrIguF4CeAodvrr90ebvLc5HAv9syu2r+E4dof+aqzWXB3XU gbVQZ0jxc2A8xn/jcMVw== Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The new driver misses a dependency: drivers/net/ethernet/ti/cpsw_new.o: In function `cpsw_rx_handler': cpsw_new.c:(.text+0x259c): undefined reference to `__page_pool_put_page' cpsw_new.c:(.text+0x25d0): undefined reference to `page_pool_alloc_pages' drivers/net/ethernet/ti/cpsw_priv.o: In function `cpsw_fill_rx_channels': cpsw_priv.c:(.text+0x22d8): undefined reference to `page_pool_alloc_pages' cpsw_priv.c:(.text+0x2420): undefined reference to `__page_pool_put_page' drivers/net/ethernet/ti/cpsw_priv.o: In function `cpsw_create_xdp_rxqs': cpsw_priv.c:(.text+0x2624): undefined reference to `page_pool_create' drivers/net/ethernet/ti/cpsw_priv.o: In function `cpsw_run_xdp': cpsw_priv.c:(.text+0x2dc8): undefined reference to `__page_pool_put_page' Other drivers use 'select' for PAGE_POOL, so do the same here. Fixes: ed3525eda4c4 ("net: ethernet: ti: introduce cpsw switchdev based driver part 1 - dual-emac") Signed-off-by: Arnd Bergmann --- drivers/net/ethernet/ti/Kconfig | 1 + 1 file changed, 1 insertion(+) -- 2.20.0 Acked-by: Ilias Apalodimas Acked-by: Jesper Dangaard Brouer Reviewed-by: Grygorii Strashko diff --git a/drivers/net/ethernet/ti/Kconfig b/drivers/net/ethernet/ti/Kconfig index a46f4189fde3..bf98e0fa7d8b 100644 --- a/drivers/net/ethernet/ti/Kconfig +++ b/drivers/net/ethernet/ti/Kconfig @@ -63,6 +63,7 @@ config TI_CPSW_SWITCHDEV tristate "TI CPSW Switch Support with switchdev" depends on ARCH_DAVINCI || ARCH_OMAP2PLUS || COMPILE_TEST depends on NET_SWITCHDEV + select PAGE_POOL select TI_DAVINCI_MDIO select MFD_SYSCON select REGMAP From patchwork Wed Dec 11 12:56:10 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnd Bergmann X-Patchwork-Id: 181209 Delivered-To: patch@linaro.org Received: by 2002:a92:3001:0:0:0:0:0 with SMTP id x1csp493326ile; Wed, 11 Dec 2019 04:57:28 -0800 (PST) X-Google-Smtp-Source: APXvYqz2/Yy7vhVe9nCem765GvdJqeM7XM0RLRe3QUUapMRF3cZJPUdWopX8P0WmMticyTo7I5p1 X-Received: by 2002:a05:6808:14d:: with SMTP id h13mr2775136oie.58.1576069047938; Wed, 11 Dec 2019 04:57:27 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1576069047; cv=none; d=google.com; s=arc-20160816; b=GryXu7Q52gDKzgDHNDktnjdedJ/AZP9rj9f7RtEfGqTL0kS+Zoq7gybs7Wjg4tjRo2 zLXpNLQ1iG0kQQ+sPQckq+KysvuauQKu0LxynQxLH9tGdQ4i6sWIeF2pdPU/DpvPwyKM MVRR/3qYbuCd7Prsi0NqVSprSAzkumlLg1ohX5Bu+p/AaxMNptZ2Bq9dgz180x8uN4FN efaDrplKpmVfpiOv5wadVIeX5cvKYc3QRUSnTjX33cR1vdB5Vbt8mS+dGOAZiIQ/3ZVi onV8X9nIoALZAKiAcWua4vL25qFAPinKit72uu+ZAliorD3YcVb9vfnKFMdAlNUhJ+e6 PSww== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=XmIFGL3ucm2oIQ/kvV8521gXryS4PzGS+ytV4IRadUM=; b=ip5Qb+Aty6wlTO4jEQBoqwu+oc0OeLsF0SCVpnn1Qbg4V0lvyZWfTByS4IMW0XSOiB 5tM0KMBWnsQQrwzLejF3/QOuj476pUZdxIlDP4xShppLJicT9074S2Rl2vMt2wgGJirV fXjf+amUvlgSIhICsDhIL0eIAcnaPRyF2rhuz8wiTzCFqeUfm0D3DmERHmzNEjP/env4 9CRyS91I0/dzNrK1b3puX9se1cQ42h72/XTYSKEpiOROw4V2Dsa6bxQva7GGUaQj0Y8E KTpYC9JmQMMjKX718lBH2xC3lld5gAsDZoIl7tK45Gv9dmltPrAxY4K8ZxiMTeyLithQ cOPQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id a8si1103029otp.35.2019.12.11.04.57.27; Wed, 11 Dec 2019 04:57:27 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729397AbfLKM50 (ORCPT + 27 others); Wed, 11 Dec 2019 07:57:26 -0500 Received: from mout.kundenserver.de ([212.227.126.134]:42119 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728128AbfLKM50 (ORCPT ); Wed, 11 Dec 2019 07:57:26 -0500 Received: from threadripper.lan ([149.172.19.189]) by mrelayeu.kundenserver.de (mreue010 [212.227.15.129]) with ESMTPA (Nemesis) id 1MatmF-1i8ibS36ZH-00cOoO; Wed, 11 Dec 2019 13:57:13 +0100 From: Arnd Bergmann To: "David S. Miller" Cc: Arnd Bergmann , Ilias Apalodimas , Murali Karicheri , Grygorii Strashko , Andrew Lunn , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 2/2] net: ethernet: ti: build cpsw-common for switchdev Date: Wed, 11 Dec 2019 13:56:10 +0100 Message-Id: <20191211125643.1987157-2-arnd@arndb.de> X-Mailer: git-send-email 2.20.0 In-Reply-To: <20191211125643.1987157-1-arnd@arndb.de> References: <20191211125643.1987157-1-arnd@arndb.de> MIME-Version: 1.0 X-Provags-ID: V03:K1:K6rsam58HmBZQzLvo9EBHtFu2MxaOTWeFk96Se6piIUDIb6cI0F /dI9Aep+YrNPLwpnbwhuOcewweRyHskJN33FJh+PjMYCurRpkrzac+njNH/TpTNGYKvmMMa LaN36M/SepcSpqQCim9xV7od6ph8Vppbjz8BRiCUu3hfCIIuizlXu94JDbVqnLJ+2ofXZeB 5srA/DbfW66duIwP47qpQ== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1; V03:K0:kqUrXnKg35M=:CaUAdEjNCKSXdpNTo0Eorq b6ldRdm5Tauq2CQV3kUOU2OLIInZe3UuZdSgZKEZTzyl5pvTzwVTIvYJToqXS9k+O6lKqSG3j OHBMNiQln4vY02omU0+rAhYHK/hqg1Cvex0uofOhbf4xryiRcanTLOOPhqQwJvRJFJtEOCHl9 E2BfqGeanhJwLlpdZIBIDTamgWWlWPInVJ/i3czwYnWbBZ0xBCdD2+qJ5lM0+8H0yfYYIFzmB hWxsJOlX59P0EevL6tR2oMuu50FE1ERBDoALc+xsr4DnnKlViRpsFJbn9fJOxoD2zS/NgStIZ GD07xbQZWFtl9wpbCltJ500d00FEdnAb72VY8gt0T+B05wRnYWPDpIhnLUhMoi3/mIGctaqwY NKSXsip/AEhMLCsDOXAmpyccgGSkrqjS9qviBjgk1gjp6ic3UInrrFRJuULvNq1+JrWXSwc93 I8kA7iypL2yrxiXGBrrLFkCwQOk5Qeu4poQuDy0SG0PL6tY2nyIG5h0O8W2cwV2Hz0X86IHNP zPChNae4ykswfrd5GbM7sLsBBmMh9EH5jXyoQzHyAgRZeuGwO4N9dhzUmpd+m2fvHVLWjSP7l DL/nYhKNWHZo2zFYw9nMfgBrqbGOI/j42hE6mZB4PaTJQKnC8zJA/FBVJlAPzielwWl/vHw8h yviFiD3E+OP024kmLaUlMWIQJl/TDQx/TMKtMdncDawnUUrPO1ZrMtSxu5w4r/1el16rZJn6e Pw+WZD2vIe/cyMBM15P3NMtLJ52SYhcFvw2RSwTXelh/lLBCPtZl2Unor67znXuOD/MwjJRkl yOGf1J2nQyF7e6RR8I1MNt//8hG7d/Cb69Nx4Ie5ceymS61b5IG0PhkATLNh02vxpdNVlhdGo H7HiYrXmWcJcZqEyIT9A== Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Without the common part of the driver, the new file fails to link: drivers/net/ethernet/ti/cpsw_new.o: In function `cpsw_probe': cpsw_new.c:(.text+0x312c): undefined reference to `ti_cm_get_macid' Use the same Makefile hack as before, and build cpsw-common.o for any driver that needs it. Fixes: ed3525eda4c4 ("net: ethernet: ti: introduce cpsw switchdev based driver part 1 - dual-emac") Signed-off-by: Arnd Bergmann --- drivers/net/ethernet/ti/Makefile | 1 + 1 file changed, 1 insertion(+) -- 2.20.0 Reviewed-by: Grygorii Strashko diff --git a/drivers/net/ethernet/ti/Makefile b/drivers/net/ethernet/ti/Makefile index d34df8e5cf94..ecf776ad8689 100644 --- a/drivers/net/ethernet/ti/Makefile +++ b/drivers/net/ethernet/ti/Makefile @@ -5,6 +5,7 @@ obj-$(CONFIG_TI_CPSW) += cpsw-common.o obj-$(CONFIG_TI_DAVINCI_EMAC) += cpsw-common.o +obj-$(CONFIG_TI_CPSW_SWITCHDEV) += cpsw-common.o obj-$(CONFIG_TLAN) += tlan.o obj-$(CONFIG_CPMAC) += cpmac.o