From patchwork Sat Nov 16 05:39:18 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Richard Henderson X-Patchwork-Id: 843821 Delivered-To: patch@linaro.org Received: by 2002:adf:9bcc:0:b0:382:184f:390f with SMTP id e12csp1212547wrc; Fri, 15 Nov 2024 21:40:14 -0800 (PST) X-Forwarded-Encrypted: i=2; AJvYcCXZZUOe9fHNOl9ohsv9KKQ4qTx5/Ab/leQha95KXBe49kwN0jUNYUXjmafKVKnWNJ9em3VtTQ==@linaro.org X-Google-Smtp-Source: AGHT+IFXA2J10wJQ7ZW9Dbbg9WRMtbmq6RIV2vwm2AKVK/Y2fI9sPjVZqk5Qr16SIG6D+a+kiVWz X-Received: by 2002:a05:6214:570a:b0:6d3:b936:60d1 with SMTP id 6a1803df08f44-6d3fb86421emr69389966d6.33.1731735614269; Fri, 15 Nov 2024 21:40:14 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1731735614; cv=none; d=google.com; s=arc-20240605; b=YYnnUUQFU+zor6qWpmhysSqSP4vTNUki4vp95iQI4gBkVEc67AyP65Ae1/DcTSfDz8 Gdh7rQEE7HDE1BMN5HZXQsHRaeZIrWv1wopUcodU49uiflHKwUCutiUBVTaGApx2I74Y 0D+vbT/HLPZ/mMMFQbFJDBGBpOVh/GJvxCkokkfSmxJC7AxTmo6yrNmrKu93kRJHu+RV Ujag48yLRKosRbav7K81H8OGrgU4KJ6NnUsminOmRmN6OIsXng9n8UDsd5ZKGUJ4MTqE K0FyU8pqY0WF2Jzyb1qQCvSbNbLh+zykKoWrFUSI33593cm5bbPqsizSV07GHvGkyRU0 /jSw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:message-id:date:subject:to:from:dkim-signature; bh=1lZiCiZf87Qs/9fUS6Yc1O4ZeocfPecUDBI/qiCE46c=; fh=PnYt+qEB9tAfMKoqBm2xjKOFpYyFFGPudh5cVIoieJM=; b=EGsb6UKk+l9KfNPfbVFPzFBJnS0DBIOI9Zgbw9UOou/b3TZII1+UkfvbPWLWheExW7 iIwZGROiMUE1Ek81m0NbK4T1WN90XbwaEEECr618d8rfPfWus3TiEvwYOyemfnhGvWb4 bsMJhUSZOQmev59a1q7Hw32bxgAT7uv7JCDBgScv1mbUcjNvagFwayZt1ChmZbfCAHMA QQlhmKwqKYUAi+ZC+0GeXCRyc6Y8wk5fIe/acLrkGFG8dIQze7aViF/We2+ur7LG9XKV 9iJG12/zXPsSyQMtsECbylncDU1hKLThoql6SvY0vMkqor01BnMa0nxY0SPtZtAgUwEI 3Ejg==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=tD7Ec0fc; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org; dara=neutral header.i=@linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id af79cd13be357-7b35ca613d1si526303485a.392.2024.11.15.21.40.14 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Fri, 15 Nov 2024 21:40:14 -0800 (PST) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=tD7Ec0fc; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org; dara=neutral header.i=@linaro.org Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tCBWn-00061i-H4; Sat, 16 Nov 2024 00:39:25 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tCBWl-00061Y-HQ for qemu-devel@nongnu.org; Sat, 16 Nov 2024 00:39:23 -0500 Received: from mail-pl1-x635.google.com ([2607:f8b0:4864:20::635]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1tCBWk-0004ey-4S for qemu-devel@nongnu.org; Sat, 16 Nov 2024 00:39:23 -0500 Received: by mail-pl1-x635.google.com with SMTP id d9443c01a7336-20cf6eea3c0so26119655ad.0 for ; Fri, 15 Nov 2024 21:39:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1731735560; x=1732340360; darn=nongnu.org; h=content-transfer-encoding:mime-version:message-id:date:subject:to :from:from:to:cc:subject:date:message-id:reply-to; bh=1lZiCiZf87Qs/9fUS6Yc1O4ZeocfPecUDBI/qiCE46c=; b=tD7Ec0fcRV8QF1O+1bsGm+lTv8VLIV1h9hAqjfIKEaK7ZbF1HIJw2fueqItmryx8v4 rLuuRAGRKpwj4yPA1ul3BspgzHmPIiaEOpo+NhwYbjs+c7Nh/OmFxUGTxSouw07oPuhl rIBLP22WB7xMz4mAj3EQZ49B2jp27guCfRCQPPZfCHU2yNf/2ioLDTnPeUd0I+GWocoz senwRmPTnSGhHYHn0i83sQ2Z1R3YEl01EDMSnzf/y/GABbWP0kS014bm9uiZF/TBWRZ7 3F4dvdxOu9UBAfE9pxsjNI0BtAl/bsrSmuQg/YKQSuYKITkn9IGbylba6WS443aluIT6 okIw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1731735560; x=1732340360; h=content-transfer-encoding:mime-version:message-id:date:subject:to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=1lZiCiZf87Qs/9fUS6Yc1O4ZeocfPecUDBI/qiCE46c=; b=kF9ZSgX9YgZ2FH6r2qYixxA1vj8VA472vA71XH7Q48wdOpRAj4X+ynLkl8HC9LbbZp hV0QjX8bqgkcEpyapJZ7z6047yYMRCzcxWvCFaVLvHGYiyXca3ZM7+2HGgR6jKUZEMKP Snv4QG1DU377qXrmz6qUrIKFzS4Y+7TdwoJ0qvFmDYfdC6UIvGsebSwExG9jbdWeaBrg rF1cCo4JvPtqoAj8rMa6Wx5OwI+SW1VwtmeXn7SE3DSusXHAh2fwj6wLX9sDuKOgfU6a pL6H5iU06kMZjWYOw9w6+kSOyOzXExMMN7DEib/XtY95jXRZanRWF1LrX2OAbitMZ3Dv eqkQ== X-Gm-Message-State: AOJu0Yy43keL35G3bjm/Snf8zWJT5k1cta4ktvzifVmVC4oes83FJHVF K6wOYyXEyNculgU5I1BVlR9RFEudr1cbQbNk114aXXV61ZD3UzU8Arn4Q47gJGtn0Tv0GYOLWvr O X-Received: by 2002:a17:903:285:b0:20c:c1bc:2253 with SMTP id d9443c01a7336-211d0d861c9mr87360235ad.32.1731735559871; Fri, 15 Nov 2024 21:39:19 -0800 (PST) Received: from stoup.. ([71.212.136.242]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-72477120aa5sm2280879b3a.79.2024.11.15.21.39.19 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 15 Nov 2024 21:39:19 -0800 (PST) From: Richard Henderson To: qemu-devel@nongnu.org Subject: [PATCH RISU] risugen/aarch64: SMULH and UMULH require ra == 31 Date: Fri, 15 Nov 2024 21:39:18 -0800 Message-ID: <20241116053918.420404-1-richard.henderson@linaro.org> X-Mailer: git-send-email 2.43.0 MIME-Version: 1.0 Received-SPF: pass client-ip=2607:f8b0:4864:20::635; envelope-from=richard.henderson@linaro.org; helo=mail-pl1-x635.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: qemu-devel-bounces+patch=linaro.org@nongnu.org Do not generate ra other than 31, as it is UNPREDICTABLE whether the instruction will trap as invalid. Signed-off-by: Richard Henderson --- aarch64.risu | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/aarch64.risu b/aarch64.risu index 8f08cd0..87d9c72 100644 --- a/aarch64.risu +++ b/aarch64.risu @@ -1887,7 +1887,7 @@ SMSUBL A64 1 00 11011 001 rm:5 1 ra:5 rn:5 rd:5 \ SMNEGL A64 1 00 11011 001 rm:5 1 11111 rn:5 rd:5 -SMULH A64 1 00 11011 010 rm:5 0 ra:5 rn:5 rd:5 +SMULH A64 1 00 11011 010 rm:5 0 11111 rn:5 rd:5 UMADDL A64 1 00 11011 101 rm:5 0 ra:5 rn:5 rd:5 \ !constraints { $ra != 31; } @@ -1899,7 +1899,7 @@ UMSUBL A64 1 00 11011 101 rm:5 1 ra:5 rn:5 rd:5 \ UMNEGL A64 1 00 11011 101 rm:5 1 11111 rn:5 rd:5 -UMULH A64 1 00 11011 110 rm:5 0 ra:5 rn:5 rd:5 +UMULH A64 1 00 11011 110 rm:5 0 11111 rn:5 rd:5 # - Logical (shifted register) # 31|30 29| 28 27 26 25 24 |23 22| 21| 20 16 15 10 9 5 4 0