From patchwork Wed Jun 21 22:06:06 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnd Bergmann X-Patchwork-Id: 106135 Delivered-To: patch@linaro.org Received: by 10.140.91.2 with SMTP id y2csp2154714qgd; Wed, 21 Jun 2017 15:07:42 -0700 (PDT) X-Received: by 10.13.196.134 with SMTP id g128mr27852197ywd.272.1498082862401; Wed, 21 Jun 2017 15:07:42 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1498082862; cv=none; d=google.com; s=arc-20160816; b=HHUpHzs/qqSS9XLbw2ZsIdO3kAy8eYAl4c3HMaqc06xFV8MajCruGurcjwY73ObL7d uCvZPy1UCCA4dmeTF/v77XxxSPKslCNC6qNua2PHKlsmXgY+jGmmX7hCyrvn4L86RVLw DGiyHEtVG4erxNJsEcCSW4uHjZUpmeB0fWjkyUSzN4ra1pG5fE/XyBtYZpWa5CtUa+Wq lnMSeiEyr+HQ+junKkoQfOa294Xh8+d/5P1dTDHZ2MhSPJYH1uKM19KBbtHCtq3/BdC0 wJ3otUYWETzn/yiTAtcDgh3fcEYWXtJvyKR2h8KsjC0aAcYU1bzpMG71MgGq/pyoseba F2hQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:date:subject:cc:to:from :arc-authentication-results; bh=QPfd9irFn7PU8jhi4B3tWjH/oa3rJb8YEmp8yCTHJU4=; b=PD3GOgnKf+MKelytjvlg296LE1LqjbCCCUb1lPqcA7n7l5AzrLwXl6JDpmcSK4aox3 yn2VPXLPw7GY2mcRJ57eWsrOYfXL8RSFjwCPIYafsa2q15HwTdGcKGaY8Uop3GYtKIJU sppC8S8CkGhqB9ugVUwzP8PGT8ZlxIz1JIQT8hiEhkm/8kX57GUn6W2n09NBd+4m7xnj +sxTsdQKSrcL1ye0eOFnw+7ckxrD6A8GuwD92LJ8VF8AHOfJ3xl5imfw5yvIbNaqgOlS KOKJzzSW2lF9lZepDSekYrWNdbzYITrJMm1CknaCetFf25x4WvRtVCI32vAchyHRY5FG 0N9g== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id n189si429874ywn.18.2017.06.21.15.07.42; Wed, 21 Jun 2017 15:07:42 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752227AbdFUWGv (ORCPT + 25 others); Wed, 21 Jun 2017 18:06:51 -0400 Received: from mout.kundenserver.de ([212.227.17.24]:58439 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751667AbdFUWGt (ORCPT ); Wed, 21 Jun 2017 18:06:49 -0400 Received: from wuerfel.lan ([5.56.224.194]) by mrelayeu.kundenserver.de (mreue103 [212.227.15.145]) with ESMTPA (Nemesis) id 0Lar3w-1e3PyC3UPw-00kNbF; Thu, 22 Jun 2017 00:06:32 +0200 From: Arnd Bergmann To: Florian Fainelli Cc: =?utf-8?b?UmFmYcWCIE1pxYJlY2tp?= , Kishon Vijay Abraham I , Andrew Lunn , netdev@vger.kernel.org, "David S . Miller" , Arnd Bergmann , linux-kernel@vger.kernel.org Subject: [RFC 1/2] net: phy: rework Kconfig settings for MDIO_BUS Date: Thu, 22 Jun 2017 00:06:06 +0200 Message-Id: <20170621220626.46691-1-arnd@arndb.de> X-Mailer: git-send-email 2.9.0 X-Provags-ID: V03:K0:ZhSJpKMM4ljfIsxwlp5x5/cs+eKgS2feXJOWItRiqCBrmOqnmsV +LQr7fZDnmiR6vpXy6mXp/WqP1ixa4wq4gTPGxP1kgSjpsTVI6UlJEQzX3T2gHJfTW30YZk L4Jg+Bu2V2uRjlAE3cLE2MDxincgEU2kDHV7MpOGP9sq+xS5layXaVMWk0WDzyIEGyw38t1 WKfNXq6zzgUZr4aSCk0zA== X-UI-Out-Filterresults: notjunk:1; V01:K0:G8Ov7gl5AeY=:sKpXKA3exhDELv9Ax28Dsx 6uwImlRLoSTH+WW5snfu3UThCslAJN8SfSKWvOePN8zTESGLzVuGr+OD8uLQJq94C4QwTThyT yw5nzkBet4U48IIiygsd6WlQkrz7yfNhwlVcyRKvNUJiRvPr+GwRPpH80hMM4R4PAyH+sj3VU 9SHngLfTViLOsUNnFS/NIyCySGHcq01EtQ2NmlR+tZSNq0jLhAhflJfiMhG10AqPQXkMUTZmL 1R2/+sPdBSM31KKU5znB13XwofW6zoa/WCYwIpIJyQ3UBbGoPCkTgeBOktNPIfBi5eevFrIae H0VpPeD9D0vTf2ydLguUSsnrvtGQek89+i2T+x+l/Ny/GLs+oHs+mj5mzaZ28Pe6VSOWDExMk MLtBlzY/huLbPuc2jU+iZmYUvtwtat93+suM3tOqq8R9NBYiz05z0gAUjcvHNZpZsFxnHx2ws HKxBQ5QCW+Ug+ld5esdIA8H62tsjUV6cToYg1gYmNFVJzKOavLmHj2yuTTAtSc9N0yPVa9wsM w5O36eEAhFKZf3OtpMdo8RZOsFHZgeN0myllIU7WmrxsOlfsMVd9AAGznq4R277JEDj9r2Fv3 aHZqJ51p25QBIBU+RJ6GKHWVA36o0A9uBTv7KIUFKbTwd7kRZrVQdiLngf6BlexbWsyIr7c/6 xQKiQaAXVY//zf3hJ/AU9Y375jbON+VVP4UkClrcTzCR01EkCFo1DbjRZ02Z4Sa24YiU= Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org I still see build errors in randconfig builds and have had this patch for a while to locally work around it: drivers/built-in.o: In function `xgene_mdio_probe': mux-core.c:(.text+0x352154): undefined reference to `of_mdiobus_register' mux-core.c:(.text+0x352168): undefined reference to `mdiobus_free' mux-core.c:(.text+0x3521c0): undefined reference to `mdiobus_alloc_size' The idea is that CONFIG_MDIO_BUS now reflects whether the mdio_bus code is built-in or a module, and other drivers that use the core code can simply depend on that, instead of having a complex dependency line. Fixes: 90eff9096c01 ("net: phy: Allow splitting MDIO bus/device support from PHYs") Signed-off-by: Arnd Bergmann --- drivers/net/phy/Kconfig | 13 ++++++++++--- 1 file changed, 10 insertions(+), 3 deletions(-) -- 2.9.0 Reviewed-by: Florian Fainelli diff --git a/drivers/net/phy/Kconfig b/drivers/net/phy/Kconfig index 2dda72004a7d..928fd892f167 100644 --- a/drivers/net/phy/Kconfig +++ b/drivers/net/phy/Kconfig @@ -7,7 +7,16 @@ menuconfig MDIO_DEVICE help MDIO devices and driver infrastructure code. -if MDIO_DEVICE +config MDIO_BUS + tristate + default m if PHYLIB=m + default MDIO_DEVICE + help + This internal symbol is used for link time dependencies and it + reflects whether the mdio_bus/mdio_device code is built as a + loadable module or built-in. + +if MDIO_BUS config MDIO_BCM_IPROC tristate "Broadcom iProc MDIO bus controller" @@ -28,7 +37,6 @@ config MDIO_BCM_UNIMAC config MDIO_BITBANG tristate "Bitbanged MDIO buses" - depends on !(MDIO_DEVICE=y && PHYLIB=m) help This module implements the MDIO bus protocol in software, for use by low level drivers that export the ability to @@ -127,7 +135,6 @@ config MDIO_THUNDER tristate "ThunderX SOCs MDIO buses" depends on 64BIT depends on PCI - depends on !(MDIO_DEVICE=y && PHYLIB=m) select MDIO_CAVIUM help This driver supports the MDIO interfaces found on Cavium From patchwork Wed Jun 21 22:06:07 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnd Bergmann X-Patchwork-Id: 106136 Delivered-To: patch@linaro.org Received: by 10.140.91.2 with SMTP id y2csp2154965qgd; Wed, 21 Jun 2017 15:08:20 -0700 (PDT) X-Received: by 10.84.160.235 with SMTP id v40mr8801441plg.91.1498082899938; Wed, 21 Jun 2017 15:08:19 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1498082899; cv=none; d=google.com; s=arc-20160816; b=dJKzcTzvdP8eZudLMkmFG8vtqGOAikS3UkzDbDbR+bCbyIDkf0NN4sMYRGy4pQ0Tp7 5FjTOPhsAKXlw8gqE/K5CTPcQUUx87ruPOIX5nWu7LjPSmR/X1V5Jeo86WigyJ4hNKeo 03NAKBxI7iymFIsBn33uhX5eadhjAzNTeZRYxTitBxCezBvIS28eggPjswTEFNAh8Xsh zvtp0r+CDQjaJzJq7Cy7Q7wDEzpCxKHsGqp1R4sNU6STDW4rjVt9ccZ9h+ce26psI8jB hLbTxG3D5AoqXQNiX2mPYACAGXVmhKymPzaUbzbYaf6XDRDTInQpEg6xpRyZRK/Ejmql av0Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from:arc-authentication-results; bh=fVLju9IcmqaVPAzqay6SQkcp0NHX8nCGG3XwbJHjMdU=; b=cdh2OYQIcwWUVCWjVw1vtO4wSSoiPXZQN2Kd/mW1Vjy2I87qd2B1Tt3kz1nrq+xitY Ak2PvZfrjtTXI/CMUncHgN8pdsGYLPWyyPf19CHfT25LrH8cMdnqY8p8DWpE7vo3SQaZ r2reOp4LlCkp2rBjGsVoLnGfSwpYKfARr5SHtEJINMJEetX3j4JutpV++eWtMiQD/O6x 60DxbPl8mo22YkqLS7+eJEy0jmUQ7RMni3ufDI8qIeVAvs8JL++0/qigvU3UaKkFeTiI HSwiNtLtWqnRfiGIZDp4zp1KZuNZinBMW39bNgxcgwUEyMLZVFOZORMxJxocjX+2cHy5 yWIw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id u5si15572511plm.352.2017.06.21.15.08.19; Wed, 21 Jun 2017 15:08:19 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752563AbdFUWHw (ORCPT + 25 others); Wed, 21 Jun 2017 18:07:52 -0400 Received: from mout.kundenserver.de ([212.227.17.13]:57834 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751999AbdFUWHu (ORCPT ); Wed, 21 Jun 2017 18:07:50 -0400 Received: from wuerfel.lan ([5.56.224.194]) by mrelayeu.kundenserver.de (mreue103 [212.227.15.145]) with ESMTPA (Nemesis) id 0LZl8O-1e4Vzj0IUW-00lU3x; Thu, 22 Jun 2017 00:06:59 +0200 From: Arnd Bergmann To: Florian Fainelli Cc: =?utf-8?b?UmFmYcWCIE1pxYJlY2tp?= , Kishon Vijay Abraham I , Andrew Lunn , netdev@vger.kernel.org, "David S . Miller" , Arnd Bergmann , linux-kernel@vger.kernel.org Subject: [RFC 2/2] phy: bcm-ns-usb3: fix MDIO_BUS dependency Date: Thu, 22 Jun 2017 00:06:07 +0200 Message-Id: <20170621220626.46691-2-arnd@arndb.de> X-Mailer: git-send-email 2.9.0 In-Reply-To: <20170621220626.46691-1-arnd@arndb.de> References: <20170621220626.46691-1-arnd@arndb.de> X-Provags-ID: V03:K0:sGozzXOWYl2thooS4xjQoRQW9gcQB+E+H0Uyjyz6+QmN7ZG/oj4 UnQCHJaVK2n5SXwQp7bw0FU79lsSWubi4zmXENPieGfa8RiFO7x94WN8+jvML9IxYL7FK84 Tragki22rHmjyAKRn253jGJkiX3euXEtx86ZVuL4s+tt2FiaZZLVwoej1YyPRM+Ru3vgAYz yecYfSooZlK3Q1rucnSOw== X-UI-Out-Filterresults: notjunk:1; V01:K0:Ss5uy2t86cc=:r7vHrVdhps4UB/OqoNOFMQ R96Z66Og2EdFy1P3yxd9Vb4GJVDJrLdRwk0lNo9Y5pdRihe3rcV5Ezp3LEmBaoSrGHk/5/GKI IuB/qDglGFgEqZHMwCPkf7V+HKVOB7zhiUgHqZNmCVY7Ak0YEPbM+5GIlk0NlmAtOGsg92ICV eUURquqJwdTcyueSE1d6js3+Lxof4osJS42L3RTDIhNhAh3S5CK3qMxmLYHbVkGHRroLg75Zo GMcMd4OmiacknMOzK1LdRufy7di6MMm95dW76D7tZ2tXu1oEFLgtLGjJI4NyJgR+kwvvzIUP3 lH+d7/Nwed6XS6OQXddlAaHK0Qcc7Dhh9tdzplYPZx7LFSknQYF8v+iq1AvMjPzrZFxnS2mAn pm7nDJjnsfeOmWftRFjK0fRgw7PRPo0f1fhnlJjpfnC8w5lCoX4LTryyQNAt4ObcH+v+oaiSH DLCZ6rLz8g+21FvBIMlXcp9HDPBsEBDE8jkd0IwYChozWrOTfuTea0pyAsOJSSF2NGAXm21JY jR/osdllS0DQJlrNYTmNKmASOJQo3i7xEJuWfHW/dmT5YER6ra3xM7hGcTvWZuhJ8irwsRtiD HDkPEHNJRY7B25n+31gdQJEygfU16p3ToE0QilwtY52Fm3q2wW+8HrZ57DVN1ZP44oKwcLrLa ZcIjgCZV8B8ZsbiVFx+H4effzdATKJzbPYTRMvFIn29taKXxtfkzsz1ADwWbG2LZkslc= Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The driver attempts to 'select MDIO_DEVICE', but the code is actually a loadable module when PHYLIB=m: drivers/phy/broadcom/phy-bcm-ns-usb3.o: In function `bcm_ns_usb3_mdiodev_phy_write': phy-bcm-ns-usb3.c:(.text.bcm_ns_usb3_mdiodev_phy_write+0x28): undefined reference to `mdiobus_write' drivers/phy/broadcom/phy-bcm-ns-usb3.o: In function `bcm_ns_usb3_module_exit': phy-bcm-ns-usb3.c:(.exit.text+0x18): undefined reference to `mdio_driver_unregister' drivers/phy/broadcom/phy-bcm-ns-usb3.o: In function `bcm_ns_usb3_module_init': phy-bcm-ns-usb3.c:(.init.text+0x18): undefined reference to `mdio_driver_register' phy-bcm-ns-usb3.c:(.init.text+0x38): undefined reference to `mdio_driver_unregister' Using 'depends on MDIO_BUS' instead will avoid the link error. Fixes: af850e14a7ae ("phy: bcm-ns-usb3: add MDIO driver using proper bus layer") Signed-off-by: Arnd Bergmann --- drivers/phy/broadcom/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.9.0 Reviewed-by: Florian Fainelli diff --git a/drivers/phy/broadcom/Kconfig b/drivers/phy/broadcom/Kconfig index 37371b89b14f..64fc59c3ae6d 100644 --- a/drivers/phy/broadcom/Kconfig +++ b/drivers/phy/broadcom/Kconfig @@ -30,8 +30,8 @@ config PHY_BCM_NS_USB3 tristate "Broadcom Northstar USB 3.0 PHY Driver" depends on ARCH_BCM_IPROC || COMPILE_TEST depends on HAS_IOMEM && OF + depends on MDIO_BUS select GENERIC_PHY - select MDIO_DEVICE help Enable this to support Broadcom USB 3.0 PHY connected to the USB controller on Northstar family.