From patchwork Wed Dec 4 17:49:03 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Greg KH X-Patchwork-Id: 180847 Delivered-To: patch@linaro.org Received: by 2002:a92:3001:0:0:0:0:0 with SMTP id x1csp961634ile; Wed, 4 Dec 2019 10:26:52 -0800 (PST) X-Google-Smtp-Source: APXvYqz/ApJ86cLvnV+p6gV7JTDy7hQKwQrngMYoWS3voNmuWXTkJUgJ8seWuhQqXiEBO46QRbUe X-Received: by 2002:a05:6830:2141:: with SMTP id r1mr3370899otd.124.1575484012656; Wed, 04 Dec 2019 10:26:52 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1575484012; cv=none; d=google.com; s=arc-20160816; b=CEiSUz2P7aC1wH205PoX0EOdnRrkeeq2sFuqdDd16Whn7+8n7b5qslHYtcP8NdT8EU MW2kIbaLhCTWzA0litiCAIwznO+Xp6Tkh6d+mOL3ZlcmJBXjlaEgaK0UQJTIkuOj0Ny6 iBWULq9W36WmwRnkPVky1MsdFmJRkWPk47JXhwbqto/YZogzmrCCbfTYYmQ0XVKmZFab rY38nw1x1s2IpTcV++IRyJoYhGg9kdzDoOwUfVdvHbeDj2Pi6pEwIZhpxpTahJZrpF9/ rQTuFRY4TX5060EvMMNCRm/0L8SC9rERgGdeLFMpogMChqS7Yy9gYcmXlNF9l4WA4g/h mDYg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=PVfpINWwYjAyrc825yO+a8SQzBQAYdGLE0o33Q7jF/I=; b=xBSDw4LiKxB/V16Op9TkNeATXToDJJO0PlcTIJBq7IAvl81Rz+7Z/k/LOp35dGQ4Pf aeXsxpABEgjSBMFp6ul6fLXKQrCrmpT+IbEvjR+X9g6KJVGE2fbq3ns9S7NMePCrHliR UxNttOVQl8Zo+tgY1n2KbNGj3acG2nKzEWKxBuAVJ2iN5gw4T2b+AZn64eu7S0Df0yXc Wl0fyKS/FyLn1pS8i1t1TOQlaG2O9SKa3bHnRHZo5YCp13RL6Fp3ZPGyodBblF1rGpHQ sTIP9FL4NkWRD7vrLEv45TSC/ziMwrVdYUiPgcyRQEwjsmtGFbs50DvdjNPDO5Z5X1Rr k8jA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=LF1WPbnU; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id x20si3421551otq.222.2019.12.04.10.26.52; Wed, 04 Dec 2019 10:26:52 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=LF1WPbnU; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730038AbfLDS0v (ORCPT + 27 others); Wed, 4 Dec 2019 13:26:51 -0500 Received: from mail.kernel.org ([198.145.29.99]:34580 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728358AbfLDR67 (ORCPT ); Wed, 4 Dec 2019 12:58:59 -0500 Received: from localhost (unknown [217.68.49.72]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 4641420863; Wed, 4 Dec 2019 17:58:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1575482338; bh=r7wqaF6k5AKKWznTAOwQ33pGuMlmJ/ecwfN0IvJdRUw=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=LF1WPbnU7rirtLM8uoc1F3OaAel2ucuLPRDrJBXHkyvMgq015Q1W9SHjoh+Gdi+Kk lmLjcO8QZlopMqMkYp0pwA8UQvvIAj60fj23js9oo9ZCkKPFJHE5Q4Zr0De/cDnTFl CFhKykznCBy52sA4ddqcIlhd2jPlCDlcTRH45jAo= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, "Reported-by: Marian Mihailescu" , Marek Szyprowski , Sylwester Nawrocki , Sasha Levin Subject: [PATCH 4.4 03/92] clk: samsung: exynos5420: Preserve PLL configuration during suspend/resume Date: Wed, 4 Dec 2019 18:49:03 +0100 Message-Id: <20191204174328.318163643@linuxfoundation.org> X-Mailer: git-send-email 2.24.0 In-Reply-To: <20191204174327.215426506@linuxfoundation.org> References: <20191204174327.215426506@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Marek Szyprowski [ Upstream commit e9323b664ce29547d996195e8a6129a351c39108 ] Properly save and restore all top PLL related configuration registers during suspend/resume cycle. So far driver only handled EPLL and RPLL clocks, all other were reset to default values after suspend/resume cycle. This caused for example lower G3D (MALI Panfrost) performance after system resume, even if performance governor has been selected. Reported-by: Reported-by: Marian Mihailescu Fixes: 773424326b51 ("clk: samsung: exynos5420: add more registers to restore list") Signed-off-by: Marek Szyprowski Signed-off-by: Sylwester Nawrocki Signed-off-by: Sasha Levin --- drivers/clk/samsung/clk-exynos5420.c | 6 ++++++ 1 file changed, 6 insertions(+) -- 2.20.1 diff --git a/drivers/clk/samsung/clk-exynos5420.c b/drivers/clk/samsung/clk-exynos5420.c index bde71b07f15e7..c94de13ce3627 100644 --- a/drivers/clk/samsung/clk-exynos5420.c +++ b/drivers/clk/samsung/clk-exynos5420.c @@ -166,12 +166,18 @@ static unsigned long exynos5x_clk_regs[] __initdata = { GATE_BUS_CPU, GATE_SCLK_CPU, CLKOUT_CMU_CPU, + CPLL_CON0, + DPLL_CON0, EPLL_CON0, EPLL_CON1, EPLL_CON2, RPLL_CON0, RPLL_CON1, RPLL_CON2, + IPLL_CON0, + SPLL_CON0, + VPLL_CON0, + MPLL_CON0, SRC_TOP0, SRC_TOP1, SRC_TOP2, From patchwork Wed Dec 4 17:49:16 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Greg KH X-Patchwork-Id: 180819 Delivered-To: patch@linaro.org Received: by 2002:a92:3001:0:0:0:0:0 with SMTP id x1csp924943ile; Wed, 4 Dec 2019 09:57:46 -0800 (PST) X-Google-Smtp-Source: APXvYqwJu8TMW9iqOivJJwK2Z31dIzM7Aw/dTNKpUXvbiSwf9zHBHKR6PbTpuq+ITTMBxYkWHPKP X-Received: by 2002:a9d:774e:: with SMTP id t14mr3354103otl.358.1575482266578; Wed, 04 Dec 2019 09:57:46 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1575482266; cv=none; d=google.com; s=arc-20160816; b=adQlsmrNZ/NEx/a0w4Q1H416atfNSGGx5Q/IOIORXEUavVJU94wPIH6Pr0ol9bp9N4 SaqC/wDbl1u+i6Nnlwok6LnF/59ubO96Ly1iD6PxrnimODqweynnh/OqFHkkGb81yDhq MwjsAUq/Yh069DHrIXASxdacYjGaaycZffBAZ1j6wL1M9b0fRYMp1fgj5QIubO07YM4x ALaFpe1iwdyGY8cxxkQZwCGi4ZTkRy5q/XtEdnOmSbzFr2GB8VoR0BA32NfO4W4I86w0 EoO6qfNYGXZW+lt9yobG2EQ0DX/PU9kT92qrinLkwwBrRp5jlieSPWZuqrHLjWRjPbG3 +APw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=7tl/LRncRhJp794B3NmB3JhU+4i3yM8W6vO7lIyB4po=; b=yQ0ZjOLTu9OfLRZOtOvKCnmYZjwyOfhbxEMRC9BlNAes/wIQL/JAB4crjMQNa5TBgO zXeyNY+tf24DsZR6g32vzjbbGuhAUt95tx98Zlk79GLynFPb0pMVEZEpbg8S48og1ZLm CvdNrv/SdwZo1qNy1NTPt39NtB32KU9fHYAByCmoYuKze5SvKBlzHqW4IZxwuCUNo4yU 7ZKjoqkWA86cFlsBq2+TAWFZy53gOROlvxhuQ2YEdaR0+T8emtvsf9vxeN7ec78B7rjj xAk7nQg38ua6/c1Gro2gO3Pe/rNIUlORXsDzepRn1g2COTgejl3Xo9vq4qOq33lYy5Gi 6kzQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b="PU/tJQio"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id w4si3490225otl.214.2019.12.04.09.57.46; Wed, 04 Dec 2019 09:57:46 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b="PU/tJQio"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728369AbfLDR5o (ORCPT + 27 others); Wed, 4 Dec 2019 12:57:44 -0500 Received: from mail.kernel.org ([198.145.29.99]:58808 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728342AbfLDR5l (ORCPT ); Wed, 4 Dec 2019 12:57:41 -0500 Received: from localhost (unknown [217.68.49.72]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 8AD1F2073B; Wed, 4 Dec 2019 17:57:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1575482261; bh=cxbX40+yMebtvgtypjYfDbKSAlYOdV5SCSC0zAhdyaI=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=PU/tJQioApDfddDF0sWOivRVBjjIWyg+eKwolAu9Un25n8WHvd7k9eMAkAxvB8zo4 BbFq1dnEvCPNOpOGPEz+RdJlmCL5b0o4Mn80isRZdcJ2lQiwHP8vI2yBZ99SQZ6f5e T3sYhBEkg8BvVlpBnA6gpMM8+KFv5FtxCTFlqlJE= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Arnd Bergmann , Olof Johansson , Sasha Levin Subject: [PATCH 4.4 16/92] ARM: ks8695: fix section mismatch warning Date: Wed, 4 Dec 2019 18:49:16 +0100 Message-Id: <20191204174330.411393155@linuxfoundation.org> X-Mailer: git-send-email 2.24.0 In-Reply-To: <20191204174327.215426506@linuxfoundation.org> References: <20191204174327.215426506@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Arnd Bergmann [ Upstream commit 4aa64677330beeeed721b4b122884dabad845d66 ] WARNING: vmlinux.o(.text+0x13250): Section mismatch in reference from the function acs5k_i2c_init() to the (unknown reference) .init.data:(unknown) The function acs5k_i2c_init() references the (unknown reference) __initdata (unknown). This is often because acs5k_i2c_init lacks a __initdata annotation or the annotation of (unknown) is wrong. Signed-off-by: Arnd Bergmann Signed-off-by: Olof Johansson Signed-off-by: Sasha Levin --- arch/arm/mach-ks8695/board-acs5k.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.20.1 diff --git a/arch/arm/mach-ks8695/board-acs5k.c b/arch/arm/mach-ks8695/board-acs5k.c index 9f9c0441a9175..e372609c48dd0 100644 --- a/arch/arm/mach-ks8695/board-acs5k.c +++ b/arch/arm/mach-ks8695/board-acs5k.c @@ -92,7 +92,7 @@ static struct i2c_board_info acs5k_i2c_devs[] __initdata = { }, }; -static void acs5k_i2c_init(void) +static void __init acs5k_i2c_init(void) { /* The gpio interface */ platform_device_register(&acs5k_i2c_device); From patchwork Wed Dec 4 17:49:25 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Greg KH X-Patchwork-Id: 180820 Delivered-To: patch@linaro.org Received: by 2002:a92:3001:0:0:0:0:0 with SMTP id x1csp925352ile; Wed, 4 Dec 2019 09:58:10 -0800 (PST) X-Google-Smtp-Source: APXvYqz0AR+MmblXFTdttZpFFtb7UObmyYhhkF36pXT4yJXjWDzzAqNMovQdx5QRcOfMztvMMGHr X-Received: by 2002:a05:6830:160c:: with SMTP id g12mr3432458otr.82.1575482290641; Wed, 04 Dec 2019 09:58:10 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1575482290; cv=none; d=google.com; s=arc-20160816; b=agYOLXOTuimAiLjdULWtiDN3Je4D6gD3t82CQd1ZKUo0Om7QM2K40rheq3RPwPmUis qiJz/ix7o4bukntl1S7gqc9JufR4tOi6SJem0Y9sIXJexYqAwvxI5dHQgyHtz80Mglth vGPFbpmmho/15/u2w0K9BhkXqd9ZHU0u0pJtA4G/HH7sAXjw43+/WR4DvyVUlLkFpTjM Y7pIcXvkopjn4By2/Uqx3Y/pj4adZ0hd51pQe750oC7mUNOyxU7P+LshHTPTUtI1v+Q5 RHCMpEbcfc4gDOwEFfDMxyHVfuJ4z4/wpOyXV9qRDUvK1RXXBtq22wbB7zTQq4dB7MW7 g0Pw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=aJu6ZyW86PWD0uwklrQqIvyNi53pfS3MBNokozcVlDE=; b=OXjet0rTG7B1HnZnrzgmNA8rN4hZJKWovWUwTnJLD1uXCHDLJuuOddUWN93NwTtKEJ vJZqVuPD33AXySIPJZ/tZ71BSXEVu4EEQEjomEVBdhFO74HDdJ7iY7kLzQagDqS/GAfX W2mcqZFy+0/DQUKl2Nus3I20ttKx1GLjKEfAWi5dHrS586sAIxCLH0pUC3X0gxedpYMh BuElXR5R2DOVlzaIddvGR9fSw7328+SBbE0UMhh70NgHxuGR/9GrsqCjLc2yqwy8IJoQ lqzv4mXUaBtGymhvHwDly9GZ6vTbXRQpy+pWqacB7otRFQg5UA4DPeJdqN3FzMCjWEfO zXkg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=h7FKRRAp; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id b6si169160oiy.116.2019.12.04.09.58.10; Wed, 04 Dec 2019 09:58:10 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=h7FKRRAp; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728603AbfLDR6J (ORCPT + 27 others); Wed, 4 Dec 2019 12:58:09 -0500 Received: from mail.kernel.org ([198.145.29.99]:60122 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728564AbfLDR6F (ORCPT ); Wed, 4 Dec 2019 12:58:05 -0500 Received: from localhost (unknown [217.68.49.72]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id F37422073B; Wed, 4 Dec 2019 17:58:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1575482285; bh=ZCOYm7uvTGNlci+Nc06dmUObDmY7JSDWXNomo+BzJS4=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=h7FKRRAp+N52pvgHIeHzwirZbqVLLwhdFgH2wvUeYt3nE7oCNX+yZG5QwwOMc3ZtD rZ7GLeWI1lQC6Ba/YiQZene4kNmVTMi3KlYCqrUNeoCXLybZjbpzTKNtJ8YeDRNtGz 9xFrdD/pcZ6UQ2XZHxP5AKW55aVy7yvHuzoEGaG0= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Masahiro Yamada , Michal Simek , Sasha Levin Subject: [PATCH 4.4 25/92] microblaze: adjust the help to the real behavior Date: Wed, 4 Dec 2019 18:49:25 +0100 Message-Id: <20191204174331.839678014@linuxfoundation.org> X-Mailer: git-send-email 2.24.0 In-Reply-To: <20191204174327.215426506@linuxfoundation.org> References: <20191204174327.215426506@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Masahiro Yamada [ Upstream commit bafcc61d998c1ca18f556d92a0e95335ac68c7da ] "make ARCH=microblaze help" mentions simpleImage.
.unstrip, but it is not a real Make target. It does not work because Makefile assumes "system.unstrip" is the name of DT. $ make ARCH=microblaze CROSS_COMPILE=microblaze-linux- simpleImage.system.unstrip [ snip ] make[1]: *** No rule to make target 'arch/microblaze/boot/dts/system.unstrip.dtb', needed by 'arch/microblaze/boot/dts/system.dtb'. Stop. make: *** [Makefile;1060: arch/microblaze/boot/dts] Error 2 make: *** Waiting for unfinished jobs.... simpleImage.
works like a phony target that generates multiple images. Reflect the real behavior. I removed the DT directory path information because it is already explained a few lines below. While I am here, I deleted the redundant *_defconfig explanation. The top-level Makefile caters to list available defconfig files: mmu_defconfig - Build for mmu nommu_defconfig - Build for nommu Signed-off-by: Masahiro Yamada Signed-off-by: Michal Simek Signed-off-by: Sasha Levin --- arch/microblaze/Makefile | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) -- 2.20.1 diff --git a/arch/microblaze/Makefile b/arch/microblaze/Makefile index 740f2b82a182a..5e1e18540a571 100644 --- a/arch/microblaze/Makefile +++ b/arch/microblaze/Makefile @@ -83,11 +83,11 @@ define archhelp echo '* linux.bin - Create raw binary' echo ' linux.bin.gz - Create compressed raw binary' echo ' linux.bin.ub - Create U-Boot wrapped raw binary' - echo ' simpleImage.
- ELF image with $(arch)/boot/dts/
.dts linked in' - echo ' - stripped elf with fdt blob' - echo ' simpleImage.
.unstrip - full ELF image with fdt blob' - echo ' *_defconfig - Select default config from arch/microblaze/configs' - echo '' + echo ' simpleImage.
- Create the following images with
.dtb linked in' + echo ' simpleImage.
: raw image' + echo ' simpleImage.
.ub : raw image with U-Boot header' + echo ' simpleImage.
.unstrip: ELF (identical to vmlinux)' + echo ' simpleImage.
.strip : stripped ELF' echo ' Targets with
embed a device tree blob inside the image' echo ' These targets support board with firmware that does not' echo ' support passing a device tree directly. Replace
with the' From patchwork Wed Dec 4 17:49:26 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Greg KH X-Patchwork-Id: 180848 Delivered-To: patch@linaro.org Received: by 2002:a92:3001:0:0:0:0:0 with SMTP id x1csp962663ile; Wed, 4 Dec 2019 10:27:50 -0800 (PST) X-Google-Smtp-Source: APXvYqzMh7K9aYTh/62Yhw44sPGE3ghE1KLFHu4hoyQOoH0BdfiH72pimSVb2VJoYyK/L5Dyl7/A X-Received: by 2002:a05:6808:56:: with SMTP id v22mr3687803oic.37.1575484070157; Wed, 04 Dec 2019 10:27:50 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1575484070; cv=none; d=google.com; s=arc-20160816; b=gsu5EnUJIMCNoiHjqUuvcvuX30xOjsL5R2v0nIHu02qAWzoojf3hIqipwWmTHIGSK6 YIcVWtRzehHPcXzQvh10HOEZGOm8VKgKStF8hEE8ZtZuvNWcbXu0zw1Ahj7ER4r/tkv/ eOcKB8P1q81BTjOjHJnTd7aqGg2X5pKF/YI0xLccDuLW3GWkmnF8AQ455PirAz3UisF6 BWjSh0cUaL9gVHw8xG7G1rnuocWU3Ns6MbL9nJs1HEcJopJqWpggFPuWSkvrTgieTQKt 74gHVisWvfv2NUYpqs78KGTLsLVNl4waUc01HTRHr4HxbnoJQm5ZvGpXA/NiDKtmiSHF S2yg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=ocwOjP1Ks6Q4NrkKC/9NkmgMdHh8E3NPiqj55JdCZFQ=; b=ci96QHwrQL2EslZEjb43M4EAj4fN0cRmYjXvS3BWstxVgSvXsq1uiSxyLBiTHtXpo9 e0YNr7fNFMdfia/oIF8M8PYX57iM4hTygb7ApS3k5aSnCYBMSryVhWcKPG47m4wahIKR gvj3PNsQ+kfOFoWYCkve5o3+mWbHj7dwGqYapk9VXoC9KzWf52R6vrb4AL0LmSav2fXU BdAMknyNKUv/Kq2XQAiM/r8yFLm6Q2l1l+R0a+nC7akyp0ACajwYYUbVlNdgHoizpKyX 0ZrJNKo55CC0Y3AW8rhfjaprXAKg2rStqlGtfb6xMRuMTMazNxBx1Xcom22hv8GOC12H dVcQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=N0ONHXjF; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id f19si3742165oti.192.2019.12.04.10.27.49; Wed, 04 Dec 2019 10:27:50 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=N0ONHXjF; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728642AbfLDR6N (ORCPT + 27 others); Wed, 4 Dec 2019 12:58:13 -0500 Received: from mail.kernel.org ([198.145.29.99]:60266 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728512AbfLDR6I (ORCPT ); Wed, 4 Dec 2019 12:58:08 -0500 Received: from localhost (unknown [217.68.49.72]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 632B120675; Wed, 4 Dec 2019 17:58:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1575482287; bh=H1WBjtuVHU+q1pByMDCrOf3M0NmQW+pm/fk8+btGKfY=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=N0ONHXjFaMUWRXiAX6TYNJumSNatMdPxDbDsEKIgZ9cTka3NLXkNrTVx2kZlryfvF PxZbc+JFiQce6jzjS3osxPXMXo43VeSRvUYE/fAfc2HzKljGNj2ze94ygm+PlPkrvD FmNWkUKV3jTmhdNN4b/EeBctz+0TWuq+ehZxCmbg= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Masahiro Yamada , Michal Simek , Sasha Levin Subject: [PATCH 4.4 26/92] microblaze: move "... is ready" messages to arch/microblaze/Makefile Date: Wed, 4 Dec 2019 18:49:26 +0100 Message-Id: <20191204174332.091899977@linuxfoundation.org> X-Mailer: git-send-email 2.24.0 In-Reply-To: <20191204174327.215426506@linuxfoundation.org> References: <20191204174327.215426506@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Masahiro Yamada [ Upstream commit 2e14f94cf4bc2f15ca5362e81ca3a987c79e3062 ] To prepare for more fixes, move this to arch/microblaze/Makefile. Otherwise, the same "... is ready" would be printed multiple times. Signed-off-by: Masahiro Yamada Signed-off-by: Michal Simek Signed-off-by: Sasha Levin --- arch/microblaze/Makefile | 2 ++ arch/microblaze/boot/Makefile | 4 ---- 2 files changed, 2 insertions(+), 4 deletions(-) -- 2.20.1 diff --git a/arch/microblaze/Makefile b/arch/microblaze/Makefile index 5e1e18540a571..491676a6cde57 100644 --- a/arch/microblaze/Makefile +++ b/arch/microblaze/Makefile @@ -75,9 +75,11 @@ archclean: linux.bin linux.bin.gz linux.bin.ub: vmlinux $(Q)$(MAKE) $(build)=$(boot) $(boot)/$@ + @echo 'Kernel: $(boot)/$@ is ready' ' (#'`cat .version`')' simpleImage.%: vmlinux $(Q)$(MAKE) $(build)=$(boot) $(boot)/$@ + @echo 'Kernel: $(boot)/$@ is ready' ' (#'`cat .version`')' define archhelp echo '* linux.bin - Create raw binary' diff --git a/arch/microblaze/boot/Makefile b/arch/microblaze/boot/Makefile index 0f3fe6a151dce..22bed08ec7f28 100644 --- a/arch/microblaze/boot/Makefile +++ b/arch/microblaze/boot/Makefile @@ -8,15 +8,12 @@ OBJCOPYFLAGS := -R .note -R .comment -R .note.gnu.build-id -O binary $(obj)/linux.bin: vmlinux FORCE $(call if_changed,objcopy) - @echo 'Kernel: $@ is ready' ' (#'`cat .version`')' $(obj)/linux.bin.ub: $(obj)/linux.bin FORCE $(call if_changed,uimage) - @echo 'Kernel: $@ is ready' ' (#'`cat .version`')' $(obj)/linux.bin.gz: $(obj)/linux.bin FORCE $(call if_changed,gzip) - @echo 'Kernel: $@ is ready' ' (#'`cat .version`')' quiet_cmd_cp = CP $< $@$2 cmd_cp = cat $< >$@$2 || (rm -f $@ && echo false) @@ -34,6 +31,5 @@ $(obj)/simpleImage.%: vmlinux FORCE $(call if_changed,objcopy) $(call if_changed,uimage) $(call if_changed,strip,.strip) - @echo 'Kernel: $(UIMAGE_OUT) is ready' ' (#'`cat .version`')' clean-files += simpleImage.*.unstrip linux.bin.ub dts/*.dtb From patchwork Wed Dec 4 17:50:12 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Greg KH X-Patchwork-Id: 180821 Delivered-To: patch@linaro.org Received: by 2002:a92:3001:0:0:0:0:0 with SMTP id x1csp927400ile; Wed, 4 Dec 2019 10:00:07 -0800 (PST) X-Google-Smtp-Source: APXvYqxY1YhROmJs33aADPrz386DJBItGPD7rgLneRLjWwXnMTwbXSrVKtmkADHA+e8KW2Yb+9Sd X-Received: by 2002:a05:6830:1707:: with SMTP id 7mr3703790otk.185.1575482407343; Wed, 04 Dec 2019 10:00:07 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1575482407; cv=none; d=google.com; s=arc-20160816; b=YovKypjTrvdNGZeYHBDyiDifckG9/a0uOqWsYTyocdfL+aXaZukAJLlhEysGTOI9NZ wNOpWboGN3Xp5RnOMhpPIDzwa0qSCHmJwLy7M3wvh9RxulOp6qEHsP/P5E2D4sVHvdXp cPub/p8/oKIvGr6nRTV4Lk1AVg9i+Z58gW3lDPtM3zO74kgAqG9G3iN6utHJfVvMqpre 0vm5rMnHk1Udk7RXzxmTk9hfTLodiqy3o2ZudK7uP97r/P33qkm6hvODLMCqPinNuljz d/yjbs2mrTpPS8GqQiC8G3jwNSNJlJ/Su6ZWPPHPxeWMoam63vLRS06zBlnPXJkYQsnn QwyA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=pXhJFdyC9Q3iFGXUDnxWfDp1jyJaJavq5YFFXEsv+nA=; b=tT02vSro8GaXXcZZfncnaRz+JGa5xTLxONW8+8fpHRu13pUwUmGdPEjAxUGMwnZ41b rFHGkJm7tXMAFNwf9Ni0vWyb9XoIAtIWw64OqMlXW99ivCKW+ZYLa+MS1G28R++TXNUi bkFYIZyizEoC58XWpChe7dvqtnjTrwiizEBASG8sczX0wMIVBQDFIIkKnEFKKYoVauNb 1+OwcsraytEvEhGF5fqga0ZG4MU1aiaArweXvYINVqlGnVrcx6GbrtSp7rob+bzjRz7i O1OJ5ae48Q2yDDa1fGehGzyCPTarKc7GTdFOKKE8gtbKCTA9VCzpqExk5ea5zHz4PJfD cJAw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=fuqsMjr5; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id o12si3699461otk.323.2019.12.04.10.00.07; Wed, 04 Dec 2019 10:00:07 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=fuqsMjr5; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729268AbfLDSAF (ORCPT + 27 others); Wed, 4 Dec 2019 13:00:05 -0500 Received: from mail.kernel.org ([198.145.29.99]:37792 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729254AbfLDSAC (ORCPT ); Wed, 4 Dec 2019 13:00:02 -0500 Received: from localhost (unknown [217.68.49.72]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 79B5520675; Wed, 4 Dec 2019 18:00:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1575482401; bh=Oq84LTVSVC75WPxhcTGPrRuAJow9CRZ9cyQfe033SG0=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=fuqsMjr52jxmmUmMfAQCooJv67JsXWzwf9v5NoPqgMZ5lY/Qhhybk6cmFafHHy1hq 2tyhVdntwd+gu3DDDvMsHL40YhX/MdYcq4wuDnZV4AwMNV4iur6ccN0q0y96xGC31h yeRbLj5kqgWV4xVlPephn5VvlWlCXs1p1T6pPaYQ= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Jian Luo , John Garry , "Martin K. Petersen" , Sasha Levin Subject: [PATCH 4.4 72/92] scsi: libsas: Support SATA PHY connection rate unmatch fixing during discovery Date: Wed, 4 Dec 2019 18:50:12 +0100 Message-Id: <20191204174334.620697720@linuxfoundation.org> X-Mailer: git-send-email 2.24.0 In-Reply-To: <20191204174327.215426506@linuxfoundation.org> References: <20191204174327.215426506@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: John Garry [ Upstream commit cec9771d2e954650095aa37a6a97722c8194e7d2 ] +----------+ +----------+ | | | | | |--- 3.0 G ---| |--- 6.0 G --- SAS disk | | | | | |--- 3.0 G ---| |--- 6.0 G --- SAS disk |initiator | | | | device |--- 3.0 G ---| Expander |--- 6.0 G --- SAS disk | | | | | |--- 3.0 G ---| |--- 6.0 G --- SATA disk -->failed to connect | | | | | | | |--- 6.0 G --- SATA disk -->failed to connect | | | | +----------+ +----------+ According to Serial Attached SCSI - 1.1 (SAS-1.1): If an expander PHY attached to a SATA PHY is using a physical link rate greater than the maximum connection rate supported by the pathway from an STP initiator port, a management application client should use the SMP PHY CONTROL function (see 10.4.3.10) to set the PROGRAMMED MAXIMUM PHYSICAL LINK RATE field of the expander PHY to the maximum connection rate supported by the pathway from that STP initiator port. Currently libsas does not support checking if this condition occurs, nor rectifying when it does. Such a condition is not at all common, however it has been seen on some pre-silicon environments where the initiator PHY only supports a 1.5 Gbit maximum linkrate, mated with 12G expander PHYs and 3/6G SATA phy. This patch adds support for checking and rectifying this condition during initial device discovery only. We do support checking min pathway connection rate during revalidation phase, when new devices can be detected in the topology. However we do not support in the case of the the user reprogramming PHY linkrates, such that min pathway condition is not met/maintained. A note on root port PHY rates: The libsas root port PHY rates calculation is broken. Libsas sets the rates (min, max, and current linkrate) of a root port to the same linkrate of the first PHY member of that same port. In doing so, it assumes that all other PHYs which subsequently join the port to have the same negotiated linkrate, when they could actually be different. In practice this doesn't happen, as initiator and expander PHYs are normally initialised with consistent min/max linkrates. This has not caused an issue so far, so leave alone for now. Tested-by: Jian Luo Signed-off-by: John Garry Signed-off-by: Martin K. Petersen Signed-off-by: Sasha Levin --- drivers/scsi/libsas/sas_expander.c | 20 ++++++++++++++++++++ 1 file changed, 20 insertions(+) -- 2.20.1 diff --git a/drivers/scsi/libsas/sas_expander.c b/drivers/scsi/libsas/sas_expander.c index d44f18f773c0f..b7e4493d3dc16 100644 --- a/drivers/scsi/libsas/sas_expander.c +++ b/drivers/scsi/libsas/sas_expander.c @@ -806,6 +806,26 @@ static struct domain_device *sas_ex_discover_end_dev( #ifdef CONFIG_SCSI_SAS_ATA if ((phy->attached_tproto & SAS_PROTOCOL_STP) || phy->attached_sata_dev) { + if (child->linkrate > parent->min_linkrate) { + struct sas_phy_linkrates rates = { + .maximum_linkrate = parent->min_linkrate, + .minimum_linkrate = parent->min_linkrate, + }; + int ret; + + pr_notice("ex %016llx phy%02d SATA device linkrate > min pathway connection rate, attempting to lower device linkrate\n", + SAS_ADDR(child->sas_addr), phy_id); + ret = sas_smp_phy_control(parent, phy_id, + PHY_FUNC_LINK_RESET, &rates); + if (ret) { + pr_err("ex %016llx phy%02d SATA device could not set linkrate (%d)\n", + SAS_ADDR(child->sas_addr), phy_id, ret); + goto out_free; + } + pr_notice("ex %016llx phy%02d SATA device set linkrate successfully\n", + SAS_ADDR(child->sas_addr), phy_id); + child->linkrate = child->min_linkrate; + } res = sas_get_ata_info(child, phy); if (res) goto out_free; From patchwork Wed Dec 4 17:50:31 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Greg KH X-Patchwork-Id: 180846 Delivered-To: patch@linaro.org Received: by 2002:a92:3001:0:0:0:0:0 with SMTP id x1csp960143ile; Wed, 4 Dec 2019 10:25:29 -0800 (PST) X-Google-Smtp-Source: APXvYqzdX09yS9X3lIxwQnogMeiKKLrYRJ/XfG2/+ms+xSSJDD+UXaJFxMaQzSwMpDNr6tLOlmj5 X-Received: by 2002:a9d:28f:: with SMTP id 15mr3721828otl.311.1575483929733; Wed, 04 Dec 2019 10:25:29 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1575483929; cv=none; d=google.com; s=arc-20160816; b=JyUxd4a/38rFY7eDna2JzW97e3w3dXVzN3QQTOVn4F8n5//laC7/4r0aLr6NJv5f95 yAZpiPNfOU14GYwO5KaB1MBEmxQT1ufuzjfC7kHcmPJSnQjXVurjNln+O1sM4z11X/dB XnArU7UndpmmYBtz0ODVDTRJCDwWco9ra8HsigcsGlppihmlGNQnyrNWJp8eJuPcSqXB JYUbnXem+IJO3Sei22sSIBa6GAjlmx4darbPFkwpfN4R3ZeRvaEh5eH38rrDhnSMSMPk NZx61H8SV4re+Juj7Crj0tNWptSeHOiWMAJ+cz47nzq4UeuMzvz9s/kYJm//YvD76iwr bIIw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=w2p0FHT9ofEAntJ+D1Egb4SIXLWlhSXAfr8ZXTAUaIk=; b=eb5vKcVAduFrxRHJ8qk0tL8RC/0hrlsDVb67s7xk8+QOSvrSCLxp9BrFOtEHtndAY9 tOab0XePqS6ltKNReKX/JL7bPC5Ra8dJPOp3WKXwS8J3RktzITK+j0nQpu9se5jObn2u QQPviidzCi5bFCQ9t2rLEBrBB60NAI0zHvY5qmFfe+JTUg1qc7sw+7u5xxz/RHgboLlt hM0g3inPjbxykyMU2XywWDKa081dPHNzP17ngtPKgA5pFbiRrX7Q9bpJA0ijB2UiJ+NZ YOmLrFQgZ1KTpr4EXsNiYDkpydFafygHtdi/XNkrkSCKpLKD+yLJS4GWT4bg83pu+iTZ ROUQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=AM9dGkt+; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id m2si3375476otk.122.2019.12.04.10.25.29; Wed, 04 Dec 2019 10:25:29 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=AM9dGkt+; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728381AbfLDSBG (ORCPT + 27 others); Wed, 4 Dec 2019 13:01:06 -0500 Received: from mail.kernel.org ([198.145.29.99]:40756 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729483AbfLDSBC (ORCPT ); Wed, 4 Dec 2019 13:01:02 -0500 Received: from localhost (unknown [217.68.49.72]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 04E2B20659; Wed, 4 Dec 2019 18:01:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1575482462; bh=O4H8gKKIofBTYa/ahR2HGrSqNn62ReqrOkWXmkecmG8=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=AM9dGkt+kmr0nHI4qgkoQnE580QpO/sjIQW2hg+lOe9dmffVAVQ+CMl8WY97eD7PC l+fwJh28t89sSwHvgjP/zHFvl7GJxTrZ2Z19Pu+MR7UeEGImW4CUnwO5NowPvMtDRp /SQHl/KY0HwXBXmMDmDwmVlC5P2K8htpIQRFTv2o= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Lionel Debieve , Herbert Xu , Mathieu Poirier Subject: [PATCH 4.4 91/92] hwrng: stm32 - fix unbalanced pm_runtime_enable Date: Wed, 4 Dec 2019 18:50:31 +0100 Message-Id: <20191204174335.613659568@linuxfoundation.org> X-Mailer: git-send-email 2.24.0 In-Reply-To: <20191204174327.215426506@linuxfoundation.org> References: <20191204174327.215426506@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Lionel Debieve commit af0d4442dd6813de6e77309063beb064fa8e89ae upstream. No remove function implemented yet in the driver. Without remove function, the pm_runtime implementation complains when removing and probing again the driver. Signed-off-by: Lionel Debieve Signed-off-by: Herbert Xu Signed-off-by: Mathieu Poirier Signed-off-by: Greg Kroah-Hartman --- drivers/char/hw_random/stm32-rng.c | 8 ++++++++ 1 file changed, 8 insertions(+) --- a/drivers/char/hw_random/stm32-rng.c +++ b/drivers/char/hw_random/stm32-rng.c @@ -166,6 +166,13 @@ static int stm32_rng_probe(struct platfo return devm_hwrng_register(dev, &priv->rng); } +static int stm32_rng_remove(struct platform_device *ofdev) +{ + pm_runtime_disable(&ofdev->dev); + + return 0; +} + #ifdef CONFIG_PM static int stm32_rng_runtime_suspend(struct device *dev) { @@ -202,6 +209,7 @@ static struct platform_driver stm32_rng_ .of_match_table = stm32_rng_match, }, .probe = stm32_rng_probe, + .remove = stm32_rng_remove, }; module_platform_driver(stm32_rng_driver);