From patchwork Mon Oct 28 03:39:26 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Nick Hu X-Patchwork-Id: 839281 Received: from mail-pj1-f52.google.com (mail-pj1-f52.google.com [209.85.216.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A5688188A18 for ; Mon, 28 Oct 2024 03:39:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.52 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1730086789; cv=none; b=lOqKduI0xK2/TKZ8Y4Jic0xfU9ca9bdgMWGwpbkafJvfFk1ESdDHEDEWGcD/bihxZQknhBZdfGdwJuySTUCyGHGRTHs04sU8wxjcuah3GMUW/0X/Y39x9NzMsUfgnuKQOXydrhN72XsAthiSnjdhCsaxAGzoZbQ9de7j/8xY1Tw= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1730086789; c=relaxed/simple; bh=KZDYF/jddIYvikTmAtIIGcfQR++5pOmWB1T42u1iP6E=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=LsnrirYgYaRaGM5SzRc1rUgxGMqSOC86+ZsOtiZJQmkNWTslmQQLRAGtA0254GO88QkFPgm05YzW8uL9F9Jo187u74a8FSzlXOQ4hPIIzGGE3DA6B5kaA1yKCidoP1k3fCRg5vCxhhRtJdjDf9ApZoIqN9VUyq5rn/+w9lvijFI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=sifive.com; spf=pass smtp.mailfrom=sifive.com; dkim=pass (2048-bit key) header.d=sifive.com header.i=@sifive.com header.b=isYBWge8; arc=none smtp.client-ip=209.85.216.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=sifive.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=sifive.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=sifive.com header.i=@sifive.com header.b="isYBWge8" Received: by mail-pj1-f52.google.com with SMTP id 98e67ed59e1d1-2e3d523a24dso2878063a91.0 for ; Sun, 27 Oct 2024 20:39:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sifive.com; s=google; t=1730086787; x=1730691587; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=ARDip39wIVC1qk/I+1tz8/feGtYsfateMnYyYJ2nUtE=; b=isYBWge8LIdvrm7FIYkezvG8T+pxsE8EX2x48dmBcUUFNweE3nGhpS64P36Tu9f5Zo b37IqGjHFaKd+cQd+ikjHGqxgb1MPbX5hcb6jx113CB0fbySStSKxFDi3aB41OFo3C38 WdHwkRfLp8So9vklWC6OSv9YpylbBDZ/xtjHR9vHja97TYzFz26LaDVbJq764x7plm9h X1mI4MWKgTwdAeD+ULTJ5ppEJbneZuu11uhngex7E61fOL/WyZI/Vu8M4QZ4PiGgjjah fd1Vob5lCNxShUjqqUhDV1w5kQaIt02YEfWry+qeGKwosyCin6e/13xqkRT3lN2uW91b Smfg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1730086787; x=1730691587; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ARDip39wIVC1qk/I+1tz8/feGtYsfateMnYyYJ2nUtE=; b=oq9wYtrAyVYzfMPRLPku2KX0NdgqkgqLLoMUxZbHdsjHG/o3wy2Xg0KYE4GghRV5sj UKVGTFOjmkEQLyu3Jf6W6x88v48AGU3wDFcROvzHX32erYdEp8FnJSd2stfQzCQ7x96X K+uM1RDYLIdlOHwwelQyCvTHlpmUkCDwBdD48Ha4LiQhrCynzrHirE/zE153Oxp+X34M zBpQT94/jyQX4luvAFLl3vZb2licA8CZkXBVsU4Ta0SGhEpDz0xoIs/x8WCGYtNz1NrO OLhJoXd1wCUJK3L19LrLOnTd3lzU+fngf6Tix3qHAWd8G8AfYI5C9OldzjwPPmti4TEu XV/g== X-Forwarded-Encrypted: i=1; AJvYcCU/feE+A3REecQmJD0gzdIK7d2MN5maoQvK/ymr7zNUGDZ3q2LEjsM0wJ59XySGzdpiRQYub298Fw==@vger.kernel.org X-Gm-Message-State: AOJu0Yyp+5hZkBuOV1bSpe1Kv9Zcpe4pZAbG9VmM7KwuyFsO7xzs+B/z Elat6NAOLDngHbRL3PH1dXRpsa06qTl4EZXNclUJYttdckxTZaXtfCDr7TuawvM= X-Google-Smtp-Source: AGHT+IHaM+aLcSm1w4qstTcoHx8cZ8OUu/YAd0POOhZWcxfHlNfvpu6ayZbkZQqDbe3fkAu25t7G5Q== X-Received: by 2002:a17:90a:b109:b0:2e2:da81:40ca with SMTP id 98e67ed59e1d1-2e8f104cb14mr8132454a91.2.1730086786918; Sun, 27 Oct 2024 20:39:46 -0700 (PDT) Received: from hsinchu35-syssw01.internal.sifive.com (59-124-168-89.hinet-ip.hinet.net. [59.124.168.89]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-2e8e340e544sm5961888a91.0.2024.10.27.20.39.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 27 Oct 2024 20:39:46 -0700 (PDT) From: Nick Hu To: greentime.hu@sifive.com, zong.li@sifive.com, "Rafael J. Wysocki" , Pavel Machek , Paul Walmsley , Palmer Dabbelt , Albert Ou , Daniel Lezcano , Thomas Gleixner , Andrew Jones , Conor Dooley , Samuel Holland , Nick Hu , Sunil V L , linux-pm@vger.kernel.org, linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org Cc: Anup Patel Subject: [PATCH v3 2/2] clocksource/drivers/timer-riscv: Stop stimecmp when cpu hotplug Date: Mon, 28 Oct 2024 11:39:26 +0800 Message-Id: <20241028033928.223218-3-nick.hu@sifive.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20241028033928.223218-1-nick.hu@sifive.com> References: <20241028033928.223218-1-nick.hu@sifive.com> Precedence: bulk X-Mailing-List: linux-pm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Stop the timer when the cpu is going to be offline otherwise the timer interrupt may be pending while performing power-down. Suggested-by: Anup Patel Link: https://lore.kernel.org/lkml/20240829033904.477200-3-nick.hu@sifive.com/T/#u Signed-off-by: Nick Hu Reviewed-by: Anup Patel --- drivers/clocksource/timer-riscv.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/drivers/clocksource/timer-riscv.c b/drivers/clocksource/timer-riscv.c index 48ce50c5f5e6..166dee14e46b 100644 --- a/drivers/clocksource/timer-riscv.c +++ b/drivers/clocksource/timer-riscv.c @@ -127,6 +127,12 @@ static int riscv_timer_starting_cpu(unsigned int cpu) static int riscv_timer_dying_cpu(unsigned int cpu) { disable_percpu_irq(riscv_clock_event_irq); + /* + * Stop the timer when the cpu is going to be offline otherwise + * the timer interrupt may be pending while performing power-down. + */ + riscv_clock_event_stop(); + return 0; }