From patchwork Fri Oct 4 12:36:56 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Lad, Prabhakar" X-Patchwork-Id: 832838 Received: from mail-ej1-f43.google.com (mail-ej1-f43.google.com [209.85.218.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 04C451D271C; Fri, 4 Oct 2024 12:37:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.43 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1728045435; cv=none; b=N29cvEqP8RF5x84WSJ7IWSJRoErzqG71CCpGoBzjFExntB2u5xhEuDm9Ur5Avi0JKBSBmqRIQPYPfptLUKYvjZkogpCQbk0kNbtazpMdXZIbcv7JQyZFPP7qThELU/3JlxE47U1tzaXmscJfFKniutpHQA3FqCKzaDxK6r4noWI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1728045435; c=relaxed/simple; bh=iDa4q0EGy+SOCPsH7APipW+rwuIfD0+r8FuA8LgXyk8=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=tImLyZT5u6WxOp5tpjp9TzW1VIm4O5W83u7USsG0Bl5tBWBkiugVSCqi1ia2HKxJBDKPfTC+++qzuS55FDsYJtkdvQ0lV39913zHL0Hm1dfHZxCMeTWQexp+VcTLT+7mFksBmJKjebiCc/HO9T+dQoar47wDFduUK1K71aXcFF4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=M2xEE+HV; arc=none smtp.client-ip=209.85.218.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="M2xEE+HV" Received: by mail-ej1-f43.google.com with SMTP id a640c23a62f3a-a8d3cde1103so268708466b.2; Fri, 04 Oct 2024 05:37:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1728045432; x=1728650232; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=PHNka6klozf6Nlp3gQ5Dw96SnP2dpYHmui1gZbUUuHI=; b=M2xEE+HVL3GJIPg4icEzbJXFArYPz9yIzjw+2MNcvYBqoAEpR9MMl8b/Y7nWmdQ4mG NEqm83OObdnKBPxTkj/mGuViI1Nmqhayij8uqXXfad6r7MqRuS+LEoCeL9Y8FkO+1UNz jBnMG3g/38jOz5c3Ihb40g7wFDMEl1dAKqFOoezCvliEXgvmrF4QXuuDDPfA3b3wmS64 P/PPTJ+72eAgsgByLuytcVkeBK3Hz4t1JamzxB44kmLV3Yowz2bD6T+4y+geDi3V/6M0 M742/8IDaPr/0JSp6qOzs8VK4s+oRbgjBe2JGtfBJ6S3SF2tVLWbmybYJEcKhWfKK3J4 Hu0A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1728045432; x=1728650232; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=PHNka6klozf6Nlp3gQ5Dw96SnP2dpYHmui1gZbUUuHI=; b=ScyaSnWGv/b0N0CC/ecEpiacK0Ugl+h81hNmfuHqojxxkUg3uEKtyoxD3r3GUw7EuP 09F0I4EHOF7hEKaGcswg2/tEeY7jhl1xvyKaxWrIb0zuLVJMRDRte4h/j5EeNvGma9wv N8PI2Czw7Yl89gVBtcisFMoU41ZASTEgXjIE/aTT+V2SJ45Mga+63TDXpOryRX1b7QPO jxS3U51QREXvrw5jBg27EKFcKzMYjXDBgGniuw7WmlDAkB9HIIwGTZzCzXc26W6YoRm8 Kq0VR1mmEYg7JPGhPFrsl18RQEVxmD7ZTALoUt3k18fKQc8l2VxegYj5chy4/Xt4nh3C 0Q4Q== X-Forwarded-Encrypted: i=1; AJvYcCURnmgscBZ5TbLbLOPaNaZofHAxoMb94Z0yy+0baP5FHljIBhMlLrJs16FN0yxiRbEah8Ree7pV7HS+IPGtWfEeqXg=@vger.kernel.org, AJvYcCWVbIrFvq32Bj62Gwh7YfP9E3iDk2ayyFPkkCY+99K+ZoXTyIRdo9twfV/NQUjF9+xPaDcITJsvEqgD@vger.kernel.org, AJvYcCXAKtfU+perE17FYsvhrfC/ZAwhQplZE1ysMsgPiHhl0lqGGGJuvNtSQv8jyvRlWT8mmK9GiC6V1eqbNvO4@vger.kernel.org X-Gm-Message-State: AOJu0YxJGg2Z0s/lv94xjMBRgJEbEiQKZwmoC7ghkI8MGnXWBJJQkgV0 FVopmnyvbi5mLj/vynzhT49sjeX/6PV0aG1lVT4pmq2gvb3wzpVTISjMdg== X-Google-Smtp-Source: AGHT+IGmgImN/5525gLT2kNV35K/3qFRa9LF8GZwEMOHSYlTb39Sdf2SmRsNsx8wg+Sd8XsboaEfcA== X-Received: by 2002:a17:907:3d8d:b0:a8d:1284:6de5 with SMTP id a640c23a62f3a-a991bd3fc29mr269025466b.14.1728045432054; Fri, 04 Oct 2024 05:37:12 -0700 (PDT) Received: from prasmi.home ([2a00:23c8:2500:a01:2595:4364:d152:dff3]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-a9910285ad0sm221601166b.34.2024.10.04.05.37.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 04 Oct 2024 05:37:11 -0700 (PDT) From: Prabhakar X-Google-Original-From: Prabhakar To: Geert Uytterhoeven , Linus Walleij , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Magnus Damm Cc: devicetree@vger.kernel.org, linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-renesas-soc@vger.kernel.org, Prabhakar , Biju Das , Fabrizio Castro , Lad Prabhakar Subject: [PATCH v2 1/3] dt-bindings: pinctrl: renesas,rzg2l-pinctrl: Allow schmitt and open drain properties Date: Fri, 4 Oct 2024 13:36:56 +0100 Message-ID: <20241004123658.764557-2-prabhakar.mahadev-lad.rj@bp.renesas.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20241004123658.764557-1-prabhakar.mahadev-lad.rj@bp.renesas.com> References: <20241004123658.764557-1-prabhakar.mahadev-lad.rj@bp.renesas.com> Precedence: bulk X-Mailing-List: linux-gpio@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 From: Lad Prabhakar On the RZ/V2H(P) SoC we can configure the 'input-schmitt-{enable,disable}' , 'drive-open-drain' and 'drive-push-pull' of multiplexed pins. Update the binding documentation to include these properties. Signed-off-by: Lad Prabhakar --- Hi Rob, I have dropped your Ack from v1 as I have updated the commit message and included `drive-push-pull` property in v2. Cheers, Prabhakar v1->v2 - Added `drive-push-pull` property --- .../devicetree/bindings/pinctrl/renesas,rzg2l-pinctrl.yaml | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/Documentation/devicetree/bindings/pinctrl/renesas,rzg2l-pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/renesas,rzg2l-pinctrl.yaml index 56d90c8e1fa3..a1805b6e3f63 100644 --- a/Documentation/devicetree/bindings/pinctrl/renesas,rzg2l-pinctrl.yaml +++ b/Documentation/devicetree/bindings/pinctrl/renesas,rzg2l-pinctrl.yaml @@ -119,6 +119,10 @@ additionalProperties: bias-disable: true bias-pull-down: true bias-pull-up: true + input-schmitt-enable: true + input-schmitt-disable: true + drive-open-drain: true + drive-push-pull: true renesas,output-impedance: description: Output impedance for pins on the RZ/V2H(P) SoC. The value provided by this From patchwork Fri Oct 4 12:36:58 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Lad, Prabhakar" X-Patchwork-Id: 832837 Received: from mail-ej1-f53.google.com (mail-ej1-f53.google.com [209.85.218.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 395A31D45E2; Fri, 4 Oct 2024 12:37:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.53 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1728045441; cv=none; b=l+Wb2M9hmlozxswODoIEd7ZcRtl5w4yZ+M4imZtjTLQwy0gO7svTSBCaM5+skJDUIw+FMCLN+uo7SHOT5KMEA0eYQmTuj81meUwT8qJi8HCGVLsrm0dcQ/MCgUT8mZTT+jESv4I13DQpHJnj1lpK1vTUs7F1IFa6MwRGY4ELskc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1728045441; c=relaxed/simple; bh=5QsFlrsVLsZwdtZp6mO6Us/52BhYyLYRdllWADfop4Q=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Uj/QQXr0uimt2DWXTMRkiHThgL0RtiDgRS9cUwU2D4Z5OyJvudbVKVjFJJ6FGOZQsIo8QwJpKUXy2BDgXHjTSLzb6skltyPOIezbZX5jYkUbfjUGBFHgGlMJHVU/yilvvgTMwfKHRXocQ/gQjeCKfxKADFbnuXNQ+crOUsJdaIs= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=iiWD+TyG; arc=none smtp.client-ip=209.85.218.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="iiWD+TyG" Received: by mail-ej1-f53.google.com with SMTP id a640c23a62f3a-a8d4093722bso295686266b.0; Fri, 04 Oct 2024 05:37:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1728045435; x=1728650235; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=I9LcPLLxPDaleyrFMUiTMF5QBxTx4spV5s9XLwwB+E0=; b=iiWD+TyGUqMCdR8Mf5U8JDaNZ98Eeiz+4PmWwg1wF3zXAax8jyxIbhHEGnMcuTlavi py847D+gHpoBRLaIYlfH0EV1JTl8JuIOSG7NxTS/JcGMhNGjSPSxevH2HKt1k0Qai1Il wUBRK9VydnWzdSumRT+DVUA+Wr+O6hWbK+XHc0tzmgCdw4xeCNQ+ZGEy2vQZ9ff8W8zE JHibGn7z3llEqh+q0UR7+AmD4jnEzi/io8aAruD2n5AokO613dVzOPbzp5ojdYuOn4lX 12nK6gYFzJqVO9BCxVtNdyThUV/nnaEiiOY4QDKr0rzyFWGqy0ysf6AnhW4IPc9uaPl2 knMA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1728045435; x=1728650235; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=I9LcPLLxPDaleyrFMUiTMF5QBxTx4spV5s9XLwwB+E0=; b=kyCEr+HHFx6a2AxUZtp0Hgvj9SUa3Apzaj4VcYsvEU3iN0K9EwbdAm9LtbES57kjp5 ZrHVuk6wyGHOs4LT9J0ADzfZGfAyELHIWcOl/tmwBZ5P7ivlaHvRghJxdrOWgchPD6MO wpdzjD/0wXdjXMRvTR8m16KkxE416q9EbvBr5+9WK7S6i3HjugTguLaBfhfApWNG1Crv 10yFs6axVa02IeD0z7M+afqhLW/GkyHyNFJ2+VFtGAPyYy89iTyANFV90RgG3hojnIS4 /ac3AVFjFyrnDx+rT0Fxq35McwxI2rS2xaV6CYD+7syjq2Lg3yl2VQb9jh/NPDz7jByY FNlA== X-Forwarded-Encrypted: i=1; AJvYcCUhRYcPLfPQnRyu4C2AhDoDs/CWibKG2riNpm0LrUXiMvW+d4atEaL5AEOsBsXaUz1JATBfjAhBEGgu@vger.kernel.org, AJvYcCV37QvoGybm0XwUaYcOtWsqUZLPcYbwpAeGwdGqCLAp5sEHvdnhDEixUaiJ01hFUG8M3G8jK5H9Ryevyq4G9Od9u9U=@vger.kernel.org, AJvYcCWe2dhStzsH9KAtQD2T4fP/Z1fvG7kXiPKvScTvhpf3fV1NEzRuUdlnADyBPHLIgEE8+dwMD9bACEmBv2Id@vger.kernel.org X-Gm-Message-State: AOJu0Yzj9RXdIwL5SAMrk7IviWvckjnhvZZQs9esGlNg1FBAMeVF7Kma jSO5RX14k4cUlYVMvhLr+j7vzKO8dWMctw72ualElMR2riGt+zRIjDXhCA== X-Google-Smtp-Source: AGHT+IHLKLaCyBdWJkVQ/RWROmiZmQC/XbMI9u2WV+co1SXbpQize0ns7wnFfIKxX37ujJwAkGHsww== X-Received: by 2002:a17:907:7203:b0:a90:c411:24fd with SMTP id a640c23a62f3a-a991bd052ddmr266321266b.10.1728045435142; Fri, 04 Oct 2024 05:37:15 -0700 (PDT) Received: from prasmi.home ([2a00:23c8:2500:a01:2595:4364:d152:dff3]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-a9910285ad0sm221601166b.34.2024.10.04.05.37.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 04 Oct 2024 05:37:14 -0700 (PDT) From: Prabhakar X-Google-Original-From: Prabhakar To: Geert Uytterhoeven , Linus Walleij , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Magnus Damm Cc: devicetree@vger.kernel.org, linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-renesas-soc@vger.kernel.org, Prabhakar , Biju Das , Fabrizio Castro , Lad Prabhakar Subject: [PATCH v2 3/3] pinctrl: renesas: rzg2l: Add support for configuring schmitt-trigger Date: Fri, 4 Oct 2024 13:36:58 +0100 Message-ID: <20241004123658.764557-4-prabhakar.mahadev-lad.rj@bp.renesas.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20241004123658.764557-1-prabhakar.mahadev-lad.rj@bp.renesas.com> References: <20241004123658.764557-1-prabhakar.mahadev-lad.rj@bp.renesas.com> Precedence: bulk X-Mailing-List: linux-gpio@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 From: Lad Prabhakar Add support for configuring the multiplexed pins as schmitt-trigger inputs. Signed-off-by: Lad Prabhakar Reviewed-by: Geert Uytterhoeven --- v1->v2 - Included RB tag --- drivers/pinctrl/renesas/pinctrl-rzg2l.c | 18 ++++++++++++++++++ 1 file changed, 18 insertions(+) diff --git a/drivers/pinctrl/renesas/pinctrl-rzg2l.c b/drivers/pinctrl/renesas/pinctrl-rzg2l.c index 8d576cc74003..13708c71f938 100644 --- a/drivers/pinctrl/renesas/pinctrl-rzg2l.c +++ b/drivers/pinctrl/renesas/pinctrl-rzg2l.c @@ -140,6 +140,7 @@ #define PUPD(off) (0x1C00 + (off) * 8) #define ISEL(off) (0x2C00 + (off) * 8) #define NOD(off) (0x3000 + (off) * 8) +#define SMT(off) (0x3400 + (off) * 8) #define SD_CH(off, ch) ((off) + (ch) * 4) #define ETH_POC(off, ch) ((off) + (ch) * 4) #define QSPI (0x3008) @@ -162,6 +163,7 @@ #define SR_MASK 0x01 #define PUPD_MASK 0x03 #define NOD_MASK 0x01 +#define SMT_MASK 0x01 #define PM_INPUT 0x1 #define PM_OUTPUT 0x2 @@ -1351,6 +1353,15 @@ static int rzg2l_pinctrl_pinconf_get(struct pinctrl_dev *pctldev, return -EINVAL; break; + case PIN_CONFIG_INPUT_SCHMITT_ENABLE: + if (!(cfg & PIN_CFG_SMT)) + return -EINVAL; + + arg = rzg2l_read_pin_config(pctrl, SMT(off), bit, SMT_MASK); + if (!arg) + return -EINVAL; + break; + case RENESAS_RZV2H_PIN_CONFIG_OUTPUT_IMPEDANCE: if (!(cfg & PIN_CFG_IOLH_RZV2H)) return -EINVAL; @@ -1489,6 +1500,13 @@ static int rzg2l_pinctrl_pinconf_set(struct pinctrl_dev *pctldev, param == PIN_CONFIG_DRIVE_OPEN_DRAIN ? 1 : 0); break; + case PIN_CONFIG_INPUT_SCHMITT_ENABLE: + if (!(cfg & PIN_CFG_SMT)) + return -EINVAL; + + rzg2l_rmw_pin_config(pctrl, SMT(off), bit, SMT_MASK, arg); + break; + case RENESAS_RZV2H_PIN_CONFIG_OUTPUT_IMPEDANCE: if (!(cfg & PIN_CFG_IOLH_RZV2H)) return -EINVAL;