From patchwork Fri Sep 27 10:02:32 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ricardo Ribalda X-Patchwork-Id: 831243 Received: from mail-qt1-f180.google.com (mail-qt1-f180.google.com [209.85.160.180]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BE4031BB680 for ; Fri, 27 Sep 2024 10:02:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.160.180 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1727431365; cv=none; b=mQTcWUR8NtaJJWWEnurYAWglirL9UsTrxV4WrDw4iJfKWrEeX4ldAPf6F6cx44ePl2KT5bHIf0liF8tPCPnz+gLk8o3qAkZqYokMU6XORIQEY3JJwtR0w+93sECJWu03i/VXrVx6MJAioCRhVDBZLA0NFoCEVgs3/tfYkIIchxE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1727431365; c=relaxed/simple; bh=NzGO/n5w0inQUSk9Mrg2JWrHNdom3NBH7egriAh15og=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=Z0tpPa/bAOVONeMtCgndb3wEtPLBgAG1m1/55p911pCqgAPeRPsQTfQ8sLKRfw/HxBzfwcD0Fw0+2HnAxv8ormIMytTe03ciNHH+EsJL0s64QIDNbuuGZQUfJByWQdi8jUNJ7TCeqWra4jhUAXYtFJrqkcLGowDCFoP/u7XopxA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org; spf=pass smtp.mailfrom=chromium.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b=gJvvCEZn; arc=none smtp.client-ip=209.85.160.180 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=chromium.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="gJvvCEZn" Received: by mail-qt1-f180.google.com with SMTP id d75a77b69052e-457ce5fda1aso14542421cf.1 for ; Fri, 27 Sep 2024 03:02:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1727431363; x=1728036163; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=YwJYpIvOPMah9ocVmXZ/vnejPzGmcFsHFsHmC+ou0no=; b=gJvvCEZntTJEMer4VufqglsmJ0gIHevwjXMbdMzjWaVqnt7cWdWKGZkQ8zilkiEIya jbzzJIRhD6N6lr/5H/WayIYJAfsou3RmraN0o98BHgstq39xQLtO7XOZZEUrpH2F62KH gqaVVTOgKu4D1La8fU19sOqpjfm3Tfl3teFMQ= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1727431363; x=1728036163; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=YwJYpIvOPMah9ocVmXZ/vnejPzGmcFsHFsHmC+ou0no=; b=bs7nLA4qDMYfkK0HNWKuzMtP5leJWiu3Z9hmZQX102nxJDrQJCnJBTgy+aVMmEuhCJ lDJyNs2uK48veH6G5iLKifWWb+hxAGKabjQ24WbamCgu1KaMdWTfxPFPEsQlUnR8gp/X owaVEmZcWy890GMKZ3X2Tkngdgf3pN/sl0QyjtCbOX16JVn6UPZT/IXLnJRadABB66Kt tAkaGZnmaMBKTqwIhusrWIO25eXRYjNtwgudFr55KtSLtOO0SWA+Hx1H4+n+Fkc33HUv ZDgNt54jOTAh8eIQ2lyQfTM5/971ul8hiFXlpuDp20LP/9YGijcXtPuzjz9h/+fn1r6T czQw== X-Gm-Message-State: AOJu0YxGqTf4VRTzitmkD6EMKnXFDxMw/kBwxYQkEaSBi9+H8zJUClJx hnqHLQWrCjBNMMeiNUjNGOiu+0QeiLCtf4r6Ngj28yl1ZFoPcHO6xCjRKopS8g== X-Google-Smtp-Source: AGHT+IHIhHVv8+j4NztQAIQhmr+1bNXNkJaWVfqmXRAU1YfyFDkrgQwJlMA6+y72ZjS/zMeolaZGXg== X-Received: by 2002:a05:622a:1208:b0:456:7fb5:1bdb with SMTP id d75a77b69052e-45c9f0aae7emr47154531cf.0.1727431362859; Fri, 27 Sep 2024 03:02:42 -0700 (PDT) Received: from denia.c.googlers.com (76.224.245.35.bc.googleusercontent.com. [35.245.224.76]) by smtp.gmail.com with ESMTPSA id d75a77b69052e-45c9f353f08sm6341091cf.94.2024.09.27.03.02.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 27 Sep 2024 03:02:41 -0700 (PDT) From: Ricardo Ribalda Date: Fri, 27 Sep 2024 10:02:32 +0000 Subject: [PATCH v2 1/3] media: ti: cal: Use str_up_down() Precedence: bulk X-Mailing-List: linux-media@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20240927-cocci-6-12-v2-1-1c6ad931959b@chromium.org> References: <20240927-cocci-6-12-v2-0-1c6ad931959b@chromium.org> In-Reply-To: <20240927-cocci-6-12-v2-0-1c6ad931959b@chromium.org> To: Benoit Parrot , Mauro Carvalho Chehab , Sakari Ailus , Bingbu Cao , Tianshu Qiu , Greg Kroah-Hartman , Hans de Goede , Andy Shevchenko , Hans Verkuil Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, linux-staging@lists.linux.dev, Ricardo Ribalda X-Mailer: b4 0.13.0 The str_up_down() helper simplifies the code and fixes the following cocci warning: drivers/media/platform/ti/cal/cal-camerarx.c:194:3-9: opportunity for str_up_down(enable) Signed-off-by: Ricardo Ribalda --- drivers/media/platform/ti/cal/cal-camerarx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/platform/ti/cal/cal-camerarx.c b/drivers/media/platform/ti/cal/cal-camerarx.c index 42dfe08b765f..ba8c4743f539 100644 --- a/drivers/media/platform/ti/cal/cal-camerarx.c +++ b/drivers/media/platform/ti/cal/cal-camerarx.c @@ -191,7 +191,7 @@ static void cal_camerarx_power(struct cal_camerarx *phy, bool enable) if (i == 10) phy_err(phy, "Failed to power %s complexio\n", - enable ? "up" : "down"); + str_up_down(enable); } static void cal_camerarx_wait_reset(struct cal_camerarx *phy) From patchwork Fri Sep 27 10:02:33 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ricardo Ribalda X-Patchwork-Id: 831119 Received: from mail-qt1-f170.google.com (mail-qt1-f170.google.com [209.85.160.170]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E1E211BC9EC for ; Fri, 27 Sep 2024 10:02:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.160.170 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1727431367; cv=none; b=aA5kdvGxQ+VOhfv24xb8XasE2nBWnLfg05czT8PrD0QClvhex9SMKanmVL3AHMuNs8rKyUdqB9MtbqKeQDMZgJwKX2PbHABQFJROtDjsKAIEArkGeenkIBtZsN29NRxKnmbkqBgcQnvK+GI6NcWzwOtVx/Hmvs305Fc0eUFDKtE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1727431367; c=relaxed/simple; bh=PTbEhgOwL2JzDldEWOrtkAWFRntEHE0H3eDBOM54qRY=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=Ff8TFpRJFm8fzOK7XDrdR1nYN9ZQkRoFss1KZqFJq7CQwLec5sgOwQ0zEPZjWd4BVn71P12QElqGnRQuk4iNUoedUmka1VsKjZOcQ07aktN69tWrwW6+jmFdLhkUIQx54i9DrP+OxgnZbpz8MaeXM24K61faKxKkxXFjy2xQQGI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org; spf=pass smtp.mailfrom=chromium.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b=a3tTt5t9; arc=none smtp.client-ip=209.85.160.170 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=chromium.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="a3tTt5t9" Received: by mail-qt1-f170.google.com with SMTP id d75a77b69052e-45826431d4bso12925941cf.0 for ; Fri, 27 Sep 2024 03:02:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1727431365; x=1728036165; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=1m9W940jAO+8Km9/nF0drShVWDtg5UbNpWglt9zOgsU=; b=a3tTt5t93SX+WJiy/eM2VdHPItce4H9jkbXH8lUDzqUTAnnEmOVP+qf8HGAUSQ5MOm 7UxPsLli8cxjMmBsjDQo4dPbofZUl1+Tab/pGF9dyg5TZdhbjSMxCCScakRB6xYXD0Qv RKHNpI/72UtW651GohBNPHgrM8pAIYGpfNFtU= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1727431365; x=1728036165; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=1m9W940jAO+8Km9/nF0drShVWDtg5UbNpWglt9zOgsU=; b=jq2GWjN3JLXCwUCDyFznkSnuddiqOLwfWi4fqvmBNAacC8Ae1OzN7OUC8/Fq0tA/UI DuAKo8k765KBjeuWG5hc1sLBjpTVBq2hLfdyfFMX638IZ23VF+IlaMHMnEc7Pt7w7pTV 0/Gf5p6F/uf6MUZp6wI4kthvQyTxl2T5rQI/YQR1UZ5tu4EeX664LIufTqCQ1P5+1HJi QrvfACo4AIVcOLCswAXVsH8nsCv8NAp1/JnoH0xgjWv0KEejhR8Z4qrEaB1SdEsAlMRu pS5Q/N1zcsOkIdt4l1aVoue7tkFf0tqhgPSiZUH/480l2M1hhJ508BLYhAgn1hT7Sbkl E7dA== X-Gm-Message-State: AOJu0Yx/mmL+JZsd8UnqrCG4PY1ho/rhRC42YDGyPhfYVXYhGAWOxK7h L6ts0FwWRnza0RMxiYDPjDbWhPK3w/ecyIbVdge82d3XG2shnHQNHCQLrjyrrw== X-Google-Smtp-Source: AGHT+IH2sKCy00o9ozG8YLnnklYCCyOzAtra00mCyeon7eku4D7Kt0x2E5WOjSuFyndy4gbIgtSOMQ== X-Received: by 2002:a05:622a:1186:b0:45b:6042:be44 with SMTP id d75a77b69052e-45c9f270f47mr35119611cf.42.1727431364785; Fri, 27 Sep 2024 03:02:44 -0700 (PDT) Received: from denia.c.googlers.com (76.224.245.35.bc.googleusercontent.com. [35.245.224.76]) by smtp.gmail.com with ESMTPSA id d75a77b69052e-45c9f353f08sm6341091cf.94.2024.09.27.03.02.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 27 Sep 2024 03:02:43 -0700 (PDT) From: Ricardo Ribalda Date: Fri, 27 Sep 2024 10:02:33 +0000 Subject: [PATCH v2 2/3] staging: media: ipu3: Use str_down_up() Precedence: bulk X-Mailing-List: linux-media@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20240927-cocci-6-12-v2-2-1c6ad931959b@chromium.org> References: <20240927-cocci-6-12-v2-0-1c6ad931959b@chromium.org> In-Reply-To: <20240927-cocci-6-12-v2-0-1c6ad931959b@chromium.org> To: Benoit Parrot , Mauro Carvalho Chehab , Sakari Ailus , Bingbu Cao , Tianshu Qiu , Greg Kroah-Hartman , Hans de Goede , Andy Shevchenko , Hans Verkuil Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, linux-staging@lists.linux.dev, Ricardo Ribalda X-Mailer: b4 0.13.0 The str_down_up() helper simplifies the code and fixes the following cocci warning: drivers/staging/media/ipu3/ipu3-css.c:229:18-47: opportunity for str_down_up(state & IMGU_STATE_POWER_DOWN) Reviewed-by: Andy Shevchenko Signed-off-by: Ricardo Ribalda --- drivers/staging/media/ipu3/ipu3-css.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/media/ipu3/ipu3-css.c b/drivers/staging/media/ipu3/ipu3-css.c index 1b0a59b78949..bb22375481a0 100644 --- a/drivers/staging/media/ipu3/ipu3-css.c +++ b/drivers/staging/media/ipu3/ipu3-css.c @@ -226,7 +226,7 @@ int imgu_css_set_powerup(struct device *dev, void __iomem *base, state = readl(base + IMGU_REG_STATE); dev_dbg(dev, "CSS pm_ctrl 0x%x state 0x%x (power %s)\n", - pm_ctrl, state, state & IMGU_STATE_POWER_DOWN ? "down" : "up"); + pm_ctrl, state, str_down_up(state & IMGU_STATE_POWER_DOWN)); /* Power up CSS using wrapper */ if (state & IMGU_STATE_POWER_DOWN) { From patchwork Fri Sep 27 10:02:34 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ricardo Ribalda X-Patchwork-Id: 831242 Received: from mail-qv1-f54.google.com (mail-qv1-f54.google.com [209.85.219.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D163C1BD028 for ; Fri, 27 Sep 2024 10:02:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.219.54 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1727431370; cv=none; b=cO6mrgLEtMM4MCk2fs96HHMcUy8tjc1rKcrU+F48TjUc32UHReR+NkSZlQ1Jlw6mMoV1/ZUU7Te8PQC+QUroopPjceJROx5Y/yz2zHoS+LxSicXRXT3zHHtye3rWzDWOr0YppPnDwb4LVcvnwB7+5Uo10BAfx2/TvT+akMrSmoU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1727431370; c=relaxed/simple; bh=uw0K97JV9fivxdnVN2cUQwyp6nbgfNRKN3h76jkLFYY=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=lCULFzq55HSBWsGcK/j9qQI+CgS/GyQiJwXb+19E64Ep6wjoOHhZ7AuqL7kpoAxEVSDJn0sMUIUa6alanYDYKIfwJpEWRy7DHcRIXSLhLjzMqmWcaTRc84DnU+xHiOGbp/l6MRvLiA/1kjsx3+8LakmIrHWpt/VQAe+0mFWNsL0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org; spf=pass smtp.mailfrom=chromium.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b=WxQPytC6; arc=none smtp.client-ip=209.85.219.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=chromium.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="WxQPytC6" Received: by mail-qv1-f54.google.com with SMTP id 6a1803df08f44-6cb3062d9a6so13200016d6.0 for ; Fri, 27 Sep 2024 03:02:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1727431368; x=1728036168; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=mSjw1khDQimJSSBzxeMp5r4khGbQqGrktSmSipAyKGM=; b=WxQPytC6OZ04vlGKZs5Eg8aZM1+av+9SLcNLIeygjg1vxW5uOCmI/2ZvUDtUr/6Zcc NM9ql9qHlbmWUxxFRnGnhP71ses9FDo5Cqi6fdHGWN5CR6vM04i5aVlLjiZmxk4ZaQmF O9hbm/zC4b4QeqRFoEVRs92NUW2JEmeTY4gN4= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1727431368; x=1728036168; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=mSjw1khDQimJSSBzxeMp5r4khGbQqGrktSmSipAyKGM=; b=xITON5De9CjH47FAdsFZCZBYF+eM9DE8GboaYhz6tEzyf7I253xAkfoWtiJqfBYC/B f0RPSNrSNk1GYA1Ew887mw6NYLDTqyoe4Sr7ty9xzxAInIJkMLFkDOeu71P6KsKCYzdJ BmoFuXzSMcm4EcJcgcaQaY6gPErw7zEDyET6vyVNlTTv0YS+mHRXSxjoS1HPZNXUSOvP uXVHxhn28xK7SD4oGfNFJrmFFlv9wYLiBFHMbfnnaK9cBpWN9ez3Qcp1TbVAJW37hENe wCuAKPTXwbn53GeTd4S1SL/8zJ4WoPkZcdOLMjqYxY81/ICUnUvid54gPLC2Qpb5YGyL d3bA== X-Gm-Message-State: AOJu0YwNSBvhg+ImjEwgw6/bQpM3JLYCp1ViAr/nf9z2FRl67pelWq9S 7J8qRhkb29ZZ44wg06S+FYAU/+Iitf4+E+EZxlnmyaO9Y4JV+695CcVPZh2NOQ== X-Google-Smtp-Source: AGHT+IGmj2VIw5fwcR7lMfdlhGfeKlUZ5ZB5sGNgsSChCVQ89YCG0Pdjs36ucyYbgh9Wu38SUEf4+Q== X-Received: by 2002:a05:6214:3d8a:b0:6c5:3123:4efd with SMTP id 6a1803df08f44-6cb3b5b663bmr52445036d6.1.1727431367752; Fri, 27 Sep 2024 03:02:47 -0700 (PDT) Received: from denia.c.googlers.com (76.224.245.35.bc.googleusercontent.com. [35.245.224.76]) by smtp.gmail.com with ESMTPSA id d75a77b69052e-45c9f353f08sm6341091cf.94.2024.09.27.03.02.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 27 Sep 2024 03:02:46 -0700 (PDT) From: Ricardo Ribalda Date: Fri, 27 Sep 2024 10:02:34 +0000 Subject: [PATCH v2 3/3] media: atomisp: Use max() macros Precedence: bulk X-Mailing-List: linux-media@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20240927-cocci-6-12-v2-3-1c6ad931959b@chromium.org> References: <20240927-cocci-6-12-v2-0-1c6ad931959b@chromium.org> In-Reply-To: <20240927-cocci-6-12-v2-0-1c6ad931959b@chromium.org> To: Benoit Parrot , Mauro Carvalho Chehab , Sakari Ailus , Bingbu Cao , Tianshu Qiu , Greg Kroah-Hartman , Hans de Goede , Andy Shevchenko , Hans Verkuil Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, linux-staging@lists.linux.dev, Ricardo Ribalda X-Mailer: b4 0.13.0 The max() macro produce nicer code and also fixes the following cocci errors: drivers/staging/media/atomisp/pci/sh_css_frac.h:40:17-18: WARNING opportunity for max() drivers/staging/media/atomisp/pci/sh_css_frac.h:50:17-18: WARNING opportunity for max() Signed-off-by: Ricardo Ribalda --- drivers/staging/media/atomisp/pci/sh_css_frac.h | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/staging/media/atomisp/pci/sh_css_frac.h b/drivers/staging/media/atomisp/pci/sh_css_frac.h index 8ba65161f7a9..3191d2858f59 100644 --- a/drivers/staging/media/atomisp/pci/sh_css_frac.h +++ b/drivers/staging/media/atomisp/pci/sh_css_frac.h @@ -37,7 +37,8 @@ static inline int sDIGIT_FITTING(int v, int a, int b) int fit_shift = sFRACTION_BITS_FITTING(a) - b; v >>= sSHIFT; - v >>= fit_shift > 0 ? fit_shift : 0; + if (fit_shift > 0) + v >>= fit_shift; return clamp_t(int, v, sISP_VAL_MIN, sISP_VAL_MAX); } @@ -47,7 +48,8 @@ static inline unsigned int uDIGIT_FITTING(unsigned int v, int a, int b) int fit_shift = uFRACTION_BITS_FITTING(a) - b; v >>= uSHIFT; - v >>= fit_shift > 0 ? fit_shift : 0; + if (fit_shift > 0) + v >>= fit_shift; return clamp_t(unsigned int, v, uISP_VAL_MIN, uISP_VAL_MAX); }