From patchwork Fri Sep 27 04:22:16 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Michael Wu X-Patchwork-Id: 831370 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (mail-bn8nam12on2125.outbound.protection.outlook.com [40.107.237.125]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 41334175D2A; Fri, 27 Sep 2024 05:25:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.237.125 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1727414730; cv=fail; b=a7IyqxyyOXxnddx7J9VlCQDWmpIVXEZgxDq8LNVyXo1P3ABKRohf9knjUVmkK/na7elW0grBMIGUrcxMGHybCB4D+jvhAW9wuGUyQARIPW4TvMd5XlUOKkxZy2xNmJdV7Yve3edXpDiCK5k9qqmtjin48h0coicH/SaXw+oLzrE= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1727414730; c=relaxed/simple; bh=FjFBHd8GlrUZJGdbQwzFs15AuMCt8/AFfFjrB8fFYpI=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: Content-Type:MIME-Version; b=hR+VVLPPaeyhaX0r8Sy0d/xdXsGbUsMJm6HM9HhYM9q6kzlktkOGWtM/VIip6VKfsgA32JKnv1gUEfv+zFgNfQ9tmkhSIzv1MAn5Dx3NZpEI4AuYgmGrTGgE1cEHK/vtNtrrWeWwjw6fJ7wzLFNnqB4LKic6XZJ2sWwhbCJGi0g= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=kneron.us; spf=pass smtp.mailfrom=kneron.us; dkim=pass (1024-bit key) header.d=kneron.us header.i=@kneron.us header.b=Iw+QCB8m; arc=fail smtp.client-ip=40.107.237.125 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=kneron.us Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=kneron.us Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=kneron.us header.i=@kneron.us header.b="Iw+QCB8m" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=jgBFuSI8zIyils+0tsL8uLBKrJlMGO+2oxqc+yUfOKoRQuSCS89tt0ojKK3PtCyS+1MZet+veydQRwAor9vxCNJwODKoVyU0A918nny6GEHTmzW5zYqfqUvp+tvMeLqO8QqPnBxsH+QErAUiRMDaDNBocc0uT6rBUEvoNe2DBQoNZg5G7NPIoUfRUxahRRkAsvIgP6D3jfDZJs3NSkF7vyrEAXdJx0qhMFFgF59U3Ij0UUAyoXmlq0UWz+wA/MoqjGx9LHbxFL0+rz3Mz8Q5fjIRFFR5dpkr/lV4hX3lWO2Bv88t9UIjIfjdHPeckWk65CqAELi90C1o33jHOmrJ8w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=HAmHFh1Z2we5MDHU+2+oQ/Ra37Q49NuUbopL+1TwJdo=; b=Jzy2wFWwm5zO5IlSnwQadQy+1aJEDXUXWJWwGtVxUpHh6Ypq1n/VpesNFKwGxbJz+5hOyngM2QC/o/REL1NfjJzXRzVf9XtgQzWTin5F6VZ213PKkux/6/kMxg7o6g/GFSnw4/PxxxoU3zBYHuWxyakqLmKKkKNBJOWnQflXReFAkCX92icYNtQJEaJ6KXW6mcXGcDODrn8OavsvlPUcjoOhvItAGTbnwYSPm+gVLB/Y+eFsiAXKK9iJ8qq5dwVyeHoLL3bOBN2WYnV9j/zeyn5grpQhlN3ocUZ7z3rQ2guCAIYa/ccGnetHIQVtAxPcTo9O6ltT9HAlLQpcuTvQXA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=kneron.us; dmarc=pass action=none header.from=kneron.us; dkim=pass header.d=kneron.us; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kneron.us; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=HAmHFh1Z2we5MDHU+2+oQ/Ra37Q49NuUbopL+1TwJdo=; b=Iw+QCB8mmCnUqrV9Bxh3kIOUU9KYIE3GCpeV5OxPu4pFXq+FEpE1ONQljUXJO60qsP01dDdumV7TK6olWPja6baegurXLCwPJ0Jlab6DkvhVQHuk0a8+A8VOyIW8JwP6chkWlQFHooJUA+/7oM+tRp2//jih3HuesOAK9te7HiE= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=kneron.us; Received: from IA1PR14MB6224.namprd14.prod.outlook.com (2603:10b6:208:42b::6) by DM4PR14MB5526.namprd14.prod.outlook.com (2603:10b6:8:bf::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7982.28; Fri, 27 Sep 2024 05:25:26 +0000 Received: from IA1PR14MB6224.namprd14.prod.outlook.com ([fe80::c527:653c:698d:3d94]) by IA1PR14MB6224.namprd14.prod.outlook.com ([fe80::c527:653c:698d:3d94%3]) with mapi id 15.20.8005.021; Fri, 27 Sep 2024 05:25:26 +0000 From: Michael Wu To: Andi Shyti , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Jarkko Nikula , Andy Shevchenko , Mika Westerberg , Jan Dabros , linux-i2c@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Morgan Chang , mvp.kutali@gmail.com, Michael Wu Subject: [PATCH v2 1/2] dt-bindings: i2c: snps,designware-i2c: add bus-capacitance-pf and clk-freq-optimized Date: Fri, 27 Sep 2024 12:22:16 +0800 Message-ID: <20240927042230.277144-2-michael.wu@kneron.us> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240927042230.277144-1-michael.wu@kneron.us> References: <20240927042230.277144-1-michael.wu@kneron.us> X-ClientProxiedBy: TYAPR01CA0148.jpnprd01.prod.outlook.com (2603:1096:404:7e::16) To IA1PR14MB6224.namprd14.prod.outlook.com (2603:10b6:208:42b::6) Precedence: bulk X-Mailing-List: linux-i2c@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: IA1PR14MB6224:EE_|DM4PR14MB5526:EE_ X-MS-Office365-Filtering-Correlation-Id: ffa99bfd-9613-4c7e-362c-08dcdeb4cb57 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|366016|52116014|376014|7416014|1800799024|80162021|921020|38350700014; X-Microsoft-Antispam-Message-Info: 6rtkLE1SUsYPjpl7G5KWiLMVO+mz92PBIxWMnY1CO1RQVFhCbrMYA+v2UMXhp/fhh5jTsXrJRG41xSMJrrSJ1CT/qfSXvhZvClFc/ACZ6osiJejlCQTST+0h3DCanZ1bHfyBdxS4lhBNzGMb3HeG8NKiIWtXvpBrueEKWby7+/h7HPERjBF1zEbXRGLkV3IvVpDNSJgFpX6ysL75zUpQkxv5HHZibxyTXXV4c8QfC79EPGPRvkHy+6EWxeWWOF9NvqdZF45ljywBUT1kmuUPnylaQNHnAYJ6lP1sb7G301oq4Vps1OdgF/Gst07SQXcXMMkwjBkXOHYBSnS0V4VFoIincVki05gYDlDtntf7Qr0oQ8a/2tO0WiQFQtBficRI6pB+O1kg/qJxbE0yyoyfbfgS08qOp3VyW97g8hiaP/Y4H58kdwoGYgSrgH3ns1a6pbh2NcDxvS93AUTQAGTeMI8C6dtmRJRWgGe9WOi2EysO9u1tRfpL+l6Iuv0SQMVKWTE7lr6y3osuZ/91Uu4pGBXIBeifNbw7NFl2JzIQaLvtFhs5ix6QQRZir2wJ4GoExghiSC+j8u7vbKS70pBIMyhBPl7RCGBsYvsplWiqDrl4TLY20f5TkieE2vDdlktHv/8ta9nIasq95lZFcG2qeMEhOhRY0Y8rx24XXMRT07qIDTtDF7UHk/xWfMZ0Q7MID8LChq5qU5SDWakbR5kjNc0QWc2sNWCvo3//1RcvxKGxogcUGYDpmLdfhfDbz5R9HNnN2P19WyglVA+3HntrPcf1dJI0X+ThPJJN9UQgWHbyrUn58lM/uuplJKFqIktFmRO1HvDLkGXxpWzZIIE2+YT25TntkuL0oDK9lsS88cF5yGdYJqCM6rHJhW1BlqhrbhrnPiyn4TWwSUvcpkyDifmRxvU5GSbEGLiEfm7OqueNkraiSYeM8jBvWq6fbJy52BG2bIE8Mg6JD4TlFHQ+gsM7sT+V3CzCnVoH66rWtyg08ChILGNryARC/GYovX8d5sgBbJ+zXdSwzhwUU7GuUyLhV/X2oHXwWMoLTly/nwLqebEq8DBmjJ4uSOUMqQDl9oe/0pwLDSgxfjdBLEEe2ldiz8wSuoP3RBAcK6LJU1DwkVq74nyZ7SvtuOBOnBxlktd/LVANd3eL1lgk9nTqYGEPul2UFnVM0v16IJWMNRAbRgqLrdARZMDmbRCVP4CJFEhA99GWVxvn4cddrqcVzFCNnXGQ/Vp8+aT+pAnXI+T0un7NRr+MZvsNiVglPA2rqTKfcFMlUCy8aOvFhkDWWTvnMnwadjAN1KRYb3U+MgFQZz+Doi0sIM1n5+G8Ajp49W++QDScXCPJbbELKyHcMDQtXJd7FaXzBLgXZap7VqmFyy/uA6ov8DViVYb+Z6a1YSkzp+2eUcLxOxkcgpIYtJkcOOHdntngmfnzTE+ipWE36MqxoI6yahp3teXwd2Tx X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:IA1PR14MB6224.namprd14.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(366016)(52116014)(376014)(7416014)(1800799024)(80162021)(921020)(38350700014); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: jZ8txIOmJdpC8Ova//92kILAN4XVyiMvwvhip9brnspSrxT+Kiqd+LRYMXW6hf58gwUqTzHLiM6iBCm9zPf7U82v5ZEmpM8+YEOCDldIVZPprte6QRwe5sPmqpXYKw8hpntXe8JVN4hMHunbLTjAEaGys86k15zXPuXmqRURSN5uygNRbfmjsN5SVeCwgR7/XAlQmsIDrRkLRk9Kbi8mAo8iUnfH2eXwua43xp9SsOLq/Eg9Fh4+oDEjfYeWBmz+YcT0C2fDYzhbGgUBIH138TOuL0ifpZ0bGO0F0XemunPcX1b1QJWCDW/YcN73lq3wv+XsWiAWBiawUjqeuVF881+JpsUfE7CcLfMcaRaByZTnmZk//veQRKQBhlM9WFTAvmIsOv907NhBsPkYUl2sAYKvLWEBwaDt6Q47yLUtC+WCshtrNPeokhw2bVFVYx+4VDgZ0gXm9XeEmhJKpAvG9xjnrRkAmyaZeSQiOljJSlt1YlP1+qEJUwlpcTKXPcc6ylTQ0MUMbbouw9MSSrO85+2/S8NVqwpmZUBQ7Ws+gyQfIaiTFf9AZMNnq1GHFP3RU75MHEeXvvnJC28LaAsel7niEn1EQ7NQ4f4+DzZ+oSaZ56eMOEvzGEsdNnTUitm6L7EEYZzRIKxHRsAfKoxklhebxkouUgpBQPBEHKhuR38mS+zSCq5thajdcIAXCGhkT6LFZ5hOPh2aRS4Krt3m0GkOdLDVtW8GK1SMotHnNHwbgk9u/tWAmmXcjNCIIfgU1Y2cPAo/6XPejgTV7uWfTB+Yx5tIC4IRZ2mgod3AXCZyEpecuTmSKp2Nu2UwUVtU2zbsw0l/rRBjDb4vc3bUcgPfFkPzo7VMz4rAXGcThCzwGRdIpXqaNqO0TuPhlSkZK32dnXJGh/W3rQKAhFNPpVx8ShCZ0elj3hSH3NXT0qzaEp8AsF3XSUyAoIs9L6zXes+D9cpb55fGiq+8wP8XYUOgyiU3mLjydZGr96FvK2ZwKbCLO/Xb973m27BH+xVvJrfIYxQ696T9+jCUqa4wgCmwSVf68kCMoIJDVVn233S6Bfs25kWcYkS2xiW3OUpzAFEFVj9hkiPqlS8CVi52IVc5Y0YTTUXBpJSc9QUl6nYiTbdd3lN2/pof40ry6Oqm+b5nWlROhaPiW8IY99tSJGgari+RsYq3SSzPnLvq9Ecix+0IWnOaMv9bGlnO7VtRyo8e7fHzlVuHip+oAtqWvuHjg1KA20g8f2PY6FhDZVCiSjbCzGONpDUCfdV3Fy2OPTyd1Ghu6TOUZx1l7FgGA2XLzbVYfxJ9ub0tAsjRbcioxDjcPUpN2U0Bi+BxO22Z6eb/HjakfJnXCX+on0OTKTNoGTi+CeQAb3FyR7XfwgRzD4vN7E6sc5Va22kGbzZaA4BN0jL1jRQYeyGQK7cHJQU33IgnHCh8GS3fkbGBq1rfwy6kzKSiwjSFrl4iLvmH0G8PNI6OOPgc/3DpGUvZlGnORrwT6vMu+xzUuWJsx50Qv9gEQir2PR66ooXTurWLWGeYkS3L6OqZtkeVXqqHYinuSGXcsUyjx0kLqu2jfW7eWYMXymnY9JAZHFHnFUG8 X-OriginatorOrg: kneron.us X-MS-Exchange-CrossTenant-Network-Message-Id: ffa99bfd-9613-4c7e-362c-08dcdeb4cb57 X-MS-Exchange-CrossTenant-AuthSource: IA1PR14MB6224.namprd14.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Sep 2024 05:25:26.7358 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f92b0f4b-650a-4d8a-bae3-0e64697d65f2 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: F9Hd8wKD/zLDr1uohUwcTnjgjun29yvd5TmGswJGsnZFV8f8rJCZN2x0vgdpaOMz63J8AlplxP3EaL0fKGiHoA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR14MB5526 Since there are no registers controlling the hardware parameters IC_CAP_LOADING and IC_CLK_FREQ_OPTIMIZATION, their values can only be declared in the device tree. bus-capacitance-pf indicates the bus capacitance in picofarad (pF). It affects the high and low pulse width of SCL line in high speed mode. The only legal values for this property are 100 and 400, which are used to calculate the tHIGH and tLOW periods for high speed mode. This property corresponds to IC_CAP_LOADING. clk-freq-optimized indicates that the hardware input clock frequency is reduced by reducing the internal latency. The property affects the high period and low period of the SCL line. The property conrresponds to IC_CLK_FREQ_OPTIMIZATION. Signed-off-by: Michael Wu --- .../bindings/i2c/snps,designware-i2c.yaml | 14 ++++++++++++++ 1 file changed, 14 insertions(+) diff --git a/Documentation/devicetree/bindings/i2c/snps,designware-i2c.yaml b/Documentation/devicetree/bindings/i2c/snps,designware-i2c.yaml index 60035a787e5c..fc19e6a8b306 100644 --- a/Documentation/devicetree/bindings/i2c/snps,designware-i2c.yaml +++ b/Documentation/devicetree/bindings/i2c/snps,designware-i2c.yaml @@ -87,6 +87,20 @@ properties: This value is used to compute the tHIGH period. default: 300 + bus-capacitance-pf: + description: | + This property represents the bus capacitance in picofarad (pF). It + affects the high and low pulse width of SCL line in high speed mode. + The only legal values for this property are 100 and 400, which are used + to calculate the tHIGH and tLOW periods for high speed mode. + default: 100 + + clk-freq-optimized: + description: | + If the hardware input clock frequency is reduced by reducing the + internal latency, this property must be declared in the device tree. It + affects the high period and low period of SCL line. + dmas: items: - description: TX DMA Channel From patchwork Fri Sep 27 04:22:17 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Michael Wu X-Patchwork-Id: 831094 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (mail-bn8nam12on2132.outbound.protection.outlook.com [40.107.237.132]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 77FD5175562; Fri, 27 Sep 2024 05:25:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.237.132 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1727414743; cv=fail; b=gMDn/MmPgwdYq+/4MpJU1gttTPQMHg9zL7fpECrVU+idRhiyvzE6Jzue8unKrb5irX1hqwY9DwJ3B7TKT8V1wyxXOADR42M72UF/cdO13eXTuLD6k03WwZUdIwCUVh0yS1ZVLT/QcEZnnFA9WxgGp9NvUAKq+x0j+T7vC5qAKKU= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1727414743; c=relaxed/simple; bh=iggXLZrvO31cSQa/efuFQnc8m3BGiQEGwSczGGaVlGU=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: Content-Type:MIME-Version; b=mqhPMgl7PN1Z2wl4z66ruikzlK1KROfNSLjnQBv+n4Wctm/L1hfrjBxRP3PhUeHCQK+qx9wvHYaU5Au5NqEKzW/s+26Mo3Aq8CQocFH1rvXxxiwxJwvK9Ci5BxqOAAUNRkC5vrLWd4SWjlmjsPqJfUwxreNtUx0SeqBpPvDyuy4= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=kneron.us; spf=pass smtp.mailfrom=kneron.us; dkim=pass (1024-bit key) header.d=kneron.us header.i=@kneron.us header.b=j0/3HB82; arc=fail smtp.client-ip=40.107.237.132 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=kneron.us Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=kneron.us Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=kneron.us header.i=@kneron.us header.b="j0/3HB82" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=t/6fRaeHJ9SUla1XMeQhp7zjOcYdTm1Tyg1ezV5ujxFy5G7eS9NkgZc/Bn0f7Mu3Efij+xpQcNQdm30HX2vQ7CU9kXRkmp+AbEMO8eM9nJVqv7fd6Cx3GcZeB0nykrZqAHS95FMoGtjbv8xyd6aw1/FkUzc2AseXRU14sbdisj3dC7BQom1dkc73eAYLAnSeVahkH48R2qog0F+h7pHK1K0+DS28HLjIhIkpfRB8cocALQLJsH66ugkKGdZIDksun4d+OLCfLEjb5XgbqVVQ3FUotz7RQIFq+vtw1MIOhO8lCdoLUUeRD/7JjUDgSeDki2WgbVgLFXdPFDelP0Vb5Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=HfrxJmvZ/E5r0G5Euv9dngxSdBDj9xpz/WN8F/z1ciU=; b=TuTD0QATxJnJEVhazk7t+G6lgm4HmXBKnr5PQIvK9lI6iEc+iZOJDt9LRPosm5Om0TYzuKIhSqLEMR6oZ+gJ5Ve5n+XJ6qQUfkJJYv8BC0MLWkvqMuPLFXLVYw70AtXKVowP8C36XJJTxBIyWtEqCM7kG/xDJs1qUklNIwv1SKK2nVwXHqpTwPZje84Kb1DBMC1xFJiI5UhIUOq0A3m60G61OiR/4Xg1Hv7J5ZGfv6A/ETXZRDgRAvwSZYm05wd8lW0avQ3/pokN7H2NQ+fOze7al/+7Kg7cSciIDso6w4Lxq8KcZaVeaqP1WHNww8OkyBiafrQVcdZ4eoorhXH0Qg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=kneron.us; dmarc=pass action=none header.from=kneron.us; dkim=pass header.d=kneron.us; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kneron.us; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=HfrxJmvZ/E5r0G5Euv9dngxSdBDj9xpz/WN8F/z1ciU=; b=j0/3HB826niGZwXiN9sE5423tZRfHlQYkLrlwSwjlU6ZUbTT3mw/m9/Z6ikmlxnOEy7PvbflCX6m1TbhEcy8GuC3N2iV3eQQ3ytDTnYe+Ra1Vul/9q20fnFgjeTnMl50n3dlt3jV+jMolpc2Pa0ISK0R3ilGp8aH9mHlnOGYfTI= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=kneron.us; Received: from IA1PR14MB6224.namprd14.prod.outlook.com (2603:10b6:208:42b::6) by DM6PR14MB3449.namprd14.prod.outlook.com (2603:10b6:5:1ed::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7982.28; Fri, 27 Sep 2024 05:25:37 +0000 Received: from IA1PR14MB6224.namprd14.prod.outlook.com ([fe80::c527:653c:698d:3d94]) by IA1PR14MB6224.namprd14.prod.outlook.com ([fe80::c527:653c:698d:3d94%3]) with mapi id 15.20.8005.021; Fri, 27 Sep 2024 05:25:36 +0000 From: Michael Wu To: Andi Shyti , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Jarkko Nikula , Andy Shevchenko , Mika Westerberg , Jan Dabros , linux-i2c@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Morgan Chang , mvp.kutali@gmail.com, Michael Wu Subject: [PATCH v2 2/2] i2c: dwsignware: determine HS tHIGH and tLOW based on HW parameters Date: Fri, 27 Sep 2024 12:22:17 +0800 Message-ID: <20240927042230.277144-3-michael.wu@kneron.us> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240927042230.277144-1-michael.wu@kneron.us> References: <20240927042230.277144-1-michael.wu@kneron.us> X-ClientProxiedBy: TYAPR01CA0148.jpnprd01.prod.outlook.com (2603:1096:404:7e::16) To IA1PR14MB6224.namprd14.prod.outlook.com (2603:10b6:208:42b::6) Precedence: bulk X-Mailing-List: linux-i2c@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: IA1PR14MB6224:EE_|DM6PR14MB3449:EE_ X-MS-Office365-Filtering-Correlation-Id: 951e3701-48dd-4909-8dd6-08dcdeb4d14a X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|1800799024|376014|7416014|52116014|366016|921020|38350700014|80162021; X-Microsoft-Antispam-Message-Info: =?utf-8?q?7zUB2BGseyXcUpJLn6C6xXute1uh5kC?= =?utf-8?q?Gk016C6Dhuzq1SQhL1cIxH2w5DUyG+N3u/c2QotlSAeEMp6byYnwo86Vdg2Muw4kq?= =?utf-8?q?Mm7EPLGWi/qyBjvHlonMrqbv+sA8jXQ5NIkeGfWjeto7azzmXX3mCFJhyUWG0PRJX?= =?utf-8?q?mzLrFrI3o1F+A6ECCoMAfHDrOEgQ1A+rWob4qHnA5zxnkJlYwBntZyDBxUHOy4AEW?= =?utf-8?q?KTEzbyeocOH7BVnF2N5X/wAWlvgeZ9COrYUT0KnvY03EiJW6AjS42hy78f9Zh1iha?= =?utf-8?q?e9lJfcTpqnX4dkva3ZXKfyzYVYBZVyfY4r5woDw7kByvU54qgYZC/hGmH5XKhi+1h?= =?utf-8?q?vABVRWfJMQ1jLpzpLUyCq3Z9qZAM++DQe26WCR+Yzokux+ec8sn9AtQKFF1ToAviw?= =?utf-8?q?Qj7+tKDz/dgw6hFaVQKrafa+HODsppn84emBrr88ZSH6rQlD9gtz+WmWm7ecdVHY1?= =?utf-8?q?yn9Us+JmPaG8kQeyJmG/PZpCxNxX5ouIimoI5M4Q3N2xyipsHZZ3eux1BxjvYnY4P?= =?utf-8?q?iVulqCTKIen62N9OA6n91AMkrprJQ/L3QhwmfnvnggQyeXlzQtcbhoCS/8Nt6XXZJ?= =?utf-8?q?vHUJja6PMleWFBX8LvKhbKm692sapsgHaOeirMDGgeEyutNTd/oISMmrK5gkPJz8a?= =?utf-8?q?gqoECH/GbNbJPJdaBmvKupmkj53dIVn9BJBNhcREyqfdWtOnQHfaxOETs57HmcREa?= =?utf-8?q?Bc1LDdfJlQjqeKDpbbeQmBx9+vhL3+CZxUGTUvpOlNZ5JxIJvs+tOxQ5j8rLwmsEZ?= =?utf-8?q?A8arVOVYar5J1DS0MU7WlKX2WIQvT024BZPd8OyFATKUVyZkNl1k6REFi5A3cUGRb?= =?utf-8?q?1T4vbZSJI2QYhicS8u9IY93dokiqWTvyfCefBzR9s1DZErQuqRxdVFiOCuDNDa7JK?= =?utf-8?q?ic+FHpY3S6dLQWIq/sgHHYFActMIOOSlyvKcKn9oE+wxlI+wWpzeguBED+60rAME2?= =?utf-8?q?xWhbqBsip7CSY0rW+FLOzDxEzucpN4OxI8wQuGc0EagUcoUcJGizYAM1xK7ye6ZJW?= =?utf-8?q?BFbh7VIxSvmpnOLiylG5gIcrmIkH5kz916krudwj13kVpnVQBb/B4T1uyAY4Od6iJ?= =?utf-8?q?N+axyQG94Cn732EtKZaGNC6wRU2cage5k83pWOqHlMV/BNNVeVPz4fUgBPTXeFKPs?= =?utf-8?q?hh1uwPFEv8WQID+4M8ERNqpSVT9DmC3OId1fFMGKkFpiDOH7w3rF3KXLNKe6Ogs8H?= =?utf-8?q?cb2DIEmsVMLH1DGcOEpQnek7A562uqy2sXqSgHKJGI5/NRAFsOEVMLd7rRdBcqsdB?= =?utf-8?q?CpiaSOnY1CML55hYw2uRnr/gZhdFROTQuzriOttIwW4aJ87sQ+5DkVjUXVY9F2OWM?= =?utf-8?q?ERDsRrQQoQBl?= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:IA1PR14MB6224.namprd14.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(1800799024)(376014)(7416014)(52116014)(366016)(921020)(38350700014)(80162021); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?q?w9PdeM0OocaN1f+oDIySEvqWnXZF?= =?utf-8?q?qE2iUcy7rZM5H9EKtz+BrOsu4Ok/fBJvZAUknzbJqUAM/hIZmzvii7sxAV63+X2Sq?= =?utf-8?q?FsVZ0osDYkFpwFVcRI+MfTBm5vakOrsuYpuPnGAzBKI7dI2w6LWxgPrhWZAdaS6k9?= =?utf-8?q?dUN/aSX+X+TeDa++xjJrfFdugARDlWb9ZrQWjYhNVJ8kB99rn5fHn0wt8hf0aBAaf?= =?utf-8?q?1qrADm7AdbU4NyoCrb1qqPDDGz2QIFTUvTi0hgHIQYFX7NhdzMNRUcb2nZBODdq5A?= =?utf-8?q?mD9CDcHnFJnb0bIfIM4xDeyd2VttHxaxkHWK9cQbNMNxNa88uJyJMNdrik6gOdVvf?= =?utf-8?q?V7WsnnsVtOSuRKzzRjgabNLhjdltIouDbRVXWalKmjez2G0t2KniOx9oNN9/psTMD?= =?utf-8?q?uK41z3PczsFo9UhqqcmDfOu9eCr67qaBYExL95LHRRWncE08BFgWjVJZaKj6Bvo3x?= =?utf-8?q?3gruEsyCGInujQ1IKcBNOrT+oXJubGI6HIDn3wdFNtiI1y57QVfeEnbtSAd8+jlXv?= =?utf-8?q?jJ8RPOVg1qykoKgpTF9ISFFUssCwcNZ7ca1kh8HAjsOjku4tEoSwzlLv3AkFoYtf2?= =?utf-8?q?wKK0aiNDoDEHSh6l+MmS3jX6h8JYuih94r/jXhrU1yE3d3eketNhglt9265MEU8hJ?= =?utf-8?q?bCKa9sVoxdoVzU1LnIzNRsa5ICTR3liT+5o9UavtLEYB3wj5rWYSA15QKpT4R9bps?= =?utf-8?q?pvI6dYWHEB7uGk5BMrOg/cF+oToaApIP3GwUBqxH8W9INs+prmt4f+MwpfTMPBxw/?= =?utf-8?q?Vk+u4OFk3nxmBKVry8j9jE8pl4rok0hdfnTwKBSD4GkXEFILrOMsZFsd8CUlpKr+O?= =?utf-8?q?VRn0Kr4emd3yLARY0xqztZrVE1Ev+H18UHuWlnnqH3yETlhRQv5lGapmIRLDrl/pg?= =?utf-8?q?FOx182NEUHarlIwQfFWZwHQaBCx9XCYMm5DHT7R7O5FpQJt7GnPbwVidHsjOR3K/G?= =?utf-8?q?uVfkk4VCtN2kxqKYXJDKUeRPD3gBvC/ACyMfQ6JA/iBgJmBwPJGxiwZo6JiDcJbJB?= =?utf-8?q?sw+22YZBO1xWg0wxMmnC0wG9ecOvvm2ANjJsljw+gQLr3Sf5Ic1Z7AV5mkvvGTYg5?= =?utf-8?q?0qKhdrnmSVgJHWNHYtK1UIkru3moZO0tC8uRQK1fbOAPbC7BgYCN+nprkEM56Tmwm?= =?utf-8?q?AEhaXg1wyS0DX32G7qjDwBQ1t6mD02Htp4mEnXx+LsgSfGnjuSR/KhienPCPEbYGf?= =?utf-8?q?7hJzhaNL/DJs5Pfzl00fLSWvGZ+C2hjF2c9JHbyykFK6YmCGdqNcObHMJyHFEKADU?= =?utf-8?q?lYMFeXohSrLm+58Vob7Y3c6q7oLyovMsgP90qEh5JxpK5SU7r9D8zCmASbVl0wWZD?= =?utf-8?q?m+5zcsOvf6MgkMQRMzjZz9gfCKuVaIac+NdWWdCT2OvdfxB3IZ8YXmq55V7cOoOeD?= =?utf-8?q?al/su/65af3XeKJEBB616VwqQLDeBa8GpdHsWXhhafQDFbGVSFn75u52TsSB9NbNz?= =?utf-8?q?bR01YKhpHlFq9+80/zuh65+dHFk63VsabU9ZyJppSDLv8vwqqEJxIewiSUorJIzss?= =?utf-8?q?w6rXf/BUV4vx?= X-OriginatorOrg: kneron.us X-MS-Exchange-CrossTenant-Network-Message-Id: 951e3701-48dd-4909-8dd6-08dcdeb4d14a X-MS-Exchange-CrossTenant-AuthSource: IA1PR14MB6224.namprd14.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Sep 2024 05:25:36.9013 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f92b0f4b-650a-4d8a-bae3-0e64697d65f2 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 1x2wL9b1blRbXTXQEBB5V56GP1F6LFOw3pvxUOyWNL4LNLCK29Tc2cQMXppwhko1wop5BryQbGKs6FheUdEqng== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR14MB3449 In commit 35eba185fd1a ("i2c: designware: Calculate SCL timing parameter for High Speed Mode") hs_hcnt and hs_lcnt are calculated based on fixed tHIGH = 160 and tLOW = 120. However, the set of these fixed values only applies to the combination of hardware parameters IC_CAP_LOADING = 400pF and IC_CLK_FREQ_OPTIMIZATION = 1. Outside of this combination, if these fixed tHIGH = 160 and tLOW = 120 are still used, the calculated hs_hcnt and hs_lcnt may not be small enough, making it impossible for the SCL frequency to reach 3.4 MHz. Section 3.15.4.5 in DesignWare DW_apb_i2b Databook v2.03 says that when IC_CLK_FREQ_OPTIMIZATION = 0, MIN_SCL_HIGHtime = 60 ns for 3.4 Mbps, bus loading = 100pF = 120 ns for 3.4 Mbps, bus loading = 400pF MIN_SCL_LOWtime = 160 ns for 3.4 Mbps, bus loading = 100pF = 320 ns for 3.4 Mbps, bus loading = 400pF and section 3.15.4.6 says that when IC_CLK_FREQ_OPTIMIZATION = 1, MIN_SCL_HIGHtime = 60 ns for 3.4 Mbps, bus loading = 100pF = 160 ns for 3.4 Mbps, bus loading = 400pF MIN_SCL_LOWtime = 120 ns for 3.4 Mbps, bus loading = 100pF = 320 ns for 3.4 Mbps, bus loading = 400pF In order to calculate more accurate hs_hcnt amd hs_lcnt, two hardware parameters IC_CAP_LOADING and IC_CLK_FREQ_OPTIMIZATION must be considered together. Signed-off-by: Michael Wu --- drivers/i2c/busses/i2c-designware-common.c | 16 ++++++++++++++++ drivers/i2c/busses/i2c-designware-core.h | 6 ++++++ drivers/i2c/busses/i2c-designware-master.c | 14 ++++++++++++-- 3 files changed, 34 insertions(+), 2 deletions(-) diff --git a/drivers/i2c/busses/i2c-designware-common.c b/drivers/i2c/busses/i2c-designware-common.c index 080204182bb5..907f049f09f8 100644 --- a/drivers/i2c/busses/i2c-designware-common.c +++ b/drivers/i2c/busses/i2c-designware-common.c @@ -372,6 +372,20 @@ static void i2c_dw_adjust_bus_speed(struct dw_i2c_dev *dev) t->bus_freq_hz = I2C_MAX_FAST_MODE_FREQ; } +static void i2c_dw_fw_parse_hw_params(struct dw_i2c_dev *dev) +{ + struct device *device = dev->dev; + int ret; + + ret = device_property_read_u32(device, "bus-capacitance-pf", &dev->bus_capacitance_pf); + if (ret || dev->bus_capacitance_pf < 400) + dev->bus_capacitance_pf = 100; + else + dev->bus_capacitance_pf = 400; + + dev->clk_freq_optimized = device_property_read_bool(device, "clk-freq-optimized"); +} + int i2c_dw_fw_parse_and_configure(struct dw_i2c_dev *dev) { struct i2c_timings *t = &dev->timings; @@ -380,6 +394,8 @@ int i2c_dw_fw_parse_and_configure(struct dw_i2c_dev *dev) i2c_parse_fw_timings(device, t, false); + i2c_dw_fw_parse_hw_params(dev); + i2c_dw_adjust_bus_speed(dev); if (is_of_node(fwnode)) diff --git a/drivers/i2c/busses/i2c-designware-core.h b/drivers/i2c/busses/i2c-designware-core.h index 1ac2afd03a0a..893c2c53648a 100644 --- a/drivers/i2c/busses/i2c-designware-core.h +++ b/drivers/i2c/busses/i2c-designware-core.h @@ -240,6 +240,10 @@ struct reset_control; * @set_sda_hold_time: callback to retrieve IP specific SDA hold timing * @mode: operation mode - DW_IC_MASTER or DW_IC_SLAVE * @rinfo: I²C GPIO recovery information + * @bus_capacitance_pf: bus capacitance in picofarad + * @clk_freq_optimized: indicate whether the hardware input clock frequency is + * reduced by reducing the internal latency required to generate the high + * period and low period of the SCL line * * HCNT and LCNT parameters can be used if the platform knows more accurate * values than the one computed based only on the input clock frequency. @@ -297,6 +301,8 @@ struct dw_i2c_dev { int (*set_sda_hold_time)(struct dw_i2c_dev *dev); int mode; struct i2c_bus_recovery_info rinfo; + u32 bus_capacitance_pf; + bool clk_freq_optimized; }; #define ACCESS_INTR_MASK BIT(0) diff --git a/drivers/i2c/busses/i2c-designware-master.c b/drivers/i2c/busses/i2c-designware-master.c index e46f1b22c360..b18da66da6a8 100644 --- a/drivers/i2c/busses/i2c-designware-master.c +++ b/drivers/i2c/busses/i2c-designware-master.c @@ -154,12 +154,22 @@ static int i2c_dw_set_timings_master(struct dw_i2c_dev *dev) dev->hs_hcnt = 0; dev->hs_lcnt = 0; } else if (!dev->hs_hcnt || !dev->hs_lcnt) { + u32 t_high, t_low; + + if (dev->bus_capacitance_pf == 400) { + t_high = dev->clk_freq_optimized ? 160 : 120; + t_low = 320; + } else { + t_high = 60; + t_low = dev->clk_freq_optimized ? 120 : 160; + } + ic_clk = i2c_dw_clk_rate(dev); dev->hs_hcnt = i2c_dw_scl_hcnt(dev, DW_IC_HS_SCL_HCNT, ic_clk, - 160, /* tHIGH = 160 ns */ + t_high, sda_falling_time, 0, /* DW default */ 0); /* No offset */ @@ -167,7 +177,7 @@ static int i2c_dw_set_timings_master(struct dw_i2c_dev *dev) i2c_dw_scl_lcnt(dev, DW_IC_HS_SCL_LCNT, ic_clk, - 320, /* tLOW = 320 ns */ + t_low, scl_falling_time, 0); /* No offset */ }