From patchwork Thu Sep 26 15:46:37 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bryan O'Donoghue X-Patchwork-Id: 830944 Received: from mail-lf1-f51.google.com (mail-lf1-f51.google.com [209.85.167.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3D15C13B5B4 for ; Thu, 26 Sep 2024 15:46:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.51 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1727365608; cv=none; b=WzrC8BQT85yM0aEv6PYMVFcUPeTrwddp18NjGAaJ/Iw86uHANynJhxAK3Gd58thpSEjD16iNbJUk0rls+3iglxpSTfu2f/kA9xAr+npLAcsjAGEPRfoCUkEX6S+U8twPVoJ3fIv5yBJVeCBemnHuHB2JSBpBat8eSMP+Oyi0wec= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1727365608; c=relaxed/simple; bh=vTwVvG8iZlHzHza+YS67mEwp2zyunt+kNzBDYWtFYWc=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=qcQGlGlGDTndNXOCgX+Dv8oFXSvy++aTr+HMLPgPK0m3DddkU3Xwf4xI3/dOzaCfyo4dgfs35W89992uOZZBigMZLP+UH8xmDY008AcOnxJMvefsVwLyHQoWSGuY45qIFBfTIFB2hLxePTQKUVcPdDs8MhzOrwnL86BzZYpTVfo= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=Tr62/Wsx; arc=none smtp.client-ip=209.85.167.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="Tr62/Wsx" Received: by mail-lf1-f51.google.com with SMTP id 2adb3069b0e04-5389917ef34so1252027e87.2 for ; Thu, 26 Sep 2024 08:46:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1727365604; x=1727970404; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=E7nKjwcfTxwC0PwN6GrPgJAgBaaTNk6QSx4URpDS/gc=; b=Tr62/WsxrIbtWYD/PpbNOfunNtorLYB6HgXtx2kPaQxdlYMzuxlJmBP3XcvDaC1CIM /OWmD0XeYGUp6L8PmaFwoxHQFEM/h49p85/eD1vTkksURqcBs4HZetRz4RltopSKKGJD N4N6tL2DB8NEK7884Qw2dQleH8eRaFepbcjbxgXtbhgimSBJE5/RDGhM1N72xpkJrPHT 4rscA1UetElZ3RzCSt2lWGA4Tbze9gXOEtQ4SGOYj0O4u/nycIW+3RokiniMa9+5vm8M K1yD/PXBzCmbSjXbwRWV2tDNG0E1zNNu3n1zBVX/ZHBb7yDLe0pWsz1mBB6fxncgXDr6 sMuQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1727365604; x=1727970404; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=E7nKjwcfTxwC0PwN6GrPgJAgBaaTNk6QSx4URpDS/gc=; b=nxbSfPvHhXluZUQ+xtVKRln52+J0BCb8W23ZNF/lDZb6jhqNkgbHWqRl9BfkW3UNxW p9n1PWWGhFh0qa3hzgVUs9rvVE0d7CCqH/dDdY6f21acxT1y2rBwcnMIql0RLr3FT8xl fi1g+/N1XDnjSHTZcaYXD9kechZEqrirTR6i5uGchO0jwSKAaXVsjuhZk47lL8ehBfy9 f8Z1kaceCMt8SZfV+ERsvezstNxedh/g4ueLToJFJ4wxQ9uVtnCAzPmBBH6D4LlyPf4H JTjlpajVJrm3ZvPRDf0A2ab8wOcgqf2zr8jTr2BoPsGOGNis09CYIz8/woFPZbM7MiZT DoeA== X-Gm-Message-State: AOJu0YzZ8sHJgz7jwpg1JY/3aagzcM0n3DU3lE4LgFEI3+ejoCBifSqk daxI/m2icc2qsBYd/XPZvC/c1tR2KhqAvWDgjotAS6bJXzAfYyd17cryvozbaKJ0hj8c/O2e9+a 4OmY= X-Google-Smtp-Source: AGHT+IHC0UquaOxuhN7DmBE/LSdM/gTJCcl8evA7sxTCF52bwGR80T7zNwFTy8yz3npSXKHM2xzLNQ== X-Received: by 2002:a05:6512:b21:b0:536:54df:bff2 with SMTP id 2adb3069b0e04-5389fc6ce3fmr15586e87.54.1727365603983; Thu, 26 Sep 2024 08:46:43 -0700 (PDT) Received: from [127.0.0.1] ([176.61.106.227]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-5c882405166sm75744a12.9.2024.09.26.08.46.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 26 Sep 2024 08:46:43 -0700 (PDT) From: Bryan O'Donoghue Date: Thu, 26 Sep 2024 16:46:37 +0100 Subject: [PATCH 1/4] media: ov08x40: Fix burst write sequence Precedence: bulk X-Mailing-List: linux-media@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20240926-b4-master-24-11-25-ov08x40-v1-1-e4d5fbd3b58a@linaro.org> References: <20240926-b4-master-24-11-25-ov08x40-v1-0-e4d5fbd3b58a@linaro.org> In-Reply-To: <20240926-b4-master-24-11-25-ov08x40-v1-0-e4d5fbd3b58a@linaro.org> To: Sakari Ailus , Jason Chen , Mauro Carvalho Chehab , Sergey Senozhatsky , Hans Verkuil , Rob Herring , Krzysztof Kozlowski , Conor Dooley Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, Bryan O'Donoghue , stable@vger.kernel.org X-Mailer: b4 0.15-dev-dedf8 X-Developer-Signature: v=1; a=openpgp-sha256; l=2802; i=bryan.odonoghue@linaro.org; h=from:subject:message-id; bh=vTwVvG8iZlHzHza+YS67mEwp2zyunt+kNzBDYWtFYWc=; b=owEBbQKS/ZANAwAIASJxO7Ohjcg6AcsmYgBm9YHg4K/kfdpbJQr+sw9ORWikEEUVqPmwUlJR2 bTlEW+ogzKJAjMEAAEIAB0WIQTmk/sqq6Nt4Rerb7QicTuzoY3IOgUCZvWB4AAKCRAicTuzoY3I Ohl/D/0Qb6kIU3vP5HUUG7aJUfyxpNFzA1wXaBuDcXnB/unRTeG6IpZ3IWeEFNgO/tti+ReF2Nm crX5bRwXLxSEJ6DO5eKhUL/PbDyq80O0q4LXjfzTbgOb/56biZxFvo73Kp9gcfm8fT1S6SC25pS CZ6fLP82MCppTds4iRoAuif/8zfvqRVjEMEoxYz/gwlPFN42n2PDUx74eLJMrV22sP6JkEVYlfD qdlbPMU1ziiDTFehsG7vCXXC9Z5TWGSO/U/cBbK6eZSRcD8bUfBLy27NhbmZgHIR/L/IyKBWoP9 vB0KaQmcJGEWXTNfrMdz0yeL/h5Wtup/MzJYFIKwWmpvWsRAywElmabLlCXwjohKfvNlp6KqceX H8LREqgmliNbLF1EoggBJgzDCs2SM/G7zEqoCkQI8s87xeizWkPkqUlyMPmkBdXXcHGQdNP45Y8 GUc2F4jUSTvdahmtXUzaiozGGGHCKQ7YgkNsk9YnJpoZckdo0F7Ta0oak3ETxMTOaWQZ1QshOYT g+9oXzKhpS/0o2m5BwJBfE/EmwBzSR8BuSacZxH80brKjK7iozHMcssJj3AUKUELU9vfirLteoY wV4cfEHsygpEby6S0aUn1DVBnyosYcZJoWIas6gtdnFdQp1aaN3Ut3HkxQAACOhG6Yqx44uV+0u ObvNwXiyV425BvA== X-Developer-Key: i=bryan.odonoghue@linaro.org; a=openpgp; fpr=E693FB2AABA36DE117AB6FB422713BB3A18DC83A It is necessary to account for I2C quirks in the burst mode path of this driver. Not all I2C controllers can accept arbitrarily long writes and this is represented in the quirks field of the adapter structure. Prior to this patch the following error message is seen on a Qualcomm X1E80100 CRD. [ 38.773524] i2c i2c-2: adapter quirk: msg too long (addr 0x0036, size 290, write) [ 38.781454] ov08x40 2-0036: Failed regs transferred: -95 [ 38.787076] ov08x40 2-0036: ov08x40_start_streaming failed to set regs Fix the error by breaking up the write sequence into the advertised maximum write size of the quirks field if the quirks field is populated. Fixes: 8f667d202384 ("media: ov08x40: Reduce start streaming time") Cc: stable@vger.kernel.org # v6.9+ Tested-by: Bryan O'Donoghue # x1e80100-crd Signed-off-by: Bryan O'Donoghue --- drivers/media/i2c/ov08x40.c | 33 ++++++++++++++++++++++++++++----- 1 file changed, 28 insertions(+), 5 deletions(-) diff --git a/drivers/media/i2c/ov08x40.c b/drivers/media/i2c/ov08x40.c index 48df077522ad0bb2b5f64a6def8844c02af6a193..be25e45175b1322145dca428e845242d8fea2698 100644 --- a/drivers/media/i2c/ov08x40.c +++ b/drivers/media/i2c/ov08x40.c @@ -1339,15 +1339,13 @@ static int ov08x40_read_reg(struct ov08x40 *ov08x, return 0; } -static int ov08x40_burst_fill_regs(struct ov08x40 *ov08x, u16 first_reg, - u16 last_reg, u8 val) +static int __ov08x40_burst_fill_regs(struct i2c_client *client, u16 first_reg, + u16 last_reg, size_t num_regs, u8 val) { - struct i2c_client *client = v4l2_get_subdevdata(&ov08x->sd); struct i2c_msg msgs; - size_t i, num_regs; + size_t i; int ret; - num_regs = last_reg - first_reg + 1; msgs.addr = client->addr; msgs.flags = 0; msgs.len = 2 + num_regs; @@ -1373,6 +1371,31 @@ static int ov08x40_burst_fill_regs(struct ov08x40 *ov08x, u16 first_reg, return 0; } +static int ov08x40_burst_fill_regs(struct ov08x40 *ov08x, u16 first_reg, + u16 last_reg, u8 val) +{ + struct i2c_client *client = v4l2_get_subdevdata(&ov08x->sd); + size_t num_regs, num_write_regs; + int ret; + + num_regs = last_reg - first_reg + 1; + num_write_regs = num_regs; + + if (client->adapter->quirks && client->adapter->quirks->max_write_len) + num_write_regs = client->adapter->quirks->max_write_len - 2; + + while (first_reg < last_reg) { + ret = __ov08x40_burst_fill_regs(client, first_reg, last_reg, + num_write_regs, val); + if (ret) + return ret; + + first_reg += num_write_regs; + } + + return 0; +} + /* Write registers up to 4 at a time */ static int ov08x40_write_reg(struct ov08x40 *ov08x, u16 reg, u32 len, u32 __val) From patchwork Thu Sep 26 15:46:39 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bryan O'Donoghue X-Patchwork-Id: 830943 Received: from mail-ed1-f53.google.com (mail-ed1-f53.google.com [209.85.208.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E8B54157E6B for ; Thu, 26 Sep 2024 15:46:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.53 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1727365609; cv=none; b=olC5Jwmi2mmhhe8MFWmckVOy4/icCE4cHzst2UhcryDsre+gL0LO5jN7+y0F2Unt+N/cASUQbAZnPL2yUhu4dJtK2+w6ZyWXKuqlUyGrvm/NpKitCkRu4/MOJgxfPoInaPi31egBOHE97ithhCqshiPr+iV75Q40iL3ddBwIpAk= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1727365609; c=relaxed/simple; bh=9n+eZBcj4PM7sK6+NFZGx6o8ZubV08SdnN4bV1+Fg3I=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=ECTIBpidZ7zTiY6qqHX3Hhw5zMadNwDJikmt/vCwlXoYQk3wRpKfpKYk04mTMdhowFfN2obM6kgg9CKZ2E0pjSEh4f7PTs6kNWVqQHGLPux8H1D9rkEr1ahSprrHiHdYaKQmcm1V7lnNm1XsUAHO66HPYHRpjma9NafnMdwokEY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=cR3y26/s; arc=none smtp.client-ip=209.85.208.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="cR3y26/s" Received: by mail-ed1-f53.google.com with SMTP id 4fb4d7f45d1cf-5c876ed9c93so1188514a12.2 for ; Thu, 26 Sep 2024 08:46:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1727365606; x=1727970406; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=X31HSTlCzdVM5leNrm8kaJCkvfeV2FA5CwiaPcRFfvM=; b=cR3y26/siPso9htbfSuKjSL4TAzVfwur+0FoIEkPmcr7vY8udMb4q4FgUcGQqk3vQw BsIAb73rRvsBfM3pFXr+LhC2wI3IdqO9xcEjWKRmQO3sdJ2ZuF7Y1tT2M73JG7UwwafP vnOpSjzLlZzsF/q1DwnElGoiEEbQP5rd0bWBZzO9gW7ip/nuPxbGeKXTWdQYMQ78G8A7 vh17qBsRN7T88Y2EOfGy7MnxTHOKmcbNNzSJ5KDLOyYza232gMcEFypcH1lYEEpQaBC5 qmA7h3BaT0XXDzOpNMlVdVBXNmB3kYXSmyFILidw0OuEBo0sKKzBoJ6x9tvNRcYnNH/r j99g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1727365606; x=1727970406; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=X31HSTlCzdVM5leNrm8kaJCkvfeV2FA5CwiaPcRFfvM=; b=Szq88YZseejT7xxk/PkyPuFFdF9yrV6LEUgdp6raQFRXtfFjdU+NVFJdjob20u1YVa dbOhaZ0/RRx0wMxMF/436jCiAK2Jf2a20+f6K4Yibn66tC65DH48XYoX8HSKhlX/zUX/ uzOwVFYxUFTSVB4i6qvInhdxk0XIap6A1m2bnkiMWh36xP9v2+f9RMrRzivKnJXBvf2a 0Guz+zkkY7/oYZH06E9lGnVdaUEiMrTlmIrHh/Oz2ZclIo9qEJKKZdJGsBmJ3DGXd1Zd iR+JtDnZcTTjZ+aEvcrxZsG9MraX0AGgez45viXgIGcR7IFi40XCh+4h2+AQHKkLr0rx D/pA== X-Gm-Message-State: AOJu0YxbHHQyQwq2M+p6/CnEvw2WzWs1ef7mcq2W+SkPHYwVOIM+pDc1 HOQs8H2wckr+rovpWjvvmbiRwo4jmA9Vveqa2FY9IkBUN1cyvAa1rM9US40rjGlnuGsZ/5ML4LP UrJk= X-Google-Smtp-Source: AGHT+IEaBURJfwJKJ3uznZce7fPj92s1+tbcBYO5hFCdQG0lP3re4+t6lCfulzAoLnpHioLQIeypkg== X-Received: by 2002:a05:6402:4402:b0:5c4:2343:1227 with SMTP id 4fb4d7f45d1cf-5c8824ef51dmr162016a12.5.1727365605957; Thu, 26 Sep 2024 08:46:45 -0700 (PDT) Received: from [127.0.0.1] ([176.61.106.227]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-5c882405166sm75744a12.9.2024.09.26.08.46.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 26 Sep 2024 08:46:45 -0700 (PDT) From: Bryan O'Donoghue Date: Thu, 26 Sep 2024 16:46:39 +0100 Subject: [PATCH 3/4] media: ov08x40: Rename ext_clk to xvclk Precedence: bulk X-Mailing-List: linux-media@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20240926-b4-master-24-11-25-ov08x40-v1-3-e4d5fbd3b58a@linaro.org> References: <20240926-b4-master-24-11-25-ov08x40-v1-0-e4d5fbd3b58a@linaro.org> In-Reply-To: <20240926-b4-master-24-11-25-ov08x40-v1-0-e4d5fbd3b58a@linaro.org> To: Sakari Ailus , Jason Chen , Mauro Carvalho Chehab , Sergey Senozhatsky , Hans Verkuil , Rob Herring , Krzysztof Kozlowski , Conor Dooley Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, Bryan O'Donoghue X-Mailer: b4 0.15-dev-dedf8 X-Developer-Signature: v=1; a=openpgp-sha256; l=1651; i=bryan.odonoghue@linaro.org; h=from:subject:message-id; bh=9n+eZBcj4PM7sK6+NFZGx6o8ZubV08SdnN4bV1+Fg3I=; b=owEBbQKS/ZANAwAIASJxO7Ohjcg6AcsmYgBm9YHhelecfaMhp+gW2199dsN/wC6Ur4mnO75hN NXFJ2kEuVCJAjMEAAEIAB0WIQTmk/sqq6Nt4Rerb7QicTuzoY3IOgUCZvWB4QAKCRAicTuzoY3I OuLZEACh+orTS42ln+5XegAqChpJoiwuhwYX+HkUOOMHmyYav76OoYVkpHhs+1/k48HWKN1IvbS UgDe0EyTFhiyH6a/uA9iV5GPY7tyMHOGbNfw6GHWaGtJGsW+eag4tSZgJfRJNZYZ2NMuCNGo52o pv0K+URCZfksevR6sOF3IiTF957DWnQ4E5UffAWKmtRef7BQ10/DlLnq/3Axi1fF+QUdX3E4ws6 8sg/Wc51VJ5ZKUNnQREYyOncc+XcvUVRNvS+82IRVmws4BVQ4b9s6xfp7r9GQs7wMwSyM4mUmCP KLKfFJwsiJVd02KrTOBFRqsWuhm+eGALpu9k4/XEJ94KvSfYYQGKoRLLGoEyzIDf2JBLxvqpemT 0GGn5INirPAN30iPfnnTl2mudkJwci9rYzQ+SFM/190fVtPUGEDfOClVaRI5iY+oTeebRZ6awlU xmH/7GRfu3E8YadJvBOH7N2hN+dU4KJI7VjRPJNg+vlD98TE4Po2L9Pt9Wm3EG3dwbCwrHa84Qt mkPRvtIgENCLwWcoi4KY/ZSantTuULvrlBUrXj7czlZlUosbYDpIVTgPLmYk3/bQmT5jm4DcYOh lGtueek1YqzrXaqTNv0R4SbBIlmOJF5xufTXHvkUntU5qAKmgbwVYEhQeTVs1qVQvtV+4vfnFHQ qyuwbEB2a66yP0w== X-Developer-Key: i=bryan.odonoghue@linaro.org; a=openpgp; fpr=E693FB2AABA36DE117AB6FB422713BB3A18DC83A The data-sheet and documentation for this part uses the name xvclk not ext_clk for the input reference clock. Rename the variables and defines in this driver to align as preparation for adding DT support where the name of the clock in DT will be "xvclk". Signed-off-by: Bryan O'Donoghue --- drivers/media/i2c/ov08x40.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/media/i2c/ov08x40.c b/drivers/media/i2c/ov08x40.c index be25e45175b1322145dca428e845242d8fea2698..3ab8b51df157af78fcccc1aaef73aedb2ae759c9 100644 --- a/drivers/media/i2c/ov08x40.c +++ b/drivers/media/i2c/ov08x40.c @@ -1215,7 +1215,7 @@ static const char * const ov08x40_test_pattern_menu[] = { /* Configurations for supported link frequencies */ #define OV08X40_LINK_FREQ_400MHZ 400000000ULL #define OV08X40_SCLK_96MHZ 96000000ULL -#define OV08X40_EXT_CLK 19200000 +#define OV08X40_XVCLK 19200000 #define OV08X40_DATA_LANES 4 /* @@ -2081,21 +2081,21 @@ static int ov08x40_check_hwcfg(struct device *dev) struct fwnode_handle *fwnode = dev_fwnode(dev); unsigned int i, j; int ret; - u32 ext_clk; + u32 xvclk_rate; if (!fwnode) return -ENXIO; ret = fwnode_property_read_u32(dev_fwnode(dev), "clock-frequency", - &ext_clk); + &xvclk_rate); if (ret) { dev_err(dev, "can't get clock frequency"); return ret; } - if (ext_clk != OV08X40_EXT_CLK) { + if (xvclk_rate != OV08X40_XVCLK) { dev_err(dev, "external clock %d is not supported", - ext_clk); + xvclk_rate); return -EINVAL; }