From patchwork Wed Sep 25 19:49:20 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Krzysztof Kozlowski X-Patchwork-Id: 830897 Received: from mail-wm1-f41.google.com (mail-wm1-f41.google.com [209.85.128.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5262A145323 for ; Wed, 25 Sep 2024 19:49:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.41 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1727293769; cv=none; b=UkR4uXuzIeVnqTSF9hfvefExoux0/+XC178o/s0KeT3IM0JBTWGCA0IMr8//hgk6I9EIMvMgzqFDfj3SOC1oFchQGKSD+JsUpG6OIvua+caUBTWd7nX6yckj1jl6rfkbfFievFO3jSJJQtFZy8JhuR2ob2MANHJJmy2rO41t9is= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1727293769; c=relaxed/simple; bh=wHlt1UDNUW4EyY1KSNP5pOfctY2UPWgFJlLnpzAPVic=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=X5Jg2H4xyvEz4y6EKXGVfbuU5op319gIs+QD571UE176TBfYL/5Bswhe/8hsB+Fzx/McjWgIce6tiEqYA5SV2N7oSXdaL9ESF0VhePQdfLcuCtUyhLGGoegdP7+O1oPuBg7p/2IAAgVx/iiCAnKpBuj3QzMc5Qs9k4Urb22Xlt4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=grVfBDWT; arc=none smtp.client-ip=209.85.128.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="grVfBDWT" Received: by mail-wm1-f41.google.com with SMTP id 5b1f17b1804b1-42e6dbc8c7dso254005e9.1 for ; Wed, 25 Sep 2024 12:49:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1727293764; x=1727898564; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=5oZ8xiwz/Qw/3jSJKzIG7b4TVIP0JKJXyRmrBm+owVg=; b=grVfBDWTvg+0ZccImOzuO3SpkJtcD2xwY/UeVorcSEwUr4ZGVzPUQDnhApb1LUAKsU Qks7mFrAj7OlE/gy7MCPc4asSFRu8Oep3Rg7rrXtpH4ZolrJaTH0/GOTWhFXAtCZ90Ct dVQLbg5LDf5fKoM07RirFqrBjuh5PN+CNV3JauhHq5ObIY96EKYPIPhc6ZD6pJpelpe+ rGGkiosq6uCvkDi/F+F926sQSaJGVQgxZwMUPM1UO5gJddIysECSjVGzRk/RRLV4C7k6 HRRcdTuqjuTvXepkfvAtKsmZ7V9dO2Ac7YJjT0qCuhw/OUep2Iecq9RBy46k6GWL+X4j bA2A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1727293764; x=1727898564; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=5oZ8xiwz/Qw/3jSJKzIG7b4TVIP0JKJXyRmrBm+owVg=; b=sFMCwOlC69roBa79ycggPahXk5VcdTB5jnvXZM2FGViKoXqZPIW5jkVCy2+a9DymBR oQOxJ9qmBxMSgF/H8u2s2yIO9W5VwIFzYlG8e4a7+9wXKUkDgFHbWS9MDsn1pEeepzoY SKZCE4GEgGgrZ0cpb3kJX02YY4ELVw6Os+BgJMxM1aXIJeOGZBV88mmZ52NHOSvOuVcx LHZ3CXI6uF0+GuMdGjeT0FsCm4ZhFfXtUVVm/wQAJ32+/5jIPkm6FtBF6cvALf+ASgqk E/wZx14vvwMuCtwrnA0EBFKjyJtPG6yM9rNFZP7QsSdf4wRp74m0gWmllCP+vzePq1vT JQoA== X-Forwarded-Encrypted: i=1; AJvYcCXQm0+PwjNCh1ljMzJNDpCfzaTyFPz02GDCx/9L5YeVM8qk9AbEhCZHXNeh9ebci/vD11M4NE6ITW51Eg==@vger.kernel.org X-Gm-Message-State: AOJu0YwhrJcwJsJt2OwXNxsUMXbDQs6JRpZVbsugqp4G2EWdQtoi7zXI ZjgKDlfOXyGxB6zp34nVFJAuCQVBETDh8uTm5hrmN/Y8sr3WTJEDmUGWojey+14= X-Google-Smtp-Source: AGHT+IFYrMPT2ZaVL6xIu/354c9a0twdXDBSySfzuoKJtCPGg1FhbJnjlrx7JBdLQuBd2QTVnVH3aA== X-Received: by 2002:a5d:5888:0:b0:378:9560:330 with SMTP id ffacd0b85a97d-37cc24d0103mr1210030f8f.13.1727293764382; Wed, 25 Sep 2024 12:49:24 -0700 (PDT) Received: from krzk-bin.. (78-11-220-99.static.ip.netia.com.pl. [78.11.220.99]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-a9392f50078sm252268766b.59.2024.09.25.12.49.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 25 Sep 2024 12:49:23 -0700 (PDT) From: Krzysztof Kozlowski To: Dmitry Torokhov , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Jiri Kosina , Benjamin Tissoires , Charles Wang , linux-input@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Krzysztof Kozlowski Subject: [PATCH 1/2] HID: hid-goodix: drop unsupported and undocumented DT part Date: Wed, 25 Sep 2024 21:49:20 +0200 Message-ID: <20240925194921.18933-1-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-input@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Drop support for Devicetree from, because the binding is being reverted (on basis of duplicating existing binding) and property was not added to the original binding. Signed-off-by: Krzysztof Kozlowski --- drivers/hid/hid-goodix-spi.c | 9 --------- 1 file changed, 9 deletions(-) diff --git a/drivers/hid/hid-goodix-spi.c b/drivers/hid/hid-goodix-spi.c index de655f745d3f..0e59663814dd 100644 --- a/drivers/hid/hid-goodix-spi.c +++ b/drivers/hid/hid-goodix-spi.c @@ -786,14 +786,6 @@ static const struct acpi_device_id goodix_spi_acpi_match[] = { MODULE_DEVICE_TABLE(acpi, goodix_spi_acpi_match); #endif -#ifdef CONFIG_OF -static const struct of_device_id goodix_spi_of_match[] = { - { .compatible = "goodix,gt7986u", }, - { } -}; -MODULE_DEVICE_TABLE(of, goodix_spi_of_match); -#endif - static const struct spi_device_id goodix_spi_ids[] = { { "gt7986u" }, { }, @@ -804,7 +796,6 @@ static struct spi_driver goodix_spi_driver = { .driver = { .name = "goodix-spi-hid", .acpi_match_table = ACPI_PTR(goodix_spi_acpi_match), - .of_match_table = of_match_ptr(goodix_spi_of_match), .pm = pm_sleep_ptr(&goodix_spi_pm_ops), }, .probe = goodix_spi_probe, From patchwork Wed Sep 25 19:49:21 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Krzysztof Kozlowski X-Patchwork-Id: 830577 Received: from mail-ed1-f54.google.com (mail-ed1-f54.google.com [209.85.208.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7A689145336 for ; Wed, 25 Sep 2024 19:49:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.54 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1727293769; cv=none; b=D0xuWjoXJxdVME82w0znVCRq/51vnYSXyFUk3DjTx2rOKEhWNcepaC4AbttCOlPj6AbE7kIpPpKUkspfE+bHawrkfTOTz312ufs4FI/aLJxNJxfT/H1y2q+cbU+2Yu4UdlS0KtauGIRdUxNhkUITLXtqE5LVlJEbXzmfb+PSIJA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1727293769; c=relaxed/simple; bh=JMy6HzAy+taa3Pj/hIHV0nlXFH/c1wdgNTeuqyl5ahg=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=lLJxQVprjiV+LU8DF0fLmDrM3kHDgJknLQbpNrMmHR0FrT3BOa6Vg3E6/qgZjaMAX2tmLmyii1wd3OCYpnB5NiZwkcF0OOPxCl22wI/lAZ8Cw0NO/NxUZmB1sisavadnU1LwTVSGTHfpjBI8LLBzwVgr0vgrY3XH47daGNwHr2M= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=gDPFTSuH; arc=none smtp.client-ip=209.85.208.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="gDPFTSuH" Received: by mail-ed1-f54.google.com with SMTP id 4fb4d7f45d1cf-5c26a701185so16594a12.1 for ; Wed, 25 Sep 2024 12:49:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1727293766; x=1727898566; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Nnd6FOHE7QpKlvZPwQ8TrimhP2bKS/XiR5+tzZuq2mo=; b=gDPFTSuHCOB2mvwOVNuFSpuJ0T4hYvUP+AKikV7egYFPV0kjMSiwNtwsmpPorp280E KdAtUxQK9QeCoW7JO0Q9YJVXcinRpl2/VnaxodPK2Mju240SSQK9d9GxQUI/ymXptQ2K mapCvAA4daJGKSOPo/1V6HTXFjEf9zvCJ0EglNDLa9+KRaHav7D2oo/1+k68H1OcCC6W BOxP6mFycJvcgjYuH7aPaS8+IkjywiT/BfNhkjJxb+re84EpU+ccYXbPyiNLvGBgx3Gr T2gRwrUc7g7EAprtnpHXpkwZdZuG7c83fp/jy/qLBTGAemSsWvaLXhQOai9KAU6aP6jH 4htg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1727293766; x=1727898566; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Nnd6FOHE7QpKlvZPwQ8TrimhP2bKS/XiR5+tzZuq2mo=; b=XJapIRP0hXDn2yn26eyNBEmJ4/kHIT4Yi7hYpURr3VFf4ZJHk/dQeLWwczG7Dx9Cb+ 9cG5r0vooRsyXBD7GTElayr6zGYRWMnpf4W2GCvsjqkta7R9HeZhzLyez16soYT/08To QjcYNkbHBeQdjyVhHxWlnXtdP2ULgTuoUqTqlprEYjMT9Jxe2NvG9/krCS5GFrvhaU2R 9Uyvn5n5CEuq3TR9o6BkDYzOyU93Zwov6XkG55rz6H4oQfSrCgONaxOfMyujXzOznLRN 3MEFhAWnYZBU4BxKD1zkjs0lmpCb2jDN0qU9RCvst6GXHpfYwiscsxlvJtfTTCyXwEIa OQ+w== X-Forwarded-Encrypted: i=1; AJvYcCWJuxH0vlR8Le7uR4ICo7JFny0LLQpxjKoZPevtN4eEQ13mU+YBVrwkZKXsVBeh8rfBSnp3uvNG50Es3w==@vger.kernel.org X-Gm-Message-State: AOJu0YxQZrV+uTnb8lsDsAZ1wJx85uHLrVpNl6rLVpC3pZMb9dBxAY59 nrLhw7Jm5u4CIcu5BM4cPq+RAanbbuPpiYVp2oHSnJoa42JqxdC7JdvPszAvdnE= X-Google-Smtp-Source: AGHT+IFhMhS425ZHN+iwoku5iEmGy3G9tdLPsxDg5U0MGOkvPOPo+zPG0zZr24n8CjUQeLokaoSzuA== X-Received: by 2002:a17:907:3e1b:b0:a8d:4410:3bd6 with SMTP id a640c23a62f3a-a93a038315amr170773366b.4.1727293765695; Wed, 25 Sep 2024 12:49:25 -0700 (PDT) Received: from krzk-bin.. (78-11-220-99.static.ip.netia.com.pl. [78.11.220.99]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-a9392f50078sm252268766b.59.2024.09.25.12.49.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 25 Sep 2024 12:49:25 -0700 (PDT) From: Krzysztof Kozlowski To: Dmitry Torokhov , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Jiri Kosina , Benjamin Tissoires , Charles Wang , linux-input@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Krzysztof Kozlowski Subject: [PATCH 2/2] dt-bindings: input: Revert "dt-bindings: input: Goodix SPI HID Touchscreen" Date: Wed, 25 Sep 2024 21:49:21 +0200 Message-ID: <20240925194921.18933-2-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240925194921.18933-1-krzysztof.kozlowski@linaro.org> References: <20240925194921.18933-1-krzysztof.kozlowski@linaro.org> Precedence: bulk X-Mailing-List: linux-input@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 This reverts commit 9184b17fbc23 ("dt-bindings: input: Goodix SPI HID Touchscreen") because it duplicates existing binding leadings to errors: goodix,gt7986u.example.dtb: touchscreen@0: compatible: 'oneOf' conditional failed, one must be fixed: ['goodix,gt7986u'] is too short 'goodix,gt7375p' was expected This was reported on mailing list on 6th of September, but no reaction happened from contributor or maintainer to fix it. Therefore let's drop binding which breaks and duplicates existing one. Fixes: 9184b17fbc23 ("dt-bindings: input: Goodix SPI HID Touchscreen") Reported-by: Rob Herring Closes: https://lore.kernel.org/all/CAL_Jsq+QfTtRj_JCqXzktQ49H8VUnztVuaBjvvkg3fwEHniUHw@mail.gmail.com/ Signed-off-by: Krzysztof Kozlowski --- It is sad that original commit author ignored the report for two weeks. This should have never been sent to Linus as pull request. --- .../bindings/input/goodix,gt7986u.yaml | 71 ------------------- 1 file changed, 71 deletions(-) delete mode 100644 Documentation/devicetree/bindings/input/goodix,gt7986u.yaml diff --git a/Documentation/devicetree/bindings/input/goodix,gt7986u.yaml b/Documentation/devicetree/bindings/input/goodix,gt7986u.yaml deleted file mode 100644 index a7d42a5d6128..000000000000 --- a/Documentation/devicetree/bindings/input/goodix,gt7986u.yaml +++ /dev/null @@ -1,71 +0,0 @@ -# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) -%YAML 1.2 ---- -$id: http://devicetree.org/schemas/input/goodix,gt7986u.yaml# -$schema: http://devicetree.org/meta-schemas/core.yaml# - -title: GOODIX GT7986U SPI HID Touchscreen - -maintainers: - - Charles Wang - -description: Supports the Goodix GT7986U touchscreen. - This touch controller reports data packaged according to the HID protocol, - but is incompatible with Microsoft's HID-over-SPI protocol. - -allOf: - - $ref: /schemas/spi/spi-peripheral-props.yaml# - -properties: - compatible: - enum: - - goodix,gt7986u - - reg: - maxItems: 1 - - interrupts: - maxItems: 1 - - reset-gpios: - maxItems: 1 - - goodix,hid-report-addr: - $ref: /schemas/types.yaml#/definitions/uint32 - description: - The register address for retrieving HID report data. - This address is related to the device firmware and may - change after a firmware update. - - spi-max-frequency: true - -additionalProperties: false - -required: - - compatible - - reg - - interrupts - - reset-gpios - - goodix,hid-report-addr - -examples: - - | - #include - #include - - spi { - #address-cells = <1>; - #size-cells = <0>; - - touchscreen@0 { - compatible = "goodix,gt7986u"; - reg = <0>; - interrupt-parent = <&gpio>; - interrupts = <25 IRQ_TYPE_LEVEL_LOW>; - reset-gpios = <&gpio1 1 GPIO_ACTIVE_LOW>; - spi-max-frequency = <10000000>; - goodix,hid-report-addr = <0x22c8c>; - }; - }; - -...