From patchwork Mon Sep 23 03:42:50 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jinjie Ruan X-Patchwork-Id: 830392 Received: from szxga02-in.huawei.com (szxga02-in.huawei.com [45.249.212.188]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1763E139D; Mon, 23 Sep 2024 03:32:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=45.249.212.188 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1727062378; cv=none; b=C8BOMz4LTwtdDJRGEX2ntUNRPUOm0irDxob9ekA4FTYoH/ux/6WW59pUvsEnBsMdcaPtOd2ufSQJ5TXymb5ntVdo7kK5LN3eZi5dMyVOD/mBxsHynWzxRTZvk6T3ztfjHR/eR4nkN6c+mCFP7Fga2O/4UvUP38DnCGhEjDWI1Qs= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1727062378; c=relaxed/simple; bh=/2zixdHs3X+qXWlatQiiJJ3bN9A7oJ5g3jEIs5AqVEA=; h=From:To:CC:Subject:Date:Message-ID:MIME-Version:Content-Type; b=clg+niyjzhLZsdKAzSdqkw7Km44cVBglVkyWs7FDS+P2GRIPmM7p7eyFDCMTgWuw2Q6NhJZ7Gar1Ukj55FvvorQQhZmIznxIxBt0mk9OMmheBRPtnFYrV6UKCfEa8AzNaj+DJmSfyNI5vRv9/p+GpPfmIh2tEG2K3DpsfJYpK2w= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=huawei.com; spf=pass smtp.mailfrom=huawei.com; arc=none smtp.client-ip=45.249.212.188 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=huawei.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=huawei.com Received: from mail.maildlp.com (unknown [172.19.162.254]) by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4XBpRX74MrzpVyd; Mon, 23 Sep 2024 11:30:48 +0800 (CST) Received: from kwepemh500013.china.huawei.com (unknown [7.202.181.146]) by mail.maildlp.com (Postfix) with ESMTPS id 16C27180113; Mon, 23 Sep 2024 11:32:52 +0800 (CST) Received: from huawei.com (10.90.53.73) by kwepemh500013.china.huawei.com (7.202.181.146) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.11; Mon, 23 Sep 2024 11:32:51 +0800 From: Jinjie Ruan To: , , , , , , , CC: Subject: [PATCH] i2c: xiic: Fix pm_runtime_set_suspended() with runtime pm enabled Date: Mon, 23 Sep 2024 11:42:50 +0800 Message-ID: <20240923034250.3008055-1-ruanjinjie@huawei.com> X-Mailer: git-send-email 2.34.1 Precedence: bulk X-Mailing-List: linux-i2c@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-ClientProxiedBy: dggems705-chm.china.huawei.com (10.3.19.182) To kwepemh500013.china.huawei.com (7.202.181.146) It is not valid to call pm_runtime_set_suspended() for devices with runtime PM enabled because it returns -EAGAIN if it is enabled already and working. So, call pm_runtime_disable() before to fix it. Fixes: 36ecbcab84d0 ("i2c: xiic: Implement power management") Signed-off-by: Jinjie Ruan --- drivers/i2c/busses/i2c-xiic.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/i2c/busses/i2c-xiic.c b/drivers/i2c/busses/i2c-xiic.c index 4c89aad02451..1d68177241a6 100644 --- a/drivers/i2c/busses/i2c-xiic.c +++ b/drivers/i2c/busses/i2c-xiic.c @@ -1337,8 +1337,8 @@ static int xiic_i2c_probe(struct platform_device *pdev) return 0; err_pm_disable: - pm_runtime_set_suspended(&pdev->dev); pm_runtime_disable(&pdev->dev); + pm_runtime_set_suspended(&pdev->dev); return ret; }