From patchwork Sat Sep 21 01:03:00 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: John Schulz X-Patchwork-Id: 830255 Received: from mail-4316.protonmail.ch (mail-4316.protonmail.ch [185.70.43.16]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 975E45227 for ; Sat, 21 Sep 2024 01:03:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.70.43.16 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1726880589; cv=none; b=udX128GKCHiGDlG2IL8ADS4nJxdTy3KB7JcANxe5V7+VAYvtrU7ULl6orjz/9y+kg19xAJD3lpzaw42pUB1VRMfWZirdPoSAVIQI0QM4rIrZ8nrj6Iimd8cOA24jzO5KyQyGI1G+UFz/Dn4Dqc4rwu2A7Kc+z/LkYIn+MQpK6/s= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1726880589; c=relaxed/simple; bh=9x5VCa9UFcC5/iIiaPZzN6hVzAWR1F8Bf2mhpq+zXh8=; h=Date:To:From:Subject:Message-ID:MIME-Version:Content-Type; b=IzAqe73SiT4HgSuHgh7g1mqS+WvF3+caCz+KKjGeS0O52Qr+8UfTUFenStL31kz8FeOUTGmRCPVzwP6txeuwznCJ5D23mWtsq3j5gTmFhfzfO9NA6GQ0WkvAHCXxlTpkDF8zxb42W6x11koP/A+c6x3bSqy0q7IqLW4BXq//Jkk= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=protonmail.com; spf=pass smtp.mailfrom=protonmail.com; dkim=pass (2048-bit key) header.d=protonmail.com header.i=@protonmail.com header.b=yE4Z32Nd; arc=none smtp.client-ip=185.70.43.16 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=protonmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=protonmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=protonmail.com header.i=@protonmail.com header.b="yE4Z32Nd" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=protonmail.com; s=protonmail3; t=1726880585; x=1727139785; bh=9x5VCa9UFcC5/iIiaPZzN6hVzAWR1F8Bf2mhpq+zXh8=; h=Date:To:From:Subject:Message-ID:Feedback-ID:From:To:Cc:Date: Subject:Reply-To:Feedback-ID:Message-ID:BIMI-Selector; b=yE4Z32NdeJzE8hYalNpILfRlWDlFMf9QEzBhliqg+PNmC8Y78sRW9KCNV6QbNzHin n+tuyQHM+Q/2lwA/ZB2WadT/8juvd6ay3LU9H+k5Y+Zaym+zIizb/nqKkGwKkMNRrx rlJC/oGYutcPL1FSXJ0NndL2AOVliQ3YP+Q1Zm866m1a+OtRTNlvELdLtULKGh0Xmk 7vfkIIk6SbWLeRikkjoxWA4jb0lbM9P8XYloW5damnhzPcKQfUy9Wc8nyhCZrzrUiq 2xQ2Dwc7z7MYuCDQDi3c/9qBG8NAozNGllHCO2ycRHuFIX+NKxtLxaCn3DKgfrM41r Bwg6lmaMImWsQ== Date: Sat, 21 Sep 2024 01:03:00 +0000 To: "linux-arm-msm@vger.kernel.org" From: John Schulz Subject: [PATCH 1/2] Changing Ardreno X185 Check to X1xxx Family Check Message-ID: Feedback-ID: 15150580:user:proton X-Pm-Message-ID: db048c6717f885d12d1b2295621bd9d7874065ec Precedence: bulk X-Mailing-List: linux-arm-msm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Hello, First time submitting a patch. As work is made towards integrating more QCOM X1E and X1P SoCs, using a family identification function seems better fit than checking individual devices. Thanks, diff --git a/drivers/gpu/drm/msm/adreno/a6xx_gpu.c b/drivers/gpu/drm/msm/adreno/a6xx_gpu.c index 06cab2c6fd66..34ca8f6d5d99 100644 --- a/drivers/gpu/drm/msm/adreno/a6xx_gpu.c +++ b/drivers/gpu/drm/msm/adreno/a6xx_gpu.c @@ -1026,7 +1026,7 @@ static int hw_init(struct msm_gpu *gpu) gpu_write(gpu, REG_A6XX_UCHE_CLIENT_PF, BIT(7) | 0x1); /* Set weights for bicubic filtering */ - if (adreno_is_a650_family(adreno_gpu) || adreno_is_x185(adreno_gpu)) { + if (adreno_is_a650_family(adreno_gpu) || adreno_is_x1xx_family(adreno_gpu)) { gpu_write(gpu, REG_A6XX_TPL1_BICUBIC_WEIGHTS_TABLE_0, 0); gpu_write(gpu, REG_A6XX_TPL1_BICUBIC_WEIGHTS_TABLE_1, 0x3fe05ff4); From patchwork Sat Sep 21 01:06:42 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: John Schulz X-Patchwork-Id: 830016 Received: from mail-4316.protonmail.ch (mail-4316.protonmail.ch [185.70.43.16]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2A9AF36C for ; Sat, 21 Sep 2024 01:06:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.70.43.16 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1726880811; cv=none; b=P0Y+gyukL+gUJT0MmKGogCBQNa752qcT0Urc8OGHAey8ZQa44PX/wRGL9YY9TgZ34izqh3f648OzHyzxdfDD/oP03CuWzefdxDU3DkRZXIQ3PZjA5FQutC5cp+KPDBwdAL92lI97ElBfbfOmZZ1Am2L3onDyNKrECrsRV3Wg/4A= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1726880811; c=relaxed/simple; bh=rvSVhSQRP2VPiTMUSng/M9I3CwjgHj+FnMgDfWfbPH4=; h=Date:To:From:Subject:Message-ID:MIME-Version:Content-Type; b=eBlpSZxXE1PYYErRXu3P+fSGZopzkRPebmq0W2AI+a/fZzlAqprnSTZ6Vptpjz9iaSZA5OUkj986EhzJlHVmN+cvwu2DzfdwINkHQAa04X+RmV9s36v8CDlcQNKIKGi9zzBKCOVRbjr2G4RVwRwF6XL8qxnoz7v3M0RNh5HhFUY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=protonmail.com; spf=pass smtp.mailfrom=protonmail.com; dkim=pass (2048-bit key) header.d=protonmail.com header.i=@protonmail.com header.b=BmOCZwjY; arc=none smtp.client-ip=185.70.43.16 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=protonmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=protonmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=protonmail.com header.i=@protonmail.com header.b="BmOCZwjY" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=protonmail.com; s=protonmail3; t=1726880807; x=1727140007; bh=Gm8gFcqcIlcBuxFivKrjLEwbQ1ibpVvVH6V0/6fI6Bw=; h=Date:To:From:Subject:Message-ID:Feedback-ID:From:To:Cc:Date: Subject:Reply-To:Feedback-ID:Message-ID:BIMI-Selector; b=BmOCZwjYk+gvVZ46Y3EI+FQ1H2qavk62RwXybHIy/2mYbFF/34nVWPL+aYGs6idf4 5++TRaYXp5EklDcWtsraOaNlJqseOSlyoTg149iUwW4siL6MUZpBZ+BfLoHi/KjcC+ kHINXAmoW4OuGsiM37p3bqV07U3NyFIrYUFR8HdswnJF+2Rj9pIxsxMn0G9+wKUDiV nl63BYVzggzrKFggfs5UCXAUPGQv+0rJLN8rvrMSRlx5//0WTNlQ3baKgxyokZxcqS 7XYd9PTKGQqFExAv4Jfzha4MLU0HLKNpIDQBcISShiKaj6R179g0hsrMmnYHSAE/IZ uczzP4u2EbDfA== Date: Sat, 21 Sep 2024 01:06:42 +0000 To: "linux-arm-msm@vger.kernel.org" From: John Schulz Subject: [PATCH 2/2] Changing Ardreno X185 Check to X1xxx Family Check Message-ID: <_GZ7LdBTzrPYK6bJtttu9hidDnuUoTNmXD1-ghFdF-gq24RJdrOagaXuCRYVbWFPAUE11C9PGOO-sRUS45w2DX8F6rB1xomA_dT3Blm2Dd4=@protonmail.com> Feedback-ID: 15150580:user:proton X-Pm-Message-ID: c2d16ba82ec405cd028fb57c6e284b4c777d76aa Precedence: bulk X-Mailing-List: linux-arm-msm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 continuing off of last... I believe the chip ID is correct but I did grab it from a msminfo32 report so it may not be. If someone with more internal hardware info could validate or direct a better way place to get it, that'd be much appreciated. Thanks! diff --git a/drivers/gpu/drm/msm/adreno/adreno_gpu.h b/drivers/gpu/drm/msm/adreno/adreno_gpu.h index 58d7e7915c57..09a38aa63f01 100644 --- a/drivers/gpu/drm/msm/adreno/adreno_gpu.h +++ b/drivers/gpu/drm/msm/adreno/adreno_gpu.h @@ -526,9 +526,14 @@ static inline int adreno_is_a750(struct adreno_gpu *gpu) return gpu->info->chip_ids[0] == 0x43051401; } -static inline int adreno_is_x185(struct adreno_gpu *gpu) -{ - return gpu->info->chip_ids[0] == 0x43050c01; +static inline int adreno_is_x1xx_family(struct adreno_gpu *gpu){ + switch (gpu->info->chip_ids[0]){ + case 0x1fc31043: // X1-45 + case 0x43050c01: // X1-85 + return 1; + default: + return 0; + } } static inline int adreno_is_a740_family(struct adreno_gpu *gpu)