From patchwork Tue Sep 17 10:32:22 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?C=C3=A9dric_Le_Goater?= X-Patchwork-Id: 829232 Delivered-To: patch@linaro.org Received: by 2002:a5d:44c6:0:b0:367:895a:4699 with SMTP id z6csp213333wrr; Tue, 17 Sep 2024 03:35:01 -0700 (PDT) X-Forwarded-Encrypted: i=2; AJvYcCUR73wRdv1pwSqoczzTzX1liRTBFKk7uW8IZoViCxv0LhWwJ/49IEWhwSBODdKW9Xq3yU/7TQ==@linaro.org X-Google-Smtp-Source: AGHT+IEcLnpd4f0AtM6zBNg1uaBjBtjCXJmoWGrkmzmdLWxuhEgFu6YtWs2qKJIHEj9woOAxfA6i X-Received: by 2002:a0c:f207:0:b0:6bf:8890:ae17 with SMTP id 6a1803df08f44-6c573808998mr251209696d6.53.1726569300921; Tue, 17 Sep 2024 03:35:00 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1726569300; cv=none; d=google.com; s=arc-20240605; b=XtVQjst49KRzClEzHxaLdghInw67Uv0uOUxjo7vQZjbM33VeTS2UVtjUJPgAN7Hckd FlXV2JX14xAo6ZoM1XwUnzpkR0vKRRUYmLKPLNaNOTNXwFyqqOmp5IyCo//5YALIZcrX oZvlHyXPhMVjjfyt7LZU9IRks3tTIbMCNOr4vFnL16xZFoaqFVnJqpdAw8FcYVN81IXW 5hBw7soIivfhIBCLKZgzNVqlhEax1NB2gGkiTgpOvfHZEz6Z4Eil9zXGn/9ck/vIB14B 2Ow60xz4RlenWRMDs8n+huMBOhtdS8/rFXrXiZ/LNdJYP/0B1ERruwmZvyzNFnZYrDZ6 ENSw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=qQu8qIBWS3JOHIdXOfrdNwNd302ozz3pkhQqDhQQF64=; fh=dYN9rl6iTk7GHj7Sydevz/bNIdCEC+yFX4aX5rx+E18=; b=WFB3m5l9bsQOoLt76wmmdMxpDOZtVWD7ik//siTN8axviZYcUeR5oAwkTb3MSAJyYJ h7G4W8ToctAkDIEIcCxDXuZl25MsS7SdhKU2QmnNL1p8dAc3zbd4U4WLIPbxByXnw5n8 kCtflvhVma7Pzz53YBztO3mINJA/3/IIu9Di6keOiJTBT3hddsl2tVrwrMBAZc5iMKPH 1lyrwKmqKp3CdvtAmqQ9kJtSq8t3HjDPhBlU2QkKpHj2NFOqu8fb1O9OqaKFfqyySLRI 2Ia8l99134zFAvKhu2uEc/pqbEbIbxnuAmCwzqFQ32Aqq0Kidlokbtu+QIXRrUZVQvgc aQtg==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=HfUZ43dt; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id 6a1803df08f44-6c58c7adb60si80994126d6.342.2024.09.17.03.35.00 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Tue, 17 Sep 2024 03:35:00 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=HfUZ43dt; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sqVWg-0006cg-1x; Tue, 17 Sep 2024 06:33:43 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sqVVj-00066q-Uv for qemu-devel@nongnu.org; Tue, 17 Sep 2024 06:32:45 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sqVVh-0006jx-Gn for qemu-devel@nongnu.org; Tue, 17 Sep 2024 06:32:43 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1726569159; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=qQu8qIBWS3JOHIdXOfrdNwNd302ozz3pkhQqDhQQF64=; b=HfUZ43dt1Zd665x0Vu8dS2PvN6KGhn8ycN65vCzTmExBuZHXnxlnMIaBK8nuG8ANuD1LhM tc6tC6+oSVpMYNe8GxtAw8QRHz2imsf9Cq423VIkhNfBQSs0zLoQqzQbFlEnRa2gklNCDU PFQsQ6E4ChcKgxDX68CMauMgg8kyRF0= Received: from mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-647-LBtArw95N6Ow8yOxN-FOIg-1; Tue, 17 Sep 2024 06:32:37 -0400 X-MC-Unique: LBtArw95N6Ow8yOxN-FOIg-1 Received: from mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.12]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id F13B119560BD; Tue, 17 Sep 2024 10:32:36 +0000 (UTC) Received: from corto.redhat.com (unknown [10.39.193.154]) by mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id DDFE819560AA; Tue, 17 Sep 2024 10:32:34 +0000 (UTC) From: =?utf-8?q?C=C3=A9dric_Le_Goater?= To: qemu-devel@nongnu.org Cc: Alex Williamson , Peter Maydell , =?utf-8?q?Philippe_Mathieu-Daud?= =?utf-8?q?=C3=A9?= , =?utf-8?q?C=C3=A9dric_Le_Goater?= Subject: [PULL 1/8] hw/vfio/pci.c: Use correct type in trace_vfio_msix_early_setup() Date: Tue, 17 Sep 2024 12:32:22 +0200 Message-ID: <20240917103229.876515-2-clg@redhat.com> In-Reply-To: <20240917103229.876515-1-clg@redhat.com> References: <20240917103229.876515-1-clg@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.0 on 10.30.177.12 Received-SPF: pass client-ip=170.10.129.124; envelope-from=clg@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: qemu-devel-bounces+patch=linaro.org@nongnu.org From: Peter Maydell The tracepoint trace_vfio_msix_early_setup() uses "int" for the type of the table_bar argument, but we use this to print a uint32_t. Coverity warns that this means that we could end up treating it as a negative number. We only use this in printing the value in the tracepoint, so mishandling it as a negative number would be harmless, but it's better to use the right type in the tracepoint. Use uint64_t to match how we print the table_offset in the vfio_msix_relo() tracepoint. Resolves: Coverity CID 1547690 Signed-off-by: Peter Maydell Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Cédric Le Goater --- hw/vfio/trace-events | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/vfio/trace-events b/hw/vfio/trace-events index 98bd4dcceadc62517a510b81ad4a2a4d8ae61b22..c475c273fd8de156c68bca3f6eaf804c94276ff6 100644 --- a/hw/vfio/trace-events +++ b/hw/vfio/trace-events @@ -27,7 +27,7 @@ vfio_vga_read(uint64_t addr, int size, uint64_t data) " (0x%"PRIx64", %d) = 0x%" vfio_pci_read_config(const char *name, int addr, int len, int val) " (%s, @0x%x, len=0x%x) 0x%x" vfio_pci_write_config(const char *name, int addr, int val, int len) " (%s, @0x%x, 0x%x, len=0x%x)" vfio_msi_setup(const char *name, int pos) "%s PCI MSI CAP @0x%x" -vfio_msix_early_setup(const char *name, int pos, int table_bar, int offset, int entries, bool noresize) "%s PCI MSI-X CAP @0x%x, BAR %d, offset 0x%x, entries %d, noresize %d" +vfio_msix_early_setup(const char *name, int pos, int table_bar, uint64_t offset, int entries, bool noresize) "%s PCI MSI-X CAP @0x%x, BAR %d, offset 0x%"PRIx64", entries %d, noresize %d" vfio_check_pcie_flr(const char *name) "%s Supports FLR via PCIe cap" vfio_check_pm_reset(const char *name) "%s Supports PM reset" vfio_check_af_flr(const char *name) "%s Supports FLR via AF cap"