From patchwork Mon Sep 16 18:56:57 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?C=C3=A9dric_Le_Goater?= X-Patchwork-Id: 829015 Delivered-To: patch@linaro.org Received: by 2002:a05:6000:4187:b0:367:895a:4699 with SMTP id ei7csp933556wrb; Mon, 16 Sep 2024 11:58:59 -0700 (PDT) X-Forwarded-Encrypted: i=2; AJvYcCUnm/kJqepcnmVFRIwkbGuQStHuRjlodzcAa4q34rLS0OLnfFs0qRpCa13OU+Jam0SySOVULQ==@linaro.org X-Google-Smtp-Source: AGHT+IH49C5X3mmG7rMPMgrXQ85mluYfaG2CkqcwfNdEa5vxh+5TL6CFBmssLKGESFc+A/38I8xV X-Received: by 2002:a05:6214:4408:b0:6c3:63ea:377d with SMTP id 6a1803df08f44-6c573580c15mr265885606d6.43.1726513139323; Mon, 16 Sep 2024 11:58:59 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1726513139; cv=none; d=google.com; s=arc-20240605; b=XtI+3VX2OrJLS3ps06LFKBChQYO2xOQmeG35HulyAt9B2mXUduR7ESjxA9kjlaZh+l OHx2kTkvRNCnEtvgLS5qb9PlGccBGNo79fyqtfghx7VkLniFTBUyft6Gf+ZLxKxV9jjA 1Q2LNra+qfon5GdShkqLswpfpvPhZjN8/WA8dKAxyuhRq+zkeC41bd/mfWrfvpZCg2aS sf3v/wA7D5g90tqzDRCggw9u+4VtdQSexUNGedyEWYu5HXh5+oy+A0ULpe81Zcxw2cxF oh5Eovonp0QOCGp9/labXAaWJ1u8t/wUxxYDr1D7sz65gGMn+uriLH+vmF52mm/GjOTt r2DA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=WLdnvBXDISfTO2djkiD99UWRW2tZHgFKNtSGKnDQ/jc=; fh=mvwt3L+XMo5CtL3N3qH0hBr334luZSyJ2bqjtJkpouw=; b=JKfqlCmP3Cn3a/yLg7gL2OaGxcEpCNKKxch4MHKQpDX/+JbrEGynMR+UvDzNjc/luW +K0dMlqgHJZtiY7lFbPZKWs8Mr3PpUKrpTYfH1M3ByVIjE+OArOITpSsLfTrbtgDHdge eL+5RfkWjxX9MOrfw2m5qeY9SGxh33IY4/rptkf2WMLhl9KV1hw4uWjBb8D5ppO2Hwgw paXHsBFpGLC24YXXJUyYpGzXiq7p0bIbT/ag2DGYr581flemcUXUA655GTWYBXbOn2tm iV57QIvCcPc8ywOOwrRopJpcJgBrxOxnyXPJIGG+AHhCYBnK2TrlQPe4IaR6EKEIMGEn Q1Rw==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=fZ3W2ufu; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id 6a1803df08f44-6c58c68aefesi65506646d6.209.2024.09.16.11.58.59 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Mon, 16 Sep 2024 11:58:59 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=fZ3W2ufu; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sqGve-0008CV-O7; Mon, 16 Sep 2024 14:58:30 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sqGvb-00084C-LJ for qemu-devel@nongnu.org; Mon, 16 Sep 2024 14:58:27 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sqGva-0003J0-4u for qemu-devel@nongnu.org; Mon, 16 Sep 2024 14:58:27 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1726513104; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=WLdnvBXDISfTO2djkiD99UWRW2tZHgFKNtSGKnDQ/jc=; b=fZ3W2ufuZKc5AN48MvqkS9j5MxYcTHGeywGXW1GgneOxeWcUDsj78KeoDS92uLxkka0Kb/ lLkmKZ7+NxxyFrhU/nNlbWkgdPAZ0nL423SVoOCXs0UrvwcGTCDJbIrM8idNHlmIzKJq+t 0AHuage9Ud7g+FS07BQYCKuRcUOsUCs= Received: from mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-690-3-riQchVNuuh2CYeePw13A-1; Mon, 16 Sep 2024 14:57:17 -0400 X-MC-Unique: 3-riQchVNuuh2CYeePw13A-1 Received: from mx-prod-int-04.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-04.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.40]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 65BC919560BE; Mon, 16 Sep 2024 18:57:15 +0000 (UTC) Received: from corto.redhat.com (unknown [10.39.192.44]) by mx-prod-int-04.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 8852619560AA; Mon, 16 Sep 2024 18:57:13 +0000 (UTC) From: =?utf-8?q?C=C3=A9dric_Le_Goater?= To: qemu-arm@nongnu.org, qemu-devel@nongnu.org Cc: Peter Maydell , =?utf-8?q?C=C3=A9dric_Le_Goate?= =?utf-8?q?r?= Subject: [PULL 01/12] hw/gpio/aspeed_gpio: Avoid shift into sign bit Date: Mon, 16 Sep 2024 20:56:57 +0200 Message-ID: <20240916185708.574546-2-clg@redhat.com> In-Reply-To: <20240916185708.574546-1-clg@redhat.com> References: <20240916185708.574546-1-clg@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.0 on 10.30.177.40 Received-SPF: pass client-ip=170.10.129.124; envelope-from=clg@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: qemu-devel-bounces+patch=linaro.org@nongnu.org From: Peter Maydell In aspeed_gpio_update() we calculate "mask = 1 << gpio", where gpio can be between 0 and 31. Coverity complains about this because 1 << 31 won't fit in a signed integer. For QEMU this isn't an error because we enable -fwrapv, but we can keep Coverity happy by doing the shift on unsigned numbers. Resolves: Coverity CID 1547742 Signed-off-by: Peter Maydell Reviewed-by: Cédric Le Goater --- hw/gpio/aspeed_gpio.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/gpio/aspeed_gpio.c b/hw/gpio/aspeed_gpio.c index 3e7b35cf4f54..71756664dd69 100644 --- a/hw/gpio/aspeed_gpio.c +++ b/hw/gpio/aspeed_gpio.c @@ -281,7 +281,7 @@ static void aspeed_gpio_update(AspeedGPIOState *s, GPIOSets *regs, diff &= mode_mask; if (diff) { for (gpio = 0; gpio < ASPEED_GPIOS_PER_SET; gpio++) { - uint32_t mask = 1 << gpio; + uint32_t mask = 1U << gpio; /* If the gpio needs to be updated... */ if (!(diff & mask)) {