From patchwork Thu Sep 12 13:16:07 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: John Keeping X-Patchwork-Id: 828635 Received: from NAM10-DM6-obe.outbound.protection.outlook.com (mail-dm6nam10on2121.outbound.protection.outlook.com [40.107.93.121]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BF7EE1A706B; Thu, 12 Sep 2024 13:16:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.93.121 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1726146989; cv=fail; b=qC3qWYqXdsBd+FyoXXablq/56h3dSdYLkssjalZbchedWRK1ItgZuKhgSWTGverVNzdFJgCLfxMyvxul/pwAoj3xMytmpyW4GftRirbhDmvISLv5bXUqck6ZwPu24rqX0L147gstg1bQMDDimsr6tMKBQTvqXNiFYSs9IKjgOyo= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1726146989; c=relaxed/simple; bh=z6mjN2mDN8zGP660xdYAvPZplwr4oRn8zLD2s0LmYqE=; h=From:To:Cc:Subject:Date:Message-ID:Content-Type:MIME-Version; b=HgJGYlsjo5scDKbOCNTagGXVyqKDgGIpGgjXsB5iyDOToP8kmuP4qu9Q/lUG4eyd7Rd825vs32n9SGr1PaRVKOOBGDqWoeF60lJ272KjinI2UtU1aL0/k0h6dh70Q2twzwQOXv9iU2p3X0+3mxODOaG9diV8dyd0leP3kEK3+W8= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=inmusicbrands.com; spf=pass smtp.mailfrom=inmusicbrands.com; dkim=pass (1024-bit key) header.d=inmusicbrands.com header.i=@inmusicbrands.com header.b=UDzYKEr3; arc=fail smtp.client-ip=40.107.93.121 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=inmusicbrands.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=inmusicbrands.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=inmusicbrands.com header.i=@inmusicbrands.com header.b="UDzYKEr3" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=ZyqqDHGe7vnhrECtYXlVhLHx8lTyXlqgEQ+CofejwQrkaYeClBRqf5rGlQLuVh/coiGk958RtM6Y4cm4ozfZUiYogfZg/799CyeierLtiLCmeLG87/0VNFwsynctQAq9tA7a6eEXH/7np/Q+7nKGGrjCZFNMbUOOKBp1BVNSNwT3WWCI6D8KhiReltYTpQ/eUuP1zvZka5pYcFV/8JDXRSvctxnzp4JikmbF7l60JQFhVE0sO8Q4QqWImm1w/7qrqrkNUGaUaRIaggWJtz3TKS9bAShyCDrjf7JsZ3vjmUXloy6OtNdv/MInNr7od6ghdIoApRLEJ4Ne5YDrrx4uig== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=7Hk4jZJJxJZ+2o2Nq0GEWCQh9HqVfqJDeGQwEqRZzKU=; b=PIfKatflxeVIrRIQRpAOwI6wptaJBOgrCrpQ9W/8W/vOO4zv0CWaw0K/Z8SBy/xx/7ihzsuoeY/krbtFgrv4e9llPWFPtdYNd/mGmehrhUidzG1+DfVjEORYFIOLQvm2kFj3JRyWwjMbEDJfpqgztSjT2gLPeEFZTTPtvz0TR52S/I4AngYDpHX+sJiWtrV534D8YaDxqpNLtcWV3bIR4wYdibL8Ri4NZeQ5mO6lQFBFMU0dQmv5QMWNF0Fz7IJ0bw4e8pc7EDhQeiHPXGjXC/5eCu2XTBabKzFhjn0CBgRzDJccWhjs3kHzFGah5/1sXt89SdVTj4eu4FFTu7eSOg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=inmusicbrands.com; dmarc=pass action=none header.from=inmusicbrands.com; dkim=pass header.d=inmusicbrands.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=inmusicbrands.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=7Hk4jZJJxJZ+2o2Nq0GEWCQh9HqVfqJDeGQwEqRZzKU=; b=UDzYKEr3fRujGa7ykqdFRjiRVVEYCe3Mf8N5izTCNJh210F0cbuiABRI5/rsGCE9GPE/OoWBgtSN6v+6+uW0JNdgDeLQnjTfybRLPupHxTDsBSZCMY2a9Pw/rgAHJJXZKNE6zjukJb87CGpR1Q49ed99MKwLU3JadEIsUlbzDsk= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=inmusicbrands.com; Received: from MW4PR08MB8282.namprd08.prod.outlook.com (2603:10b6:303:1bd::18) by CH3PR08MB10267.namprd08.prod.outlook.com (2603:10b6:610:207::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7962.18; Thu, 12 Sep 2024 13:16:22 +0000 Received: from MW4PR08MB8282.namprd08.prod.outlook.com ([fe80::55b3:31f1:11c0:4401]) by MW4PR08MB8282.namprd08.prod.outlook.com ([fe80::55b3:31f1:11c0:4401%6]) with mapi id 15.20.7939.017; Thu, 12 Sep 2024 13:16:22 +0000 From: John Keeping To: Greg Kroah-Hartman Cc: John Keeping , Roy Luo , Alan Stern , yuan linyu , Sumit Garg , Krishna Kurapati , Paul Cercueil , Chris Wulff , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] usb: gadget: core: force synchronous registration Date: Thu, 12 Sep 2024 14:16:07 +0100 Message-ID: <20240912131608.1645554-1-jkeeping@inmusicbrands.com> X-Mailer: git-send-email 2.46.0 X-ClientProxiedBy: LO4P123CA0177.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:18a::20) To MW4PR08MB8282.namprd08.prod.outlook.com (2603:10b6:303:1bd::18) Precedence: bulk X-Mailing-List: linux-usb@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: MW4PR08MB8282:EE_|CH3PR08MB10267:EE_ X-MS-Office365-Filtering-Correlation-Id: 07a3a527-e521-4992-339e-08dcd32d18d4 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|7416014|52116014|376014|366016|1800799024|38350700014; X-Microsoft-Antispam-Message-Info: TNs7hzgRzR04DUGGbWCO91d2uLdcb6iXy6fLm4Aoz50V1CXpH/0AnkpNJuPaxpe0c2AjpHw+04A+5WZTPDsnBjj8/VnbBfr0bJQ4w9bS6vslvmJnI8NzmQMkPFDv2eVKUK3TSqYucJJZ28gky9h+Bo1csyS9s73Cr92QpGKqhAZou0ueX4HpE1q2bldUl8C9ERMT5nYMdZEP989gcQRBK/nqSU0ighxTwgcSM/vagoT1uXFQzZ9k729vjuAcoKXrTDIidZNr3f3/oqovIq1SgRkmP675vnY0KBxnbxEEoV4CDSCj5cT8Pw/yezywo1T1BPTrmb8AMsXkB7S5xVaaapSwMoly0LJyTZe1j1zUTyUpeTkVL317yqe+IGOg8N15kx7znXLwR055bX3mEojg2lbSxevh7hINR5uMVR+CzvpAMBVYH/snS/eCp2z+Nx9Sy2erLiyOp5Q8pCI636AwAJPo4wPR1jwXHS5+38/QHjuyx5CLQccn1EMaSGlmrd38J3PwJCnxHFvgSg42SL0OcnF0xfNcCnEN2EcvDpmqyTv4RjNIjmOtahOdZo6OkoAOTZUYIdlzc8qpU8+bMtBGylsqZfFYGpeDDPn+XOBCEVr0FO+B5oC9hXWhOVS1khCr49ie/100ZYITahKRJIMoraeb03wViVM8j6apslLDQ4j5qKihIor6NRKPBqSeeY76nr2TRvA03CehyBRHLfuBEnFFOJpebPoGmtLIB1OnsEMToEmoU8elhr1XWiMVStmYQUPSpxFFS61yHPC1Bwe+7LPbWFIOoMzHFRIQ2JcZNxy/erTYMbYOaA3HgvxKvFajROfCkxi6RVsHsHZ/xrurMyPkzxMOpW5b7hUzv1g0dcqwxznYwk4sOTczwGPk4hGv5zz3k+oSbsFHWzqHSx5AUoCOpyCBAO4VyaeTvWXvvvxRF8eLCgg1evIvlrPfDuHdGI4GjrwM5Ix9GqFYopJXMI05wiurKK/xHvoyK8l+H8PHQFeJgVNlXh6AbS4bW3rywMC4Hg/SKat8QnkkHoct0f2Az1J0ikNXuvAJhQiN9d4F/hc40W3AsJM/9O2ZvMDY4qlkBaB2BOFbsqhdToms0WKDOAHiJ0dzx7qHNEBKW5QgOzWEI1KJg9xCcguaDWUp7EFq5cwPIv160ogWas1ZKIFes57n9MCMEXMwuny4tKtEMmjXtAvkchgaRHek0jbJatwawxGcNZe/i5+QlgOEp9IuKTGwjrtuvz1do12c6kObJglWiK8I7AAN67QpQ7IKmWw8YtwX3//PixN+mksN2kCtAvW8BQBlvHzy72soL7lksu3XUpj99pMFwovsoD5vaSif3xrZZpiC/xGkpSjTT+tg09tT0N24CwKGiWRE66Z8waJ1j6qDF/4NZ/RIGYw1 X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MW4PR08MB8282.namprd08.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(7416014)(52116014)(376014)(366016)(1800799024)(38350700014); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: KdG18SORbDr9V5ZMui/9q+45KD3QdKG4ET52wi1qzn/cd+khAxZc1hWU530oUO3YT0Rx0wBfL6SenqdWYtsgZp6Vg+uKAWihL+50UuK0j92HEJRVhqrh3LuC/RjyEvyR0WR1qhOcu/OCF+l3edFwEY93fR0aHzgcSRj5AS8Wr5sWa5mHwIsqfbod4k59668tR473IEDnvJ8EtyNO3HsnXKyi8EuZVL3F8s35m2xFCwcvu6rXkk4YD130bz+vtGxQjvAu4dzyEQNp7l6GThdByk6yA5IFTU3J+5tZjMJh95wFF789yix2FaQgGfpdgvX8LRRmumUQF+//3F15zlKE5TEYBFvZJ67ncUr0bVuJqmJWhrNOEUT6OH5cpPPvvLb860gx+RsrrCf34rIO0ULxQThqmB7+NFTLkpdAPyTLpOyaGw2DKrf5YVcO3MUiR4m/Xu0+HUKsl4w4XU/idQ4E1wwmjqaVQQxwmO74mltAwlK4cU0RgrIOyvhJFbvqvucPUFhmUq7JJWhpscQBXuKjg+V2CCGt6v32/ZUiqqXwCb1e0YdsEA3Q3FR1bjOeazfwssIUEZ4CpVzJKRYClCKoaeWLSpFz/5mV9AvGglw0v6GyEXYlbfgnipqmsZotgrH+Hlbq5RDCPtT1ifCdoiYDTEP9lYoMyigM5BJrf3tnVv68ou5EkmUuU+EGA33Oyby/ti+U0JFBI4sjL24GcmAGK0FgzYwKNzHo2hNzlqfPmIlZBkhQGvv9lpFdE3tvM3xiUYHgjSH9LcDQPxlz547SJJGBTGZ18VM9gCFI7DGb5aAmVW4xFDC/aSBxhnhJ9LKjSor7qN+6VLMW56UrhIewVlJoKJ3lTtwisCw8p1XPk0xxTsPxansSWMo3DK3iND1jH6/GrYiu4BaXk0LSv3sInpIam3PGmJNK1sqXKoTgmhcb80xJHayCtXSG1d3p+1qA8+n+a02b5UBHmpEpepTQu0pjozn4zfyQT2MRIMy8CV0FZ0tNC5NaSydsup9ahXu0eWFteeE2EhpiAQRznPPjTWKM2hfK1iyyJmJgR96Qo6UrxbYehYDaYpZb0A76oMQSVp7jP531Fo8R5v7SrwEZa/ZF4HzKk0FnQmy2/7zJ4NcGaPwXjyA3FH8SyP6/XjcrtxpsPTbSE83dS02X5GYCB65NZvb12hUMJQMRNIqYg6L20s878+aF7HnFWUShAJBY70NQ3WJW6Nb5sGhl/MeW0ysIQLxWTV25ktv6HbQW+Dx0TtZd1/9wWIGyxCiccOwdql6esI5KdXMl/WE+CxwiFTbI5R3yg03tdJyMDS4Zr6FmCvMMkNZCg7TzBGb+KMPXU4rvWqd9uaMpGsSFp/BATPweFkmKnMem6i2+zDmiH5cQFIczZPINeFI2ZhxGCgBbe2eakA5pGZUnHevVsaMSja1YjmBYLirULxAkE2n4CVNfmGzxzJkuIt1jpW125+camGOplhlfftc2s2lINaEPqLVs/OK7qz4BbrOS0eYYak7l70Rfy9BW1D6toOgLlK3ZFJRCinDeY1lnNxf0LsOLZPAnoBEJe0stGWkroV/xzYrTHTQ9W1gLxWzm3fNY0Jro9sL8NF8upMLlvygUOielVg== X-OriginatorOrg: inmusicbrands.com X-MS-Exchange-CrossTenant-Network-Message-Id: 07a3a527-e521-4992-339e-08dcd32d18d4 X-MS-Exchange-CrossTenant-AuthSource: MW4PR08MB8282.namprd08.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Sep 2024 13:16:22.6529 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 24507e43-fb7c-4b60-ab03-f78fafaf0a65 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: aRo7G0MmRWdk/IrSGdQLUpgu4C7+IIaX0v6BR5GkNEjotyYh+/Fr7cLZpq4mh0BCuVVGlSNpVAWXjUxGugG54VRgwlpH++xjY97ZtSUF2wQ= X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH3PR08MB10267 Registering a gadget driver is expected to complete synchronously and immediately after calling driver_register() this function checks that the driver has bound so as to return an error. Set PROBE_FORCE_SYNCHRONOUS to ensure this is the case even when asynchronous probing is set as the default. Signed-off-by: John Keeping --- drivers/usb/gadget/udc/core.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/usb/gadget/udc/core.c b/drivers/usb/gadget/udc/core.c index cf6478f97f4a3..a6f46364be65f 100644 --- a/drivers/usb/gadget/udc/core.c +++ b/drivers/usb/gadget/udc/core.c @@ -1696,6 +1696,7 @@ int usb_gadget_register_driver_owner(struct usb_gadget_driver *driver, driver->driver.bus = &gadget_bus_type; driver->driver.owner = owner; driver->driver.mod_name = mod_name; + driver->driver.probe_type = PROBE_FORCE_SYNCHRONOUS; ret = driver_register(&driver->driver); if (ret) { pr_warn("%s: driver registration failed: %d\n",