From patchwork Thu Nov 14 09:39:49 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tomi Valkeinen X-Patchwork-Id: 179383 Delivered-To: patch@linaro.org Received: by 2002:a92:38d5:0:0:0:0:0 with SMTP id g82csp10810303ilf; Thu, 14 Nov 2019 01:40:16 -0800 (PST) X-Google-Smtp-Source: APXvYqxQMCvZ/rSLEsd/XjW5Cbo5iStnq2f+CDKwrm/QaCybOvoE21sdPMDMSbyPOgMurXtV45Ct X-Received: by 2002:a63:5511:: with SMTP id j17mr6192112pgb.70.1573724416592; Thu, 14 Nov 2019 01:40:16 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1573724416; cv=none; d=google.com; s=arc-20160816; b=ty7JgSH5p6XfHj3Esbz87S+QJj43TglrefGDWLWLUcg49h7DkuFrjTtjcxrBLp6I1p Y5gH/LW4yWJuUOSDVHstiNSa/tL8XTcNkXdimDudBMKpAVmqSi7H46mAC+utaHXDU1jD qG5SI6xrebS5DkfeAu7W59YmKWaj7fVvjz59zF8Hi66o9RyWCWX1IssIhOxffB+cnyKy qNy24AYb6hpil0MZTaryqcwmfGLwoZ29hyqjZgIK7OUMOZ5GC4+fd6ftVjJC1GgstTH7 MN6I1aV1sRFuVoEI223KOAKXsgrwk4uMEIUHP4s+MbQ4+7yr79Llc/LNV/BpNzWKve/b jOeg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:cc:list-subscribe :list-help:list-post:list-archive:list-unsubscribe:list-id :precedence:mime-version:references:in-reply-to:message-id:date :subject:to:from:delivered-to; bh=OJ1G+hE27bpATaq5jxjTc4pmblSI+qyp0bgOCRsILbE=; b=0edM7q9xCjTN8f02+0gJdKMRSVxfh2CIRz/uM7C9QdiY0mi4rGAdlUnSl41EA+Zr/A OabLQV+22GTjE5qSfhe/GGKf0FC581mIPJ84GX0czJBfcRgNMcoLCV6h9Pw8nxA0t7jK p+h+Pioi5XVZTqH+2ZLCvvRHKUQWEUZpkb+YZPo1jz9nvLwLMhvtw0O+tMeFmWR5Ot/W dj1I6Etjg/zq0rla17CDBsiUi8bSg5L78uGOa6dQ0VTe9gH+67ePhl3ImkHTRTfITe5f LexhYzSQQuM5xmj9MpLeJN/4aJq0fX3W0W5Iweh+LWxni1gSusvNYaRvKrNpP18X35PU sjbg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 131.252.210.177 as permitted sender) smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org; dmarc=fail (p=QUARANTINE sp=NONE dis=NONE) header.from=ti.com Return-Path: Received: from gabe.freedesktop.org (gabe.freedesktop.org. [131.252.210.177]) by mx.google.com with ESMTPS id s7si5654820pgb.66.2019.11.14.01.40.16 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 14 Nov 2019 01:40:16 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 131.252.210.177 as permitted sender) client-ip=131.252.210.177; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 131.252.210.177 as permitted sender) smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org; dmarc=fail (p=QUARANTINE sp=NONE dis=NONE) header.from=ti.com Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id C22026E158; Thu, 14 Nov 2019 09:40:10 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from fllv0016.ext.ti.com (fllv0016.ext.ti.com [198.47.19.142]) by gabe.freedesktop.org (Postfix) with ESMTPS id 90FF06E155 for ; Thu, 14 Nov 2019 09:40:08 +0000 (UTC) Received: from fllv0034.itg.ti.com ([10.64.40.246]) by fllv0016.ext.ti.com (8.15.2/8.15.2) with ESMTP id xAE9e3dj060084; Thu, 14 Nov 2019 03:40:03 -0600 Received: from DLEE103.ent.ti.com (dlee103.ent.ti.com [157.170.170.33]) by fllv0034.itg.ti.com (8.15.2/8.15.2) with ESMTPS id xAE9e2XD035592 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Thu, 14 Nov 2019 03:40:03 -0600 Received: from DLEE105.ent.ti.com (157.170.170.35) by DLEE103.ent.ti.com (157.170.170.33) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1847.3; Thu, 14 Nov 2019 03:40:02 -0600 Received: from fllv0040.itg.ti.com (10.64.41.20) by DLEE105.ent.ti.com (157.170.170.35) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1847.3 via Frontend Transport; Thu, 14 Nov 2019 03:40:02 -0600 Received: from deskari.lan (ileax41-snat.itg.ti.com [10.172.224.153]) by fllv0040.itg.ti.com (8.15.2/8.15.2) with ESMTP id xAE9dtjp085959; Thu, 14 Nov 2019 03:40:00 -0600 From: Tomi Valkeinen To: , , Thierry Reding , Tony Lindgren , Laurent Pinchart Subject: [PATCH 2/3] ARM: dts: am437x-gp/epos-evm: drop unused panel timings Date: Thu, 14 Nov 2019 11:39:49 +0200 Message-ID: <20191114093950.4101-3-tomi.valkeinen@ti.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20191114093950.4101-1-tomi.valkeinen@ti.com> References: <20191114093950.4101-1-tomi.valkeinen@ti.com> MIME-Version: 1.0 X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1573724403; bh=J6WQnf08jE29+k+Z+wJAETstTtd+Nns4dCt3g2mlorQ=; h=From:To:CC:Subject:Date:In-Reply-To:References; b=ZgDFJ/1FAIgtMzS2ZkkBB7p7Jgt3v9Zi7UxXT1n8awaNOoR4mVwQyGsGxu1A7NOPR T10TvQrJNXQiOtUuCRLCN78Drs/2GLyePdmlKZuau89wEN8ZNwTvRn0O/zy53RQ0mT FkFFuaH0WB1M4raYRUDgrFDxSqPMqW1XgUbCGl8I= X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Ujfalusi , Tomi Valkeinen , Jyri Sarha Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" panel-simple now handled panel osd070t1718-19ts, and we no longer need the panel timings in the DT file. So remove them. Signed-off-by: Tomi Valkeinen --- arch/arm/boot/dts/am437x-gp-evm.dts | 16 ---------------- arch/arm/boot/dts/am43x-epos-evm.dts | 16 ---------------- 2 files changed, 32 deletions(-) diff --git a/arch/arm/boot/dts/am437x-gp-evm.dts b/arch/arm/boot/dts/am437x-gp-evm.dts index 811c8cae315b..040403049cea 100644 --- a/arch/arm/boot/dts/am437x-gp-evm.dts +++ b/arch/arm/boot/dts/am437x-gp-evm.dts @@ -91,22 +91,6 @@ backlight = <&lcd_bl>; - panel-timing { - clock-frequency = <33000000>; - hactive = <800>; - vactive = <480>; - hfront-porch = <210>; - hback-porch = <16>; - hsync-len = <30>; - vback-porch = <10>; - vfront-porch = <22>; - vsync-len = <13>; - hsync-active = <0>; - vsync-active = <0>; - de-active = <1>; - pixelclk-active = <1>; - }; - port { lcd_in: endpoint { remote-endpoint = <&dpi_out>; diff --git a/arch/arm/boot/dts/am43x-epos-evm.dts b/arch/arm/boot/dts/am43x-epos-evm.dts index 078cb473fa7d..330fce060e8b 100644 --- a/arch/arm/boot/dts/am43x-epos-evm.dts +++ b/arch/arm/boot/dts/am43x-epos-evm.dts @@ -47,22 +47,6 @@ backlight = <&lcd_bl>; - panel-timing { - clock-frequency = <33000000>; - hactive = <800>; - vactive = <480>; - hfront-porch = <210>; - hback-porch = <16>; - hsync-len = <30>; - vback-porch = <10>; - vfront-porch = <22>; - vsync-len = <13>; - hsync-active = <0>; - vsync-active = <0>; - de-active = <1>; - pixelclk-active = <1>; - }; - port { lcd_in: endpoint { remote-endpoint = <&dpi_out>; From patchwork Thu Nov 14 09:39:50 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tomi Valkeinen X-Patchwork-Id: 179384 Delivered-To: patch@linaro.org Received: by 2002:a92:38d5:0:0:0:0:0 with SMTP id g82csp10810393ilf; Thu, 14 Nov 2019 01:40:21 -0800 (PST) X-Google-Smtp-Source: APXvYqyodd/4DkUaIHPzFuT5O92oI0Xeo5xL6KKAYepXE8uA5NcrXjvRw2rxNV2+ahqjbgdtsbpf X-Received: by 2002:a17:902:8690:: with SMTP id g16mr8963958plo.194.1573724421068; Thu, 14 Nov 2019 01:40:21 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1573724421; cv=none; d=google.com; s=arc-20160816; b=AqqnlnmEX2D2ZEGUqZKxan94NfSHxuyMS+RHGxq3T0wwSR8XEe4zBpVU2KfgGBLIbr IXzbUGNOZkOW5pWNWP3jr6N3n5yBG6muc4hq2Ls3bKg0en3i77jxwwFiAwgwzoeeA6eC 7g1vodzZzLuSGhy6kcO5Jke+Al3qcJhg0dWximUszeuqUfZTfQSROsKSD48sD2LSGnBz BVldvubX5GcST0Ub1bwqvqiwil2KHbcOFFTG20vskQLQSTF0CWjog/qs+RteZgMWUiSY ZgD+YfL0NDlMywCH5cKu5rCEwU24Zen764f4rXFwB/DWR5HNcASqORVrC9JzKQeFFx5u vb9g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:cc:list-subscribe :list-help:list-post:list-archive:list-unsubscribe:list-id :precedence:mime-version:references:in-reply-to:message-id:date :subject:to:from:delivered-to; bh=x3obLRWQUW2Odz3H/hQ5UIQatGCfS6tr/m0JkJ8L7Jk=; b=KL1bz1srmR/nDfn+ONQCywpTaCRSvHtOvBg6O/9/zyqf0a7KPciq/ZhpaMLhZtnrxj 8R9Dg15z23LUDffPoXaseCTAjUtgO1m6nGdIOphOhoitissIeQwEsO89q7Mfgvk6O0lp jQdBwiG88asP4YxitM7+47f8RkX+qITUl/sBZ+Fq8wbDI/bnwBKamy5Jlf88Kmwem4o8 AEyBDg8Qne/E10xJFZebAowZqssNdTJK/IKjQqlfTxzi+uJr2F7cQncYm/suaY4ZRmrP nRghScfhZFKgR05jxpGKVeAunKQ0Lc0mYYMi+QixQt4lpLQ6rWbm8AiE9lM5pxVFuY0m nszA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 2610:10:20:722:a800:ff:fe36:1795 as permitted sender) smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org; dmarc=fail (p=QUARANTINE sp=NONE dis=NONE) header.from=ti.com Return-Path: Received: from gabe.freedesktop.org (gabe.freedesktop.org. [2610:10:20:722:a800:ff:fe36:1795]) by mx.google.com with ESMTPS id q36si5114147pjq.40.2019.11.14.01.40.20 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 14 Nov 2019 01:40:21 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 2610:10:20:722:a800:ff:fe36:1795 as permitted sender) client-ip=2610:10:20:722:a800:ff:fe36:1795; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 2610:10:20:722:a800:ff:fe36:1795 as permitted sender) smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org; dmarc=fail (p=QUARANTINE sp=NONE dis=NONE) header.from=ti.com Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id B3FDA6E153; Thu, 14 Nov 2019 09:40:16 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from lelv0142.ext.ti.com (lelv0142.ext.ti.com [198.47.23.249]) by gabe.freedesktop.org (Postfix) with ESMTPS id EDBD46E15A for ; Thu, 14 Nov 2019 09:40:10 +0000 (UTC) Received: from fllv0035.itg.ti.com ([10.64.41.0]) by lelv0142.ext.ti.com (8.15.2/8.15.2) with ESMTP id xAE9e6Vt025264; Thu, 14 Nov 2019 03:40:06 -0600 Received: from DFLE113.ent.ti.com (dfle113.ent.ti.com [10.64.6.34]) by fllv0035.itg.ti.com (8.15.2/8.15.2) with ESMTP id xAE9e6Ns123500; Thu, 14 Nov 2019 03:40:06 -0600 Received: from DFLE114.ent.ti.com (10.64.6.35) by DFLE113.ent.ti.com (10.64.6.34) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1847.3; Thu, 14 Nov 2019 03:40:04 -0600 Received: from fllv0040.itg.ti.com (10.64.41.20) by DFLE114.ent.ti.com (10.64.6.35) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1847.3 via Frontend Transport; Thu, 14 Nov 2019 03:40:04 -0600 Received: from deskari.lan (ileax41-snat.itg.ti.com [10.172.224.153]) by fllv0040.itg.ti.com (8.15.2/8.15.2) with ESMTP id xAE9dtjq085959; Thu, 14 Nov 2019 03:40:02 -0600 From: Tomi Valkeinen To: , , Thierry Reding , Tony Lindgren , Laurent Pinchart Subject: [PATCH 3/3] drm/panel: simple: fix osd070t1718_19ts sync drive edge Date: Thu, 14 Nov 2019 11:39:50 +0200 Message-ID: <20191114093950.4101-4-tomi.valkeinen@ti.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20191114093950.4101-1-tomi.valkeinen@ti.com> References: <20191114093950.4101-1-tomi.valkeinen@ti.com> MIME-Version: 1.0 X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1573724406; bh=6LTnMb6e3K2BsU0Oe3+xvKa3TV0PwdvlajoGCs2MpqU=; h=From:To:CC:Subject:Date:In-Reply-To:References; b=ZJGUOmsrFH7KP0vRFaPawIbdpwPkW30RqaiaDif9zf6xu5FvgCZt6uY04+pmiofzv /9jnD1wXaQUapSMwz9L5bOysSGmP7NCoxcOtq+ObL3Fdr8GhPVsADjUpSHOHEBcfsy n7+Ah5/MkrxeA3U3FmLKEt/ApbcFjRja683S1mgQ= X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Ujfalusi , Tomi Valkeinen , Jyri Sarha Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" The panel datasheet says that the panel samples at falling edge, but does not say anything about h/v sync signals. Testing shows that if the sync signals are driven on falling edge, the picture on the panel will be slightly shifted right. Setting sync drive edge to the same as data drive edge fixes this issue. Signed-off-by: Tomi Valkeinen --- drivers/gpu/drm/panel/panel-simple.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c index 5d487686d25c..0784536ae6af 100644 --- a/drivers/gpu/drm/panel/panel-simple.c +++ b/drivers/gpu/drm/panel/panel-simple.c @@ -2397,7 +2397,8 @@ static const struct panel_desc osddisplays_osd070t1718_19ts = { .height = 91, }, .bus_format = MEDIA_BUS_FMT_RGB888_1X24, - .bus_flags = DRM_BUS_FLAG_DE_HIGH | DRM_BUS_FLAG_PIXDATA_DRIVE_POSEDGE, + .bus_flags = DRM_BUS_FLAG_DE_HIGH | DRM_BUS_FLAG_PIXDATA_DRIVE_POSEDGE | + DRM_BUS_FLAG_SYNC_DRIVE_POSEDGE, .connector_type = DRM_MODE_CONNECTOR_DPI, };