From patchwork Fri Aug 23 16:54:04 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lech Perczak X-Patchwork-Id: 822348 Received: from eu-smtp-delivery-197.mimecast.com (eu-smtp-delivery-197.mimecast.com [185.58.85.197]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C8D8F18BC31 for ; Fri, 23 Aug 2024 16:54:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.58.85.197 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1724432052; cv=none; b=hR65hboPYZ5hBUkYDS8RKGQvr8TSAsT5xZU/hGy8BHPmWk3ezXO9+GPteJpnckWXzeM0F3ePKO6HKaq8GDR3TJrm24JSVWoJ0sHd6AVCnPC68xew5HsFWErFIGkB4KFmUfafEQE2t+wWdQX3dUlo1zVtyXzxTvkJomtfvmJHAxI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1724432052; c=relaxed/simple; bh=MwEVhaAbbZG5Mnu0wsRNb0OT3kpHS7zusoKlKGO7lww=; h=Message-ID:Date:Subject:From:To:Cc:References:In-Reply-To: MIME-Version:Content-Type; b=QTSpl+4a7pVccPwAiwp0Z5CfXhoiT4hJkpognD62lNwZWn6rbY93cw4YpmabFPD9kZT6m0epVJ/z8L1gdM2wcF1npVTFQCSo3wLy1ZFxoizsfsc6GTdUE0MMDiA3S+WjX8gnqLSpNDoL8gk3w+GGNWVnDQ6qaJXVt2roezD0fQc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=camlingroup.com; spf=pass smtp.mailfrom=camlingroup.com; dkim=pass (1024-bit key) header.d=camlingroup.com header.i=@camlingroup.com header.b=P+saWbeL; arc=none smtp.client-ip=185.58.85.197 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=camlingroup.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=camlingroup.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=camlingroup.com header.i=@camlingroup.com header.b="P+saWbeL" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=camlingroup.com; s=mimecast20210310; t=1724432048; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=MmDul3sGjX2alKR0pnOMKeFwHoMlNM0CJyllM9dlV8Y=; b=P+saWbeLsTGW1ibfgMszNfJxgM3ahSNwoW+gwAOg+XgyBkChScirH3nJV8aXpOoFlmlOBG JEy0bM6pLHJkrbMoQThn8zQM1tYsyI/FZeXiDEPvyEjGjUfbdWGBj0qBFvbWh8JwV3qOjy RWrIaa9UeKmpscgYUcLqqIrf4qJVdl8= Received: from GBR01-CWX-obe.outbound.protection.outlook.com (mail-cwxgbr01lp2043.outbound.protection.outlook.com [104.47.85.43]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id uk-mta-192-M2L29m98NCeuO4dLZeW_zQ-1; Fri, 23 Aug 2024 17:54:07 +0100 X-MC-Unique: M2L29m98NCeuO4dLZeW_zQ-1 Received: from LO4P123MB5272.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:20b::7) by LO2P123MB6200.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:268::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7897.19; Fri, 23 Aug 2024 16:54:06 +0000 Received: from LO4P123MB5272.GBRP123.PROD.OUTLOOK.COM ([fe80::55a9:7dae:8812:f567]) by LO4P123MB5272.GBRP123.PROD.OUTLOOK.COM ([fe80::55a9:7dae:8812:f567%5]) with mapi id 15.20.7897.014; Fri, 23 Aug 2024 16:54:06 +0000 Message-ID: Date: Fri, 23 Aug 2024 18:54:04 +0200 User-Agent: Mozilla Thunderbird Subject: [PATCH v3 1/3] serial: sc16is7xx: remove SC16IS7XX_MSR_DELTA_MASK From: Lech Perczak To: linux-serial@vger.kernel.org, "linux-kernel@vger.kernel.org" Cc: Greg Kroah-Hartman , Jiri Slaby , Hugo Villeneuve , Andy Shevchenko , =?utf-8?q?Krzysztof_Drobi=C5=84ski?= , =?utf-8?q?Pawe=C5=82_Lenkow?= , Kirill Yatsenko References: <7deb753f-bf86-47ce-89bf-8277aca4293e@camlingroup.com> In-Reply-To: <7deb753f-bf86-47ce-89bf-8277aca4293e@camlingroup.com> X-ClientProxiedBy: BEXP281CA0016.DEUP281.PROD.OUTLOOK.COM (2603:10a6:b10::26) To LO4P123MB5272.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:20b::7) Precedence: bulk X-Mailing-List: linux-serial@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: LO4P123MB5272:EE_|LO2P123MB6200:EE_ X-MS-Office365-Filtering-Correlation-Id: c42d20b4-0e82-4d3e-85db-08dcc394331a X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|366016|376014 X-Microsoft-Antispam-Message-Info: =?utf-8?q?SRQx4lYL6NSpYYm2MqosTgRs1WPEXy+?= =?utf-8?q?b4t+NJ1YA+3E6rmUAwj9O+1P63pH26Vyaso3p7O1Pqy7+hr5u11qEsRrGyWRqV7le?= =?utf-8?q?ov8y1GSStpfe5h7HM/F1wcXkcIT70cbsleqZXQLOFoKHuDa6RqB+i+x2qfMoot9T9?= =?utf-8?q?E5zTAzD4U8uZPYUQM8L9FZzJczDmte81knmk9b82iy+9llsvcKhI3cgoj9cufSm22?= =?utf-8?q?5aegguD+goSrTCBcoLZaT1ji6L300oN99fPddL6FWc8Bk8Hwy8n2Bbxo8r4Z9eLKh?= =?utf-8?q?/DuXFTeoy6aalmhQ86JlXa5DNGOGJ++YadMUPUOoy6EB4vpsAh+dfX+lt9gBnYO3w?= =?utf-8?q?TxZKsQObNo88QNB65mX7vnaIZSkJoUROgYLfK9dOqbi4UHFw7KamR8jUCCg+jZ7gO?= =?utf-8?q?tn9rnsb5HWq0QbSxGZ87ecu2j2g5I7YJCb107P9brKAhrLzubwZHKtZVju2mlsrzw?= =?utf-8?q?7BntAitxcZiD13ZZmO9AlACXOx5LORoKnXdg19PDUVrQBkTbyXoCaAjiSU1tY9/UG?= =?utf-8?q?+LzrXSqSJuPdmlttxabJanANdOcfz5NgzmV/v13PVR2rNcYmwa0Uwwmks7I906Esi?= =?utf-8?q?J2Ql7Kqr91uTmTw4H9OP1pm3kKZWzoE1EUBSLwOujy3BBtAcU25l9l2sXbvCSPXgw?= =?utf-8?q?luArG7l4q89JOg9Kh18mFd5NRy6NKJg6aCjp2ZkQPEenagefA3wPyGYUPPcriA6wh?= =?utf-8?q?dfmrl5vrw9OJk9lPKlxJNlYNAqWcxJ2TeLv8j+S5JPdKcgloQ5cH/ashd0AVaj/u1?= =?utf-8?q?WXFg3W3859RQLa653w153x1g3pP8yzVkAlPoELrMMkHuJqH/A6kf8xaAp77EsPW8l?= =?utf-8?q?3G8itHdrOLiMzRrAgGx1ROdqcLrdsujrUw9ftoizF6h82u6Uv6bAizdNzAQI3C2mq?= =?utf-8?q?zONpz/UeZqzAi5/N1jAf2lDUunDUPR7UAJ15lJxoFwEvpkHtDe3bY1zPcYdbdsM/N?= =?utf-8?q?lN+EJnIGOe3DmlTHf383U+BBqgGqyjaW09VHObdk/17yXMkJjQqye0GFgre5YZLV7?= =?utf-8?q?kZz0wlCRceUUFPk1e8DAFGC40+pic49y28LVC4Nivyux3JbiBSkZu+LLsCBzEKo9B?= =?utf-8?q?FUhE3TycObrjbvPMt9ZEqwuSOpmiivWt/rC+A8wxMsL6O+CacAK21Ua9ApxwN3wKj?= =?utf-8?q?NPfaJ+L4rxghPDkEReJq5T/lzSRYydST/Y6QGTub7Gg53EJRy2eb4MC9Fguk02YVy?= =?utf-8?q?grQYCEQZYBzJzTKoJttCv+NZYKmpWfyk/DC/8RXNlrQODWxOh5Eu6hK+cdMjt5lx6?= =?utf-8?q?ma9aZyFJLZlbHaluyC2PKvIiVy8DWMLacdQ=3D=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:LO4P123MB5272.GBRP123.PROD.OUTLOOK.COM; PTR:; CAT:NONE; SFS:(13230040)(1800799024)(366016)(376014); DIR:OUT; SFP:1102 X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?q?1AvlE7M41dSmVxKL3vpWHi0fgkBK?= =?utf-8?q?ae50moA8dxtJIf7C6CPghiXC4e/5OLG7ZwMcbbTag7NQnFjuQLSLBvygNR+5KR+xC?= =?utf-8?q?lqInmqXFGrAjIDIcudoQY/IusRt5dhptb+ix9UGDVFteAjCIgq6mKtq5erKRlPhLN?= =?utf-8?q?wtAUuVulZv470SulXD8x9svZkwaSkBf2kbAv2IxjvchaI4nUw9fafgP7GeW2lR3LG?= =?utf-8?q?BomfxXRqBfTQOV482/8EEEUT7p4KBhlRMfxPHGZHxWZ1FvhvHEnGmr5oI1d0IASNO?= =?utf-8?q?4+AfOLuiEO1EyCeO9/hrCGKEQ7M+c59NZDFTm/xlPjUbyVLC3CoWbdGmEv8hVjGSK?= =?utf-8?q?hF/4tsWO/YMFjTnNXWANjJwpO7EWqdJcTasakAwwxnVkNN8W/g8w+CzmabeDYn9zZ?= =?utf-8?q?TF/PjVtcc8p2GKIlnJXChRHqfcYT96+/bj/ui9mCr5FOt1+eCH7JaRTapR6t7IKYA?= =?utf-8?q?qcp9EmuRhJjDpVqLqxZccVU0B63oeOM10p1uJ6VUwBGlh3Z+purbOr9oATlGXtlls?= =?utf-8?q?zKzfVp89CQfnKN9DrmA4GSP3bZ66Ayal+/h1NQjeKjQkLfOBejJQHLSmbuIPTif/C?= =?utf-8?q?yOZigJq/d0dWISZ05+99Bi8nr3j/16aq0/Cm+O9HceyKuWEvD7NUFMg+Z4dUUMy/E?= =?utf-8?q?vNbpk004KYlVzyUASDYZ1t+93ElEag3vKajS++mfHBTgzj31kkDqeyO8rPcwVGAPk?= =?utf-8?q?+5t5QffpM7yu2aub4BAY2dVSIfB3TK0x7u1s4xA/G+sY6jbPr9+Kj5lQ9vwNcCa0A?= =?utf-8?q?tdi9IxBqBLF3usiK4O2k/3/6vtYsdkrUQSIE0n+8+JusowOC90j8qCKooxZNm0mbh?= =?utf-8?q?+wErOhL+g/S6Je5D+tebx6wKU7nN/zeTdNJ+GFHShDVkMuKQow0dKBUF8b96s0jpx?= =?utf-8?q?qS8DHQSC8igi8Pd0cUl+hogjtCGDaU9du7jxQDdXeu+WHVm3PYynIaqWnn8d+Q3Xc?= =?utf-8?q?raIlihiIU4A+9ZR1EynRzNCra4E8G3U0vphxD9ZcJsnt3ytG7X7zpZBof7NWX2qoz?= =?utf-8?q?SpkpBMbVjfaVh12VyXrHV2UkFP+x/xo/5PqW1kIyOrYZ8r2OR4MHjOcOu3lLiaLJL?= =?utf-8?q?4rJzO9N8Vaz/qSuD+t7ZY36Fl8Ry0H8qObdThZjBrq06GAIxYEjWqH1Ze0O3yCPwA?= =?utf-8?q?qHddlKdpwjrTEroMJIjhWrmlDt9Vcc6hgcZv62z4Otu5muCMSg8DJnRJxZGGmB7HU?= =?utf-8?q?x4nbUVGeMDrnDkKl0aD/d42sKn7928ajpaYjvCf8k7Lvv9SbSusDcoU81jsrNqd8H?= =?utf-8?q?8Gi3U1JPnXe0TBsB0t3PZJWl2uGEFLE0w62US45OX+lSV6158eREp79WgCYXXL9wy?= =?utf-8?q?6hml6IDcaylKuwkwd3VddUqeqU6PmbwYZTaQ5eUi6Ke+ibFD+CujSOjjDsVqmX1R3?= =?utf-8?q?oz4NpmPcG8EHxsNE4haODQj6RkqF39vl45i4N04KmU+mtuvbIMKfXFW2XSMDcqvIp?= =?utf-8?q?MilgNRaQ3DLN719IM4rN0KuLvINJYIrU8yOFynp9QEKTeQnYPnn7H6yRkiqNU5+dQ?= =?utf-8?q?+Owkj7str+ForwGftgSOECz2DwBLXNeC/l8dwrmFfsKqFkIxpeZC15JvMM3jMc/sc?= =?utf-8?q?6Ev0TfLW242UOehO+lJUaJwH6DIk4CfqQ=3D=3D?= X-OriginatorOrg: camlingroup.com X-MS-Exchange-CrossTenant-Network-Message-Id: c42d20b4-0e82-4d3e-85db-08dcc394331a X-MS-Exchange-CrossTenant-AuthSource: LO4P123MB5272.GBRP123.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Aug 2024 16:54:06.0917 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: fd4b1729-b18d-46d2-9ba0-2717b852b252 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Pv1BDGeJnc353cBrv7XwMe7KZ05NZvs8CyCGwUyMwo6DuUrEXH6f/2SgJLDVWkmDFPOg3yqT3NK+3rmoBRsneUM9szr+2FORkdQFk+gLylU= X-MS-Exchange-Transport-CrossTenantHeadersStamped: LO2P123MB6200 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: camlingroup.com Content-Language: en-US This definition isn't used anywhere anymore, let's delete it. Reviewed-by: Andy Shevchenko Signed-off-by: Lech Perczak --- Cc: Greg Kroah-Hartman Cc: Jiri Slaby Cc: Hugo Villeneuve Cc: Andy Shevchenko --- drivers/tty/serial/sc16is7xx.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/tty/serial/sc16is7xx.c b/drivers/tty/serial/sc16is7xx.c index bf0065d1c8e9..8a2020f9930e 100644 --- a/drivers/tty/serial/sc16is7xx.c +++ b/drivers/tty/serial/sc16is7xx.c @@ -207,7 +207,6 @@ #define SC16IS7XX_MSR_CD_BIT (1 << 7) /* CD (IO6) * - only on 75x/76x */ -#define SC16IS7XX_MSR_DELTA_MASK 0x0F /* Any of the delta bits! */ /* * TCR register bits From patchwork Fri Aug 23 16:54:45 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lech Perczak X-Patchwork-Id: 822123 Received: from eu-smtp-delivery-197.mimecast.com (eu-smtp-delivery-197.mimecast.com [185.58.86.197]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6DC1518E74C for ; Fri, 23 Aug 2024 16:54:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.58.86.197 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1724432092; cv=none; b=rTmECWAj9i6lhBEn9tkyyuzJ1M7YGwaGjQSGQ4bpqd52bcJ7+JjYJI17hYERGsOhfpWykxoa/TYNXwLEufr3PbYuGYvqOAvPLJApQnFfnmz1PFQBBog8UQPmuXY1pEf25aMEpCEWXTw3qIR10Zz+Y3lOoiDO8ga1uRfh2vfHfN8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1724432092; c=relaxed/simple; bh=xlivHA5ql1it85zYsrc8TIQfQPV0ClIQCYh3/vL6HX4=; h=Message-ID:Date:Subject:From:To:Cc:References:In-Reply-To: MIME-Version:Content-Type; b=CrZOLGVGfnwUVorAmj3Dmq8ELqiLQLknwr5zejS8uJLBphNsM1+whtvOoHw72g3n7HaUlQaij0hIpvZnhHTytlM/es2FAvz/zYW93ffp2zq46PdW1vYy1encTgWRdl9ymTByiaaAeMTSdb+A5UTybFw4fZnt57t/V/Nlp2/Rb/8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=camlingroup.com; spf=pass smtp.mailfrom=camlingroup.com; dkim=pass (1024-bit key) header.d=camlingroup.com header.i=@camlingroup.com header.b=hIU5u7x3; arc=none smtp.client-ip=185.58.86.197 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=camlingroup.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=camlingroup.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=camlingroup.com header.i=@camlingroup.com header.b="hIU5u7x3" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=camlingroup.com; s=mimecast20210310; t=1724432088; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=c728VZv6v7K8l+pge5+f5HkAlqnOFc8OqhDpJIZ4pus=; b=hIU5u7x3igji6eCBJ3fj1Pz7XUG7KpbrcmpF3ZdTIQ/3p8YRXe6kN5m571KBy/irvPZxPi SxYNunClqG7TzfUmS4Gm1GD8r2Mj4YWVtI1ZAKgUw0JhYsQLAjAUy+A0ynxMO/NP41kuiW CMBUJBMhDOYwLYldjOkyhX5CYEbmVk4= Received: from GBR01-CWX-obe.outbound.protection.outlook.com (mail-cwxgbr01lp2042.outbound.protection.outlook.com [104.47.85.42]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id uk-mta-235-iZ77_G1tN9CxZ2xa7eDk9g-1; Fri, 23 Aug 2024 17:54:47 +0100 X-MC-Unique: iZ77_G1tN9CxZ2xa7eDk9g-1 Received: from LO4P123MB5272.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:20b::7) by CWLP123MB3105.GBRP123.PROD.OUTLOOK.COM (2603:10a6:400:5c::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7897.19; Fri, 23 Aug 2024 16:54:46 +0000 Received: from LO4P123MB5272.GBRP123.PROD.OUTLOOK.COM ([fe80::55a9:7dae:8812:f567]) by LO4P123MB5272.GBRP123.PROD.OUTLOOK.COM ([fe80::55a9:7dae:8812:f567%5]) with mapi id 15.20.7897.014; Fri, 23 Aug 2024 16:54:46 +0000 Message-ID: <8314e995-6f7a-4e9e-98dd-8c424d25b854@camlingroup.com> Date: Fri, 23 Aug 2024 18:54:45 +0200 User-Agent: Mozilla Thunderbird Subject: [PATCH v3 2/3] serial: sc16is7xx: fix copy-paste errors in EFR_SWFLOWx_BIT constants From: Lech Perczak To: linux-serial@vger.kernel.org, "linux-kernel@vger.kernel.org" Cc: Greg Kroah-Hartman , Jiri Slaby , Hugo Villeneuve , Andy Shevchenko , =?utf-8?q?Krzysztof_Drobi=C5=84ski?= , =?utf-8?q?Pawe=C5=82_Lenkow?= , Kirill Yatsenko References: <7deb753f-bf86-47ce-89bf-8277aca4293e@camlingroup.com> In-Reply-To: <7deb753f-bf86-47ce-89bf-8277aca4293e@camlingroup.com> X-ClientProxiedBy: BEXP281CA0003.DEUP281.PROD.OUTLOOK.COM (2603:10a6:b10::13) To LO4P123MB5272.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:20b::7) Precedence: bulk X-Mailing-List: linux-serial@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: LO4P123MB5272:EE_|CWLP123MB3105:EE_ X-MS-Office365-Filtering-Correlation-Id: 6dffcdac-b3c7-4202-e9a7-08dcc3944b4a X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|376014|366016 X-Microsoft-Antispam-Message-Info: =?utf-8?q?B8+dlqZM1xYszWn8Y+eGrjsvmBINeaR?= =?utf-8?q?aLjKGpxEm5NPzibLpz1YrwmHhCpDADtQE+jC7MBbrKeVPs0K8q6IfeV1bt1u+S1xA?= =?utf-8?q?qrUX4CjJa1VG//1ZyI/Cd5EK2Dd/cOTlm5cLlPxGMyIsX2Qd9hWvCp7bmo+MbKuUE?= =?utf-8?q?/Fxp3OiGLty8g72BxzMXLvxBM6mRSFFSt/BBTFTKJP8qZdRnlArA7SgU2nRjWKg9Y?= =?utf-8?q?9nRVKGAITd9ENYYRamiWfXeci7tFESrX8kEW8Jgn2LoGibbtQjL3BllomMCnDHN2J?= =?utf-8?q?2bOmuMFa7aH+mmSadIvXBD6oBFYuZ5id+D7zlaFfnjmEqXS210bEhK4GI5AwNVm+z?= =?utf-8?q?ba+c+IMYMDAUQJzosTYziNndXPszAOlHC7sEXLhjGYWdExqpWz1iMv2iuecdK78AT?= =?utf-8?q?DE3ZWQPikRTpwzgd4UWt9JEaT7nGzRnThYeNKKL03cLjXvW8naWYXHp0q+MQDSSkf?= =?utf-8?q?TbXMoHqKvGZS0zAokS/YW9Bu44IquxP3qRZTVy3nJyOIduclW5BTK6mQx00xjL4gs?= =?utf-8?q?8l9TxZ4GOlzA1xcUZZCcW+0DXj9RdsvqO3DAIrT4oRzOoW3TVeqdYnAYy/QIm7DQh?= =?utf-8?q?ke9RSGPaio1NZbkdiqS8Qrbh+PxFarfDKvMtuh7p6Vxx8HBvY7FaPIuF1snE4OFUI?= =?utf-8?q?0zkl+lmz3TFI1SPOjozQvGreKsMld3Dt5AD31q7uUYAvQYdCONIinA6DXAlGxL9dP?= =?utf-8?q?0VmEDIKl0+XzNDjSDZ7DDRg5JSofOFtSeQ9hjDno+338Wtj+SudXujPYL1Ja8+XCE?= =?utf-8?q?6XbO+wlHQbcLuNhtL+ikZjsi1ULqmPtY1Q/tfERj2dKmIz2c5P2Omu+ccGi5QDM5s?= =?utf-8?q?+ZGF1zk2LIO4E6AWCi64PXcGFoRnZMmc6yxcyjdPs0aDvQTfcaL0IM4ivGUJA79Hk?= =?utf-8?q?eqW1IvRSO6vgZkYJEmyxanZfJydMUMWK3hXtwUz4coy6Gohv5WDKWV+InOKX87lz1?= =?utf-8?q?sX4jq0Tqskl2wVpfUWNRN1Gq09DlbvKqA8EoEv39ZkkGcrdugg22i6eevrmYpOkip?= =?utf-8?q?+bWDcQrVLNqnVb9dd4zUS+caWVlNzWig3dRq88rlQDMe+x0KWpsbt1T4fgO3kfkp4?= =?utf-8?q?9wRAXbKMg0JCiYDr/ZWmpghglaJP9rwk+nmzZ9bKtB+2KFFTtzWj0qzFAkZFCwpVI?= =?utf-8?q?RX+Su3qaN6p2kiYN+U4M6ZQRtrG3wI9XCoSklCEUhINzTtmvwpb6Uw2AuRNbxeCHr?= =?utf-8?q?wWkhlfnoxA0Stm/ssWzXuoQK4CTJ2ihi0zIoiwqJBgIcz5oQax4Z045NZa+QNtsWL?= =?utf-8?q?ZK+4MvSCZe2X2JYqzM2s1QEjokXlXmGWO3A=3D=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:LO4P123MB5272.GBRP123.PROD.OUTLOOK.COM; PTR:; CAT:NONE; SFS:(13230040)(1800799024)(376014)(366016); DIR:OUT; SFP:1102 X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?q?XgYLHK9ZYYfPvsO618T6F81Dl/Nz?= =?utf-8?q?e/Ki+AVp3n2KtQXRCpTM5bOGIggEbEOm07ODBV8TeUow5ueuxdAfnrSeXnERBYSnP?= =?utf-8?q?i2DjYrhGUClmZr7mGjggvL3Xg0xtEjujmccUFH1HVoq0a2B6mfXgEEHTkgyCJxRiP?= =?utf-8?q?tGBj4DkxZ9e0cAmvzpJakHAL8eXeWONvQpc3KvrljZlG2cLESDQ/DXtfdaGV7+XrT?= =?utf-8?q?MEzScs53MP4oZ2sh1pgsJLiJ24czC5G5xf06+9YP/hoRsYg0EVgCXlznQMJALljeF?= =?utf-8?q?AuCYWcM9nDtFkIWMnModmYe1e25KNKOX6YSRp1Sd41em0NCCH3uo4TikoaKrSiZRm?= =?utf-8?q?nMCEY4N+KpPWkxKnD92zUN6HqZdS+A71wuYzB9fqyVVveHzuIoL6+y+OzbPsVpZwz?= =?utf-8?q?4zcvc/CJqHl2+DiuOX2SV2/D6o4dQZ+C7jxocxOe+IllPJK1CT+dSMjy8/QKzDSZo?= =?utf-8?q?VK8vYqm8n01XR5H8fzfqF+v6vb0TQdK+Vy0SGcSouuycFUZ6uiRb73BbdiSqN78kd?= =?utf-8?q?bdCgEQXqJwEE0XSzBDO2yiSvtaU3jlSCSnOaT3J+ENLg5FJXmXqMDRagoThZx4zUX?= =?utf-8?q?RBP7grp58EV9byn5lv4lPkidSz1trrbvLxMI/BFPD+lVXJyCRPKIXvp6A6gPCjsC4?= =?utf-8?q?Nworl4PE6UN5wRWJ6RllxA2pE+cjWjqEscequQhJfNujVXdVP2kGDsI6aOJoT2EXL?= =?utf-8?q?mGsbwZXWgYqfh2LSfSnre07FNlFJmkKFmkXFx6f7hs6xAU//7Xt8Hhu/JJn1C3aWJ?= =?utf-8?q?U8BTVQwG+WjC8opoc1LBVDAXcEb2RtNKJwo508l+98RqZGH9f5OTxaiLoT0c/LHbQ?= =?utf-8?q?NsY/5ihDq7lg2Kj357R/6EZj5RZRg1D1HZxa3LBWMo4+seZHRWcgWoJtDcT9RGzRu?= =?utf-8?q?ZymNmZ0WiS2ZXHICD6+ZDCzwgq3qlsUkApCri4352Ul65+b0CsaFFjwXnaVYi4HqT?= =?utf-8?q?KalxOODvByPdk5Iyy9ukhLM4bwlnMxVt+Qr7kVzoHVeKG7au4sxjefC5T0z33GrGw?= =?utf-8?q?5PUElxkuA3By8uo4J1jEgKbQO9bdaH76MfGFYi9Jnu8ulO+g6em7TexGVfACQeMX4?= =?utf-8?q?Lq0e11GdMUfba3z1oBEeVqd32ciImLXUpVyCDyoICOdWIDAJQ/kY6Wynt9jo3+80u?= =?utf-8?q?6Q6YQW1XF9Y05RF87lKmrI/a9WlZ7pFrWTCp2HFS2kSBPWWx2jXDK/14HmqGU1F4L?= =?utf-8?q?vwTKlkbw7HRUj1Ft4II3yTKPHK3Fivxrcw8wzHLIYPbiTsD3/onelBqU43D5XiUhr?= =?utf-8?q?axAUK8HioENXSgRAii7jGIdoCraGmBk8T6J1x4CkhGEdB+7GnJtp0KTgS0u07mpJz?= =?utf-8?q?craZYZ+5fhvZ4EnVlCJ/tkDtHbUVeVgh4OZ3eCvOE/jX0u54j5/ahcttkk4Z9W+Fe?= =?utf-8?q?GmdGntQW3JFDDJuK0Fb5oVCycl/sA57IlBjnSHytoN4OAtGTvK1ZzNZmPIyldrC+M?= =?utf-8?q?m/10ZJmxjTEsWSozsOPKarB0XzQVGOYHh9McbVnVdN1qInBMsYYN9UWMl0c5Y98pr?= =?utf-8?q?MxqHG/7tEI9wNbJ2UlGapJNAS64+QtlwWtwlvCsXRFJN8SKNLZhSOyqc3pThLZ8tZ?= =?utf-8?q?Y2c30bG4rB3tijDwjAZeoxReXtC1xOWZA=3D=3D?= X-OriginatorOrg: camlingroup.com X-MS-Exchange-CrossTenant-Network-Message-Id: 6dffcdac-b3c7-4202-e9a7-08dcc3944b4a X-MS-Exchange-CrossTenant-AuthSource: LO4P123MB5272.GBRP123.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Aug 2024 16:54:46.6601 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: fd4b1729-b18d-46d2-9ba0-2717b852b252 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: cLBwOgcMQcNO2w3ITjaVi2jn/6qgOUaErsnt/Of2s56Eh7cZCRyuQT0V2KW2fkQ4GxLfSBOPwGsVX+1YlzbW4Ks1dLBQ07hy7v3oPkd1k1g= X-MS-Exchange-Transport-CrossTenantHeadersStamped: CWLP123MB3105 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: camlingroup.com Content-Language: en-US Comments attached to bits 0 and 1 incorrectly referenced bits 2 and 3, which don't match the datasheet - fix them. At the same time remove comments for individual constants, as they add nothing to the definitions themselves. Signed-off-by: Lech Perczak --- Cc: Greg Kroah-Hartman Cc: Jiri Slaby Cc: Hugo Villeneuve Cc: Andy Shevchenko --- drivers/tty/serial/sc16is7xx.c | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/drivers/tty/serial/sc16is7xx.c b/drivers/tty/serial/sc16is7xx.c index 8a2020f9930e..36b7c682ae94 100644 --- a/drivers/tty/serial/sc16is7xx.c +++ b/drivers/tty/serial/sc16is7xx.c @@ -266,9 +266,9 @@ * and writing to IER[7:4], * FCR[5:4], MCR[7:5] */ -#define SC16IS7XX_EFR_SWFLOW3_BIT (1 << 3) /* SWFLOW bit 3 */ -#define SC16IS7XX_EFR_SWFLOW2_BIT (1 << 2) /* SWFLOW bit 2 - * +#define SC16IS7XX_EFR_SWFLOW3_BIT (1 << 3) +#define SC16IS7XX_EFR_SWFLOW2_BIT (1 << 2) + /* * SWFLOW bits 3 & 2 table: * 00 -> no transmitter flow * control @@ -280,10 +280,10 @@ * XON1, XON2, XOFF1 and * XOFF2 */ -#define SC16IS7XX_EFR_SWFLOW1_BIT (1 << 1) /* SWFLOW bit 2 */ -#define SC16IS7XX_EFR_SWFLOW0_BIT (1 << 0) /* SWFLOW bit 3 - * - * SWFLOW bits 3 & 2 table: +#define SC16IS7XX_EFR_SWFLOW1_BIT (1 << 1) +#define SC16IS7XX_EFR_SWFLOW0_BIT (1 << 0) + /* + * SWFLOW bits 1 & 0 table: * 00 -> no received flow * control * 01 -> receiver compares From patchwork Fri Aug 23 16:55:44 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lech Perczak X-Patchwork-Id: 822347 Received: from eu-smtp-delivery-197.mimecast.com (eu-smtp-delivery-197.mimecast.com [185.58.86.197]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id ACDD718594C for ; Fri, 23 Aug 2024 16:55:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.58.86.197 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1724432152; cv=none; b=MrA8a78BbqjlRxko/lJ0m8P6RusksMXmlIBLKKd4kkG5vbF4xe+bYC9Fjkjtx4OLm5vsJ5bDddvEld/oQbYl1unDMKcZSG7D1xSYBmBtqrPNsAxTKqoba9Z2aYs4v1JETHLfjeROPNT4cy0dBAELIMQ/z60beYc79PbsRRoK6J4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1724432152; c=relaxed/simple; bh=X3ZBB/mDgG1Kjzde5mia5pf0TbgzFFqzHif36Q4Mn8I=; h=Message-ID:Date:Subject:From:To:Cc:References:In-Reply-To: MIME-Version:Content-Type; b=XSU6Oac9GDUiJK6sq8qkldLUHt0CdpUQ+xXseytfyfBrFK7kvblrmgqB4P5PjtZzABnmbRgKc/WxPiKVdnSbpF3ass4hjnUX8S4ssztynLUurYSXiaiwuAc+SqIdK+oGntwzmn49to+Relms31He6sYFEqnrm0MW2bA6QHyUHIc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=camlingroup.com; spf=pass smtp.mailfrom=camlingroup.com; dkim=pass (1024-bit key) header.d=camlingroup.com header.i=@camlingroup.com header.b=di/ixNTS; arc=none smtp.client-ip=185.58.86.197 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=camlingroup.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=camlingroup.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=camlingroup.com header.i=@camlingroup.com header.b="di/ixNTS" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=camlingroup.com; s=mimecast20210310; t=1724432149; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=CwOU/ElRbhXXjWKHwmDDxUlaVScH9TJ6tydmUNi9wD8=; b=di/ixNTSZNh2bfywqrR8fK5fWptAKYexs6b7u8cmlel1HiaHl4bPRfhpMibnFx0+4fI+Bs OJb5XrISb5bGs4mMPkU8zaYt1FwFHdlLOJpjRzNOkswsKMSoBM3VT7cTuypwyf0rojv0FK PUEHN2fz0jEHIrXP8o5BJAIaCnwi5iI= Received: from GBR01-CWX-obe.outbound.protection.outlook.com (mail-cwxgbr01lp2049.outbound.protection.outlook.com [104.47.85.49]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id uk-mta-169-b-PLD-GCPMGLbSaUVbQa2g-1; Fri, 23 Aug 2024 17:55:48 +0100 X-MC-Unique: b-PLD-GCPMGLbSaUVbQa2g-1 Received: from LO4P123MB5272.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:20b::7) by CWLP123MB3105.GBRP123.PROD.OUTLOOK.COM (2603:10a6:400:5c::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7897.19; Fri, 23 Aug 2024 16:55:46 +0000 Received: from LO4P123MB5272.GBRP123.PROD.OUTLOOK.COM ([fe80::55a9:7dae:8812:f567]) by LO4P123MB5272.GBRP123.PROD.OUTLOOK.COM ([fe80::55a9:7dae:8812:f567%5]) with mapi id 15.20.7897.014; Fri, 23 Aug 2024 16:55:46 +0000 Message-ID: Date: Fri, 23 Aug 2024 18:55:44 +0200 User-Agent: Mozilla Thunderbird Subject: [PATCH v3 3/3] serial: sc16is7xx: convert bitmask definitions to use BIT() macro From: Lech Perczak To: linux-serial@vger.kernel.org, "linux-kernel@vger.kernel.org" Cc: Greg Kroah-Hartman , Jiri Slaby , Hugo Villeneuve , Andy Shevchenko , =?utf-8?q?Krzysztof_Drobi=C5=84ski?= , =?utf-8?q?Pawe=C5=82_Lenkow?= , Kirill Yatsenko References: <7deb753f-bf86-47ce-89bf-8277aca4293e@camlingroup.com> In-Reply-To: <7deb753f-bf86-47ce-89bf-8277aca4293e@camlingroup.com> X-ClientProxiedBy: WA2P291CA0005.POLP291.PROD.OUTLOOK.COM (2603:10a6:1d0:1e::11) To LO4P123MB5272.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:20b::7) Precedence: bulk X-Mailing-List: linux-serial@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: LO4P123MB5272:EE_|CWLP123MB3105:EE_ X-MS-Office365-Filtering-Correlation-Id: cd508958-bac7-44a4-5c6a-08dcc3946f0c X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|376014|366016 X-Microsoft-Antispam-Message-Info: =?utf-8?q?3QTrs/mAbE5VGfw9yCPvvUa1mryfbnm?= =?utf-8?q?TSxq/l4G/Dlom5u01cdF8Hwi5+X2np35qcYohg9J2WfhNfIwYW32g0vqncGanFBdO?= =?utf-8?q?SZUVhDDgIVmnMO/huNIUf4aRzgMQZ/m4DRNaaXk+D/LYYmeENxQhR51RMoP1XH0RY?= =?utf-8?q?dxcq/RM2Ac04zPFgFgNY0hli/9c8MaxzlhuggOV8yMW6fBNy6E27TjC6y88d9q63L?= =?utf-8?q?CXDb7kf3cVGMnE+VqjKBOTL5Bc3SbS0T7XdkKhwHx0OFP0NbXnzGcf2P596q7O4cZ?= =?utf-8?q?Q3QQff02ksBqGAFXUF8hOX90ZSAqH6GGcFiR1e8vUxXdYfUGU65pPZsI+eLGeKw5G?= =?utf-8?q?0WuM3g2Z3JUMl9LIWYIkTF7kl4R+m6CCxn5D0D7pIylSBBkW1zMNhfp4qNeSN1WGQ?= =?utf-8?q?H1CtGSkbYox0wXgQw7uHqs81L/As0/1PVBBd6P1OVpE84G2ACaZCmUD9QoLWCxzwV?= =?utf-8?q?ysgZ4qGyhXqsSXq6KOv76ZYVHvtS5Qel+dl3aYng3PemRbPO2hHuHLZlQQmj7ExRZ?= =?utf-8?q?7HO8vKtocyBL88tNT13HDOqy+xxLaXZfrUqeL+Sq0hP6mamOoHceXjnggMYSV54zu?= =?utf-8?q?NtGrP2JK0L8oqQlFmc48tuU7ERf9av4/jqXmTX4BhZPEKMahCVHOYjAhjztzx1J5g?= =?utf-8?q?33t6CttVq7WdAHLqW6josL2hTBMyE5OrXOPD/TbPxj3FM0RKOzfDvg0tLaO6XgXmJ?= =?utf-8?q?cnhd4fQdjfTtrAPwiyTUVZhce5MSlGpweG9qVby8MUtxHnWXUdVIeSF5T49bGx7IY?= =?utf-8?q?wzzGrH3M5IwH1h5/p38VCfxZQMD5MxNJT2MgYh+IgPIGdrNt8n3fTltPVQ+uyIFcX?= =?utf-8?q?Bw/dIqiLkTxxiJj8YXWEcInwL2vbbrPyEBdgSreRBoPce6UeQln24nm3Sqk1ZKwZO?= =?utf-8?q?yAmuE0T+xbzhpdUcFNV3O72duOEEVfxY5r+pauldZawCk0rgotHu3nAXGQUvs62Jz?= =?utf-8?q?0cpsX7SwzRZJcwxKbOiijO73rmWfdQjO8rJ3DRMGzWvZNxmOB/iYJGfpxJCiUST3L?= =?utf-8?q?CsK/pg0KwS0/OUQYYvZj7Tj2J3X4oyQ94SzVAnQvOc5bFKm4e8/8TbxrvQwuXPrPl?= =?utf-8?q?vcxY5OiDrdJLAegQByvNQlwghYs9ZntfbWAg8M4+HvcdlymFcFOl1v5pxC/OxMRxA?= =?utf-8?q?NzdpanQD5yW0SHGJu+WfkV07E6mXvTq0zQ6Akj628KFQ9HAiLAQ9eoy4pWq5E700L?= =?utf-8?q?ilzGibIqE8t/uBS4LLD4DtMNXKuXIASnYVoQnuvw4zW5CMl/C7aKT8MzDtvcXULVo?= =?utf-8?q?ljP8kNxBopKqFR30rO7s02/JV68N9WjhU6Q=3D=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:LO4P123MB5272.GBRP123.PROD.OUTLOOK.COM; PTR:; CAT:NONE; SFS:(13230040)(1800799024)(376014)(366016); DIR:OUT; SFP:1102 X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?q?fKadI5nh7/jrHFUGuqQTL5Ab0HaO?= =?utf-8?q?mlyxY8NTivuOpdxR+BoTS6DrIMlB+ReDX7LBoetQ9yM+tg30qC+5zoE+VnMFQNa4h?= =?utf-8?q?hI1eO+aubag54oYud7UXhFxqCFfFLlQou3FLwI3To+MPLrqZzCJDPBDyLodqUhzPx?= =?utf-8?q?wzNRywYa+qXQ5koPriNHwAjM4XwWCiFwnzP4rvQNyytt2R67azn2Rc031bHoXMI/E?= =?utf-8?q?LnTuwWEsfa+trSlirrgz71FbiaQhduuQvNX5KP7JxXiTuC4SV60lcb0VuPHWVUbdo?= =?utf-8?q?zV8ePwzqQbYw3O6BoUVLeQcoj+JK84Mvm+6BV5FoZqXbcDP8vv5R1tSsDtyOFZ1eK?= =?utf-8?q?wadaJfRb0RMmtqQ6TduNJ4SnpwChVJCHS42jKU0cbBYkAUrpdrAIXzQZUkKD594hB?= =?utf-8?q?2DwRMUAJMjQK7vZ0woy8EQwUCGVo1GUg3tJ7BPkGdhWVp/iuHNSe0yG1ogQsEPKnA?= =?utf-8?q?/balenv0bJDC1HXP9bcXRG4RqjDWf5YSh565PpUC8oB/s8GljSScraH1GjxwRI1mf?= =?utf-8?q?SCBRLXjPSmGj0j0yC7IGyRcknKS/tBUoBmLfWsOcZtPReqzOPwD3AxyQuWP1YWU5v?= =?utf-8?q?CKDwVH9Q4dmT4fIcH2PRTn6GiNT5ftBvmRoAHyrLlmYsFOzoMuO5fgRovNgz80tHg?= =?utf-8?q?7QyMv8dlNHUBSfjipp/wQgxVvzPUMICXpWEuI9P3xOQYvrLx7cNYA0KeMZYXKL3ig?= =?utf-8?q?Arg8Kxz0DBZoUKMJeCO6HdY6SQ9idTsA+DEkw2tKsUQZ0uFtNv7uTx291FfmiuxY7?= =?utf-8?q?vJBz1zCyiR35bhRiDfdkrV3Jf7sv107jMfBMsEzY458yHnWwV47QTIFQMaA8FltQk?= =?utf-8?q?6NL/+GG8UK5WGy/z5wV09bJjLE14nBxGZmgCtunXLp/uRT2Ngf6/EfagKMWgvIgBF?= =?utf-8?q?J0E/g4PtCctbMWEygzdJ61j5RXbOeZQyjite6/QSwdQTHrJy08GftEYilLrVYb6df?= =?utf-8?q?79ZypHHGyWlnU7TF2uuQm6aOd/5nlnMH9qsumvNkDM25rihh+ggkYo5rcRZo3HvIt?= =?utf-8?q?ToMx3c5l7PZk6dTB+5H8uMLT3E81jKJVTOlODA3L6w80pbIhXtXq3N7VGDmnG7LXy?= =?utf-8?q?GOKZcJBgdmkIgUrcNSDVQLjj1Pq2V4tjzThinet81XabvHL3wCD+/L/pp/GXGigvz?= =?utf-8?q?Scih596MdvJVR7W1lnwh+ySQSYnRwqanYUXm6/LnopSxgJ9P5WEvfL6yFbbWGUM2s?= =?utf-8?q?kg2EotTiWZA8XTFHOBNV83CE+cGB+6W7lMVzvCeBxrjh7FlT9TNsc+aXGIV4Gf4yN?= =?utf-8?q?w4b9Eebzs+2ijIHdq/clMELEbyACC+wsoh5o/PNxYYNaH7huK/gRFUGWOSjKe6UPe?= =?utf-8?q?O6SkL1DvZlg/DMcJHnI3DXcprdakF3N2Pw1pFwZV2mfUdTW7IYDSXvLICkUYk1O+/?= =?utf-8?q?UyXd36xbPkvXPn79wecJhIcgHGyIagwQuBzTAfYITFENewxMypg7AGNbJIeSg7tzy?= =?utf-8?q?DduqXkLnTK+SGlUwkNf6JZ7hu6dqEkkdpNMvjEwc/E7J3OOhPvjBZHJ3QhoZCmgye?= =?utf-8?q?FmT2o8VB4197ZtN19WLjmtAVdouY5hZWbr4TgJg8EQwe7DdACByGa0JOkzBL+P3yU?= =?utf-8?q?+fMnprVrHRHKDpABasFYzFTtzbMdvPyDw=3D=3D?= X-OriginatorOrg: camlingroup.com X-MS-Exchange-CrossTenant-Network-Message-Id: cd508958-bac7-44a4-5c6a-08dcc3946f0c X-MS-Exchange-CrossTenant-AuthSource: LO4P123MB5272.GBRP123.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Aug 2024 16:55:46.6344 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: fd4b1729-b18d-46d2-9ba0-2717b852b252 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: De2EjTdwDXj5e91WxLP/BuV8TGI4i8/4l6BcBexfWNA0p0wEF71WixavQh1sm6DskR2AIfwDDcnuops6kpUOm5qxpCGqx8mohbXt0+S0OYI= X-MS-Exchange-Transport-CrossTenantHeadersStamped: CWLP123MB3105 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: camlingroup.com Content-Language: en-US Now that bit definition comments were cleaned up, convert bitmask definitions to use BIT() macro for clarity. Convert SC16IS7XX_IIR_* bitmask constants, to use GENMASK() macro, where applicable - while at that, realign comments. Compose SC16IS7XX_LSR_BRK_ERROR_MASK using aforementioned constants, instead of open-coding it, and remove now unneeded comment. Signed-off-by: Lech Perczak --- Cc: Greg Kroah-Hartman Cc: Jiri Slaby Cc: Hugo Villeneuve Cc: Andy Shevchenko --- drivers/tty/serial/sc16is7xx.c | 174 +++++++++++++++++---------------- 1 file changed, 89 insertions(+), 85 deletions(-) diff --git a/drivers/tty/serial/sc16is7xx.c b/drivers/tty/serial/sc16is7xx.c index 36b7c682ae94..68fdb2dee414 100644 --- a/drivers/tty/serial/sc16is7xx.c +++ b/drivers/tty/serial/sc16is7xx.c @@ -10,6 +10,7 @@ #undef DEFAULT_SYMBOL_NAMESPACE #define DEFAULT_SYMBOL_NAMESPACE SERIAL_NXP_SC16IS7XX +#include #include #include #include @@ -77,52 +78,52 @@ #define SC16IS7XX_XOFF2_REG (0x07) /* Xoff2 word */ /* IER register bits */ -#define SC16IS7XX_IER_RDI_BIT (1 << 0) /* Enable RX data interrupt */ -#define SC16IS7XX_IER_THRI_BIT (1 << 1) /* Enable TX holding register +#define SC16IS7XX_IER_RDI_BIT BIT(0) /* Enable RX data interrupt */ +#define SC16IS7XX_IER_THRI_BIT BIT(1) /* Enable TX holding register * interrupt */ -#define SC16IS7XX_IER_RLSI_BIT (1 << 2) /* Enable RX line status +#define SC16IS7XX_IER_RLSI_BIT BIT(2) /* Enable RX line status * interrupt */ -#define SC16IS7XX_IER_MSI_BIT (1 << 3) /* Enable Modem status +#define SC16IS7XX_IER_MSI_BIT BIT(3) /* Enable Modem status * interrupt */ /* IER register bits - write only if (EFR[4] == 1) */ -#define SC16IS7XX_IER_SLEEP_BIT (1 << 4) /* Enable Sleep mode */ -#define SC16IS7XX_IER_XOFFI_BIT (1 << 5) /* Enable Xoff interrupt */ -#define SC16IS7XX_IER_RTSI_BIT (1 << 6) /* Enable nRTS interrupt */ -#define SC16IS7XX_IER_CTSI_BIT (1 << 7) /* Enable nCTS interrupt */ +#define SC16IS7XX_IER_SLEEP_BIT BIT(4) /* Enable Sleep mode */ +#define SC16IS7XX_IER_XOFFI_BIT BIT(5) /* Enable Xoff interrupt */ +#define SC16IS7XX_IER_RTSI_BIT BIT(6) /* Enable nRTS interrupt */ +#define SC16IS7XX_IER_CTSI_BIT BIT(7) /* Enable nCTS interrupt */ /* FCR register bits */ -#define SC16IS7XX_FCR_FIFO_BIT (1 << 0) /* Enable FIFO */ -#define SC16IS7XX_FCR_RXRESET_BIT (1 << 1) /* Reset RX FIFO */ -#define SC16IS7XX_FCR_TXRESET_BIT (1 << 2) /* Reset TX FIFO */ -#define SC16IS7XX_FCR_RXLVLL_BIT (1 << 6) /* RX Trigger level LSB */ -#define SC16IS7XX_FCR_RXLVLH_BIT (1 << 7) /* RX Trigger level MSB */ +#define SC16IS7XX_FCR_FIFO_BIT BIT(0) /* Enable FIFO */ +#define SC16IS7XX_FCR_RXRESET_BIT BIT(1) /* Reset RX FIFO */ +#define SC16IS7XX_FCR_TXRESET_BIT BIT(2) /* Reset TX FIFO */ +#define SC16IS7XX_FCR_RXLVLL_BIT BIT(6) /* RX Trigger level LSB */ +#define SC16IS7XX_FCR_RXLVLH_BIT BIT(7) /* RX Trigger level MSB */ /* FCR register bits - write only if (EFR[4] == 1) */ -#define SC16IS7XX_FCR_TXLVLL_BIT (1 << 4) /* TX Trigger level LSB */ -#define SC16IS7XX_FCR_TXLVLH_BIT (1 << 5) /* TX Trigger level MSB */ +#define SC16IS7XX_FCR_TXLVLL_BIT BIT(4) /* TX Trigger level LSB */ +#define SC16IS7XX_FCR_TXLVLH_BIT BIT(5) /* TX Trigger level MSB */ /* IIR register bits */ -#define SC16IS7XX_IIR_NO_INT_BIT (1 << 0) /* No interrupts pending */ -#define SC16IS7XX_IIR_ID_MASK 0x3e /* Mask for the interrupt ID */ -#define SC16IS7XX_IIR_THRI_SRC 0x02 /* TX holding register empty */ -#define SC16IS7XX_IIR_RDI_SRC 0x04 /* RX data interrupt */ -#define SC16IS7XX_IIR_RLSE_SRC 0x06 /* RX line status error */ -#define SC16IS7XX_IIR_RTOI_SRC 0x0c /* RX time-out interrupt */ -#define SC16IS7XX_IIR_MSI_SRC 0x00 /* Modem status interrupt - * - only on 75x/76x - */ -#define SC16IS7XX_IIR_INPIN_SRC 0x30 /* Input pin change of state - * - only on 75x/76x - */ -#define SC16IS7XX_IIR_XOFFI_SRC 0x10 /* Received Xoff */ -#define SC16IS7XX_IIR_CTSRTS_SRC 0x20 /* nCTS,nRTS change of state - * from active (LOW) - * to inactive (HIGH) - */ +#define SC16IS7XX_IIR_NO_INT_BIT BIT(0) /* No interrupts pending */ +#define SC16IS7XX_IIR_ID_MASK GENMASK(5,1) /* Mask for the interrupt ID */ +#define SC16IS7XX_IIR_THRI_SRC BIT(1) /* TX holding register empty */ +#define SC16IS7XX_IIR_RDI_SRC BIT(2) /* RX data interrupt */ +#define SC16IS7XX_IIR_RLSE_SRC GENMASK(2,1) /* RX line status error */ +#define SC16IS7XX_IIR_RTOI_SRC GENMASK(3,2) /* RX time-out interrupt */ +#define SC16IS7XX_IIR_MSI_SRC 0x00 /* Modem status interrupt + * - only on 75x/76x + */ +#define SC16IS7XX_IIR_INPIN_SRC GENMASK(5,4) /* Input pin change of state + * - only on 75x/76x + */ +#define SC16IS7XX_IIR_XOFFI_SRC BIT(4) /* Received Xoff */ +#define SC16IS7XX_IIR_CTSRTS_SRC BIT(5) /* nCTS,nRTS change of state + * from active (LOW) + * to inactive (HIGH) + */ /* LCR register bits */ -#define SC16IS7XX_LCR_LENGTH0_BIT (1 << 0) /* Word length bit 0 */ -#define SC16IS7XX_LCR_LENGTH1_BIT (1 << 1) /* Word length bit 1 +#define SC16IS7XX_LCR_LENGTH0_BIT BIT(0) /* Word length bit 0 */ +#define SC16IS7XX_LCR_LENGTH1_BIT BIT(1) /* Word length bit 1 * * Word length bits table: * 00 -> 5 bit words @@ -130,7 +131,7 @@ * 10 -> 7 bit words * 11 -> 8 bit words */ -#define SC16IS7XX_LCR_STOPLEN_BIT (1 << 2) /* STOP length bit +#define SC16IS7XX_LCR_STOPLEN_BIT BIT(2) /* STOP length bit * * STOP length bit table: * 0 -> 1 stop bit @@ -138,11 +139,11 @@ * word length is 5, * 2 stop bits otherwise */ -#define SC16IS7XX_LCR_PARITY_BIT (1 << 3) /* Parity bit enable */ -#define SC16IS7XX_LCR_EVENPARITY_BIT (1 << 4) /* Even parity bit enable */ -#define SC16IS7XX_LCR_FORCEPARITY_BIT (1 << 5) /* 9-bit multidrop parity */ -#define SC16IS7XX_LCR_TXBREAK_BIT (1 << 6) /* TX break enable */ -#define SC16IS7XX_LCR_DLAB_BIT (1 << 7) /* Divisor Latch enable */ +#define SC16IS7XX_LCR_PARITY_BIT BIT(3) /* Parity bit enable */ +#define SC16IS7XX_LCR_EVENPARITY_BIT BIT(4) /* Even parity bit enable */ +#define SC16IS7XX_LCR_FORCEPARITY_BIT BIT(5) /* 9-bit multidrop parity */ +#define SC16IS7XX_LCR_TXBREAK_BIT BIT(6) /* TX break enable */ +#define SC16IS7XX_LCR_DLAB_BIT BIT(7) /* Divisor Latch enable */ #define SC16IS7XX_LCR_WORD_LEN_5 (0x00) #define SC16IS7XX_LCR_WORD_LEN_6 (0x01) #define SC16IS7XX_LCR_WORD_LEN_7 (0x02) @@ -153,58 +154,61 @@ * reg set */ /* MCR register bits */ -#define SC16IS7XX_MCR_DTR_BIT (1 << 0) /* DTR complement +#define SC16IS7XX_MCR_DTR_BIT BIT(0) /* DTR complement * - only on 75x/76x */ -#define SC16IS7XX_MCR_RTS_BIT (1 << 1) /* RTS complement */ -#define SC16IS7XX_MCR_TCRTLR_BIT (1 << 2) /* TCR/TLR register enable */ -#define SC16IS7XX_MCR_LOOP_BIT (1 << 4) /* Enable loopback test mode */ -#define SC16IS7XX_MCR_XONANY_BIT (1 << 5) /* Enable Xon Any +#define SC16IS7XX_MCR_RTS_BIT BIT(1) /* RTS complement */ +#define SC16IS7XX_MCR_TCRTLR_BIT BIT(2) /* TCR/TLR register enable */ +#define SC16IS7XX_MCR_LOOP_BIT BIT(4) /* Enable loopback test mode */ +#define SC16IS7XX_MCR_XONANY_BIT BIT(5) /* Enable Xon Any * - write enabled * if (EFR[4] == 1) */ -#define SC16IS7XX_MCR_IRDA_BIT (1 << 6) /* Enable IrDA mode +#define SC16IS7XX_MCR_IRDA_BIT BIT(6) /* Enable IrDA mode * - write enabled * if (EFR[4] == 1) */ -#define SC16IS7XX_MCR_CLKSEL_BIT (1 << 7) /* Divide clock by 4 +#define SC16IS7XX_MCR_CLKSEL_BIT BIT(7) /* Divide clock by 4 * - write enabled * if (EFR[4] == 1) */ /* LSR register bits */ -#define SC16IS7XX_LSR_DR_BIT (1 << 0) /* Receiver data ready */ -#define SC16IS7XX_LSR_OE_BIT (1 << 1) /* Overrun Error */ -#define SC16IS7XX_LSR_PE_BIT (1 << 2) /* Parity Error */ -#define SC16IS7XX_LSR_FE_BIT (1 << 3) /* Frame Error */ -#define SC16IS7XX_LSR_BI_BIT (1 << 4) /* Break Interrupt */ -#define SC16IS7XX_LSR_BRK_ERROR_MASK 0x1E /* BI, FE, PE, OE bits */ -#define SC16IS7XX_LSR_THRE_BIT (1 << 5) /* TX holding register empty */ -#define SC16IS7XX_LSR_TEMT_BIT (1 << 6) /* Transmitter empty */ -#define SC16IS7XX_LSR_FIFOE_BIT (1 << 7) /* Fifo Error */ +#define SC16IS7XX_LSR_DR_BIT BIT(0) /* Receiver data ready */ +#define SC16IS7XX_LSR_OE_BIT BIT(1) /* Overrun Error */ +#define SC16IS7XX_LSR_PE_BIT BIT(2) /* Parity Error */ +#define SC16IS7XX_LSR_FE_BIT BIT(3) /* Frame Error */ +#define SC16IS7XX_LSR_BI_BIT BIT(4) /* Break Interrupt */ +#define SC16IS7XX_LSR_BRK_ERROR_MASK (SC16IS7XX_LSR_OE_BIT | \ + SC16IS7XX_LSR_PE_BIT | \ + SC16IS7XX_LSR_FE_BIT | \ + SC16IS7XX_LSR_BI_BIT) +#define SC16IS7XX_LSR_THRE_BIT BIT(5) /* TX holding register empty */ +#define SC16IS7XX_LSR_TEMT_BIT BIT(6) /* Transmitter empty */ +#define SC16IS7XX_LSR_FIFOE_BIT BIT(7) /* Fifo Error */ /* MSR register bits */ -#define SC16IS7XX_MSR_DCTS_BIT (1 << 0) /* Delta CTS Clear To Send */ -#define SC16IS7XX_MSR_DDSR_BIT (1 << 1) /* Delta DSR Data Set Ready +#define SC16IS7XX_MSR_DCTS_BIT BIT(0) /* Delta CTS Clear To Send */ +#define SC16IS7XX_MSR_DDSR_BIT BIT(1) /* Delta DSR Data Set Ready * or (IO4) * - only on 75x/76x */ -#define SC16IS7XX_MSR_DRI_BIT (1 << 2) /* Delta RI Ring Indicator +#define SC16IS7XX_MSR_DRI_BIT BIT(2) /* Delta RI Ring Indicator * or (IO7) * - only on 75x/76x */ -#define SC16IS7XX_MSR_DCD_BIT (1 << 3) /* Delta CD Carrier Detect +#define SC16IS7XX_MSR_DCD_BIT BIT(3) /* Delta CD Carrier Detect * or (IO6) * - only on 75x/76x */ -#define SC16IS7XX_MSR_CTS_BIT (1 << 4) /* CTS */ -#define SC16IS7XX_MSR_DSR_BIT (1 << 5) /* DSR (IO4) +#define SC16IS7XX_MSR_CTS_BIT BIT(4) /* CTS */ +#define SC16IS7XX_MSR_DSR_BIT BIT(5) /* DSR (IO4) * - only on 75x/76x */ -#define SC16IS7XX_MSR_RI_BIT (1 << 6) /* RI (IO7) +#define SC16IS7XX_MSR_RI_BIT BIT(6) /* RI (IO7) * - only on 75x/76x */ -#define SC16IS7XX_MSR_CD_BIT (1 << 7) /* CD (IO6) +#define SC16IS7XX_MSR_CD_BIT BIT(7) /* CD (IO6) * - only on 75x/76x */ @@ -239,19 +243,19 @@ #define SC16IS7XX_TLR_RX_TRIGGER(words) ((((words) / 4) & 0x0f) << 4) /* IOControl register bits (Only 75x/76x) */ -#define SC16IS7XX_IOCONTROL_LATCH_BIT (1 << 0) /* Enable input latching */ -#define SC16IS7XX_IOCONTROL_MODEM_A_BIT (1 << 1) /* Enable GPIO[7:4] as modem A pins */ -#define SC16IS7XX_IOCONTROL_MODEM_B_BIT (1 << 2) /* Enable GPIO[3:0] as modem B pins */ -#define SC16IS7XX_IOCONTROL_SRESET_BIT (1 << 3) /* Software Reset */ +#define SC16IS7XX_IOCONTROL_LATCH_BIT BIT(0) /* Enable input latching */ +#define SC16IS7XX_IOCONTROL_MODEM_A_BIT BIT(1) /* Enable GPIO[7:4] as modem A pins */ +#define SC16IS7XX_IOCONTROL_MODEM_B_BIT BIT(2) /* Enable GPIO[3:0] as modem B pins */ +#define SC16IS7XX_IOCONTROL_SRESET_BIT BIT(3) /* Software Reset */ /* EFCR register bits */ -#define SC16IS7XX_EFCR_9BIT_MODE_BIT (1 << 0) /* Enable 9-bit or Multidrop +#define SC16IS7XX_EFCR_9BIT_MODE_BIT BIT(0) /* Enable 9-bit or Multidrop * mode (RS485) */ -#define SC16IS7XX_EFCR_RXDISABLE_BIT (1 << 1) /* Disable receiver */ -#define SC16IS7XX_EFCR_TXDISABLE_BIT (1 << 2) /* Disable transmitter */ -#define SC16IS7XX_EFCR_AUTO_RS485_BIT (1 << 4) /* Auto RS485 RTS direction */ -#define SC16IS7XX_EFCR_RTS_INVERT_BIT (1 << 5) /* RTS output inversion */ -#define SC16IS7XX_EFCR_IRDA_MODE_BIT (1 << 7) /* IrDA mode +#define SC16IS7XX_EFCR_RXDISABLE_BIT BIT(1) /* Disable receiver */ +#define SC16IS7XX_EFCR_TXDISABLE_BIT BIT(2) /* Disable transmitter */ +#define SC16IS7XX_EFCR_AUTO_RS485_BIT BIT(4) /* Auto RS485 RTS direction */ +#define SC16IS7XX_EFCR_RTS_INVERT_BIT BIT(5) /* RTS output inversion */ +#define SC16IS7XX_EFCR_IRDA_MODE_BIT BIT(7) /* IrDA mode * 0 = rate upto 115.2 kbit/s * - Only 75x/76x * 1 = rate upto 1.152 Mbit/s @@ -259,15 +263,15 @@ */ /* EFR register bits */ -#define SC16IS7XX_EFR_AUTORTS_BIT (1 << 6) /* Auto RTS flow ctrl enable */ -#define SC16IS7XX_EFR_AUTOCTS_BIT (1 << 7) /* Auto CTS flow ctrl enable */ -#define SC16IS7XX_EFR_XOFF2_DETECT_BIT (1 << 5) /* Enable Xoff2 detection */ -#define SC16IS7XX_EFR_ENABLE_BIT (1 << 4) /* Enable enhanced functions +#define SC16IS7XX_EFR_AUTORTS_BIT BIT(6) /* Auto RTS flow ctrl enable */ +#define SC16IS7XX_EFR_AUTOCTS_BIT BIT(7) /* Auto CTS flow ctrl enable */ +#define SC16IS7XX_EFR_XOFF2_DETECT_BIT BIT(5) /* Enable Xoff2 detection */ +#define SC16IS7XX_EFR_ENABLE_BIT BIT(4) /* Enable enhanced functions * and writing to IER[7:4], * FCR[5:4], MCR[7:5] */ -#define SC16IS7XX_EFR_SWFLOW3_BIT (1 << 3) -#define SC16IS7XX_EFR_SWFLOW2_BIT (1 << 2) +#define SC16IS7XX_EFR_SWFLOW3_BIT BIT(3) +#define SC16IS7XX_EFR_SWFLOW2_BIT BIT(2) /* * SWFLOW bits 3 & 2 table: * 00 -> no transmitter flow @@ -280,8 +284,8 @@ * XON1, XON2, XOFF1 and * XOFF2 */ -#define SC16IS7XX_EFR_SWFLOW1_BIT (1 << 1) -#define SC16IS7XX_EFR_SWFLOW0_BIT (1 << 0) +#define SC16IS7XX_EFR_SWFLOW1_BIT BIT(1) +#define SC16IS7XX_EFR_SWFLOW0_BIT BIT(0) /* * SWFLOW bits 1 & 0 table: * 00 -> no received flow @@ -307,9 +311,9 @@ #define SC16IS7XX_FIFO_SIZE (64) #define SC16IS7XX_GPIOS_PER_BANK 4 -#define SC16IS7XX_RECONF_MD (1 << 0) -#define SC16IS7XX_RECONF_IER (1 << 1) -#define SC16IS7XX_RECONF_RS485 (1 << 2) +#define SC16IS7XX_RECONF_MD BIT(0) +#define SC16IS7XX_RECONF_IER BIT(1) +#define SC16IS7XX_RECONF_RS485 BIT(2) struct sc16is7xx_one_config { unsigned int flags;