From patchwork Mon Aug 12 16:54:50 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lech Perczak X-Patchwork-Id: 818781 Received: from eu-smtp-delivery-197.mimecast.com (eu-smtp-delivery-197.mimecast.com [185.58.85.197]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1D73D2B9B5 for ; Mon, 12 Aug 2024 16:54:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.58.85.197 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1723481698; cv=none; b=soTNZLYSb+Ia5ZgNKDMOBmDJr1nBd3nR7XFf5BLXxkkkuABw4RIntqKRRdeFFT/a7r+Wqk7TFJOUhRW7LShWSUdwgdqpEtHn7CVGql7cOli7sA+Xrf8pmxpG5hJC80apwNUl+q02K+CZOZuBpHuZ31/kj+HPJRTfjknKpf6hPjM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1723481698; c=relaxed/simple; bh=74cmuXQyKQMY1F1bPCy1W6XjlRjNqu78NXP77nLThNU=; h=Message-ID:Date:Subject:From:To:Cc:References:In-Reply-To: MIME-Version:Content-Type; b=P5TlOQubpDPv7HoBD92pmUZzkHI4m18eQSMLUkvn7EBrYAnM/hPklBmNOnixXE3MyWTzAtXjQlBDimXwVLbgW4rrRjS/sRHrcDc+JCePvRhVIeEA1fKICik8wbsoUaeWWl0geCJv1/0CyjoNiK3GwkD5tszFcJ2opt5V+c0ulJU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=camlingroup.com; spf=pass smtp.mailfrom=camlingroup.com; dkim=pass (1024-bit key) header.d=camlingroup.com header.i=@camlingroup.com header.b=kNf84Zta; arc=none smtp.client-ip=185.58.85.197 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=camlingroup.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=camlingroup.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=camlingroup.com header.i=@camlingroup.com header.b="kNf84Zta" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=camlingroup.com; s=mimecast20210310; t=1723481695; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=TIa7EUVONlUwLxTX5h8Ao+TJ2uqK3rhOokLSZLQxcC4=; b=kNf84Ztayj0ffMgC4NcmyVflKYehwJSA0XLNhz4QgT0gRPxGUW+HPh2IQ9QCpKH/x0MXhT brrqZksobLphBZjtq2zt/8/yWmXEyanzchwHaZRdafzinMPbNvgeqFEsR42wmq0D737ZKX XI3CNr8P99aqWWM9ruTVIBwaxGQIGNk= Received: from GBR01-LO4-obe.outbound.protection.outlook.com (mail-lo4gbr01lp2104.outbound.protection.outlook.com [104.47.85.104]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id uk-mta-272-btZkcbUuMDKlhAWbELXEGw-1; Mon, 12 Aug 2024 17:54:54 +0100 X-MC-Unique: btZkcbUuMDKlhAWbELXEGw-1 Received: from CWXP123MB5267.GBRP123.PROD.OUTLOOK.COM (2603:10a6:400:142::9) by CWXP123MB6004.GBRP123.PROD.OUTLOOK.COM (2603:10a6:400:1bf::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7849.19; Mon, 12 Aug 2024 16:54:52 +0000 Received: from CWXP123MB5267.GBRP123.PROD.OUTLOOK.COM ([fe80::f866:62f9:716e:ca4f]) by CWXP123MB5267.GBRP123.PROD.OUTLOOK.COM ([fe80::f866:62f9:716e:ca4f%6]) with mapi id 15.20.7849.021; Mon, 12 Aug 2024 16:54:52 +0000 Message-ID: Date: Mon, 12 Aug 2024 18:54:50 +0200 User-Agent: Mozilla Thunderbird Subject: [PATCH v2 1/3] serial: sc16is7xx: remove SC16IS7XX_MSR_DELTA_MASK From: Lech Perczak To: linux-serial@vger.kernel.org, linux-serial@vger.kernel.org Cc: Greg Kroah-Hartman , Jiri Slaby , Hugo Villeneuve , Andy Shevchenko , =?utf-8?q?Krzysztof_Drobi=C5=84ski?= , Pawel Lenkow , Kirill Yatsenko References: <16b7bff3-71ec-4042-a9a8-755f32b85716@camlingroup.com> In-Reply-To: <16b7bff3-71ec-4042-a9a8-755f32b85716@camlingroup.com> X-ClientProxiedBy: WA0P291CA0006.POLP291.PROD.OUTLOOK.COM (2603:10a6:1d0:1::18) To CWXP123MB5267.GBRP123.PROD.OUTLOOK.COM (2603:10a6:400:142::9) Precedence: bulk X-Mailing-List: linux-serial@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CWXP123MB5267:EE_|CWXP123MB6004:EE_ X-MS-Office365-Filtering-Correlation-Id: f0f78f06-772b-41fb-b09a-08dcbaef7c64 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|376014|366016 X-Microsoft-Antispam-Message-Info: =?utf-8?q?rVmi3E3oeE+As1dzmPG+AS3V4gteLyU?= =?utf-8?q?AGHLXM626QxtaBY1tbSoigJqmQy9n0v0duuu+9rWIw/jD/cyi/fiwah17d3xb1rTU?= =?utf-8?q?01/SHRYGNrTEuOEER5ujlQ959EFjK95/esEmNoeNBuh3Whg9ux4wRaYCWC5QGnzio?= =?utf-8?q?dljRRjqHJro/bC1yNOldfDcK7lqNkIyTnWwWFAr+wBqrcYWq5DqCw59ONlltCiQ5b?= =?utf-8?q?PSdTsgWqXQndNm2IPnW4oZ2HX2tSH85aA4+0l+RqFWvWyquP9pd1k1Ds+e3O9gTmp?= =?utf-8?q?VjG+/xFRcVMJ10XnAa8dKaYGx75DawWb4QTAlF8Y6r4sxvZG+rtaguH19dJQmWj9e?= =?utf-8?q?/hoX38lVOiCNT1XIMnVN7cY0JmXZfqnO8HDLUHM0TRGZXhkgpZ+y4lmjAEN5aE1j2?= =?utf-8?q?oiVbWjJJHAqe+v+i5cjkZKOZkj9pw9w4X2j9cmb/k83r6LsmcQPS9YMiSRNJJv8t/?= =?utf-8?q?8rm1h/BH2PtfBbmqGie43VV9+Wm+OGtx4t4W4BTuoKSlFJ0ch60EHkcuXMgTzbTbR?= =?utf-8?q?O9vDLJryrsGtGHBP0JS6X+KS0KEPKSUVOh5kUOIz8IX95MEU3+PditaibZBMCrRWe?= =?utf-8?q?rIoGoTb/eJhK3Cji54eTF/GRANfzEwHnIqQMJiSssK7npOmSjaNEQtRqmvSA0X9W5?= =?utf-8?q?1n7g+jTxPzIe1thTADONjJoPjGH5JzoaJfCVuCxN940Ouwwsly2uXaEvx4Mjo3R4P?= =?utf-8?q?nC5cn0GOxxJIlI/pkh79zIxlP/eE25V4KbTKtsANFtgZxfgfm7wGiD0ofoHfJuYNs?= =?utf-8?q?uaPGk1LS1jjElx+3HsB2B2hZRw1oy/zeRV+z/pLAec5He39WH+YFGqza3De8BcfPF?= =?utf-8?q?GQPHtbwQQwfOvTMFZZN0jsbp1YndI4eP+VCCedH46OguBasmKhBfoBsR8AjgmEA7x?= =?utf-8?q?Su3QgUHihm2Jog1Hh5MSrPAhzINoVhyhn7U3u2YweptA/dMQ2GaLYWo68PX+DCRMc?= =?utf-8?q?PKJlJJZjj4Nv3LlkNr+DwvIsGl5WxDSVaSMc5KeJEb4qFL/9tMJMcfysS1VNJomJ7?= =?utf-8?q?1x2NEA4VsDOSn5tLxfDdGqyBcrwhRi82o13B0DOmzfsSn8M+ykjiCUVzcf1UUcYjc?= =?utf-8?q?cEKPzAuDHXonH5iHa3hWOGNuPk4o3r/Q/WACO+04bkhBJomxJF3r6OVhGFTfboPim?= =?utf-8?q?emMJSvD+DU5T6EL8MWM/W7nLeKK59fUOV78iDoc9y40k6oCrhpuzL+c6KajCrMRXv?= =?utf-8?q?yB19p+c4JAig/9umjFizVSF8jDHdvA3GESTroGqaxFOqO/GeDwO3M+qr6zlni63Bm?= =?utf-8?q?vmqzLaBDKYw5QBwiGHWNwCEJnJh74s1f2dA=3D=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CWXP123MB5267.GBRP123.PROD.OUTLOOK.COM; PTR:; CAT:NONE; SFS:(13230040)(1800799024)(376014)(366016); DIR:OUT; SFP:1102 X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?q?HPxEirfMmjOFzgCEhXjIbpr2Bkzc?= =?utf-8?q?3uC7fljGXXaEaqy8d4UiFRGUoiLv7qSyncygfza1PWD6BVTXkeAwM/LM5S2w0O+C1?= =?utf-8?q?LwMQYpvlXNWyeB5j6Ou0yaAsh7kvbhVcajYAIlceXPlcEkBArGmAmdtloZ50p0aQs?= =?utf-8?q?V9zRe/3ELgA0/k94yL+eeT3EPu5ya224XNb0y0o+N2E6EZKlOgvn+X1K7WCTUkOpY?= =?utf-8?q?mBoX8ZJdnub4zyfoc+xCW/NmMEYe2eVmJn0IPmstPalOuau8M/zntEZJ3YpqzX0yf?= =?utf-8?q?MqA/hDZnd9iisUgIWN5aAKjj4xuAJZZ9qW5yt+o8OTIJsBT4lxu4SgcTiCXhbka3E?= =?utf-8?q?G4mEZoagaTUL2lA5JbpV/yuGAFIB7/LxnirpGu2j7FKNxKp+eMUpv3DBFCfPEbCm7?= =?utf-8?q?QHH62/qOc2BSl3vSZufeyEmR4zXleBsuHv7MdRz5LnuB8sNgCAY/Vzb7AukqXGYo2?= =?utf-8?q?JuwTMB99qqg5W7/Loq7D2fZI5BKT1Um8grbjKB+WQqKCsA9QkzAimRSkG3Q60oIkW?= =?utf-8?q?7a304E2Vdq7vjeeLHJB3PR7GP2TIpqEonWj6cx2IOb+1RTyK3kmbQ+iOAmC2j5ZLO?= =?utf-8?q?mBtvxUnYY0XIn7B/T45RKLtLROx2KmDVTeX5bmQeULFsEi6iSYiFwcPIUHJXXi7I3?= =?utf-8?q?A/klQnlcjnbrJJ2mekck7GPv9uLLFDXUpFJ+DM+Yt1bXRiGblsS5M2okStyK1vAX9?= =?utf-8?q?5gl/uK6I6HJUCtPc3xpvmJlG5WKXz+JSbqUD+K6M/Gr1RxZX0xenTTlKApBgquzSS?= =?utf-8?q?OP9Z07DaRrLBybzsPY/M2b7/ABrsnE9buAbxrf2P6oh3kcejVxiYO45vY5eavvI+4?= =?utf-8?q?L/w8BGYjMF6BT8+owWiiNCDbfNTWEGgad6Vf8GPIKHNzoYPVsQz+sLq0BvjXkjRqU?= =?utf-8?q?pKE1ZhGCelwQsiXm+MtvwRgaAMDSCShxltNKPXVxKphpqWHfRs67ohoHBwhyYi8cA?= =?utf-8?q?L4Spa6q/Qdf5AW8Fcntwur9vNzzo5cc9mrATLU7oxvlcuqDiTcRXmIs6VrrGrEYJ+?= =?utf-8?q?1XxUTG2QcCGCpYUIflbTWTaZxid4GmYabIw2OdTMGebPTv0GeBHMm1QCsb2tNW4wG?= =?utf-8?q?ZZ4ObuswXLXW4FG0AHNNbFlkxbSUiLwsdHeHsA85VTB2NssxrPAHdNB3AZLDvm5Qi?= =?utf-8?q?Hrvfz9p8/KAimcVAmDPtYzNUERl62a82Q5nGMT9+khNlMakk6YvRBHYxDlvmsfI3y?= =?utf-8?q?b2WyF/hxycPq2NrwETGA1o8vUhIpEjw/f8On1DYRRsKzkXPH52MIFpOw3jEbGJg+F?= =?utf-8?q?6AVuDhP+KdpdZmStGf6u+p8ws1glvPCUsgXC9oXh3qTABnjUvgePWyOZUVvOEzPwY?= =?utf-8?q?nu1N6FPcEmH6qYyCo3XGQ4xv3xo7xOPay5Rrrb6rGRF9J4cCAov2YbgwPjPtnPqww?= =?utf-8?q?SUXzBqyp8QU7eOyajKQdWZivwRIIZ/1csUnFw1vqc+tJ+Zh6wki2y7VKLvNqF/HKh?= =?utf-8?q?0DXz0p3qjxZaWu6djxCPVttOneIwsWv8vj8or3SPKJTjCVQ8jo21ZVk+wscm459SB?= =?utf-8?q?vk5GEhbtporQYC3iuGDntmdJ5RUZ6yJK6g=3D=3D?= X-OriginatorOrg: camlingroup.com X-MS-Exchange-CrossTenant-Network-Message-Id: f0f78f06-772b-41fb-b09a-08dcbaef7c64 X-MS-Exchange-CrossTenant-AuthSource: CWXP123MB5267.GBRP123.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Aug 2024 16:54:52.8193 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: fd4b1729-b18d-46d2-9ba0-2717b852b252 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: EwR/w7vcbR1hLCBQik/u8FseshyeGfD6XK6+I+accP3lINL60zPSKVjM98wrkvp30mUT+QG7EIviJy9yZG5D0XRYuS31OFJsdQydAh6udgc= X-MS-Exchange-Transport-CrossTenantHeadersStamped: CWXP123MB6004 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: camlingroup.com Content-Language: en-US This definition isn't used anywhere anymore, let's delete it. Signed-off-by: Lech Perczak --- Cc: Greg Kroah-Hartman Cc: Jiri Slaby Cc: Hugo Villeneuve Cc: Andy Shevchenko --- drivers/tty/serial/sc16is7xx.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/tty/serial/sc16is7xx.c b/drivers/tty/serial/sc16is7xx.c index bf0065d1c8e9..8a2020f9930e 100644 --- a/drivers/tty/serial/sc16is7xx.c +++ b/drivers/tty/serial/sc16is7xx.c @@ -207,7 +207,6 @@ #define SC16IS7XX_MSR_CD_BIT (1 << 7) /* CD (IO6) * - only on 75x/76x */ -#define SC16IS7XX_MSR_DELTA_MASK 0x0F /* Any of the delta bits! */ /* * TCR register bits From patchwork Mon Aug 12 16:56:53 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lech Perczak X-Patchwork-Id: 818780 Received: from eu-smtp-delivery-197.mimecast.com (eu-smtp-delivery-197.mimecast.com [185.58.85.197]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 265F44317C for ; Mon, 12 Aug 2024 16:56:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.58.85.197 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1723481821; cv=none; b=QuL2OSe9QIIgiDrYz1i8Fqyt9igs5gYVO4UH+uc0rHS8kSRTRDbuEhtE0l71GaKcFuA2APpYIC2nr/d8M0OYRLlCN1Q6sOByG7rrw/kt0prMPxrhCahBS/O4lJQWGe4cCBrRCZo3+ZkVn92fPxtyrkhxoae+JKivwIoIoUX1cpE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1723481821; c=relaxed/simple; bh=D9EfQgOOVPTE+lZtsc0tErt15c8/InthfjTwMmKTSMU=; h=Message-ID:Date:Subject:From:To:Cc:References:In-Reply-To: MIME-Version:Content-Type; b=BEen3cf7zvBvoKEyxvs/tjf5qlzzpNZ/jLYBp07jVZQ5KqFvKwu1eJun+58vjEN/ss0wXCfFWLLiMifISGeHDNIOa4Ftrk2c0NUFqCq66QErAdGNsOFC1mhogHkVaog2yoA4ATMGngSPnBlLNXXzX1ZsKtQzrPJ/AQNXuEX9is4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=camlingroup.com; spf=pass smtp.mailfrom=camlingroup.com; dkim=pass (1024-bit key) header.d=camlingroup.com header.i=@camlingroup.com header.b=ilewV5va; arc=none smtp.client-ip=185.58.85.197 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=camlingroup.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=camlingroup.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=camlingroup.com header.i=@camlingroup.com header.b="ilewV5va" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=camlingroup.com; s=mimecast20210310; t=1723481817; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=UiQEcsJc0rPQX6UZI77aPHaG50vXe0dvNEzRF8owf+c=; b=ilewV5vaZzbKWxItMXovMRSuUoby+AuvfHmCnvVUIGcGr3yUk3AfNzQwyIkbiPWJPHlZeb jPdrvvr9D5JnpX61UEA950AJE+SRGwh8WFg6dktnM8IcAuc9vwAcO+yA4RYcr90pW2DO2/ 0+yZHVkC4bpB8jCPmOzjAul4Nfl8TXU= Received: from GBR01-CWX-obe.outbound.protection.outlook.com (mail-cwxgbr01lp2041.outbound.protection.outlook.com [104.47.85.41]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id uk-mta-304-sNOlvkakOYm_ybSZ5HW_YA-1; Mon, 12 Aug 2024 17:56:56 +0100 X-MC-Unique: sNOlvkakOYm_ybSZ5HW_YA-1 Received: from CWXP123MB5267.GBRP123.PROD.OUTLOOK.COM (2603:10a6:400:142::9) by CWXP123MB6004.GBRP123.PROD.OUTLOOK.COM (2603:10a6:400:1bf::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7849.19; Mon, 12 Aug 2024 16:56:55 +0000 Received: from CWXP123MB5267.GBRP123.PROD.OUTLOOK.COM ([fe80::f866:62f9:716e:ca4f]) by CWXP123MB5267.GBRP123.PROD.OUTLOOK.COM ([fe80::f866:62f9:716e:ca4f%6]) with mapi id 15.20.7849.021; Mon, 12 Aug 2024 16:56:55 +0000 Message-ID: <8cfa1c75-03f8-4071-b277-752006b576ac@camlingroup.com> Date: Mon, 12 Aug 2024 18:56:53 +0200 User-Agent: Mozilla Thunderbird Subject: [PATCH v2 3/3] serial: sc16is7xx: convert bitmask definitions to use BIT macro From: Lech Perczak To: linux-serial@vger.kernel.org, linux-serial@vger.kernel.org Cc: Greg Kroah-Hartman , Jiri Slaby , Hugo Villeneuve , Andy Shevchenko , =?utf-8?q?Krzysztof_Drobi=C5=84ski?= , Pawel Lenkow , Kirill Yatsenko References: <16b7bff3-71ec-4042-a9a8-755f32b85716@camlingroup.com> In-Reply-To: <16b7bff3-71ec-4042-a9a8-755f32b85716@camlingroup.com> X-ClientProxiedBy: WA0P291CA0010.POLP291.PROD.OUTLOOK.COM (2603:10a6:1d0:1::12) To CWXP123MB5267.GBRP123.PROD.OUTLOOK.COM (2603:10a6:400:142::9) Precedence: bulk X-Mailing-List: linux-serial@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CWXP123MB5267:EE_|CWXP123MB6004:EE_ X-MS-Office365-Filtering-Correlation-Id: 055de36c-57b9-4795-ab72-08dcbaefc552 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|1800799024|376014 X-Microsoft-Antispam-Message-Info: =?utf-8?q?tgQMAo9yLyhhJTTUkOzE9hDA+d1LqFD?= =?utf-8?q?9qLaF/+++B1jqj2pYJNuIzXhfMZrWZDmPReQiSupNtM13xMirU3JzWdlYIJt7YEWy?= =?utf-8?q?GM12MX6+AjruH9X0b7Rl7l/rfvgeLdhSD84euoi7FMx5teCHu0pfoX9WUO6DWt2my?= =?utf-8?q?CCQuTYXkFIHM9toDHeLS9nzsKRp8xMIPo3Q9sZHakhSySsab9H82YL2XOvaZhyqA/?= =?utf-8?q?oFkRdeoCIjfcU8uPFjMM9sZAtFJxKcOydwGjAw083iv1IfODfoyJpUAyBTHwIu58k?= =?utf-8?q?ghHQzjUM4ZA22NAAq4NXFGzHegFlN3stZ0nPvqQqzlpWI6WyozRWqoDp9oiKkHale?= =?utf-8?q?X23w14L1RcYsF09xltCciEEq3k4dKNrXwbjjvNNsTDpg2MRHlS0CmujRaTJzKX1HY?= =?utf-8?q?2cOYBTaToz52E8zcjt7/uT6wlA7ANl3PjGwzI1gKxggQZA3HsxGSPUewNWX7XNc9s?= =?utf-8?q?dm5jhLJoqAlJT6zM/HH7AaBrP9YFnroiMe4AxbNwsc6r2vJiMk8MG6VITdBqm6RM3?= =?utf-8?q?w4Fkgvj16UPlZvWwjfKGJiZv2QITYBXHXf4RSZZ+dE7xE/cATfvsITB0LxnCZkrkw?= =?utf-8?q?vcLQEAPJ6tkISwlIuc5xqno0fYc89ft33JWlb6i5t8sDzOzyMtMQxZ3m7J3XvLEGt?= =?utf-8?q?ameQvYE9A55J5vPJN9rjKs0HaPuO1G5D3B8M09OI1aU34PTUX3o/MwP6sfwpOd6wm?= =?utf-8?q?cfKgdwICB12elBL0hV36Lgd78J4kkJODLJ3e3xa9u0vviBKbwG+HQXN1t4AYBRKrv?= =?utf-8?q?PeqLaElJQYwZPS5kII9CI1Vz1Q75Zaj0hSyHhymqr+2jsM/ROpZ6lXFawwPhZ/eEI?= =?utf-8?q?sd60JY5NA8ojx/X9Oqsg4yAgEY0uYrGUCj2mjWSUmTpXF/nvu/SoQ9c8gCHLWi7XV?= =?utf-8?q?QkJ8K2Gp8+c1bd6Sk3+tgjoczWVYYmZAQMRBhyLjigePTwahy1GRzvmtoVVCuOrFt?= =?utf-8?q?RsUHjIymrLYxZQftvnizjN16Aln1vscUMxDRRTZKeA2xMTTnqQLYUjSSc/MmlvTIN?= =?utf-8?q?vA0MZ8woQjoh0EjeDhLrIq0mUITukf0/rGGE6CxxX0a/3PyW0HXZoeeV9+OUBhqaq?= =?utf-8?q?6aEIx/qMd5tHVBVYLa89/f+6K5nelVo7zSpArqPX7YhyFsLo9rKqKVvLLFP4sMYzv?= =?utf-8?q?nk4leUHx6g/FiRVbMWH5JmsV/UxW4lA/GHWVfkookekYx7hMJwYM+5t/4bCY+2a1p?= =?utf-8?q?bSERRdNk1detO2xlYmQxgPUavA7EZ23ZJgzSrjWfAP2NBfzYCeyuqVtN3VRbVzu6X?= =?utf-8?q?kVhhSoZeJCLUzdYCe1xC1bnN9uDBS4+YTqA=3D=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CWXP123MB5267.GBRP123.PROD.OUTLOOK.COM; PTR:; CAT:NONE; SFS:(13230040)(366016)(1800799024)(376014); DIR:OUT; SFP:1102 X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?q?O7oZlXX2agLiCgMmXmcS3LZmpqu5?= =?utf-8?q?0AZ4Z3wY4qcv9l35BCZNsWflWcQSu0uzJwlZjSi5neMQnw3Ht9tkMD1wwCKVIyBKb?= =?utf-8?q?C8+1Hn72gKwWgrMAUhf2ao9HGdsaigSa60lAL2DevGrY4fB4Z+1WeITgl9eiKzdfa?= =?utf-8?q?hBylGUn9sMb2u0yD7OS/RPAJlsnZVwsGbY0vPUsUtNTdvll75rqHLBdbZnBacotVJ?= =?utf-8?q?pigR7dppYeTzCEs+Mc39yoSL9drsMZMbE7Oy/vGCPBqjDwp291zB/xyNKRrBEv8mc?= =?utf-8?q?P4v1OMAgps5oRcyMRAOBjQtR3RoDUAnOWLIrqHjkO/yOvCYrVT8iO41120U0uIZFU?= =?utf-8?q?eJVC9u/yMWnVcYJY8TGlQ//GZauGuh6kHjg2f0kP2aCSEVFzuQsPGHiEqaDp975g3?= =?utf-8?q?T6//zqS0v0Anxl2wX9XYDSHmnNizX22tysD7PnEPvksaaoS2/JRcaDk2iETQ8jVss?= =?utf-8?q?+7x63sIY2Fu1KY08h+0gvgWg07EGGkb8MscL24O9M2x/QGHC3ojtTKjDg0A3jk+F8?= =?utf-8?q?eUtuZpMSqNNtYPJTFypOmtoLRu34t4iyh3dYPXK3EBQJ4fxUXoIamjRsylMsZZVey?= =?utf-8?q?2PKKJAYJgBezolfjVZG5T7am2kxn9cMZaDcfDcekz7v0Gtrmnk9HKURJ3bJgKE/Qr?= =?utf-8?q?be2keuY3Pvg53+e046jpIt2yRgpV5j4MEIu1DG5w+NN3+nZDR9FdAaqz3FOx3goJU?= =?utf-8?q?I2VW3LzmrKIq1wpK5v0jCGzqEk+5p1QMShBzWM9OTRtc2fshjTH9CygPhCuAo/HzI?= =?utf-8?q?DDrc8RdP9j6Ld+Ewc6oTaqE7lJqP1YLatUx4AMA0HhPsExRqniCNTh9514SzH556h?= =?utf-8?q?OMOhPjpZ+OszDADjY06wuKTSPNO3VOInEU6vPJc0rG5rKRht6jSCs/1oC4i9QKPvI?= =?utf-8?q?MYuvZSizCYh9/oelPmcKyl7kX03EVRS87KH+fAJH7Eyl24n2EC8kguUituob3MVp3?= =?utf-8?q?Qgk2ZabUO2f+LLVB5uSqtNF+8dr+Y/OLyRgsdZdnjC1X+dov3qPTj8nMf0l0nYxrz?= =?utf-8?q?eFe/uzVBRgvdbwjXUoaYy4MVyjam23RXtpccQFkOPRvOwRvUeNFraFvxDTPmpdDLW?= =?utf-8?q?kAKo33x5hVD+jz8aPNvzvh17LV8Iq1UVWiIFD52r6c2xRDu9VVPDAvNgpquL9ZahZ?= =?utf-8?q?oUrh9q4QkuruyCKZRYw9QTa7OvLFvHydRbFGmfbEwSx4IMQQ/nh/cA7ClmtXEkQql?= =?utf-8?q?68gkUJnDpZZHgTeZ/0vB9jrN5xQ17XAxZf5hiMf5bW4jUkOZHaIjwRyvnUNXYIt/o?= =?utf-8?q?18lW/nqwkHyE4SuiISsZRCRukOEV8wNElRVanaUXAYDA4oilVOcq+UmSmzEAae162?= =?utf-8?q?wfPobNJWgwoRSVV/uukLOvaxV5CENquJRApZuYd9xDhErwnVYU9HI683CfgQ1yUEC?= =?utf-8?q?6KtDP2pT+aLnop09SpXHJ0cGCnyAujF/wIpI7YYBWFjmWnSqI7gUIr4puzm+6wiCd?= =?utf-8?q?YDFDKdveXEQZG4i9X7dEbEgHiiVX0bZEK1jel1z1u3vHkjHUTUVB0EkVq4t6kPmuu?= =?utf-8?q?VS02YGY6c58rKuRqSknCWERWPOMcNJpuBQ=3D=3D?= X-OriginatorOrg: camlingroup.com X-MS-Exchange-CrossTenant-Network-Message-Id: 055de36c-57b9-4795-ab72-08dcbaefc552 X-MS-Exchange-CrossTenant-AuthSource: CWXP123MB5267.GBRP123.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Aug 2024 16:56:55.1335 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: fd4b1729-b18d-46d2-9ba0-2717b852b252 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 2AswL2mQ1mmIleXd2OPbcCOrpJSM2DXcBmK+K/oOBFep62b9C9VolAN31DqjC9km1PFJi3KVreqDU54psj75LKr35Qlfa+wHFhU/lthgLNs= X-MS-Exchange-Transport-CrossTenantHeadersStamped: CWXP123MB6004 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: camlingroup.com Content-Language: en-US Now that bit definition comments were cleaned up, convert bitmask definitions to use BIT macro for clarity. Signed-off-by: Lech Perczak --- Cc: Greg Kroah-Hartman Cc: Jiri Slaby Cc: Hugo Villeneuve Cc: Andy Shevchenko --- drivers/tty/serial/sc16is7xx.c | 137 +++++++++++++++++---------------- 1 file changed, 69 insertions(+), 68 deletions(-) diff --git a/drivers/tty/serial/sc16is7xx.c b/drivers/tty/serial/sc16is7xx.c index 36b7c682ae94..a3c2ae112090 100644 --- a/drivers/tty/serial/sc16is7xx.c +++ b/drivers/tty/serial/sc16is7xx.c @@ -10,6 +10,7 @@ #undef DEFAULT_SYMBOL_NAMESPACE #define DEFAULT_SYMBOL_NAMESPACE SERIAL_NXP_SC16IS7XX +#include #include #include #include @@ -77,33 +78,33 @@ #define SC16IS7XX_XOFF2_REG (0x07) /* Xoff2 word */ /* IER register bits */ -#define SC16IS7XX_IER_RDI_BIT (1 << 0) /* Enable RX data interrupt */ -#define SC16IS7XX_IER_THRI_BIT (1 << 1) /* Enable TX holding register +#define SC16IS7XX_IER_RDI_BIT BIT(0) /* Enable RX data interrupt */ +#define SC16IS7XX_IER_THRI_BIT BIT(1) /* Enable TX holding register * interrupt */ -#define SC16IS7XX_IER_RLSI_BIT (1 << 2) /* Enable RX line status +#define SC16IS7XX_IER_RLSI_BIT BIT(2) /* Enable RX line status * interrupt */ -#define SC16IS7XX_IER_MSI_BIT (1 << 3) /* Enable Modem status +#define SC16IS7XX_IER_MSI_BIT BIT(3) /* Enable Modem status * interrupt */ /* IER register bits - write only if (EFR[4] == 1) */ -#define SC16IS7XX_IER_SLEEP_BIT (1 << 4) /* Enable Sleep mode */ -#define SC16IS7XX_IER_XOFFI_BIT (1 << 5) /* Enable Xoff interrupt */ -#define SC16IS7XX_IER_RTSI_BIT (1 << 6) /* Enable nRTS interrupt */ -#define SC16IS7XX_IER_CTSI_BIT (1 << 7) /* Enable nCTS interrupt */ +#define SC16IS7XX_IER_SLEEP_BIT BIT(4) /* Enable Sleep mode */ +#define SC16IS7XX_IER_XOFFI_BIT BIT(5) /* Enable Xoff interrupt */ +#define SC16IS7XX_IER_RTSI_BIT BIT(6) /* Enable nRTS interrupt */ +#define SC16IS7XX_IER_CTSI_BIT BIT(7) /* Enable nCTS interrupt */ /* FCR register bits */ -#define SC16IS7XX_FCR_FIFO_BIT (1 << 0) /* Enable FIFO */ -#define SC16IS7XX_FCR_RXRESET_BIT (1 << 1) /* Reset RX FIFO */ -#define SC16IS7XX_FCR_TXRESET_BIT (1 << 2) /* Reset TX FIFO */ -#define SC16IS7XX_FCR_RXLVLL_BIT (1 << 6) /* RX Trigger level LSB */ -#define SC16IS7XX_FCR_RXLVLH_BIT (1 << 7) /* RX Trigger level MSB */ +#define SC16IS7XX_FCR_FIFO_BIT BIT(0) /* Enable FIFO */ +#define SC16IS7XX_FCR_RXRESET_BIT BIT(1) /* Reset RX FIFO */ +#define SC16IS7XX_FCR_TXRESET_BIT BIT(2) /* Reset TX FIFO */ +#define SC16IS7XX_FCR_RXLVLL_BIT BIT(6) /* RX Trigger level LSB */ +#define SC16IS7XX_FCR_RXLVLH_BIT BIT(7) /* RX Trigger level MSB */ /* FCR register bits - write only if (EFR[4] == 1) */ -#define SC16IS7XX_FCR_TXLVLL_BIT (1 << 4) /* TX Trigger level LSB */ -#define SC16IS7XX_FCR_TXLVLH_BIT (1 << 5) /* TX Trigger level MSB */ +#define SC16IS7XX_FCR_TXLVLL_BIT BIT(4) /* TX Trigger level LSB */ +#define SC16IS7XX_FCR_TXLVLH_BIT BIT(5) /* TX Trigger level MSB */ /* IIR register bits */ -#define SC16IS7XX_IIR_NO_INT_BIT (1 << 0) /* No interrupts pending */ +#define SC16IS7XX_IIR_NO_INT_BIT BIT(0) /* No interrupts pending */ #define SC16IS7XX_IIR_ID_MASK 0x3e /* Mask for the interrupt ID */ #define SC16IS7XX_IIR_THRI_SRC 0x02 /* TX holding register empty */ #define SC16IS7XX_IIR_RDI_SRC 0x04 /* RX data interrupt */ @@ -121,8 +122,8 @@ * to inactive (HIGH) */ /* LCR register bits */ -#define SC16IS7XX_LCR_LENGTH0_BIT (1 << 0) /* Word length bit 0 */ -#define SC16IS7XX_LCR_LENGTH1_BIT (1 << 1) /* Word length bit 1 +#define SC16IS7XX_LCR_LENGTH0_BIT BIT(0) /* Word length bit 0 */ +#define SC16IS7XX_LCR_LENGTH1_BIT BIT(1) /* Word length bit 1 * * Word length bits table: * 00 -> 5 bit words @@ -130,7 +131,7 @@ * 10 -> 7 bit words * 11 -> 8 bit words */ -#define SC16IS7XX_LCR_STOPLEN_BIT (1 << 2) /* STOP length bit +#define SC16IS7XX_LCR_STOPLEN_BIT BIT(2) /* STOP length bit * * STOP length bit table: * 0 -> 1 stop bit @@ -138,11 +139,11 @@ * word length is 5, * 2 stop bits otherwise */ -#define SC16IS7XX_LCR_PARITY_BIT (1 << 3) /* Parity bit enable */ -#define SC16IS7XX_LCR_EVENPARITY_BIT (1 << 4) /* Even parity bit enable */ -#define SC16IS7XX_LCR_FORCEPARITY_BIT (1 << 5) /* 9-bit multidrop parity */ -#define SC16IS7XX_LCR_TXBREAK_BIT (1 << 6) /* TX break enable */ -#define SC16IS7XX_LCR_DLAB_BIT (1 << 7) /* Divisor Latch enable */ +#define SC16IS7XX_LCR_PARITY_BIT BIT(3) /* Parity bit enable */ +#define SC16IS7XX_LCR_EVENPARITY_BIT BIT(4) /* Even parity bit enable */ +#define SC16IS7XX_LCR_FORCEPARITY_BIT BIT(5) /* 9-bit multidrop parity */ +#define SC16IS7XX_LCR_TXBREAK_BIT BIT(6) /* TX break enable */ +#define SC16IS7XX_LCR_DLAB_BIT BIT(7) /* Divisor Latch enable */ #define SC16IS7XX_LCR_WORD_LEN_5 (0x00) #define SC16IS7XX_LCR_WORD_LEN_6 (0x01) #define SC16IS7XX_LCR_WORD_LEN_7 (0x02) @@ -153,58 +154,58 @@ * reg set */ /* MCR register bits */ -#define SC16IS7XX_MCR_DTR_BIT (1 << 0) /* DTR complement +#define SC16IS7XX_MCR_DTR_BIT BIT(0) /* DTR complement * - only on 75x/76x */ -#define SC16IS7XX_MCR_RTS_BIT (1 << 1) /* RTS complement */ -#define SC16IS7XX_MCR_TCRTLR_BIT (1 << 2) /* TCR/TLR register enable */ -#define SC16IS7XX_MCR_LOOP_BIT (1 << 4) /* Enable loopback test mode */ -#define SC16IS7XX_MCR_XONANY_BIT (1 << 5) /* Enable Xon Any +#define SC16IS7XX_MCR_RTS_BIT BIT(1) /* RTS complement */ +#define SC16IS7XX_MCR_TCRTLR_BIT BIT(2) /* TCR/TLR register enable */ +#define SC16IS7XX_MCR_LOOP_BIT BIT(4) /* Enable loopback test mode */ +#define SC16IS7XX_MCR_XONANY_BIT BIT(5) /* Enable Xon Any * - write enabled * if (EFR[4] == 1) */ -#define SC16IS7XX_MCR_IRDA_BIT (1 << 6) /* Enable IrDA mode +#define SC16IS7XX_MCR_IRDA_BIT BIT(6) /* Enable IrDA mode * - write enabled * if (EFR[4] == 1) */ -#define SC16IS7XX_MCR_CLKSEL_BIT (1 << 7) /* Divide clock by 4 +#define SC16IS7XX_MCR_CLKSEL_BIT BIT(7) /* Divide clock by 4 * - write enabled * if (EFR[4] == 1) */ /* LSR register bits */ -#define SC16IS7XX_LSR_DR_BIT (1 << 0) /* Receiver data ready */ -#define SC16IS7XX_LSR_OE_BIT (1 << 1) /* Overrun Error */ -#define SC16IS7XX_LSR_PE_BIT (1 << 2) /* Parity Error */ -#define SC16IS7XX_LSR_FE_BIT (1 << 3) /* Frame Error */ -#define SC16IS7XX_LSR_BI_BIT (1 << 4) /* Break Interrupt */ +#define SC16IS7XX_LSR_DR_BIT BIT(0) /* Receiver data ready */ +#define SC16IS7XX_LSR_OE_BIT BIT(1) /* Overrun Error */ +#define SC16IS7XX_LSR_PE_BIT BIT(2) /* Parity Error */ +#define SC16IS7XX_LSR_FE_BIT BIT(3) /* Frame Error */ +#define SC16IS7XX_LSR_BI_BIT BIT(4) /* Break Interrupt */ #define SC16IS7XX_LSR_BRK_ERROR_MASK 0x1E /* BI, FE, PE, OE bits */ -#define SC16IS7XX_LSR_THRE_BIT (1 << 5) /* TX holding register empty */ -#define SC16IS7XX_LSR_TEMT_BIT (1 << 6) /* Transmitter empty */ -#define SC16IS7XX_LSR_FIFOE_BIT (1 << 7) /* Fifo Error */ +#define SC16IS7XX_LSR_THRE_BIT BIT(5) /* TX holding register empty */ +#define SC16IS7XX_LSR_TEMT_BIT BIT(6) /* Transmitter empty */ +#define SC16IS7XX_LSR_FIFOE_BIT BIT(7) /* Fifo Error */ /* MSR register bits */ -#define SC16IS7XX_MSR_DCTS_BIT (1 << 0) /* Delta CTS Clear To Send */ -#define SC16IS7XX_MSR_DDSR_BIT (1 << 1) /* Delta DSR Data Set Ready +#define SC16IS7XX_MSR_DCTS_BIT BIT(0) /* Delta CTS Clear To Send */ +#define SC16IS7XX_MSR_DDSR_BIT BIT(1) /* Delta DSR Data Set Ready * or (IO4) * - only on 75x/76x */ -#define SC16IS7XX_MSR_DRI_BIT (1 << 2) /* Delta RI Ring Indicator +#define SC16IS7XX_MSR_DRI_BIT BIT(2) /* Delta RI Ring Indicator * or (IO7) * - only on 75x/76x */ -#define SC16IS7XX_MSR_DCD_BIT (1 << 3) /* Delta CD Carrier Detect +#define SC16IS7XX_MSR_DCD_BIT BIT(3) /* Delta CD Carrier Detect * or (IO6) * - only on 75x/76x */ -#define SC16IS7XX_MSR_CTS_BIT (1 << 4) /* CTS */ -#define SC16IS7XX_MSR_DSR_BIT (1 << 5) /* DSR (IO4) +#define SC16IS7XX_MSR_CTS_BIT BIT(4) /* CTS */ +#define SC16IS7XX_MSR_DSR_BIT BIT(5) /* DSR (IO4) * - only on 75x/76x */ -#define SC16IS7XX_MSR_RI_BIT (1 << 6) /* RI (IO7) +#define SC16IS7XX_MSR_RI_BIT BIT(6) /* RI (IO7) * - only on 75x/76x */ -#define SC16IS7XX_MSR_CD_BIT (1 << 7) /* CD (IO6) +#define SC16IS7XX_MSR_CD_BIT BIT(7) /* CD (IO6) * - only on 75x/76x */ @@ -239,19 +240,19 @@ #define SC16IS7XX_TLR_RX_TRIGGER(words) ((((words) / 4) & 0x0f) << 4) /* IOControl register bits (Only 75x/76x) */ -#define SC16IS7XX_IOCONTROL_LATCH_BIT (1 << 0) /* Enable input latching */ -#define SC16IS7XX_IOCONTROL_MODEM_A_BIT (1 << 1) /* Enable GPIO[7:4] as modem A pins */ -#define SC16IS7XX_IOCONTROL_MODEM_B_BIT (1 << 2) /* Enable GPIO[3:0] as modem B pins */ -#define SC16IS7XX_IOCONTROL_SRESET_BIT (1 << 3) /* Software Reset */ +#define SC16IS7XX_IOCONTROL_LATCH_BIT BIT(0) /* Enable input latching */ +#define SC16IS7XX_IOCONTROL_MODEM_A_BIT BIT(1) /* Enable GPIO[7:4] as modem A pins */ +#define SC16IS7XX_IOCONTROL_MODEM_B_BIT BIT(2) /* Enable GPIO[3:0] as modem B pins */ +#define SC16IS7XX_IOCONTROL_SRESET_BIT BIT(3) /* Software Reset */ /* EFCR register bits */ -#define SC16IS7XX_EFCR_9BIT_MODE_BIT (1 << 0) /* Enable 9-bit or Multidrop +#define SC16IS7XX_EFCR_9BIT_MODE_BIT BIT(0) /* Enable 9-bit or Multidrop * mode (RS485) */ -#define SC16IS7XX_EFCR_RXDISABLE_BIT (1 << 1) /* Disable receiver */ -#define SC16IS7XX_EFCR_TXDISABLE_BIT (1 << 2) /* Disable transmitter */ -#define SC16IS7XX_EFCR_AUTO_RS485_BIT (1 << 4) /* Auto RS485 RTS direction */ -#define SC16IS7XX_EFCR_RTS_INVERT_BIT (1 << 5) /* RTS output inversion */ -#define SC16IS7XX_EFCR_IRDA_MODE_BIT (1 << 7) /* IrDA mode +#define SC16IS7XX_EFCR_RXDISABLE_BIT BIT(1) /* Disable receiver */ +#define SC16IS7XX_EFCR_TXDISABLE_BIT BIT(2) /* Disable transmitter */ +#define SC16IS7XX_EFCR_AUTO_RS485_BIT BIT(4) /* Auto RS485 RTS direction */ +#define SC16IS7XX_EFCR_RTS_INVERT_BIT BIT(5) /* RTS output inversion */ +#define SC16IS7XX_EFCR_IRDA_MODE_BIT BIT(7) /* IrDA mode * 0 = rate upto 115.2 kbit/s * - Only 75x/76x * 1 = rate upto 1.152 Mbit/s @@ -259,15 +260,15 @@ */ /* EFR register bits */ -#define SC16IS7XX_EFR_AUTORTS_BIT (1 << 6) /* Auto RTS flow ctrl enable */ -#define SC16IS7XX_EFR_AUTOCTS_BIT (1 << 7) /* Auto CTS flow ctrl enable */ -#define SC16IS7XX_EFR_XOFF2_DETECT_BIT (1 << 5) /* Enable Xoff2 detection */ -#define SC16IS7XX_EFR_ENABLE_BIT (1 << 4) /* Enable enhanced functions +#define SC16IS7XX_EFR_AUTORTS_BIT BIT(6) /* Auto RTS flow ctrl enable */ +#define SC16IS7XX_EFR_AUTOCTS_BIT BIT(7) /* Auto CTS flow ctrl enable */ +#define SC16IS7XX_EFR_XOFF2_DETECT_BIT BIT(5) /* Enable Xoff2 detection */ +#define SC16IS7XX_EFR_ENABLE_BIT BIT(4) /* Enable enhanced functions * and writing to IER[7:4], * FCR[5:4], MCR[7:5] */ -#define SC16IS7XX_EFR_SWFLOW3_BIT (1 << 3) -#define SC16IS7XX_EFR_SWFLOW2_BIT (1 << 2) +#define SC16IS7XX_EFR_SWFLOW3_BIT BIT(3) +#define SC16IS7XX_EFR_SWFLOW2_BIT BIT(2) /* * SWFLOW bits 3 & 2 table: * 00 -> no transmitter flow @@ -280,8 +281,8 @@ * XON1, XON2, XOFF1 and * XOFF2 */ -#define SC16IS7XX_EFR_SWFLOW1_BIT (1 << 1) -#define SC16IS7XX_EFR_SWFLOW0_BIT (1 << 0) +#define SC16IS7XX_EFR_SWFLOW1_BIT BIT(1) +#define SC16IS7XX_EFR_SWFLOW0_BIT BIT(0) /* * SWFLOW bits 1 & 0 table: * 00 -> no received flow @@ -307,9 +308,9 @@ #define SC16IS7XX_FIFO_SIZE (64) #define SC16IS7XX_GPIOS_PER_BANK 4 -#define SC16IS7XX_RECONF_MD (1 << 0) -#define SC16IS7XX_RECONF_IER (1 << 1) -#define SC16IS7XX_RECONF_RS485 (1 << 2) +#define SC16IS7XX_RECONF_MD BIT(0) +#define SC16IS7XX_RECONF_IER BIT(1) +#define SC16IS7XX_RECONF_RS485 BIT(2) struct sc16is7xx_one_config { unsigned int flags;