From patchwork Sat Aug 3 10:41:40 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dmitry Baryshkov X-Patchwork-Id: 816529 Received: from mail-ed1-f46.google.com (mail-ed1-f46.google.com [209.85.208.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 952E1135417 for ; Sat, 3 Aug 2024 10:41:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.46 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1722681709; cv=none; b=C+Nn8mMqcVCoCe0TsYNH6gd10cTdQ1AA0YhAr13QLms7pjD8IP1AHULjf5Y7ASkDCVFk4nMCmGulAq6O+yF1G3V00GhMZEPY9jXk+gKzzZHN5WzN1BMqW6NQh/xfWAuiq6trG4rVsACCIaJOeEYsFXc2Ty47B4onDvyareK/jUA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1722681709; c=relaxed/simple; bh=5AgJN5aHDblbftkEIFfXfOsOG4+a7awLLmKJqobEli0=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=D8lN3OraV7MrYGB2xDq5StdbDkieKLSzB8XeSC2/+17gGLgW+dU8ndXA2g2XQb4/szjYKpBGBdMhNpA3u38+Py6klivbnfArPNBz/7FDDQJrh4e7EkdAKtELEd5QR1HYAbfMtoIZXWhWy28UDBapb0JIkri6dyGj4NRQiGKZzx8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=k1VxwT01; arc=none smtp.client-ip=209.85.208.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="k1VxwT01" Received: by mail-ed1-f46.google.com with SMTP id 4fb4d7f45d1cf-5a79df5af51so7117155a12.0 for ; Sat, 03 Aug 2024 03:41:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1722681706; x=1723286506; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=m8XLJ+HA0unzIKoKdtjXDUtkUVFRpH3N4K5zB2zQ6s4=; b=k1VxwT01D3KMJEO/kmfuMby77/JLWaNMCCCAaZ39VCgJD38z0RxCnO64FjXSf9tVtZ 0bgTWBqxMw5siefbWP6/IsmBeP60bR5+ETwmdSdo4ngPhuCpEnWTNoNlaZsfLiy4YPK2 7Lp9cym70xyRgAQaxsrxGTorMrXR0E7BaQbnIr1zsdAR88WzZKWDgL6FrareMpp8kq7H gRp+/4SDl2w1m7d/tqgwtUP34S6OFq66MJVHt+KVphTR9Wm5jT8hJ4vaFFXLdQFw74sM wkQXnuxErfPcKFic7b+MsAGSjC4hrG2FxhmCSJWoVyKdQIHClSqqGHWv4LvhfQxhtShN Kg3A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1722681706; x=1723286506; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=m8XLJ+HA0unzIKoKdtjXDUtkUVFRpH3N4K5zB2zQ6s4=; b=dlh/txu7rIkJlZmOVYglp9RV7qdxjQqnlfh0uOA312CEQSAHLWLu1kEOyOTjDjGSPw XVcZ9P82o0NiJbTVJm0Lb+VI1IlJFYWl1COP9PxqwRbESZ/9MLMVe5rSUkxR4s2EyDpB rN2rWujfFF8oZ+1jrt8qswj2shuyv0CE9yTSkU+cGmWRaU2ah7XChEdIW7W+iRC6UXGt XS+Okt577xAQo2oUjK8EiK6kIyWqqYNnNOvmkJHLOoCUI4cS9Vz9I+uaZYvy78oP7XIM v/qeAS6EoruUHRlT09/ZDYJJKjPKerhAAD6ste+/xcYtvT8NNVl8XPqMtaQekIDSq50d +n5w== X-Forwarded-Encrypted: i=1; AJvYcCXutVFRNJccTXOa2sbU8Y/I0roWpTwsittsVaXXy4bzc2NOKdOkliQzoXpa3C2uanoSLt44r2yPS3+mMqARfIjvPHXdcOYa/SK4Zk7hlA== X-Gm-Message-State: AOJu0Yxd/rN+P9tDSvuvKM/j4xwU9iSvT+ajHOUoVBzgzohy5RZeAPnK 75GbQS3qVMJSasRFc1DfQA1T2WLJmyb5+/EcvPPpRqRfADEYsbFsTK9GAz/FUK8= X-Google-Smtp-Source: AGHT+IHvt7AU+zU7xwu3ztuEExFnHw0l6EN0M9aJEJT/i5CZBMm1ydae3AJtvueqBZdlyT6zILCzIg== X-Received: by 2002:a17:907:9689:b0:a7a:81ba:8eb3 with SMTP id a640c23a62f3a-a7dbe630868mr712622766b.27.1722681705810; Sat, 03 Aug 2024 03:41:45 -0700 (PDT) Received: from umbar.lan ([192.130.178.91]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-a7dc9e7feecsm202086366b.176.2024.08.03.03.41.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 03 Aug 2024 03:41:45 -0700 (PDT) From: Dmitry Baryshkov Date: Sat, 03 Aug 2024 13:41:40 +0300 Subject: [PATCH 1/2] ASoC: codecs: lpass-macro: fix version strings returned for 1.x codecs Precedence: bulk X-Mailing-List: linux-arm-msm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20240803-codec-version-v1-1-bc29baa5e417@linaro.org> References: <20240803-codec-version-v1-0-bc29baa5e417@linaro.org> In-Reply-To: <20240803-codec-version-v1-0-bc29baa5e417@linaro.org> To: Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , Srinivas Kandagatla , Banajit Goswami Cc: linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org, alsa-devel@alsa-project.org, linux-arm-msm@vger.kernel.org, Dmitry Baryshkov X-Mailer: b4 0.14.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1032; i=dmitry.baryshkov@linaro.org; h=from:subject:message-id; bh=5AgJN5aHDblbftkEIFfXfOsOG4+a7awLLmKJqobEli0=; b=owEBbQGS/pANAwAKAYs8ij4CKSjVAcsmYgBmrglmLHOXtJFkuzvtwm4NKEq4/Mw0jlQEd65rl co+5GQLEJmJATMEAAEKAB0WIQRMcISVXLJjVvC4lX+LPIo+Aiko1QUCZq4JZgAKCRCLPIo+Aiko 1VFGCACvWH4yrjqDg8O8sGmAjvsoB7gb1LhWyK1QKUHycyeWlFzFIe+RQMGDqrWahB7sI+3kVCV o57BPiJmwj3QT9WRDwqaRt/N35ws7e8rmLeg33I2mVe2aimoKjenIQsiU31f82e9oxyfAxriF3z cgsdqXUiubsimZUB6bNQUtCWDWBdAW3kHD98O6eAV+fN/70yoCp13O+sLh2eIFwI85BQJHpBBLv MZCkKSIfQTFcPQNq4IqtffQt7+o++ReYgL39jsSq+mHzj7ACmXa5yG0OsCRrxVZY9/u8DmSqmnL na6rBtue7cMa1CdXkfliOOOhjaofxxnj2TiuNvFgW0bqyb2K X-Developer-Key: i=dmitry.baryshkov@linaro.org; a=openpgp; fpr=8F88381DD5C873E4AE487DA5199BF1243632046A Add missing cases to lpass_macro_get_codec_version_string() to let it print the correct codec version for 1.x codec platforms. Fixes: 378918d59181 ("ASoC: codecs: lpass-macro: add helpers to get codec version") Signed-off-by: Dmitry Baryshkov --- sound/soc/codecs/lpass-macro-common.h | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/sound/soc/codecs/lpass-macro-common.h b/sound/soc/codecs/lpass-macro-common.h index 21cb30ab706d..fb4b96cb2b23 100644 --- a/sound/soc/codecs/lpass-macro-common.h +++ b/sound/soc/codecs/lpass-macro-common.h @@ -49,6 +49,12 @@ static inline void lpass_macro_pds_exit_action(void *pds) static inline const char *lpass_macro_get_codec_version_string(int version) { switch (version) { + case LPASS_CODEC_VERSION_1_0: + return "v1.0"; + case LPASS_CODEC_VERSION_1_1: + return "v1.1"; + case LPASS_CODEC_VERSION_1_2: + return "v1.2"; case LPASS_CODEC_VERSION_2_0: return "v2.0"; case LPASS_CODEC_VERSION_2_1: From patchwork Sat Aug 3 10:41:41 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dmitry Baryshkov X-Patchwork-Id: 816633 Received: from mail-ed1-f44.google.com (mail-ed1-f44.google.com [209.85.208.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9C535137764 for ; Sat, 3 Aug 2024 10:41:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.44 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1722681710; cv=none; b=K8Z2FtsOhZbbAWPU7EB9aQ84YmMxkeT44Sj9XRARd+KnAucmjHqrVHmd5P/fe8Zm1TQkJiwrZW4VRn4ZwMZjTa7R92ziv4O9/ow4fajQo3C4hJLwC8z3Ll6xO79xfFz3aHH7gDjQQ4lVMQtPrsFVi5jHo2s5eQgHIpxJkLe7L8E= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1722681710; c=relaxed/simple; bh=8swDYCKlHMm/RjEDI1jjvRnoWAi33eYa7CllXV/57qw=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=YknzaN5zdCOmISbStygZOsysibpeklrqH48vyMsx1PCW3JQZloE8YnThZKv8AVsYi4yzu5WD/3uAPa0xXY5ODQyV0hBDHoEEQqW2kNGbRltMkOnmzFJlDz5XKEV80WluEcuOzuSfvvS2GGBRjkqsy2Hs9twj/thlFiNS9iH0x8M= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=j+cQvfFA; arc=none smtp.client-ip=209.85.208.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="j+cQvfFA" Received: by mail-ed1-f44.google.com with SMTP id 4fb4d7f45d1cf-5b3fff87e6bso6841623a12.0 for ; Sat, 03 Aug 2024 03:41:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1722681707; x=1723286507; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=h2P5CUm71nRXIdibIz1zY1EQPaX8kSIUbjLIcJ8FN4Y=; b=j+cQvfFAKoUJVj/EbdjFfbDZ23FnLF/JmUTZqBzc22AEzxWPZkGMLcR6XzDFUEg07d O9zIzs2j5kUKFy4ZvCjwtu2FehhaDO6I7S7kQzum7SnZLyFJ54MnwaqByrHK6JlcX2ut OMcbjcFjepguGzuQY9dsZ1WCZCQe11ARaLiqGMa4u9RM8CIUXQz4yL0abDTqqzMIqCpz VHTy/TZB0p64pz4w4oJFAS4YWHVLVjPMoHIYJm8D7LejjUNW5W5dLWiA4xD9yWN5yMJP SRyEMFv5jv+FgfFXr43TBzRij5EpBLQsRM/iEN9/w1ClINQnnw/+opu5oOn/Ju08u3OS 3sFw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1722681707; x=1723286507; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=h2P5CUm71nRXIdibIz1zY1EQPaX8kSIUbjLIcJ8FN4Y=; b=JmMjw2BHw94A/wq0GXLUKf4KvfuMrX55pDCD5u3ADyBZAHxiKHei8K+q/pS6OSFteb jIdVhSknITnMnjKARUQrHmKp1vJKPMFHOYbqcxQGaIL2LlnE2JGUdp1vAl8qP3rU9aos 8S/wS3ulpEq61taTREzwZzpyND254e6SXn+nhIIkpHTjNg0cLDh4z21JUByhZ17JRpWE Mz+Ls8ytX7UcJzm3DSAfz1G+C+4LmlaF7ijxOLqR4/oRILqBxch6G/dJycoxW3xT9xK1 55bQx2P8b1NeTZuXBs2yIvMe5f6dOdWU6RUiTdT9FD17m2Hlf50mK3MRyofcx+Nnk7L7 cAeQ== X-Forwarded-Encrypted: i=1; AJvYcCVBxWYu/DDQEkmpM++YvNAVtzIAblcj4YDrrDvo23ib9gXhzqo5HNhOmugSrBG6IRFUkw676wSXioViA5fijaCUhlBJNLemtOwWuwMICw== X-Gm-Message-State: AOJu0YyY59SGLvVxhfpigAq15i+wKYNW2VCiucNHr+Tv9R44aYdv69L8 Kj7YnW7WJ4UNGSITEs81cYHIapa5zNgeMqkhzX8f86ON3pIN0qBJ5vIJaAW7Uvg= X-Google-Smtp-Source: AGHT+IGx8JIglmqEtvVOloITy2p1V5U6PesAEG1DHceXHVPF+dkLXz1ocl5KFlVXTMxUWNwK3835aA== X-Received: by 2002:a17:907:6093:b0:a7a:a7b8:ada7 with SMTP id a640c23a62f3a-a7dc4df97f8mr402428566b.24.1722681706827; Sat, 03 Aug 2024 03:41:46 -0700 (PDT) Received: from umbar.lan ([192.130.178.91]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-a7dc9e7feecsm202086366b.176.2024.08.03.03.41.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 03 Aug 2024 03:41:46 -0700 (PDT) From: Dmitry Baryshkov Date: Sat, 03 Aug 2024 13:41:41 +0300 Subject: [PATCH 2/2] ASoC: codecs: lpass-va-macro: warn on unknown version Precedence: bulk X-Mailing-List: linux-arm-msm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20240803-codec-version-v1-2-bc29baa5e417@linaro.org> References: <20240803-codec-version-v1-0-bc29baa5e417@linaro.org> In-Reply-To: <20240803-codec-version-v1-0-bc29baa5e417@linaro.org> To: Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , Srinivas Kandagatla , Banajit Goswami Cc: linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org, alsa-devel@alsa-project.org, linux-arm-msm@vger.kernel.org, Dmitry Baryshkov X-Mailer: b4 0.14.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1126; i=dmitry.baryshkov@linaro.org; h=from:subject:message-id; bh=8swDYCKlHMm/RjEDI1jjvRnoWAi33eYa7CllXV/57qw=; b=owEBbQGS/pANAwAKAYs8ij4CKSjVAcsmYgBmrglnQf2eSPxhCPoW50YyCE1b+UmchLkcoNa1+ dvwTlj910+JATMEAAEKAB0WIQRMcISVXLJjVvC4lX+LPIo+Aiko1QUCZq4JZwAKCRCLPIo+Aiko 1VfsCACUeTsaUC8cUzv19Lh7pPQnhShgpW6Nj2314n5dvpeCHe4zpggfLbi8sxpB6rdB/mz6e9H ILm68xJuIZXE+HtM5m0JwHucNwU7sNeTWqPL/vhcgNKyH4jZeoyAHwMYutMqkeXoIuspg36KcU4 nMqEIszCdROdPeJ7pzaXs7pP05lW67SDv9bJi6u4YTCPIJuhlMVcpEl7nEWKHJ8xbRsDghHhf0T sQM/WWIddmjWKwEG298mvWjM6wsDDjfMLlSMkmH65C+EZctbnxD+EijiFMdjHhpRN6wJ0qUDUMr OhV4HE4+/VdZBtnQLKlXKDH9paR4HGoCR8FGMNvgSJPsfQxN X-Developer-Key: i=dmitry.baryshkov@linaro.org; a=openpgp; fpr=8F88381DD5C873E4AE487DA5199BF1243632046A Warn the users if the driver doesn't know the codec version. This helps in debugging the issues with other codec not detecting the correct version. va_macro 3370000.codec: Unknown VA Codec version, ID: 00 / 0f / 00 Signed-off-by: Dmitry Baryshkov --- sound/soc/codecs/lpass-va-macro.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/sound/soc/codecs/lpass-va-macro.c b/sound/soc/codecs/lpass-va-macro.c index b852cc7ffad9..cdc090418d74 100644 --- a/sound/soc/codecs/lpass-va-macro.c +++ b/sound/soc/codecs/lpass-va-macro.c @@ -1483,6 +1483,10 @@ static void va_macro_set_lpass_codec_version(struct va_macro *va) if ((core_id_0 == 0x02) && (core_id_1 == 0x0F) && (core_id_2 == 0x80 || core_id_2 == 0x81)) version = LPASS_CODEC_VERSION_2_8; + if (version == LPASS_CODEC_VERSION_UNKNOWN) + dev_warn(va->dev, "Unknown Codec version, ID: %02x / %02x / %02x\n", + core_id_0, core_id_1, core_id_2); + lpass_macro_set_codec_version(version); dev_dbg(va->dev, "LPASS Codec Version %s\n", lpass_macro_get_codec_version_string(version));