From patchwork Sat Aug 3 10:41:40 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dmitry Baryshkov X-Patchwork-Id: 817130 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (unknown [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7BEA3C52D6D for ; Sat, 3 Aug 2024 10:48:28 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id CD6C447E7; Sat, 3 Aug 2024 12:48:06 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz CD6C447E7 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1722682096; bh=5AgJN5aHDblbftkEIFfXfOsOG4+a7awLLmKJqobEli0=; h=From:Date:Subject:References:In-Reply-To:To:Cc:List-Id: List-Archive:List-Help:List-Owner:List-Post:List-Subscribe: List-Unsubscribe:From; b=YJWCu4vVC05Nb6qCBY3NZZbAsmUYHdOSmJZeINCQlDsrU9eIob6G4DQcZZ2rhnrZu hXR2ZCdfjntWr331jGk/WB/k9QnWJ54Kf93FKnIJREZCK3HBO24AI9V9v53ZI0QgNY SD0ioXyirNggywCeeVQpLeDrhFyyt0WLnBEQ710Q= Received: by alsa1.perex.cz (Postfix, from userid 50401) id 8F30CF805E4; Sat, 3 Aug 2024 12:47:13 +0200 (CEST) Received: from mailman-core.alsa-project.org (mailman-core.alsa-project.org [10.254.200.10]) by alsa1.perex.cz (Postfix) with ESMTP id 281F4F80601; Sat, 3 Aug 2024 12:47:13 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id D307FF8007E; Sat, 3 Aug 2024 12:44:12 +0200 (CEST) Received: from mail-ed1-x531.google.com (mail-ed1-x531.google.com [IPv6:2a00:1450:4864:20::531]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 65619F8007E for ; Sat, 3 Aug 2024 12:41:46 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 65619F8007E Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key, unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256 header.s=google header.b=Q7OseUAt Received: by mail-ed1-x531.google.com with SMTP id 4fb4d7f45d1cf-5af326eddb2so6851624a12.1 for ; Sat, 03 Aug 2024 03:41:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1722681706; x=1723286506; darn=alsa-project.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=m8XLJ+HA0unzIKoKdtjXDUtkUVFRpH3N4K5zB2zQ6s4=; b=Q7OseUAtlWp6CSlXN3Mp/juxeyKDSUkJ+Uz2H61AVmj+/hek12ssn5+bQ5M51gj9NB WFRD4uPfvpYMgExMxECajrd4TYPBMOA0ZEPR4jExr+scZkMguD/iNVukMAQajRG6U6r8 TJUnWYUm00v7oii0yzwZVvT/1h2kqt+PX9XjEd0v2ZzMoEdIiBqwVzXqnlErtXKnl+kM D3vmnmEpk9l2bFwI/ODakmDXwqsq4tJAmuDr1w7egsStuSFBkAmXYoqk82Zrgfs/8Med 5giS9sFIglcwoGbWs/zZLnDj6DfsnA7Xz+LnjGQuvgIye/r6CP0ByQT557n+xhFnGmGn MI7g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1722681706; x=1723286506; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=m8XLJ+HA0unzIKoKdtjXDUtkUVFRpH3N4K5zB2zQ6s4=; b=OltdOCFJhvi1IjOM2mvuyF+oZg6MaUAGF3yMBp4aaBk804mkHpOSR0aiwn5Ubvmdlg LdKgLe6YiKcfXQYtNIvvXYbadtxASTtIpxBhu2htYTMCWL5GeSaoZJQ14CH/RbP7FKPb gr0KqQKlOxEs+tOJ1lwxoaJ0DKIl39BwObW1tL/ScJttGQhKgtuu3KUg7WH1O7bF3ySr FGoOe02cLYSay5KEiMDOpqBcUfA6q8RWLEi3HDriVr2ncymw+2QukxHgh7mjgfF6QM+Z zFgHzbePwpNUtA7zLYgWB+ErEjklA4f0H5CPFKt/qrtsexwBHwqFvSP+Ti2CkbIZFaVG Yb+Q== X-Forwarded-Encrypted: i=1; AJvYcCUsyMU2iUmkIdfkhZypwQF02tuQ679r9QL2npSakCW2M2Nv6ZElNgOGAL7RUODakSwDn+zB479iI1w9/3I+rmP3ZAHVnnida2d1RTA= X-Gm-Message-State: AOJu0YzjVe7NnII9fiW+OTMYwvWHnOdHb9LHVPX8EKxF+Wn6K3/UnR6h wqyv6ndlxVrTsIKgZgHc75Am5quBzHF9VbA7UUJxI6YJ2LamRz8QkN0xgzqUwfg= X-Google-Smtp-Source: AGHT+IHvt7AU+zU7xwu3ztuEExFnHw0l6EN0M9aJEJT/i5CZBMm1ydae3AJtvueqBZdlyT6zILCzIg== X-Received: by 2002:a17:907:9689:b0:a7a:81ba:8eb3 with SMTP id a640c23a62f3a-a7dbe630868mr712622766b.27.1722681705810; Sat, 03 Aug 2024 03:41:45 -0700 (PDT) Received: from umbar.lan ([192.130.178.91]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-a7dc9e7feecsm202086366b.176.2024.08.03.03.41.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 03 Aug 2024 03:41:45 -0700 (PDT) From: Dmitry Baryshkov Date: Sat, 03 Aug 2024 13:41:40 +0300 Subject: [PATCH 1/2] ASoC: codecs: lpass-macro: fix version strings returned for 1.x codecs MIME-Version: 1.0 Message-Id: <20240803-codec-version-v1-1-bc29baa5e417@linaro.org> References: <20240803-codec-version-v1-0-bc29baa5e417@linaro.org> In-Reply-To: <20240803-codec-version-v1-0-bc29baa5e417@linaro.org> To: Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , Srinivas Kandagatla , Banajit Goswami Cc: linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org, alsa-devel@alsa-project.org, linux-arm-msm@vger.kernel.org, Dmitry Baryshkov X-Mailer: b4 0.14.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1032; i=dmitry.baryshkov@linaro.org; h=from:subject:message-id; bh=5AgJN5aHDblbftkEIFfXfOsOG4+a7awLLmKJqobEli0=; b=owEBbQGS/pANAwAKAYs8ij4CKSjVAcsmYgBmrglmLHOXtJFkuzvtwm4NKEq4/Mw0jlQEd65rl co+5GQLEJmJATMEAAEKAB0WIQRMcISVXLJjVvC4lX+LPIo+Aiko1QUCZq4JZgAKCRCLPIo+Aiko 1VFGCACvWH4yrjqDg8O8sGmAjvsoB7gb1LhWyK1QKUHycyeWlFzFIe+RQMGDqrWahB7sI+3kVCV o57BPiJmwj3QT9WRDwqaRt/N35ws7e8rmLeg33I2mVe2aimoKjenIQsiU31f82e9oxyfAxriF3z cgsdqXUiubsimZUB6bNQUtCWDWBdAW3kHD98O6eAV+fN/70yoCp13O+sLh2eIFwI85BQJHpBBLv MZCkKSIfQTFcPQNq4IqtffQt7+o++ReYgL39jsSq+mHzj7ACmXa5yG0OsCRrxVZY9/u8DmSqmnL na6rBtue7cMa1CdXkfliOOOhjaofxxnj2TiuNvFgW0bqyb2K X-Developer-Key: i=dmitry.baryshkov@linaro.org; a=openpgp; fpr=8F88381DD5C873E4AE487DA5199BF1243632046A Message-ID-Hash: 6H2KSKMWWSQM5O7SDOUBYVHRPM7H46G2 X-Message-ID-Hash: 6H2KSKMWWSQM5O7SDOUBYVHRPM7H46G2 X-MailFrom: dmitry.baryshkov@linaro.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-alsa-devel.alsa-project.org-0; header-match-alsa-devel.alsa-project.org-1; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.9 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Add missing cases to lpass_macro_get_codec_version_string() to let it print the correct codec version for 1.x codec platforms. Fixes: 378918d59181 ("ASoC: codecs: lpass-macro: add helpers to get codec version") Signed-off-by: Dmitry Baryshkov --- sound/soc/codecs/lpass-macro-common.h | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/sound/soc/codecs/lpass-macro-common.h b/sound/soc/codecs/lpass-macro-common.h index 21cb30ab706d..fb4b96cb2b23 100644 --- a/sound/soc/codecs/lpass-macro-common.h +++ b/sound/soc/codecs/lpass-macro-common.h @@ -49,6 +49,12 @@ static inline void lpass_macro_pds_exit_action(void *pds) static inline const char *lpass_macro_get_codec_version_string(int version) { switch (version) { + case LPASS_CODEC_VERSION_1_0: + return "v1.0"; + case LPASS_CODEC_VERSION_1_1: + return "v1.1"; + case LPASS_CODEC_VERSION_1_2: + return "v1.2"; case LPASS_CODEC_VERSION_2_0: return "v2.0"; case LPASS_CODEC_VERSION_2_1: From patchwork Sat Aug 3 10:41:41 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dmitry Baryshkov X-Patchwork-Id: 816518 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (unknown [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 00298C52D6D for ; Sat, 3 Aug 2024 10:48:17 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 88B5947CB; Sat, 3 Aug 2024 12:47:55 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 88B5947CB DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1722682085; bh=8swDYCKlHMm/RjEDI1jjvRnoWAi33eYa7CllXV/57qw=; h=From:Date:Subject:References:In-Reply-To:To:Cc:List-Id: List-Archive:List-Help:List-Owner:List-Post:List-Subscribe: List-Unsubscribe:From; b=sevkQ1WLoVOsc+1dzXPjWCp7FvH/6kI0hW0/a1p33SF/Bo08MXSJXwL1s4my28tHx 2yOdpB2DGhemN8gFxmDpdCH+nbSgEwgiiEkba//wIPirKZdCgnqkdo5nJYK9eR/G7p A4xUdvCXw1nw3sQRCczLIsb+AC4Va6WpRpfWnTgQ= Received: by alsa1.perex.cz (Postfix, from userid 50401) id A959DF805BD; Sat, 3 Aug 2024 12:47:12 +0200 (CEST) Received: from mailman-core.alsa-project.org (mailman-core.alsa-project.org [10.254.200.10]) by alsa1.perex.cz (Postfix) with ESMTP id 18FCFF805E2; Sat, 3 Aug 2024 12:47:12 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 2C5A8F8026A; Sat, 3 Aug 2024 12:42:12 +0200 (CEST) Received: from mail-ej1-x631.google.com (mail-ej1-x631.google.com [IPv6:2a00:1450:4864:20::631]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 92FBDF801C0 for ; Sat, 3 Aug 2024 12:41:48 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 92FBDF801C0 Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key, unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256 header.s=google header.b=Aqq5fypB Received: by mail-ej1-x631.google.com with SMTP id a640c23a62f3a-a7a843bef98so941684566b.2 for ; Sat, 03 Aug 2024 03:41:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1722681707; x=1723286507; darn=alsa-project.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=h2P5CUm71nRXIdibIz1zY1EQPaX8kSIUbjLIcJ8FN4Y=; b=Aqq5fypBDZc1c2jmta3B86PLBdD/Kfy8QRA7PIiBwHU+dB1zUXkam82bcHZLGDge+g mUTnyYugbSaFLekpBV1X8cv/5hW/vS5AwFzl/F3S+1BZ43oYqjHqqa/zBtzSQAYNn5V4 lm3O5s1y16bOduLM23jO9/zII8AdFGLh+LwetmzTzZuoCc9WIcN+beQIEhGFpU6cnrDq H38CNh54ULwXNvedslAOVQyK7prqRerEL9HPaeBC/nkoEpf3AyiUR4cD3MCDJQvU54ls qonUHs6eG9uyL4082qKQ8xGNQzCcsCbJzVQ3JUxCrv55FvLvxgsUHC6gdQgNwayLLjlP hqhw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1722681707; x=1723286507; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=h2P5CUm71nRXIdibIz1zY1EQPaX8kSIUbjLIcJ8FN4Y=; b=QIhR3RiuBmbDajUSHK4jUTJj4P+K9jGltv/L/P4MTsCof8GuDAjzwWr6yXoanKZitP 4PdbciDcLOeb7I08P4LAvJZsUhgilAuD6UVWokFXgS51M2MpoBIwnKP6f10L5DRrcLZo /Exp83s+mhPD0vtmT/dtKxhrIcsESB3LqwKAzP8ZZElfp4O+O6eWqugBX9Sk4AO2V7dN +nrsV6JLAmVu+rMceBPehncpJGn7cdut0jNQNKlOj/JxXQq5OfodLftppxEkHblWGkIc 4PnIYPB3tkDhnZPeHQZWgpAv7Uy6h2d++37ALf6pyJX4Df2I3He0lLEXzmWCdAEroh2Q QOFw== X-Forwarded-Encrypted: i=1; AJvYcCVekL18oHaXcTzmAkOatiwnA47Pr0wljzKUIRQpC7v8xfWI5gurkjmfs1mHbJgmVDo6VrZsOWIX27Box6sOhLmKYawhr7EAF9hS5DM= X-Gm-Message-State: AOJu0YywFeRlJgrTplTf0jYXmY8JHNu1e+H6RoMHhaSHQ/kU5tRDxckO NXAKHy5F7RsOgG10dwVeFil7CDBxDSOwG78gcoUiUFJUHMlQ/2cmykfIKYFbe7U= X-Google-Smtp-Source: AGHT+IGx8JIglmqEtvVOloITy2p1V5U6PesAEG1DHceXHVPF+dkLXz1ocl5KFlVXTMxUWNwK3835aA== X-Received: by 2002:a17:907:6093:b0:a7a:a7b8:ada7 with SMTP id a640c23a62f3a-a7dc4df97f8mr402428566b.24.1722681706827; Sat, 03 Aug 2024 03:41:46 -0700 (PDT) Received: from umbar.lan ([192.130.178.91]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-a7dc9e7feecsm202086366b.176.2024.08.03.03.41.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 03 Aug 2024 03:41:46 -0700 (PDT) From: Dmitry Baryshkov Date: Sat, 03 Aug 2024 13:41:41 +0300 Subject: [PATCH 2/2] ASoC: codecs: lpass-va-macro: warn on unknown version MIME-Version: 1.0 Message-Id: <20240803-codec-version-v1-2-bc29baa5e417@linaro.org> References: <20240803-codec-version-v1-0-bc29baa5e417@linaro.org> In-Reply-To: <20240803-codec-version-v1-0-bc29baa5e417@linaro.org> To: Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , Srinivas Kandagatla , Banajit Goswami Cc: linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org, alsa-devel@alsa-project.org, linux-arm-msm@vger.kernel.org, Dmitry Baryshkov X-Mailer: b4 0.14.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1126; i=dmitry.baryshkov@linaro.org; h=from:subject:message-id; bh=8swDYCKlHMm/RjEDI1jjvRnoWAi33eYa7CllXV/57qw=; b=owEBbQGS/pANAwAKAYs8ij4CKSjVAcsmYgBmrglnQf2eSPxhCPoW50YyCE1b+UmchLkcoNa1+ dvwTlj910+JATMEAAEKAB0WIQRMcISVXLJjVvC4lX+LPIo+Aiko1QUCZq4JZwAKCRCLPIo+Aiko 1VfsCACUeTsaUC8cUzv19Lh7pPQnhShgpW6Nj2314n5dvpeCHe4zpggfLbi8sxpB6rdB/mz6e9H ILm68xJuIZXE+HtM5m0JwHucNwU7sNeTWqPL/vhcgNKyH4jZeoyAHwMYutMqkeXoIuspg36KcU4 nMqEIszCdROdPeJ7pzaXs7pP05lW67SDv9bJi6u4YTCPIJuhlMVcpEl7nEWKHJ8xbRsDghHhf0T sQM/WWIddmjWKwEG298mvWjM6wsDDjfMLlSMkmH65C+EZctbnxD+EijiFMdjHhpRN6wJ0qUDUMr OhV4HE4+/VdZBtnQLKlXKDH9paR4HGoCR8FGMNvgSJPsfQxN X-Developer-Key: i=dmitry.baryshkov@linaro.org; a=openpgp; fpr=8F88381DD5C873E4AE487DA5199BF1243632046A Message-ID-Hash: 5A6HO4WYA6VNDKO25OW3RW26JJVMCUQV X-Message-ID-Hash: 5A6HO4WYA6VNDKO25OW3RW26JJVMCUQV X-MailFrom: dmitry.baryshkov@linaro.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-alsa-devel.alsa-project.org-0; header-match-alsa-devel.alsa-project.org-1; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.9 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Warn the users if the driver doesn't know the codec version. This helps in debugging the issues with other codec not detecting the correct version. va_macro 3370000.codec: Unknown VA Codec version, ID: 00 / 0f / 00 Signed-off-by: Dmitry Baryshkov --- sound/soc/codecs/lpass-va-macro.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/sound/soc/codecs/lpass-va-macro.c b/sound/soc/codecs/lpass-va-macro.c index b852cc7ffad9..cdc090418d74 100644 --- a/sound/soc/codecs/lpass-va-macro.c +++ b/sound/soc/codecs/lpass-va-macro.c @@ -1483,6 +1483,10 @@ static void va_macro_set_lpass_codec_version(struct va_macro *va) if ((core_id_0 == 0x02) && (core_id_1 == 0x0F) && (core_id_2 == 0x80 || core_id_2 == 0x81)) version = LPASS_CODEC_VERSION_2_8; + if (version == LPASS_CODEC_VERSION_UNKNOWN) + dev_warn(va->dev, "Unknown Codec version, ID: %02x / %02x / %02x\n", + core_id_0, core_id_1, core_id_2); + lpass_macro_set_codec_version(version); dev_dbg(va->dev, "LPASS Codec Version %s\n", lpass_macro_get_codec_version_string(version));