From patchwork Fri Aug 2 12:46:06 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Pierre-Louis Bossart X-Patchwork-Id: 816280 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (unknown [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A07CAC3DA4A for ; Fri, 2 Aug 2024 12:47:33 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id CA37D462A; Fri, 2 Aug 2024 14:47:12 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz CA37D462A DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1722602842; bh=XBS9PxZs/DQyKy80vX3Y7aB81pdtJGCDeOOoRgQsmwY=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-Id: List-Archive:List-Help:List-Owner:List-Post:List-Subscribe: List-Unsubscribe:From; b=anyY8W575q7UESYxFUupeYBfjtHjyNjz090xj+tUwKzWrLLtE1mkm5rCZzJQg7ylz wKTPRoRF1U4tLppM7pkA5C4NSMEVrx5acqMsWGk2LYX0b9SshJQvKBnNGcLGZaxltn oziNPsasi/u4BjpTe0MYTNgtqXcIf+9yUNpPUG2o= Received: by alsa1.perex.cz (Postfix, from userid 50401) id 0BC06F805F7; Fri, 2 Aug 2024 14:46:33 +0200 (CEST) Received: from mailman-core.alsa-project.org (mailman-core.alsa-project.org [10.254.200.10]) by alsa1.perex.cz (Postfix) with ESMTP id 23B74F805E3; Fri, 2 Aug 2024 14:46:33 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id A28A0F8026A; Fri, 2 Aug 2024 14:46:27 +0200 (CEST) Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 7250EF800B0 for ; Fri, 2 Aug 2024 14:46:25 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 7250EF800B0 Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key, unprotected) header.d=intel.com header.i=@intel.com header.a=rsa-sha256 header.s=Intel header.b=eq4zfuM9 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1722602787; x=1754138787; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=XBS9PxZs/DQyKy80vX3Y7aB81pdtJGCDeOOoRgQsmwY=; b=eq4zfuM93k6UcPghiCKweXzHIWVU1urDKEOeDxk4qmZ+wFcqTVNs9b2f nDCicKfTxKcRuRZ5y6SGAScHd//Bjq7ocD4BzZEASpavO1KIaSy1uW+YE yBloBpvLZGY90s8LBJ2hBPAsOfL4CNAKf7xLgdenkzcXBk19zEv50ZOtT VNbD6FR56SxfrAFz9axERF0BneudKmzFvujm5UYgVpLLJPAZ1F/ShZtbc Z0W9L9+V0Vxv9dubWtvaaeVOJ9L9KpZYiQX87pImZ9qqQ9ppRxPRfE9f/ aNYtFOHRrnHTsybXk4Vkt+b6SZjvUePQuxWzX3w7LCiwg0UrRif666IUw A==; X-CSE-ConnectionGUID: zQTWJJMYQLyAA8pjU+YCvQ== X-CSE-MsgGUID: W9npddkCT0WvOf0iFGpqYA== X-IronPort-AV: E=McAfee;i="6700,10204,11152"; a="20199380" X-IronPort-AV: E=Sophos;i="6.09,257,1716274800"; d="scan'208";a="20199380" Received: from orviesa004.jf.intel.com ([10.64.159.144]) by fmvoesa112.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Aug 2024 05:46:24 -0700 X-CSE-ConnectionGUID: tOD1a0kvQaureISg0dzQ2A== X-CSE-MsgGUID: fjelm9b1RTO/i455o8ZSIw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.09,257,1716274800"; d="scan'208";a="60407845" Received: from ltuz-desk.ger.corp.intel.com (HELO pbossart-mobl6.intel.com) ([10.245.246.89]) by orviesa004-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Aug 2024 05:46:21 -0700 From: Pierre-Louis Bossart To: linux-sound@vger.kernel.org Cc: alsa-devel@alsa-project.org, tiwai@suse.de, broonie@kernel.org, Pierre-Louis Bossart , Ranjani Sridharan , =?utf-8?q?P=C3=A9ter?= =?utf-8?q?_Ujfalusi?= Subject: [PATCH 1/4] ASoC: SOF: sof-priv.h: optimize snd_sof_platform_stream_params Date: Fri, 2 Aug 2024 14:46:06 +0200 Message-ID: <20240802124609.188954-2-pierre-louis.bossart@linux.intel.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240802124609.188954-1-pierre-louis.bossart@linux.intel.com> References: <20240802124609.188954-1-pierre-louis.bossart@linux.intel.com> MIME-Version: 1.0 Message-ID-Hash: JNCQQBT4DSR2MII54GYUQU4CM7XABJ5S X-Message-ID-Hash: JNCQQBT4DSR2MII54GYUQU4CM7XABJ5S X-MailFrom: pierre-louis.bossart@linux.intel.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-alsa-devel.alsa-project.org-0; header-match-alsa-devel.alsa-project.org-1; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.9 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: reshuffle members to remove hole. Signed-off-by: Pierre-Louis Bossart Reviewed-by: Ranjani Sridharan Reviewed-by: Péter Ujfalusi --- sound/soc/sof/sof-priv.h | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/sound/soc/sof/sof-priv.h b/sound/soc/sof/sof-priv.h index 4d6a1517f9b3..28179a573762 100644 --- a/sound/soc/sof/sof-priv.h +++ b/sound/soc/sof/sof-priv.h @@ -132,16 +132,17 @@ struct snd_sof_pdata; /** * struct snd_sof_platform_stream_params - platform dependent stream parameters - * @stream_tag: Stream tag to use - * @use_phy_addr: Use the provided @phy_addr for configuration * @phy_addr: Platform dependent address to be used, if @use_phy_addr * is true + * @stream_tag: Stream tag to use + * @use_phy_addr: Use the provided @phy_addr for configuration * @no_ipc_position: Disable position update IPC from firmware + * @cont_update_posn: Continuous position update. */ struct snd_sof_platform_stream_params { + u32 phy_addr; u16 stream_tag; bool use_phy_address; - u32 phy_addr; bool no_ipc_position; bool cont_update_posn; }; From patchwork Fri Aug 2 12:46:07 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Pierre-Louis Bossart X-Patchwork-Id: 816522 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (unknown [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id CE33EC52D6D for ; Fri, 2 Aug 2024 12:47:48 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 6FAB44656; Fri, 2 Aug 2024 14:47:23 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 6FAB44656 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1722602853; bh=fpxs6tDpDWLpeRh4dVFvDcdkPptt+K5RS8hhS8lBskk=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-Id: List-Archive:List-Help:List-Owner:List-Post:List-Subscribe: List-Unsubscribe:From; b=bHYCrZXyTLIQvrZaOG4v+LFtCwo6IZyS92epXNm87gsMqludYT0fceIy9nB4Lw805 hpKbbRmdMZUACz/Z8X4DOM7//BX86xOOqj/utqIQNyR9gcxoEf4ejjs4ZfYV700Va3 JTiKgrCeqJXTNOPk5zhwX2aX91b5nCr4wcO5Kl4o= Received: by alsa1.perex.cz (Postfix, from userid 50401) id 585C0F805D7; Fri, 2 Aug 2024 14:46:34 +0200 (CEST) Received: from mailman-core.alsa-project.org (mailman-core.alsa-project.org [10.254.200.10]) by alsa1.perex.cz (Postfix) with ESMTP id 8F14AF80604; Fri, 2 Aug 2024 14:46:34 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 4E492F8026A; Fri, 2 Aug 2024 14:46:29 +0200 (CEST) Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 575F1F800E3 for ; Fri, 2 Aug 2024 14:46:26 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 575F1F800E3 Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key, unprotected) header.d=intel.com header.i=@intel.com header.a=rsa-sha256 header.s=Intel header.b=feCCQgh5 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1722602789; x=1754138789; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=fpxs6tDpDWLpeRh4dVFvDcdkPptt+K5RS8hhS8lBskk=; b=feCCQgh5weatGsnwYXzt20c9HM++RLA4i8QuPwhSOBjNXEu5UlUQ9LTg WZAFm47eKPL1Ii9hTbDOCSxJaO10NdTKb+/X6kBR21WxhNVK1fUZbY0X4 l2LzfLr3klY2f0Lo4/Od1jpEaB/xU6Uub0gLk9nGViQem14Oh+61rEDCu ftndPs5Tqca5UVjS+QGccFMjeMcZkYat6jy/URNWVL9k5hsOINfeyuW3H Pp+hMpXWMA2W05AITMY0OduYYqDqpmWUhUeIzk5OmEFASqaaQCrU1UAk3 Jnjd/3Ww8KGi409jPgCKFVji3BylZUp/SWDSwczKhFaHvSi1TxlQd2k9q A==; X-CSE-ConnectionGUID: O0BXqcSPQjS6brWCEbYyaw== X-CSE-MsgGUID: tD4WlcfxSKyDYVZoHI0UsA== X-IronPort-AV: E=McAfee;i="6700,10204,11152"; a="20199384" X-IronPort-AV: E=Sophos;i="6.09,257,1716274800"; d="scan'208";a="20199384" Received: from orviesa004.jf.intel.com ([10.64.159.144]) by fmvoesa112.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Aug 2024 05:46:26 -0700 X-CSE-ConnectionGUID: PhUPz21JQ7SWHBluGA8WtQ== X-CSE-MsgGUID: dSMUo1SuSQaG1MLr/Onh+Q== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.09,257,1716274800"; d="scan'208";a="60407872" Received: from ltuz-desk.ger.corp.intel.com (HELO pbossart-mobl6.intel.com) ([10.245.246.89]) by orviesa004-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Aug 2024 05:46:24 -0700 From: Pierre-Louis Bossart To: linux-sound@vger.kernel.org Cc: alsa-devel@alsa-project.org, tiwai@suse.de, broonie@kernel.org, Pierre-Louis Bossart , Ranjani Sridharan , =?utf-8?q?P=C3=A9ter?= =?utf-8?q?_Ujfalusi?= Subject: [PATCH 2/4] ASoC: SOF: sof-priv.h: optimize snd_sof_mailbox Date: Fri, 2 Aug 2024 14:46:07 +0200 Message-ID: <20240802124609.188954-3-pierre-louis.bossart@linux.intel.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240802124609.188954-1-pierre-louis.bossart@linux.intel.com> References: <20240802124609.188954-1-pierre-louis.bossart@linux.intel.com> MIME-Version: 1.0 Message-ID-Hash: ZVJ5NTTCEYDTQG2BDIKAUEPQTGCIS225 X-Message-ID-Hash: ZVJ5NTTCEYDTQG2BDIKAUEPQTGCIS225 X-MailFrom: pierre-louis.bossart@linux.intel.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-alsa-devel.alsa-project.org-0; header-match-alsa-devel.alsa-project.org-1; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.9 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Reverse the two members to remove a hole. Signed-off-by: Pierre-Louis Bossart Reviewed-by: Ranjani Sridharan Reviewed-by: Péter Ujfalusi --- sound/soc/sof/sof-priv.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/soc/sof/sof-priv.h b/sound/soc/sof/sof-priv.h index 28179a573762..6ecc58e11592 100644 --- a/sound/soc/sof/sof-priv.h +++ b/sound/soc/sof/sof-priv.h @@ -412,8 +412,8 @@ struct snd_sof_debugfs_map { /* mailbox descriptor, used for host <-> DSP IPC */ struct snd_sof_mailbox { - u32 offset; size_t size; + u32 offset; }; /* IPC message descriptor for host <-> DSP IO */ From patchwork Fri Aug 2 12:46:08 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Pierre-Louis Bossart X-Patchwork-Id: 816279 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (unknown [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E95D7C52D6D for ; Fri, 2 Aug 2024 12:48:07 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 1C8B64612; Fri, 2 Aug 2024 14:47:42 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 1C8B64612 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1722602872; bh=5foePlp2+cV6Hcaj7mVVBKfwSze+k9WjEGjj4Z0R3rM=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-Id: List-Archive:List-Help:List-Owner:List-Post:List-Subscribe: List-Unsubscribe:From; b=EEMkfQksEvGIxhmFYSAYH4Enbd06h5JNudbtMl7+l45+3SrMDFEu5BuLfdb3NBg7g bT5yvX9bBl0rFQ/5NZESgvkAR0EcdXaXNcBccXm9vUR65qc5jZYQ78Zv0kxztGUpLp EYO5Os4CwQq+uaWkf2jwd2Lpse1OfObybz1zJUd0= Received: by alsa1.perex.cz (Postfix, from userid 50401) id B51FAF80621; Fri, 2 Aug 2024 14:46:39 +0200 (CEST) Received: from mailman-core.alsa-project.org (mailman-core.alsa-project.org [10.254.200.10]) by alsa1.perex.cz (Postfix) with ESMTP id 4CA71F80621; Fri, 2 Aug 2024 14:46:39 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 38A1DF805E9; Fri, 2 Aug 2024 14:46:34 +0200 (CEST) Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 191C3F805AD for ; Fri, 2 Aug 2024 14:46:30 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 191C3F805AD Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key, unprotected) header.d=intel.com header.i=@intel.com header.a=rsa-sha256 header.s=Intel header.b=fJhnCSkW DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1722602792; x=1754138792; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=5foePlp2+cV6Hcaj7mVVBKfwSze+k9WjEGjj4Z0R3rM=; b=fJhnCSkW4+phsXsE4ABhPCs2rOBQZDDQVKX+4Vb/CS4ggzQ9cOLgikGS /ILnBlC4WoEECgjepxndrwkEiGYBcljy+GPXV+ElSY+tyIq5zjN3k1esS GG3Rpfpjm3R3QugzDtdl5K/lSQpMi+emlzdhydkv8itRkPQS9UeXbDmKB T7d8ehachqfgwE+1dIrxCgoemFoHvzL/LMJoZnfvsOEludVFzLjdkDf8F THKv0cDBIQG76QQAeUExLO4bxzAs45H9AFBBDg6J9I9FXtxs6EBjOdwgS sRSdcUJ+VUFVRgau9IARi1t7VXlKJzbNC/7lq2EDAfZjvaBGkpRbC7cOP A==; X-CSE-ConnectionGUID: S3A1jQB0T02RBYV3iZPjqQ== X-CSE-MsgGUID: ZA/eYbznRxW32kldi/Tb/A== X-IronPort-AV: E=McAfee;i="6700,10204,11152"; a="20199389" X-IronPort-AV: E=Sophos;i="6.09,257,1716274800"; d="scan'208";a="20199389" Received: from orviesa004.jf.intel.com ([10.64.159.144]) by fmvoesa112.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Aug 2024 05:46:29 -0700 X-CSE-ConnectionGUID: yAC/kB31QJmlUPxIkGuiRg== X-CSE-MsgGUID: GpK/gihXTRaGT//6H3+6jA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.09,257,1716274800"; d="scan'208";a="60407888" Received: from ltuz-desk.ger.corp.intel.com (HELO pbossart-mobl6.intel.com) ([10.245.246.89]) by orviesa004-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Aug 2024 05:46:26 -0700 From: Pierre-Louis Bossart To: linux-sound@vger.kernel.org Cc: alsa-devel@alsa-project.org, tiwai@suse.de, broonie@kernel.org, Pierre-Louis Bossart , Ranjani Sridharan , =?utf-8?q?P=C3=A9ter?= =?utf-8?q?_Ujfalusi?= Subject: [PATCH 3/4] ASoC: SOF: sof-priv.h: optimize snd_sof_ipc_msg Date: Fri, 2 Aug 2024 14:46:08 +0200 Message-ID: <20240802124609.188954-4-pierre-louis.bossart@linux.intel.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240802124609.188954-1-pierre-louis.bossart@linux.intel.com> References: <20240802124609.188954-1-pierre-louis.bossart@linux.intel.com> MIME-Version: 1.0 Message-ID-Hash: 66ZHMTKQA6CXTDMDWEF3WCQH6ROURXLJ X-Message-ID-Hash: 66ZHMTKQA6CXTDMDWEF3WCQH6ROURXLJ X-MailFrom: pierre-louis.bossart@linux.intel.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-alsa-devel.alsa-project.org-0; header-match-alsa-devel.alsa-project.org-1; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.9 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Move waitq to make sure it's entirely in the same cache line, and move ipc_complete to reduce padding. struct snd_sof_ipc_msg { void * msg_data; /* 0 8 */ void * reply_data; /* 8 8 */ size_t msg_size; /* 16 8 */ size_t reply_size; /* 24 8 */ int reply_error; /* 32 4 */ bool ipc_complete; /* 36 1 */ /* XXX 3 bytes hole, try to pack */ wait_queue_head_t waitq; /* 40 88 */ /* --- cacheline 2 boundary (128 bytes) --- */ void * rx_data; /* 128 8 */ /* size: 136, cachelines: 3, members: 8 */ /* sum members: 133, holes: 1, sum holes: 3 */ /* last cacheline: 8 bytes */ }; Signed-off-by: Pierre-Louis Bossart Reviewed-by: Ranjani Sridharan Reviewed-by: Péter Ujfalusi --- sound/soc/sof/sof-priv.h | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/sound/soc/sof/sof-priv.h b/sound/soc/sof/sof-priv.h index 6ecc58e11592..843be3b6415d 100644 --- a/sound/soc/sof/sof-priv.h +++ b/sound/soc/sof/sof-priv.h @@ -425,11 +425,12 @@ struct snd_sof_ipc_msg { size_t reply_size; int reply_error; + bool ipc_complete; + + wait_queue_head_t waitq; + /* notification, firmware initiated messages */ void *rx_data; - - wait_queue_head_t waitq; - bool ipc_complete; }; /** From patchwork Fri Aug 2 12:46:09 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Pierre-Louis Bossart X-Patchwork-Id: 816521 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (unknown [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 02E39C3DA4A for ; Fri, 2 Aug 2024 12:48:21 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 4EA46469E; Fri, 2 Aug 2024 14:47:54 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 4EA46469E DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1722602884; bh=z+Sp/e05K5Vs3Docgs64RMH7lUs8XWU9ixiBYYv/QaI=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-Id: List-Archive:List-Help:List-Owner:List-Post:List-Subscribe: List-Unsubscribe:From; b=uLiQBeA+Xuc5bLqtNGUjtfP79WSVrD4WGAUL6J3IA5L/QYinzPiJ4nsv/4soS9PiP haC07HejA+uWQ5E6j9jsUJDF2mK6wc+NnFR60X2f4fy0UsqzyUU4g66xEbIJAHBKrZ hH7KpLtYC6e4bWPaUZrT1Rd4IBh5qEvJjw6g78HQ= Received: by alsa1.perex.cz (Postfix, from userid 50401) id C9F70F80640; Fri, 2 Aug 2024 14:46:41 +0200 (CEST) Received: from mailman-core.alsa-project.org (mailman-core.alsa-project.org [10.254.200.10]) by alsa1.perex.cz (Postfix) with ESMTP id 8BED9F80448; Fri, 2 Aug 2024 14:46:41 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 8704AF80607; Fri, 2 Aug 2024 14:46:35 +0200 (CEST) Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 21576F805F3 for ; Fri, 2 Aug 2024 14:46:32 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 21576F805F3 Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key, unprotected) header.d=intel.com header.i=@intel.com header.a=rsa-sha256 header.s=Intel header.b=gC+uhE/r DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1722602794; x=1754138794; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=z+Sp/e05K5Vs3Docgs64RMH7lUs8XWU9ixiBYYv/QaI=; b=gC+uhE/rpSsKT4OaZ6vW3/pWjxDfQqkaq8gRays5u2giW1Fae6kHNyL0 VhcoIe66RDFoPpxS0Tt5OG1P8K4zURJl2eynte+Ly0hAuo0dNa80zX87A ttMqlLfwxZwJn35U+EcKhuQIhwZKR28LtzsL1J96Vdf6QJmsPvuu/OI0e PR3qVXN/HZyVjg1M49FxIEqYlXsaflxQQmpStRlJhp+uLgLPOgY8u1AHK OnZtQr+SOyLx0C3HTPur8HZL+P3mDFoeUyTp+AcntgmXutrmKwacIYdFw 1f0kmmvTcS7je7vp0IuiKYZvMQIYrsPR4hCkxhgcJXXumRmL4BeXcsX4o A==; X-CSE-ConnectionGUID: cxdH+QjGRdmEiqBp4KZbRw== X-CSE-MsgGUID: 7LoT/bT4TnuKMK7umtrVxA== X-IronPort-AV: E=McAfee;i="6700,10204,11152"; a="20199394" X-IronPort-AV: E=Sophos;i="6.09,257,1716274800"; d="scan'208";a="20199394" Received: from orviesa004.jf.intel.com ([10.64.159.144]) by fmvoesa112.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Aug 2024 05:46:32 -0700 X-CSE-ConnectionGUID: pZCeloacRgK9OLuASgvsNg== X-CSE-MsgGUID: XTmyxUFeRwGIlTlhgtT5BQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.09,257,1716274800"; d="scan'208";a="60407902" Received: from ltuz-desk.ger.corp.intel.com (HELO pbossart-mobl6.intel.com) ([10.245.246.89]) by orviesa004-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Aug 2024 05:46:29 -0700 From: Pierre-Louis Bossart To: linux-sound@vger.kernel.org Cc: alsa-devel@alsa-project.org, tiwai@suse.de, broonie@kernel.org, Pierre-Louis Bossart , Ranjani Sridharan , =?utf-8?q?P=C3=A9ter?= =?utf-8?q?_Ujfalusi?= Subject: [PATCH 4/4] ASoC: SOF: sof-audio.h: optimize snd_sof_pcm_stream_pipeline_list Date: Fri, 2 Aug 2024 14:46:09 +0200 Message-ID: <20240802124609.188954-5-pierre-louis.bossart@linux.intel.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240802124609.188954-1-pierre-louis.bossart@linux.intel.com> References: <20240802124609.188954-1-pierre-louis.bossart@linux.intel.com> MIME-Version: 1.0 Message-ID-Hash: KFMDH6DRQQTGFZIZWRKSSR4LA46OMW2J X-Message-ID-Hash: KFMDH6DRQQTGFZIZWRKSSR4LA46OMW2J X-MailFrom: pierre-louis.bossart@linux.intel.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-alsa-devel.alsa-project.org-0; header-match-alsa-devel.alsa-project.org-1; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.9 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Invert members to remove hole. Signed-off-by: Pierre-Louis Bossart Reviewed-by: Ranjani Sridharan Reviewed-by: Péter Ujfalusi --- sound/soc/sof/sof-audio.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/sound/soc/sof/sof-audio.h b/sound/soc/sof/sof-audio.h index 49be02234fc3..b9b8b64768b9 100644 --- a/sound/soc/sof/sof-audio.h +++ b/sound/soc/sof/sof-audio.h @@ -314,12 +314,12 @@ struct sof_token_info { /** * struct snd_sof_pcm_stream_pipeline_list - List of pipelines associated with a PCM stream - * @count: number of pipeline widgets in the @pipe_widgets array * @pipelines: array of pipelines + * @count: number of pipeline widgets in the @pipe_widgets array */ struct snd_sof_pcm_stream_pipeline_list { - u32 count; struct snd_sof_pipeline **pipelines; + u32 count; }; /* PCM stream, mapped to FW component */