From patchwork Wed Nov 6 13:28:21 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Amit Kucheria X-Patchwork-Id: 178700 Delivered-To: patch@linaro.org Received: by 2002:a92:38d5:0:0:0:0:0 with SMTP id g82csp608222ilf; Wed, 6 Nov 2019 05:29:00 -0800 (PST) X-Google-Smtp-Source: APXvYqx6Hf5oJhbVE8Px+j3W2XU9N6O4q/holPzrO5DvaPMnVPWaBigGXjyvUwX4nkm5P9dNmeZ3 X-Received: by 2002:a50:ed12:: with SMTP id j18mr2711891eds.172.1573046940857; Wed, 06 Nov 2019 05:29:00 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1573046940; cv=none; d=google.com; s=arc-20160816; b=ew/j5qQlrfix95embu6Ilgo3rpGzS4fIFRpxOdOTd28MHe0PN3zLTW6xxRgBwTxeUh KzhCvfo0sN0zRQfoCHeMhuG6cGA9Wi7GAld+Anv74VwrA5Qodl636lmRC1sNqY3XwyWi Aba/uE7zvV5I3ObbwOIo355cOKxVnChSbeOmZQX4OKWGKDMGXAiTfbKBwKBt0QbPC8Gd nalo5tG3B0xIn2bKZSkUKA6matxKiwhUHYgylBkNXNDGy58Xy6nnA8h8mowDoyyT4+NK 1lMZgJiQ8IK12R9Yjb3Tks/UTkbw07+4hLNn2OrfvZSl0hvR/upPe4tdPtyvRx5zlnkR tPJg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:references :in-reply-to:message-id:date:subject:cc:to:from:dkim-signature; bh=SZaR5E/HobZwk+pxemYk2DTTfx/38H5VTmSiCwvG6UI=; b=HRLTs4IfFqB2hF92EHCU68+yFUBRbYhAWBTfDUQ+KAwaQDZ9/fMG+CMRVZSCGOzp6H 9cEnTk2Ez/+iOKhRoGxnNrEPe86/Lu6snVUOAVpEowcTe2uU7InYVT81DUUdJh9l/zSR imuTPMJ8fy26kA3SkzPS+lBixw/nGAi6oaqoMI0iqTmu9W5sYcZqm37ZpF5AQfUgVECo H6EiZ8xMvpV+CbVvgrcP1UrUCJ98ytIaFqZZGN5Usx5MC9WTFzM+JS9TgHACKXDFdv7I +7LdxRGSwIwr8PORPpqOHZALHJ6RQsvWCva2rGD0y5sD2K4rdcUj/ah/ei4EqhF9F3MJ Tvmg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=Rye+OiPH; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id h5si3394467ejq.374.2019.11.06.05.29.00; Wed, 06 Nov 2019 05:29:00 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=Rye+OiPH; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731821AbfKFN25 (ORCPT + 26 others); Wed, 6 Nov 2019 08:28:57 -0500 Received: from mail-pg1-f193.google.com ([209.85.215.193]:46683 "EHLO mail-pg1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731803AbfKFN24 (ORCPT ); Wed, 6 Nov 2019 08:28:56 -0500 Received: by mail-pg1-f193.google.com with SMTP id r18so1431941pgu.13 for ; Wed, 06 Nov 2019 05:28:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :in-reply-to:references; bh=SZaR5E/HobZwk+pxemYk2DTTfx/38H5VTmSiCwvG6UI=; b=Rye+OiPHXXnz8fja5i/j36mcB3yxJE200yCycPPv/3yhaPayJX6hhLERUxiLv6twmY bRZnfcm4BeOTxHrM0T1dh3bxydk+eryZkBBgfWPuhK4aG8QNxLF6odpN7Wv1ozcxHS2x EM+oMzZPi0TW1kj26d5Iwt0mWXAnHYzU9F9GgDWX6XrGEKxwV/a9nINLctgxZUw829Ce 5eieb5zsF3ES/aNP6VvbfBpz154Dgd0kNNgpiKwizk8XAsV3wn1HEe7DSpP35Kc42TNG oye9OOHONa1HKV27klLS7W3cknlg94qFuKEXx7Mg6rY9yOx4mh6LEsdZEnrGTkQubm+j RwYg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:in-reply-to:references; bh=SZaR5E/HobZwk+pxemYk2DTTfx/38H5VTmSiCwvG6UI=; b=Dx4V0g/g0NSMxtdhkAAm5zKFOPbK3PmFzlPrYSCPoTU0/SG+h/OzzwxTKOJU7Ge2FL WqfDwR7zYZXecxEW9pbWyHniEy+4MEuQfbw9SZp7KxFwvzjal6qe6KDt4Wm8yjGkrkt4 C6vBCdWorvVMtOODJb6DtgVMzBZh0TpT6eiFSCdcCpWsit065yGMjK0xZCogLyHghCEu fJS1PFvR7SjKc0e38O+5SkQ/ynl4RDKyIE7TpVRuBT35utLhyYfbdcvBS+AVpuy8pnla vSYGRQgRKscUsLRoaYN6hTBbKs/sazxK3RONn4oubIjXlxVexIRVYJm2lVKnGYZEKAqV 816g== X-Gm-Message-State: APjAAAWU3DLRxr83Z9d9qNH+BhwnHI3eZQZS7iTuwDq7VTHVZIPe5271 rY8WGMj28vKC2dKAXkr/ZY3/Vd3NEQfdZg== X-Received: by 2002:aa7:86c2:: with SMTP id h2mr3321962pfo.248.1573046935453; Wed, 06 Nov 2019 05:28:55 -0800 (PST) Received: from localhost ([49.248.202.230]) by smtp.gmail.com with ESMTPSA id a33sm23504468pgb.57.2019.11.06.05.28.54 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 06 Nov 2019 05:28:54 -0800 (PST) From: Amit Kucheria To: linux-kernel@vger.kernel.org, edubezval@gmail.com, Amit Daniel Kachhap , Amit Kucheria , Bartlomiej Zolnierkiewicz , Daniel Lezcano , Guillaume La Roque , Heiko Stuebner , Javi Merino , Jonathan Hunter , Jun Nie , Krzysztof Kozlowski , Kukjin Kim , Matthias Brugger , Shawn Guo , Thierry Reding , Viresh Kumar , Zhang Rui Cc: linux-pm@vger.kernel.org Subject: [PATCH 05/11] thermal: max77620: Appease the kernel-doc deity Date: Wed, 6 Nov 2019 18:58:21 +0530 Message-Id: <09609109359054d2a1f7e0456402ebabad1e315f.1573046440.git.amit.kucheria@linaro.org> X-Mailer: git-send-email 2.17.1 In-Reply-To: References: In-Reply-To: References: Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Fix up the following warning when compiled with make W=1: linux.git/drivers/thermal/max77620_thermal.c:48: warning: Function parameter or member 'temp' not described in 'max77620_thermal_read_temp' Signed-off-by: Amit Kucheria --- drivers/thermal/max77620_thermal.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.17.1 Reviewed-by: Viresh Kumar diff --git a/drivers/thermal/max77620_thermal.c b/drivers/thermal/max77620_thermal.c index 88fd0fbe0cfac..82d06c7411eb3 100644 --- a/drivers/thermal/max77620_thermal.c +++ b/drivers/thermal/max77620_thermal.c @@ -33,7 +33,7 @@ struct max77620_therm_info { /** * max77620_thermal_read_temp: Read PMIC die temperatue. * @data: Device specific data. - * temp: Temperature in millidegrees Celsius + * @temp: Temperature in millidegrees Celsius * * The actual temperature of PMIC die is not available from PMIC. * PMIC only tells the status if it has crossed or not the threshold level From patchwork Wed Nov 6 13:28:23 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Amit Kucheria X-Patchwork-Id: 178702 Delivered-To: patch@linaro.org Received: by 2002:a92:38d5:0:0:0:0:0 with SMTP id g82csp608366ilf; Wed, 6 Nov 2019 05:29:07 -0800 (PST) X-Google-Smtp-Source: APXvYqwtvzch5/CQlqdKCzM/Eu2lHfhi9JFyckZj2ylKb/AY9KfmGrMUT0bgezsIyysCHrM00abU X-Received: by 2002:a17:906:300a:: with SMTP id 10mr34795371ejz.104.1573046947660; Wed, 06 Nov 2019 05:29:07 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1573046947; cv=none; d=google.com; s=arc-20160816; b=Ka/66xRm6wPCmUCtymEl1E9pU5dOA+y+0uGqjyN8l7ZyhYP7wCLwC3KMEwv8tNWemx zcglH/w0xmVcd+zKrGkzd7VUie+wnD5Rc/B04/U9Q6v4Mgx0/C4p2pZGDgayfgzIPju2 rl0BGgVc0JUo5eqpp4U27+0HKniO58aURQHTUNgT2TtiCTHZIugAJOjsuq4RIoYvxIO5 L5G01TwdR1tGy6U2XpzlA6I/rRR/N2dC18dn/6yT/hU/ln2t2C4ZttmQY4GsQkkIlLsE elaeAqihmyJ4YyySJPpg42iDupYEEkyGmopofKvIc5NYnqNRb95Rh0/4pRZPcQ7yz81u Y5Fg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:references :in-reply-to:message-id:date:subject:cc:to:from:dkim-signature; bh=Rxuz5AKRhYwDEc2ju4DSL4K4+pPb8Uk4j39gu0W8ZCQ=; b=Q9CILYNlA398J8q3/Cqz31EqSED4FFq045uH0dZCA++5LFL4tsE/+39jVATANSTciE 7c+7jWOaoziaWsiTNP7JXTebwU//KxFVLPZu5fx+PkdrCzYPNZ+RO7c0JCzQC4ziUjzj nBeA8hykVakutlb8ZHuYzK3C60FgiFAxYB2zinvxAuzr/NvLuGJJ/7eMD3p5xTkiG7jM PjrqHdbxy31KftIdtXpqK7e3Yl+S8RersKZob9OXOKGzL2K+1/HALChq1YMHWUfUBwJs ny4WEn7EXCDEwO63RsfFglCfijEaz3lc2/XWBnsTDRvMSrTsdbgdInYqEE85HDFzUXrH OQ3A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=EEInOP7D; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id u11si13801342edi.385.2019.11.06.05.29.07; Wed, 06 Nov 2019 05:29:07 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=EEInOP7D; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731860AbfKFN3G (ORCPT + 26 others); Wed, 6 Nov 2019 08:29:06 -0500 Received: from mail-pg1-f193.google.com ([209.85.215.193]:39652 "EHLO mail-pg1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731826AbfKFN3E (ORCPT ); Wed, 6 Nov 2019 08:29:04 -0500 Received: by mail-pg1-f193.google.com with SMTP id 29so5829949pgm.6 for ; Wed, 06 Nov 2019 05:29:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :in-reply-to:references; bh=Rxuz5AKRhYwDEc2ju4DSL4K4+pPb8Uk4j39gu0W8ZCQ=; b=EEInOP7DB8lbrJuWagzB9tYaHP/rrHOL2bKvo3JM0gyhWrT02CnUe9hqCCpm9PcO8j gMqiSIawVDAZ9mrcDA7xtuPbw8DnA9wWCxCIN03EONVvvd5nLDPAIWmTK2INLgKQuQCx r6Cad7CUa3txk8jRPoX6WL2fRVXxszPE6VbNZZyVPcayMLaYC1hAhJCMMz4iHZRF7ait 66JHaWPmgAmyRGvaszkezzMGCCxKaBMwhpPm4DIP6mOB3GfVoH4vigDdZdfNMhuObvv+ tosGonmI/ET9XLrsIZUy9SQ/G5jAVgOWFvlk9QFQA7r9xN/NIhsoA4jYgcd7AanNv73u U9IQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:in-reply-to:references; bh=Rxuz5AKRhYwDEc2ju4DSL4K4+pPb8Uk4j39gu0W8ZCQ=; b=BREhtdcjJicDFHg4IXaz0IhvssRl7hIaSNRbdgMYdYHPdtUWBvqGHXPTL610QI72g5 zECZwWqR5+AdiCFampFojGV6KGYtWp8jZfzzarCdCOwbRfbHNQDENF0lvvoJ7Ksifh7N Kwnhuclc9siq5d2NuQd7GKXkQxlKrFWXtT4V8766t/bLX29r43Zt5TYi8T8sOGX1WAH3 3JXXOr/ckzEMpxj5XDTWqRiMFAFTQLE0rtoEJatQ1ztNhdsAr7tETdUp7I8kmLLzOs23 dVyX6udcoz+HDRn7cG5szUfZOuuMwhNBitpTptcJEZhO1goyY1BrfSBlndxxqKXiJYQK w2Gg== X-Gm-Message-State: APjAAAXrEuVnWK674OAK4FySkZbHZ+ilrFTjvFgL0b6ws4sCl1OXKGUS XlLP/tYSwSWXI+i2/8fkgZSFtSl3hrqMgg== X-Received: by 2002:a17:90b:24c:: with SMTP id fz12mr3761393pjb.51.1573046943798; Wed, 06 Nov 2019 05:29:03 -0800 (PST) Received: from localhost ([49.248.202.230]) by smtp.gmail.com with ESMTPSA id hi2sm2412031pjb.22.2019.11.06.05.29.02 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 06 Nov 2019 05:29:03 -0800 (PST) From: Amit Kucheria To: linux-kernel@vger.kernel.org, edubezval@gmail.com, Amit Daniel Kachhap , Amit Kucheria , Bartlomiej Zolnierkiewicz , Daniel Lezcano , Guillaume La Roque , Heiko Stuebner , Javi Merino , Jonathan Hunter , Jun Nie , Krzysztof Kozlowski , Kukjin Kim , Matthias Brugger , Shawn Guo , Thierry Reding , Viresh Kumar , Zhang Rui Cc: linux-pm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org Subject: [PATCH 07/11] thermal: rockchip: Appease the kernel-doc deity Date: Wed, 6 Nov 2019 18:58:23 +0530 Message-Id: <290895a22aa8a13c13b3a4ae77c13244b4ecee58.1573046440.git.amit.kucheria@linaro.org> X-Mailer: git-send-email 2.17.1 In-Reply-To: References: In-Reply-To: References: Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Replace a comment starting with /** by simply /* to avoid having it interpreted as a kernel-doc comment. Describe missing function parameters where needed. Fixes up the following warnings when compiled with make W=1: linux.git/drivers/thermal/rockchip_thermal.c:27: warning: cannot understand function prototype: 'enum tshut_mode ' linux.git/drivers/thermal/rockchip_thermal.c:37: warning: cannot understand function prototype: 'enum tshut_polarity ' linux.git/drivers/thermal/rockchip_thermal.c:46: warning: cannot understand function prototype: 'enum sensor_id ' linux.git/drivers/thermal/rockchip_thermal.c:56: warning: cannot understand function prototype: 'enum adc_sort_mode ' linux.git/drivers/thermal/rockchip_thermal.c:123: warning: Function parameter or member 'chn_id' not described in 'rockchip_tsadc_chip' linux.git/drivers/thermal/rockchip_thermal.c:123: warning: Function parameter or member 'control' not described in 'rockchip_tsadc_chip' linux.git/drivers/thermal/rockchip_thermal.c:167: warning: Function parameter or member 'sensors' not described in 'rockchip_thermal_data' linux.git/drivers/thermal/rockchip_thermal.c:608: warning: Function parameter or member 'grf' not described in 'rk_tsadcv2_initialize' linux.git/drivers/thermal/rockchip_thermal.c:608: warning: Function parameter or member 'regs' not described in 'rk_tsadcv2_initialize' linux.git/drivers/thermal/rockchip_thermal.c:608: warning: Function parameter or member 'tshut_polarity' not described in 'rk_tsadcv2_initialize' linux.git/drivers/thermal/rockchip_thermal.c:644: warning: Function parameter or member 'grf' not described in 'rk_tsadcv3_initialize' linux.git/drivers/thermal/rockchip_thermal.c:644: warning: Function parameter or member 'regs' not described in 'rk_tsadcv3_initialize' linux.git/drivers/thermal/rockchip_thermal.c:644: warning: Function parameter or member 'tshut_polarity' not described in 'rk_tsadcv3_initialize' linux.git/drivers/thermal/rockchip_thermal.c:732: warning: Function parameter or member 'regs' not described in 'rk_tsadcv3_control' linux.git/drivers/thermal/rockchip_thermal.c:732: warning: Function parameter or member 'enable' not described in 'rk_tsadcv3_control' linux.git/drivers/thermal/rockchip_thermal.c:1211: warning: Function parameter or member 'reset' not described in 'rockchip_thermal_reset_controller' Signed-off-by: Amit Kucheria --- drivers/thermal/rockchip_thermal.c | 22 ++++++++++++++++------ 1 file changed, 16 insertions(+), 6 deletions(-) -- 2.17.1 diff --git a/drivers/thermal/rockchip_thermal.c b/drivers/thermal/rockchip_thermal.c index 343c2f5c5a259..9ed8085bb7924 100644 --- a/drivers/thermal/rockchip_thermal.c +++ b/drivers/thermal/rockchip_thermal.c @@ -19,7 +19,7 @@ #include #include -/** +/* * If the temperature over a period of time High, * the resulting TSHUT gave CRU module,let it reset the entire chip, * or via GPIO give PMIC. @@ -29,7 +29,7 @@ enum tshut_mode { TSHUT_MODE_GPIO, }; -/** +/* * The system Temperature Sensors tshut(tshut) polarity * the bit 8 is tshut polarity. * 0: low active, 1: high active @@ -39,7 +39,7 @@ enum tshut_polarity { TSHUT_HIGH_ACTIVE, }; -/** +/* * The system has two Temperature Sensors. * sensor0 is for CPU, and sensor1 is for GPU. */ @@ -48,7 +48,7 @@ enum sensor_id { SENSOR_GPU, }; -/** +/* * The conversion table has the adc value and temperature. * ADC_DECREMENT: the adc value is of diminishing.(e.g. rk3288_code_table) * ADC_INCREMENT: the adc value is incremental.(e.g. rk3368_code_table) @@ -80,13 +80,14 @@ struct chip_tsadc_table { /** * struct rockchip_tsadc_chip - hold the private data of tsadc chip - * @chn_id[SOC_MAX_SENSORS]: the sensor id of chip correspond to the channel + * @chn_id: array of sensor ids of chip corresponding to the channel * @chn_num: the channel number of tsadc chip * @tshut_temp: the hardware-controlled shutdown temperature value * @tshut_mode: the hardware-controlled shutdown mode (0:CRU 1:GPIO) * @tshut_polarity: the hardware-controlled active polarity (0:LOW 1:HIGH) * @initialize: SoC special initialize tsadc controller method * @irq_ack: clear the interrupt + * @control: enable/disable method for the tsadc controller * @get_temp: get the temperature * @set_alarm_temp: set the high temperature interrupt * @set_tshut_temp: set the hardware-controlled shutdown temperature @@ -139,7 +140,7 @@ struct rockchip_thermal_sensor { * @chip: pointer to the platform/configuration data * @pdev: platform device of thermal * @reset: the reset controller of tsadc - * @sensors[SOC_MAX_SENSORS]: the thermal sensor + * @sensors: array of thermal sensors * @clk: the controller clock is divided by the exteral 24MHz * @pclk: the advanced peripherals bus clock * @grf: the general register file will be used to do static set by software @@ -590,6 +591,9 @@ static int rk_tsadcv2_code_to_temp(const struct chip_tsadc_table *table, /** * rk_tsadcv2_initialize - initialize TASDC Controller. + * @grf: the general register file will be used to do static set by software + * @regs: the base address of tsadc controller + * @tshut_polarity: the hardware-controlled active polarity (0:LOW 1:HIGH) * * (1) Set TSADC_V2_AUTO_PERIOD: * Configure the interleave between every two accessing of @@ -624,6 +628,9 @@ static void rk_tsadcv2_initialize(struct regmap *grf, void __iomem *regs, /** * rk_tsadcv3_initialize - initialize TASDC Controller. + * @grf: the general register file will be used to do static set by software + * @regs: the base address of tsadc controller + * @tshut_polarity: the hardware-controlled active polarity (0:LOW 1:HIGH) * * (1) The tsadc control power sequence. * @@ -723,6 +730,8 @@ static void rk_tsadcv2_control(void __iomem *regs, bool enable) /** * rk_tsadcv3_control - the tsadc controller is enabled or disabled. + * @regs: the base address of tsadc controller + * @enable: boolean flag to enable the controller * * NOTE: TSADC controller works at auto mode, and some SoCs need set the * tsadc_q_sel bit on TSADCV2_AUTO_CON[1]. The (1024 - tsadc_q) as output @@ -1206,6 +1215,7 @@ rockchip_thermal_register_sensor(struct platform_device *pdev, /** * Reset TSADC Controller, reset all tsadc registers. + * @reset: the reset controller of tsadc */ static void rockchip_thermal_reset_controller(struct reset_control *reset) { From patchwork Wed Nov 6 13:28:24 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Amit Kucheria X-Patchwork-Id: 178703 Delivered-To: patch@linaro.org Received: by 2002:a92:38d5:0:0:0:0:0 with SMTP id g82csp608531ilf; Wed, 6 Nov 2019 05:29:14 -0800 (PST) X-Google-Smtp-Source: APXvYqx4sPmlzjsjtGxwaT6Bo83gcrFnIBje9hGvJ2qiSgk9ZSY1qXQ/iV8uutlsdzKgf6VcjuTZ X-Received: by 2002:aa7:d54e:: with SMTP id u14mr2621528edr.49.1573046954585; Wed, 06 Nov 2019 05:29:14 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1573046954; cv=none; d=google.com; s=arc-20160816; b=XQff0CYw7wSm+wRMr8Gjlad7wE75kqLJSh3lebJQO/79BvRsIX8mfH/iiRa7qEpYfQ /mLLQtHVr06zfukA2QIVymomUc7tVFGnXeVYfCF02KUZW17vTpRGyYVNyk3nywjS8kZm N53p7RVB03OLNKZnDkk+USvrD7BiLgBhZAHQfjiHMAp1fPOULK8Q4JiIQEcbEGpBVFLV qAQfVF4/w7e5PJ2dyNGDyWAo48IIxQrLAV5kCw0Hu6S6WggIJtsYdeBv1/TNI0RNaI42 cJ13Nb4lLBayXjYjc/rXoITmdiOk+rE/M0LfRVjXY/ESsTDjzjDjJu7pbhan7xJg6HLA G3zg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:references :in-reply-to:message-id:date:subject:cc:to:from:dkim-signature; bh=2xqYXv9mzaQHwdDh6j/4ycM4TkgLqd6VvlhGxQOhNwg=; b=qNk1fbYJKeXKZvPnoAifhCbFd1GgE5B8Zs4Bw/OLUqQQFMtTfBG6pjF0E/rLgGra3U 5Dlo8p+gyX7oEfvMrWjl+j9PW+mwAquBzyJEgo7Vryf05Xoqevuyw8YrECZ9ciuNHCAJ Xi6B3V0iIS/oA1d1yCXbDau8vfb1BXpaLAYERlkmi//ml7TZPxiWtn1Bn2ad465L50RF b1tTy+mXvb3p8iLakT+X5kmVLWpx8+/Vb62riJvPgX2JyfW/m37LIoRx1u7KDJ6Jw6tN cIZco5nbeNGlotAnxtpKBebgXHToTohYk23ly4iqoZHbyZsGCpD8t/Ghf3G+gqmi0rwX PpPw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=za0v+vrO; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id l64si13895175edl.306.2019.11.06.05.29.14; Wed, 06 Nov 2019 05:29:14 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=za0v+vrO; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731875AbfKFN3L (ORCPT + 26 others); Wed, 6 Nov 2019 08:29:11 -0500 Received: from mail-pl1-f195.google.com ([209.85.214.195]:42390 "EHLO mail-pl1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726845AbfKFN3I (ORCPT ); Wed, 6 Nov 2019 08:29:08 -0500 Received: by mail-pl1-f195.google.com with SMTP id j12so9478299plt.9 for ; Wed, 06 Nov 2019 05:29:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :in-reply-to:references; bh=2xqYXv9mzaQHwdDh6j/4ycM4TkgLqd6VvlhGxQOhNwg=; b=za0v+vrOAYFsK6XXgXtbLMXEk/0Jo14oKAfvmttgjG9v8GTN3APeKjjkysHBIo/MaD yu1fZQ8H+NAJ/MF1Jb65S7HsNdTp52aIe2OqV7nU/fr3/e2KDfBJa5HMfkeSVHMiPaWW pjJ7GrAUvONFXEc2cWBBFXzetevUlhXpioV7h5PS917zag1508jFEetnjK0914bqqzdY z6myjrjljlOZOD3qORGAP0lciZJSobhzFPoJYYF8KE3t7m1+Vd6KhBJI37QGCM7tU7m3 xlR68RTUxYR9NhAjBoSmKY60c6bglrGlJ6+UZkW0SU5UkzgR2LFnaqY85S8gIQnGTaEs 7vDg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:in-reply-to:references; bh=2xqYXv9mzaQHwdDh6j/4ycM4TkgLqd6VvlhGxQOhNwg=; b=YOtZ93TWem9lkZlHScy1l/lB1bczfhbJ3pLxPbIbD090cW3oZLWeUUcj6qCrY+aQL1 FSrgg245SmTkdQSoXJ4C3vDHIgQnLo4Stv+zRz7j1jp2m8KdPHEotihLGBIC9JvqgMVT t++/w5N5bSHwntuAuCmLlwWZXdwGnxmPpwcVHVfvhSE40iHMg7rFg6Do4G5F/JJZnwXK WCIsNSiSQyNOZOw9idR5FKBN3xzul7biXuuA+w56QkaY6dt6GpCJaeJZKhIV7VpeHyTH BIpPpcFPjQZOk67q3QyW/F3hCNmc1qz0jHjAm2+FZJ7Qrg0OWZm+rOVV3iXsusqpveE8 MDbQ== X-Gm-Message-State: APjAAAUtD6M2Pdux2GZ/JdWFGekr9QBDUhLQ4AABWl8z+RJQTEk2aI2u uPFBHqPAMtfOa5eJaVXgucAaLCi0Ryr+ww== X-Received: by 2002:a17:902:8309:: with SMTP id bd9mr1678528plb.153.1573046947813; Wed, 06 Nov 2019 05:29:07 -0800 (PST) Received: from localhost ([49.248.202.230]) by smtp.gmail.com with ESMTPSA id g7sm23243544pgr.52.2019.11.06.05.29.06 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 06 Nov 2019 05:29:07 -0800 (PST) From: Amit Kucheria To: linux-kernel@vger.kernel.org, edubezval@gmail.com, Amit Daniel Kachhap , Amit Kucheria , Bartlomiej Zolnierkiewicz , Daniel Lezcano , Guillaume La Roque , Heiko Stuebner , Javi Merino , Jonathan Hunter , Jun Nie , Krzysztof Kozlowski , Kukjin Kim , Matthias Brugger , Shawn Guo , Thierry Reding , Viresh Kumar , Zhang Rui Cc: linux-pm@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: [PATCH 08/11] thermal: samsung: Appease the kernel-doc deity Date: Wed, 6 Nov 2019 18:58:24 +0530 Message-Id: X-Mailer: git-send-email 2.17.1 In-Reply-To: References: In-Reply-To: References: Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Fix up the following warning when compiled with make W=1: linux.git/drivers/thermal/mtk_thermal.c:374: warning: cannot understand function prototype: 'const struct mtk_thermal_data mt8173_thermal_data = ' linux.git/drivers/thermal/mtk_thermal.c:413: warning: cannot understand function prototype: 'const struct mtk_thermal_data mt2701_thermal_data = ' linux.git/drivers/thermal/mtk_thermal.c:443: warning: cannot understand function prototype: 'const struct mtk_thermal_data mt2712_thermal_data = ' linux.git/drivers/thermal/mtk_thermal.c:499: warning: cannot understand function prototype: 'const struct mtk_thermal_data mt8183_thermal_data = ' linux.git/drivers/thermal/mtk_thermal.c:529: warning: Function parameter or member 'sensno' not described in 'raw_to_mcelsius' Signed-off-by: Amit Kucheria --- drivers/thermal/samsung/exynos_tmu.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) -- 2.17.1 diff --git a/drivers/thermal/samsung/exynos_tmu.c b/drivers/thermal/samsung/exynos_tmu.c index fb2c55123a99e..8193b66a3f831 100644 --- a/drivers/thermal/samsung/exynos_tmu.c +++ b/drivers/thermal/samsung/exynos_tmu.c @@ -138,7 +138,7 @@ enum soc_type { /** * struct exynos_tmu_data : A structure to hold the private data of the TMU - driver + * driver * @id: identifier of the one instance of the TMU controller. * @base: base address of the single instance of the TMU controller. * @base_second: base address of the common registers of the TMU controller. @@ -162,8 +162,11 @@ enum soc_type { * 0 < reference_voltage <= 31 * @regulator: pointer to the TMU regulator structure. * @reg_conf: pointer to structure to register with core thermal. + * @tzd: pointer to thermal_zone_device structure * @ntrip: number of supported trip points. * @enabled: current status of TMU device + * @tmu_set_trip_temp: SoC specific method to set trip (rising threshold) + * @tmu_set_trip_hyst: SoC specific to set hysteresis (falling threshold) * @tmu_initialize: SoC specific TMU initialization method * @tmu_control: SoC specific TMU control method * @tmu_read: SoC specific TMU temperature read method From patchwork Wed Nov 6 13:28:25 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Amit Kucheria X-Patchwork-Id: 178704 Delivered-To: patch@linaro.org Received: by 2002:a92:38d5:0:0:0:0:0 with SMTP id g82csp608607ilf; Wed, 6 Nov 2019 05:29:18 -0800 (PST) X-Google-Smtp-Source: APXvYqxYUsWIFvKhHAA9fjBL4OeTjmkcVWqmusnjr0vu/5MG6jGykZBTwExcr53l0xa3cFPkISFC X-Received: by 2002:a50:8859:: with SMTP id c25mr2591319edc.253.1573046958670; Wed, 06 Nov 2019 05:29:18 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1573046958; cv=none; d=google.com; s=arc-20160816; b=fkLwhFeaYVB1Th2xIK8czHJx9TCeh+pas9v7mY8YaP+nK5xKNfhHj27Jml0yg2jf56 MgjvtYUE4GRk4PGDwToNiXxRt0p9M/86uYlGOY4sMA81jB58ZOf9XyYwUZsQCwMgnU1O adoShvGhkWdog9JYCB6Pj4yyaRR5V68F50IDiT8LiMbR1nLK1tlmZkuVxCPROMXsPttB 2ATobmoMx98yQxaeFkxr0L0ijG4f1ufO8t9KU3gxU92RDdsEurcc8PivtYbLGN1IoOh5 bvN8qIXrLuPl2jkdnwH7IN7TyFLmMUnIuNa3yDb/NzN7aGW7I5ESyOPRAjJh39p+xjTT BJwQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:references :in-reply-to:message-id:date:subject:cc:to:from:dkim-signature; bh=7255+C81bgkCi8NGM8c0LBC3vCxrIbGTPf3ioqLcyWY=; b=DPBdAG5n5INkJ9OlfjdhNBGLDDTXfVdwXsYZ2DCDOCI7MrEylg3gifkX+8oe87EHwh exlMbXstfKvbSDJB5ssfMFixhNK8luobSEHPueY0rlscDTAGi1w1QpAT3AU+rvHhRZBp o7Sf0Yp+uffYEI3aOOL+OkC9TirlRpQQVOnpQPTiHi+gDGYU5coTq1j71dBvrORTT5Cj I4I36kxBTPyO6kdQe9E8pwIYN/elU+SuOY2YG4jaEJMBOtcKwI1eRPX0t6nEIwvgkjKU aBFtFY+ie33tfGYpW4NjecoUwCPRu8iMbRZ3Avb/ACNMAk+SFzi80iJC0YxoqjvTCpnt rWKw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=ddcOjiSe; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id z15si11498280edd.8.2019.11.06.05.29.18; Wed, 06 Nov 2019 05:29:18 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=ddcOjiSe; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731903AbfKFN3P (ORCPT + 26 others); Wed, 6 Nov 2019 08:29:15 -0500 Received: from mail-pl1-f196.google.com ([209.85.214.196]:37975 "EHLO mail-pl1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731886AbfKFN3M (ORCPT ); Wed, 6 Nov 2019 08:29:12 -0500 Received: by mail-pl1-f196.google.com with SMTP id w8so11424332plq.5 for ; Wed, 06 Nov 2019 05:29:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :in-reply-to:references; bh=7255+C81bgkCi8NGM8c0LBC3vCxrIbGTPf3ioqLcyWY=; b=ddcOjiSextgQgzgcfT/whbaOfy/nCfGeGuEGl2N4Ki0Atdupm/umvsICnXhHuZ6QLj QzlPsgnzZAGelJxDBlasD3SISnQudVbzb+ryGfqUla8rmjEwGfrkONCrDYJjzSZwjTvx VPA0r9ABhIY3CAcJNS+bzaA6YRsL2bA8v1BpF7JkjGr/vgXnIwTa3zBudYVkdNjE+DMn 27jMaw5vTbktUbz2qUA9wlQBsEnJunmiF4N5wSkOA+P7I7e8eGsEqYGe7ZkpbNBgpTSi +djdpFzIeFkzs3/6Mn5IethZC30s7HajAi9qTK1482fMaI92qN+OPBA554jkYSPgLPkO mH0Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:in-reply-to:references; bh=7255+C81bgkCi8NGM8c0LBC3vCxrIbGTPf3ioqLcyWY=; b=WT9Uou/DJh7SiuHcd0VSFw53pmB4PsN4cgvYPfO8m7Nu04ccqItccwk9UufCa50aSB WRKO3At742T7AhwxV+Q9fIhjomq6hpVstDf0meuTKgpm2k8/M5MJX/VqytVb/ncVNTjZ G+8A7F5GIu/mVmFgCo3szNSCd+n4WZNAwMKnGuB5CNO/7Wn8+X6FlFTKz2QjnryKLCrY bQ1UXwC9NamcZtubQ8Z2pcharbeHN1JtHq+A11eU6MjGMR3ChedGrVXw8+KmRudqtWm3 OzjXQMedUhRHY35OPIPSdzno3zgHma7+16FAXH7F482trJ7qMNkt6y98G5Q5opZRP0q8 cSbA== X-Gm-Message-State: APjAAAVERzICY1GhIZqUJOg2YPdKuj44MF2VrvQJZYbGiJ6t7P1FE7wY JiutRvWVCGJ+fOveyEMWpb6O9+Hr2VCLcQ== X-Received: by 2002:a17:902:7207:: with SMTP id ba7mr2659118plb.172.1573046951646; Wed, 06 Nov 2019 05:29:11 -0800 (PST) Received: from localhost ([49.248.202.230]) by smtp.gmail.com with ESMTPSA id l24sm22658774pff.151.2019.11.06.05.29.10 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 06 Nov 2019 05:29:11 -0800 (PST) From: Amit Kucheria To: linux-kernel@vger.kernel.org, edubezval@gmail.com, Amit Daniel Kachhap , Amit Kucheria , Bartlomiej Zolnierkiewicz , Daniel Lezcano , Guillaume La Roque , Heiko Stuebner , Javi Merino , Jonathan Hunter , Jun Nie , Krzysztof Kozlowski , Kukjin Kim , Matthias Brugger , Shawn Guo , Thierry Reding , Viresh Kumar , Zhang Rui Cc: linux-pm@vger.kernel.org, linux-tegra@vger.kernel.org Subject: [PATCH 09/11] thermal: tegra: Appease the kernel-doc deity Date: Wed, 6 Nov 2019 18:58:25 +0530 Message-Id: <4cba46c100cb504a52e52062bdf4e4a4e9427b99.1573046440.git.amit.kucheria@linaro.org> X-Mailer: git-send-email 2.17.1 In-Reply-To: References: In-Reply-To: References: Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Fix up the following warning when compiled with make W=1: linux.git/drivers/thermal/tegra/soctherm.c:369: warning: Function parameter or member 'value' not described in 'ccroc_writel' linux.git/drivers/thermal/tegra/soctherm.c:369: warning: Excess function parameter 'v' description in 'ccroc_writel' linux.git/drivers/thermal/tegra/soctherm.c:447: warning: Function parameter or member 'dev' not described in 'enforce_temp_range' linux.git/drivers/thermal/tegra/soctherm.c:772: warning: Function parameter or member 'sg' not described in 'tegra_soctherm_set_hwtrips' linux.git/drivers/thermal/tegra/soctherm.c:772: warning: Function parameter or member 'tz' not described in 'tegra_soctherm_set_hwtrips' linux.git/drivers/thermal/tegra/soctherm.c:944: warning: Function parameter or member 'ts' not described in 'soctherm_oc_intr_enable' linux.git/drivers/thermal/tegra/soctherm.c:1167: warning: Function parameter or member 'data' not described in 'soctherm_oc_irq_disable' linux.git/drivers/thermal/tegra/soctherm.c:1167: warning: Excess function parameter 'irq_data' description in 'soctherm_oc_irq_disable' linux.git/drivers/thermal/tegra/soctherm.c:1224: warning: Function parameter or member 'ctrlr' not described in 'soctherm_irq_domain_xlate_twocell' linux.git/drivers/thermal/tegra/soctherm.c:1686: warning: Function parameter or member 'pdev' not described in 'soctherm_init_hw_throt_cdev' linux.git/drivers/thermal/tegra/soctherm.c:1764: warning: Function parameter or member 'ts' not described in 'throttlectl_cpu_level_cfg' linux.git/drivers/thermal/tegra/soctherm.c:1812: warning: Function parameter or member 'ts' not described in 'throttlectl_cpu_level_select' linux.git/drivers/thermal/tegra/soctherm.c:1855: warning: Function parameter or member 'ts' not described in 'throttlectl_cpu_mn' linux.git/drivers/thermal/tegra/soctherm.c:1886: warning: Function parameter or member 'ts' not described in 'throttlectl_gpu_level_select' linux.git/drivers/thermal/tegra/soctherm.c:1928: warning: Function parameter or member 'ts' not described in 'soctherm_throttle_program' Signed-off-by: Amit Kucheria --- drivers/thermal/tegra/soctherm.c | 15 +++++++++++++-- 1 file changed, 13 insertions(+), 2 deletions(-) -- 2.17.1 Reviewed-by: Viresh Kumar diff --git a/drivers/thermal/tegra/soctherm.c b/drivers/thermal/tegra/soctherm.c index 5acaad3a594f3..66e0639da4bf2 100644 --- a/drivers/thermal/tegra/soctherm.c +++ b/drivers/thermal/tegra/soctherm.c @@ -360,7 +360,7 @@ static struct soctherm_oc_irq_chip_data soc_irq_cdata; /** * ccroc_writel() - writes a value to a CCROC register * @ts: pointer to a struct tegra_soctherm - * @v: the value to write + * @value: the value to write * @reg: the register offset * * Writes @v to @reg. No return value. @@ -435,6 +435,7 @@ static int tegra_thermctl_get_temp(void *data, int *out_temp) /** * enforce_temp_range() - check and enforce temperature range [min, max] + * @dev: struct device * of the SOC_THERM instance * @trip_temp: the trip temperature to check * * Checks and enforces the permitted temperature range that SOC_THERM @@ -747,6 +748,8 @@ static int get_hot_temp(struct thermal_zone_device *tz, int *trip, int *temp) /** * tegra_soctherm_set_hwtrips() - set HW trip point from DT data * @dev: struct device * of the SOC_THERM instance + * @sg: pointer to the sensor group to set the thermtrip temperature for + * @tz: struct thermal_zone_device * * * Configure the SOC_THERM HW trip points, setting "THERMTRIP" * "THROTTLE" trip points , using "thermtrips", "critical" or "hot" @@ -931,6 +934,7 @@ static irqreturn_t soctherm_thermal_isr_thread(int irq, void *dev_id) /** * soctherm_oc_intr_enable() - Enables the soctherm over-current interrupt + * @ts: pointer to a struct tegra_soctherm * @alarm: The soctherm throttle id * @enable: Flag indicating enable the soctherm over-current * interrupt or disable it @@ -1156,7 +1160,7 @@ static void soctherm_oc_irq_enable(struct irq_data *data) /** * soctherm_oc_irq_disable() - Disables overcurrent interrupt requests - * @irq_data: The interrupt request information + * @data: The interrupt request information * * Clears the interrupt request enable bit of the overcurrent * interrupt request chip data. @@ -1206,6 +1210,7 @@ static int soctherm_oc_irq_map(struct irq_domain *h, unsigned int virq, /** * soctherm_irq_domain_xlate_twocell() - xlate for soctherm interrupts * @d: Interrupt request domain + * @ctrlr: Controller device tree node * @intspec: Array of u32s from DTs "interrupt" property * @intsize: Number of values inside the intspec array * @out_hwirq: HW IRQ value associated with this interrupt @@ -1681,6 +1686,7 @@ static int soctherm_throt_cfg_parse(struct device *dev, /** * soctherm_init_hw_throt_cdev() - Parse the HW throttle configurations * and register them as cooling devices. + * @pdev: Pointer to platform_device struct */ static void soctherm_init_hw_throt_cdev(struct platform_device *pdev) { @@ -1751,6 +1757,7 @@ static void soctherm_init_hw_throt_cdev(struct platform_device *pdev) /** * throttlectl_cpu_level_cfg() - programs CCROC NV_THERM level config + * @ts: pointer to a struct tegra_soctherm * @level: describing the level LOW/MED/HIGH of throttling * * It's necessary to set up the CPU-local CCROC NV_THERM instance with @@ -1798,6 +1805,7 @@ static void throttlectl_cpu_level_cfg(struct tegra_soctherm *ts, int level) /** * throttlectl_cpu_level_select() - program CPU pulse skipper config + * @ts: pointer to a struct tegra_soctherm * @throt: the LIGHT/HEAVY of throttle event id * * Pulse skippers are used to throttle clock frequencies. This @@ -1841,6 +1849,7 @@ static void throttlectl_cpu_level_select(struct tegra_soctherm *ts, /** * throttlectl_cpu_mn() - program CPU pulse skipper configuration + * @ts: pointer to a struct tegra_soctherm * @throt: the LIGHT/HEAVY of throttle event id * * Pulse skippers are used to throttle clock frequencies. This @@ -1874,6 +1883,7 @@ static void throttlectl_cpu_mn(struct tegra_soctherm *ts, /** * throttlectl_gpu_level_select() - selects throttling level for GPU + * @ts: pointer to a struct tegra_soctherm * @throt: the LIGHT/HEAVY of throttle event id * * This function programs soctherm's interface to GK20a NV_THERM to select @@ -1918,6 +1928,7 @@ static int soctherm_oc_cfg_program(struct tegra_soctherm *ts, /** * soctherm_throttle_program() - programs pulse skippers' configuration + * @ts: pointer to a struct tegra_soctherm * @throt: the LIGHT/HEAVY of the throttle event id. * * Pulse skippers are used to throttle clock frequencies. From patchwork Wed Nov 6 13:28:27 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Amit Kucheria X-Patchwork-Id: 178706 Delivered-To: patch@linaro.org Received: by 2002:a92:38d5:0:0:0:0:0 with SMTP id g82csp608757ilf; Wed, 6 Nov 2019 05:29:25 -0800 (PST) X-Google-Smtp-Source: APXvYqxUmhyiYl8EJ7nSepak5VGF1mHmJ80kODpSC/ogvZr5kS4S+3cJ0bfAt2HhL+L8D9fFKyrS X-Received: by 2002:a17:906:5015:: with SMTP id s21mr33662668ejj.226.1573046965601; Wed, 06 Nov 2019 05:29:25 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1573046965; cv=none; d=google.com; s=arc-20160816; b=toylGYLSdiArU0Xa4nssCvpr2e1p+7QSnt33AbFUZrPYjWXOWhEnbIxivKegaNhtrK Jz+R4oq8xfUpGcoDViNnUQKQfQrsQHU+KNQ6OFUwTsF8P0E64uktB6Bt5tkW0vEoFT4s lRd5jjroOL/ESysqbwCsern8jBRPjrbIGpW7eBfFp+ffWWkQwzzuJvdU+Vp2zije5Pt0 Psp1ErB7t+EyyVY0qgZl9qXf6dBQmZCNsCOr6aCKJKqgm5jznrv2kYBe7KUxpSM0R/Qf d8yW+Lg0QHELKWBe6BDipFO5u8lYAguSKgEmTF5vGnTxX0Qe3Q5CN54dsafWRkPugs4y zhRw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:references :in-reply-to:message-id:date:subject:cc:to:from:dkim-signature; bh=ndl0P+VsTZD2v+P2v9bn/U9V2szmDcFpE9QaZn60GcY=; b=pLt/7MT1g+vN6H6ZWpt0k839cfwmxP4c+DrqL8/9Y5UHzDjo6qQ5b9MY1ziF7TXdj9 Z37pSy+tGII0XsfYcFF+0coY9TDAwTwFy7mEQrhnBg4S5oZxIAazdgiqRmK2LWZ5H/r1 1BieSAgbAnFMjA9NDkQ4HXkUWrxoI+9/t577Y4Xc225MsPr6dBZwY7aN4VmMSYjrOauA iKkTsQj8MyTwhc0EokLLRk1U198i8ra+hPR9NN+zZwt/unFtYtassYrc5EzysVyEIvVC q9psoQb86mmsT+9CGnXAMeJE38BYCH2qT0+0olx9fRywZyMvi7pJAIboYiqVVctv4Wvx fg8g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=Jk++708L; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id j5si12783438edc.195.2019.11.06.05.29.25; Wed, 06 Nov 2019 05:29:25 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=Jk++708L; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731928AbfKFN3X (ORCPT + 26 others); Wed, 6 Nov 2019 08:29:23 -0500 Received: from mail-pl1-f196.google.com ([209.85.214.196]:35399 "EHLO mail-pl1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731917AbfKFN3V (ORCPT ); Wed, 6 Nov 2019 08:29:21 -0500 Received: by mail-pl1-f196.google.com with SMTP id s10so591970plp.2 for ; Wed, 06 Nov 2019 05:29:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :in-reply-to:references; bh=ndl0P+VsTZD2v+P2v9bn/U9V2szmDcFpE9QaZn60GcY=; b=Jk++708LXyo/7ByqvgwlIhPiri1IenbjKc2cSae50LsdvVJ10VmxSRemddzrpMGYof ybKFnP4OZTKR+IWnxPv3rZ9SPmHwVgfII4zpEmSWVuBQrRmabm5c3d8DPoBhycjaN1E8 wi1E4HvuUCTJKw0uZbJVmAD24BB6z6q6XQSkrwm6bh4+2zlfDBTWijbLLo+BwJ9Vgnlp lHWz+p3h9owUvqYFwwuS4MD/Emodoj4SNJ6y436+Vqyu2XrS8bkMQxSUvLOMM/jsVOIs KGo41pjh56vWYLWunJ2sIYBrwuf6HTjyenTCgPLhrmloOJzaCwR87IgyzvWh/5QJM4fm VeGA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:in-reply-to:references; bh=ndl0P+VsTZD2v+P2v9bn/U9V2szmDcFpE9QaZn60GcY=; b=WLTy7kcktx+eYp6bO6X5fWrJwlghenWiQpVsOdyj7hTO7Pn/N+SLIQUbN8JjOr8YBG gj0/tiwBvOwQtGMpRELi3ew/JXreVYUGcvNwtDUuCHg9MeZ4hi6XvaxarHRlDnN8v2TJ xg+Ffw6s+RKEEHRje6jxivdBGHqY3aqKlSZAXKo+rdrE/aGoZyzRo4csX7N/dN6B8QwS 9+IOAlOpUKmml5H0LCHS3Dn/hF2BRR/5d0ksFFXK/rP5Lk9Q5EHkyqfcUOkRv3Qs49RT v3qOtyb/NpXHtaEYDEvHnMroF5Lkz7sC/9riWeyCecZV2pQuvoTwglgO2QHsRYJ5sdco RY9g== X-Gm-Message-State: APjAAAVDZweJmRa3UqYObDVO1Y2slsWk3bw2HKKR5doizh5Nhs+cCMJJ 8Jpm1p0q1AQvX+jE4p2+5HrbvNW34G7sYQ== X-Received: by 2002:a17:902:ac98:: with SMTP id h24mr688438plr.227.1573046959859; Wed, 06 Nov 2019 05:29:19 -0800 (PST) Received: from localhost ([49.248.202.230]) by smtp.gmail.com with ESMTPSA id x20sm23088825pfa.186.2019.11.06.05.29.18 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 06 Nov 2019 05:29:19 -0800 (PST) From: Amit Kucheria To: linux-kernel@vger.kernel.org, edubezval@gmail.com, Amit Daniel Kachhap , Amit Kucheria , Bartlomiej Zolnierkiewicz , Daniel Lezcano , Guillaume La Roque , Heiko Stuebner , Javi Merino , Jonathan Hunter , Jun Nie , Krzysztof Kozlowski , Kukjin Kim , Matthias Brugger , Shawn Guo , Thierry Reding , Viresh Kumar , Zhang Rui Cc: linux-arm-kernel@lists.infradead.org, linux-pm@vger.kernel.org Subject: [PATCH 11/11] thermal: zx2967: Appease the kernel-doc deity Date: Wed, 6 Nov 2019 18:58:27 +0530 Message-Id: X-Mailer: git-send-email 2.17.1 In-Reply-To: References: In-Reply-To: References: Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Fix up the following warning when compiled with make W=1: linux.git/drivers/thermal/zx2967_thermal.c:57: warning: Function parameter or member 'dev' not described in 'zx2967_thermal_priv' Signed-off-by: Amit Kucheria --- drivers/thermal/zx2967_thermal.c | 1 + 1 file changed, 1 insertion(+) -- 2.17.1 Reviewed-by: Viresh Kumar diff --git a/drivers/thermal/zx2967_thermal.c b/drivers/thermal/zx2967_thermal.c index 7c8a82c8e1e92..8e3a2d3c2f9a3 100644 --- a/drivers/thermal/zx2967_thermal.c +++ b/drivers/thermal/zx2967_thermal.c @@ -45,6 +45,7 @@ * @clk_topcrm: topcrm clk structure * @clk_apb: apb clk structure * @regs: pointer to base address of the thermal sensor + * @dev: struct device pointer */ struct zx2967_thermal_priv {