From patchwork Sun Jul 21 16:28:34 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kousik Sanagavarapu X-Patchwork-Id: 813701 Received: from mail-ot1-f53.google.com (mail-ot1-f53.google.com [209.85.210.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 151795380F; Sun, 21 Jul 2024 17:09:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.53 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1721581756; cv=none; b=h12Khq4BW7oUL00J5Uu770QTm4APPfBg9gsuvkrolSxue4kyxh+QXxtZF6QAJH/C94Kf4m+WxtTnJdLq6T+SJ/Gz6i0Az409vqrmuk6jjMfVkt1Fu+8j15bbwO2gXmD7q/cyzVxolTxXvgtlvSkUp57wVvuKvOb0ILIe7ruUIK4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1721581756; c=relaxed/simple; bh=dkbX/BmKso1WNDWENo072TCLDSRYmDwH7oq/jqphAT8=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=cVz7YjeDyOfR+Y1PPzTJgY1NkMw3Qca3TX/97FOqrgxDB25a6gGc1H3/Zn8JIRS3wfx+FmvEBIXmMZy/hYyATWDwui1kWe6856M7M1tt0Jh9rwbzYDlW6o83DQ2oMKT6HM77mRsB3liNFzlhLYFDwH/+vs5effPJbt2HgFrXSXg= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=FIMblW/n; arc=none smtp.client-ip=209.85.210.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="FIMblW/n" Received: by mail-ot1-f53.google.com with SMTP id 46e09a7af769-70362cb061aso1983060a34.1; Sun, 21 Jul 2024 10:09:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1721581752; x=1722186552; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=G9aEJfvEVkHc3rc+qcpiZ+r3iAy/bh/OhW1EfSbvL3c=; b=FIMblW/nLRqJNc9ibarmaaymq/N+9JmN+6K2VmXbaQHW9hRzAVA5csVDoJtoN5TJu0 b97RSnPYty6qSKvwriAUgjdXOFVFNwVN9jkkw9SJ5/t/nYqHw5eyn3LOe9IuJgJxmhXn X0TpGchaP/aPMTqKeJN76p7Nw1hZS+3Y+TmfNaJXcKO9obCXTwbRk59xAOwXIXz6iyKg 7CWhh/GALmNXUVoicY8Ibydo1PbJxwKW8CCzMGoUWWTj5MkPbXU+CSBcWUxbvUzGZ2tc FizxIG7A8O6kpoNqMOP1aplBKHaqBLGPE2iFEq0sz+wNVOmDuy5e6E7cT5BMpxEbpNJm Smcw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1721581752; x=1722186552; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=G9aEJfvEVkHc3rc+qcpiZ+r3iAy/bh/OhW1EfSbvL3c=; b=oHaCa6CL5Awj4JYhFrjkKGWpKfG+hv/KSY318+ZpxNEmLoT7zKtjcZazNJ9SKQWSej r314OPRsHKK2TclzZv6al4ES1HAclluWlADSQfPjv+GhySa6VcfeS3APA1ucGtkosKF4 MpU6KYsCfmLz1ipO38/T/TtD3Nj1U930EtZ0HDM+40uz85XjGqyxSBubGqaFjKO53/zi 5ILU5pFkkaB4RwNKST1op4dg3cduEJiv2QdCdjLerUH1y+B4+PcgNsUQwbSTEW71RT/y JAw2OZhkCPCsnajBixxb/3hOm3KtG19yELMUXuXjmTC3ZnBtGt0iGymmaDo/uprnMl1e mb8w== X-Forwarded-Encrypted: i=1; AJvYcCVzL4rlMPxe3ChrnKE7etZuYjRtEqp0n8e+2aQn9cpYTsxlIFw51+4BiV/yU5nmunmo2r9SBQlT9gTvaQvtTEY84hBetEoF0h/4dXnqaWVHiIHvVEIc8M+HCYljRF4JPU0LZ7xj1+U762b5wR8= X-Gm-Message-State: AOJu0YxJ8PjpNscFrDKz0gMe5wBXwuIedml4Df9fce0UAFJ4gdmmrNnW Vl9ErP/VdDmxMWSm68RtfdY2rgoU/94uoVzkWTtVwQp1A0D6uuoy X-Google-Smtp-Source: AGHT+IG4RGm6UldBRPirm/sgg0RJFRpR7a2pTNHo9NF5qkkB4iyXZ5ybq2E6dEdqmje5bNCJc3Rb7w== X-Received: by 2002:a05:6830:391b:b0:703:b0e9:d951 with SMTP id 46e09a7af769-709008d0de4mr6872850a34.6.1721581751955; Sun, 21 Jul 2024 10:09:11 -0700 (PDT) Received: from kousik.local ([2405:201:c006:312d:f66f:2b12:abd:60ff]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-70d285943e3sm417810b3a.213.2024.07.21.10.09.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 21 Jul 2024 10:09:11 -0700 (PDT) From: Kousik Sanagavarapu To: Daniel Lezcano , Thomas Gleixner , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Wim Van Sebroeck , Guenter Roeck , Nishanth Menon , Santosh Shilimkar Cc: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-watchdog@vger.kernel.org, linux-kernel@vger.kernel.org, Kousik Sanagavarapu Subject: [PATCH 1/3] dt-bindings: timer: ti, davinci-timer: convert to dtschema Date: Sun, 21 Jul 2024 21:58:34 +0530 Message-ID: <20240721170840.15569-2-five231003@gmail.com> X-Mailer: git-send-email 2.45.2.827.g557ae147e6.dirty In-Reply-To: <20240721170840.15569-1-five231003@gmail.com> References: <20240721170840.15569-1-five231003@gmail.com> Precedence: bulk X-Mailing-List: linux-watchdog@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Convert txt binding of TI's DaVinci timer to dtschema to allow for validation. Signed-off-by: Kousik Sanagavarapu --- .../bindings/timer/ti,davinci-timer.txt | 37 ---------- .../bindings/timer/ti,davinci-timer.yaml | 68 +++++++++++++++++++ 2 files changed, 68 insertions(+), 37 deletions(-) delete mode 100644 Documentation/devicetree/bindings/timer/ti,davinci-timer.txt create mode 100644 Documentation/devicetree/bindings/timer/ti,davinci-timer.yaml diff --git a/Documentation/devicetree/bindings/timer/ti,davinci-timer.txt b/Documentation/devicetree/bindings/timer/ti,davinci-timer.txt deleted file mode 100644 index 29bf91ccf5b7..000000000000 --- a/Documentation/devicetree/bindings/timer/ti,davinci-timer.txt +++ /dev/null @@ -1,37 +0,0 @@ -* Device tree bindings for Texas Instruments DaVinci timer - -This document provides bindings for the 64-bit timer in the DaVinci -architecture devices. The timer can be configured as a general-purpose 64-bit -timer, dual general-purpose 32-bit timers. When configured as dual 32-bit -timers, each half can operate in conjunction (chain mode) or independently -(unchained mode) of each other. - -The timer is a free running up-counter and can generate interrupts when the -counter reaches preset counter values. - -Also see ../watchdog/davinci-wdt.txt for timers that are configurable as -watchdog timers. - -Required properties: - -- compatible : should be "ti,da830-timer". -- reg : specifies base physical address and count of the registers. -- interrupts : interrupts generated by the timer. -- interrupt-names: should be "tint12", "tint34", "cmpint0", "cmpint1", - "cmpint2", "cmpint3", "cmpint4", "cmpint5", "cmpint6", - "cmpint7" ("cmpintX" may be omitted if not present in the - hardware). -- clocks : the clock feeding the timer clock. - -Example: - - clocksource: timer@20000 { - compatible = "ti,da830-timer"; - reg = <0x20000 0x1000>; - interrupts = <21>, <22>, <74>, <75>, <76>, <77>, <78>, <79>, - <80>, <81>; - interrupt-names = "tint12", "tint34", "cmpint0", "cmpint1", - "cmpint2", "cmpint3", "cmpint4", "cmpint5", - "cmpint6", "cmpint7"; - clocks = <&pll0_auxclk>; - }; diff --git a/Documentation/devicetree/bindings/timer/ti,davinci-timer.yaml b/Documentation/devicetree/bindings/timer/ti,davinci-timer.yaml new file mode 100644 index 000000000000..615ceb8f30af --- /dev/null +++ b/Documentation/devicetree/bindings/timer/ti,davinci-timer.yaml @@ -0,0 +1,68 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/timer/ti,davinci-timer.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: TI DaVinci Timer + +maintainers: + - Kousik Sanagavarapu + +description: | + + This is a 64-bit timer found on TI's DaVinci architecture devices. The timer + can be configured as a general-purpose 64-bit timer, dual general-purpose + 32-bit timers. When configured as dual 32-bit timers, each half can operate + in conjunction (chain mode) or independently (unchained mode) of each other. + + The timer is a free running up-counter and can generate interrupts when the + counter reaches preset counter values. + +properties: + compatible: + const: ti,da830-timer + + reg: + maxItems: 1 + + interrupts: + minItems: 2 + + interrupt-names: + minItems: 2 + items: + - const: tint12 + - const: tint34 + - const: cmpint0 + - const: cmpint1 + - const: cmpint2 + - const: cmpint3 + - const: cmpint4 + - const: cmpint5 + - const: cmpint6 + - const: cmpint7 + + clocks: + maxItems: 1 + +required: + - compatible + - reg + - interrupts + - interrupt-names + - clocks + +additionalProperties: false + +examples: + - | + timer@20000 { + compatible = "ti,da830-timer"; + reg = <0x20000 0x1000>; + interrupts = <21>, <22>; + interrupt-names = "tint12", "tint34"; + clocks = <&pll0_auxclk>; + }; + +... From patchwork Sun Jul 21 16:28:35 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kousik Sanagavarapu X-Patchwork-Id: 814110 Received: from mail-pf1-f173.google.com (mail-pf1-f173.google.com [209.85.210.173]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 65D5616A954; Sun, 21 Jul 2024 17:09:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.173 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1721581760; cv=none; b=Z/s0/6Py1a82BbgaJflzWITuOS11FzLChttQTX8clYsb8NQV72xa7Yt78x382DBpl3QSgvOo3jcdxMsF9zHf5+pYIBIyh4DiK6mX/ZyijKgTDnqPbThH3eBdS9hRCs4c/tGdaiXIr9y0q4E0A3UpAOj1WzgPrRYVm2b5D6XuhEM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1721581760; c=relaxed/simple; bh=mgXMk9207gSsRQUmrkKWubb5TQ6pXEwLYXpKlHkkwRs=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Zvttb1OaOvrIKKYy2x/ljWpzx90eolVLZC8KTQKUdkHKphp9gmJy1T6c7PZZR4dDjOvjDIdsp87uAbAaDeWy+HRMprlnzQWkXfjv01BtG9hoTGS5KsZc05/dqr5gi+K4cbvK/E2xO01LGjYb6eriFy3znedr4VGng/m088ZVoIk= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=m6rLn3AW; arc=none smtp.client-ip=209.85.210.173 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="m6rLn3AW" Received: by mail-pf1-f173.google.com with SMTP id d2e1a72fcca58-70d150e8153so511987b3a.0; Sun, 21 Jul 2024 10:09:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1721581759; x=1722186559; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=m+xFnJLXKFSs1rD/pdMgqeISRYaT8z33SQNfYCihvv0=; b=m6rLn3AWso0Nl2pbIRyGNZ4ynCIGODz9C6fWlT1PSNsi23asFb3/PabHWraZtJW9me JARnQVJvomzUIWD2QKlWAfe8yzeodC1xWMWIyQm/6Xtfk/4+QZJ8yJZW2k/GIa8kMPl+ MvsUT5nQAG2ec9F/6oEoDgo7BudK2YrYnF5jZ3sQymtcF53Q1ZH+re1VIdKvd1qc4PGL VnBrCdyajo9I4uaGIK12ifgPbgdHIgF4VyVWB4inaeh7WLyYg/LPaePiCmrboR3HZCiP RLGKxHuvyspPrmBtY9Kh/FsVKkXjZrq/ZRJD482Q5+ZIkyUnpXbVKKjKvOSSMZ0+8IAg 6L7w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1721581759; x=1722186559; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=m+xFnJLXKFSs1rD/pdMgqeISRYaT8z33SQNfYCihvv0=; b=G+IWqp+tQPRQASEiv74evSSB/dQxYmNBvekyVRdAXPpt07zxKiEwEEJD0KCqPUHMDW RdfSQZ/YK03qPbOEs0BqjM4y9+Qe/WNYu8VDRIFa09Cp2Pi4kjE663jS4GFN4g5kXazd GQwDywrgso9hdskywQHOl9LPmNm13b3gTnYnvqtxVNo0+8zomLSa54UP/iR/dvoE4AjQ palAK586rM+jwC9Y6eFVIGhWa10HdX4xbzPEZdbT9Te4096kbhBR2jV0vVY7dd7nC/WJ IIWN8Rk+2t+qqE2VguPkwuqDEBVCOR+BhWsiT3kzf7GVHzF7D2QEoDIrvjIWJ09pUJH+ ArDg== X-Forwarded-Encrypted: i=1; AJvYcCXNIyXXBKI7l6AA822TacLUteiKlU7XFsMxxqximUtEx2oLGAvlIJp0p2BLUrntVi1JwOY1Fr+NAL4P95C4OM3AZIZDqExHi7zhgJQGnvv7EZU62B2zwp+aEX/mnN0cQNcrjecRfP910pnLxvc= X-Gm-Message-State: AOJu0YwPPvNQGuWoUas3Ra3gG5v9Qg1uk7HadW6mg1uykhF1+Zuc5enG 5ggnWZ+WdlPunta376WUqOylywgoh9duzt99q3e1ggqUS2aroZjP X-Google-Smtp-Source: AGHT+IENAylm5O+0sTieY5CFralyVXeCUeaCnUG9F/PIBeQRb/dRfNNLBPxjkB3W/gCU0FJWFl0g0w== X-Received: by 2002:a05:6a00:1954:b0:704:2516:8d17 with SMTP id d2e1a72fcca58-70cfd51e05cmr14110055b3a.8.1721581758481; Sun, 21 Jul 2024 10:09:18 -0700 (PDT) Received: from kousik.local ([2405:201:c006:312d:f66f:2b12:abd:60ff]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-70d285943e3sm417810b3a.213.2024.07.21.10.09.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 21 Jul 2024 10:09:18 -0700 (PDT) From: Kousik Sanagavarapu To: Daniel Lezcano , Thomas Gleixner , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Wim Van Sebroeck , Guenter Roeck , Nishanth Menon , Santosh Shilimkar Cc: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-watchdog@vger.kernel.org, linux-kernel@vger.kernel.org, Kousik Sanagavarapu Subject: [RFC PATCH 2/3] dt-bindings: watchdog: ti,davinci-wdt: convert to dtschema Date: Sun, 21 Jul 2024 21:58:35 +0530 Message-ID: <20240721170840.15569-3-five231003@gmail.com> X-Mailer: git-send-email 2.45.2.827.g557ae147e6.dirty In-Reply-To: <20240721170840.15569-1-five231003@gmail.com> References: <20240721170840.15569-1-five231003@gmail.com> Precedence: bulk X-Mailing-List: linux-watchdog@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Convert txt bindings of TI's DaVinci/Keystone Watchdog Timer Controller to dtschema to allow for validation. Signed-off-by: Kousik Sanagavarapu --- This patch was submitted to the lists before by Nik https://lore.kernel.org/linux-devicetree/20231024195839.49607-1-n2h9z4@gmail.com/ Although it seems that the right way include the "power-domians" property was not decided upon (read through the thread). I grepped for instances of "power-domains" in ti related SoCs and other subsystems and it seems that there is always only 1 such "power-domains" phandle Documentation/devicetree/bindings/display/ti/ti,k2g-dss.yaml The existing dts code also confirms this arch/arm/boot/dts/ti/keystone/keystone-k2g.dtsi Again, I guess it would be great if someone could point out if this is right - so RFC. Also, shouldn't "clocks" be "required"? - RFC. .../bindings/watchdog/davinci-wdt.txt | 24 --------- .../bindings/watchdog/ti,davinci-wdt.yaml | 52 +++++++++++++++++++ 2 files changed, 52 insertions(+), 24 deletions(-) delete mode 100644 Documentation/devicetree/bindings/watchdog/davinci-wdt.txt create mode 100644 Documentation/devicetree/bindings/watchdog/ti,davinci-wdt.yaml diff --git a/Documentation/devicetree/bindings/watchdog/davinci-wdt.txt b/Documentation/devicetree/bindings/watchdog/davinci-wdt.txt deleted file mode 100644 index aa10b8ec36e2..000000000000 --- a/Documentation/devicetree/bindings/watchdog/davinci-wdt.txt +++ /dev/null @@ -1,24 +0,0 @@ -Texas Instruments DaVinci/Keystone Watchdog Timer (WDT) Controller - -Required properties: -- compatible : Should be "ti,davinci-wdt", "ti,keystone-wdt" -- reg : Should contain WDT registers location and length - -Optional properties: -- timeout-sec : Contains the watchdog timeout in seconds -- clocks : the clock feeding the watchdog timer. - Needed if platform uses clocks. - See clock-bindings.txt - -Documentation: -Davinci DM646x - https://www.ti.com/lit/ug/spruer5b/spruer5b.pdf -Keystone - https://www.ti.com/lit/ug/sprugv5a/sprugv5a.pdf - -Examples: - -wdt: wdt@2320000 { - compatible = "ti,davinci-wdt"; - reg = <0x02320000 0x80>; - timeout-sec = <30>; - clocks = <&clkwdtimer0>; -}; diff --git a/Documentation/devicetree/bindings/watchdog/ti,davinci-wdt.yaml b/Documentation/devicetree/bindings/watchdog/ti,davinci-wdt.yaml new file mode 100644 index 000000000000..1829c407147d --- /dev/null +++ b/Documentation/devicetree/bindings/watchdog/ti,davinci-wdt.yaml @@ -0,0 +1,52 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/watchdog/ti,davinci-wdt.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: TI DaVinci/Keystone Watchdog Timer Controller + +maintainers: + - Kousik Sanagavarapu + +description: | + TI's Watchdog Timer Controller for DaVinci and Keystone Processors. + + Datasheets + + Davinci DM646x - https://www.ti.com/lit/ug/spruer5b/spruer5b.pdf + Keystone - https://www.ti.com/lit/ug/sprugv5a/sprugv5a.pdf + +allOf: + - $ref: watchdog.yaml# + +properties: + compatible: + enum: + - ti,davinci-wdt + - ti,keystone-wdt + + reg: + maxItems: 1 + + power-domains: + maxItems: 1 + + clocks: + maxItems: 1 + +required: + - compatible + - reg + +unevaluatedProperties: false + +examples: + - | + watchdog@22f0080 { + compatible = "ti,davinci-wdt"; + reg = <0x022f0080 0x80>; + clocks = <&clkwdtimer0>; + }; + +... From patchwork Sun Jul 21 16:28:36 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kousik Sanagavarapu X-Patchwork-Id: 813700 Received: from mail-io1-f42.google.com (mail-io1-f42.google.com [209.85.166.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F41D3168498; Sun, 21 Jul 2024 17:09:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.166.42 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1721581767; cv=none; b=MfqtCGuTM+tyQDRDWVOoLheLbSjFa21XWwt3vgpuNUm+qmVJGdIOUMJiMliCXITkciEQsT7i7K8YQaUdFIpmv0BoL5xK+YL5uAE82JSMU0v/hpXof0EKDD7ylJeH+BtuXlECL0UqCWHuycn2CNvZIjje3vTJbzMptXK3+SQiYlM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1721581767; c=relaxed/simple; bh=2um/GU8leukLyHCK06Z2T9a+Z9uUER35bwjofaOfLq0=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=BvMEGCVTDazQ9ILbO5U/K4Ya26YGUvqE3st8Q3tRgR8sD1p6eTbj7H+AJEA7GLx01/Sdb/cDMJpz+q6TztS8y3N0anCYDLmDW//eKrB7MrPY39SrObyNWrcQDPFMhVsmIcJqpV0Xlm9cJvaAFGSwOI1KCMkOZwG1kshvP1bLetE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=HBspY1c0; arc=none smtp.client-ip=209.85.166.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="HBspY1c0" Received: by mail-io1-f42.google.com with SMTP id ca18e2360f4ac-807007b8dd1so145110839f.2; Sun, 21 Jul 2024 10:09:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1721581765; x=1722186565; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=TJbtHFQcNPBsqXeFfU2FjoOsfer626zKkq+lXutNICI=; b=HBspY1c0LXij68jTV93VyaIfIyMpENfFWRudFmQWlHTcien7goCD4O0C9vFzf0k0Jj bHNlcIilOKN8PNEikXDUKdCYvGZDSBKo2HqTZag5p0rHDIXPkZRQ2Shb/Ld+MOgtgkqG Vdu8PZErE6B42BuHKLekLH5SP7wKQHGtTCwtwWdvTVG+lDy1bOr2qbkrlW8CinBGM548 /p8ZqPcacvFcevSIE7jDoOjmEyO0urIfA1gduD1QK6C4gd0wdpvEJr0Wwf+laWZehqNn iIoELiLY1DQmOX9k5uFj+mvPzkKfrnBQe28TThPkcjzSuCWZzMVQ84jTtF4iE7KK8wAJ AiyA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1721581765; x=1722186565; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=TJbtHFQcNPBsqXeFfU2FjoOsfer626zKkq+lXutNICI=; b=GneRPCMsKNmgbUA4LSChk7GBDQKwbn0x2SLDgvPd+TRPddzXhOAfkp9VyjmGzD0k+O chufpKR4F4VKbUM7hmpQzR/HNBHyDDzMrQTSJdq4ga326+i9k5Wi2ALArLcAMoYINE3S 0TSHqrTVjTmElzdgDs9cX4DdRNbkmNHO+02Cr6WhkiwB3EfjGmnvxALL8xJvS6zs8hda cdfgQ3rwKo0eK2aKfVnGs+b41w90LRCyS7xntlu7cRBD3RpEsrUkuLq760fzpwAvQc9x WAs3KKqkZmnMDvkL+XBvY1/qMm3+pNi3SM9MQrE9BzzDkQdetHS6IbX6tyScF8eqigpe JRYA== X-Forwarded-Encrypted: i=1; AJvYcCXATLBd3NS88LzRCPWuU73VrBQp3p1HD6QBBaZ6otffxkRVIalvmIEyQUlxFMwGzqN80XUxRY2ck9vf8SmPQ8ovXoxGWpAquy0hXCPbfD7XMHuUIzrJ3SkJIi8noFH/RkzXAvBeuj/VdV82A1M= X-Gm-Message-State: AOJu0Yzqtr5+AM2vkQedyzZsFj8BrvBxH3dE3UDqGA0U39FVNZpGBKDP whX4Tuh7NO9OlvMW4O0TDybSjNF/EU9yu1GaF7rzefbIqbyaNWkz X-Google-Smtp-Source: AGHT+IHTUuDmrSkpDNTCs+DM7fkQIf/sYoD1C3wpPlVfiRwZYjxYuCgZLbQbZW5lfAz3EpEk6s1CMw== X-Received: by 2002:a05:6602:6422:b0:806:31ee:13b with SMTP id ca18e2360f4ac-81aa538d525mr787891739f.4.1721581765062; Sun, 21 Jul 2024 10:09:25 -0700 (PDT) Received: from kousik.local ([2405:201:c006:312d:f66f:2b12:abd:60ff]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-70d285943e3sm417810b3a.213.2024.07.21.10.09.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 21 Jul 2024 10:09:24 -0700 (PDT) From: Kousik Sanagavarapu To: Daniel Lezcano , Thomas Gleixner , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Wim Van Sebroeck , Guenter Roeck , Nishanth Menon , Santosh Shilimkar Cc: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-watchdog@vger.kernel.org, linux-kernel@vger.kernel.org, Kousik Sanagavarapu Subject: [RFC PATCH 3/3] ARM: dts: davinci, keystone: correct watchdog nodenames Date: Sun, 21 Jul 2024 21:58:36 +0530 Message-ID: <20240721170840.15569-4-five231003@gmail.com> X-Mailer: git-send-email 2.45.2.827.g557ae147e6.dirty In-Reply-To: <20240721170840.15569-1-five231003@gmail.com> References: <20240721170840.15569-1-five231003@gmail.com> Precedence: bulk X-Mailing-List: linux-watchdog@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Using "wdt" instead of "watchdog" for watchdog timer nodes doesn't allow for validation with the corresponding dtschema and gives errors $ make CHECK_DTBS=y DT_SCHEMA_FILES=ti,davinci-wdt.yaml \ ti/keystone/keystone-k2g-ice.dtb DTC_CHK arch/arm/boot/dts/ti/keystone/keystone-k2g-ice.dtb arch/arm/boot/dts/ti/keystone/keystone-k2g-ice.dtb: wdt@02250000: $nodename:0: 'wdt@02250000' does not match '^(timer|watchdog)(@.*|-([0-9]|[1-9][0-9]+))?$' from schema $id: http://devicetree.org/schemas/watchdog/ti,davinci-wdt.yaml# Therefore change "wdt@" to "watchdog@". While at it, remove "ti,davinci-wdt" compatible from the keystone dts code. Signed-off-by: Kousik Sanagavarapu --- Question: Should "wdt@" be changed everywhere in the dts code or is it only a requirement of validation against dtschema? Also, I'm not sure about removing "ti,davinci-wdt" from the keystone dts code. I'm thinking it is only there so that the driver code can get information from keystone nodes too, because it seems that there is no code for ti,keystone-wdt. So question, - Is WDT Controller driver for keystone not written yet? Or - Does the WDT Controller driver for keystone have the same functionality as one on davinci - hence leading us to simply do .compatible = "ti,keystone-wdt" ? arch/arm/boot/dts/ti/davinci/da850.dtsi | 2 +- arch/arm/boot/dts/ti/keystone/keystone-k2g.dtsi | 4 ++-- arch/arm/boot/dts/ti/keystone/keystone.dtsi | 4 ++-- 3 files changed, 5 insertions(+), 5 deletions(-) diff --git a/arch/arm/boot/dts/ti/davinci/da850.dtsi b/arch/arm/boot/dts/ti/davinci/da850.dtsi index 1d3fb5397ce3..89055ab87256 100644 --- a/arch/arm/boot/dts/ti/davinci/da850.dtsi +++ b/arch/arm/boot/dts/ti/davinci/da850.dtsi @@ -525,7 +525,7 @@ clocksource: timer@20000 { interrupt-names = "tint12", "tint34"; clocks = <&pll0_auxclk>; }; - wdt: wdt@21000 { + wdt: watchdog@21000 { compatible = "ti,davinci-wdt"; reg = <0x21000 0x1000>; clocks = <&pll0_auxclk>; diff --git a/arch/arm/boot/dts/ti/keystone/keystone-k2g.dtsi b/arch/arm/boot/dts/ti/keystone/keystone-k2g.dtsi index dafe485dfe19..884402a5fe4a 100644 --- a/arch/arm/boot/dts/ti/keystone/keystone-k2g.dtsi +++ b/arch/arm/boot/dts/ti/keystone/keystone-k2g.dtsi @@ -610,8 +610,8 @@ spi3: spi@21806000 { clocks = <&k2g_clks 0x0013 0>; }; - wdt: wdt@02250000 { - compatible = "ti,keystone-wdt", "ti,davinci-wdt"; + wdt: watchdog@02250000 { + compatible = "ti,keystone-wdt"; reg = <0x02250000 0x80>; power-domains = <&k2g_pds 0x22>; clocks = <&k2g_clks 0x22 0>; diff --git a/arch/arm/boot/dts/ti/keystone/keystone.dtsi b/arch/arm/boot/dts/ti/keystone/keystone.dtsi index ff16428860a9..f697f27edcfc 100644 --- a/arch/arm/boot/dts/ti/keystone/keystone.dtsi +++ b/arch/arm/boot/dts/ti/keystone/keystone.dtsi @@ -225,8 +225,8 @@ usb0: usb@2690000 { }; }; - wdt: wdt@22f0080 { - compatible = "ti,keystone-wdt","ti,davinci-wdt"; + wdt: watchdog@22f0080 { + compatible = "ti,keystone-wdt"; reg = <0x022f0080 0x80>; clocks = <&clkwdtimer0>; };