From patchwork Mon Nov 4 12:36:58 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dan Murphy X-Patchwork-Id: 178410 Delivered-To: patch@linaro.org Received: by 2002:a92:38d5:0:0:0:0:0 with SMTP id g82csp1427271ilf; Mon, 4 Nov 2019 04:39:12 -0800 (PST) X-Google-Smtp-Source: APXvYqxZPhz+eVq4XozRCaJeL+E5xivSBhJOBg9TMj5pEmebfOTkG0LVM6bQOnc8cqmNF/wTioHT X-Received: by 2002:a17:906:2654:: with SMTP id i20mr17070474ejc.163.1572871151907; Mon, 04 Nov 2019 04:39:11 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1572871151; cv=none; d=google.com; s=arc-20160816; b=XX+UAWajMff+Yb+GcaM78tBjZzJ/SR/oa6283awKUHwwNWxx5mZafC7OR8CA/61jYK q+Tjxiei2bswF3Sur5f9xxhTvaN06YZDUBetPuwnQnOTwWHkk6rCCDKHpJxUDAGuHsrU 4ofk5jb2CumuOtQnzM5vTy6QR5/Rm6QUG1Wt6qThleLVTxN7LXYQoAP7AYk/VctlhQCQ aA1KCmvt+mayPIFnoHcmglh62NrZV/+S9b4qACU+Un9QY7VoP1qg97HIUHygEpGVQz46 tvp+o+Uv3Z1KjHb1cHwjzY57OUbFkIyDoAe/6MEamsI1JcJis9PZCkS1Lx11FonWspuw u6TA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=Q6v3ZsELVVFaq45xRxLW4voHJAlhEXxHc1kVNsr3mZg=; b=I0Oxnkt4kz8OBqGBgkX/tdMTGvJBqRg2SqoBMuCScTbb48+RdIMX+gc3KCi9Kv3+Ji MQTRdYvAy/nK+OFdioIJDOKOjYXpZY8q6k2psFBCxWg1laH38CJBLMIUqyrnWWd1jlN+ Y/QLd3PfDqWnerxEHF3HIfLMVu3uiLLnaGaxMgrcG/CEajY5gL8r/t51S5dRGegE12kf oYkZZDWDOnVBZmi6MGoTsI1ix4ohIWEy3QMgfrzYPbCNztVrjLvn3z5xafyughyOO/6T W+dfVu88VU/nAv8us912RVfJcE7mObEKRhllhzsv560zG1ZU+maBHxzeee8KcujIQerO b3ww== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@ti.com header.s=ti-com-17Q1 header.b=J0T2BXQe; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=NONE dis=NONE) header.from=ti.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id n2si4774393ejx.38.2019.11.04.04.39.11; Mon, 04 Nov 2019 04:39:11 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@ti.com header.s=ti-com-17Q1 header.b=J0T2BXQe; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=NONE dis=NONE) header.from=ti.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729133AbfKDMjK (ORCPT + 26 others); Mon, 4 Nov 2019 07:39:10 -0500 Received: from fllv0015.ext.ti.com ([198.47.19.141]:51198 "EHLO fllv0015.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727267AbfKDMjI (ORCPT ); Mon, 4 Nov 2019 07:39:08 -0500 Received: from lelv0266.itg.ti.com ([10.180.67.225]) by fllv0015.ext.ti.com (8.15.2/8.15.2) with ESMTP id xA4CcvIY014981; Mon, 4 Nov 2019 06:38:57 -0600 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1572871137; bh=Q6v3ZsELVVFaq45xRxLW4voHJAlhEXxHc1kVNsr3mZg=; h=From:To:CC:Subject:Date:In-Reply-To:References; b=J0T2BXQePWpiLGVZtWCLJTjgk3tiVhMQcKderkCWycPyAPDoWz6ziGBVz3rE9HXkM +Y9VYA0YK3Hd+cNAyNM8ieflcArYa8b8XeME1UTAz+41dUjrdUd7kk22IDSoiJyDr4 fbsozdDOokN4a2FyD4lBH5aYI2vp7v6DX+xiy0V8= Received: from DFLE109.ent.ti.com (dfle109.ent.ti.com [10.64.6.30]) by lelv0266.itg.ti.com (8.15.2/8.15.2) with ESMTPS id xA4CcvrF129686 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Mon, 4 Nov 2019 06:38:57 -0600 Received: from DFLE107.ent.ti.com (10.64.6.28) by DFLE109.ent.ti.com (10.64.6.30) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1713.5; Mon, 4 Nov 2019 06:38:42 -0600 Received: from lelv0327.itg.ti.com (10.180.67.183) by DFLE107.ent.ti.com (10.64.6.28) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1713.5 via Frontend Transport; Mon, 4 Nov 2019 06:38:42 -0600 Received: from localhost (ileax41-snat.itg.ti.com [10.172.224.153]) by lelv0327.itg.ti.com (8.15.2/8.15.2) with ESMTP id xA4Ccunb085496; Mon, 4 Nov 2019 06:38:56 -0600 From: Dan Murphy To: , CC: , , Dan Murphy , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team Subject: [PATCH v16 10/19] ARM: dts: imx6dl-yapp4: Add reg property to the lp5562 channel node Date: Mon, 4 Nov 2019 06:36:58 -0600 Message-ID: <20191104123707.31930-11-dmurphy@ti.com> X-Mailer: git-send-email 2.22.0.214.g8dca754b1e In-Reply-To: <20191104123707.31930-1-dmurphy@ti.com> References: <20191104123707.31930-1-dmurphy@ti.com> MIME-Version: 1.0 X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Add the reg property to each channel node. This update is to accomodate the multicolor framework. In addition to the accomodation this allows the LEDs to be placed on any channel and allow designs to skip channels as opposed to requiring sequential order. Signed-off-by: Dan Murphy CC: Shawn Guo CC: Sascha Hauer CC: Pengutronix Kernel Team CC: Fabio Estevam CC: NXP Linux Team --- arch/arm/boot/dts/imx6dl-yapp4-common.dtsi | 14 ++++++++++---- 1 file changed, 10 insertions(+), 4 deletions(-) -- 2.22.0.214.g8dca754b1e diff --git a/arch/arm/boot/dts/imx6dl-yapp4-common.dtsi b/arch/arm/boot/dts/imx6dl-yapp4-common.dtsi index e8d800fec637..efc466ed1fea 100644 --- a/arch/arm/boot/dts/imx6dl-yapp4-common.dtsi +++ b/arch/arm/boot/dts/imx6dl-yapp4-common.dtsi @@ -257,29 +257,35 @@ reg = <0x30>; clock-mode = /bits/ 8 <1>; status = "disabled"; + #address-cells = <1>; + #size-cells = <0>; - chan0 { + chan@0 { chan-name = "R"; led-cur = /bits/ 8 <0x20>; max-cur = /bits/ 8 <0x60>; + reg = <0>; }; - chan1 { + chan@1 { chan-name = "G"; led-cur = /bits/ 8 <0x20>; max-cur = /bits/ 8 <0x60>; + reg = <1>; }; - chan2 { + chan@2 { chan-name = "B"; led-cur = /bits/ 8 <0x20>; max-cur = /bits/ 8 <0x60>; + reg = <2>; }; - chan3 { + chan@3 { chan-name = "W"; led-cur = /bits/ 8 <0x0>; max-cur = /bits/ 8 <0x0>; + reg = <3>; }; }; From patchwork Mon Nov 4 12:37:07 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dan Murphy X-Patchwork-Id: 178417 Delivered-To: patch@linaro.org Received: by 2002:a92:38d5:0:0:0:0:0 with SMTP id g82csp1427985ilf; Mon, 4 Nov 2019 04:39:47 -0800 (PST) X-Google-Smtp-Source: APXvYqxxNvKvJPsaGzBlfjD4kHAEYh8JSDDh0sfhuTP1YWMkmFIUVWJJSzzpdm3MZkberzDaBNXN X-Received: by 2002:a17:906:7e10:: with SMTP id e16mr23735508ejr.84.1572871187220; Mon, 04 Nov 2019 04:39:47 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1572871187; cv=none; d=google.com; s=arc-20160816; b=wksWybdyIcceXLrY9KyVF5n/wip/3k8BKnCoXvRfuVcvosxWUCJk5QA9oq+GdXI4T3 fEF5SNqmdbpQXP0D3CKZBPWk+dFviH70IOpykRbwthE9+IhXRQlZ6TtVUYpE35XChXQD iveCVqMcdDHTN1HPWkOF8l1mWajvGfJV10YrBfCZevSkNnnXmcQzYQ9V/mYFsJbjRnT0 Sp/712nLga1AlHfbHjCydgAlFxIF/KoI+rqAnKxoc8Sfv1oYaV06vXkkVZSdsoaHLvdB rfY9lv5/ug65NcWofClrEW3p6ZIRZv70GRrG2buix/DiHXeDKcfkCEhrtNpWIdZU2khG 1GgA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=CiO3hXAyFsuZm3cE8SXZzPxL1D+KaY4p9kZlHGgSu6M=; b=wY1TfxatwHbU9OKlo165z+Ly6FlhHO7UlLp8LTjcmgUnqGNLH05cIDwDNmSCdnNGnz wJhjxAwYVrymz4xIL1Rk6/fOcntkH+hVKu5iUEpsCJVPew7PZ3clgxRmGdM1SdhRLNkw UvD9eTszTLy3w7R7PXtlJPNaa9Kt8LmPhck16Y6nz/AReyxNKhUnbsIMKiZUULE71S+p dE5VL7Ats8TG7oaET0BgmpqKPRzSvYbHHhRivIDPbRBxgaYRNTa/buZ6rdZlOY+ab8lm StH4RL1jbAaZgIu1IxB4sjUhq2RK8YUEFmVM3vpfWcZxDiq8u4RchTO2ngEyw/DmgrlE o29g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@ti.com header.s=ti-com-17Q1 header.b=rWAz4FGw; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=NONE dis=NONE) header.from=ti.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 14si12155497eja.294.2019.11.04.04.39.46; Mon, 04 Nov 2019 04:39:47 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@ti.com header.s=ti-com-17Q1 header.b=rWAz4FGw; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=NONE dis=NONE) header.from=ti.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729268AbfKDMjn (ORCPT + 26 others); Mon, 4 Nov 2019 07:39:43 -0500 Received: from fllv0016.ext.ti.com ([198.47.19.142]:52664 "EHLO fllv0016.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727267AbfKDMjn (ORCPT ); Mon, 4 Nov 2019 07:39:43 -0500 Received: from fllv0035.itg.ti.com ([10.64.41.0]) by fllv0016.ext.ti.com (8.15.2/8.15.2) with ESMTP id xA4Cdemm118813; Mon, 4 Nov 2019 06:39:40 -0600 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1572871180; bh=CiO3hXAyFsuZm3cE8SXZzPxL1D+KaY4p9kZlHGgSu6M=; h=From:To:CC:Subject:Date:In-Reply-To:References; b=rWAz4FGwSyFQQyHjOvix7FTqguGBvpYXY9Ov0GbmBvRZGd7fXifBrSEZSjENxSwR2 Z1RWXbXNvlXSnN7qFoWUUl2LZx1Yz1QEh612+vd4lpk62HmBOsNPBBgXlLCamQTo04 UcpclimbfRDRMDQVDJuNPbhR8rJAvxc1Xc0ZzW3g= Received: from DFLE115.ent.ti.com (dfle115.ent.ti.com [10.64.6.36]) by fllv0035.itg.ti.com (8.15.2/8.15.2) with ESMTP id xA4CdeaQ069385; Mon, 4 Nov 2019 06:39:40 -0600 Received: from DFLE109.ent.ti.com (10.64.6.30) by DFLE115.ent.ti.com (10.64.6.36) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1713.5; Mon, 4 Nov 2019 06:39:25 -0600 Received: from lelv0326.itg.ti.com (10.180.67.84) by DFLE109.ent.ti.com (10.64.6.30) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1713.5 via Frontend Transport; Mon, 4 Nov 2019 06:39:25 -0600 Received: from localhost (ileax41-snat.itg.ti.com [10.172.224.153]) by lelv0326.itg.ti.com (8.15.2/8.15.2) with ESMTP id xA4Cddll013779; Mon, 4 Nov 2019 06:39:39 -0600 From: Dan Murphy To: , CC: , , Dan Murphy Subject: [PATCH v16 19/19] leds: lp55xx-common: Remove extern from lp55xx-common header Date: Mon, 4 Nov 2019 06:37:07 -0600 Message-ID: <20191104123707.31930-20-dmurphy@ti.com> X-Mailer: git-send-email 2.22.0.214.g8dca754b1e In-Reply-To: <20191104123707.31930-1-dmurphy@ti.com> References: <20191104123707.31930-1-dmurphy@ti.com> MIME-Version: 1.0 X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org extern is implied and is not needed in the common header file. Remove the extern keyword and re-align the code. Signed-off-by: Dan Murphy --- drivers/leds/leds-lp55xx-common.h | 26 ++++++++++++-------------- 1 file changed, 12 insertions(+), 14 deletions(-) -- 2.22.0.214.g8dca754b1e diff --git a/drivers/leds/leds-lp55xx-common.h b/drivers/leds/leds-lp55xx-common.h index 18476051d3d2..051f8b33c601 100644 --- a/drivers/leds/leds-lp55xx-common.h +++ b/drivers/leds/leds-lp55xx-common.h @@ -183,29 +183,27 @@ struct lp55xx_led { }; /* register access */ -extern int lp55xx_write(struct lp55xx_chip *chip, u8 reg, u8 val); -extern int lp55xx_read(struct lp55xx_chip *chip, u8 reg, u8 *val); -extern int lp55xx_update_bits(struct lp55xx_chip *chip, u8 reg, - u8 mask, u8 val); +int lp55xx_write(struct lp55xx_chip *chip, u8 reg, u8 val); +int lp55xx_read(struct lp55xx_chip *chip, u8 reg, u8 *val); +int lp55xx_update_bits(struct lp55xx_chip *chip, u8 reg, u8 mask, u8 val); /* external clock detection */ -extern bool lp55xx_is_extclk_used(struct lp55xx_chip *chip); +bool lp55xx_is_extclk_used(struct lp55xx_chip *chip); /* common device init/deinit functions */ -extern int lp55xx_init_device(struct lp55xx_chip *chip); -extern void lp55xx_deinit_device(struct lp55xx_chip *chip); +int lp55xx_init_device(struct lp55xx_chip *chip); +void lp55xx_deinit_device(struct lp55xx_chip *chip); /* common LED class device functions */ -extern int lp55xx_register_leds(struct lp55xx_led *led, - struct lp55xx_chip *chip); +int lp55xx_register_leds(struct lp55xx_led *led, struct lp55xx_chip *chip); /* common device attributes functions */ -extern int lp55xx_register_sysfs(struct lp55xx_chip *chip); -extern void lp55xx_unregister_sysfs(struct lp55xx_chip *chip); +int lp55xx_register_sysfs(struct lp55xx_chip *chip); +void lp55xx_unregister_sysfs(struct lp55xx_chip *chip); /* common device tree population function */ -extern struct lp55xx_platform_data -*lp55xx_of_populate_pdata(struct device *dev, struct device_node *np, - struct lp55xx_chip *chip); +struct lp55xx_platform_data *lp55xx_of_populate_pdata(struct device *dev, + struct device_node *np, + struct lp55xx_chip *chip); #endif /* _LEDS_LP55XX_COMMON_H */