From patchwork Wed Jul 10 17:04:59 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephan Gerhold X-Patchwork-Id: 811806 Received: from mail-wm1-f46.google.com (mail-wm1-f46.google.com [209.85.128.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 33185195B14 for ; Wed, 10 Jul 2024 17:05:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.46 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1720631120; cv=none; b=YNmZBNlboUF6n7fIH5ozY/entKOlFpTB7lOO+5wYAPZ+p6+3GZ/ifhQ6AQgxmRx8oAzxi5QiBFLi06jI23fwW16mvuhD2DplKZcH1+6gUfqge6QFfhITJnnrjt/1SIWI/CcoqOQD+i0r/W7o5myN9WNiJ3FCTLYbdi12mWUStgc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1720631120; c=relaxed/simple; bh=OjIv6lSyIoOmyQVHsNTFY8WnoyqlDx5HT8DrVGCLkuY=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=ccDcbQquCHsUGDOatD2OdWNbOvRjFJ34LpJ4OdZ1ZTybmrQAAVm+aqhz1NI+4JaxOGA1aJ6s3yCs/AV8A22Gftdbenkaatalye/dlaWbfPMZHLnl81bRBImNcO2C8PwvmXdtbzmLuWms4eQh5H1SYtSvlMAm56ouLhx84hC2h28= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=nkWXSBSj; arc=none smtp.client-ip=209.85.128.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="nkWXSBSj" Received: by mail-wm1-f46.google.com with SMTP id 5b1f17b1804b1-426636ef8c9so25935515e9.2 for ; Wed, 10 Jul 2024 10:05:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1720631117; x=1721235917; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=S4NkoAIT77VT3upOcUYDgNo3eUGfA37eNUjC42fZIhc=; b=nkWXSBSjzqJ1ESlxQPj7Yb/ecY3DMOnq6LU7RR7lE5zaSowR+rJZsGleqCmWnR82/m xSvcyDKd0rCCcbwgtSjN/VvUD8DLs9n51/z2hO5pYvLaJXPmXxOfETTRsZJAPyTILpsR J+LLS2TVZH9svZZt9XEbzqJ13nLQpKEjOPfCSi0WFXmJBjvOQ+/JZaQE33rtWbmp+ObN xJQ2e2x5x8uqmrj9/NCmNnrVP/4zoBpT+bgORSBfTJxLq36kyRe9iFP02KjC89LcYI0T Es4PSvBzDNJxu4AmZfxg/Rg23Qi3w6DXkxtE9NfRQVdzjezbRjZ/+Loa9LuolZ+EUEMP OOpg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1720631117; x=1721235917; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=S4NkoAIT77VT3upOcUYDgNo3eUGfA37eNUjC42fZIhc=; b=QtkcaA7A8uhyxueYGIx2z7K9kFLJeTlp6MdFK4Q+RLQEif9lQrmUFz1wBgQbOzcKU7 8eOaw4lW9VChgsSMXi9QiHaIW+ryPAy3h8cOQBHY4HmPIfgOPkIKEPaujoykjW1p5NYa ddtAbkATWj1WUWdNyyE1I0xwWOz5xqnqGLXXpe/MB0kRtthuPkv7F4N1hnsgGQk86PAz jxa+NNP66R6CBIUfTl0bJEKMZAyN9iQAAcUDHwUPcaa9MBBmzWZnomZGu/N5Vl1s6nTJ JANYwgiPaFzWWPz57rbeGVTrSUY/vfSUIqXG8EG7Cs4LIPkG+cg+5jp7AoX/icQootaC ZDtA== X-Forwarded-Encrypted: i=1; AJvYcCUfdZna1EOwdFAycw8+AD137F9mgMpCMgsmskVawDJAMgGycbjj9Ss2TGqUlzXDTqYb7K9ncc2T5U5z/GMITItTEu6Z+UxyBjg/GsNJXg== X-Gm-Message-State: AOJu0YyzhwCDo/VgOuBCl5/GrQ3BjK/vXDw7PpNm5Kat8wXyVilYEZuW W9AfBCnzMO6pDE/vF+/AcynPtRRmfMDdKF8WnGi8/IZ+yWmKPQcvLQJDtnud9ZI= X-Google-Smtp-Source: AGHT+IGkLUFSUmZ5ECS3GHwAe+MqsROrwZrfQE/I+tdJdPvxCPyYlWVxShiAik5dzVjABnYcvtZ7ZQ== X-Received: by 2002:a05:600c:896:b0:426:5216:3254 with SMTP id 5b1f17b1804b1-426708f1eebmr46866985e9.32.1720631117621; Wed, 10 Jul 2024 10:05:17 -0700 (PDT) Received: from [127.0.0.2] ([2a02:2454:ff1f:b240:65e6:93ca:5f80:ea9b]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-367cde7dedfsm5838446f8f.24.2024.07.10.10.05.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 10 Jul 2024 10:05:17 -0700 (PDT) From: Stephan Gerhold Date: Wed, 10 Jul 2024 19:04:59 +0200 Subject: [PATCH 3/5] Revert "drm/panel-edp: Add SDC ATNA45AF01" Precedence: bulk X-Mailing-List: linux-arm-msm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20240710-x1e80100-crd-backlight-v1-3-eb242311a23e@linaro.org> References: <20240710-x1e80100-crd-backlight-v1-0-eb242311a23e@linaro.org> In-Reply-To: <20240710-x1e80100-crd-backlight-v1-0-eb242311a23e@linaro.org> To: Neil Armstrong , Bjorn Andersson , Konrad Dybcio Cc: Jessica Zhang , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Douglas Anderson , dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, Abel Vesa , Johan Hovold X-Mailer: b4 0.13.0 This reverts commit 8ebb1fc2e69ab8b89a425e402c7bd85e053b7b01. The panel should be handled through the samsung-atna33xc20 driver for correct power up timings. Otherwise the backlight does not work correctly. We have existing users of this panel through the generic "edp-panel" compatible (e.g. the Qualcomm X1E80100 CRD), but the screen works only partially in that configuration: It works after boot but once the screen gets disabled it does not turn on again until after reboot. It behaves the same way with the default "conservative" timings, so we might as well drop the configuration from the panel-edp driver. That way, users with old DTBs will get a warning and can move to the new driver. Signed-off-by: Stephan Gerhold --- drivers/gpu/drm/panel/panel-edp.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/gpu/drm/panel/panel-edp.c b/drivers/gpu/drm/panel/panel-edp.c index 3a574a9b46e7..d2d682385e89 100644 --- a/drivers/gpu/drm/panel/panel-edp.c +++ b/drivers/gpu/drm/panel/panel-edp.c @@ -1960,8 +1960,6 @@ static const struct edp_panel_entry edp_panels[] = { EDP_PANEL_ENTRY('L', 'G', 'D', 0x05af, &delay_200_500_e200_d200, "Unknown"), EDP_PANEL_ENTRY('L', 'G', 'D', 0x05f1, &delay_200_500_e200_d200, "Unknown"), - EDP_PANEL_ENTRY('S', 'D', 'C', 0x416d, &delay_100_500_e200, "ATNA45AF01"), - EDP_PANEL_ENTRY('S', 'H', 'P', 0x1511, &delay_200_500_e50, "LQ140M1JW48"), EDP_PANEL_ENTRY('S', 'H', 'P', 0x1523, &delay_80_500_e50, "LQ140M1JW46"), EDP_PANEL_ENTRY('S', 'H', 'P', 0x153a, &delay_200_500_e50, "LQ140T1JH01"), From patchwork Wed Jul 10 17:05:00 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephan Gerhold X-Patchwork-Id: 811805 Received: from mail-lf1-f52.google.com (mail-lf1-f52.google.com [209.85.167.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 56BA9195FD1 for ; Wed, 10 Jul 2024 17:05:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.52 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1720631122; cv=none; b=LU5PqKbUXku6XzGZdSHe/hR0aWEBwJzH/VnLmdX2IxHUAjO5f6sQWIXWXqTgiMvzOc6sB+EiGpFDxYn3ViLJlX1DqKfbmRMf87j73KvG5mp3xPs6XMmSbvojTDpIAzCCLQz03lewOD1zeuEkcV482KMhj9Vo/e1RsUpzh1mytoc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1720631122; c=relaxed/simple; bh=UtGbOemBnLSiS/SSxde0/IPn7E11HeciK/KMJx5zgzg=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=UXzPUYLvuezBbEO4l/pUwxj4pnf+5YayJIpysm48fJvZh4nQ1sEkVEvaoo+plXbUrKVjH1weMi7Ud9ya3iJ/4e4Y+QEP5IhzG/sduR0guzmCELW7t8Pji2oRn/IvZUQhenLpFNKAwjytLlL7xkQBGHT890vvJEG6KtDKkB6NP3A= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=LsLq3ko0; arc=none smtp.client-ip=209.85.167.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="LsLq3ko0" Received: by mail-lf1-f52.google.com with SMTP id 2adb3069b0e04-52e976208f8so7221546e87.2 for ; Wed, 10 Jul 2024 10:05:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1720631118; x=1721235918; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=ejuDXxzDzIH7zcxYcOPWRk3uTUuzsIoqRWToUCtONmU=; b=LsLq3ko0dEzIxVV03b/Sxfq0ohjNb7DdPmSl2uFnq3WU8jJ13/fccWpT/ATmUPgcuK k+Csu+TO8PGmCRyBNyasjp2FDjQ6cdZ0QWIkNL+nE6vkuo8WHimXlRTY/p1FfcfgJw77 56F45oodFpoGj+RMHwrm/oso9eAwGI7HNKdFS04ZzT1Dl6LYrSiPlCI+Tu9v6AdfNo01 MG8DlqovWQHyPCVAoIFBCM4aZsHPWJFf19TJQodeKj9G7fN94BMGYuwI7ekFHJ7b9GXa LmcUNCVAjfqLIVOmox8yTG6IhYL5ef86ZbR/j/j8VUUohaZxhlaRGoG8deaQXsplmYTt Sc2w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1720631118; x=1721235918; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ejuDXxzDzIH7zcxYcOPWRk3uTUuzsIoqRWToUCtONmU=; b=lQuMaPqcLMEkPYPHHo1z8Tog5NVj0cv+aRUzeE3wj8sxlw2Njd0EP5HnV4I8Ir9eqG LOcGk3/HtZHaixuunnTAT2S/yfoZVHKz1eaoXqdlD9Xi3RItmkt6ePXvgy6TRMjqFA2q +2yIIC9X3DBECejJLZqcQkzg6UMpNVbD+GhhQJ6rgjogRCNha723L+rN2StoHRBgqViV oh835Lw5N6Bsrdg8uveTpyf41s/yYdnYi+PuJzq9mK5Cg4CQexolYs+925SZg68SDbL4 g+t055SPucAoIFJnNy04gLQ5BXN0+E2ssF4jx5QE1/FOPxwEnKZ+0pHIP42nE0ML4r0g yH6w== X-Forwarded-Encrypted: i=1; AJvYcCVD09dmR6z1i2lu4lXJS9HFBQd5a1SHCHArT67Sq5PgmzvxfMh0fypUon+94JY9z7YusH6mpDnNDggFjUOfg+Y2fJCF1yqOEvaDNbJBQw== X-Gm-Message-State: AOJu0YzQM/29VF9nghB3g49dRg02GAoKeOjj1DKZHAzkIdDHM8pJHp36 yO6wAJs9ZRviH7GoQYK7ujD5liwegHFUpEDSJn7tQptE8F9bSJrhV9TNTw221+Y= X-Google-Smtp-Source: AGHT+IEdzDMqSpFrgPIKMoDSkhiU2e+ql+AL5vU9wurvK32RxWDhsTOWJlgEkSrVCpO+E3+Am+YAjQ== X-Received: by 2002:ac2:4281:0:b0:52e:9471:e533 with SMTP id 2adb3069b0e04-52eb99d5fb9mr3803124e87.66.1720631118372; Wed, 10 Jul 2024 10:05:18 -0700 (PDT) Received: from [127.0.0.2] ([2a02:2454:ff1f:b240:65e6:93ca:5f80:ea9b]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-367cde7dedfsm5838446f8f.24.2024.07.10.10.05.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 10 Jul 2024 10:05:18 -0700 (PDT) From: Stephan Gerhold Date: Wed, 10 Jul 2024 19:05:00 +0200 Subject: [PATCH 4/5] arm64: dts: qcom: x1e80100-crd: Fix backlight Precedence: bulk X-Mailing-List: linux-arm-msm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20240710-x1e80100-crd-backlight-v1-4-eb242311a23e@linaro.org> References: <20240710-x1e80100-crd-backlight-v1-0-eb242311a23e@linaro.org> In-Reply-To: <20240710-x1e80100-crd-backlight-v1-0-eb242311a23e@linaro.org> To: Neil Armstrong , Bjorn Andersson , Konrad Dybcio Cc: Jessica Zhang , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Douglas Anderson , dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, Abel Vesa , Johan Hovold X-Mailer: b4 0.13.0 The backlight does not work correctly with the current display panel configuration: It works after boot, but once the display gets disabled it is not possible to get it back on. It turns out that the ATNA45AF01 panel needs exactly the same non-standard power sequence as implemented by the panel-samsung-atna33xc20 driver for sc7180-trogdor-homestar. Switch the panel in the DT to the new compatible and make two more changes to make it work correctly: 1. Add the missing GPIO for the panel EL_ON3 line (EDP_BL_EN on CRD and enable-gpios in the DT). 2. Drop the regulator-always-on for the panel regulator. The panel does not seem to power off properly if the regulator stays on. Signed-off-by: Stephan Gerhold --- arch/arm64/boot/dts/qcom/x1e80100-crd.dts | 17 +++++++++++++++-- 1 file changed, 15 insertions(+), 2 deletions(-) diff --git a/arch/arm64/boot/dts/qcom/x1e80100-crd.dts b/arch/arm64/boot/dts/qcom/x1e80100-crd.dts index 6152bcd0bc1f..7d6800dd9b8a 100644 --- a/arch/arm64/boot/dts/qcom/x1e80100-crd.dts +++ b/arch/arm64/boot/dts/qcom/x1e80100-crd.dts @@ -268,7 +268,6 @@ vreg_edp_3p3: regulator-edp-3p3 { pinctrl-0 = <&edp_reg_en>; pinctrl-names = "default"; - regulator-always-on; regulator-boot-on; }; @@ -724,9 +723,13 @@ &mdss_dp3 { aux-bus { panel { - compatible = "edp-panel"; + compatible = "samsung,atna45af01"; + enable-gpios = <&pmc8380_3_gpios 4 GPIO_ACTIVE_HIGH>; power-supply = <&vreg_edp_3p3>; + pinctrl-0 = <&edp_bl_en>; + pinctrl-names = "default"; + port { edp_panel_in: endpoint { remote-endpoint = <&mdss_dp3_out>; @@ -785,6 +788,16 @@ &pcie6a_phy { status = "okay"; }; +&pmc8380_3_gpios { + edp_bl_en: edp-bl-en-state { + pins = "gpio4"; + function = "normal"; + power-source = <1>; /* 1.8V */ + input-disable; + output-enable; + }; +}; + &qupv3_0 { status = "okay"; };