From patchwork Sat Jul 6 03:53:15 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Thorsten Blum X-Patchwork-Id: 811015 Received: from mail-pf1-f180.google.com (mail-pf1-f180.google.com [209.85.210.180]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0BB08E552 for ; Sat, 6 Jul 2024 03:53:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.180 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1720238016; cv=none; b=PCKg3wkdDDx7w4xw6zL3OjSrDHk0+k7CHOBJQA74siK6jn014A16w+hHbjlE9bStJrnRjJ535vXlQ6rS0J9xg5WsbbEGiPxq2NO0z++WFQAoojgRwM3YKLWJmCXhBja7yrLMa7d57FFO35okEKZ0wD4LjViaxTylyswFFdQRZ2Q= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1720238016; c=relaxed/simple; bh=W/CrAXDbeC0SSEXOfQP63UPOyqf4kQHI6MDqovcLp30=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=WmKag/6Gn4E0rKgZnoIXESzc2kun5t9mw8DMv1cS26I6+DJzXG/AluzPrB8IeE8qlJOLzWxqGf3tTfV+bPpuWfaJwKS5UWZ/3NAtTCvIyAwTPBu8mlOdILr9jyRfQWZMMGN9c/n93B2i6XJdLq5YBC7F+QSjofbjdjewQg08Oyw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=toblux.com; spf=none smtp.mailfrom=toblux.com; dkim=pass (2048-bit key) header.d=toblux-com.20230601.gappssmtp.com header.i=@toblux-com.20230601.gappssmtp.com header.b=NnjBJ0uu; arc=none smtp.client-ip=209.85.210.180 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=toblux.com Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=toblux.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=toblux-com.20230601.gappssmtp.com header.i=@toblux-com.20230601.gappssmtp.com header.b="NnjBJ0uu" Received: by mail-pf1-f180.google.com with SMTP id d2e1a72fcca58-70b0d0a7a56so998904b3a.0 for ; Fri, 05 Jul 2024 20:53:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=toblux-com.20230601.gappssmtp.com; s=20230601; t=1720238014; x=1720842814; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=7/QJekGf6J0BGOc8SMTfzQnbLQk7qq4oZoAeuPMHAKg=; b=NnjBJ0uuqLYTUiB60fjJjWACm27o3kuV6yN0Fdomo4Zm3hDd0Ev7R+kqgZJmtv8PR4 Q5DUwE5HQrovLVl7punZ+dMZLLl8wcu80f6TDYdEVCyQqFBlEU66luwPGszxCV+EaBIe JXIl80a66Fogksz9ZutSmB1u/JxBh1LXMhzZUIKRpdo3fzjppDhLYu8XeJT7uEX4dET0 ba6gamagGrUXnm0tqNhFL5nACtVVxtObC2bgnU9hyqmlGBqyu1flOyu/iSFDCIV3T1+e CdcKfAKbVkNH5I2nxt7MTVvh21mM59koEyCWImkalEw1OKlML3bKIkAzc+jGh7h97+H/ KFDw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1720238014; x=1720842814; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=7/QJekGf6J0BGOc8SMTfzQnbLQk7qq4oZoAeuPMHAKg=; b=ESQTQ7rz+g9rZILPKdBk9Q9UUcOsQdWYkpQJfj4gwFd+nRFCQgF/EP3RFieGDv9jmQ y6uKjdGZPJFbdOO36MR9n8w4ieiOQx//ohs/gofZrl0hM71T3A/ifYWTtnTIgoksrAhN QKn0xypQ1+gpvra1Z6g99Ss1k4Bs9wPOm2Ux0ukNBVOMLz0CtX7HXG72W0cb9N8fPqot fRFb/MrhiKTopuYe7UwkVd6Sl/giSLSEUHUmDB5CCnam34nrBaRp3W5JFIQQCDA5bt+v RgDPu1w4U8XVa/xHGUlxNrF9Rwx8fjvLDzy8I8Oc6L28VOUwfNF2RF66q3OhsPqRlMGK 3kPQ== X-Gm-Message-State: AOJu0YzEuQXYzFSkvk+KEIfEcj9h4FCEoFk7slADX+0aPoGUBifpmFxL W9yAOZJfv2gF/2y7mzfPWQA/EQBi71q1FUN5jqDgRpX5OPdx4u2ySn0KfPjev04= X-Google-Smtp-Source: AGHT+IElTiFX17tmBkDLlD8Ps+E21r8HvLYEwZ9QL9A53DZVx3aEu+m+fg9vfnoheFDx/oL/1qSpyA== X-Received: by 2002:a05:6a00:1c81:b0:70b:1d77:730a with SMTP id d2e1a72fcca58-70b1d778ccdmr309693b3a.28.1720238014293; Fri, 05 Jul 2024 20:53:34 -0700 (PDT) Received: from fedora.vc.shawcable.net (S0106c09435b54ab9.vc.shawcable.net. [24.85.107.15]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-70b10abeb23sm1905508b3a.72.2024.07.05.20.53.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 05 Jul 2024 20:53:34 -0700 (PDT) From: Thorsten Blum To: jikos@kernel.org, bentiss@kernel.org Cc: linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, Thorsten Blum Subject: [PATCH] HID: hid-steam: Use clamp() macro Date: Sat, 6 Jul 2024 05:53:15 +0200 Message-ID: <20240706035314.153460-2-thorsten.blum@toblux.com> X-Mailer: git-send-email 2.45.2 Precedence: bulk X-Mailing-List: linux-input@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Use clamp() to actually clamp the value to the range [-32767, 32767] (as mentioned in the function comment) instead of manually mapping one specific value. Compile-tested only. Signed-off-by: Thorsten Blum --- drivers/hid/hid-steam.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/hid/hid-steam.c b/drivers/hid/hid-steam.c index a765a48c0ab5..69dde025999b 100644 --- a/drivers/hid/hid-steam.c +++ b/drivers/hid/hid-steam.c @@ -1340,7 +1340,7 @@ static inline s16 steam_le16(u8 *data) { s16 x = (s16) le16_to_cpup((__le16 *)data); - return x == -32768 ? -32767 : x; + return clamp(x, -32767, 32767); } /*